profile
viewpoint
Ash Furrow ashfurrow @artsy New York https://ashfurrow.com/ Building software with my whole heart. He/him.

ashfurrow/AFTabledCollectionView 553

How to display a UICollectionView within a UITableViewCell

artsy/Swift-at-Artsy 290

Repo for the notes for Swift at Artsy

ashfurrow/AFImageDownloader 88

Downloads JPEG images asynchronously and decompresses them on a background thread.

ashfurrow/Angular 33

Making an Othello/Reversi clone

ashfurrow/AFActivityIndicatorView 25

A ground-up, home-made implementation of UIActivityIndicatorView

ashfurrow/500px-API-Test 22

500px recently opened their API to the public. I want to try it out.

ashfurrow/ARAnalytics 5

Simplify your iOS analytics

ashfurrow/ARTiledImageView 5

Display, pan and deep zoom with tiled images on iOS.

artsy/imessage-sticker-experiment 4

Experimental repo for an iMessages stickers app

push eventartsy/eigen

David Sheldrick

commit sha 4a90fdca0bc090e2d93a535aad2f8f1823ce2869

chore: remove TS SwitchBoard class + purge navRef pattern (#4170) * clean up TS SwitchBoard class * update changelog * goodbye navRef * run yarn relay

view details

push time in 14 minutes

delete branch artsy/eigen

delete branch : ds300/cleanup-switchboard

delete time in 14 minutes

PR merged artsy/eigen

chore: remove TS SwitchBoard class + purge navRef pattern Squash On Green

Description

Follow up from #3771

PR Checklist (tick all before merging)

<!-- 💡 This checklist is experimental. MX warmly welcomes any feedback about the list or how it impacts your workflow -->

  • [x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • [x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • [x] I have documented any follow-up work that this PR will require, or it does not require any.
  • [x] I have added an app state migration, or my changes do not require one. (What are migrations?)
  • [x] I have added a CHANGELOG.yml entry or my changes do not require one.
+443 -885

3 comments

151 changed files

ds300

pr closed time in 14 minutes

pull request commentartsy/eigen

chore: remove TS SwitchBoard class + purge navRef pattern

#squashongreen

ds300

comment created time in 18 minutes

pull request commentartsy/eigen

chore: remove TS SwitchBoard class + purge navRef pattern

🕺🕺🕺 one step closer in the right direction 🎉

ds300

comment created time in 19 minutes

push eventartsy/eigen

Brian Beckerle

commit sha 407a2d998db67735a69a882b2b703604a7a6a540

chore: don't pass email to segment (#4168)

view details

David Sheldrick

commit sha d2f890c062825c1e8a17c3129143d68c857d78e6

fix: device token checking (#4171) * fix token checking * update changelog

view details

Barry Hoggard

commit sha 693041f3a6b5acca7f8dfa86f8f2826640e0337f

feat: respect artwork size when showing price estimates (#4169)

view details

artsyit

commit sha d254edf6cf615a5e149e7e322ed1275676a47cbb

Update metaphysics schema

view details

artsy-peril[bot]

commit sha d823079f4eacdbedb25fa1242df82ce60317cb87

Update metaphysics schema (#4172) Update metaphysics schema

view details

David Sheldrick

commit sha f0c3ea72f6f68e8ea076511cb3a3ef96746d54b0

Merge branch 'master' into ds300/cleanup-switchboard

view details

push time in 21 minutes

created tagartsy/eigen

tag6.7.2-2020.11.25.06

The Art World in Your Pocket or Your Trendy Tech Company's Tote, Artsy's iOS app.

created time in 5 hours

push eventartsy/eigen

Brian Beckerle

commit sha 407a2d998db67735a69a882b2b703604a7a6a540

chore: don't pass email to segment (#4168)

view details

David Sheldrick

commit sha d2f890c062825c1e8a17c3129143d68c857d78e6

fix: device token checking (#4171) * fix token checking * update changelog

view details

Barry Hoggard

commit sha 693041f3a6b5acca7f8dfa86f8f2826640e0337f

feat: respect artwork size when showing price estimates (#4169)

view details

artsyit

commit sha d254edf6cf615a5e149e7e322ed1275676a47cbb

Update metaphysics schema

view details

artsy-peril[bot]

commit sha d823079f4eacdbedb25fa1242df82ce60317cb87

Update metaphysics schema (#4172) Update metaphysics schema

view details

push time in 5 hours

startedashfurrow/xcode-hardware-performance

started time in 10 hours

push eventartsy/eigen

Matt Dole

commit sha 565b3596d4c1e811ee5ab7a85f6ff8d5d000346e

feat: update palette colors

view details

Matt Dole

commit sha 3c4feb2271ed99f9d68ad60a1feab297f5b5ce59

test: fix tests expecting hardcoded colors

view details

Matt Dole

commit sha fa426b13e04c3433f63b6d601696d6c102eb1cae

docs: changelog

view details

Matt Dole

commit sha cbf2254d2f64c0a7187d38c52b6b44cdb87453c0

unknown: podfile.lock

view details

push time in 13 hours

Pull request review commentartsy/eigen

chore: update colors

 SPEC CHECKSUMS:   CocoaLibEvent: 2fab71b8bd46dd33ddb959f7928ec5909f838e3f   CocoaLumberjack: aa9dcab71bdf9eaf2a63bbd9ddc87863efe45457   DHCShakeNotifier: 64048427ecaa763f2472d0032f58bf7a10074eee-  DoubleConversion: cde416483dac037923206447da6e1454df403714+  DoubleConversion: 5805e889d232975c086db112ece9ed034df7a0b2

👋 mobile noob here - I'm not sure what caused this or if it belongs in this PR! any pointers?

mdole

comment created time in 13 hours

pull request commentartsy/eigen

chore: update colors

<!-- 0 failure: 1 warning: Please assign som...

DangerID: danger-id-Peril; -->

<table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Warnings</th> </tr> </thead> <tbody><tr> <td>:warning:</td> <td>Please assign someone to merge this PR, and optionally include people who should review.</td> </tr> </tbody> </table>

<p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against 79c5affb61741fb318eaddf034f8036964420a1e </p>

mdole

comment created time in 13 hours

PR opened artsy/eigen

chore: update colors

The type of this PR is: Chore

Description

Updating colors in Palette, so needed to update here too! (Thanks @zephraph for working towards a unified tokens package 😉) https://github.com/artsy/palette/pull/819

PR Checklist (tick all before merging)

  • [?] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • [x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • [x] I have documented any follow-up work that this PR will require, or it does not require any.
  • [x] I have added an app state migration, or my changes do not require one. (What are migrations?)
  • [x] I have added a CHANGELOG.yml entry or my changes do not require one.
+27 -14

0 comment

4 changed files

pr created time in 13 hours

push eventartsy/eigen

Matt Dole

commit sha ec7e79bfaf6acfcfd129c0848ef4c172be3c7972

feat: update palette colors

view details

Matt Dole

commit sha 2612d3fd63ad73357cb4681acbfa21e7b8f70033

test: fix tests expecting hardcoded colors

view details

Matt Dole

commit sha f1ef59df1acec3db9b4fd98f6b9200f689bafb15

docs: changelog

view details

Matt Dole

commit sha 79c5affb61741fb318eaddf034f8036964420a1e

unknown: podfile.lock

view details

push time in 13 hours

push eventartsy/eigen

artsyit

commit sha d254edf6cf615a5e149e7e322ed1275676a47cbb

Update metaphysics schema

view details

artsy-peril[bot]

commit sha d823079f4eacdbedb25fa1242df82ce60317cb87

Update metaphysics schema (#4172) Update metaphysics schema

view details

push time in 13 hours

delete branch artsy/eigen

delete branch : update-schema

delete time in 13 hours

PR merged artsy/eigen

Update metaphysics schema Merge On Green

Greetings human :robot: this PR was automatically created as part of metaphysics' deploy process.

+17 -0

0 comment

1 changed file

artsyit

pr closed time in 13 hours

create barnchartsy/eigen

branch : update-schema

created branch time in 13 hours

PR opened artsy/eigen

Update metaphysics schema

Greetings human :robot: this PR was automatically created as part of metaphysics' deploy process.

+17 -0

0 comment

1 changed file

pr created time in 13 hours

issue commentashfurrow/danger-ruby-swiftlint

--strict mode not working, even with via `additional_swiftlint_args`

I have the same problem. I wrote like the following in Dangerfile:

swiftlint.lint_files inline_mode: true, fail_on_error: true, additional_swiftlint_args: '--strict'
Jeehut

comment created time in 13 hours

push eventartsy/eigen

Matt Dole

commit sha 3fb71f51993c662dba81afeace763c5cd74049cd

docs: changelog

view details

push time in 15 hours

startedobsidiansystems/nix-thunk

started time in 15 hours

push eventartsy/eigen

Matt Dole

commit sha d58a9714e43d38ede23f4ddca6c37dbd2039cffd

test: fix tests expecting hardcoded colors

view details

push time in 15 hours

create barnchartsy/eigen

branch : update-colors

created branch time in 15 hours

push eventartsy/eigen

Erik

commit sha b7beb6adc22c0e92a960158f43c411b8afa9948e

split old and new inboxes (#4160)

view details

push time in 16 hours

delete branch artsy/eigen

delete branch : erikdstock/move-my-bids

delete time in 16 hours

PR merged artsy/eigen

Reviewers
chore: split old and new inboxes

This is a PR to your development branch @lilyfromseattle - totally your call on whether to incorporate it, and I'm not sure if it would be considered best practice or not so tagging some others as well. I was thinking about the sort of complicated display logic in our Inbox component and in particular how we are fetching both the old lotStandings (from gravity) and the new auctionsLotStandingConnection* and wondered if we can separate these out, so I made a PR to do that.

In short, I split Inbox.tsx into a directory with Inbox & InboxOld (the version of Inbox.tsx currently on master) plus an InboxWrapper (which checks the AREmissionOptions to decide which to display.

As a side benefit we are working with a new single component now so can iterate on it without worrying about breaking old functionality, and when we do switch over completely we can just delete the OldInbox + wrapper files and move back to a single-file module.

*side note- if this isn't the best way to go about it we will want to change the hadBids logic in some other way, since the two queries for lot standings return different results.

+2436 -1306

2 comments

13 changed files

erikdstock

pr closed time in 16 hours

startedsbz/freebsd-commands

started time in 17 hours

push eventartsy/README

Joey Aghion

commit sha ea58944d860da95a4c0aa92e2ad251a1d3b1355b

Update hokusai configure command for new k8s version

view details

push time in 17 hours

push eventartsy/eigen

Barry Hoggard

commit sha 693041f3a6b5acca7f8dfa86f8f2826640e0337f

feat: respect artwork size when showing price estimates (#4169)

view details

push time in 18 hours

more