profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/ascorbic/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Matt Kane ascorbic @VelaLabs @netlify UK mk.gg Principal engineer @netlify

ascorbic/clevrlib 15

CLEVR Actionscript Library

ascorbic/canvas-paint-tool 12

Realistic canvas paint tool

ascorbic/airbed 6

Lightweight CouchDB client library for Adobe AIR

ascorbic/actionscript3-tmbundle 2

ActionScript 3 TextMate Bundle

ascorbic/babel-jsx-utils 2

Utilities for working with Babel and JSX

ascorbic/adas-bake 1

Gatsby starter for a Contentful project.

ascorbic/core-plot 1

Unofficial core-plot mirror

push eventascorbic/cna-test

Matt Kane

commit sha b7114a2db30048e31a544db56174188f26b5ea1e

Included files in config

view details

push time in 2 days

issue commentnetlify/netlify-plugin-nextjs

Static files are not correclty served with `netlify dev`

This is possibly caused by https://github.com/netlify/cli/issues/2990

guhur

comment created time in 2 days

issue openednetlify/cli

Rewrites do not work in `dev` when characters are urelencoded

Describe the bug

When a wildcard rewrite is added, files are not found if there are urlencoded characters in the requested URL.

To Reproduce

  1. Add the following redirect:
/_next/static/* /static/:splat 200
  1. Create a file in /static/ that needs URL-encoding. e.g. static/special[test].txt
  2. Run ntl dev
  3. Add a link to /_next/static/special[test].txt and it will load fine.
  4. Add a link to /_next/static/special%5Btest%5D.txt and it will not be found.

It loads fine when deployed.

Repo here: https://github.com/ascorbic/redirect-demo

Expected behavior

An encoded URL should load the same as one without encoding.

created time in 2 days

create barnchascorbic/redirect-demo

branch : main

created branch time in 2 days

created repositoryascorbic/redirect-demo

created time in 2 days

push eventascorbic/cna-test

Matt Kane

commit sha 0ed3843eab5456ed1c6701c0ed0e01852c5e8600

Included files in config

view details

push time in 2 days

push eventascorbic/cna-test

Matt Kane

commit sha c7e278574cdb4c39ddae29ad17068b83a4e43538

Use private dir

view details

Matt Kane

commit sha 246729347d9ef161a91da2eb68ecd2cb9151499f

Add redirect

view details

push time in 2 days

issue commentnetlify/build

Set `process.env.NETLIFY` to true when running build command

Ah, in that case if there's a good reason to not set it locally, having a separate local var that can be checked-for might be a good alternative. So if setting NETLIFY has unwanted side-effects, then NETLIFY_LOCAL could be used and if a framework wants to know it can check for both.

ascorbic

comment created time in 3 days

issue openednetlify/build

Set `process.env.NETLIFY` to true when running build command

Is your feature request related to a problem? Please describe.

Some frameworks detect when they are being compiled by Netlify to enable Netlify-specific configuration. This can be done by looking for the NETLIFY env var for builds, but this is not set locally, meaning local builds and deploys may miss these.

Describe the solution you'd like

Set NETLIFY to "true" when running build or deploy --build via the cli. It may also be useful to have an additional NETLIFY_LOCAL var.

Describe alternatives you've considered

Setting the value in a build plugin or toml. This is not ideal, as it stops it from being zero-config. Adding it as an env var in framework-info, though this would need to be done for every framework that needed it. Using other ways of detecting that the build is being run via ntl. These are likely to be fragile.

Additional context

The example that inspired this is Nuxt 3, which enables zero-config integrations when it detects the Netlify environment.

created time in 3 days

issue openednetlify/cli

Set `process.env.NETLIFY` to true when running build command

Is your feature request related to a problem? Please describe.

Some frameworks detect when they are being compiled by Netlify to enable Netlify-specific configuration. This can be done by looking for the NETLIFY env var for builds, but this is not set locally, meaning local builds and deploys may miss these.

Describe the solution you'd like

Set NETLIFY to "true" when running build or deploy --build via the cli. It may also be useful to have an additional NETLIFY_LOCAL var.

Describe alternatives you've considered

Setting the value in a build plugin or toml. This is not ideal, as it stops it from being zero-config. Adding it as an env var in framework-info, though this would need to be done for every framework that needed it. Using other ways of detecting that the build is being run via ntl. These are likely to be fragile.

Additional context

The example that inspired this is Nuxt 3, which enables zero-config integrations when it detects the Netlify environment.

created time in 3 days

push eventnetlify/netlify-plugin-nextjs

renovate[bot]

commit sha 6a21507be6b7d07bfc4cef5b59cd3db94b6e2e8e

chore(deps): update dependency netlify-cli to ^5.2.0 (#548) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Matt Kane

commit sha 7445a3fdcfc653a138fe8ec366fe30e37c40bc7b

Merge branch 'main' into release-v4.0.0

view details

push time in 3 days

issue openednetlify/zip-it-and-ship-it

Allow `.mjs` entrypoints for functions

- Do you want to request a feature or report a bug?

Feature

- What is the current behavior?

While zisi can bundle ESM files with.mjs extensions, it does not recognize them as entrypoints.

- If the current behavior is a bug, please provide the steps to reproduce.

  1. Create a function in netlify/functions/hello/hello.mjs
  2. Run zip-it-and-ship-it netlify/functions out_functions

- What is the expected behavior? The function hello is bundled, defaulting to esbuild

created time in 3 days

pull request commentnetlify/build

feat: add support for feature-flagging plugin versions

Is there anything blocking this from being merged?

eduardoboucas

comment created time in 3 days

pull request commentunjs/ipx

feat: default to not upscaling images

@pi0 Does this look like the right approach to you?

ascorbic

comment created time in 3 days

push eventnetlify/netlify-plugin-nextjs

renovate[bot]

commit sha 6a21507be6b7d07bfc4cef5b59cd3db94b6e2e8e

chore(deps): update dependency netlify-cli to ^5.2.0 (#548) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Matt Kane

commit sha 9893a29a64b0927dee3902179aca8b32cbaa90b3

Merge branch 'main' into feat/internal-functions

view details

push time in 3 days

issue openednetlify/build

Function bundling should warn not fail if functions dir is missing

Is your feature request related to a problem? Please describe.

If a functions dir is specified in a site config, but that dir is not found then function bundling does not happen. This was fine previously (as there were no functions to bundle). However now that internal functions are also bundled, then this means that internal function bundling is skipped.

Describe the solution you'd like

A warning should be logged, but internal functions should still be bundled.

Describe alternatives you've considered

The functions dir could be removed from the config. However it is added by default when running init, and many sites will be migrating from the old setup where they needed to have a local functions dir.

Additional context

We cannot start using the internal functions dir in build plugins until this is fixed, as they silently fail.

created time in 4 days

issue commentnetlify/cli

Add a `netlify clean` command

what do you mean by Netlify cache? Is it everything under <project-dir>/.netlify except the state.json file?

@erezrokah Yes, exactly that.

I think it's simplest to just have 1. Clears .netlify cache by default, and runs framework-specific clean commands if implemented, and/or a command in the toml

ascorbic

comment created time in 4 days

issue openednetlify/cli

Function bundling should warn not fail if functions dir is missing

Is your feature request related to a problem? Please describe.

If a functions dir is specified in a site config, but that dir is not found then function bundling does not happen. This was fine previously (as there were no functions to bundle). However now that internal functions are also bundled, then this means that internal function bundling is skipped.

Describe the solution you'd like

A warning should be logged, but internal functions should still be bundled.

Describe alternatives you've considered

The functions dir could be removed from the config. However it is added by default when running init, and many sites will be migrating from the old setup where they needed to have a local functions dir.

Additional context

We cannot start using the internal functions dir in build plugins until this is fixed, as they silently fail.

created time in 4 days

push eventnetlify/netlify-plugin-nextjs

Matt Kane

commit sha 0397c121b3ae9db20fdaf1d278b36777fa96527b

fix: update test

view details

push time in 4 days

PR opened netlify/netlify-plugin-nextjs

feat: use internal functions dir

Use the new internal functions directory if available. If so, also warn if there are existing generated functions in the old directory that need removing.

+10460 -208

0 comment

4 changed files

pr created time in 4 days

push eventnetlify/netlify-plugin-nextjs

Matt Kane

commit sha 5d11eaf59e38e1088f8b8d9ea23f34c29ac92a13

feat: use internal functions dir

view details

push time in 4 days

push eventnetlify/netlify-plugin-nextjs

renovate[bot]

commit sha ea7ab47faecb24f0922f9368f4ea8dee47f1e2e7

chore(deps): update dependency netlify-cli to ^4.4.3 (#542) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Matt Kane

commit sha 4de9f1eaba72fa2d3d2d41d375f0c2f894bc2482

fix: handle workspace commands

view details

renovate[bot]

commit sha 1b7558b9119dfc87f7e56a4ff3a63e72dc3423a9

chore(deps): update dependency @netlify/eslint-config-node to ^3.1.8 (#543) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 66624cb03f01bbf4aee7e38e0d533029dfa0f0ad

chore(deps): update dependency netlify-cli to ^4.4.4 (#544) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 4a69dccbe5779bb48cdb1e1761f1c314374ca96e

chore(deps): update dependency netlify-cli to v5 (#545) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Matt Kane

commit sha e3e7cd1c863d48eeea77e5c4197b80db8392243d

feat: add NEXT_PLUGIN_FORCE_RUN to skip auto-detection (#547) * feat: add NEXT_PLUGIN_FORCE_RUN to skip auto-detection * chore: add tests * chore: add plugin removal info

view details

Matt Kane

commit sha 04dec684e85db6c7d4b33ec8940e9993b359d188

feat: wip

view details

Matt Kane

commit sha 72d4c8899b387a97badb091a7e58496e94486de6

fix: use internal funcs constant

view details

push time in 4 days

create barnchnetlify/netlify-plugin-nextjs

branch : feat/internal-functions

created branch time in 4 days

push eventnetlify/netlify-plugin-nextjs

Matt Kane

commit sha e3e7cd1c863d48eeea77e5c4197b80db8392243d

feat: add NEXT_PLUGIN_FORCE_RUN to skip auto-detection (#547) * feat: add NEXT_PLUGIN_FORCE_RUN to skip auto-detection * chore: add tests * chore: add plugin removal info

view details

push time in 4 days

delete branch netlify/netlify-plugin-nextjs

delete branch : feat/static-env-var

delete time in 4 days

PR merged netlify/netlify-plugin-nextjs

feat: add NEXT_PLUGIN_FORCE_RUN to skip auto-detection type: feature

This PR adds support for an env var NEXT_PLUGIN_FORCE_RUN, which skips autodetection and forces the plugin to either always run (if set to "true" or "1") or never run (if set to "false" or "0")

Fixes #546

+65 -14

0 comment

4 changed files

ascorbic

pr closed time in 4 days

issue closednetlify/netlify-plugin-nextjs

Allow static site export to be set via env var

We currently use several heuristics to detect if a site is actually a static export, so we can disable the plugin. However it's not 100% effective, and we have some false positives and negatives. We should add an env var such as NEXT_STATIC_EXPORT which overrides the detection and sets it to either true or false.

closed time in 4 days

ascorbic

Pull request review commentnetlify/netlify-plugin-nextjs

feat: add NEXT_PLUGIN_FORCE_RUN to skip auto-detection

 const usesBuildCommand = ({ build, scripts, command }) => {     return raw.some((script) => script.includes(command))   } catch (error) {     console.error(-      'There was an error parsing your build command:',-      error.message,-      `\n\nThe build command is "${build.command}" and the available npm scripts are: ${Object.keys(scripts)+      `Static export detection disabled because we could not parse your build command: ${error.message}+The build command is "${build.command}" and the available npm scripts are: ${Object.keys(scripts)         .map((script) => `"${script}"`)-        .join(', ')}`,+        .join(', ')}++If the site does use static export then you can set the env var NEXT_PLUGIN_FORCE_RUN to "false"`,

Done

ascorbic

comment created time in 4 days

PullRequestReviewEvent