profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/asbachb/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Benjamin Asbach asbachb Code Passionist Around the world https://www.impl.it

asbachb/ftp4j 42

ftp4j is a java implementation of the ftp, ftps and ftpes protocol provided as maven artifact

asbachb/grademasterflash 3

With grademaster you can calculate your bachelor or master grade // Mit grademaster kannst du den Notendurschnitt deines Bachelor bzw. Masterstudiums berechnen

asbachb/jd-dependency-decompiler-maven-plugin 3

dependency decompiler for maven based on jd

asbachb/acbuild 0

a build tool for ACIs

asbachb/alpine-package-sync 0

A bash script which syncs apline linux package repository and create subdirectories for a new sync

asbachb/ArchUnit 0

A Java architecture test library, to specify and assert architecture rules in plain Java

asbachb/aur-jenkins-lts 0

https://aur.archlinux.org/packages/jenkins-lts/

pull request commentNixOS/nixpkgs

openjdk17: init at 17+35

Just FYI there's a new release of java 17.0.1: https://github.com/openjdk/jdk17u/tags

Uthar

comment created time in 6 days

issue commentcontainers/podman

Use hosts public ip address in /etc/hosts for rootless containers

I think the routing problem is a firewall problem.

These pastes are from a vm without firewall.

asbachb

comment created time in 7 days

issue openedcontainers/podman

Use hosts public ip address in /etc/hosts for rootless containers

Follow up to #8466

root@d9e153cabee0:/# cat /etc/hosts 
127.0.0.1	localhost
127.0.1.1	vm-virtualbox

# The following lines are desirable for IPv6 capable hosts
::1     ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters
# used by slirp4netns
10.0.2.100	d9e153cabee0 jolly_borg
10.0.2.2 host.containers.internal

But the container does not seem to be able to route to the host:

vm@vm-virtualbox:~$ python3 -m http.server 8000
Serving HTTP on 0.0.0.0 port 8000 (http://0.0.0.0:8000/) ...
root@d9e153cabee0:/# curl http://127.0.1.1:8000
curl: (7) Failed to connect to 127.0.1.1 port 8000: Connection refused
root@d9e153cabee0:/# curl http://10.0.2.2:8000
curl: (7) Failed to connect to 10.0.2.2 port 8000: Network is unreachable

created time in 9 days

issue commentcontainers/podman

Support '--add-host=host.docker.internal:host-gateway'

@mheon any details how to use this? I saw there's a "route" in /etc/hosts:

root@d9e153cabee0:/# cat /etc/hosts 
127.0.0.1	localhost
127.0.1.1	vm-virtualbox

# The following lines are desirable for IPv6 capable hosts
::1     ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters
# used by slirp4netns
10.0.2.100	d9e153cabee0 jolly_borg
10.0.2.2 host.containers.internal

But the container does not seem to be able to route to the host:

vm@vm-virtualbox:~$ python3 -m http.server 8000
Serving HTTP on 0.0.0.0 port 8000 (http://0.0.0.0:8000/) ...
curl: (7) Failed to connect to 127.0.1.1 port 8000: Connection refused
root@d9e153cabee0:/# curl http://10.0.2.100:8000
djmattyg007

comment created time in 9 days

pull request commentrevelc/xml-formatter

Pass `lineDelimiter` as parameter of `format` instead during instantiation

The basic idea seems sound, but this particular change is broken, as the FormatterTest does not compile with these changes.

It would be good to preserve the existing constructors, which allow specifying a default line delimiter, as well as the existing format method signature. A new format method can be provided to override the default delimiter that is passed in the constructor.

@ctubbsii If we'd introduce the default constructor and formatter-maven-plugin applies the change without code the configuration for line ending would be totally broken. So not providing the previous interface was kind of on purpose.

Alternatively we might move the setting to FormattingPreferences and provide a getter for the preferences to modify it afterwards. In the end we need a possibility for formatter-maven-plugin to change the line ending after initialization of XMLFormatter. I agree that this PR might be a quick & dirty solution which might need a little bit more brain work.

asbachb

comment created time in 12 days

push eventasbachb/xml-formatter

Benjamin Asbach

commit sha 3c633f144f342ae1625fc7e31e342cb6996fe44c

Pass `lineDelimiter` as parameter of `format` instead during instantiation The previous behavior was problematic, as `formatter-maven-plugin` has an option to `KEEP` file line endings. So the line ending is not known when the formatter is instantiated and so the option creates weird behavior like inserting `null` in xml.

view details

push time in 12 days

pull request commentrevelc/xml-formatter

Pass `lineDelimiter` as parameter of `format` instead during instantiation

I need to double check. Maybe I missed something to commit.

asbachb

comment created time in 15 days

Pull request review commentapache/netbeans

NETBEANS-5956: Adding default java trust store to xml retriever

 public void checkServerTrusted(X509Certificate[] certs, String authType)                 }             }         };+        TrustManager[] combinedTrustManagers = (TrustManager[]) Stream.of(defaultTrustManagers, trustAllCerts)+                .flatMap(Stream::of)+                .toArray(size -> new TrustManager[size]);++        KeyManager[] keyManagersFromSystemProperties = null;+        try {+            KeyStore keyStoreFromSystemProperties = null;+            char[] keyStorePassword = System.getProperty("javax.net.ssl.keyStorePassword", "").toCharArray();+            if (System.getProperty("javax.net.ssl.keyStore") != null) {+                File keyStoreFile = new File(System.getProperty("javax.net.ssl.keyStore"));+                if (keyStoreFile.exists()) {+                    KeyStore keyStore = KeyStore.getInstance(System.getProperty("javax.net.ssl.keyStoreType", KeyStore.getDefaultType()));+                    try ( InputStream keyStoreStream = new FileInputStream(keyStoreFile)) {+                        keyStore.load(keyStoreStream, keyStorePassword);+                    } -        // #208324: proper key managers need to be passed, so let's configure at least the defaults...-        KeyManager[] mgrs;-        if (System.getProperty("javax.net.ssl.keyStorePassword") != null &&  // NOI18N-            System.getProperty("javax.net.ssl.keyStore") != null) { // NOI18N-            try {-                KeyStore ks = KeyStore.getInstance("JKS"); // NOI18N-                    ks.load(new FileInputStream(System.getProperty("javax.net.ssl.keyStore")), //NOI18N-                    System.getProperty("javax.net.ssl.keyStorePassword").toCharArray() //NOI18N-                );-                // Set up key manager factory to use our key store-                KeyManagerFactory kmf = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());-                kmf.init(ks,System.getProperty("javax.net.ssl.keyStorePassword").toCharArray()); // NOI18N-                mgrs = kmf.getKeyManagers();-            } catch (IOException ex) {-                // this is somewhat expected, i.e. JKS file not present-                mgrs = null;-            } catch (java.security.GeneralSecurityException e) {-                ErrorManager.getDefault().notify(e);-                return;+                    keyStoreFromSystemProperties = keyStore;+                }             }-        } else {-            mgrs = null;++            KeyManagerFactory keyManagerFactory = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());+            keyManagerFactory.init(keyStoreFromSystemProperties, keyStorePassword);+            keyManagersFromSystemProperties = keyManagerFactory.getKeyManagers();+        } catch (GeneralSecurityException | IOException ex) {+            keyManagersFromSystemProperties = new KeyManager[0];         }+         try {             SSLContext sslContext = SSLContext.getInstance("SSL"); //NOI18N-            sslContext.init(mgrs, trustAllCerts, new java.security.SecureRandom());+            sslContext.init(keyManagersFromSystemProperties, combinedTrustManagers, new java.security.SecureRandom());             con.setSSLSocketFactory(sslContext.getSocketFactory());-            con.setHostnameVerifier(new HostnameVerifier() {-                public boolean verify(String string, SSLSession sSLSession) {-                    // accept all hosts-                    return true;-                }-            });-        } catch (java.security.GeneralSecurityException e) {+            con.setHostnameVerifier(this::acceptAllHosts);+        } catch (GeneralSecurityException e) {             ErrorManager.getDefault().notify(e);         }     }-    ++    private boolean acceptAllHosts(String host, SSLSession sslSession) {+        return true;

Created a follow up: https://issues.apache.org/jira/browse/NETBEANS-6121

asbachb

comment created time in 17 days

PullRequestReviewEvent

delete branch asbachb/incubator-netbeans

delete branch : NETBEANS-5956

delete time in 17 days

pull request commentapache/netbeans

NETBEANS-5956: Adding default java trust store to xml retriever

@matthiasblaesing Surely I agree. Happy to contribute to my favourite IDE.

asbachb

comment created time in 17 days

Pull request review commentapache/netbeans

NETBEANS-5956: Adding default java trust store to xml retriever

 public void checkServerTrusted(X509Certificate[] certs, String authType)                 }             }         };+        TrustManager[] combinedTrustManagers = (TrustManager[]) Stream.of(defaultTrustManagers, trustAllCerts)+                .flatMap(Stream::of)+                .toArray(size -> new TrustManager[size]);++        KeyManager[] keyManagersFromSystemProperties = null;+        try {+            KeyStore keyStoreFromSystemProperties = null;+            char[] keyStorePassword = System.getProperty("javax.net.ssl.keyStorePassword", "").toCharArray();+            if (System.getProperty("javax.net.ssl.keyStore") != null) {+                File keyStoreFile = new File(System.getProperty("javax.net.ssl.keyStore"));+                if (keyStoreFile.exists()) {+                    KeyStore keyStore = KeyStore.getInstance(System.getProperty("javax.net.ssl.keyStoreType", KeyStore.getDefaultType()));+                    try ( InputStream keyStoreStream = new FileInputStream(keyStoreFile)) {+                        keyStore.load(keyStoreStream, keyStorePassword);+                    } -        // #208324: proper key managers need to be passed, so let's configure at least the defaults...-        KeyManager[] mgrs;-        if (System.getProperty("javax.net.ssl.keyStorePassword") != null &&  // NOI18N-            System.getProperty("javax.net.ssl.keyStore") != null) { // NOI18N-            try {-                KeyStore ks = KeyStore.getInstance("JKS"); // NOI18N-                    ks.load(new FileInputStream(System.getProperty("javax.net.ssl.keyStore")), //NOI18N-                    System.getProperty("javax.net.ssl.keyStorePassword").toCharArray() //NOI18N-                );-                // Set up key manager factory to use our key store-                KeyManagerFactory kmf = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());-                kmf.init(ks,System.getProperty("javax.net.ssl.keyStorePassword").toCharArray()); // NOI18N-                mgrs = kmf.getKeyManagers();-            } catch (IOException ex) {-                // this is somewhat expected, i.e. JKS file not present-                mgrs = null;-            } catch (java.security.GeneralSecurityException e) {-                ErrorManager.getDefault().notify(e);-                return;+                    keyStoreFromSystemProperties = keyStore;+                }             }-        } else {-            mgrs = null;++            KeyManagerFactory keyManagerFactory = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());+            keyManagerFactory.init(keyStoreFromSystemProperties, keyStorePassword);+            keyManagersFromSystemProperties = keyManagerFactory.getKeyManagers();+        } catch (GeneralSecurityException | IOException ex) {+            keyManagersFromSystemProperties = new KeyManager[0];         }+         try {             SSLContext sslContext = SSLContext.getInstance("SSL"); //NOI18N-            sslContext.init(mgrs, trustAllCerts, new java.security.SecureRandom());+            sslContext.init(keyManagersFromSystemProperties, combinedTrustManagers, new java.security.SecureRandom());             con.setSSLSocketFactory(sslContext.getSocketFactory());-            con.setHostnameVerifier(new HostnameVerifier() {-                public boolean verify(String string, SSLSession sSLSession) {-                    // accept all hosts-                    return true;-                }-            });-        } catch (java.security.GeneralSecurityException e) {+            con.setHostnameVerifier(this::acceptAllHosts);+        } catch (GeneralSecurityException e) {             ErrorManager.getDefault().notify(e);         }     }-    ++    private boolean acceptAllHosts(String host, SSLSession sslSession) {+        return true;

@matthiasblaesing friendly reminder.

asbachb

comment created time in 17 days

PullRequestReviewEvent

PR opened revelc/xml-formatter

Pass `lineDelimiter` as parameter of `format` instead during instantiation

The previous behavior was problematic, as formatter-maven-plugin has an option to KEEP file line endings. So the line ending is not known when the formatter is instantiated and so the option creates weird behaviors like inserting null in xml.

+6 -12

0 comment

1 changed file

pr created time in 17 days

push eventasbachb/xml-formatter

Benjamin Asbach

commit sha af4a3b5d3b87ada37c9640655cf25c6b67e86acc

Pass `lineDelimiter` as parameter of `format` instead during instantiation The previous behavior was problematic, as `formatter-maven-plugin` has an option to `KEEP` file line endings. So the line ending is not known when the formatter is instantiated and so the option creates weird behavior like inserting `null` in xml.

view details

push time in 17 days

push eventasbachb/xml-formatter

Benjamin Asbach

commit sha df2522e3af9ac0e4f42f5bc655aa32ecc60ac723

Pass `lineDelimiter` as parameter of `format` instead of configuring it during instantiation The previous behaviour was problematic, as `formatter-maven-plugin` has an option to `KEEP` file line endings. So the line ending is not known when the formatter is instantiated and so the option creates weird behaviours like inserting `null` in xml.

view details

push time in 17 days

fork asbachb/xml-formatter

XML formatter for use with net.revelc formatter-maven-plugin

fork in 17 days

pull request commentjboss-dockerfiles/wildfly

WildFly 25.0.0.Final

Maybe not 100% related. But do you plan do publish preview package as well?

jmesnil

comment created time in 19 days

issue commentNixOS/nixpkgs

Packaging request: Daedalus wallet

Maybe we can work on a workaround to add this to a local installation without having it in nixpkgs repos.

jluttine

comment created time in 19 days

issue commentjboss-dockerfiles/wildfly

Please update Dockerhub to WildFly 24.0.1.Final

Seems that WildFly 25 was released, but no official docker image is available.

p1ngod

comment created time in 19 days

issue commentNixOS/nixpkgs

lxd: Unable to creat a virtual machine

@Artturin Now it's taking way longer for the error message to appear:

DBUG[10-05|22:32:24] Got response struct from LXD
DBUG[10-05|22:32:24]
	{
		"id": "48ba40f0-fc60-46c4-9fa1-f657a884c3e8",
		"class": "task",
		"description": "Creating instance",
		"created_at": "2021-10-05T22:32:24.038155887-06:00",
		"updated_at": "2021-10-05T22:32:24.038155887-06:00",
		"status": "Running",
		"status_code": 103,
		"resources": {
			"instances": [
				"/1.0/instances/ubuntu-vm"
			]
		},
		"metadata": null,
		"may_cancel": false,
		"err": "",
		"location": "none"
	}
Error: Failed instance creation: Failed creating instance record: Instance type "virtual-machine" is not supported on this server
asbachb

comment created time in 20 days

Pull request review commentapache/netbeans

NETBEANS-5956: Adding default java trust store to xml retriever

 public void checkServerTrusted(X509Certificate[] certs, String authType)                 }             }         };+        TrustManager[] combinedTrustManagers = (TrustManager[]) Stream.of(defaultTrustManagers, trustAllCerts)+                .flatMap(Stream::of)+                .toArray(size -> new TrustManager[size]);++        KeyManager[] keyManagersFromSystemProperties = null;+        try {+            KeyStore keyStoreFromSystemProperties = null;+            char[] keyStorePassword = System.getProperty("javax.net.ssl.keyStorePassword", "").toCharArray();+            if (System.getProperty("javax.net.ssl.keyStore") != null) {+                File keyStoreFile = new File(System.getProperty("javax.net.ssl.keyStore"));+                if (keyStoreFile.exists()) {+                    KeyStore keyStore = KeyStore.getInstance(System.getProperty("javax.net.ssl.keyStoreType", KeyStore.getDefaultType()));+                    try ( InputStream keyStoreStream = new FileInputStream(keyStoreFile)) {+                        keyStore.load(keyStoreStream, keyStorePassword);+                    } -        // #208324: proper key managers need to be passed, so let's configure at least the defaults...-        KeyManager[] mgrs;-        if (System.getProperty("javax.net.ssl.keyStorePassword") != null &&  // NOI18N-            System.getProperty("javax.net.ssl.keyStore") != null) { // NOI18N-            try {-                KeyStore ks = KeyStore.getInstance("JKS"); // NOI18N-                    ks.load(new FileInputStream(System.getProperty("javax.net.ssl.keyStore")), //NOI18N-                    System.getProperty("javax.net.ssl.keyStorePassword").toCharArray() //NOI18N-                );-                // Set up key manager factory to use our key store-                KeyManagerFactory kmf = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());-                kmf.init(ks,System.getProperty("javax.net.ssl.keyStorePassword").toCharArray()); // NOI18N-                mgrs = kmf.getKeyManagers();-            } catch (IOException ex) {-                // this is somewhat expected, i.e. JKS file not present-                mgrs = null;-            } catch (java.security.GeneralSecurityException e) {-                ErrorManager.getDefault().notify(e);-                return;+                    keyStoreFromSystemProperties = keyStore;+                }             }-        } else {-            mgrs = null;++            KeyManagerFactory keyManagerFactory = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());+            keyManagerFactory.init(keyStoreFromSystemProperties, keyStorePassword);+            keyManagersFromSystemProperties = keyManagerFactory.getKeyManagers();+        } catch (GeneralSecurityException | IOException ex) {+            keyManagersFromSystemProperties = new KeyManager[0];         }+         try {             SSLContext sslContext = SSLContext.getInstance("SSL"); //NOI18N-            sslContext.init(mgrs, trustAllCerts, new java.security.SecureRandom());+            sslContext.init(keyManagersFromSystemProperties, combinedTrustManagers, new java.security.SecureRandom());             con.setSSLSocketFactory(sslContext.getSocketFactory());-            con.setHostnameVerifier(new HostnameVerifier() {-                public boolean verify(String string, SSLSession sSLSession) {-                    // accept all hosts-                    return true;-                }-            });-        } catch (java.security.GeneralSecurityException e) {+            con.setHostnameVerifier(this::acceptAllHosts);+        } catch (GeneralSecurityException e) {             ErrorManager.getDefault().notify(e);         }     }-    ++    private boolean acceptAllHosts(String host, SSLSession sslSession) {+        return true;

@matthiasblaesing Maybe it makes more sense to open up a up a follow up bug to change this behavior?

asbachb

comment created time in 21 days

PullRequestReviewEvent

Pull request review commentapache/netbeans

NETBEANS-5956: Adding default java trust store to xml retriever

 public void checkServerTrusted(X509Certificate[] certs, String authType)                 }             }         };+        TrustManager[] combinedTrustManagers = (TrustManager[]) Stream.of(defaultTrustManagers, trustAllCerts)+                .flatMap(Stream::of)+                .toArray(size -> new TrustManager[size]);++        KeyManager[] keyManagersFromSystemProperties = null;+        try {+            KeyStore keyStoreFromSystemProperties = null;+            char[] keyStorePassword = System.getProperty("javax.net.ssl.keyStorePassword", "").toCharArray();+            if (System.getProperty("javax.net.ssl.keyStore") != null) {+                File keyStoreFile = new File(System.getProperty("javax.net.ssl.keyStore"));+                if (keyStoreFile.exists()) {+                    KeyStore keyStore = KeyStore.getInstance(System.getProperty("javax.net.ssl.keyStoreType", KeyStore.getDefaultType()));+                    try ( InputStream keyStoreStream = new FileInputStream(keyStoreFile)) {+                        keyStore.load(keyStoreStream, keyStorePassword);+                    } -        // #208324: proper key managers need to be passed, so let's configure at least the defaults...-        KeyManager[] mgrs;-        if (System.getProperty("javax.net.ssl.keyStorePassword") != null &&  // NOI18N-            System.getProperty("javax.net.ssl.keyStore") != null) { // NOI18N-            try {-                KeyStore ks = KeyStore.getInstance("JKS"); // NOI18N-                    ks.load(new FileInputStream(System.getProperty("javax.net.ssl.keyStore")), //NOI18N-                    System.getProperty("javax.net.ssl.keyStorePassword").toCharArray() //NOI18N-                );-                // Set up key manager factory to use our key store-                KeyManagerFactory kmf = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());-                kmf.init(ks,System.getProperty("javax.net.ssl.keyStorePassword").toCharArray()); // NOI18N-                mgrs = kmf.getKeyManagers();-            } catch (IOException ex) {-                // this is somewhat expected, i.e. JKS file not present-                mgrs = null;-            } catch (java.security.GeneralSecurityException e) {-                ErrorManager.getDefault().notify(e);-                return;+                    keyStoreFromSystemProperties = keyStore;+                }             }-        } else {-            mgrs = null;++            KeyManagerFactory keyManagerFactory = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());+            keyManagerFactory.init(keyStoreFromSystemProperties, keyStorePassword);+            keyManagersFromSystemProperties = keyManagerFactory.getKeyManagers();+        } catch (GeneralSecurityException | IOException ex) {+            keyManagersFromSystemProperties = new KeyManager[0];         }+         try {             SSLContext sslContext = SSLContext.getInstance("SSL"); //NOI18N-            sslContext.init(mgrs, trustAllCerts, new java.security.SecureRandom());+            sslContext.init(keyManagersFromSystemProperties, combinedTrustManagers, new java.security.SecureRandom());             con.setSSLSocketFactory(sslContext.getSocketFactory());-            con.setHostnameVerifier(new HostnameVerifier() {-                public boolean verify(String string, SSLSession sSLSession) {-                    // accept all hosts-                    return true;-                }-            });-        } catch (java.security.GeneralSecurityException e) {+            con.setHostnameVerifier(this::acceptAllHosts);+        } catch (GeneralSecurityException e) {             ErrorManager.getDefault().notify(e);         }     }-    ++    private boolean acceptAllHosts(String host, SSLSession sslSession) {+        return true;

Actuall I wonder if it can be removed completely. I suspect that the validation should be done by the default SSL/TLS processing.

asbachb

comment created time in 21 days

PullRequestReviewEvent

issue openedNixOS/nixpkgs

lxd: Unable to creat a virtual machine

Describe the bug

Currently it seems to be unable to create a virtual machine with lxd.

asbachb@nixos-t14s  /etc/nixos/modules  lxc launch images:ubuntu/hirsute ubuntu-vm --vm

Creating ubuntu-vm
Error: Failed instance creation: Failed creating instance record: Instance type "virtual-machine" is not supported on this server

Steps To Reproduce

Steps to reproduce the behavior:

  1. Enable lxd:
  virtualisation = {
    lxd = {
      enable = true;
      recommendedSysctlSettings = true;
    };
  };
  1. Ensure your user is in lxd group
  2. Try to create a virtual machine: lxc launch images:ubuntu/hirsute ubuntu-vm --vm

Notify maintainers

@fpletz @wucke13 @marsam

Metadata

 ✘ asbachb@nixos-t14s  /etc/nixos/modules  nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.14.8, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.15`
 - channels(asbachb): `"nixos-21.11pre304061.dd14e5d78e9, nixos-20.09-20.09.4393.068984c00e0"`
 - channels(root): `"nixos-21.11pre319562.c21ba4f7bb4, nixos-hardware, nixos-unstable"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
* lxd
# a list of nixos modules affected by the problem
module:
* lxd

created time in 22 days

delete branch asbachb/nixpkgs

delete branch : update/netbeans

delete time in 23 days

pull request commentNixOS/nixpkgs

keystore-explorer: use latest available lts java version to run

/status needs_reviewer

asbachb

comment created time in 23 days

pull request commentNixOS/nixpkgs

keystore-explorer: use latest available lts java version to run

/marvin opt-in /marvin status needs_reviewer

asbachb

comment created time in 23 days

PR closed NixOS/nixpkgs

Reviewers
bottles: 2021.7.14-treviso -> 2021.9.14-treviso 2.status: merge conflict 10.rebuild-linux: 1-10 10.rebuild-darwin: 0 10.rebuild-linux: 1 marvin awaiting_changes

Added new dependency patool as it's now needed during runtime.

Motivation for this change

Update to latest release.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 30, done.
remote: Counting objects: 100% (24/24), done.
remote: Compressing objects: 100% (11/11), done.
remote: Total 30 (delta 15), reused 14 (delta 13), pack-reused 6
Unpacking objects: 100% (30/30), 224.55 KiB | 782.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   9f761047cc4..b7255cd8b96  master     -> refs/nixpkgs-review/0
$ git worktree add /home/asbachb/.cache/nixpkgs-review/rev-df00de53009d941f5417aa298761f558da758a5b-dirty/nixpkgs b7255cd8b96994ebfc20810f3cad4b6e871af7f4
Preparing worktree (detached HEAD b7255cd8b96)
Updating files: 100% (27893/27893), done.
HEAD is now at b7255cd8b96 Merge pull request #138542 from figsoda/cargo-tally
$ nix-env --option system x86_64-linux -f /home/asbachb/.cache/nixpkgs-review/rev-df00de53009d941f5417aa298761f558da758a5b-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • [x] Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [ ] Fits CONTRIBUTING.md.
+10 -5

10 comments

1 changed file

asbachb

pr closed time in 23 days