profile
viewpoint

upgrades-migrations/redhat-upgrade-tool 11

Upgrades Red Hat Enterprise Linux from one major version to a newer one.

upgrades-migrations/preupgrade-assistant-modules 3

Modules for the Preupgrade Assistant tool

artmello/goschinke 1

Implements Schinke latin stemming in Go

caiobegotti/Corre-Curitiba 1

Corre Curitiba, códigos e apps pra monitorar calendários de corridas na região de Curitiba

artmello/ansible 0

Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.

artmello/ansible-devel-env 0

Ansible role for setting up Leapp Development Environment

artmello/athens 0

A Go module datastore and proxy

artmello/buildah 0

A tool which facilitates building OCI images

artmello/dnf-plugins-extras 0

repository for DNF community plugins

artmello/gofed 0

Pack of tools to generate spec file, automate builds, updates, dependency check and other handy task around packaging and keeping the ecosystem in a good shape.

pull request commentoamg/leapp

snactor.sanity-check: Add option to ignore models

@pirat89 the review request is more of a FYI at this point.

vinzenz

comment created time in 19 hours

pull request commentoamg/leapp

snactor.sanity-check: Add option to ignore models

<!-- leapp-bot-github-pr-welcome-message -->

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.

If you want to re-run tests or request review, you can use following commands as a comment:

  • leapp-ci build to run unit tests, copr build and e2e tests in OAMG CI
  • e2e tests to run unit tests, copr build and end-to-end tests in Murphy CI (OAMG members only) [OLD PIPELINE]
  • review please to notify leapp developers of review request

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

vinzenz

comment created time in 19 hours

PR opened oamg/leapp

Reviewers
snactor.sanity-check: Add option to ignore models wip

Previously, if a Model was being consumed by actor before it was produced, snactor sanity-check reported a failure. This however blocks some use case in leapp-repository now, where there is the possibility to supply user data and it is being verified before in a later stage it actually is used. This sanitization actor causes this check to fail and would force an ugly workaround by having a dummy actor pretending to produce the message earlier.

This patch will introduce two ways of handling this situation by ignoring the models. Either each model can be specified as a commandline option --ignore or a path to a file containing a list of such models can be supplied via --ignorefile. Any of those specified model names supplied via --ignore or the ignore file will no longer be considered a failure.

Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com

+18 -4

0 comment

1 changed file

pr created time in 19 hours

pull request commentoamg/leapp-repository

Feature/add actor checkpcidrivers

FYI commits from ZhukovGreen added 4 commits on Oct 27 is just rebasing to the recent master

ZhukovGreen

comment created time in a day

pull request commentoamg/leapp-repository

Do not inhibit upgrade with SCA enabled manifest

Re-tested and seems to be working fine.

Rezney

comment created time in a day

push eventoamg/snippets

Petr Stodulka

commit sha 903baafbd73c5900a9b50417b489b69b07dde588

leapp-inspector: add README and bash-completion script The README.md file roughly document the purpose and usage of the leapp-inspector. As well, contains instructions how to install the bash-completion script under a user. The bash completion script covers all current subcommands and options.

view details

Petr Stodulka

commit sha ee203406b24c6759ef471eb91b06b4cea5935a87

leapp-inspector: add disclaimer The point is to ensure that people will not start to use it in automation tools, etc. blindly, expecting that the tool/library is stable. It's still under heavy development and crucial changes can be made without sorry.

view details

push time in a day

PR merged oamg/snippets

Reviewers
leapp-inspector: add README and bash-completion script enhancement

The README.md file roughly document the purpose and usage of the leapp-inspector. As well, contains instructions how to install the bash-completion script under a user.

The bash completion script covers all current subcommands and options.

+274 -0

1 comment

3 changed files

pirat89

pr closed time in a day

pull request commentoamg/snippets

leapp-inspector: add README and bash-completion script

Regarding our policies in snippets repository, and another wanted usage of the tool in other parts of our project, merging.

pirat89

comment created time in a day

Pull request review commentoamg/leapp-repository

Ensure --enablerepo are not blacklisted + better reporting

 from leapp.libraries.common.config import get_product_type from leapp.libraries.stdlib import api from leapp.models import (+    CustomTargetRepository,     RepositoriesBlacklisted,     RepositoriesFacts,     RepositoriesMap, )  +def _report_using_unsupported_repos(repos):+    report = [+        reporting.Title("Using repository not supported by Red Hat"),+        reporting.Summary(+            "The following repositories has been used for the "+            "upgrade, but they are not supported by the Red Hat.:\n"+            "- {}".format("\n - ".join(repos))+        ),+        reporting.ExternalLink(

You're right. This MR has a long history, so I will recheck texting

ZhukovGreen

comment created time in 2 days

Pull request review commentoamg/leapp-repository

Ensure --enablerepo are not blacklisted + better reporting

 from leapp.libraries.common.config import get_product_type from leapp.libraries.stdlib import api from leapp.models import (+    CustomTargetRepository,     RepositoriesBlacklisted,     RepositoriesFacts,     RepositoriesMap, )  +def _report_using_unsupported_repos(repos):+    report = [+        reporting.Title("Using repository not supported by Red Hat"),+        reporting.Summary(+            "The following repositories has been used for the "+            "upgrade, but they are not supported by the Red Hat.:\n"+            "- {}".format("\n - ".join(repos))+        ),+        reporting.ExternalLink(

btw: following repositories have.

ZhukovGreen

comment created time in 2 days

Pull request review commentoamg/leapp-repository

Ensure --enablerepo are not blacklisted + better reporting

 from leapp.libraries.common.config import get_product_type from leapp.libraries.stdlib import api from leapp.models import (+    CustomTargetRepository,     RepositoriesBlacklisted,     RepositoriesFacts,     RepositoriesMap, )  +def _report_using_unsupported_repos(repos):+    report = [+        reporting.Title("Using repository not supported by Red Hat"),+        reporting.Summary(+            "The following repositories has been used for the "+            "upgrade, but they are not supported by the Red Hat.:\n"+            "- {}".format("\n - ".join(repos))+        ),+        reporting.ExternalLink(

that was kind of the problem already before. Maybe we should think about the better wording.

ZhukovGreen

comment created time in 2 days

Pull request review commentoamg/leapp-repository

If msgs is None, make sure mocked consume works

 def __init__(self, arch=architecture.ARCH_X86_64, envars=None, kernel='3.10.0-95         self.configuration = namedtuple(             'configuration', ['architecture', 'kernel', 'leapp_env_vars', 'os_release', 'version']         )(arch, kernel, envarsList, release, version)-        self._msgs = msgs+        self._msgs = msgs if msgs else []

Thx!

ZhukovGreen

comment created time in 2 days

Pull request review commentoamg/leapp

os.path.ismount workaround to detect bind mounts

+import os++_MOUNTS_PATH = '/proc/self/mounts'+++def _ismount_with_bindmounts(path):+    if not os.path.exists(path):+        print("Path {path} does not exist".format(path=path))

What about printing to stderr here?

vinzenz

comment created time in 2 days

Pull request review commentoamg/leapp

os.path.ismount workaround to detect bind mounts

+overlay / overlay rw,relatime,lowerdir=/var/lib/docker/overlay2/l/E6QDTSDO4R6FU7IUN3SKWB2M6F:/var/lib/docker/overlay2/l/N7VEADMERCHKZBYU3YK23MTCI6,upperdir=/var/lib/docker/overlay2/fca5eaf608e48053b5d4a91225a7c9388579f35927416ec16ee902bc4724c703/diff,workdir=/var/lib/docker/overlay2/fca5eaf608e48053b5d4a91225a7c9388579f35927416ec16ee902bc4724c703/work 0 0+proc /proc proc rw,nosuid,nodev,noexec,relatime 0 0+tmpfs /dev tmpfs rw,nosuid,size=65536k,mode=755 0 0+devpts /dev/pts devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=666 0 0+sysfs /sys sysfs rw,nosuid,nodev,noexec,relatime 0 0+tmpfs /sys/fs/cgroup tmpfs rw,nosuid,nodev,noexec,relatime,mode=755 0 0+cpuset /sys/fs/cgroup/cpuset cgroup rw,nosuid,nodev,noexec,relatime,cpuset 0 0+cpu /sys/fs/cgroup/cpu cgroup rw,nosuid,nodev,noexec,relatime,cpu 0 0+cpuacct /sys/fs/cgroup/cpuacct cgroup rw,nosuid,nodev,noexec,relatime,cpuacct 0 0+blkio /sys/fs/cgroup/blkio cgroup rw,nosuid,nodev,noexec,relatime,blkio 0 0+memory /sys/fs/cgroup/memory cgroup rw,nosuid,nodev,noexec,relatime,memory 0 0+devices /sys/fs/cgroup/devices cgroup rw,nosuid,nodev,noexec,relatime,devices 0 0+freezer /sys/fs/cgroup/freezer cgroup rw,nosuid,nodev,noexec,relatime,freezer 0 0+net_cls /sys/fs/cgroup/net_cls cgroup rw,nosuid,nodev,noexec,relatime,net_cls 0 0+perf_event /sys/fs/cgroup/perf_event cgroup rw,nosuid,nodev,noexec,relatime,perf_event 0 0+net_prio /sys/fs/cgroup/net_prio cgroup rw,nosuid,nodev,noexec,relatime,net_prio 0 0+hugetlb /sys/fs/cgroup/hugetlb cgroup rw,nosuid,nodev,noexec,relatime,hugetlb 0 0+pids /sys/fs/cgroup/pids cgroup rw,nosuid,nodev,noexec,relatime,pids 0 0+rdma /sys/fs/cgroup/rdma cgroup rw,nosuid,nodev,noexec,relatime,rdma 0 0+cgroup /sys/fs/cgroup/systemd cgroup rw,nosuid,nodev,noexec,relatime,name=systemd 0 0+mqueue /dev/mqueue mqueue rw,nosuid,nodev,noexec,relatime 0 0+shm /dev/shm tmpfs rw,nosuid,nodev,noexec,relatime,size=65536k 0 0+/dev/vda1 /etc/resolv.conf ext4 rw,relatime 0 0+/dev/vda1 /etc/hostname ext4 rw,relatime 0 0+/dev/vda1 /etc/hosts ext4 rw,relatime 0 0+devpts /dev/console devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=666 0 0+overlay /usr overlay rw,relatime,lowerdir=/var/lib/docker/overlay2/l/E6QDTSDO4R6FU7IUN3SKWB2M6F:/var/lib/docker/overlay2/l/N7VEADMERCHKZBYU3YK23MTCI6,upperdir=/var/lib/docker/overlay2/fca5eaf608e48053b5d4a91225a7c9388579f35927416ec16ee902bc4724c703/diff,workdir=/var/lib/docker/overlay2/fca5eaf608e48053b5d4a91225a7c9388579f35927416ec16ee902bc4724c703/work 0 0

Please add a new line at the EOF.

vinzenz

comment created time in 2 days

Pull request review commentoamg/leapp

os.path.ismount workaround to detect bind mounts

+proc /proc proc rw,nosuid,nodev,noexec,relatime 0 0+tmpfs /dev tmpfs rw,nosuid,size=65536k,mode=755 0 0+devpts /dev/pts devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=666 0 0+sysfs /sys sysfs rw,nosuid,nodev,noexec,relatime 0 0+tmpfs /sys/fs/cgroup tmpfs rw,nosuid,nodev,noexec,relatime,mode=755 0 0+cpuset /sys/fs/cgroup/cpuset cgroup rw,nosuid,nodev,noexec,relatime,cpuset 0 0+cpu /sys/fs/cgroup/cpu cgroup rw,nosuid,nodev,noexec,relatime,cpu 0 0+cpuacct /sys/fs/cgroup/cpuacct cgroup rw,nosuid,nodev,noexec,relatime,cpuacct 0 0+blkio /sys/fs/cgroup/blkio cgroup rw,nosuid,nodev,noexec,relatime,blkio 0 0+memory /sys/fs/cgroup/memory cgroup rw,nosuid,nodev,noexec,relatime,memory 0 0+devices /sys/fs/cgroup/devices cgroup rw,nosuid,nodev,noexec,relatime,devices 0 0+freezer /sys/fs/cgroup/freezer cgroup rw,nosuid,nodev,noexec,relatime,freezer 0 0+net_cls /sys/fs/cgroup/net_cls cgroup rw,nosuid,nodev,noexec,relatime,net_cls 0 0+perf_event /sys/fs/cgroup/perf_event cgroup rw,nosuid,nodev,noexec,relatime,perf_event 0 0+net_prio /sys/fs/cgroup/net_prio cgroup rw,nosuid,nodev,noexec,relatime,net_prio 0 0+hugetlb /sys/fs/cgroup/hugetlb cgroup rw,nosuid,nodev,noexec,relatime,hugetlb 0 0+pids /sys/fs/cgroup/pids cgroup rw,nosuid,nodev,noexec,relatime,pids 0 0+rdma /sys/fs/cgroup/rdma cgroup rw,nosuid,nodev,noexec,relatime,rdma 0 0+cgroup /sys/fs/cgroup/systemd cgroup rw,nosuid,nodev,noexec,relatime,name=systemd 0 0+mqueue /dev/mqueue mqueue rw,nosuid,nodev,noexec,relatime 0 0+shm /dev/shm tmpfs rw,nosuid,nodev,noexec,relatime,size=65536k 0 0+/dev/vda1 /etc/resolv.conf ext4 rw,relatime 0 0+/dev/vda1 /etc/hostname ext4 rw,relatime 0 0+/dev/vda1 / ext4 rw,relatime 0 0+/dev/vda1 /etc/hosts ext4 rw,relatime 0 0+devpts /dev/console devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=666 0 0

Please add a new line at the EOF.

vinzenz

comment created time in 2 days

Pull request review commentoamg/leapp

os.path.ismount workaround to detect bind mounts

+import os++_MOUNTS_PATH = '/proc/self/mounts'+++def _ismount_with_bindmounts(path):+    if not os.path.exists(path):+        print("Path {path} does not exist".format(path=path))+        return False+    if os.path.islink(path):+        print("Path {path} is link".format(path=path))+        return False+    with open(_MOUNTS_PATH) as f:+        for line in f:+            try:+                target = line.split(' ')[1]

Just curious, under what circumstances it will not have the target?

vinzenz

comment created time in 2 days

Pull request review commentoamg/leapp-repository

Ensure --enablerepo are not blacklisted + better reporting

 from leapp.libraries.common.config import get_product_type from leapp.libraries.stdlib import api from leapp.models import (+    CustomTargetRepository,     RepositoriesBlacklisted,     RepositoriesFacts,     RepositoriesMap, )  +def _report_using_unsupported_repos(repos):+    report = [+        reporting.Title("Using repository not supported by Red Hat"),+        reporting.Summary(+            "The following repositories has been used for the "+            "upgrade, but they are not supported by the Red Hat.:\n"+            "- {}".format("\n - ".join(repos))+        ),+        reporting.ExternalLink(

I am confused by this report, and I am pretty sure customers would be confused too.

You talk about unsupported repositories and add a link to CRB - And from the looks of the code it seems like that this link even would come up if none of the repos is the CRB repo. Or am I missing something?

Similar for the black listed repo.

ZhukovGreen

comment created time in 2 days

Pull request review commentoamg/leapp-repository

A humble attempt to respect framework dependencies.

 VOLUME /payload RUN yum update -y && \     yum install python-virtualenv make git -y +# XXX FIXME couldn't figure out a proper way to get pip v10+ on the system

I am just wondering why easy_install can't get the job done

fernflower

comment created time in 3 days

Pull request review commentoamg/leapp-repository

A humble attempt to respect framework dependencies.

 VOLUME /payload RUN yum update -y && \     yum install python-virtualenv make git -y +# XXX FIXME couldn't figure out a proper way to get pip v10+ on the system

Is pip v10+ really needed? If yes, I wouldn't mark it as a FIXME, if installation by a package manager is not a viable option, installation using get-pip.py script is pretty standard.

fernflower

comment created time in 3 days

pull request commentoamg/leapp

os.path.ismount workaround to detect bind mounts

<!-- leapp-bot-github-pr-welcome-message -->

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.

If you want to re-run tests or request review, you can use following commands as a comment:

  • leapp-ci build to run unit tests, copr build and e2e tests in OAMG CI
  • e2e tests to run unit tests, copr build and end-to-end tests in Murphy CI (OAMG members only) [OLD PIPELINE]
  • review please to notify leapp developers of review request

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

vinzenz

comment created time in 3 days

PR opened oamg/leapp

os.path.ismount workaround to detect bind mounts

Previously os.path.ismount does return False for bind mounts if they come from the same partition. This PR fixes this issue by checking /proc/self/mounts if the mount exists.

This patch bumps the framework-version to 1.4

Task: OAMG-4171 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1901440 Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com

+104 -1

0 comment

6 changed files

pr created time in 3 days

Pull request review commentoamg/leapp-repository

If msgs is None, make sure mocked consume works

 def __init__(self, arch=architecture.ARCH_X86_64, envars=None, kernel='3.10.0-95         self.configuration = namedtuple(             'configuration', ['architecture', 'kernel', 'leapp_env_vars', 'os_release', 'version']         )(arch, kernel, envarsList, release, version)-        self._msgs = msgs+        self._msgs = msgs if msgs else []

alternatively you could probably set msgs=() in the constructor

ZhukovGreen

comment created time in 3 days

Pull request review commentoamg/leapp-repository

If msgs is None, make sure mocked consume works

 def __init__(self, arch=architecture.ARCH_X86_64, envars=None, kernel='3.10.0-95         self.configuration = namedtuple(             'configuration', ['architecture', 'kernel', 'leapp_env_vars', 'os_release', 'version']         )(arch, kernel, envarsList, release, version)-        self._msgs = msgs+        self._msgs = msgs if msgs else []
        self._msgs = msgs or []
ZhukovGreen

comment created time in 3 days

Pull request review commentoamg/leapp-repository

A humble attempt to respect framework dependencies.

 TIMESTAMP:=$${__TIMESTAMP:-$(shell /bin/date -u "+%Y%m%d%H%MZ")} SHORT_SHA=`git rev-parse --short HEAD` BRANCH=`git rev-parse --abbrev-ref HEAD | tr -- '-/' '_'` +# In case the top commit Depends-On some framework patch that is not merged yet - override framework master with the+# proper version+REQ_LEAPP_PR=$(shell git show HEAD -q | grep Depends-On | grep -Eo '[[:digit:]]*')

The check for Depends-On keyword only in top commit of the PR is somewhat cumbersome, what if the PR author:

  1. needs to add another commit? He has to add this keyword to every commit message.
  2. forgets to add this keyword to the last comment? He has to add another commit or rebase with modified commit message.
  3. wnats to change (or even remove) the PR dependency? Same as above

It seems to me that better approach would be querying API and checking PR description for this keyword. This way the PR author (or even repo owner) can easily add/remove the dependecy and also the dependency has better visibility. If implemented this way I would also prefer to have this dependency on its own line. e.g. checking something like ^Depends-On: [[:digit:]]*$

fernflower

comment created time in 4 days

Pull request review commentoamg/leapp-repository

A humble attempt to respect framework dependencies.

 TIMESTAMP:=$${__TIMESTAMP:-$(shell /bin/date -u "+%Y%m%d%H%MZ")} SHORT_SHA=`git rev-parse --short HEAD` BRANCH=`git rev-parse --abbrev-ref HEAD | tr -- '-/' '_'` +# In case the top commit Depends-On some framework patch that is not merged yet - override framework master with the+# proper version+DEPENDS_ON_PR=$(shell git show HEAD -q | grep Depends-On | grep -Eo '[[:digit:]]*')+DEPENDS_ON_PR_IS_OPEN=$(shell curl "https://api.github.com/repos/oamg/leapp/pulls/${DEPENDS_ON_PR}" | python -c "import json,sys; print (json.load(sys.stdin)['closed_at'] is None)")

I'm OK with using $(...) in the Makefile:

  1. Argument that people unfamiliar with Makefile syntax is void - people unfamiliar with ${SUBSTITUTE_ANYTHING} syntax should learn it first and then they can work with ${SUBSTITUTE_ANYTHING}
  2. The syntax is aleady used in multiple places in this Makefile, the same holds for leapp's Makefile
  3. I'm hugely biased against backticks, they should have died really long ago, but that's no argument...
fernflower

comment created time in 4 days

pull request commentoamg/leapp-repository

Add an "AND_IF" after /dev/mapper check

@Rezney after discussion with QE, I am keeping it opened yet for a while.

Rezney

comment created time in 4 days

pull request commentoamg/leapp-repository

Add an "AND_IF" after /dev/mapper check

<!-- leapp-bot-github-pr-welcome-message -->

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.

If you want to re-run tests or request review, you can use following commands as a comment:

  • leapp-ci build to run unit tests, copr build and e2e tests in OAMG CI
  • e2e tests to run unit tests, copr build and end-to-end tests in Murphy CI (OAMG members only) [OLD PIPELINE]
  • review please to notify leapp developers of review request

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

Rezney

comment created time in 4 days

pull request commentoamg/leapp-repository

Add an "AND_IF" after /dev/mapper check

Reopened at @pirat89 request. We aim to merge this sooner rather then later.

Rezney

comment created time in 4 days

PullRequestEvent

PR closed oamg/leapp-repository

Feature/keep manually enabled repos

ref #544

This MR provides the user with the possibility to manually enable the rhel8 repository by specifying it next to --enablerepo option. By doing this, the repo will be shielded from exclusion (even if it is optional on rhel 7).

TODO

  • [ ] Merge #545 and rebase on top
  • [ ] Clarify what is manually enabled repo
+398 -205

4 comments

23 changed files

ZhukovGreen

pr closed time in 5 days

more