profile
viewpoint
Aaron Schlesinger arschles @Microsoft @Azure Portland, OR https://arschles.com/ Gopher & Kubernaut

aarons-talks/2017-12-04-KubeCon-North-America-2017 207

Best practices for building an app to run on Kubernetes

aarons-talks/2017-KubeCon-EU 27

Code for KubeCon EU 2017

aarons-talks/2019-06-18-JFrog-SwampUP 4

Sample Code from my JFrog SwampUP 2019 Talk

arschles/assert 4

Simple assertions for Go (golang) tests

arschles/athens-workshops 4

Workshops for the Athens Project

aarons-talks/2019-07-26-GopherCon-US 3

Demo code from my GopherCon US 2019 Talk

aarons-talks/2017-09-24-Ignite 2

Code, demos and resources for Ignite 2017 talks

arschles/awesome-go 2

A curated list of awesome Go frameworks, libraries and software

arschles/badhttp 2

an HTTP server that can be configured to do bad things

aarons-talks/2019-08-23-GopherCon-UK 1

Demo code from my GopherCon UK 2019 Talk

push eventarschles/twitch

Aaron Schlesinger

commit sha 51be2cbbe317ba703d2819630739fc4f84bf2c7d

today Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 2 hours

issue openedosscda/kedahttp

Split up the admin API, proxy, and external scaler

This way we can deploy them separately to Kubernetes.

  • Need to investigate rewriting any/all of them in rust. the go is simple prototype
  • For rust rewrite, there's already #11 for rewriting the CLI, so a second rust project would need a top-level cargo.toml that defines a workspace

created time in 4 hours

push eventosscda/kedahttp

Aaron Schlesinger

commit sha 7ceb195e4b1457569a58ddc9fff0983ebead3fd0

test for rm Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 4 hours

push eventosscda/kedahttp

Aaron Schlesinger

commit sha c18c245112f2e8de756cfa5cf7066ee251e77725

removing the go client, replacing completely with the rust one Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

Aaron Schlesinger

commit sha 61bacb6195d33a93307c8c8d26cacda8ebacbfb0

removing the go client, replacing completely with the rust one Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 4 hours

PR opened osscda/kedahttp

Rewriting the CLI in rust
+149 -1

0 comment

7 changed files

pr created time in 10 hours

push eventosscda/kedahttp

Aaron Schlesinger

commit sha 8e0b99170b2aa330d75a1475d682b1389b6f4955

RUST CLI FTWWWWW Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in a day

push eventarschles/twitch

Aaron Schlesinger

commit sha f08cf412fd96c0ff9c9c53ad6ca766d2369543b9

moar Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in a day

create barnchosscda/kedahttp

branch : rustcli

created branch time in a day

Pull request review commentdnephin/pre-commit-golang

another option for fixing the go vet script

 #!/usr/bin/env bash+ set -e pkg=$(go list)-for dir in $(echo $@|xargs -n1 dirname|sort -u); do-  go vet $pkg/$dir+for fn in "$@"; do+  go vet "${pkg}/${fn}"

Yup, with go 1.13, you can run it against files. Here's a test:

keda on 🌲 http Go 🐹  v1.13.8 go vet main.go

keda on 🌲 http Go 🐹  v1.13.8   echo $?
0
arschles

comment created time in a day

PullRequestReviewEvent

pull request commentkedacore/charts

Adding the ability to set the default HTTP timeout

The failure in https://github.com/kedacore/charts/pull/90/checks?check_run_id=1311498573 is this:

Error:  templates/21-metrics-clusterrolebinding.yaml: object name does not conform to Kubernetes naming requirements: "keda-operator:system:auth-delegator": invalid metadata name, must match regex ^(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])+$ and the length must not longer than 253

I didn't touch that file so I think it's unrelated to my change, but I'm happy to fix it if you like.

arschles

comment created time in 2 days

push eventarschles/kedacharts

Aaron Schlesinger

commit sha 023f21c236a5df25bd6ed4659990b0d66fb11d30

Adding the ability to set the default HTTP timeout Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 2 days

PR opened kedacore/charts

Reviewers
Adding the ability to set the default HTTP timeout

https://github.com/kedacore/keda/pull/1251 adds a new environment variable to allow users to set the default HTTP timeout in the system. This exposes that setting in the helm chart.

+9 -0

0 comment

2 changed files

pr created time in 2 days

create barncharschles/kedacharts

branch : timeout-env-var

created branch time in 2 days

fork arschles/charts

Helm charts for KEDA

fork in 2 days

push eventarschles/keda

Aaron Schlesinger

commit sha a6f8f375cb9831f25edcdaf9c991f34308685591

go vet fixes Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 2 days

issue commentkedacore/keda

TLS client is build with InsecureSkipVerify

https://github.com/kedacore/keda/pull/1251/files makes some progress towards this. creation of HTTP requests is limited to 1-2 points in the code

aman-bansal

comment created time in 2 days

push eventarschles/keda

Mohammed Al Ashaal

commit sha b1fdb9bb71fd1d8c891f1c2d9e2caee13fbf4e49

using lua script in fetching the list type and length in redis scaler (#1249) Signed-off-by: Mohamed Al Ashaal <m7medalash3al@gmail.com>

view details

silenceper

commit sha 2afc068d7996b21f602bc1e95c48755617baf095

fix actions name (#1252) Signed-off-by: silenceper <silenceper@gmail.com>

view details

aman bansal

commit sha 56b08bdffc7ac1cdb72eb4f51d66c5bd79190bf5

fix: renaming auth mode as per documentation review (#1258) Signed-off-by: aman-bansal <bansalaman2905@gmail.com>

view details

Ang Gao

commit sha bc61b4fcddb9f2833c7891db8665dc095964ea27

Add Argo Rollouts e2e test (#1261) Signed-off-by: Ang Gao <ang.gao87@gmail.com>

view details

Zbynek Roubalik

commit sha d1094539391ba1de5596e4675f9b4d0ba1537d14

point badge to v2 build (#1265) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

view details

Zbynek Roubalik

commit sha 4b4e4736e6c5e7f622c9771d46a8c136967b63a5

adding ScaledJob finalizer (#1260) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

view details

Artyom Kartasov

commit sha 733e92ef8d08465d5df620df2b4f19d59f3f03cb

enable golangci-lint: scopelint, structcheck (#1158) (#1268) Signed-off-by: akartasov <agneum@gmail.com>

view details

Artyom Kartasov

commit sha d0788b943ecf94f7f7c5b1a09f777cc3af6b746e

enable golangci-lint: interfacer, staticcheck (#1158) (#1267) Signed-off-by: akartasov <agneum@gmail.com>

view details

Tomek Urbaszek

commit sha bda3664427628185fd13ef9998750d0cd1b31365

Make lightning white in logo (#1276) Signed-off-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>

view details

Tsuyoshi Ushio

commit sha 091d7f84c1b881f2a72ac273bc9e83cefd297a23

fix:memory leak (#1284) Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>

view details

Zbynek Roubalik

commit sha 01579005e86dcd30e82c54f873c48520d35157f3

update deps (#1272) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

view details

Jess McCreery

commit sha dfc8604cca5ef53b6a647f5060ea5e71dbc2f444

New IBM MQ Scaler (#1259) Signed-off-by: Jess McCreery <jessica.mccreery@ibm.com> Co-authored-by: Liam McNulty <59540366+LiamMcNulty@users.noreply.github.com> Co-authored-by: Richard Coppen <30902631+rcoppen@users.noreply.github.com> Co-authored-by: cpilton <pilton.callum@gmail.com> Co-authored-by: Jess McCreery <jessica.mccreery@ibm.com> Co-authored-by: Bimsara Pilapitiya <bimsara.pilapitiya@ibm.com> Co-authored-by: Rory Jackson <rory.jackson@ibm.com> Co-authored-by: Soheel Chughtai <soheel_chughtai@uk.ibm.com> Co-authored-by: Nisheeka Nynan <nisheeka.nynan@ibm.com>

view details

Adam Sunderland

commit sha 7553e9a2fa535bf426696f2aa47bd89faae9c376

Remove Kafka scaler requirement for CA/cert/key (#1288) Signed-off-by: iterion <adam.sunderland@zapier.com>

view details

Zbynek Roubalik

commit sha b2eb02cb74af9060ee21c723e2fc2f6af6fb6f70

install instructions for 2.0.0 RC2 (#1289) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

view details

Tsuyoshi Ushio

commit sha 9d0ef8f6e20ffd4d881b0aa2cb098e1ffded40c4

Add referece to how to setup profiler (#1290) Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>

view details

Jianbo Sun

commit sha fcc463b23dcb82dd141dc2b7a55adc28c7a7e824

fix buildScalers panic when podTemplateSpec is nil (#1293) Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>

view details

Aaron Schlesinger

commit sha f24a43270b3a47ae431fcc8e5c3e14faf3cb4f14

using dedicated HTTP clients fixes https://github.com/kedacore/keda/issues/1133 Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> reading timeout from env var, and storing HTTP client in ScalerConfig Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> fixing undeclared name client Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 2 days

push eventarschles/keda

Aaron Schlesinger

commit sha edf672f232619be27d24c9f5b84c519fc2cfc8dc

using dedicated HTTP clients fixes https://github.com/kedacore/keda/issues/1133 Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> reading timeout from env var, and storing HTTP client in ScalerConfig Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> fixing undeclared name client Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 2 days

push eventarschles/pre-commit-golang

Aaron Schlesinger

commit sha 5424282df25815e0db7ad7de69cd01b90e6e4939

spacing

view details

push time in 2 days

pull request commentkedacore/keda

Not running govet or gofmt in Dockerfile builds

We have two patches proposed, hopefully the maintainer will choose one of them: https://github.com/dnephin/pre-commit-golang/pull/63 and https://github.com/dnephin/pre-commit-golang/pull/62

arschles

comment created time in 2 days

PR opened dnephin/pre-commit-golang

another option for fixing the go vet script

alternative to #62, see that PR for context on this one

+3 -2

0 comment

1 changed file

pr created time in 2 days

create barncharschles/pre-commit-golang

branch : govet2

created branch time in 2 days

PR opened dnephin/pre-commit-golang

Using simpler oneliner for go vet

The go vet check is failing in this PR (the logs are here). I'm not sure what's going on, but modern go vet ./... will run through all files in the repo. this is suboptimal, but it's not extremely slow in many cases. perhaps there should be two checks? just an idea, not sure if it's necessary

+1 -4

0 comment

1 changed file

pr created time in 2 days

create barncharschles/pre-commit-golang

branch : govet

created branch time in 2 days

push eventarschles/keda

Aaron Schlesinger

commit sha 76af3d0fe1dc5487f494d84ef47fd49eb42997fa

fixing undeclared name client Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 2 days

push eventarschles/keda

Aaron Schlesinger

commit sha d1ed94e0c2f4008eb827dff1565c3e43e297e6ef

fixing undeclared name client

view details

push time in 2 days

pull request commentkedacore/keda

Not running govet or gofmt in Dockerfile builds

The static check is failing because of the go-vet pre-commit hook. That code is here. We are working on a patch for that code, at which point we'll update this PR :smile:

arschles

comment created time in 2 days

push eventarschles/keda

Aaron Schlesinger

commit sha acad632bd32e1b137f79d868b7f8c0f7f42f0490

combining the go fmt and go vet into one repo Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 2 days

issue commentkedacore/keda

MQTT - based scaler

I didn't have anything specific in mind regarding "volume of messages" - just an abstract idea. I think that number of messages received over a period of time could work. another idea is to maintain a rolling average of messages received over a window. according to you, @andschneider , you'd need to have KEDA be a subscriber to the queue - not sure if that's ok to do. @zroubalik thoughts on that part?

arschles

comment created time in 2 days

push eventarschles/keda

Aaron Schlesinger

commit sha 540ac1300b438a3c1fd9baac1bc3b909a4fdb6ea

combining the go fmt and go vet into one repo

view details

push time in 2 days

push eventarschles/keda

Aaron Schlesinger

commit sha d6ced2b37989a60ba670a652de573eef39a0be87

deleting whitespace Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 2 days

push eventarschles/keda

Aaron Schlesinger

commit sha 3000f077dcd5e36cae07524bf0673a965d145c40

deleting whitespace

view details

push time in 2 days

push eventarschles/keda

Aaron Schlesinger

commit sha 6bdc75423b3e8ae9667a13d1509b1ac49a107209

Not running govet or gofmt in Dockerfile builds Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

Aaron Schlesinger

commit sha 9386e6a7eee8fbc6aacee5fdf557c38c8d7a3db0

adding go vet to the pre-commit config file Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

Aaron Schlesinger

commit sha 99dad3921b3747298f317eacdc5c12be64747f4f

calling make Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

Aaron Schlesinger

commit sha 44aa3585c9fe39e24ca3ae991cf3ff8bc647d7f6

don't double-call go build Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 2 days

push eventarschles/keda

Aaron Schlesinger

commit sha ccc9843b65cdf4307b07fd182848443dd791e41c

calling make

view details

Aaron Schlesinger

commit sha 76788ec855c7e2b0bd9f7ec11960144c9f646477

don't double-call go build

view details

push time in 2 days

issue commentgomods/athens

Content-Length Support is required to make local pkgsite working

@jaredallard great - would you be ok with submitting a PR with that change?

AlexeyUzhva

comment created time in 6 days

pull request commentgomods/athens

Add artifactory storage backend

@bored-engineer yea, I think that's a flake. I restarted it. One question though - would it not be better to just use Artifactory as an upstream? iirc you can use it as a Go module server as well

bored-engineer

comment created time in 6 days

pull request commentgomods/athens

Fix K8s service account usage

oops @owenhaynes the helm chart version needs an increase, then this is all good to go

owenhaynes

comment created time in 6 days

PullRequestReviewEvent

push eventowenhaynes/athens

Federico Paolinelli

commit sha 27f36834161274dd3b98f8547a1aea1f536f643d

Replace the current e2e script with a test suite running e2e tests. (#1514) * Replace the current e2e script with a test suite running e2e tests. * Add a build tag to skip e2e while running unit tests. We want e2e tests to be skipped while running normal unit tests.

view details

Sebastian Heid

commit sha d7db2d4f1104e5799dc50971865c10799c278a51

Add installation instructions for BOSH (#1535) * Add installation instructions for BOSH * Fix weight and add link to try-out document Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>

view details

Aaron Schlesinger

commit sha ed703ee63dcf0418d9ce662baf8dee78097dbb1e

Adding docs for setting the GONOSUMDB env var on the Athens side (#1504) * Adding docs for setting the GONOSUMDB env var on the Athens side Ref https://github.com/gomods/athens/issues/1363 * Updating with multiple repos, and adding a note * Update docs/content/configuration/sumdb.md Co-Authored-By: Ted Wexler <ted@stuckinacan.com> * Qualifying "user" Co-authored-by: Ted Wexler <ted@stuckinacan.com>

view details

Aaron Schlesinger

commit sha 9624953236f5a8b45ecdefd0887b1682c7f815e0

Updating the sum database documentation (#1494) * Updating the sum database documentation

view details

Matthew Plachter

commit sha 71c57ef7eeed364c77cb25aec89654b5518a5be4

add config options for redis password (#1545) * add config options for redis password * redis password test and failure test * changed redis name and made a minimal redis.conf add drone volume volume fix remove volumes from drone. repoint redis path Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Co-authored-by: Marwan Sulaiman <marwan.sameer@gmail.com>

view details

Ted Wexler

commit sha 53232f726dfd5fe055c4f70a53dac098fb0db8e0

Update builds for Go 1.14 (#1558) * Update .drone.yml for Go 1.14 * Update appveyor.yml for Go 1.14 * Update Dockerfile.test for Go 1.14 * Update Dockerfile for Go 1.14 * Update scripts/build-image/Dockerfile

view details

Aaron Schlesinger

commit sha 5ea57ccd7e5afce88cad79e9df6bb7b87adc52ae

Adding more documentation to the Pull Request template (#1552) * Adding more documentation to the Pull Request template Including how the WIP bot factors into your workflow Fixes https://github.com/gomods/athens/issues/792

view details

Aaron Schlesinger

commit sha e42546a2b02853609ebd616bf493bbf9d56ad6fc

Adding "Powered by Netlify" text (#1563)

view details

Aaron Schlesinger

commit sha e1374bea39d2263c7948d4ebf2fcff6362eeae51

Remove chart version from deployments and services selectors (#1562) Label selectors are immutable; having the chart version part of the label selectors means that upgrades require a full recreation of the deployments and services instead of a simple update. This branch removes the chart version from the selectors to allow smooth upgrades.

view details

Dylan Meeus

commit sha 33384411dd1ec270f88ab040a3bc23443b5af332

update version info in google-cloud-run docs (#1573) * update version info in google-cloud-run docs * Update docs/content/install/install-on-google-cloud-run.md Co-Authored-By: Marwan Sulaiman <marwan.sameer@gmail.com> Co-authored-by: Marwan Sulaiman <marwan.sameer@gmail.com>

view details

Ted Wexler

commit sha 939e6955265f0a1290950974e9d672e35b65db79

Adds redis sentinel support (#1554) * Adds redis sentinel support Fixes #1553 * Fix redis-sentinel test hostnames * Fix redis master name again * Fix redis sentinel port in tests * Upgrade the redis client * Rmoeve accidental config change * Fix default config * Addresses review comments * Add documentation on single flight mechanisms * Fix spelling issues * Fix formatting Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>

view details

Aaron Schlesinger

commit sha 6b5b62c0fceb97e8c86816fcf82a93f730a330e3

Updating helm chart image version to latest (#1574) * updating image version to latest * updating chart.yaml versions * pushing a blank commit to trigger new CI builds

view details

Aaron Schlesinger

commit sha a7ffb86efedd9824cf52aca0541e23e0b300dad3

Fixing code like the go team printed version link (#1566) Fixes https://github.com/gomods/athens/issues/1565

view details

Aaron Schlesinger

commit sha 99867c743fe23d50adb9c958837a4c4aac521c10

Improving the project status section of our README (#1555) * Improving the project status section of our README Athens is not really "beta" anymore because teams are using it and we are already taking backward compatibility into consideration actively. I believe that the version number is a different but related discussion that we should have. I've also updated the contributing documentation and removed the section about dev meetings * Updating docs on contributing code * Removing redundant "issues" words * fixing issues URL * bumping to get netlify to build again * bumping to get netlify to run (again) * bumping to get netlify to run (again) * bumping to get netlify to run (again)

view details

Marwan Sulaiman

commit sha 0bb95c73515ee1ac018dbb13e85d5030a031917d

pkg/storage: make Checker optional in storage.Backend (#1580) * pkg/storage: make Checker optional in storage.Backend * pass storage

view details

Aaron Schlesinger

commit sha e89cf0feb2155f60ab2b0a808a75c1c84ccf8e34

Sample pr template change (#1577) * Updating commented-out instructions for PR submitters * adding more clarity

view details

Aaron Schlesinger

commit sha 94a97fe9e9a93cac0d44e7216c6d99e8beff5008

"sumdbPoxy" ==> "sumdbProxy" (#1569) Co-authored-by: Ted Wexler <ted@stuckinacan.com>

view details

Ted Wexler

commit sha 701bf394a5ded3e7b73b3dd97011b9bef755bdd3

Move SingleFlight.Redis.Password back under SingleFlight.Redis (#1581) Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>

view details

Marwan Sulaiman

commit sha a03c3306fc71527ede2b5eb6efea229d3a1e00ea

go.mod: update/use google cloud storage sub module (#1588) * go.mod: update/use google cloud storage sub module * downgrade grpc because v1.27.1 has a breaking change * stay in 1.12 for now

view details

Aaron Schlesinger

commit sha 130963486b6baf1a665135be3f6c351dc5581260

Adding notes for how to do a release (#1576) * Adding notes for how to do a release * Changes thanks @marwan-at-work and @twexler * bumping to get netlify to run (again) Co-authored-by: Ted Wexler <ted@stuckinacan.com>

view details

push time in 6 days

issue openedosscda/kedahttp

Sidestep the proxy when 1 or more pods are running.

If there is at least 1 pod running, an incoming request will connect somewhere, so there's little reason for a proxy to sit in the middle. When the system has no pods running, the proxy will need to hold the request and forward it after the first pod has scaled up.

The proxy will always need to keep metrics to control scaling.

created time in 6 days

push eventosscda/kedahttp

Aaron Schlesinger

commit sha 962764969f1c7589a1653136fad53ccf685014c9

Update README.md

view details

push time in 6 days

push eventarschles/keda

Aaron Schlesinger

commit sha 33b1b6b346752b9aaccdf824064c5570814a9198

adding go vet to the pre-commit config file Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 6 days

push eventarschles/keda

Aaron Schlesinger

commit sha c59cbf40a335aff4b30170a53e9352a3279fb0e5

adding go vet to the pre-commit config file

view details

push time in 6 days

push eventarschles/keda

Aaron Schlesinger

commit sha e4b8d325dbf0af293d72d5342e39edb24ee7f791

Not running govet or gofmt in Dockerfile builds Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 6 days

PR opened kedacore/keda

Reviewers
Not running govet or gofmt in Dockerfile builds

<!-- Thank you for contributing!

 Read more about how you can contribute in our contribution guide:
 https://github.com/kedacore/keda/blob/master/CONTRIBUTING.md

-->

Since we have code quality checks on the v2 branch, they will run prior to any docker build operation. That means that the go fmt and go vet calls inside the Dockerfile are redundant. This change removes them by creating two new makefile targets: adapter-dockerfile and manager-dockerfile, and changing the adapter and manager dockerfiles to call those two targets, respectively.

Checklist

  • [ ] Commits are signed with Developer Certificate of Origin (DCO)
  • [ ] Tests have been added
  • [ ] A PR is opened to update the documentation on https://github.com/kedacore/keda-docs
  • [ ] Changelog has been updated

Fixes #1070

+23 -4

0 comment

3 changed files

pr created time in 6 days

create barncharschles/keda

branch : gofmt

created branch time in 6 days

push eventarschles/keda

Aaron Schlesinger

commit sha d2cafd66c4a367573d7886577376a3ba57820a2d

reading timeout from env var, and storing HTTP client in ScalerConfig Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 6 days

pull request commentkedacore/keda

using dedicated HTTP clients

@aman-bansal @zroubalik I commited a change for both reading the timeout from an env var and also putting the HTTP client into the ScalerConfig (instead of changing the signatures for each scaler constructor).

One question that I still have is, in the Metrics API scaler, how should we configure the TLS transport? Currently, I have a TODO on it because if you configure it in the constructor, you'd be setting it on the global HTTP client. See https://github.com/kedacore/keda/pull/1251/files#diff-c832e36c124014f31496fdbc15f77397f48b73855a7b7441fd95525ed6112f54R82

arschles

comment created time in 6 days

push eventarschles/keda

Aaron Schlesinger

commit sha 25a1db3da51b04ae02aed2655b027570364fc07a

reading timeout from env var, and storing HTTP client in ScalerConfig

view details

push time in 6 days

issue commentkedacore/keda

MQTT - based scaler

I would be happy to get started on this.

arschles

comment created time in 6 days

issue openedkedacore/keda

MQTT - based scaler

I'd like to have a scaler listen to an MQTT source and scale up/down based on incoming messages. This would be useful for Kubernetes clusters that run on the edge (for example, in IoT scenarios and in scenarios where k8s is running on underpowered machines)

  • Scaler Source: A scaler to support scaling applications based on incoming MQTT messages. Not intended to support bidirectional communications
  • How do you want to scale: Based on volume of messages on a particular topic
  • Authentication: Two options are username/password auth and advanced (x.509) auth. username/password auth should be sufficient for now, given that you can already place credentials in a secret and pass them into a ScaledObject

created time in 6 days

issue commentkedacore/keda

Decouple go fmt and vet from building docker image

I'm happy to take this on

turbaszek

comment created time in 7 days

issue commentkedacore/keda

Should scalers reuse opened connection/clients?

Would #1133 be a step toward this? in the PR for this #1251 creates a long-lived HTTP client that has an internal connection pool

zroubalik

comment created time in 7 days

issue commentgomods/athens

Who's using Athens in production?

@krishnakumar4a4 your use case is one that we've had in mind for a while. I'm glad to hear that it's working for you

marwan-at-work

comment created time in 7 days

push eventarschles/keda

Aaron Schlesinger

commit sha 50cb279f773dc34ee03af7bab8d52be1b66cdb64

using dedicated HTTP clients fixes https://github.com/kedacore/keda/issues/1133 Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 7 days

Pull request review commentkedacore/keda

using dedicated HTTP clients

 func main() { 	cmd.Flags().AddGoFlagSet(flag.CommandLine) // make sure we get the klog flags 	cmd.Flags().IntVar(&prometheusMetricsPort, "metrics-port", 9022, "Set the port to expose prometheus metrics") 	cmd.Flags().StringVar(&prometheusMetricsPath, "metrics-path", "/metrics", "Set the path for the prometheus metrics endpoint")++	var globalHTTPTimeoutMS int+	cmd.Flags().IntVar(&globalHTTPTimeoutMS, "http-timeout", 300, "The default timeout of all HTTP requests (unless you explicitly set it otherwise)")

Apologies for the delay, I had to give a talk yesterday.

@aman-bansal I agree regarding 1, so I would vote against that personally.

I think I'm on the same page as you regarding 2 and 3. Assuming we have a global timeout variable that you pass into KEDA when you start it up, you could also allow people to override that on a per-trigger basis by passing a timeout in the manifest you submit.

Specific to 3, I'm happy to change it to read from an environment variable rather than a flag. Let me know

arschles

comment created time in 7 days

PullRequestReviewEvent

push eventarschles/dotfiles

Aaron Schlesinger

commit sha ad77e3504ae78d1a1ece09598f8f49aec0365e44

Update bootstrap-linux.sh

view details

push time in 8 days

push eventarschles/dotfiles

Aaron Schlesinger

commit sha 11131ae56662e78bf48ef0b59191f61850b6210a

updated paths

view details

push time in 8 days

push eventarschles/twitch

Aaron Schlesinger

commit sha 427d9201869779b751ce4ef356718018245b5aeb

deleting static dir

view details

push time in 8 days

push eventarschles/twitch

Aaron Schlesinger

commit sha f42fca71b8e712e1e4abf0c36f09297b2c67a6bd

adding stream notes

view details

push time in 8 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha dd4e8ad0c725aea98d199b541c0305d703f97135

add email

view details

push time in 8 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha b747bbdaa9a219d73a57d0f21cbdd0e34459d419

backup plannnnn

view details

push time in 8 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha 92c5c8430a06356c1f2cfda309eea10d8393d056

localhost go server

view details

push time in 8 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha d5280eca46dd66743fc60e3bbfffce87aae24b56

BEFORE I BREAK ANYTHING ELSEEEEEE

view details

push time in 8 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha 28881742b19709d6577cca05f7f1e28a5d0a4ae9

stuf

view details

push time in 8 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha 92b09494b44b92581c0526bbec7de7b8e506ca38

heart

view details

push time in 9 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha dbceb514927cb327444070bebd2d9123a86f9a68

one more slide etc...

view details

push time in 9 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha 0bcff615682e696fbb5ca2f265ef198cb549441c

More fixes

view details

push time in 9 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha 5fd4f2971ce43d8232abdff23e867fcd7df949a4

permanent changes to Go

view details

push time in 9 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha 71af7652e4245cef4fc0ade3f501ead3d2c7ada0

changes

view details

push time in 9 days

Pull request review commentkedacore/keda

using dedicated HTTP clients

 func main() { 	cmd.Flags().AddGoFlagSet(flag.CommandLine) // make sure we get the klog flags 	cmd.Flags().IntVar(&prometheusMetricsPort, "metrics-port", 9022, "Set the port to expose prometheus metrics") 	cmd.Flags().StringVar(&prometheusMetricsPath, "metrics-path", "/metrics", "Set the path for the prometheus metrics endpoint")++	var globalHTTPTimeoutMS int+	cmd.Flags().IntVar(&globalHTTPTimeoutMS, "http-timeout", 300, "The default timeout of all HTTP requests (unless you explicitly set it otherwise)")

My thought process was that this would give a single timeout for all triggers. Would you rather go with a per-trigger timeout?

arschles

comment created time in 9 days

PullRequestReviewEvent

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha 9dab3e79f1bef7c936fad25752f6b5504310fda2

shoutout

view details

Aaron Schlesinger

commit sha 29525acf98abba372d6b5a5d4a7af67984c249e5

more

view details

push time in 12 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha 320042c5bc6517f3e4e11a82cc24587001396ae9

both things work!!!

view details

Aaron Schlesinger

commit sha d7a7d1db49077d0e9551a6c8650cb51813fd8670

cleaning up slides

view details

push time in 12 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha eec782bd9445e953ded2647fffd7ce59d33dd97f

a note

view details

push time in 13 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha e548c35a91953c7fd28316d2766384430bf05554

more stuff!!

view details

push time in 13 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha 3d68cb8d27ee36e2a32ad752f9848d98f3e28c27

more stuff

view details

push time in 13 days

issue openedhashicorp/waypoint

Error on waypoint install for Docker

<!-- Please reserve GitHub issues for bug reports and feature requests.

For questions, the best place to get answers is on our discussion forum, as they will get more visibility from experienced users than the issue tracker.

Please note: We take Waypoint's security and our users' trust very seriously. If you believe you have found a security issue in Waypoint, please responsibly disclose by contacting us at security@hashicorp.com. Our PGP key is available at our security page: https://www.hashicorp.com/security/

-->

Describe the bug Following the getting started guide, the waypoint install --platform=docker -accept-tos command fails with this output:

! Error installing server into docker: Error response from daemon: No such image: hashicorp/waypoint:latest

Steps to Reproduce

Follow the instructions on https://www.waypointproject.io/docs/getting-started (I am running ElementaryOS Hera, which is based on Ubuntu Bionic) up to and including the install command.

Expected behavior

I expected the install to complete successfully.

Additional context

A docker pull hashicorp/waypoint:latest completes successfully.

created time in 13 days

startedhashicorp/waypoint

started time in 13 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha fad047d95da757f53ffd611afb0830c776c0715d

stuff

view details

push time in 14 days

push eventarschles/dotfiles

Aaron Schlesinger

commit sha e51080c74b2ec57f376a319392937ab4763a3be0

Update bootstrap-linux.sh

view details

push time in 14 days

push eventarschles/www

Aaron Schlesinger

commit sha c174edd2e00bbc80e68205e52bc4ea1cdfc40149

Update speaking.md

view details

push time in 15 days

push eventarschles/www

Aaron Schlesinger

commit sha c6f249f7abd3cf39f05e983ddf2b3e412f333eb5

Update speaking.md

view details

push time in 15 days

PR opened kedacore/keda

using dedicated HTTP clients

<!-- Thank you for contributing!

 Read more about how you can contribute in our contribution guide:
 https://github.com/kedacore/keda/blob/master/CONTRIBUTING.md

-->

This attempts to use a dedicated, global HTTP client with a configurable global timeout for all scalers that do HTTP operations. This is a draft PR for now, but I'll update the docs too if the direction is acceptable.

Checklist

  • [ ] Commits are signed with Developer Certificate of Origin (DCO)
  • [x] Tests have been added
  • [ ] A PR is opened to update the documentation on https://github.com/kedacore/keda-docs
  • [ ] Changelog has been updated

Fixes https://github.com/kedacore/keda/issues/1133

+230 -101

0 comment

31 changed files

pr created time in 15 days

create barncharschles/keda

branch : httpclient

created branch time in 15 days

issue commentgomods/athens

Reload DownloadMode file/retrieve from URL

@bored-engineer we talked in Slack:

If we just implemented refresh logic for the existing file case this wouldn't really be a concern right? It becomes a concern when we add fetching from a HTTP endpoint? We could enforce TLS in the provided URL but that's a bit unnecessary in localhost configurations

We should force the download mode URL to use SSL, and then I think this is a fine idea. Also, this is a smaller thing but if you send a PR, make sure to have Athens clearly log when it reloads config, including a timestamp

bored-engineer

comment created time in 15 days

push eventarschles/dotfiles

Aaron Schlesinger

commit sha 10d5b40ec2c8f6c9e56fc67be3547468ae09af94

Update bootstrap-linux.sh

view details

push time in 15 days

issue commentkedacore/keda

Use http.Client instead of http.Get

I would like to work on this. I'll send a draft PR as a start.

aman-bansal

comment created time in 15 days

push eventarschles/dotfiles

Aaron Schlesinger

commit sha e93dd75b3d500ab489078bc33c94111b669ae415

go plugin fix

view details

push time in 15 days

push eventarschles/dotfiles

Aaron Schlesinger

commit sha 6c1d2f12472cef80032963e976d106724417b556

python plugin

view details

push time in 15 days

fork arschles/keda

KEDA is a Kubernetes-based Event Driven Autoscaling component. It provides event driven scale for any container running in Kubernetes

https://keda.sh

fork in 15 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha 824e8cd33172111be9d2e5e026e87f6597b1affa

more

view details

push time in 19 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha b42b956f3933418d964b543c1155974668ac426a

updates

view details

push time in 19 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha d879365759995f0228e1105d451986476b3e272f

starting go server

view details

push time in 19 days

push eventaarons-talks/2020-10-20-All-Things-Open

Aaron Schlesinger

commit sha 647acc0f94502e177b67647a70bcb255cfcc8c82

Python app works

view details

push time in 19 days

issue openedaarons-talks/2020-10-20-All-Things-Open

Python app: set up mypy or other type checking

IDK if this is is already supported by VSCode

created time in 19 days

more