profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/arathyjan/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Arathy Janardhanan arathyjan Thoughtworks Pune

arathyjan/applied-scala 2

From scala course

arathyjan/PayTimeReminder 1

Android app to remind when a insurance or loan emi etc is due.

arathyjan/android-arduino-using-bluetooth 0

This project aims to establish a connection and transfer data between an Android app and a microcontroller (Arduino).

arathyjan/biblioteca 0

Pre course assignment project structure for ThoughtWorks University

arathyjan/chromeapp 0

create a new chrome app

PullRequestEvent

PR closed openmrs/openmrs-distro-referenceapplication

RATEST-95:Failing Test: Edit Form Test

https://issues.openmrs.org/browse/RATEST-95 cc @k-joseph

+10 -7

4 comments

1 changed file

sherrif10

pr closed time in 4 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-93:Failing Test: Delete Form Test

 public void deleteFormTest() throws Exception {      @After     public void tearDown() throws Exception {+	if(headerPage !=null) {

Any reason for adding this

sherrif10

comment created time in 9 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyModulesAvailableOnHomePage() throws Exception {     }      @Test-    public void verifyClerkModulesAvailableOnHomePage() throws Exception {+    public void verifyClerkModulesAvailableOnHomePage() {         goToLoginPage().loginAsClerk();         homePage = new HomePage(page);-        assertPage(homePage);+        assertPage(homePage.waitForPage());         assertTrue(homePage.isActiveVisitsAppPresent());         assertTrue(homePage.isAppointmentSchedulingAppPresent());-        assertTrue(homePage.isRegisterPatientCustomizedForRefAppPresent());

Any reason for removing this

sherrif10

comment created time in 9 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyModulesAvailableOnHomePage() throws Exception {     }      @Test-    public void verifyClerkModulesAvailableOnHomePage() throws Exception {+    public void verifyClerkModulesAvailableOnHomePage() {         goToLoginPage().loginAsClerk();         homePage = new HomePage(page);-        assertPage(homePage);+        assertPage(homePage.waitForPage());         assertTrue(homePage.isActiveVisitsAppPresent());         assertTrue(homePage.isAppointmentSchedulingAppPresent());

Any reason for removing this

sherrif10

comment created time in 9 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyModulesAvailableOnHomePage() throws Exception {     }      @Test-    public void verifyClerkModulesAvailableOnHomePage() throws Exception {+    public void verifyClerkModulesAvailableOnHomePage() {         goToLoginPage().loginAsClerk();         homePage = new HomePage(page);-        assertPage(homePage);+        assertPage(homePage.waitForPage());         assertTrue(homePage.isActiveVisitsAppPresent());         assertTrue(homePage.isAppointmentSchedulingAppPresent());-        assertTrue(homePage.isRegisterPatientCustomizedForRefAppPresent());

Any reason for removing this

sherrif10

comment created time in 9 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

Add @Category(BuildTests.class) annotation before verifyClerkModulesAvailableOnHomePage() , verifyDoctorModulesAvailableOnHomePage(), verifyNurseModulesAvailableOnHomePage(), verifySysadminModulesAvailableOnHomePage()

sherrif10

comment created time in 9 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

RATEST-95:Failing Test: Edit Form Test

You need to go through the logs and resolve them and then you can push the ticket to code review

sherrif10

comment created time in 9 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

RATEST-141: Fix find patient by name test

Waiting the page to load ensures that the entered patient identifier matches with the test created patient identifier. Otherwise without waiting the page to load, the comparison is made against the searched patient identifierwith any of the existing patient in the db server instanceinstead of thetest created patient

kdaud

comment created time in 9 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-140: Fix find patient record test

 public void deletePatient() throws Exception {         deletePatient(patient);     } -    @Ignore-    @Category(org.openmrs.reference.groups.BuildTests.class)-    public void testFindPatientRecord() throws InterruptedException {+    @Test+    @Category(BuildTests.class)+    public void findPatientRecordTest() {         FindPatientPage findPatientPage = homePage.goToFindPatientRecord();         findPatientPage.enterPatient(patient.identifier);

Waiting the page to load ensures that the patient identifier entered matches with the test created patient identifier. Otherwise without waiting the page to load, the comparison is made against the entered patient identifier with any of the existing patient instead of the test created patient

kdaud

comment created time in 10 hours

PR opened openmrs/openmrs-distro-referenceapplication

RATEST-141: Fix find patient by name test

Ticket ID: https://issues.openmrs.org/browse/RATEST-141

Description Fix find patient by name test

+8 -4

0 comment

1 changed file

pr created time in 11 hours

PR closed openmrs/openmrs-distro-referenceapplication

RATEST-141: Fix Find Patient By Name Test

Ticket ID: https://issues.openmrs.org/browse/RATEST-141

Description Fix Find Patient By Name

+8 -4

0 comment

1 changed file

kdaud

pr closed time in 11 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Ratest 153: Fix duplicate patient register test

 public void duplicateRegisterTest() throws InterruptedException, ParseException         sdf.applyPattern(NEW_FORMAT);         newBirthDate = sdf.format(date); -         String info = registrationPage.getSimilarPatientInfo();         assertThat(info, Matchers.is(patient.gender + ", " + newBirthDate + ", " + patient.address1 + " " + patient.address2 + " " + patient.city + patient.state + patient.country + patient.postalCode ));     } -

Get rid of these spaces

Have you had a look at the second commit that emphasizes quality assurance

kdaud

comment created time in 17 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Ratest 153: Fix duplicate patient register test

 public void duplicateRegisterTest() throws InterruptedException, ParseException         sdf.applyPattern(NEW_FORMAT);         newBirthDate = sdf.format(date); -         String info = registrationPage.getSimilarPatientInfo();         assertThat(info, Matchers.is(patient.gender + ", " + newBirthDate + ", " + patient.address1 + " " + patient.address2 + " " + patient.city + patient.state + patient.country + patient.postalCode ));     } -

Get rid of these spaces

kdaud

comment created time in 17 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyNurseModulesAvailableOnHomePage() throws Exception {     public void verifySysadminModulesAvailableOnHomePage() throws Exception {

True i aggree since adding a waitForPage handles that

sherrif10

comment created time in 17 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyNurseModulesAvailableOnHomePage() throws Exception {     public void verifySysadminModulesAvailableOnHomePage() throws Exception {

And herealso

sherrif10

comment created time in 18 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyDoctorModulesAvailableOnHomePage() throws Exception {     public void verifyNurseModulesAvailableOnHomePage() throws Exception {

Here as well

sherrif10

comment created time in 18 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyClerkModulesAvailableOnHomePage() throws Exception {     public void verifyDoctorModulesAvailableOnHomePage() throws Exception {

And here

sherrif10

comment created time in 18 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyModulesAvailableOnHomePage() throws Exception {     public void verifyClerkModulesAvailableOnHomePage() throws Exception {

Even here

sherrif10

comment created time in 18 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

     public void verifyModulesAvailableOnHomePage() throws Exception {

Remove the throws

sherrif10

comment created time in 18 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-135: Fix Add User Test

      private static final String URL = "/admin/index.htm"; -    private static final By MANAGE_USERS = By.cssSelector("#legacyui-manageUsers a");

The element does not exist ??

Lab report indicates clearly that the current property attribute for the element

kdaud

comment created time in 19 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-135: Fix Add User Test

      private static final String URL = "/admin/index.htm"; -    private static final By MANAGE_USERS = By.cssSelector("#legacyui-manageUsers a");

Investigation Lab report indicates clearly that the current property attribute for the element does not exist.

The element does not exist ??

kdaud

comment created time in 19 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

MF-562: Overall Baseline Metadata for 3.0 Packaging

cc: @k-joseph @dkayiwa

alaboso

comment created time in 19 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-135: Fix Add User Test

      private static final String URL = "/admin/index.htm"; -    private static final By MANAGE_USERS = By.cssSelector("#legacyui-manageUsers a");

Any reason why changing to the defined full url

Investigation report indicates clearly that the current property attribute for the element does not exist. Apart from the suggested property, the element can also be retrieved via its id, xpath, linkText and others but in terms ofelementLoadTime, the suggested one takes less time to retrieve the element than any other attribute can do. Putting quality assurance in mind, the suggested property is given a priority

kdaud

comment created time in 19 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-145: Fix end visit test

 public void setUp() throws Exception {     }      @Test-    @Ignore     @Category(BuildTests.class)-    public void EndVisitTest() throws Exception {+    public void endVisitTest() {         FindPatientPage findPatientPage = homePage.goToFindPatientRecord();         findPatientPage.enterPatient(patient.identifier);         ClinicianFacingPatientDashboardPage clinicianFacingPatientDashboardPage = findPatientPage.clickOnFirstPatient();         PatientVisitsDashboardPage patientVisitsDashboardPage = clinicianFacingPatientDashboardPage.goToRecentVisits();         patientVisitsDashboardPage = patientVisitsDashboardPage.endVisit();-        assertNull(patientVisitsDashboardPage.getActiveVisit());

Have tested this by ignoring and it passed,

After a deep simulation with my virtual remote server on CI Vs Bamboo, I discovered that by just removing @ignore annotation, the test passes with CI But fails with Bamboo. Ideally I trust bamboo test result than CI report. Though the element that is consumed by getActiveVisit() method passes with startVist test when assertNotNull() is applied But the element becomes no longer attached to the DOM when assertNull() is applied. Different element looks ups (id(), xpath(), linkText()) have a similar case.

do you think this change is necessary

Its from the reason above that we rather use assertTrue() function since it achieves the same goal in this case

kdaud

comment created time in 19 hours

PR opened openmrs/openmrs-distro-referenceapplication

Ratest 153: Fix duplicate patient register test

Ticket ID: https://issues.openmrs.org/browse/RATEST-153

Description Fix duplicate patient register test

+3 -10

0 comment

1 changed file

pr created time in 20 hours

pull request commentopenmrs/openmrs-contrib-android-client

AC-906 : Re-Designed Home Screen UI

@LuGO0 ok, sure thanks for the follow-up...

sahuadarsh0

comment created time in a day

pull request commentopenmrs/openmrs-contrib-android-client

AC-906 : Re-Designed Home Screen UI

Hi @sahuadarsh0 thanks for continuously resolving the merge conflicts, we have just delayed merging of all PRs in the backlog. I will let you know when we will be ready to merge this PR and then we can work on this PR again.

sahuadarsh0

comment created time in a day

pull request commentopenmrs/openmrs-distro-referenceapplication

MF-562: Overall Baseline Metadata for 3.0 Packaging

I have resolved the conflict.

Hopefully the WS issue gets resolved soon so we revert platform verion to 2.4.0 (refapp-3.0)

alaboso

comment created time in 2 days

push eventopenmrs/openmrs-sdk

openmrs-bot

commit sha 5b8b5a6ec86c326cdb0359c36086ee8f204d9386

[maven-release-plugin] prepare for next development iteration

view details

push time in 2 days