profile
viewpoint
Anna Kocheshkova annakocheshkova @akvelon, @Microsoft Russia, Ivanovo Developer at @akvelon

annakocheshkova/cordova-plugin-code-push 1

Cordova plugin for CodePush

annakocheshkova/active-directory-b2c-android-native-msal 0

This is a simple Android app showcasing how to use MSAL to authenticate users via Azure Active Directory B2C, and access a Web API with the resulting tokens.

annakocheshkova/active-directory-b2c-dotnet-desktop 0

Sample showing how a Windows Desktop .NET (WPF) application can sign in a user using Azure AD B2C, get an access token using MSAL.NET and call an API.

annakocheshkova/active-directory-b2c-ios-swift-native-msal 0

An iOS sample in Swift that authenticates Azure AD B2C users and calls an API using OAuth 2.0

annakocheshkova/appcenter-sampleapp-react-native 0

A sample App Center application written in React Native.

annakocheshkova/AppCenter-SDK-Android 0

Development repository for the App Center SDK for Android

annakocheshkova/AppCenter-SDK-Apple 0

Development repository for the App Center SDK for iOS

annakocheshkova/appcenter-sdk-cordova 0

App Center Preview SDK for Cordova

created tagmicrosoft/appcenter-sdk-unity

tag3.3.1

Development repository for the App Center SDK for Unity platforms, including Android, iOS, and UWP

created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentmicrosoft/appcenter-sdk-unity

App Center post-build does not override custom URL Scheme

 private static void OnPostprocessInfo(PlistDocumentWrapper info, AppCenterSettin                 setStringMethod.Invoke(urlType, new object[] { "CFBundleTypeRole", "None" });                 setStringMethod.Invoke(urlType, new object[] { "CFBundleURLName", ApplicationIdHelper.GetApplicationId() });                 var urlSchemes = urlType.GetType().GetMethod("CreateArray").Invoke(urlType, new[] { "CFBundleURLSchemes" });-                urlSchemes.GetType().GetMethod("AddString").Invoke(urlSchemes, new[] { "appcenter-" + settings.iOSAppSecret });++                // Add custom schemes defined in Unity players settings.+                foreach (var scheme in schemes)+                {+                    urlSchemes.GetType().GetMethod("AddString").Invoke(urlSchemes, new[] { scheme });

Why don't we have a null check here as well?

AnastasiaKubova

comment created time in 15 days

Pull request review commentmicrosoft/appcenter-sdk-unity

App Center post-build does not override custom URL Scheme

 private static void OnPostprocessInfo(PlistDocumentWrapper info, AppCenterSettin     {         if (settings.UseDistribute && AppCenter.Distribute != null)         {-            // Add App Center URL sceme.+            // Add App Center URL scemes.+            var schemes = new List<string>() { "appcenter-" + settings.iOSAppSecret  };++            // Create a reflection call for getting custom schemes from iOS settings.+            Type playerSettingsClass = typeof(PlayerSettings.iOS);+            MethodInfo iOSURLSchemesMethod = playerSettingsClass.GetMethod("GetURLSchemes", BindingFlags.Static | BindingFlags.NonPublic);++            // Verify that method is exist and call it for getting custom schemes.+            if (iOSURLSchemesMethod != null)+            {+                var schemesFromSettings = (string[])iOSURLSchemesMethod.Invoke(null, null);

Can it throw?

AnastasiaKubova

comment created time in 15 days

Pull request review commentmicrosoft/appcenter-sdk-unity

App Center post-build does not override custom URL Scheme

 # App Center SDK for Unity Change Log +## Release 3.3.1 (Under development)++### App Center++#### iOS++* **[Fix]** Fix override custom `URLScheme` in the post-build script.
* **[Fix]** Fix overriding custom `URLScheme` in the post-build script.
AnastasiaKubova

comment created time in 15 days

Pull request review commentmicrosoft/appcenter-sdk-unity

App Center post-build does not override custom URL Scheme

 private static void OnPostprocessInfo(PlistDocumentWrapper info, AppCenterSettin     {         if (settings.UseDistribute && AppCenter.Distribute != null)         {-            // Add App Center URL sceme.+            // Add App Center URL scemes.+            var schemes = new List<string>() { "appcenter-" + settings.iOSAppSecret  };++            // Create a reflection call for getting custom schemes from iOS settings.+            Type playerSettingsClass = typeof(PlayerSettings.iOS);+            MethodInfo iOSURLSchemesMethod = playerSettingsClass.GetMethod("GetURLSchemes", BindingFlags.Static | BindingFlags.NonPublic);++            // Verify that method is exist and call it for getting custom schemes.
            // Verify that method exists and call it for getting custom schemes.
AnastasiaKubova

comment created time in 15 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

issue closedmicrosoft/plcrashreporter

Timestamp value is nil in SystemInfo

Hi,

I am using PLCrashreporter in my project. I want to fetch the timestamp when the report was generated by using report.systemInfo.timestamp, but this comes as nil. It is written in the document that it may be nil if the date is unavailable. Any help would be helpful in figuring out the reason for it to be coming as nil and what workaround is recommended to resolve it.

Platform - IOS Simulator

closed time in 18 days

PravinPushkar

issue commentmicrosoft/plcrashreporter

Timestamp value is nil in SystemInfo

Hey! Have you got any more questions? If so, please let us know. For now I'm going to close this issue.

PravinPushkar

comment created time in 18 days

issue commentmicrosoft/appcenter-sdk-react-native

Archive failed with return code: 65

I don't think our SDK does anything specific related to jsbundle, but this feels to me like a question more related to the App Center build system. Could you go over to App Center and open a support ticket there? Our support team should connect you with Build engineering team.

ibrahimyolbir

comment created time in 21 days

issue commentmicrosoft/appcenter-sdk-react-native

Archive failed with return code: 65

Hi there @maxckelly! So you created and passed these files manually similar to @ibrahimyolbir before, right? What exactly is the error you are getting after? Is it "No JSBundle"?

ibrahimyolbir

comment created time in 21 days

issue commentmicrosoft/plcrashreporter

Timestamp value is nil in SystemInfo

Hi there! This value is collected via C++ time() method. Here are some of the reasons this value can be null (or -1, under the hood). What kind of simulator do you use (iOS version, etc)? Is there a chance the time is incorrect there?

As a workaround, I can suggest checking for this value at the moment of loading the crash and adding a fallback:

NSData *data = [reporter loadPendingCrashReportDataAndReturnError: &error];
PLCrashReport *report = [[PLCrashReport alloc] initWithData: data error: &error];
if (report.systemInfo.timestamp == nil) { ... }
PravinPushkar

comment created time in 21 days

issue commentmicrosoft/appcenter-sdk-dotnet

Packaged desktop app in partial trust mode does not report events

Great! Let us know if there are any problems. I'm closing the ticket for now.

FreddyD-GH

comment created time in 22 days

issue closedmicrosoft/appcenter-sdk-dotnet

Packaged desktop app in partial trust mode does not report events

Description

The AppCenter SDK does not send any information to the server when running a WPF app that is packaged and running in partial trust.

Repro Steps

Please list the steps used to reproduce your issue.

  1. Create a WPF app and add the basic App Center SDK setup
  2. Add a "Windows Application Packaging Project" to the solution
  3. Under the "Applications" node, add a reference to the Wpf app
  4. Change the "Trust Level" in the properties of the referenced app from "Full Trust" to "Partial Trust"

Details

  1. What is your app platform (Xamarin.Android or Xamarin.iOS or UWP)?
    • WPF (.net core 3.1)
  2. Which SDK version are you using?
    • 3.4.0
  3. Which OS version did you experience the issue on?
    • Windows 10 (ver 2004)
  4. What device version did you see this error on? Were you using an emulator or a physical device?
    • Physical device
  5. What third party libraries are you using?
    • None
  6. Please enable verbose logging for your app using AppCenter.LogLevel = LogLevel.Verbose before your call to AppCenter.Start(...) and include the logs here:
2020-08-14 16:23:22.386 [AppCenter] DEBUG: Creating database at: C:\Users\freddy\AppData\Local\Packages\6c5343aa-f273-46cc-bab5-995aae08e034_ma242gh8qbk8m\AC\Microsoft\AppCenter\d3070778-1a9b-4380-98b4-8e0ae8e4957b\Logs.db
2020-08-14 16:23:22.490 [AppCenter] DEBUG: AddChannel(core)
2020-08-14 16:23:22.601 [AppCenter] INFO: App Center SDK configured successfully.
2020-08-14 16:23:22.638 [AppCenter] DEBUG: AddChannel(analytics)
2020-08-14 16:23:22.681 [AppCenterAnalytics] DEBUG: SessionTracker.Resume
2020-08-14 16:23:22.713 [AppCenter] DEBUG: Invoke EnqueuingLog event for channel 'analytics'
2020-08-14 16:23:22.867 [AppCenter] INFO: 'Analytics' service started.
2020-08-14 16:23:22.901 [AppCenter] DEBUG: AddChannel(crashes)
2020-08-14 16:23:22.953 [AppCenter] INFO: 'Crashes' service started.
2020-08-14 16:23:23.007 [AppCenter] DEBUG: Invoke EnqueuingLog event for channel 'core'

closed time in 22 days

FreddyD-GH
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventmicrosoft/appcenter-cli

Anna Kocheshkova

commit sha 0002d28281699bec877743e6e5995997c7f884f6

Move task

view details

push time in a month

push eventmicrosoft/appcenter-cli

Anna Kocheshkova

commit sha 4315662db3f66427faf040cd0daae6c0e8ba88f8

Add step to CI

view details

push time in a month

Pull request review commentmicrosoft/appcenter-cli

Consume appcenter-file-upload-client-node as a package

 jobs:    - script: |       npm run test:ci || [ -f './test-results.xml' ]-    displayName: 'Run tests (with JUnit output)'+    displayName: 'Run CLI tests (with JUnit output)'    - task: PublishTestResults@2     inputs:       testResultsFormat: 'JUnit'       testResultsFiles: 'test-results.xml'       searchFolder: '$(Build.SourcesDirectory)'       failTaskOnFailedTests: true-      testRunTitle: 'Unit tests'-    displayName: 'Verify unit test result'+      testRunTitle: 'CLI unit tests'+    displayName: 'Verify CLI unit test result'++  - script: |+      npm ci+      npm run build+    displayName: 'Install and build appcenter-file-upload-client-node'+    workingDirectory: appcenter-file-upload-client-node++  - script: |+      npm run test:ci || [ -f './test-results.xml' ]+    displayName: 'Run appcenter-file-upload-client-node tests'+    workingDirectory: appcenter-file-upload-client-node++  - task: PublishTestResults@2+    inputs:+      testResultsFormat: 'JUnit'+      testResultsFiles: 'test-results.xml'+      searchFolder: '$(Build.SourcesDirectory)/appcenter-file-upload-client-node'+      failTaskOnFailedTests: true+      testRunTitle: 'appcenter-file-upload-client-node unit tests'+    displayName: 'Verify appcenter-file-upload-client-node unit test result'

We have npm install here, and if it doesn't work, then testing step will fail. I don't see similar verification steps for the npm i for CLI so not sure why we need it?

russelarms

comment created time in a month

Pull request review commentmicrosoft/appcenter-cli

Consume appcenter-file-upload-client-node as a package

   },   "dependencies": {     "abort-controller": "^3.0.0",+    "appcenter-file-upload-client-node": "1.0.0",

I don't think they are somehow related.

russelarms

comment created time in a month

Pull request review commentmicrosoft/appcenter-cli

Consume appcenter-file-upload-client-node as a package

   },   "preferGlobal": true,   "scripts": {-    "build": "npm run lint && gulp build:raw",+    "build-ac-fus": "cd appcenter-file-upload-client-node && npm run build",+    "build": "npm run build-ac-fus && npm run lint && gulp build:raw",

I don't think we need it. For CI, we have this step, similar to building the cli itself.

russelarms

comment created time in a month

push eventmicrosoft/appcenter-cli

Anna Kocheshkova

commit sha 186cb2b998152ea8943b9018082e127100ca425e

Remove extra entry

view details

push time in a month

pull request commentmicrosoft/appcenter-cli

Consume appcenter-file-upload-client-node as a package

@jp-andre it has not appeared on the 2nd run. Probably a flaky one, since we're talking to the real AppCenter API.

russelarms

comment created time in a month

push eventmicrosoft/appcenter-cli

Anna Kocheshkova

commit sha eb2b8d4b994e535dd519ef743e70c53a63d0b69d

Fix CI

view details

push time in a month

push eventmicrosoft/appcenter-cli

Anna Kocheshkova

commit sha 35754218b1de0374434e8ee5ee8a257bef53391b

Fix installation

view details

push time in a month

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 7185a193805d5d19c822732749f49c2c1b4985e9

Apply suggestions from code review Co-authored-by: Clement Polet <clpolet@microsoft.com>

view details

push time in a month

PR opened microsoft/appcenter-sdk-apple

Fix logs sent inside applicaitonWillTerminate

Things to consider before you submit the PR:

  • [x] Has CHANGELOG.md been updated?
  • [X] Are tests passing locally?
  • [X] Are the files formatted correctly?
  • [x] Did you add unit tests?
  • [X] Did you check UI tests on the sample app? They are not executed on CI.
  • [X] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Logs sent from applicationWillTerminate were not being saved because of dispatch_async call. To fix this, we add a task to the logsQueue and wait for it inside applicationWillTerminate event.

Related PRs or issues

https://github.com/microsoft/appcenter-sdk-apple/issues/2123/

Misc

AB#81803

+130 -0

0 comment

7 changed files

pr created time in a month

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha f04f0545777e0275779352930ffcf39841eb61bb

Make timeout smaller

view details

push time in a month

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha f7dd85b41f48c17d98cba3f642b61c50cc7748c1

Add tests

view details

push time in a month

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 54b550fa1b573f17979af427534a815362762246

Rename and add block to parameter

view details

push time in a month

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 08ec47096b338630cdc1dc61447242d51f92b909

Rename method, do some cleanup

view details

push time in a month

push eventmicrosoft/appcenter-sdk-apple

Anastasia Kubova

commit sha ea811824e56442d61b2b2a83960ffad1b0ae0d91

Add script for sorting schemes

view details

Anastasia Kubova

commit sha 5f0662f69f862b05877de233d379bce40944d757

Resolve feedback

view details

Anastasia Kubova

commit sha 7c50ee71f2879c82ff95ffbb44898369b39c887d

Formatting

view details

Ivan Matkov

commit sha b49bf54078fa8c4ecb5511b5f57a5ed6a83d44ac

Apply suggestions from code review Co-authored-by: Clement Polet <clpolet@microsoft.com>

view details

Ivan Matkov

commit sha f7b7a463c0697badcea5426aaef340fcacfd2142

Merge pull request #2133 from microsoft/fix/add-sort-schemes-script Add script to sort schemes in the project

view details

Anna Kocheshkova

commit sha 09e85a7c7b571411590707e497b4c56197abc94b

Fix sending logs from applicationWillTerminate

view details

Anna Kocheshkova

commit sha 2aad88575909bef274790c409feeced87a54a6a2

Separate method into util

view details

push time in a month

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha a764c2d6118d730ec5e63944f348614a8e78bd55

Remove unused code

view details

push time in 2 months

Pull request review commentmicrosoft/appcenter-sdk-apple

Fix for late applicationWillTerminate call

  @implementation MSChannelGroupDefault +static volatile uint32_t _hasEnteredApplicationWillTerminate;

Will be confusing now that it is a property

annakocheshkova

comment created time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha c0a1b8dcdb0af574fedcf5811dfef1d098e65001

Address feedback

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 040b50c9e8ca1978074da43732e3625fd7b8ae9a

Simplify syntax

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 3c902a424be6db234b62fd4a8251c683d514fd77

Fix tests

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha ac924b614fb1673be3dcc2a2e2798ac0ee9b1db3

Add conditionals for macOS

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 6e53b5d91e849d6c72de5be27c073a72ba83f51a

Move the test

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Ivan Matkov

commit sha cbef8f8774d9705d59f8e2376bc37057e56cf65f

Add analyze and test yaml for iOS

view details

Ivan Matkov

commit sha 11668a778b27430ac4b665e3bc3b46722f3a3708

Explicit set sdk and configuration

view details

Ivan Matkov

commit sha 8322ee50a9efe666aef73ac1f101ea19a4f99827

Recursive checkout

view details

Ivan Matkov

commit sha e0e75e1c12ed86bfcfecf12deac0283848bd0614

Add analyze and test for other platforms

view details

Ivan Matkov

commit sha 65c36be683c6475a93385e55c518123b3f6074fe

Use one template for all platforms

view details

Ivan Matkov

commit sha 3a143d226abb9aea5a29879147cf533b16ca792b

Build frameworks pipeline

view details

Ivan Matkov

commit sha 4bb0751eea61bdd0d12b4ff3b62dadb3a2a7ec53

Use default (latest) Xcode for analyze and test

view details

Ivan Matkov

commit sha e92e3c4d71995ace5d32f14b8248ef94513c3588

Build test apps pipeline

view details

Ivan Matkov

commit sha 015a6652de35febbf9d59de7a97648c1eb7bfa8b

Add triggers

view details

Ivan Matkov

commit sha 5ff436631ffc667cdf03c5150c11cfaca7110b73

Merge pull request #2143 from microsoft/v-ivmatk/azdo-yaml Migrate CI to YAML files

view details

Anna Kocheshkova

commit sha 17c319bb98d4591a1ecc48a36690fff165682c14

Merge branch 'develop' into bug/applicationwillterminate-logs

view details

Anna Kocheshkova

commit sha b79b27b51524ccd83a079dca8f7c2f7387ab9a35

Merge branch 'bug/applicationwillterminate-logs' into applicationwillterminate-fix

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Ivan Matkov

commit sha cbef8f8774d9705d59f8e2376bc37057e56cf65f

Add analyze and test yaml for iOS

view details

Ivan Matkov

commit sha 11668a778b27430ac4b665e3bc3b46722f3a3708

Explicit set sdk and configuration

view details

Ivan Matkov

commit sha 8322ee50a9efe666aef73ac1f101ea19a4f99827

Recursive checkout

view details

Ivan Matkov

commit sha e0e75e1c12ed86bfcfecf12deac0283848bd0614

Add analyze and test for other platforms

view details

Ivan Matkov

commit sha 65c36be683c6475a93385e55c518123b3f6074fe

Use one template for all platforms

view details

Ivan Matkov

commit sha 3a143d226abb9aea5a29879147cf533b16ca792b

Build frameworks pipeline

view details

Ivan Matkov

commit sha 4bb0751eea61bdd0d12b4ff3b62dadb3a2a7ec53

Use default (latest) Xcode for analyze and test

view details

Ivan Matkov

commit sha e92e3c4d71995ace5d32f14b8248ef94513c3588

Build test apps pipeline

view details

Ivan Matkov

commit sha 015a6652de35febbf9d59de7a97648c1eb7bfa8b

Add triggers

view details

Ivan Matkov

commit sha 5ff436631ffc667cdf03c5150c11cfaca7110b73

Merge pull request #2143 from microsoft/v-ivmatk/azdo-yaml Migrate CI to YAML files

view details

Anna Kocheshkova

commit sha 17c319bb98d4591a1ecc48a36690fff165682c14

Merge branch 'develop' into bug/applicationwillterminate-logs

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha a0389845034503b7f34a1066e411cf1ba7a19e86

Add callback to channel unit

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha d05e39823eee838926f8925afa08c009e7e27238

Address feedback

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 9b9fec11f49ec6724c244bb082b93718c1a5dc6c

Fix another test

view details

push time in 2 months

Pull request review commentmicrosoft/appcenter-sdk-apple

Fix for late applicationWillTerminate call

 #import "MSLogDBStorage.h"  static char *const kMSLogsDispatchQueue = "com.microsoft.appcenter.ChannelGroupQueue";+static BOOL _hasEnteredApplicationWillTerminate = NO;

We do not hold a reference to channel group by its units, so it needs to be static

annakocheshkova

comment created time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 292ab1b25678bf31d88b8c79cbe3f5a21eadefa1

Add another way of synchronization for static field

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha b810f5bdbc56ca64f55939408555b9e230009dff

Address feedback

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 88034f7792d386f4c7fc547585b9648c025d25d6

Do not store the flag

view details

push time in 2 months

PR opened microsoft/appcenter-sdk-apple

Fix for late applicationWillTerminate call

Things to consider before you submit the PR:

~* [ ] Has CHANGELOG.md been updated?~

  • [X] Are tests passing locally?
  • [X] Are the files formatted correctly?
  • [X] Did you add unit tests?
  • [X] Did you check UI tests on the sample app? They are not executed on CI.
  • [X] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

In case user subscription to applicationWillTerminate event fires later than ours, we still need to store logs synchronously.

+22 -6

0 comment

3 changed files

pr created time in 2 months

create barnchmicrosoft/appcenter-sdk-apple

branch : applicationwillterminate-fix

created branch time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 269dd348eb628cb5929edc36f2d88d343f0b710a

Add changelog and verify step

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 591a3e9fdd39a7130dce020a7d437c1235b7599a

Address feedback

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 00cb347e4f6fca9d5eb0b6d97ee2a02f04ce83f4

Add targetConditionals

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha c25db0c5fb8aea0fbff3218a0a52de244c21fc0c

Another fix

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha f549298c2fe2840f97d5643437d34019a7246f10

Fix build

view details

push time in 2 months

Pull request review commentmicrosoft/appcenter-sdk-apple

Fix logs sent inside applicationWillTerminate

 - (void)channel:(id<MSChannelProtocol>)channel didResumeWithIdentifyingObject:(i  - (void)setEnabled:(BOOL)isEnabled andDeleteDataOnDisabled:(BOOL)deleteData { +#if !TARGET_OS_OSX+  if (isEnabled) {+    [MS_NOTIFICATION_CENTER addObserver:self

Could be. One possible solution is to use a special flag inside our callback and handle it later but seems like a bit of overkill. What do you think?

annakocheshkova

comment created time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 8d97c428a03ee478bba0accf538c0428be216ae9

Add tests

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha c5c68796d9caac64d042a99c4ceb05fe08d9f01f

Add unused parameter

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 76349485ed539bf2415664e60cf7aeb5d0e27a31

Add conditions

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 4cf49a67baeaf874c4410de99383b097a12814e7

Address feedback

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-apple

Anna Kocheshkova

commit sha 594e1ec334c17a1e619dadce7dfef5ac3f164746

Fix comment

view details

push time in 2 months

PR opened microsoft/appcenter-sdk-apple

Fix logs sent inside applicationWillTerminate

Things to consider before you submit the PR:

  • [ ] Has CHANGELOG.md been updated?
  • [X] Are tests passing locally?
  • [X] Are the files formatted correctly?
  • [ ] Did you add unit tests? Not yet
  • [X] Did you check UI tests on the sample app? They are not executed on CI.
  • [X] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Logs sent from applicationWillTerminate were not being saved because of dispatch_async call. To fix this, we add a task to the logsQueue and wait for it inside applicationWillTerminate event.

Related PRs or issues

https://github.com/microsoft/appcenter-sdk-apple/issues/2123/

Misc

AB#81803

TODO: unit tests

+28 -0

0 comment

2 changed files

pr created time in 2 months

create barnchmicrosoft/appcenter-sdk-apple

branch : bug/applicationwillterminate-logs

created branch time in 2 months

Pull request review commentmicrosoft/appcenter-sdk-android

Add set ndk script to post clone

 #!/usr/bin/env bash echo "Executing post clone script in `pwd`" echo "dimension.dependency=$DIMENSION_DEPENDENCY" >> $APPCENTER_SOURCE_DIRECTORY/local.properties+../scripts/set-ndk-version.sh

I think it's more convenient to store them all in one folder

annakocheshkova

comment created time in 2 months

PR opened microsoft/appcenter-sdk-android

Add set ndk script to post clone

~* [ ] Has CHANGELOG.md been updated?~ ~* [ ] Are tests passing locally?~ ~* [ ] Did you add unit tests?~ ~* [ ] Did you check UI tests on the sample app? They are not executed on CI.~

  • [X] Are the files formatted correctly?
  • [X] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Fix App Center build for Android 11.

+1 -0

0 comment

1 changed file

pr created time in 2 months

create barnchmicrosoft/appcenter-sdk-android

branch : v-annkoc/fix-ac-build

created branch time in 2 months

PullRequestEvent

PR closed microsoft/appcenter-sdk-android

Add a script that uses latest CI NDK version

~* [ ] Has CHANGELOG.md been updated?~ ~* [ ] Are tests passing locally?~ ~* [ ] Did you add unit tests?~ ~* [ ] Did you check UI tests on the sample app? They are not executed on CI.~

  • [X] Are the files formatted correctly?
  • [X] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Due to this gradle update, in case several NDK versions are installed (like on our CI), it takes the default, not the latest one, so as a result CI uses 18th NDK which breaks the build.

The solution per the documentation is to set the version in gradle: ndkVersion = '21.3.6528147', which we are doing on CI in order not to break local and future builds.

Related PRs or issues

AB#82284

NOTE: Don't forget to enable the corresponding task on CI after merging.

+21 -0

0 comment

1 changed file

annakocheshkova

pr closed time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha 17a426cb7c11a627ab0ddb5a473c7eb07c8c675a

Update scripts/set-ndk-version.sh Co-authored-by: Ivan Matkov <v-ivmatk@microsoft.com>

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha f4101c128c6c785657d1b310438a2c3fa33b38e9

Update script

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha a7c1527bfb442f3d30747da620ebcadb82cd6871

Apply feedback

view details

Anna Kocheshkova

commit sha 2ca296d4b4e08dceeb515e936d0f17e8cb034e6e

Merge branch 'v-annkoc/ndk-script' of https://github.com/microsoft/appcenter-sdk-android into v-annkoc/ndk-script

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha e51b53d1c6c14ef696530d13f989c7a2ec8fd1e0

Update scripts/set-ndk-version.sh Co-authored-by: Guillaume Perrot <guperrot@github.com>

view details

push time in 2 months

PullRequestEvent

PR closed microsoft/appcenter-sdk-android

Add a script that uses latest CI NDK version

~* [ ] Has CHANGELOG.md been updated?~ ~* [ ] Are tests passing locally?~ ~* [ ] Did you add unit tests?~ ~* [ ] Did you check UI tests on the sample app? They are not executed on CI.~

  • [X] Are the files formatted correctly?
  • [X] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Due to this gradle update, in case several NDK versions are installed (like on our CI), it takes the default, not the latest one, so as a result CI uses 18th NDK which breaks the build.

The solution per the documentation is to set the version in gradle: ndkVersion = '21.3.6528147', which we are doing on CI in order not to break local and future builds.

Related PRs or issues

AB#82284

NOTE: Don't forget to enable the corresponding task on CI after merging.

+23 -0

0 comment

1 changed file

annakocheshkova

pr closed time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha f35fbee4d96d2d12dd0da34a609b5c34976887c0

Apply feedback

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha 04e706e5dc8aef3dbe95e4cd462e1304a3135515

Cleanup

view details

push time in 2 months

PR opened microsoft/appcenter-sdk-android

Add a script that uses latest CI NDK version

~* [ ] Has CHANGELOG.md been updated?~ ~* [ ] Are tests passing locally?~

  • [X] Are the files formatted correctly? ~* [ ] Did you add unit tests?~
  • [X] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change? ~* [ ] Did you check UI tests on the sample app? They are not executed on CI.~

Description

Due to this gradle update, in case several NDK versions are installed (like on our CI), it takes the default, not the latest one, so as a result CI uses 18th NDK which breaks the build.

The solution per the documentation is to set the version in gradle: ndkVersion = '21.3.6528147', which we are doing on CI in order not to break local and future builds.

Related PRs or issues

AB#82284

+25 -0

0 comment

1 changed file

pr created time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha d6d471dc52cd2a6ec9004c58a0a85a73d577d447

Add set-ndk-version script

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha 16c546ffb10b31953e39fbf579a5c236795a4017

Simplify echo

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha 2a75bef1b372898808cf844987bd92625de04a71

Write to file

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha f395ad419989b8989b91d44bdf87264b69cac20a

Add quotes and new line

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha 1a0729215b88bd1e2b2d19a31ffd39f352b6edb6

Fix spaces

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha 147559f76cab233ecbafa43a47caa4a185633fae

Fix the spaces

view details

push time in 2 months

push eventmicrosoft/appcenter-sdk-android

Anna Kocheshkova

commit sha 588d153ee0b291c64d508cfe2b51a59431a99674

Fix sed

view details

push time in 2 months

more