profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/angshu/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
angshuman sarkar angshu Bangalore, India

openmrs/openmrs-module-bedmanagement 7

The Bed Management module brings in the data model, DAO entities, services and REST API layers for managing beds, admission locations and all other backend entities that relates to IPD Ward Management.

KalyanAkella/twist-maven-plugin 2

A Maven plugin for executing Twist scenarios through POM.xml

angshu/formidable-android-client 1

android client for Formidable

angshu/mchs_config 1

A sample configuration setup for bahmni.

angshu/formidable 0

Data collection platform for ICT4H

angshu/formidable-server 0

server app for formidable

angshu/openmrs-core 0

OpenMRS API and web application code

angshu/openmrs-module-aijar 0

Electronic Medical Records system for Uganda

pull request commentopenmrs/openmrs-distro-referenceapplication

RATEST-115:Un Ignore SearchActiveVisitTest

could you please share those changes you thing are needed to we added, otherwise it works as expected on headless =true

sherrif10

comment created time in 14 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

RATEST-115:Un Ignore SearchActiveVisitTest

There is no more work to be done here i guess

@sherrif10 you may be right. While testing your changes I realised there could be some little work to be done. If you do not mind test these changes once again with chromeheadless set to true. Some thing like headless=true

sherrif10

comment created time in 14 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

RATEST-115:Un Ignore SearchActiveVisitTest

There is no more work to be done here i guess, i tested this work on both chrome driver and firefox driver and all was well unless am getting your point mistakenly thanks

sherrif10

comment created time in 14 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

RATEST-115:Un Ignore SearchActiveVisitTest

Have tested the changes locally but there could be some more work to do. Do you mind testing these changes with chromeheadless instance

sherrif10

comment created time in 14 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

RATEST-115:Un Ignore SearchActiveVisitTest

Hello @kaweesi could we merge this please

sherrif10

comment created time in 15 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-74:Failing Test:Ignored AddFormTests

     private static String REST_PATH_2 = "'\"]";     private static By CALENDAR_EYE_FORM = By.id("w1-display");     private static By DATAPICKER_YEAR = By.className("ui-datepicker-year");-    private static By DATAPICKER_MONTH = By.className("ui-datepicker-moth");+    private static By DATAPICKER_MONTH = By.className("ui-datepicker-month");

Pr to fix the error logged in here https://github.com/openmrs/openmrs-distro-referenceapplication/pull/359

sherrif10

comment created time in 15 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-74:Failing Test:Ignored AddFormTests

     private static String REST_PATH_2 = "'\"]";     private static By CALENDAR_EYE_FORM = By.id("w1-display");     private static By DATAPICKER_YEAR = By.className("ui-datepicker-year");-    private static By DATAPICKER_MONTH = By.className("ui-datepicker-moth");+    private static By DATAPICKER_MONTH = By.className("ui-datepicker-month");

sure this is a typo error, Last meeting on TAC cal we discussed of resolving these bugs along uitest automatation Test

sherrif10

comment created time in 16 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-74:Failing Test:Ignored AddFormTests

     private static String REST_PATH_2 = "'\"]";     private static By CALENDAR_EYE_FORM = By.id("w1-display");     private static By DATAPICKER_YEAR = By.className("ui-datepicker-year");-    private static By DATAPICKER_MONTH = By.className("ui-datepicker-moth");+    private static By DATAPICKER_MONTH = By.className("ui-datepicker-month");

are you sure this class is renamed in the hosting module? if not you can have this refactoring/renaming change in a separate ticket such that it's all tracked at once

sherrif10

comment created time in 17 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-74:Failing Test:Ignored AddFormTests

+package org.openmrs.reference.page;++import org.openmrs.uitestframework.page.Page;+import org.openqa.selenium.By;++public class HtmlFormsPage extends Page {++    private static final By NEW_HTML_FORM = By.cssSelector("a[href='htmlForm.form']");+    private static final By NAME = By.name("form.name");+    private static  By DESCRIPTION = By.name("form.description");+    private static  By SAVE_FORM = By.cssSelector("input[type=\"submit\"]");+    private  static By VERSION = By.name("form.version");++    public HtmlFormsPage(ManageHtmlFormsPage page) {+        super(page);+    }++   public void setNAME(String name) throws InterruptedException {+        driver.findElement(NAME).clear();+        driver.findElement(NAME).sendKeys("newFormTest");+        driver.findElement(NAME).getAttribute("value");+    }+    public  void setDESCRIPTION(String description) {+       driver.findElement(DESCRIPTION).clear();+      driver.findElement(DESCRIPTION).sendKeys("description");+      driver.findElement(DESCRIPTION).getAttribute("value");+    }+   public void setVERSION(String integer){

these attribute setting methods can all be merged into one method such as createNewTestForm()

sherrif10

comment created time in 17 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-74:Failing Test:Ignored AddFormTests

  */ public class AddFormTest extends TestBase {     private HomePage homePage;+    private static final By NEW_HTML_FORM = By.cssSelector("a[href='htmlForm.form']");+    private static final By NAME = By.name("form.name");+    private static  By DESCRIPTION = By.name("form.description");+    private  static By VERSION = By.name("form.version");+    private static  By SAVE_FORM = By.cssSelector("input[type=\"submit\"]");+    private static  By HOME = By.id("homeNavLink");+     private HeaderPage headerPage;     private ManageFormsPage manageForm;     private ClinicianFacingPatientDashboardPage patientDashboardPage;+    private AdministrationPage administrationPage;+    private ManageHtmlFormsPage manageHtmlFormsPage;+    private HtmlFormsPage htmlFormsPage;      @Before     public void setUp() throws Exception {         homePage = new HomePage(page);-        assertPage(homePage);+        homePage.goToAdministration().clickOnManageHtmlForms().clickOnNewHtmlForm();+        driver.manage().timeouts().implicitlyWait(0,TimeUnit.SECONDS);++        driver.findElement(NAME).clear();

you can move all this page functionality into the respective page @sherrif10

sherrif10

comment created time in 17 hours

pull request commentopenmrs/openmrs-module-coreapps

RA-1711: Program Enrollment Widget should allow enrollment date of program to be equal to completion date of previous program

If they do not exist already, adding some tests for the comparator would be great. 😊

mogoodrich

comment created time in 17 hours

issue openedBahmni/openmrs-module-bahmniapps

ADT patient page launched from patient has no option to select bed after clicking twice on dropdown bar

Hi Developer Team,

i found following Bug:

When i go to the ADT page from the patient and try to e.g. admit the patient, the beds disappear when i open and close the dropdown.

ADTBug

If i want to look through my departments as user, i cannot go back because the beds are not displayed anymore.

On the InPatient Module, there is already a green button on the right side of the header which allows switching.

Bildschirmfoto 2021-04-17 um 15 42 12

I think just enabling this button in this mentioned page before solves this issue.

Current Workaround is a page reload. (But i think this is not that user-friendly also on tablets)

I would like to fix it and open PR since it should be a simple AngularJS condition somewhere, if you accept this issue.

Best regards, Johannes

created time in a day

PR opened ProjectEKA/hiu-ui

[Security] Bump ssri from 6.0.1 to 6.0.2

Bumps ssri from 6.0.1 to 6.0.2. This update includes a security fix. <details> <summary>Vulnerabilities fixed</summary> <p><em>Sourced from <a href="https://github.com/advisories/GHSA-vx3p-948g-6vhq">The GitHub Security Advisory Database</a>.</em></p> <blockquote> <p><strong>Regular Expression Denial of Service (ReDoS)</strong> npm <code>ssri</code> 5.2.2-6.0.1 and 7.0.0-8.0.0, processes SRIs using a regular expression which is vulnerable to a denial of service. Malicious SRIs could take an extremely long time to process, leading to denial of service. This issue only affects consumers using the strict option.</p> <p>Affected versions: >= 5.2.2 < 6.0.2</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md">ssri's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/zkat/ssri/compare/v6.0.1...v6.0.2">6.0.2</a> (2021-04-07)</h2> <h3>Bug Fixes</h3> <ul> <li>backport regex change from 8.0.1 (<a href="https://github.com/zkat/ssri/commit/b30dfdb">b30dfdb</a>), closes <a href="https://github-redirect.dependabot.com/zkat/ssri/issues/19">#19</a></li> </ul> <p><!-- raw HTML omitted --><!-- raw HTML omitted --></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/ssri/commit/b7c8c7c61db89aeb9fbf7596c0ef17071bc216ef"><code>b7c8c7c</code></a> chore(release): 6.0.2</li> <li><a href="https://github.com/npm/ssri/commit/b30dfdb00bb94ddc49a25a85a18fb27afafdfbb1"><code>b30dfdb</code></a> fix: backport regex change from 8.0.1</li> <li>See full diff in <a href="https://github.com/npm/ssri/compare/v6.0.1...v6.0.2">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~nlf">nlf</a>, a new releaser for ssri since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+3 -3

0 comment

1 changed file

pr created time in 2 days

create barnchProjectEKA/hiu-ui

branch : dependabot/npm_and_yarn/ssri-6.0.2

created branch time in 2 days

push eventopenmrs/openmrs-esm-patient-chart

Florian Rappl

commit sha 253c4aeadb3c27eb471091eb465ce07f2431519a

Refinement of workspace handling

view details

Florian Rappl

commit sha 147393d8ce6abeca759e2538ed12e1ed3842b8e2

Merge branch 'feature/monorepo' of https://github.com/openmrs/openmrs-esm-patient-chart into feature/monorepo

view details

Florian Rappl

commit sha defe93bdaf7a6e451d6f3482e7aac7de45f1b376

Visit implementation

view details

push time in 2 days

Pull request review commentopenmrs/openmrs-module-htmlformentry

HTML-419:EncounterProviderAndRole and encounterProvider tags should display retired providers at the bottom,also add includeRetired

 public String generateHtml(FormEntryContext context) { 		sb.append("</option>"); 		 		for (Provider provider : providers) {-			sb.append("\n<option ");-			if (initialValue != null && initialValue.equals(provider))-				sb.append("selected=\"true\" ");-			sb.append("value=\"" + provider.getId() + "\">")-			        .append(provider.getPerson() != null-			                ? HtmlFormEntryUtil.getFullNameWithFamilyNameFirst(provider.getPerson().getPersonName())-			                : provider.getName())-			        .append("</option>");+			if (provider.getRetired()) {

Would be nice to have a screenshot of how this looks.

HerbertYiga

comment created time in 2 days

Pull request review commentopenmrs/openmrs-module-htmlformentry

HTML-419:EncounterProviderAndRole and encounterProvider tags should display retired providers at the bottom,also add includeRetired

 public static Object getProviderRole(String id) { 		} 	} 	+	//gets retired and non retired providers+	public static List<Provider> getRetiredAndNonRetiredProviders(List<String> providerRoleIds,

This seems like a lot of duplicate code from the existing getProviders method.

Instead of creating this new method, could we:

  • change the existing List<Provider> getAllProviders() method on line 2444 to "List<Provider> getAllProviders(boolean includeRetired)

  • change the getProviders method above (line 2426) to take in a third parameter, "includeRetired"

  • for backwards compatibility, create a getProviders(List<String> providerRolesId, boolean returnAllIfNoRolesSpecified) that just calls the new method we created above with includeRetired=false?

And while we are at it, add or modify any existing unit tests to test this.

Then see my comment below of how we would use this...

HerbertYiga

comment created time in 2 days

Pull request review commentopenmrs/openmrs-module-htmlformentry

HTML-419:EncounterProviderAndRole and encounterProvider tags should display retired providers at the bottom,also add includeRetired

 public EncounterProviderAndRoleTag(Map<String, String> parameters) { 		providerWidgetSeparator = TagUtil.parseParameter(parameters, "providerWidgetSeparator", String.class, ", "); 		encounterRole = TagUtil.parseParameter(parameters, "encounterRole", EncounterRole.class); 		autocompleteProvider = TagUtil.parseParameter(parameters, "autocompleteProvider", Boolean.class, false);+		includeRetired = TagUtil.parseParameter(parameters, "includeRetired", Boolean.class, true);

I know the original specifications said this should default to true, it looks like in the current behavior, retired providers are excluded by default, so let's default this property to false.

HerbertYiga

comment created time in 2 days

Pull request review commentopenmrs/openmrs-module-htmlformentry

HTML-419:EncounterProviderAndRole and encounterProvider tags should display retired providers at the bottom,also add includeRetired

 public EncounterProviderAndRoleTag(Map<String, String> parameters) { 		providerWidgetSeparator = TagUtil.parseParameter(parameters, "providerWidgetSeparator", String.class, ", "); 		encounterRole = TagUtil.parseParameter(parameters, "encounterRole", EncounterRole.class); 		autocompleteProvider = TagUtil.parseParameter(parameters, "autocompleteProvider", Boolean.class, false);+		includeRetired = TagUtil.parseParameter(parameters, "includeRetired", Boolean.class, true); 		providerMatchMode = TagUtil.parseParameter(parameters, "providerMatchMode", MatchMode.class, MatchMode.ANYWHERE); 		defaultValue = TagUtil.parseParameter(parameters, "default", Provider.class); 		providerRoles = TagUtil.parseListParameter(parameters, "providerRoles", String.class); 		if (!autocompleteProvider) {-			providers = HtmlFormEntryUtil.getProviders(providerRoles, true);+			if (!includeRetired) {

If we made the changes I suggested above, I think we could replace this whole block with: providers = HtmlFormEntryUtil.getProviders(providerRoles, true, includeRetire)

HerbertYiga

comment created time in 2 days

PullRequestEvent

PR opened Bahmni/bahmni-package

Bah 1181 new
+1 -1

0 comment

1 changed file

pr created time in 2 days

push eventopenmrs/openmrs-module-coreapps

mgoodrich

commit sha bcdab2c4656718a8dfbf3e945ae1a412ea3905d5

RA-1911: Program Enrollment Widget should allow enrollment date of program to be equal to completion date of previous program tweak based on PR feedback

view details

push time in 2 days

push eventopenmrs/openmrs-module-coreapps

mgoodrich

commit sha d960bb6d3deee1f9791331d0472f28062f2e2fad

RA-1913: Core Apps Program Status widget doesn't handle existing patient programs with retired states

view details

push time in 2 days

pull request commentopenmrs/openmrs-module-uicommons

EMPT-84: Fixed XSS in "other" drug input (uicommons)

The only changes were this and the allergyui change, from the updated versions of the module. When I am back to my desktop I will try again and record the exact details.

maxhark

comment created time in 2 days

push eventopenmrs/openmrs-esm-patient-chart

Vineet Sharma

commit sha d0e2c1ae7f09cb4c5928e41a9b9752bc60b84888

New structure for the actions button on patient-banner, in extension to issue MF-500 (#220)

view details

push time in 2 days

PR merged openmrs/openmrs-esm-patient-chart

MF-500: New structure for the actions button on patient-banner extensions.

What does this PR do? This PR changes the structure of the CustomOverflowMenu that was created earlier. The new structure allows adding the menu items from different esm-modules. Previously, CustomOverflowMenuItem component was being used, which couldn't be used in every esm-module, so the new structure allows the freedom from this component and adding the class into either button/link in the new extensions will do the work.

+17484 -4

2 comments

9 changed files

vasharma05

pr closed time in 2 days

push eventopenmrs/openmrs-module-coreapps

mgoodrich

commit sha 2383dbf776e9328066d16d442fb019f9fd1e5018

UHM-5266: Program Widget: better handle retired/missing workflows

view details

push time in 2 days

Pull request review commentopenmrs/openmrs-module-openconceptlab

OCLOMRS-870:Unable to import a private dictionary through Subscription Module

 public OclResponse fetchOclConcepts(String url, String token) throws IOException     public GetMethod executeExportRequest(String url, String collectionVersion) throws IOException{
 
 		GetMethod exportUrlGet = getExportUrl(url, collectionVersion);
+		if (!StringUtils.isBlank(token)) {
+			get.addRequestHeader("Authorization", "Token " + token);
+			get.addRequestHeader("Compress", "true");
+		}
		if (!StringUtils.isBlank(token)) {
			exportUrlGet.addRequestHeader("Authorization", "Token " + token);
		}

Note that we're also going to need to pass the token into this function.

jwnasambu

comment created time in 2 days

Pull request review commentopenmrs/openmrs-module-openconceptlab

OCLOMRS-870:Unable to import a private dictionary through Subscription Module

 public OclResponse fetchSnapshotUpdates(String url, String token, Date updatedSi 		bytesDownloaded = 0;
 		
 		GetMethod get = new GetMethod(url);
-		if (!StringUtils.isBlank(token)) {
-			get.addRequestHeader("Authorization", "Token " + token);
-			get.addRequestHeader("Compress", "true");
-		}

We definitely want to leave this here!

jwnasambu

comment created time in 2 days