profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/andrewvaughanj/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Andrew V. Jones andrewvaughanj @VectorSoftwareRI Cornwall

andrewvaughanj/alacritty 1

A cross-platform, OpenGL terminal emulator.

andrewvaughanj/folly_1444 1

Reproducer for https://github.com/facebook/folly/issues/1444

andrewvaughanj/boolector 0

A Satisfiability Modulo Theories (SMT) solver for the theories of fixed-size bit-vectors, arrays and uninterpreted functions.

andrewvaughanj/btor2tools 0

A generic parser and tool package for the BTOR2 format.

andrewvaughanj/cadical 0

CaDiCaL SAT Solver

andrewvaughanj/CBT_for_Ada_Examples 0

Examples for the Ada Europe 2016 Paper: Change-based Testing for Ada

andrewvaughanj/cgreen 0

A modern, portable, cross-language unit testing and mocking framework for C and C++

andrewvaughanj/cmake-microchip 0

CMake modules for the Microchip embedded toolchain

CommitCommentEvent

pull request commentjenkinsci/vectorcast-execution-plugin

BugzID: 92851 - Futureproof New Reporting API Check

I'd rather see something simple like:

try:
   from vector.apps import DataAPI
   return True
except:
   return False

You already have logic almost identical to that here:

  • https://github.com/jenkinsci/vectorcast-execution-plugin/blob/cadb15ddc0cc11353102912050c2cf696dc891dc/src/main/resources/scripts/generate-results.py#L59

Also, it should be except ImportError.

vapdrs

comment created time in a day

issue commentfacebook/infer

Unable to build facebook-clang-plugins due to `CMAKE_LINKER-NOTFOUND`

Seems pretty conclusive:

  • CMake 3.21.1, no lld: CMAKE_LINKER:FILEPATH=CMAKE_LINKER-NOTFOUND

  • CMake 3.21.2, no lld: CMAKE_LINKER:FILEPATH=/usr/bin/ld

  • CMake 3.21.3, no lld: CMAKE_LINKER:FILEPATH=/usr/bin/ld

  • CMake 3.21.1, with lld: CMAKE_LINKER:FILEPATH=/usr/bin/ld.lld

andrewvaughanj

comment created time in a day

issue commentfacebook/infer

Infer 1.1 does not capture/analyze files when the compiler is set to `/usr/bin/gcc` in Makefile but works fine when `gcc` is used

This is sort of expected; infer capture works by inserting a "fake" gcc (or clang) on the front of $PATH, such that the compilation commands get redirected to the infer versions, which capture the execution.

For example:

avj@platypus /tmp/temp$ cat Makefile
all:
	which gcc

avj@platypus /tmp/temp$ make
which gcc
/usr/bin/gcc
avj@platypus /tmp/temp$ /home/avj/clones/infer/main/infer/bin/infer capture -- make
Capturing in make/cc mode...
which gcc
/home/avj/clones/infer/main/infer/lib/wrappers/gcc

If you've got a hard-coded gcc in your Makefile, then infer can't "redirect" this to its own wrapper around gcc.

zyh1121

comment created time in 3 days

issue commentfacebook/infer

Unable to build facebook-clang-plugins due to `CMAKE_LINKER-NOTFOUND`

Doing 2 (i.e., updating to CMake 3.21.3) resolves the issue (i.e., CMAKE_LINKER is set to /usr/bin/ld not CMAKE_LINKER-NOTFOUND).

andrewvaughanj

comment created time in 3 days

issue openedfacebook/infer

Unable to build facebook-clang-plugins due to `CMAKE_LINKER-NOTFOUND`

I'm trying to build infer @ 23a915e (well, #1532) but my build fails with:

: && /usr/bin/cmake -E rm -f /home/avj/tmp/clang-setup.LYj2xK/build/lib/clang/12.0.1/lib/linux/libclang_rt.fuzzer_
interceptors-x86_64.a && /home/avj/tmp/clang-setup.LYj2xK/build/bin/llvm-ar qc /home/avj/tmp/clang-setup.LYj2xK/bu
ild/lib/clang/12.0.1/lib/linux/libclang_rt.fuzzer_interceptors-x86_64.a  lib/fuzzer/CMakeFiles/RTfuzzer_intercepto
rs.x86_64.dir/FuzzerInterceptors.cpp.o && /home/avj/tmp/clang-setup.LYj2xK/build/bin/llvm-ranlib /home/avj/tmp/cla
ng-setup.LYj2xK/build/lib/clang/12.0.1/lib/linux/libclang_rt.fuzzer_interceptors-x86_64.a && cd /home/avj/tmp/clan
g-setup.LYj2xK/build/tools/clang/runtime/compiler-rt-bins/lib/fuzzer/cxx_x86_64_merge.dir && CMAKE_LINKER-NOTFOUND
 --whole-archive /home/avj/tmp/clang-setup.LYj2xK/build/lib/clang/12.0.1/lib/linux/libclang_rt.fuzzer_interceptors
-x86_64.a --no-whole-archive /home/avj/tmp/clang-setup.LYj2xK/build/tools/clang/runtime/compiler-rt-bins/lib/fuzze
r/libcxx_fuzzer_x86_64/lib/libc++.a -r -o fuzzer_interceptors.o && /home/avj/tmp/clang-setup.LYj2xK/build/bin/llvm
-objcopy --localize-hidden fuzzer_interceptors.o && /usr/bin/cmake -E remove /home/avj/tmp/clang-setup.LYj2xK/buil
d/lib/clang/12.0.1/lib/linux/libclang_rt.fuzzer_interceptors-x86_64.a && /home/avj/tmp/clang-setup.LYj2xK/build/bi
n/llvm-ar qcs /home/avj/tmp/clang-setup.LYj2xK/build/lib/clang/12.0.1/lib/linux/libclang_rt.fuzzer_interceptors-x86_64.a fuzzer_interceptors.o
/bin/sh: line 1: CMAKE_LINKER-NOTFOUND: command not found

I'm yet to try it, but it seems there's two causes:

  1. You don't have lld installed: https://gitlab.kitware.com/cmake/cmake/-/issues/22500#note_993575
  2. Your CMake is "too old" (it was only fixed in August 2021 and so is in CMake 3.21.2; https://gitlab.kitware.com/cmake/cmake/-/commit/788b7afff20a59bada4dbb21418d9f83290996c6)

This is more of an FYI if other people hit the same issue.

created time in 3 days

PR opened facebook/infer

Use 'force' over 'batch' when applying patches

As part of #1532 it was seen that clang/setup.sh used --batch when calling patch. The --batch option has the following description (from https://man7.org/linux/man-pages/man1/patch.1.html):

       -t  or  --batch
          Suppress questions like -f, but make some different
          assumptions: skip patches whose headers do not contain file
          names (the same as -f); skip patches for which the file has
          the wrong version for the Prereq: line in the patch; and
          assume that patches are reversed if they look like they are.

comparatively, --force has the following description:

       -f  or  --force
          Assume that the user knows exactly what he or she is doing,
          and do not ask any questions.  Skip patches whose headers do
          not say which file is to be patched; patch files even though
          they have the wrong version for the Prereq: line in the patch;
          and assume that patches are not reversed even if they look
          like they are.  This option does not suppress commentary; use
          -s for that.

So, importantly, the "big difference" between -f and -t is that batch "assume[s] that patches are reversed if they look like they are" -- this clearly isn't good when moving to later LLVM versions, as it means the facebook-clang-plugins patches can "undo" upstream changes.

Therefore, this PR simply changes clang/setup.sh to use --force rather than --batch.

Signed-off-by: Andrew V. Jones andrewvaughanj@gmail.com

Please see CONTRIBUTING.md for how to set up your development environment and run tests.

+1 -1

0 comment

1 changed file

pr created time in 3 days

push eventandrewvaughanj/infer

push time in 3 days

create barnchandrewvaughanj/infer

branch : patch_use_force

created branch time in 3 days

push eventandrewvaughanj/infer

Andrew V. Jones

commit sha ddc4f83878fca95707903b736f90c5e6e231c36d

Use 'force' over 'batch' when applying patches Signed-off-by: Andrew V. Jones <andrewvaughanj@gmail.com>

view details

push time in 3 days

PR opened facebook/infer

Patch missing 'limits' in facebook-clang-plugins #1407

With the update to LLVM 12 (87a3d2708a0e2c09046ae5cc376d7e680b4995da) the patch I added in #1409 to avoid a missing <limits> now gets treated as an "accidentally reversed" patch. This is because upstream (== LLVM 12) now includes the #include that #1409 added, which is why patch tries to remove <limits>:

+ for PATCH_FILE in ${CLANG_PREBUILD_PATCHES[*]}
+ patch --batch -p 1
patching file llvm-project/llvm/utils/benchmark/src/benchmark_register.h
Reversed (or previously applied) patch detected!  Assuming -R.
+ popd

In trying to resolve this issue I also noticed that there's also libcxx/utils/google-benchmark/src/benchmark_register.h, which has the same "original" problem (that is, it uses std::numeric_limits without #include <limits>). See: https://github.com/llvm/llvm-project/blob/llvmorg-12.0.1/libcxx/utils/google-benchmark/src/benchmark_register.h#L4

Therefore, this PR does two things:

  1. It removes the patch against llvm/utils/benchmark/src/benchmark_register.h (as this file is now correct upstream)
  2. It patches libcxx/utils/google-benchmark/src/benchmark_register.h to also include <limits> (as it doesn't do this upstream)

Signed-off-by: Andrew V. Jones andrewvaughanj@gmail.com

+2 -2

0 comment

1 changed file

pr created time in 3 days

create barnchandrewvaughanj/infer

branch : numeric_limits_patch

created branch time in 3 days

delete branch andrewvaughanj/infer

delete branch : master

delete time in 3 days

push eventandrewvaughanj/infer

Jules Villard

commit sha b3405e6a864231090fe4e70337082fe7ec42cc0c

[pulse] refactor models of malloc/alloc/new/... Summary: There was some code duplication between the various models of memory allocators. Planning to add `new` and `new[]` soon so starting with this refactor. Reviewed By: skcho Differential Revision: D30425966 fbshipit-source-id: d3692aa6b

view details

Jules Villard

commit sha 087c6f3f48868fc6b65949c41cdd67041281ac81

[clang][minor] use a Pvar.t map to store C++ temporaries markers Summary: We store only pvars in there. Reviewed By: skcho Differential Revision: D30455862 fbshipit-source-id: 277ae089f

view details

Jules Villard

commit sha a65ee487a3fe2a264c074316ecc968bc4f24e170

[clang][minor] set the location of injected destructors correctly Summary: This only makes a difference in the HTML output as far as I can tell but it was always confusing to find the destructor node at the beginning of blocks and functions instead of at the end, where they semantically occur. Reviewed By: skcho Differential Revision: D30455863 fbshipit-source-id: c66f8dced

view details

Jules Villard

commit sha c84faa3f7c0b972aa93c086f3aa489839be917cd

[clang][minor] fix typo and comment formatting Summary: . Reviewed By: skcho Differential Revision: D30455861 fbshipit-source-id: a500eee24

view details

Sungkeun Cho

commit sha a47cf83831cc6f44df5f5af74cdc7d0f0daff862

[ConfigImpact] Log if strict mode enabled or not Reviewed By: ngorogiannis Differential Revision: D30515823 fbshipit-source-id: 3754ca55b

view details

Nikos Gorogiannis

commit sha 9fb1258b8bf1d0ed4a4959891061547a901a45a9

[buck][java] change stanza name Summary: The new version of the infer buck flavours understands the config stanza `infer`, not `infer_java`. Reviewed By: jvillard Differential Revision: D30540942 fbshipit-source-id: e2a735da4

view details

Matteo Marescotti

commit sha 0d7d70bd34c1795e73242a2dda3dfac84bbf9241

[erlang] support OTP 25 anno format Summary: From OTP 25 anno can be a tuple of two integers `{line_number, column_number}`. This diff adds support during both the json AST extraction and parsing. Differential Revision: D30574556 fbshipit-source-id: a4cd1e3fa

view details

Nikos Gorogiannis

commit sha 3ce84b35388f165f14d77d17ca38a3c375114475

[java] ignore some Sawja exceptions caused by Kotlin files Reviewed By: ezgicicek Differential Revision: D30510781 fbshipit-source-id: 95783baed

view details

Sungkeun Cho

commit sha f1a54e79ce2af8d2bf1b72edbf18494927ed492c

[ConfigImpact] Log if strict mode enabled or not (fix) Reviewed By: ezgicicek Differential Revision: D30574637 fbshipit-source-id: f09ee60f4

view details

Ezgi Çiçek

commit sha 812a9fc606817c05d340ebde62135865c9971476

[inferbo] Add model for Map.get Summary: Add a naive model. Ideally, we should distinguish keys and values so that map.get mentions values (not just some abstract elements). Reviewed By: skcho Differential Revision: D30579701 fbshipit-source-id: ef6297322

view details

Daiva Naudziuniene

commit sha fa4bbd2544cbda66c096779fb359a5844f427c36

[pulse] Show Nil Block Call warnings only for objc blocks Summary: Nil Block Call is ObjectiveC specific issue type, however, we also report it for cpp code when we call function pointer that is nullptr. We want to keep reporting for nullptr call, however, we want to change the issue type from Nil Block Call to NullPtr Dereference. We use call flags to determine if we call objc block. Reviewed By: skcho Differential Revision: D30603571 fbshipit-source-id: 8084d05fb

view details

Jules Villard

commit sha 2ad94599c7f3344085988d72267a976c32f9a094

[clang] create C++ temporaries on CXXBindTemporaryExpr when appropriate Summary: Like `MaterializeTemporaryExpr`, `CXXBindTemporaryExpr` is used by clang to signal that a temporary variable is needed to hold the result of a (sub-)expression. But, unlike the former, the latter only requires a C++ temporary to be created in *some* of the cases, namely when the sub-expression is not performing initialisation for a known variable already (in particular one already created by `MaterializeTemporaryExpr`! Or an actual program variable being assigned). Previously, we were missing creating (and thus destroying) these C++ temporaries when needed. This diff fixes that by registering `CXXBindTemporaryExpr` as a source of C++ temporaries in CScope.ml, and adding logic to destroy only the C++ temporaries that ended up being actually used. Reviewed By: skcho Differential Revision: D30455859 fbshipit-source-id: baf7029eb

view details

Jules Villard

commit sha 094a43c260d4a0fec0f66e7a16759bf980470683

[pulse] move code around before modification Summary: Move one module definition before the other at the former will end up using the latter. Reviewed By: ezgicicek Differential Revision: D30541432 fbshipit-source-id: cc19fae93

view details

Jules Villard

commit sha 56625a6bbb065a451fbd6454b809c4a0158a837c

[clang] destroy temporaries with extended lifetimes too Summary: When a C++ temporary is assigned directly to a ref (lvalue), its lifetime gets extended to that of that lvalue. For example: ``` { X& x = X(); // X() is stored in a C++ temporary, then assigned to x. // In doing so, its lifetime is now that of x instead of // getting destroyed at the end of the statement ... stuff ... } // end of the scope of x: destroy the temporary ``` Before this diff, we would skip destroying these temporaries (instead of destroying them without taking into their lifetime extension, which would have been worse). Now we correctly destroy them. Reviewed By: ezgicicek Differential Revision: D30541430 fbshipit-source-id: e9ce45958

view details

Jules Villard

commit sha 2b20a8de3a040153fe7cdb8f12c2bf43906cdc07

[pulse] watch out for accidental state list collapses Summary: In several models we had a problematic use of the `let<*>/let<+>` operators coupled with returning several possible states: we need to be careful not to collapse *all* these disjuncts to `[Error _]` when only *one* of them is an error. This happens whenever we do ``` let<*> astate1 = ... in let<*> astate2 = ... in [astate1; astate2] ``` This gives the wrong result `[Error _]` when either of these two failed, instead of a two-state result with at least one error in it, eg `[Error err1; astate2]`. The correct way to write these whenever several states are to be returned is to not use the `let<*>`/`let<+>` operators at the top level: ``` let astate1 = let<*> x = ... in ... in let astate2 = ... in [astate1; astate2] ``` Concretely the incorrect behaviour made us miss some coverage and so introduced false negatives. Reviewed By: skcho Differential Revision: D30541428 fbshipit-source-id: af04e4ccf

view details

Jules Villard

commit sha c2961539a6eddc7a3d9b2519c2614f9bf8387cd4

[pulse] call destructor on `delete` Summary: This is the correct behaviour, was missing before. Reviewed By: skcho Differential Revision: D30541431 fbshipit-source-id: 473d5c300

view details

Ezgi Çiçek

commit sha f3f1256d779a4b7394d567d28d3016c07e6f80ff

[refactor] Remove explicit equal and use deriving instead for simple types Summary: As described in the ppx docs, > ... can check for equality using [%compare.equal: ..], which produces a function that returns true precisely when [%compare: ..] returns 0. [%equal: ..] is prefered over [%compare.equal: ..] and in particular is expected to be slightly faster. However, [%compare.equal: ..] can come in handy for types that only have [@deriving compare]. In particular, support for [@deriving equal] was added long after the project started, which means that many types out there only support [deriving compare]. we could just use `deriving equal` instead of defining a separate equal variant which calls `%compare.equal`, especially for simple types. Reviewed By: ngorogiannis Differential Revision: D30667515 fbshipit-source-id: 5d3ed561f

view details

dependabot[bot]

commit sha ab1270ea0be97faabe82c4e52c40948d44d115b0

Bump tar from 6.1.4 to 6.1.11 in /website (#1488) Summary: Bumps [tar](https://github.com/npm/node-tar) from 6.1.4 to 6.1.11. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/node-tar/commit/e573aeea19d4d650908b7f6bf0a1ad8dce9f1736"><code>e573aee</code></a> 6.1.11</li> <li><a href="https://github.com/npm/node-tar/commit/edb8e9a3fa5869cfb935479a262f6f61b0a2ec57"><code>edb8e9a</code></a> fix: perf regression on hot string munging path</li> <li><a href="https://github.com/npm/node-tar/commit/a9d9b05fc974425089922bf66e8e7751ea8bfbbc"><code>a9d9b05</code></a> chore(test): Avoid spurious failures packing node_modules/.cache</li> <li><a href="https://github.com/npm/node-tar/commit/24b8bdadf37118182496ecf81fa7a872196fb38b"><code>24b8bda</code></a> fix(test): use posix path for testing path reservations</li> <li><a href="https://github.com/npm/node-tar/commit/e5a223c6b293f1cb2ebb2dd97668f787e8983ca4"><code>e5a223c</code></a> fix(test): make unpack test pass on case-sensitive fs</li> <li><a href="https://github.com/npm/node-tar/commit/188baddc1d0e6ef5140c7a788f03fc2a6c3df2ea"><code>188badd</code></a> 6.1.10</li> <li><a href="https://github.com/npm/node-tar/commit/23312ce7db8a12c78d0fba96d7664a01619266a3"><code>23312ce</code></a> drop dirCache for symlink on all platforms</li> <li><a href="https://github.com/npm/node-tar/commit/4f1f4a21fca64f3089da0e83ceea775c66b55052"><code>4f1f4a2</code></a> 6.1.9</li> <li><a href="https://github.com/npm/node-tar/commit/875a37e3ec031186fc6599f6807341f56c584598"><code>875a37e</code></a> fix: prevent path escape using drive-relative paths</li> <li><a href="https://github.com/npm/node-tar/commit/b6162c7fafe797f856564ef37f4b82747f051455"><code>b6162c7</code></a> fix: reserve paths properly for unicode, windows</li> <li>Additional commits viewable in <a href="https://github.com/npm/node-tar/compare/v6.1.4...v6.1.11">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tar&package-manager=npm_and_yarn&previous-version=6.1.4&new-version=6.1.11)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/infer/network/alerts). </details> Pull Request resolved: https://github.com/facebook/infer/pull/1488 Reviewed By: skcho Differential Revision: D30694079 Pulled By: ngorogiannis fbshipit-source-id: fa34492dd

view details

Martin Trojer

commit sha 87a3d2708a0e2c09046ae5cc376d7e680b4995da

Update to llvm/clang12 Reviewed By: skcho, jvillard Differential Revision: D30368521 fbshipit-source-id: 7947ece0d

view details

Matteo Marescotti

commit sha 98359fed8d5f049669474715efa06397141332ef

[erlang] perform AST extraction in parallel Summary: Erlang AST extraction performed sequentially can lead to poor performance of big projects. Reviewed By: rgrig Differential Revision: D30669829 fbshipit-source-id: eed04d2ba

view details

push time in 3 days

create barnchandrewvaughanj/infer

branch : main

created branch time in 3 days

delete branch andrewvaughanj/infer

delete branch : origin/main

delete time in 3 days

create barnchandrewvaughanj/infer

branch : json_props

created branch time in 3 days

create barnchandrewvaughanj/infer

branch : origin/main

created branch time in 3 days

issue commentltcmelo/psychec

Compiling on Windows?

Hmm, yeah, I hadn't noticed that it seems this header is used in both "common" and "cfe" -- std::ostream& operator<<(std::ostream& os, const Diagnostic& diagnostic) should only be dllexport inside of "common" and not inside of "cfe".

If those messages are correct, then it seems it has inconsistent linkage inside of those modules (it should be dllexport in "common" and `dllimport" in "cfe").

geekrelief

comment created time in 4 days

issue openedltcmelo/psychec

Re-enable tests on Win32

In #46, psychec's test-suite.exe was disabled (on Win32) as it does not correctly link on that platform.

They were disabled because (at the time of #46) psychec's tests live in psychecfe.{so,dll} and are not correctly exposed (on Windows) in a way that allows test-suite.exe to link against them without link-time errors.

This is a "reminder issue" such that it is not forgotten to re-enable the building/running of those tests later on.

created time in 4 days

PR opened ltcmelo/psychec

Disable 'test-suite' on Win32/MinGW

As discussed in #44 -- currently psychec's tests live in psychecfe.{so,dll} and are not correctly exposed (on Windows) in a way that allows test-suite.exe to link against them.

This PR disables building the tests such that at least cnip.exe can be built on Win32/MinGW without link-time errors (in other parts of the build).

Signed-off-by: Andrew V. Jones andrew.jones@vector.com

+5 -3

0 comment

1 changed file

pr created time in 4 days

create barnchandrewvaughanj/psychec

branch : disable_tests_win32

created branch time in 4 days

issue commentltcmelo/psychec

Handling `#define` in the AST?

There's quite a big difference between Treesitter and something like clang or cnip -- the latter tools parse the preprocessed source code (i.e., after macros have been expanded).

On the other hand, Treesitter parses the code without preprocessing -- this means it can expose some entities in its AST which are macros, but also it cannot parse code (correctly) that depends on the expansion of those macros.

I guess it is a case of: "you win some, you lose some".

geekrelief

comment created time in 4 days

push eventandrewvaughanj/psychec

Andrew V. Jones

commit sha 85f39b1215fd6c5e53d71c3fa638519651a4e3a9

Creating per-library EXPORT symbols (#44) * Creating per-library EXPORT symbols Signed-off-by: Andrew V. Jones <andrew.jones@vector.com> * Removing out of date comment Signed-off-by: Andrew V. Jones <andrew.jones@vector.com>

view details

push time in 4 days

create barnchandrewvaughanj/psychec

branch : export_operators

created branch time in 4 days

Pull request review commentjenkinsci/vectorcast-execution-plugin

BugzID: 92851 - Futureproof New Reporting API Check

 results" in the Publish JUnit test result report configuration.  ## Change Log +### Version 0.71 (21 Sep 2021)+- Updated scripts to use a different method for checking the presence of the+  new reports api. Later versions of VectorCAST will require this version of the

Seriously, "api" in lowercase is grammatically wrong.

vapdrs

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentjenkinsci/vectorcast-execution-plugin

BugzID: 92851 - Futureproof New Reporting API Check

 results" in the Publish JUnit test result report configuration.  ## Change Log +### Version 0.71 (21 Sep 2021)+- Updated scripts to use a different method for checking the presence of the+  new reports api. Later versions of VectorCAST will require this version of the

"The Python support scripts have been updated to attempt importing a module from VectorCAST's DataAPI/reporting API vs. checking for the existence of a pre-compiled Python bytecode file. Such an approach follow's Python's "EAFP" mantra."

(and then don't mention the bit about "later versions" -- a version today and a version after 92851 will both be able to import that module vs. checking for the pyc).

vapdrs

comment created time in 4 days

PullRequestReviewEvent

issue commentltcmelo/psychec

Compiling on Windows?

Compiling with MSVC probably isn't as easy as with MSYS -- especially with things such as the flags that the CMakeLists.txt set.

However the error you've linked in your screenshot (about the operators!) is going to be because it was "partially broken" in the diff I gave.

You should try this again now, because I did set the linkage for the operator<< calls (at least for those that matter).

geekrelief

comment created time in 4 days