profile
viewpoint
Andrew Imm andrewimm Oculus, Facebook, Parse

andrewimm/wasm-gb 56

Game Boy emulator in WebAssembly and WebGL 2.0

andrewimm/parse-lite 38

The universal JS library for Parse Server

andrewimm/babel-plugin-inline-package-json 10

Babel plugin for inlining references to package.json values

andrewimm/js-struct 10

Because sometimes you need to deal with byte structures in JS :nut_and_bolt:

andrewimm/babel-plugin-remove-proptypes 8

Babel plugin for removing static declarations of React propTypes

andrewimm/wasm-c64 5

C64 emulator in WebAssembly and WebGL 2.0

andrewimm/imm-dos-nx 4

A toy protected-mode, multitasking OS for x86, with a subsystem for running DOS programs

andrewimm/ibeam 1

A framework for API clients

andrewimm/binquire 0

Command-line utility that convert binary files to require-able JS files

andrewimm/CommonML 0

Simple OCaml Development Workflow on CommonJS

issue commentfacebook/create-react-app

npx create-react-app my-app is isn't installing the packages and i try uninstalling npm using -g but still.

I actually got this working by doing the following: npm install -g npm@latest

Ahmadzayd

comment created time in 39 minutes

pull request commentparse-community/parse-server

Attempt to remove the schemaCache

Do we need to add Postgres support with the PR already, or can this come at a later stage? @cbaker6 would you want to look into replicating this feature for Postgres?

SebC99

comment created time in an hour

pull request commentparse-community/parse-dashboard

[Snyk] Upgrade query-string from 6.13.6 to 6.13.7

<!-- 0 failure: 0 warning:

1 markdown notices DangerID: danger-id-Peril; -->

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page. <p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> </p>

snyk-bot

comment created time in 2 hours

PR opened parse-community/parse-dashboard

[Snyk] Upgrade query-string from 6.13.6 to 6.13.7

<h3>Snyk has created this PR to upgrade query-string from 6.13.6 to 6.13.7.</h3>

merge advice :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/>

  • The recommended version is 1 version ahead of your current version.
  • The recommended version was released 21 days ago, on 2020-11-05.

<details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>query-string</b></summary> <ul> <li> <b>6.13.7</b> - <a href="https://snyk.io/redirect/github/sindresorhus/query-string/releases/tag/v6.13.7">2020-11-05</a></br><ul> <li>Allow readonly <code>Stringifiable[]</code> in <code>StringifiableRecord</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="736465459" data-permission-text="Title is private" data-url="https://github.com/sindresorhus/query-string/issues/291" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/query-string/pull/291/hovercard" href="https://snyk.io/redirect/github/sindresorhus/query-string/pull/291">#291</a>) <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/query-string/commit/71d84b7901b5f93983f053dc965affe945f8d993/hovercard" href="https://snyk.io/redirect/github/sindresorhus/query-string/commit/71d84b7901b5f93983f053dc965affe945f8d993"><tt>71d84b7</tt></a></li> </ul> <p><a class="commit-link" href="https://snyk.io/redirect/github/sindresorhus/query-string/compare/v6.13.6...v6.13.7"><tt>v6.13.6...v6.13.7</tt></a></p> </li> <li> <b>6.13.6</b> - <a href="https://snyk.io/redirect/github/sindresorhus/query-string/releases/tag/v6.13.6">2020-10-17</a></br><ul> <li>When only receiving values with encoded array value, decode values (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="722611965" data-permission-text="Title is private" data-url="https://github.com/sindresorhus/query-string/issues/287" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/query-string/pull/287/hovercard" href="https://snyk.io/redirect/github/sindresorhus/query-string/pull/287">#287</a>) <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/query-string/commit/b38f06c88faa4a3524b39e992b6096b511ce8309/hovercard" href="https://snyk.io/redirect/github/sindresorhus/query-string/commit/b38f06c88faa4a3524b39e992b6096b511ce8309"><tt>b38f06c</tt></a></li> </ul> <p><a class="commit-link" href="https://snyk.io/redirect/github/sindresorhus/query-string/compare/v6.13.5...v6.13.6"><tt>v6.13.5...v6.13.6</tt></a></p> </li> </ul> from <a href="https://snyk.io/redirect/github/sindresorhus/query-string/releases">query-string GitHub release notes</a> </details> </details>

<details> <summary><b>Commit messages</b></summary> </br> <details> <summary>Package name: <b>query-string</b></summary> <ul> <li><a href="https://snyk.io/redirect/github/sindresorhus/query-string/commit/35846d9cc6442f3e70dffd7657180b0bc00db650">35846d9</a> 6.13.7</li> <li><a href="https://snyk.io/redirect/github/sindresorhus/query-string/commit/71d84b7901b5f93983f053dc965affe945f8d993">71d84b7</a> Allow readonly `Stringifiable[]` in `StringifiableRecord` (#291)</li> </ul>

<a href="https://snyk.io/redirect/github/sindresorhus/query-string/compare/98dabaa493408a4c40a6f70ded94c44dd5c6b476...35846d9cc6442f3e70dffd7657180b0bc00db650">Compare</a> </details> </details> <hr/>

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information: <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzYWIxMDJiYS0yYjg5LTRiNTUtYTk1My1iNjFiMTI4MTQ2YjQiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjNhYjEwMmJhLTJiODktNGI1NS1hOTUzLWI2MWIxMjgxNDZiNCJ9fQ==" width="0" height="0"/>

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

<!--- (snyk:metadata:{"prId":"3ab102ba-2b89-4b55-a953-b61b128146b4","dependencies":[{"name":"query-string","from":"6.13.6","to":"6.13.7"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/acinader/project/953c8e1a-a9ef-4134-afbe-43474913abbb?utm_source=github&utm_medium=upgrade-pr","projectPublicId":"953c8e1a-a9ef-4134-afbe-43474913abbb","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2020-11-05T20:48:05.198Z"},"templateVariants":["merge-advice-badge-shown"],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]}) --->

+4 -4

0 comment

2 changed files

pr created time in 2 hours

push eventparse-community/parse-dashboard

snyk-bot

commit sha 85cff58581b8decf9675175f2078ef4796dbc272

fix: upgrade query-string from 6.13.6 to 6.13.7 Snyk has created this PR to upgrade query-string from 6.13.6 to 6.13.7. See this package in npm: https://www.npmjs.com/package/query-string See this project in Snyk: https://app.snyk.io/org/acinader/project/953c8e1a-a9ef-4134-afbe-43474913abbb?utm_source=github&utm_medium=upgrade-pr

view details

push time in 2 hours

pull request commentparse-community/ParseLiveQuery-iOS-OSX

Switch CI to main branch

I guess though that assumes they know that the repo has switched the default branch to main - hence this comment from GitHub...

(with a warning and instructions to update their local clone), so it’s easy for your contributors to move

cbaker6

comment created time in 2 hours

Pull request review commentfacebook/create-react-app

fix: eslint cache destination folder change

 const resolveModule = (resolveFn, filePath) => {   return resolveFn(`${filePath}.js`); }; +let cachePath = resolveApp('node_modules/.cache');+try {+  fs.accessSync(cachePath, fs.constants.W_OK | fs.constants.R_OK);

I am sure that eslint will create directory of cacheLocation if it doesn't exist by mkdirp. debug these code.

ehsankhfr

comment created time in 4 hours

issue commentfacebook/docusaurus

Search on v2.docusaurus.io returns no results

Yes me too I found the search completely unusable today. And I think it worked well yesterday.

beeradley

comment created time in 4 hours

PR opened facebook/react-native

Fix Hermes sourcemaps for custom build variants

Summary

It's a common use case to have a custom buildType on android that should be similar to release for staging builds For those, due to this line there is no easy way to make sure the sourcemaps are output.

This leads to issues such as https://github.com/getsentry/sentry-react-native/issues/1105 At the moment, this is one of the blockers to use Hermes on our side, and oh boy do we want to use it! Congrats on that, it's quite fantastic!

One option would be to add a flag specific for Hermes, like useHermesReleaseConfigIn, but then that would be an additional flag to set to true in addition to bundleIn and devDisabledIn. You'd have something like:

project.ext.react = [
        entryFile        : "index.js",
        bundleInBeta     : true,
        devDisabledInBeta: true,
        useHermesReleaseConfigIn: true,
        enableHermes: true,  // clean and rebuild if changing
]

My suggestion is then to have one flag to rule them all for such variants so that you only have to add:

project.ext.react = [
        entryFile        : "index.js",
        useReleaseConfigInBeta: true,
        enableHermes: true,  // clean and rebuild if changing
]

I started by refactoring and moving all uses of targetName.toLowerCase().contains("release") into a single variable, then I introduced the new flag.

Of course, open to any challenges/feedbacks!

Changelog

[Android] [Added] - Add gradle flag to enable all release config [Android] [Fixed] - Allow Hermes sourcemaps for custom build types

Test Plan

  1. I have a project with 3 build types:
    buildTypes {
        debug {
            applicationIdSuffix ".debug"
            signingConfig signingConfigs.debug
        }

        beta {
            applicationIdSuffix ".beta"
            signingConfig signingConfigs.beta
            matchingFallbacks = ['release']
        }

        release {
            minifyEnabled enableProguardInReleaseBuilds
            proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
            signingConfig signingConfigs.release
        }
    }
  1. I've replaced my config which was previously:
project.ext.react = [
        entryFile        : "index.js",
        bundleInBeta     : true,
        devDisabledInBeta: true,
        enableHermes: true,  // clean and rebuild if changing
]

by

project.ext.react = [
        entryFile        : "index.js",
        useReleaseConfigInBeta: true,
        enableHermes: true,  // clean and rebuild if changing
]
  1. I've built all variants of the app:
./gradlew clean assembleRelease
./gradlew clean assembleBeta
./gradlew clean assembleDebug
  • [x] All 3 builds now work. assembleBeta was not working because we use Sentry for crash reporting, and it wasn't able to find any sourcemaps.
  • [x] On Beta and Release sourcemaps are now correctly uploaded to Sentry and the app runs fine.
  • [x] On Debug, the app runs fine, the bundle task was not run, dev menu and reload work as expected
+8 -4

0 comment

2 changed files

pr created time in 4 hours

pull request commentfacebook/docusaurus

fix(v2): support rendering of singular tabs

@aeneasr a canary dist tag has been published, you can try it and let me know if it works for you?

This fix should be available

aeneasr

comment created time in 4 hours

issue commentfacebook/react-native

Appearance issue

<table><tbody><tr><th width="50">:warning:</th><th width="100%"> Missing Environment Information </th></tr><tr><td>:information_source:</td><td> Your issue may be missing information about your development environment. You can obtain the missing information by running <code>react-native info</code> in a console. </td></tr></tbody></table>

chukhlov

comment created time in 4 hours

Pull request review commentfacebook/docusaurus

feat(v2): to add automated canary releases

     "crowdin:upload:v2": "crowdin upload sources --config ./crowdin-v2.yaml",     "crowdin:uploadTranslations:v2": "crowdin upload translations --config ./crowdin-v2.yaml",     "crowdin:download:v2": "crowdin download --config ./crowdin-v2.yaml",+    "canary": "yarn canary:bumpVersion && yarn canary:publish",+    "canary:bumpVersion": "yarn lerna version 2.0.0-alpha.`git rev-parse --short HEAD` --exact --no-push --yes",+    "canary:publish": "yarn lerna publish from-package --dist-tag canary --yes",

Notes:

  • tried to use lerna publish --canary but wasn't able to make it work, as it seems to refuse to publish unchanged packages, and to generate a good version name (probably because we already use alpha.patch)
  • from-package should be convenient, as if we try to publish twice the same version, it will just avoid to publish packages that are already published, instead of failing due to trying to publish twice the same version (ex: we restart the CI on same commit: it should still work)
slorber

comment created time in 4 hours

issue openedfacebook/react-native

Appearance issue

React-native Appearance has some issue on background mode. Here is an video example how to reproduce the bug in the app

Appearance listener will change the colorScheme value to "light" when app is in background mode and never back to dark.

`useEffect(() => { const listener = ({colorScheme}: any) => { setIsDarkMode(colorScheme === 'dark'); }; Appearance.addChangeListener(listener);

return () => {
  Appearance.removeChangeListener(listener);
};

}, []);`

created time in 4 hours

push eventfacebook/docusaurus

slorber

commit sha 51d15178a054c85f1a1ec2a59d292dd7befe28b1

fix canary releases workflow

view details

push time in 5 hours

pull request commentfacebook/docusaurus

feat(v2): to add automated canary releases

Size Change: +1 B

Total Size: 156 kB

<details><summary>ℹ️ <strong>View Unchanged</strong></summary>

Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.87 kB +1 B
website/build/main.********.js 112 kB 0 B
website/build/styles.********.css 17.4 kB 0 B

</details>

<a href="https://github.com/preactjs/compressed-size-action"><sub>compressed-size-action</sub></a>

slorber

comment created time in 5 hours

pull request commentfacebook/docusaurus

feat(v2): to add automated canary releases

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3827--docusaurus-2.netlify.app/classic/ <!-- Sticky Pull Request Commentlighthouse -->

slorber

comment created time in 5 hours

pull request commentfacebook/docusaurus

feat(v2): to add automated canary releases

Deploy preview for docusaurus-2 ready!

Built with commit c76c4a5f25bc6e2503be3b41d808c04fa4d62544

https://deploy-preview-3827--docusaurus-2.netlify.app

slorber

comment created time in 5 hours

PR opened facebook/docusaurus

feat(v2): to add automated canary releases

Motivation

Make new fixes accessible to power users as soon as they get merged, by publishing a npm version under the "canary" dist tag.

+17 -0

0 comment

2 changed files

pr created time in 5 hours

create barnchfacebook/docusaurus

branch : slorber/canary-releases

created branch time in 5 hours

created tagfacebook/docusaurus

tagv2.0.0-alpha.bd62be93d

Easy to maintain open source documentation websites.

created time in 6 hours

issue openedfacebook/create-react-app

Webpack 4 bug in package resolution

I have the problem described in the Stackoverflow question. If I triaged it correctly then there is a bug in Webpack 4 and it's a hard dependency of react-scripts.

I have the following solutions in mind for that problem:

  1. Don't use react-scripts. But I don't have an idea of how to build a React application without them.
  2. Fork markdown-it-prism package to specify the path to index.js explicitly.
  3. Somehow use Webpack 5 with react-scripts.

If you have any ideas about how to fix it in a better way then I would really appreciate your help.

created time in 6 hours

issue commentfacebook/create-react-app

Slow compilation still after upgrade to new version 4.0.1

I tried to debug my app using speed-measure-webpack-plugin (thanks @eek for suggestion) and figured out that problem is 100% (at least in my case) related to ESLintPlugin. Here some metrics:

version 3.4.4 version 4.0.1 version 4.0.1 (second run) version 4.0.1 without ESLintPlugin
Screenshot 2020-11-26 at 20 20 59 Screenshot 2020-11-26 at 20 24 34 Screenshot 2020-11-26 at 20 25 31 Screenshot 2020-11-26 at 20 26 32

You can try if it works in your case by commenting out the plugin in node_modules/react-scripts/config/webpack.config.js: Screenshot 2020-11-26 at 20 45 21

As a temporary solution you can use react-app-rewired with such config-override:

module.exports = (config) => {
  config.plugins = config.plugins.filter(
    (plugin) => !(plugin.options && plugin.options.eslintPath)
  );
  return config;
};
dagar07

comment created time in 6 hours

PR opened facebook/create-react-app

Reviewers
feat(monorepo): adds ability to run cra-template-typescript locally

<!-- Thank you for sending the PR!

If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots!

Happy contributing! -->

I had some extra 🦃 day time and wanted to submit this small customization we introduced into our fork for consideration upstream.

This PR adds the ability to run the cra-template-typescript source locally, which is nice when verifying the template contents and TS ecosystem.

To run:

CRA_TEMPLATE_TS_LOCAL=true yarn start
CRA_TEMPLATE_TS_LOCAL=true yarn build
CRA_TEMPLATE_TS_LOCAL=true yarn test

image

This relies on a process.env check within paths.js that alters the hardcoded path to cra-template.

I know webpack 5 is doing away with Node polyfilling, but CRA currently still supports process.env so I am hoping this is alright.

Running this for the first time is interesting too, in that TypeScript generates two files that have historically never been present, tsconfig.json and the react-app-env.d.ts file. I've currently gitignored these files, as there is value in the tsconfig.json being generated by TS from version to version (I know the definition is added during init). 🤔 though on some level it's interesting to think that CRA could have more opinion here about what a default tsconfig looks like (with added maintenance then...)

I am being slightly lazy here and letting the GH CI handle the complete suite. Forgive me, but kiddos call 👶

+26 -1

0 comment

4 changed files

pr created time in 6 hours

pull request commentfacebook/docusaurus

fix(v2): support rendering of singular tabs

wow that's awesome!

aeneasr

comment created time in 6 hours

issue commentfacebook/create-react-app

Auto reload does not detect changes to index.js

Its happening same for me. OS = ubuntu 18.04.05 node version =12.20.0 npm version = 6.14.8 create-react-app version - 4.0.1

uzair-suria

comment created time in 6 hours

issue commentfacebook/docusaurus

RFC: social cards

@sarthakkundra I also built a POC but it explored an alternate approach, it might worth looking into.

slorber

comment created time in 6 hours

issue openedfacebook/docusaurus

Search on v2.docusaurus.io returns no results

🐛 Bug Report

On https://v2.docusaurus.io, run a search. No results come back.

Have you read the [Contributing Guidelines on issues]

Yes

To Reproduce

  • Visit https://v2.docusaurus.io.
  • Search for "markdown"
  • No results come back

Expected behavior

Results come back

Screen Shot 2020-11-26 at 10 23 23 AM

Actual Behavior

No results come back

Your Environment

  • macOS 10.15.7
  • Tried in Safari, Chrome, and Firefox

Reproducible Demo

Search on https://v2.docusaurus.io

created time in 6 hours

issue commentfacebook/docusaurus

RFC: social cards

Sounds good!

slorber

comment created time in 7 hours

more