profile
viewpoint
Andrew Christianson andrew-christianson Los Angeles, CA

andrew-christianson/lsp-python-ms 3

emacs lsp-mode client for Microsoft's python language server

andrew-christianson/alerter 0

Send User Alert Notification on Mac OS X 10.8 from the command-line.

andrew-christianson/amazon-sagemaker-workshop 0

Amazon SageMaker workshop lab guides and materials

andrew-christianson/anaconda 0

Anaconda turns your Sublime Text 3 in a full featured Python development IDE including autocompletion, code linting, IDE features, autopep8 formating, McCabe complexity checker and Vagrant for Sublime Text 3 using Jedi, PyFlakes, pep8, PyLint, pep257 and McCabe that will never freeze your Sublime Text 3

andrew-christianson/anaconda-mode 0

Code navigation, documentation lookup and completion for Python.

andrew-christianson/awesome-go 0

A curated list of awesome Go frameworks, libraries and software

andrew-christianson/aws-okta 0

aws-vault like tool for Okta authentication

startedmartin-saurer/jkernel

started time in 11 days

startedapache/zeppelin

started time in 16 days

starteddmmiller612/sparktorch

started time in 16 days

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha ac78bcaf8bee18f43af988b68f4e6ff376f1362b

pkg: don't try to expand a nil venv-dir

view details

push time in 19 days

startedlogpy/logpy

started time in 22 days

startedmrocklin/unification

started time in 22 days

startedmhagiwara/100-nlp-papers

started time in 23 days

startedeugeneyan/applied-ml

started time in 23 days

startedforcedotcom/distributions

started time in 24 days

startedprobcomp/crosscat

started time in 24 days

PR opened emacs-lsp/lsp-python-ms

check for venv dirs sibling to parent dirs (#126)

I think this resolves #126 and #122. We check first if we're in a path inside a venv (to address the latter issue) and then check if any siblings of our parent directories are a venv.

+3 -2

0 comment

1 changed file

pr created time in 25 days

create barnchandrew-christianson/lsp-python-ms

branch : bugfix-126

created branch time in 25 days

issue commentemacs-lsp/lsp-python-ms

lsp-python-ms-locate-python locates the wrong python instance

FYI I think the fix to this broke lsp-python-ms--dominating-venv-python for cases like

project_dir/
     pkg/
         src.py <- locate from a buffer here
     venv/ <- misses this venv
         ....

I'll open a PR when I get a chance (need to disentangle branches on my fork)

randomphrase

comment created time in 25 days

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha cc405a055c3660d5cb574f9f77666f329389c8e2

resolve issue introduced in emacs-lsp#123 and resolve emacs-lsp#122

view details

push time in 25 days

push eventandrew-christianson/lsp-python-ms

Alastair Rankine

commit sha 7288aeb7e934f02d479ba323e1d72be22da5361e

Fix lsp-python-ms--dominating-venv-python #122

view details

林玮

commit sha ff0d64308d782ff1a0ce9406e501c1455dc6c7d8

Allow user to set path of the Python executable explicitly

view details

Andrew Christianson

commit sha a7fe655b1eb26d4654dc5cb550c753a15a184c6b

don't use multi-root pyright - it doesn't get the right paths...

view details

push time in 25 days

startedconda/conda-build

started time in a month

startedpocl/pocl

started time in a month

startedconda-forge/clang-compiler-activation-feedstock

started time in a month

startedphracker/MacOSX-SDKs

started time in a month

startedmicrosoft/verona

started time in a month

PR closed emacs-lsp/lsp-python-ms

(Resubmit) Add preliminary support for running pyright-langserver

(Resubmission of #110 due to mis-merge)

!! WIP - Comment wanted !!

This PR adds basic support for running pyright alongside (or instead of) the C# language server.

I think integrating pyright alongside the C# language server is the right first step to address lsp-mode#1863. In my experimentation so far, pyright knocks the socks off the C# server for type checking and diagnostics, but is sub-par for goto-definition, and fails completely on libraries that lack stubs (e.g. numpy and lots of other stuff that ecosystem). Running the pyright server as add-on (thanks to @yyoncho's awesome work there!) is a pretty good compromise, and sets up lsp-mode to support pyright if/when MS deprecates the C# language server.

TODOs before merging:

  • [ ] add install/update functions for pyright (might be a pain)
  • [ ] disable pyrights goto definition capability when it's running as an add-on
  • [ ] add support for generating a pyrightconfig.json at the root of the project, as some config options for pyright cannot be set from its LSP interface
  • [x] resolve emacs-lsp/lsp-mode#1922
+132 -26

1 comment

1 changed file

andrew-christianson

pr closed time in a month

startedtarget/lorri

started time in a month

startedleanprover/lean

started time in 2 months

startedleanprover/lean4

started time in 2 months

delete branch andrew-christianson/lsp-python-ms

delete branch : gh-pages

delete time in 2 months

push eventandrew-christianson/emacs-jupyter

Nathaniel Nicandro

commit sha 3beb736853c6a16a32e6bf951e66b07177159148

Add `jupyter-repl-completing-read-repl-buffer` * jupyter-repl.el (jupyter-repl-completing-read-repl-buffer): Do it. (jupyter-repl-restart-kernel, jupyter-repl-associate-buffer): Use it.

view details

Nathaniel Nicandro

commit sha 8c711dd3ce48f60433cb1d19738168c3594a8a00

`jupyter-repl-client-has-manager-p` -> `jupyter-client-has-manager-p` * jupyter-client.el (jupyter-client-has-manager-p): New function. * jupyter-repl.el (jupyter-repl-client-has-manager-p): Remove function. (jupyter-repl-connected-p, jupyter-repl-kill-buffer-query-function): (jupyter-repl-restart-kernel, jupyter-repl-display-kernel-buffer): Rename calls to `jupyter-repl-client-has-manager-p` to `jupyter-client-has-manager-p`. * test/jupyter-test.el (jupyter-repl-client-predicates): Rename calls to `jupyter-repl-client-has-manager-p` to `jupyter-client-has-manager-p`.

view details

Nathaniel Nicandro

commit sha 23f41cf86c9b3804c622715c769047e9ccbec129

Add `jupyter-kernel-alive-p` method for a `jupyter-kernel-client` * jupyter-client.el (jupyter-kernel-alive-p): Do it. * jupyter-repl.el (jupyter-repl-connected-p): Use it.

view details

Nathaniel Nicandro

commit sha 7a1c91eef482a9fa75bba601ca41d82dbd40e79f

Add the `jupyter-kernel-process-manager` class So as to further generalize and separate out the abstract kernel manager class from its various implementations. * jupyter-kernel-manager.el (jupyter-meta-kernel): Fix documentation. (jupyter-kernel-process, jupyter-command-kernel, jupyter-spec-kernel): Move related functions and methods to `jupyter-kernel-process-manager.el` (jupyter-kernel-manager-base): Remove class. (jupyter-kernel-manager): Re-purpose class as the base class of all kernel managers. The class corresponding to the old functionality is now named `jupyter-kernel-process-manager`. Move all related functions and methods for `jupyter-kernel-process-manager` to `jupyter-kernel-process-manager.el`. * jupyter-kernel-process-manager.el: New file. * jupyter-repl.el: Require `jupyter-kernel-process-manager` instead of `jupyter-kernel-manager`. * jupyter-server.el (jupyter-server-kernel-manager): Inherit from `jupyter-kernel-manager` instead of `jupyter-kernel-manager-base`. * test/jupyter-test.el (jupyter-kernel-lifetime) (jupyter-command-kernel): Use `jupyter-kernel-process-manager` instead of `jupyter-kernel-manager`. * test/test-helper.el: Require `jupyter-kernel-process-manager` instead of `jupyter-kernel-manager`.

view details

Nathaniel Nicandro

commit sha 39974d184188966fd0c948a25320209c9de74af6

jupyter-repl-restart-kernel: Use a kernel manager to restart if possible * jupyter-repl.el (jupyter-repl-restart-kernel): Call the `jupyter-shutdown-kernel` method of the client's kernel manager if available. Remove code that started a kernel when restarting if a manager was available, this is already handled by `jupyter-shutdown-kernel`.

view details

Nathaniel Nicandro

commit sha c4dc513c52c57a6f67d3c25c09079365dd2b06f5

Add FIXME

view details

Nathaniel Nicandro

commit sha 4b97a72cdd243ae8557e722b79d102a67dec7797

Don't overwrite default `url-cookie-file` during tests This is now easier to do since the value of `url-cookie-file` is propagated to websocket subprocesses.

view details

Nathaniel Nicandro

commit sha 96aaedf5b59a7bae08dada1ad8ccd02585e53b10

jupyter-ioloop--dump-message: Don't abbreviate printed lists

view details

Nathaniel Nicandro

commit sha 81b034dad9dbe63753cff5817a7822d9425f1c1a

Remove unused `jupyter-tramp.el` functions

view details

Nathaniel Nicandro

commit sha 797ce5e0e6b9d2e425b26b5d717a05305507f9d0

jupyter-api-delete-cookies: Fix cookie expiration in test

view details

Nathaniel Nicandro

commit sha 91957986e131788fae81beefadbb0498db51d539

Evaluation overlays * README.org: Add section on `jupyter-eval-use-overlays`, minor formatting fix * jupyter-client.el (jupyter-eval-overlay): New face. (jupyter-eval-use-overlays, jupyter-eval-overlay-prefix): New custom variables. (jupyter--display-eval-result): Remove function. (jupyter-eval): Use `jupyter-eval-string`. (jupyter-eval-result-callbacks): New function. (jupyter-eval-add-callbacks): Result callbacks now obtained from `jupyter-eval-result-callbacks`, only add callbacks for non-result message types. Allow `beg` and `end` arguments remove `result-cb` argument, update all callers. (jupyter-eval-string): Allow `beg` and `end` arguments remove `cb` argument, update all callers. (jupyter-eval-string-command): Remove `cb` argument, update all callers. (jupyter-eval-region): Ditto. (jupyter-eval-line-or-region): Refactor. (jupyter-eval-overlay-keymap): New keymap. (jupyter-eval-ov--delete, jupyter-eval-ov--remove-all) (jupyter-eval-ov--propertize, jupyter-eval-ov--fold-boundary) (jupyter-eval-ov--expand-string, jupyter-eval-ov--make) (jupyter-eval-ov--expand, jupyter-eval-ov--fold) (jupyter-eval-toggle-overlay, jupyter-eval-remove-overlays) (jupyter-eval-display-overlay, jupyter-eval-display-with-overlay-p): New functions. * jupyter-repl.el (jupyter-eval-string): Ensure callbacks are added in the original (non-REPL) buffer the command was called from. So that `jupyter-eval-display-with-overlay-p`, indirectly called by `jupyter-eval-add-callbacks`, works. (jupyter-repl-interaction-mode-map): Set `C-c C-o` binding to `jupyter-eval-remove-overlays`.

view details

Nathaniel Nicandro

commit sha fbabaa230381aa4afe57b9f90c51ebf3aeff95ca

Update CHANGELOG

view details

Nathaniel Nicandro

commit sha 0484fa1191282fb71f165c7bbedfac9437ad5616

jupyter-server-ioloop: Spend more time waiting for input As opposed to spending most of the time waiting for websocket messages. This makes Emacs more responsive in scenarios where we are sending input to a kernel and immediately waiting for a response, e.g. in `jupyter-repl-ret` and `jupyter-eval`.

view details

Nathaniel Nicandro

commit sha 0ff69491cdc7474cef41add4139f20b3918ea1d3

jupyter-inspect: Fix commentary

view details

Nathaniel Nicandro

commit sha 091857a21b36408511e6d2ede9a35765525e12ef

Remove unnecessary uses of `jupyter-weak-ref`

view details

Nathaniel Nicandro

commit sha aa9b634e7b26347a9b938da4cb97184b73651a64

jupyter-eval-string-command: Fix wrong number of arguments

view details

Nathaniel Nicandro

commit sha 79ddd9357e9250fcb56f658facfbd50130107902

Add `org-babel-jupyter-current-src-block-params` This is needed because `org-mode` merges many sources of source block params so its not enough to just re-compute the parameters in `jupyter-generate-request` using `org-babel-get-src-block-info` or `org-babel-log-get-info`.

view details

Nathaniel Nicandro

commit sha 4de01643c8ed82158d64f1f8af2ec7cfd80b8b42

jupyter-eval: Revert back to not using `jupyter-eval-string` `jupyter-eval-string` adds unwanted callbacks to the request. `jupyter-eval` is meant to evaluate code without any changes occurring in the buffer.

view details

Nathaniel Nicandro

commit sha 438ac0afd4b311484945ea5e166350f9c4adcf31

jupyter-org--image-result: Prefer `when` instead of `if`

view details

Nathaniel Nicandro

commit sha c5fd3edc8501c993d7fe70a79d5bce9f3e273820

jupyter-available-kernelspecs: Clarify documentation

view details

push time in 2 months

fork andrew-christianson/emacs-jupyter

An interface to communicate with Jupyter kernels.

fork in 2 months

startedsvaksha/Julia.jl

started time in 2 months

startedemacs-lsp/lsp-pyright

started time in 2 months

CommitCommentEvent

startedIntuitionMachines/OrigamiNet

started time in 2 months

pull request commentemacs-lsp/lsp-mode

Add pyright language server for Python

I'm in favor of option 2/3 here. I like the side-by-side version in emacs-lsp/lsp-python-ms#114, but it's easy enough to make :add-on a configurable value here vs there, and it'd probably be better to wait for pyright to stabilize a bit more.

I'll plan to close out the other PR and contribute any changes I have for pyright here.

That said, @yyoncho I still think our discussion from #1923 would be nice for this application, so we can mask out features of any language server when running as an add-on

zeronone

comment created time in 2 months

startedstreamlit/streamlit

started time in 2 months

startedautoml/auto-sklearn

started time in 2 months

push eventandrew-christianson/lsp-python-ms

push time in 2 months

push eventandrew-christianson/lsp-python-ms

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 03a5fba1b27d516540882c82ceabf335b66e1255

make conda optional; remove dependence on Emacs 25 by expanding macros

view details

push time in 2 months

Pull request review commentemacs-lsp/lsp-python-ms

Add preliminary support for running pyright-langserver

 WORKSPACE is just used for logging and _PARAMS is unused."           (lsp--spinner-stop))))     (lsp--info "Microsoft Python language server is analyzing...done"))) +(dolist (mode lsp-python-ms-extra-major-modes)+  (add-to-list 'lsp-language-id-configuration `(,mode . "python")))+++;; pyright we should be able to pass this to the language server as a+;; configuration change; but pyright doesn't seem to support that as+;; of this writing. Instead, it queries the _client_ configuration for+;; these parameters...+;;+;; So, we pick the right files out of the hashtable and had those back to the language server++(defun lsp-python-ms-pyright--make-venv-ht (&optional workspace)+  (let* ((workspace-root (or (when workspace (lsp--workspace-root workspace))+                             (lsp-python-ms--workspace-root)))+         (python (lsp-python-ms-locate-python workspace-root))+         (python-bin (directory-file-name (file-name-directory python)))+         (python-env-dir (directory-file-name (file-name-directory python-bin)))+         (python-env (file-name-nondirectory python-env-dir))+         (ht (ht-create))+         (pht (ht-create)) ; {pyright: pht}+         (pyht (ht-create))  ; {python: ptht}+         (pyaht (ht-create))) ; {python : {analysos: pyaht}}+    (if (string-match "env" python)+        (progn+          (ht-set pyht "venvPath" python-env-dir)+          (ht-set pht "venv" python-env)))+    (cl-destructuring-bind (pyver pysyspath pyintpath)+        (lsp-python-ms--get-python-ver-and-syspath workspace-root)+      (ht-set pyaht "extraPaths" pysyspath)+      (ht-set pyht "pythonPath" pyintpath)+      (ht-set pyaht "logLevel" "trace")+      (ht-set pht "useLibraryCodeForTypes" t)++      (ht-set ht "python" pyht)+      (ht-set pyht "analysis" pyaht)+      (ht-set ht "pyright" pht)+      ht)))+(defun lsp-python-ms-pyright--get-local-python-syspath ()+  (ht-get (ht-get (ht-get (lsp-python-ms-pyright--make-venv-ht) "python") "analysis") "extraPaths"))+(defun lsp-python-ms-pyright--get-local-python-intpath ()+  (ht-get (ht-get (lsp-python-ms-pyright--make-venv-ht) "python") "pythonPath"))+(defun lsp-python-ms-pyright--get-local-python-venvdir ()+    (ht-get (ht-get (lsp-python-ms-pyright--make-venv-ht) "python") "venvPath"))+(defun lsp-python-ms-pyright--get-local-python-venv ()+  (ht-get (ht-get (lsp-python-ms-pyright--make-venv-ht) "pyright") "venv"))+ (lsp-register-custom-settings- `(("python.autoComplete.addBrackets" lsp-python-ms-completion-add-brackets)+ `(+   ;; pyright appears to look for extraPaths in a slightly different+   ;; section than the main language server.+   ("python.autoComplete.extraPaths" lsp-python-ms-extra-paths)+   ("python.analysis.extraPaths" lsp-python-ms-pyright--get-local-python-syspath)++   ("pyright.useLibraryCodeForTypes" t t)+   ("python.analysis.autoSearchPaths"+    (lambda () (or lsp-python-ms-use-pyright+                   (<= (length lsp-python-ms-extra-paths) 0))) t)+   ("python.analysis.autoSearchPaths" t t)    ("python.analysis.cachingLevel" lsp-python-ms-cache)+   ("python.analysis.disabled" lsp-python-ms-disabled)    ("python.analysis.errors" lsp-python-ms-errors)-   ("python.analysis.warnings" lsp-python-ms-warnings)    ("python.analysis.information" lsp-python-ms-information)-   ("python.analysis.disabled" lsp-python-ms-disabled)-   ("python.analysis.autoSearchPaths" (lambda () (<= (length lsp-python-ms-extra-paths) 0)) t)-   ("python.autoComplete.extraPaths" lsp-python-ms-extra-paths)))--(dolist (mode lsp-python-ms-extra-major-modes)-  (add-to-list 'lsp-language-id-configuration `(,mode . "python")))--(lsp-register-client- (make-lsp-client-  :new-connection (lsp-stdio-connection (lambda () lsp-python-ms-executable)-                                        (lambda () (f-exists? lsp-python-ms-executable)))-  :major-modes (append '(python-mode) lsp-python-ms-extra-major-modes)-  :server-id 'mspyls-  :priority 1-  :initialization-options 'lsp-python-ms--extra-init-params-  :notification-handlers (lsp-ht ("python/languageServerStarted" 'lsp-python-ms--language-server-started-callback)-                                 ("telemetry/event" 'ignore)-                                 ("python/reportProgress" 'lsp-python-ms--report-progress-callback)-                                 ("python/beginProgress" 'lsp-python-ms--begin-progress-callback)-                                 ("python/endProgress" 'lsp-python-ms--end-progress-callback))-  :initialized-fn (lambda (workspace)-                    (with-lsp-workspace workspace-                      (lsp--set-configuration (lsp-configuration-section "python"))))-  :download-server-fn (lambda (client callback error-callback update?)-                        (when lsp-python-ms-auto-install-server-                          (lsp-python-ms--install-server client callback error-callback update?)))))+   ("python.analysis.logLevel" lsp-python-ms-log-level)+   ("python.analysis.warnings" lsp-python-ms-warnings)+   ("python.autoComplete.addBrackets" lsp-python-ms-completion-add-brackets)+   ("python.pythonPath" lsp-python-ms-pyright--get-local-python-intpath)+   ("python.venv" lsp-python-ms-pyright--get-local-python-venv)+   ("python.venvPath" lsp-python-ms-pyright--get-local-python-venvdir))+ )++(when lsp-python-ms-use-pyright+  (lsp-register-client+   (make-lsp-client+    :new-connection (lsp-stdio-connection+                     (lambda () lsp-pyright-server-cmd)+                     (lambda ()+                       (and (cl-first lsp-pyright-server-cmd)+                            (executable-find (cl-first lsp-pyright-server-cmd)))))+    :major-modes '(python-mode)+    :server-id 'mspyright+    :add-on? (eq lsp-python-ms-use-pyright 'addon)+    :priority 1

good point, added (in #114

andrew-christianson

comment created time in 2 months

pull request commentemacs-lsp/lsp-mode

Use :is-incomplete in lsp-make-completion-list

@yyoncho thanks for the quick merge. I'd definitely like to have an option (or a snippet/example of how) to remove a specific capability from a server. It'd be helpful for my msplys / mspyright case, but I think there could be other applications in areas where there are multiple competing/complementary language servers users might want to chose between.

I think lsp--server-unregister-capability is in the right direction, but I'm not sure if it's the best way to accomplish that

andrew-christianson

comment created time in 2 months

PR opened emacs-lsp/lsp-mode

Use :is-incomplete in lsp-make-completion-list

This PR is the simple resolution to #1922. I suspect there may be a more comprehensive solution involving lsp-interface but I have less insight into that area of this project

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchandrew-christianson/lsp-mode

branch : bugfix-merge-completion

created branch time in 2 months

issue openedemacs-lsp/lsp-mode

lsp-make-completion-list does not accept :isIncomplete

Describe the bug

lsp-make-completion-list does not include isIncomplete when given key :isIncomplete, but does when given key is-incomplete. This breaks lsp--merge-results at L1338 while merging multiple responses to a textDocument/completion request, which ultimately breaks completion when both the primary workspace and an add-on workspace respond to that request.

When running under lsp-start-plain this throws an error. When running under debug-on-error in my configuration, it appears to launch the debugger, but the backtrace window is automatically closed within milliseconds.

To Reproduce

;; This buffer is for text that is not saved, and for Lisp evaluation.
;; To create a file, visit it with C-x C-f and enter text in its buffer.

(json-encode (lsp-make-completion-list :is-incomplete t :items '(a s d f)))
;; > "{\"isIncomplete\":true,\"items\":[\"a\",\"s\",\"d\",\"f\"]}"

(json-encode (lsp-make-completion-list :isIncomplete t :items '(a s d f)))
;; Emacs 27, my config:  "{\"items\":[\"a\",\"s\",\"d\",\"f\"]}"
;; Emacs 27, lsp-start-plain: Lisp error: (error "Keyword argument :isIncomplete not one of (:items :is-incomplete)")

Emacs Version:

GNU Emacs 27.0.91 (build 12, x86_64-apple-darwin19.5.0, NS appkit-1894.50 Version 10.15.5 (Build 19F101))
 of 2020-07-07

Expected behavior lsp-make-completion-list should include the expected keys

Which Language Server did you use Mention which server/language did you use (e. g. lsp-python, lsp-ccls, lsp-java, etc)

OS MacOS 10.15.5

Error callstack When hitting this bug when in lsp-completion-at-point, it barfs the entire response to textDocument/completion into the lsp log and the echo area.

created time in 2 months

pull request commentemacs-lsp/lsp-mode

Add pyright language server for Python

@leungbk thanks for the tag. I was lagging on re-submitting emacs-lsp/lsp-python-ms#110, but it's there now as emacs-lsp/lsp-python-ms#114.

@zeronone thanks for this, and for microsoft/pyright#810 ! This looks good, and addresses one of my TODOs on the other PR. To confirm: are you assuming that users will set other configuration (e.g. venvPath, pythonPath) with a pyrightconfig.json?

zeronone

comment created time in 2 months

PR opened emacs-lsp/lsp-python-ms

(Resubmit) Add preliminary support for running pyright-langserver

(Resubmission of #110 due to mis-merge)

!! WIP - Comment wanted !!

This PR adds basic support for running pyright alongside (or instead of) the C# language server.

I think integrating pyright alongside the C# language server is the right first step to address lsp-mode#1863. In my experimentation so far, pyright knocks the socks off the C# server for type checking and diagnostics, but is sub-par for goto-definition, and fails completely on libraries that lack stubs (e.g. numpy and lots of other stuff that ecosystem). Running the pyright server as add-on (thanks to @yyoncho's awesome work there!) is a pretty good compromise, and sets up lsp-mode to support pyright if/when MS deprecates the C# language server.

TODOs before merging:

  • [ ] add install/update functions for pyright (might be a pain)
  • [ ] disable pyrights goto definition capability when it's running as an add-on
  • [ ] add support for generating a pyrightconfig.json at the root of the project, as some config options for pyright cannot be set from its LSP interface
+140 -26

0 comment

1 changed file

pr created time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha e4a7fc81d33e3daca7014c86732bfbea715c78d5

add seemingly missing key to responses

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 07f641a02c2d4f715ed1b130dfddc9213a45bad9

add seemingly missing key to responses

view details

Andrew Christianson

commit sha ffa98bf0316bc79dd2997395b9cae53768808dc2

Merge branch 'pyright'

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 07f641a02c2d4f715ed1b130dfddc9213a45bad9

add seemingly missing key to responses

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 66175517459834fb48c2eb6d2cccd9c3388249e7

enclose registration in a function so that user settings can apply

view details

Andrew Christianson

commit sha 686cb9ac150c1504626fb70b72dd6d4669523a6c

Merge branch 'pyright'

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 66175517459834fb48c2eb6d2cccd9c3388249e7

enclose registration in a function so that user settings can apply

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Vincent Zhang

commit sha 396c25c6e0c143c5e5370d9e29b2e65661510e79

Change the priority of mspyls. See https://github.com/seagle0128/.emacs.d/issues/156.

view details

Vincent Zhang

commit sha 5d0c799099aa5810858174f390e28fff3894bc06

Autoload lsp-python-ms-update-server.

view details

Vincent Zhang

commit sha 2a6e7449d4d02f81469f4fe03e7b9f8e13bf860d

Update FAQ.

view details

Maximilian Roos

commit sha b340801bef7fa2b6d1d0546faafd31081c1dc7ec

Typo

view details

Vincent Zhang

commit sha 19feb4aaaa03382e5d9841f237dd1685d8fe2994

Merge pull request #89 from max-sixty/patch-1 Typo

view details

Brian Leung

commit sha 371aeed1da35b5adf1e2fa54d51f3c1c1c40bf3e

Remove lsp-python-ms--client-initialized.

view details

Brian Leung

commit sha a6ab6ec50448c1567517da35d4e8ff41e8ece7c6

Fix declare-function invocation.

view details

Vincent Zhang

commit sha 109bc24129dc2467d9fd0ca578873b40788b5fa5

Merge pull request #90 from leungbk/nits Nits

view details

Eric Dallo

commit sha dcea20c461bb8138cca006bcfef484d1277cd71f

Add webpage

view details

Vincent Zhang

commit sha 841534b0394911d74b42ec306416c276a75ddde3

Merge pull request #92 from ericdallo/add-webpage Add action for gh-pages

view details

Eric Dallo

commit sha 324a0bf50be2ebbdafcfb532c573ac22d5170d10

Fix docs action

view details

Brian Leung

commit sha 730c0ea8c0aeda531c171b39a58e85eafe9ef8d0

Add installation instructions for NixOS.

view details

Vincent Zhang

commit sha 97ad997c6c2e3bc8d12c02b2809960d47ad316b0

Merge pull request #94 from leungbk/nixos-instructions Add installation instructions for NixOS.

view details

Vincent Zhang

commit sha 4035519850e76df8b76ea51430a8db9177de51a3

New option: lsp-python-ms-auto-install-server. Close #85.

view details

Vincent Zhang

commit sha 4c2e834746ad5b07153052ed7fcb4e63a4f00a7d

Bump version.

view details

Vincent Zhang

commit sha 130904da907b854a47c384f5ddba08f05993d91c

Fix #98: mspyls instal process failed: wrong number of arguments.

view details

Vincent Zhang

commit sha db6f2636da1037bda06d5a2d992c4857ce3ad9b0

Fix #96: Unresolved import problems.

view details

Vincent Zhang

commit sha c8ebd0b162a6a3a00b2143464616cb9940e56c18

Update docs.

view details

Vincent Zhang

commit sha 7068cf04a0d0a1877afe56990cc577edd824a1e4

Update docs.

view details

Vincent Zhang

commit sha 8560f60278026902911a92b631fef681dd156f3d

Add new setting: python.autoComplete.extraPaths. See #96.

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 6a243309afd8e10d8516d01c13986553d374a1bf

add preliminary support for running pyright instead of or alongside mspyls

view details

Andrew Christianson

commit sha 40c7babb65da918350a948972b93c47831692db1

correct server-cmd variable name in lsp-make-client

view details

Andrew Christianson

commit sha 20eee6f03c86e92d4ad2bcf1d9ec3258e04659f8

ensure config value is nil or t

view details

Andrew Christianson

commit sha aa433ebec7fc9425c5fefe78105ea04c21b19646

add multi-root flag for pyright server

view details

Andrew Christianson

commit sha 3cc40870c63c05c715e13563a650d23a874acb02

use activation functions so that pyright can be disabled dynamically

view details

Andrew Christianson

commit sha 286ec6e15f02fa9dad1d2a6a5a79f0200de11119

swap order of client registration; make sure activation functions are bools

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 336115276e820e49714f9b4a7bac9d1c699692fb

use activation functions so that pyright can be disabled dynamically

view details

Andrew Christianson

commit sha cc289fd2e248ff4f84a32a19a1ae3dbf0f813889

swap order of client registration; make sure activation functions are bools

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 4498c8e4e1ca3ab14fd5473f781429e49beb99fe

look for conda environments and yaml files

view details

Andrew Christianson

commit sha 1c1a54587308eb141b3ce3e9fc2245aff2b74291

use conda-* functions to find conda environments

view details

Andrew Christianson

commit sha 7c183f175b3d67e966c1cdea83f39fd341e1db3b

bail out if we can't find an enviroment file

view details

Andrew Christianson

commit sha 8b780a02ce7591aabe08fc361edbade065b6f84b

defer to a prevailing conda env, if set

view details

Andrew Christianson

commit sha 835c2a636321c79537b0b063277346fe4d034cda

revise check order: local venv, pyenv, conda, system

view details

Andrew Christianson

commit sha 41b23e640cbbd0e1e9221f585db805a6b282837f

more defensive finding of executable command

view details

Andrew Christianson

commit sha 3fc077099ae8146e8652f63c0ef2eaaddec18fca

add config option for locate-python

view details

Andrew Christianson

commit sha 036f2b47dcd7113a02bf9cb170f8ad9aad9db0f1

typo in guess-env variable usage; don't fail if not in a workspace

view details

Andrew Christianson

commit sha 564a82eb801a2240d765d4c384c14b6ece7b6579

add preliminary support for running pyright instead of or alongside mspyls

view details

Andrew Christianson

commit sha 5ed3658450ce8affa28dba6eece06aa73a2c3e67

correct server-cmd variable name in lsp-make-client

view details

Andrew Christianson

commit sha dc7163ceac39d3705621b699d1b3219ed8a98f3a

ensure config value is nil or t

view details

Andrew Christianson

commit sha 9fe2caedee9338da3c00b9166fb3f91e6b777c86

add multi-root flag for pyright server

view details

Andrew Christianson

commit sha 599e79f7b9dd31f6f7f87d4bdd98021e39304da7

use activation functions so that pyright can be disabled dynamically

view details

Andrew Christianson

commit sha a402de2677d9df07658ae98a44da2a3a14c8177c

swap order of client registration; make sure activation functions are bools

view details

Andrew Christianson

commit sha 133825daca897602da7bfda81389a94c818d6f81

Merge branch 'check-conda'

view details

Andrew Christianson

commit sha 7df2902dac55fe97be3d81b678df6dc038f9f185

Merge branch 'pyright'

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

conao3

commit sha 0eabdd24c8e8e4c4b9e291bca20c846e36d8822b

Remove toplevel sexp and wrap it with *-initialize function

view details

conao3

commit sha 9677b3d6c418230c2a60eb51bc7a1a3ed3aaff77

fix recommend init.el

view details

Andrew Christianson

commit sha 6a243309afd8e10d8516d01c13986553d374a1bf

add preliminary support for running pyright instead of or alongside mspyls

view details

Vincent Zhang

commit sha 59372bd07c668f2bdccc8c8df14991fda319e0d7

Merge pull request #110 from andrew-christianson/pyright-mr Add preliminary support for running pyright-langserver

view details

Vincent Zhang

commit sha 525d383810eadee3df8b6605b98a85fa34636d04

Revert "Add preliminary support for running pyright-langserver"

view details

Vincent Zhang

commit sha f2a0bf01ed54f1163c7675773807962644b68677

Merge pull request #111 from emacs-lsp/revert-110-pyright-mr Revert "Add preliminary support for running pyright-langserver"

view details

Vincent Zhang

commit sha 03f7ecc3b8708178d38afc4c2338268e5f6a527e

Merge pull request #106 from conao3/feature Remove toplevel sexp and wrap it with *-initialize function

view details

Vincent Zhang

commit sha f9a3d745f59d11b7e54cb645766036ce3e538ec8

Revert "Remove toplevel sexp and wrap it with *-initialize function"

view details

Vincent Zhang

commit sha 0c9abf5041192bc2f85c46c08b73c8c68ead8dfc

Merge pull request #112 from emacs-lsp/revert-106-feature Revert "Remove toplevel sexp and wrap it with *-initialize function"

view details

Andrew Christianson

commit sha 4498c8e4e1ca3ab14fd5473f781429e49beb99fe

look for conda environments and yaml files

view details

Andrew Christianson

commit sha 1c1a54587308eb141b3ce3e9fc2245aff2b74291

use conda-* functions to find conda environments

view details

Andrew Christianson

commit sha 7c183f175b3d67e966c1cdea83f39fd341e1db3b

bail out if we can't find an enviroment file

view details

Andrew Christianson

commit sha 8b780a02ce7591aabe08fc361edbade065b6f84b

defer to a prevailing conda env, if set

view details

Andrew Christianson

commit sha 835c2a636321c79537b0b063277346fe4d034cda

revise check order: local venv, pyenv, conda, system

view details

Andrew Christianson

commit sha 41b23e640cbbd0e1e9221f585db805a6b282837f

more defensive finding of executable command

view details

Andrew Christianson

commit sha 3fc077099ae8146e8652f63c0ef2eaaddec18fca

add config option for locate-python

view details

Andrew Christianson

commit sha 036f2b47dcd7113a02bf9cb170f8ad9aad9db0f1

typo in guess-env variable usage; don't fail if not in a workspace

view details

push time in 2 months

delete branch andrew-christianson/lsp-python-ms

delete branch : pyright-mr

delete time in 2 months

push eventandrew-christianson/lsp-python-ms

conao3

commit sha 0eabdd24c8e8e4c4b9e291bca20c846e36d8822b

Remove toplevel sexp and wrap it with *-initialize function

view details

conao3

commit sha 9677b3d6c418230c2a60eb51bc7a1a3ed3aaff77

fix recommend init.el

view details

Vincent Zhang

commit sha 59372bd07c668f2bdccc8c8df14991fda319e0d7

Merge pull request #110 from andrew-christianson/pyright-mr Add preliminary support for running pyright-langserver

view details

Vincent Zhang

commit sha 525d383810eadee3df8b6605b98a85fa34636d04

Revert "Add preliminary support for running pyright-langserver"

view details

Vincent Zhang

commit sha f2a0bf01ed54f1163c7675773807962644b68677

Merge pull request #111 from emacs-lsp/revert-110-pyright-mr Revert "Add preliminary support for running pyright-langserver"

view details

Vincent Zhang

commit sha 03f7ecc3b8708178d38afc4c2338268e5f6a527e

Merge pull request #106 from conao3/feature Remove toplevel sexp and wrap it with *-initialize function

view details

Vincent Zhang

commit sha f9a3d745f59d11b7e54cb645766036ce3e538ec8

Revert "Remove toplevel sexp and wrap it with *-initialize function"

view details

Vincent Zhang

commit sha 0c9abf5041192bc2f85c46c08b73c8c68ead8dfc

Merge pull request #112 from emacs-lsp/revert-106-feature Revert "Remove toplevel sexp and wrap it with *-initialize function"

view details

Andrew Christianson

commit sha 564a82eb801a2240d765d4c384c14b6ece7b6579

add preliminary support for running pyright instead of or alongside mspyls

view details

Andrew Christianson

commit sha 5ed3658450ce8affa28dba6eece06aa73a2c3e67

correct server-cmd variable name in lsp-make-client

view details

Andrew Christianson

commit sha dc7163ceac39d3705621b699d1b3219ed8a98f3a

ensure config value is nil or t

view details

Andrew Christianson

commit sha 9fe2caedee9338da3c00b9166fb3f91e6b777c86

add multi-root flag for pyright server

view details

Andrew Christianson

commit sha 599e79f7b9dd31f6f7f87d4bdd98021e39304da7

use activation functions so that pyright can be disabled dynamically

view details

Andrew Christianson

commit sha a402de2677d9df07658ae98a44da2a3a14c8177c

swap order of client registration; make sure activation functions are bools

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha f39844c42e4dc50e68c691d182849c4e9192ac7a

swap order of client registration; make sure activation functions are bools

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 9eb91f0bae38b85ecbb8719306c51d5ec55f5f10

use activation functions so that pyright can be disabled dynamically

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 872ec4088b540eb08bdf54e312b4eeb3c31b41ee

typo in guess-env variable usage; don't fail if not in a workspace

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 872ec4088b540eb08bdf54e312b4eeb3c31b41ee

typo in guess-env variable usage; don't fail if not in a workspace

view details

Andrew Christianson

commit sha 725b3c5922b11362c51a7aebe8cc232baa57a6b1

add preliminary support for running pyright instead of or alongside mspyls

view details

Andrew Christianson

commit sha 62767982deb3060930eff294f6b6b5ef4aeb5715

correct server-cmd variable name in lsp-make-client

view details

Andrew Christianson

commit sha 05f1e97df68c725f929282b04f2ca18476a5f2d1

ensure config value is nil or t

view details

Andrew Christianson

commit sha 535382983cf6b2a1fcf776511e9a9e5dc3249690

add multi-root flag for pyright server

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 40c7babb65da918350a948972b93c47831692db1

correct server-cmd variable name in lsp-make-client

view details

Andrew Christianson

commit sha 20eee6f03c86e92d4ad2bcf1d9ec3258e04659f8

ensure config value is nil or t

view details

Andrew Christianson

commit sha aa433ebec7fc9425c5fefe78105ea04c21b19646

add multi-root flag for pyright server

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 95cee33c3a7b71bfd28dc258b5fc8938a56adb8c

add multi-root flag for pyright server

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 67f4de1a45794936b11685d6aed4918924c925f4

correct server-cmd variable name in lsp-make-client

view details

Andrew Christianson

commit sha 58d58acbf9d8f544261ba0a154d41bcf28ac23ac

ensure config value is nil or t

view details

push time in 2 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha 3046f419ff35612f128de9a838f0141b1e99e125

typo in guess-env variable usage; don't fail if not in a workspace

view details

push time in 2 months

PR opened emacs-lsp/lsp-python-ms

Add preliminary support for running pyright-langserver

!! WIP - Comment wanted !!

This PR adds basic support for running pyright alongside (or instead of) the C# language server.

I think integrating pyright alongside the C# language server is the right first step to address lsp-mode#1863. In my experimentation so far, pyright knocks the socks off the C# server for type checking and diagnostics, but is sub-par for goto-definition, and fails completely on libraries that lack stubs (e.g. numpy and lots of other stuff that ecosystem). Running the pyright server as add-on (thanks to @yyoncho's awesome work there!) is a pretty good compromise, and sets up lsp-mode to support pyright if/when MS deprecates the C# language server.

TODOs before merging:

  • [ ] add install/update functions for pyright (might be a pain)
  • [ ] disable pyrights goto definition capability when it's running as an add-on
  • [ ] add support for generating a pyrightconfig.json at the root of the project, as some config options for pyright cannot be set from its LSP interface
+120 -28

0 comment

1 changed file

pr created time in 3 months

create barnchandrew-christianson/lsp-python-ms

branch : pyright-mr

created branch time in 3 months

PR opened emacs-lsp/lsp-python-ms

Add more robust mechanism for finding python environments

This PR makes lsp-python-ms-locate-python aware of conda and pyenv environments in addition to the support for project-local venv environments. When an environment is located, it extracts then path to the interpreter and uses that interpreter (and thus its associated sys.path) to initialize the language server.

This has been on my daily driver branch for a while, and works well for my purposes, but I'd definitely appreciate review to insure it maps to others' use cases

+89 -16

0 comment

1 changed file

pr created time in 3 months

push eventandrew-christianson/lsp-python-ms

Vincent Zhang

commit sha 396c25c6e0c143c5e5370d9e29b2e65661510e79

Change the priority of mspyls. See https://github.com/seagle0128/.emacs.d/issues/156.

view details

Vincent Zhang

commit sha 5d0c799099aa5810858174f390e28fff3894bc06

Autoload lsp-python-ms-update-server.

view details

Vincent Zhang

commit sha 2a6e7449d4d02f81469f4fe03e7b9f8e13bf860d

Update FAQ.

view details

Maximilian Roos

commit sha b340801bef7fa2b6d1d0546faafd31081c1dc7ec

Typo

view details

Vincent Zhang

commit sha 19feb4aaaa03382e5d9841f237dd1685d8fe2994

Merge pull request #89 from max-sixty/patch-1 Typo

view details

Brian Leung

commit sha 371aeed1da35b5adf1e2fa54d51f3c1c1c40bf3e

Remove lsp-python-ms--client-initialized.

view details

Brian Leung

commit sha a6ab6ec50448c1567517da35d4e8ff41e8ece7c6

Fix declare-function invocation.

view details

Vincent Zhang

commit sha 109bc24129dc2467d9fd0ca578873b40788b5fa5

Merge pull request #90 from leungbk/nits Nits

view details

Eric Dallo

commit sha dcea20c461bb8138cca006bcfef484d1277cd71f

Add webpage

view details

Vincent Zhang

commit sha 841534b0394911d74b42ec306416c276a75ddde3

Merge pull request #92 from ericdallo/add-webpage Add action for gh-pages

view details

Eric Dallo

commit sha 324a0bf50be2ebbdafcfb532c573ac22d5170d10

Fix docs action

view details

Brian Leung

commit sha 730c0ea8c0aeda531c171b39a58e85eafe9ef8d0

Add installation instructions for NixOS.

view details

Vincent Zhang

commit sha 97ad997c6c2e3bc8d12c02b2809960d47ad316b0

Merge pull request #94 from leungbk/nixos-instructions Add installation instructions for NixOS.

view details

Vincent Zhang

commit sha 4035519850e76df8b76ea51430a8db9177de51a3

New option: lsp-python-ms-auto-install-server. Close #85.

view details

Vincent Zhang

commit sha 4c2e834746ad5b07153052ed7fcb4e63a4f00a7d

Bump version.

view details

Vincent Zhang

commit sha 130904da907b854a47c384f5ddba08f05993d91c

Fix #98: mspyls instal process failed: wrong number of arguments.

view details

Vincent Zhang

commit sha db6f2636da1037bda06d5a2d992c4857ce3ad9b0

Fix #96: Unresolved import problems.

view details

Vincent Zhang

commit sha c8ebd0b162a6a3a00b2143464616cb9940e56c18

Update docs.

view details

Vincent Zhang

commit sha 7068cf04a0d0a1877afe56990cc577edd824a1e4

Update docs.

view details

Vincent Zhang

commit sha 8560f60278026902911a92b631fef681dd156f3d

Add new setting: python.autoComplete.extraPaths. See #96.

view details

push time in 3 months

push eventandrew-christianson/lsp-python-ms

Andrew Christianson

commit sha c78d37ad50b71b8a25a656c0020f94752ae8686c

add preliminary support for running pyright instead of or alongside mspyls

view details

push time in 3 months

create barnchandrew-christianson/lsp-python-ms

branch : pyright

created branch time in 3 months

startedaaronbieber/org-protocol-handler

started time in 3 months

startedvygr/ChrysaLisp

started time in 3 months

more