andreasnuesslein ( Andreas Nüßlein )

At least on one system using Python 3.8 the error output of systemctl status [pid] would not be written to the output variable. Also the output of systemctl (version 246) apparantly changed to

"Failed to get unit for PID [pid]: PID [pid] does not belong to any loaded unit."

Therefore I think it is better to check the return code of the systemctl status process and if it is non-zero, return None.

This was the output of lib_users 0.14 on the affected system. I think bpfilter_umh is some Kernel process or something.

# lib_users --services
3524 "bpfilter_umh"

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.8/lib_users", line 133, in <module>
    main(sys.argv[1:])
  File "/usr/lib/python-exec/python3.8/lib_users", line 129, in main
    print(common.get_services(users))
  File "/usr/lib/python3.8/site-packages/lib_users_util/common.py", line 114, in get_services
    unit = query_systemctl(pid)
  File "/usr/lib/python3.8/site-packages/lib_users_util/common.py", line 100, in query_systemctl
    svc = fields[1]
IndexError: list index out of range

This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>

+4 -2

1 commit in fkoester/lib_users/tree/services-output klausman/lib_users/tree/master

0 comment

1 changed file

fkoester

pr closed time in 20 days

push eventklausman/lib_users

Fabian Köster

commit sha d26e716dab04a908f71a28ee4c628dd1aea603d7

Fix error handling of systemctl status process (#7) * Fix error handling of systemctl status process At least on one system using Python 3.8 the error output of `systemctl status [pid]` would not be written to the output variable. Also the output of systemctl (version 246) apparantly changed to "Failed to get unit for PID [pid]: PID [pid] does not belong to any loaded unit." Therefore I think it is better to check the return code of the `systemctl status` process and if it is non-zero, return None.

view details

push time in 20 days

PR opened klausman/lib_users

Fix error handling of systemctl status process

At least on one system using Python 3.8 the error output of systemctl status [pid] would not be written to the output variable. Also the output of systemctl (version 246) apparantly changed to

"Failed to get unit for PID [pid]: PID [pid] does not belong to any loaded unit."

Therefore I think it is better to check the return code of the systemctl status process and if it is non-zero, return None.

This was the output of lib_users 0.14 on the affected system. I think bpfilter_umh is some Kernel process or something.

# lib_users --services
3524 "bpfilter_umh"

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.8/lib_users", line 133, in <module>
    main(sys.argv[1:])
  File "/usr/lib/python-exec/python3.8/lib_users", line 129, in main
    print(common.get_services(users))
  File "/usr/lib/python3.8/site-packages/lib_users_util/common.py", line 114, in get_services
    unit = query_systemctl(pid)
  File "/usr/lib/python3.8/site-packages/lib_users_util/common.py", line 100, in query_systemctl
    svc = fields[1]
IndexError: list index out of range

+4 -2

1 commit in fkoester/lib_users/tree/services-output klausman/lib_users/tree/master

0 comment

1 changed file

pr created time in 20 days

startedsphinx-doc/sphinx

started time in 20 days

fork thibaudcolas/sphinx

Main repository for the Sphinx documentation builder

https://www.sphinx-doc.org

sphinx-doc/sphinx thibaudcolas/sphinx

fork in 20 days