profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/amosbird/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Amos Bird amosbird kuaishou.com Beijing Telegram @amosbird

amosbird/ccutils 5

c++ snippets collected from various places

amosbird/ClickHouse 5

ClickHouse is a free analytic DBMS for big data.

amosbird/abproxy 2

simple web proxies in go.

amosbird/amospxe 2

easy to use pxe server

amosbird/abmb 1

modern c++ micro benchmark header

amosbird/996.ICU 0

Repo for counting stars and contributing. Press F to pay respect to glorious developers.

issue commentClickHouse/ClickHouse

How to use post submission of URL function?

insert is only POST

It may be interesting to have INSERT returning records so that we can do POST)

linqingping

comment created time in a day

pull request commentClickHouse/ClickHouse

Fix replication queue accumulation caused by the entries that has bee…

(version 102.1.1) look like a local fork build.

zhongyuankai

comment created time in a day

PR opened ClickHouse/ClickHouse

Disable projections when ARRAY JOIN is used.

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md): Disable projections when ARRAY JOIN is used. Currently projection analysis will break array join aliases.

Detailed description / Documentation draft: .

+50 -54

0 comment

5 changed files

pr created time in 2 days

create barnchamosbird/ClickHouse

branch : projection-fix17

created branch time in 2 days

push eventamosbird/ClickHouse

Amos Bird

commit sha 8a66d1a5190043d3aed24f7d5fcd3d8c6ac69ff5

Handle null column correctly in JSONFunction

view details

push time in 2 days

issue commentClickHouse/ClickHouse

Upgrade to 21.8 LTS fails with: Unknown auxiliary ZooKeeper name

cc @fastio https://github.com/ClickHouse/ClickHouse/pull/17070

Alex-Burmak

comment created time in 3 days

startedNuitka/Nuitka

started time in 4 days

startedgoogle/python-fire

started time in 4 days

issue commentClickHouse/ClickHouse

PROJECTION Compression (skip indexes and settings ?)

Not sure what's the proper grammar for this. But yes, it's already in plan.

UnamedRus

comment created time in 5 days

push eventamosbird/ClickHouse

Amos Bird

commit sha 177461590ad7f20139f687e457fc15847e2d72d0

Handle null column correctly in JSONFunction

view details

push time in 5 days

issue commentClickHouse/ClickHouse

Wrong query result because of push-down optimization

https://github.com/ClickHouse/ClickHouse/pull/27932/files#diff-aa3c979016a9f8c6ab5a51560411afa3f4cef55d34c899a2b1e7aff38aca4076R252

Looks like it is enabled

Anyway, #28975 did not brake any test

empty_result_for_aggregation_by_constant_keys_on_empty_set = true means the old behavior :)

den-crane

comment created time in 5 days

issue commentClickHouse/ClickHouse

Wrong query result because of push-down optimization

Likely after #27932

But that PR only introduced a setting which is disabled by default.

den-crane

comment created time in 5 days

issue commentClickHouse/ClickHouse

crash with prefer_column_name_to_alias on 21.8.5

Is it a bug of prefer_column_name_to_alias itself or a bug that can be unveiled by this setting?

UnamedRus

comment created time in 6 days

push eventamosbird/ClickHouse

Amos Bird

commit sha 3ab9b657f069b96a24e652857b4f22e42c649007

Handle null column correctly in JSONFunction

view details

push time in 8 days

issue commentClickHouse/ClickHouse

Projection (RFC)

@zhouxuhua 可以列一下局限性,有好的方向我想办法优化优化

amosbird

comment created time in 8 days

issue commentAmokHuginnsson/replxx

Line continuation support

In what ways are they glitchy?

I tried to make some screencast but it's not enough to capture the issue.... It's a visible text re-rendering when moving cursors right by word. It's interesting that moving left is perfectly fine.

nvanwyen

comment created time in 8 days

issue commentAmokHuginnsson/replxx

HISTORY_INCREMENTAL_SEARCH breaks line readering

As far as I can tell there was a new feature added to Clickhouse version of replxx related to editing history entry behavior. replxx behaves differently than readline in this regard.

Yes, and @azat also think it's better to use the upstream strategy.

amosbird

comment created time in 8 days

PR opened AmokHuginnsson/replxx

Added support for INTENSE and custom colors

https://github.com/ClickHouse-Extras/replxx/pull/6

+36 -23

0 comment

3 changed files

pr created time in 8 days

create barnchamosbird/replxx

branch : morecolor

created branch time in 8 days

issue commentClickHouse/ClickHouse

Lots of empty tmp_merge_... directories under $TMP_PATH leading to significant time to chown on startup

@amosbird I don't understand did you solve it in #28299 or not ?

It's solved.

jacobrandall

comment created time in 8 days

issue commentAmokHuginnsson/replxx

Line continuation support

Cool! It's indeed better. Though some movements are still glitchy.

Good: Word-Left, Home, End Bad: Up, Down, Left, Right, Word-Right

Btw, it seems we don't handle multiple lines properly which cannot be filled in one screen. I guess it's ok for the moment)

nvanwyen

comment created time in 8 days

push eventamosbird/ClickHouse

Vitaly Baranov

commit sha 05247c7eefbadf63320163d4bcd4b99100db1344

Add test.

view details

Vitaly Baranov

commit sha ff1fad85216c0212520278075a1fbaea992688b6

Use setSetting() with implicit conversion true/false -> Field.

view details

Vladimir Chebotarev

commit sha 441958f59032683e82041de0574523cbd4140052

Proper parser.

view details

Vladimir Chebotarev

commit sha a6e246b9baedba960928bc4afd30fe8e95a1cec5

Parsing.

view details

Vladimir Chebotarev

commit sha 1146efacffee306b59718e9c7eb6e75ea5c01ea5

Partitioned writes for S3.

view details

Vladimir Chebotarev

commit sha 0879dbbfa7a719bd2d6c6c85fa708511e0b34b1f

Test.

view details

Vladimir Chebotarev

commit sha 328213f5d9d64e1afa1d792cb2d7b4184fa8edbb

Fixes.

view details

Vladimir Chebotarev

commit sha e99433e0941d785d9c1d097071d0f796001a5780

Better functionality.

view details

Vladimir Chebotarev

commit sha d1efe3afa7c399e001c578023d90f09c400595f7

Review fixes.

view details

Vladimir Chebotarev

commit sha c008eab31aee95dce1f3e00c4fc6b84fefaf0ec6

Review fixes.

view details

vdimir

commit sha d13b98d1c093004643fb262678e7b20d86e88bc6

Add test for unsupported INSERT PARTITION BY

view details

vdimir

commit sha eb31b194b9b20e6c965e32d95185d54bb2f4e818

Add validation to insert partition by key to s3

view details

vdimir

commit sha f02ceedd92e9ec99b75987ed90adf1f8b91d8690

Add 01944_insert_partition_by to arcadia and fasttest skip list

view details

vdimir

commit sha 4c9fb7ff582a364d490e5020edac986b128b1eb1

Fix error code in StorageS3.cpp

view details

Vladimir Chebotarev

commit sha 5ce9e266b4aa0299ea908c474f183fe4fc7eed2f

Less strict validation.

view details

Vladimir Chebotarev

commit sha b4484f4f213305f3f6bbef49ccd661859ee959b4

Test fix.

view details

Vladimir Chebotarev

commit sha 6b75863dd48e051acf7b5d5a75656487a273580a

Test fix.

view details

Vladimir Chebotarev

commit sha 24fcf152ed460b7d6190a56094e5c7bfa347d4e4

Minor fix.

view details

Vladimir Chebotarev

commit sha be343766a6dce8e72937b43e9083c795a59ac1aa

Update src/Storages/StorageS3.cpp Co-authored-by: Vladimir C <vdimir@yandex-team.ru>

view details

Vladimir Chebotarev

commit sha b34f60ad4627c3a5e70a545aa36f261273aff888

Fixed `find`.

view details

push time in 9 days

issue closedAmokHuginnsson/replxx

HISTORY_INCREMENTAL_SEARCH breaks line readering

When we have huge lines in history, ctrl-r (HISTORY_INCREMENTAL_SEARCH) will lead to chaos line rendering.

image

closed time in 9 days

amosbird

issue commentAmokHuginnsson/replxx

HISTORY_INCREMENTAL_SEARCH breaks line readering

Though Clickhouse client has its own set of improvements that would have to be ported back to replxx if you were gonna switch to this repo.

The intense color is the only diff now)

If this issue is solved, can it closed?

Lemme do that for you. Thank you!

amosbird

comment created time in 9 days

Pull request review commentClickHouse/ClickHouse

Handle null column correctly in JSONFunction.

 class FunctionJSON : public IFunction, WithContext     String getName() const override { return Name::name; }     bool isVariadic() const override { return true; }     size_t getNumberOfArguments() const override { return 0; }++    // Both NULL and JSON NULL should generate NULL value.+    bool useDefaultImplementationForNulls() const override { return false; }+     bool useDefaultImplementationForConstants() const override { return true; }     bool isSuitableForShortCircuitArgumentsExecution(const DataTypesWithConstInfo & /*arguments*/) const override { return true; }      DataTypePtr getReturnTypeImpl(const ColumnsWithTypeAndName & arguments) const override     {+        NullPresence null_presence = getNullPresense(arguments);++        if (null_presence.has_null_constant)+        {+            return makeNullable(std::make_shared<DataTypeNothing>());+        }+        if (null_presence.has_nullable)+        {+            auto nested_columns = createBlockWithNestedColumns(arguments);+            auto return_type = Impl<DummyJSONParser>::getReturnType(Name::name, nested_columns);+            return makeNullable(return_type);+        }         return Impl<DummyJSONParser>::getReturnType(Name::name, arguments);     }      ColumnPtr executeImpl(const ColumnsWithTypeAndName & arguments, const DataTypePtr & result_type, size_t input_rows_count) const override     {+        NullPresence null_presence = getNullPresense(arguments);

Sure. In fact let's build a OverloadResolver and store NullPresence beforehand.

amosbird

comment created time in 9 days

PullRequestReviewEvent

Pull request review commentClickHouse/ClickHouse

Handle null column correctly in JSONFunction.

 class FunctionJSON : public IFunction, WithContext     String getName() const override { return Name::name; }     bool isVariadic() const override { return true; }     size_t getNumberOfArguments() const override { return 0; }++    // Both NULL and JSON NULL should generate NULL value.+    bool useDefaultImplementationForNulls() const override { return false; }+     bool useDefaultImplementationForConstants() const override { return true; }     bool isSuitableForShortCircuitArgumentsExecution(const DataTypesWithConstInfo & /*arguments*/) const override { return true; }      DataTypePtr getReturnTypeImpl(const ColumnsWithTypeAndName & arguments) const override     {+        NullPresence null_presence = getNullPresense(arguments);++        if (null_presence.has_null_constant)+        {+            return makeNullable(std::make_shared<DataTypeNothing>());+        }+        if (null_presence.has_nullable)+        {+            auto nested_columns = createBlockWithNestedColumns(arguments);+            auto return_type = Impl<DummyJSONParser>::getReturnType(Name::name, nested_columns);+            return makeNullable(return_type);+        }         return Impl<DummyJSONParser>::getReturnType(Name::name, arguments);     }      ColumnPtr executeImpl(const ColumnsWithTypeAndName & arguments, const DataTypePtr & result_type, size_t input_rows_count) const override     {+        NullPresence null_presence = getNullPresense(arguments);+        if (null_presence.has_null_constant)+        {+            // Default implementation for nulls returns null result for null arguments,+            // so the result type must be nullable.+            if (!result_type->isNullable())+                throw Exception(ErrorCodes::LOGICAL_ERROR,+                                "Function {} with Null argument and default implementation for Nulls "+                                "is expected to return Nullable result, got {}", result_type->getName());

The exception is useless. It's not meant to catch any bug... I'll rewrite.

amosbird

comment created time in 9 days

PullRequestReviewEvent

issue commentAmokHuginnsson/replxx

Line continuation support

@AmokHuginnsson This is pure awesome! I've started using it for a couple of hours now. However, there is one tiny issue: when moving cursors faster enough (word movements), replxx seems rendering a bit slow. I can visibly experience text "jittering". Maybe we can improve the performance somehow?

nvanwyen

comment created time in 9 days

issue commentAmokHuginnsson/replxx

HISTORY_INCREMENTAL_SEARCH breaks line readering

Awesome! Now it works as expected. Btw, is it ok for me to submit this PR back to the upstream here https://github.com/ClickHouse-Extras/replxx/pull/6 , so that we can switch back to this repo instead of maintaining the fork (•‿•)

amosbird

comment created time in 9 days