profile
viewpoint
Amira Salah amirasalah Cairo, Egypt

amirasalah/react-login 1

simple login page using Create React App

amirasalah/algods 0

https://trusting-hugle-a03e93.netlify.app/

amirasalah/algos-cocktail 0

Collection of Algorithms from different sources written in vanilla JS (Well, Its TS actually!) and tested in Jest

amirasalah/Chuck-Norris-Extravaganza 0

First Rule of Chuck Norris is: Do Not Talk About Chuck Norris.

amirasalah/covid19-react 0

https://musing-heisenberg-a6d5fc.netlify.app/

amirasalah/random-dogs 0

Little weekend projects of random dogs written in vanilla js

startedmafintosh/csv-parser

started time in an hour

startedkitten/reghex

started time in 2 hours

PullRequestEvent

PR closed commercetools/commercetools-jvm-sdk

Adding RetryableSphereClientWithExponentialBackoff SphereClient utility to avoid duplication in other projects.
  • Adding RetryableSphereClientWithExponentialBackoff, which is a SphereClient utility that provides good defaults for retry logic with considering exponential backoff.

  • This code is common code and can be used it everywhere that uses SphereClient. The utility is created in the java-sync, JVM SDK convenience library to avoid code duplication.

  • Updating assertj version for the test cases.

+518 -1

4 comments

4 changed files

praveenkumarct

pr closed time in 8 hours

pull request commentcommercetools/commercetools-jvm-sdk

Adding RetryableSphereClientWithExponentialBackoff SphereClient utility to avoid duplication in other projects.

I would then suggest to split up the class. The calculation of the Backoff could be added to the RetryAction as a new static factory method.

https://github.com/commercetools/commercetools-jvm-sdk/blob/master/commercetools-sdk-base/src/main/java/io/sphere/sdk/retry/RetryAction.java

And as the RetryableSphereClientWithExponentialBackoff acts here as a Factory I think the appropiate place would be in the commercetools-convenience module for it.

https://github.com/commercetools/commercetools-jvm-sdk/tree/master/commercetools-convenience/src/main/java/io/sphere/sdk/client

praveenkumarct

comment created time in 8 hours

push eventcommercetools/commercetools-sync-java

Ahmet Öz

commit sha 68be3d2b89688034bc73dc9d7591e782bb85dec6

Fix broken links in docs. (#634) * Update Travis badge. * Fix broken links in shopping lists docs. * Update dependency updates for the latest release.

view details

Ahmet Öz

commit sha 2126aa7071948a4d424d260e5318befb6e586c56

Merge branch 'master' into dependabot/gradle/org.mockito-mockito-junit-jupiter-3.6.28

view details

push time in 11 hours

delete branch commercetools/commercetools-sync-java

delete branch : fix-broken-links

delete time in 11 hours

push eventcommercetools/commercetools-sync-java

Ahmet Öz

commit sha 68be3d2b89688034bc73dc9d7591e782bb85dec6

Fix broken links in docs. (#634) * Update Travis badge. * Fix broken links in shopping lists docs. * Update dependency updates for the latest release.

view details

push time in 11 hours

push eventcommercetools/nodejs

Renovate Bot

commit sha b8b6ebf01feaf5d185f3fbd3e80cf3c985585cb4

chore(deps): update all dependencies

view details

push time in 12 hours

push eventcommercetools/nodejs

Renovate Bot

commit sha ae3dec0bbc41aca04fe45939c1acedf6fd29838e

chore(deps): update all dependencies

view details

push time in 13 hours

PR closed commercetools/commercetools-api-reference

Reviewers
addition of required for TypedMoneyDraft,Message, and TypeResourceIde…

…ntifier

Tiffany worked with Microsoft to get the swagger file to import into Azure. Three changes were made, the addition of type for TypedMoneyDraft, Message, and ResourceIdentifier. See https://github.com/commercetools/commercetools-api-reference/issues/198

Is the following syntax correct for adding to the api reference?

+4 -0

3 comments

3 changed files

nspeet

pr closed time in a day

pull request commentcommercetools/commercetools-api-reference

addition of required for TypedMoneyDraft,Message, and TypeResourceIde…

From Jens...' there is no simple way as the used tool for conversion just does it wrong.'

nspeet

comment created time in a day

pull request commentcommercetools/commercetools-api-reference

addition of required for TypedMoneyDraft,Message, and TypeResourceIde…

@jenschude is there a way in this repo / build of the swagger file to add the ‘required": ["type"]’ ? Or should we just use https://raw.githubusercontent.com/commercetools/commercetools-api-reference/master/oas/openapi.yaml

nspeet

comment created time in a day

push eventcommercetools/commercetools-api-reference

Auto Mation

commit sha cf66b89c728479158ed37222a6b77550a7a87870

TASK: Updating RAML types, Postman and OAS definition

view details

push time in a day

push eventcommercetools/commercetools-api-reference

Jens Schulze

commit sha 9ae55f6962825f4f5c39f48176cc929f62604398

use rmf codegen for OAS files

view details

push time in a day

issue closedcommercetools/commercetools-sync-java

Use graphQL endpoint for caching keys -> ids

When caching key to ids of resources like categories and types, the graphQL endpoint could be better used to only fetch the keys instead of fetching the whole information on the resources.

closed time in a day

heshamMassoud

issue closedcommercetools/commercetools-sync-java

check cacheKeysToIds() is needed and make cache methods consistent between services

Description

Make cache related service methods consistent between services, check https://github.com/commercetools/commercetools-sync-java/pull/392#discussion_r289768985

closed time in a day

ahmetoz

push eventcommercetools/commercetools-dotnet-core-sdk

Michele George

commit sha 23eed2054f20158441783ec8537472fdd2587078

Solve Failing Test

view details

push time in a day

pull request commentcommercetools/commercetools-jvm-sdk

url encode key for domain requests

👍

jenschude

comment created time in a day

push eventcommercetools/commercetools-api-reference

Auto Mation

commit sha f6687ecd5a2e3198011050ec8da276e7fe89681c

TASK: Updating RAML types, Postman and OAS definition

view details

push time in a day

push eventcommercetools/commercetools-sdk-php-v2

Auto Mation

commit sha c9359a359ff747e1894c79d753a104ba6ed6b12a

TASK: Updating SDK

view details

push time in a day

push eventcommercetools/commercetools-api-reference

Jens Schulze

commit sha aa0a215fae1b561daf1da3b45a93513c3f5a84ba

fix money type in TaxedPriceDraft

view details

push time in a day

delete branch commercetools/commercetools-api-reference

delete branch : generic_update

delete time in a day

pull request commentcommercetools/commercetools-api-reference

addition of required for TypedMoneyDraft,Message, and TypeResourceIde…

It's not working like this :)

OAS and RAML are completely different formats and you can't just put OAS definitions inside a RAML file. As you can see in the checks that the validations failed.

We have to find another way fixing these issues.

nspeet

comment created time in a day

create barnchcommercetools/sunrise-spa

branch : feature/subscription

created branch time in 2 days

PR opened commercetools/commercetools-api-reference

Reviewers
addition of required for TypedMoneyDraft,Message, and TypeResourceIde…

…ntifier

Tiffany worked with Microsoft to get the swagger file to import into Azure. Three changes were made, the addition of type for TypedMoneyDraft, Message, and ResourceIdentifier.

Is the following syntax correct for adding to the api reference?

+4 -0

0 comment

3 changed files

pr created time in 2 days

create barnchcommercetools/commercetools-api-reference

branch : typeParity

created branch time in 2 days

push eventcommercetools/commercetools-jvm-sdk

Jens Schulze

commit sha c8dd01f246bfb8fa12e737b17344bb0c67f542ca

url encode key for domain requests

view details

Jens Schulze

commit sha 0cd8a6a7d965553b0fa891f48906d59c2a7111db

update release note

view details

Jens Schulze

commit sha 24c6a11a1aacb156a84e43970187f65dfda8bfb4

Merge pull request #2087 from commercetools/url_encode_key

view details

push time in 2 days

delete branch commercetools/commercetools-jvm-sdk

delete branch : url_encode_key

delete time in 2 days

more