profile
viewpoint
Łukasz Langa ambv Poznań, Poland http://lukasz.langa.pl Python 3.8 & 3.9 Release Manager. llanga on Twitter. Python core developer, hobbyist musician, dad.

ambv/bitrot 130

Detects bit rotten files on the hard drive to save your precious photo and music collection from slow decay.

ambv/flake8-mypy 107

A plugin for flake8 integrating Mypy.

ambv/dj.choices 31

An enum implementation for Django forms and models

ambv/dj.chain 21

An object that enables chaining multiple iterables to serve them lazily as a queryset-compatible object.

ambv/flake8-pyi 20

A plugin for Flake8 that provides specializations for type hinting stub files

ambv/aiotone 18

A demo of using AsyncIO for music sequencing

ambv/aioecho 15

A non-broken echo protocol example for asyncio

ambv/commonplace 15

A basic Python-based publishing platform based around the idea of commonplace books

ambv/.dot_files 13

My distributed configuration

ambv/gha-issuenumber 6

A GitHub action that enforces all commits have issue numbers linked

push eventpython/peps

Łukasz Langa

commit sha 0c1b259034c4ba7ccf724dc7732a4c3a22e3b770

[pep-0596] Actual date for 3.9.0rc2, planned dates for 3.9.1+

view details

push time in 4 days

create barnchpython/cpython

branch : branch-v3.9.0

created branch time in 4 days

created tagpython/cpython

tagv3.9.0rc2

The Python programming language

created time in 4 days

push eventpython/cpython

Łukasz Langa

commit sha 2bd31b5fde32194a63ca1e782e2578c6bd2ba759

Python 3.9.0rc2

view details

Łukasz Langa

commit sha 274e9cee50edba545ebd405d6b1892c768810fb9

Merge tag 'v3.9.0rc2' into 3.9 Python 3.9.0rc2

view details

Łukasz Langa

commit sha 1f7c99ccf600bd1f3ef3168cc033d963f825d0e1

Post 3.9.0rc2

view details

push time in 4 days

push eventambv/cpython

Łukasz Langa

commit sha 2bd31b5fde32194a63ca1e782e2578c6bd2ba759

Python 3.9.0rc2

view details

Miss Islington (bot)

commit sha 4465df626684fdc8eeb25ca248218cde2eeeb9ec

_auto_called cleanup (GH-22285) (cherry picked from commit fc23a9483ef0d7c98bea9f82392377d0b6ef7b18) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

view details

Ethan Furman

commit sha a9ba8ba9a71f3cb8d274c354ff67b6206abeb8ac

[3.9] bpo-39728: Enum: fix duplicate `ValueError` (GH-22277) (GH-22282) fix default `_missing_` to return `None` instead of raising a `ValueError` Co-authored-by: Andrey Darascheka <andrei.daraschenka@leverx.com> (cherry picked from commit c95ad7a91fbd7636f33a098d3b39964ab083bf49) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

view details

Miss Islington (bot)

commit sha f76a3889d1fc6c5514323866a047b642c6da4e9b

bpo-41662: Fix bugs in binding parameters in sqlite3 (GH-21998) * When the parameters argument is a list, correctly handle the case of changing it during iteration. * When the parameters argument is a custom sequence, no longer override an exception raised in ``__len__()``. (cherry picked from commit 0b419b791077414bbc011a412698ebb362b63761) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

view details

Łukasz Langa

commit sha 274e9cee50edba545ebd405d6b1892c768810fb9

Merge tag 'v3.9.0rc2' into 3.9 Python 3.9.0rc2

view details

Łukasz Langa

commit sha 1f7c99ccf600bd1f3ef3168cc033d963f825d0e1

Post 3.9.0rc2

view details

push time in 4 days

created tagambv/cpython

tagv3.9.0rc2

The Python programming language

created time in 5 days

create barnchambv/cpython

branch : branch-v3.9.0rc2

created branch time in 5 days

push eventambv/cpython

Miss Islington (bot)

commit sha 90eff4ed4445a0fa9d8cdf74c0f86c50ed510dad

bpo-41520: codeop no longer ignores SyntaxWarning (GH-21838) (cherry picked from commit 369a1cbdee14d9f27356fb3a8bb21e4fde289d25) Co-authored-by: Victor Stinner <vstinner@python.org>

view details

Guido van Rossum

commit sha b3ad2ca56afc6a56c9a6e7b419bc05e8e5b15e19

[3.9] bpo-40979: refactored typing.rst; (mostly) same content, new sub-sections and ordering (GH-21574) (#21843) Also added PEP 585 deprecation notes. (cherry picked from commit ab72fdeb82) Co-authored-by: Luciano Ramalho <luciano@ramalho.org>

view details

Terry Jan Reedy

commit sha f24430f1542ea2768793b48704ae2d4e241892ae

[3.9] bpo-41520: Fix second codeop regression (GH-21848) Fix the repression introduced by the initial regression fix. (cherry picked from commit c818b15fa59039de67022c29085d439fa5d3ef95) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

view details

Miss Islington (bot)

commit sha 3dd1153b9963cc7fc74ba2fa5bf2be46f154c613

bpo-41066: Update the comparison section for os vs pathlib (GH-21261) (cherry picked from commit 0eb9deb4a62e6d9daa82bc2f67d1075864ca8ece) Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <thatiparthysreenivas@gmail.com>

view details

Miss Islington (bot)

commit sha 7fcd515c353dabf645fe34b7806ab17feac22957

Fixed comment about pathlib.link_to: it was added in 3.8, not changed. (GH-21851) (cherry picked from commit a3eae43aeedb6e6a31adeab3c0c90961d05ab113) Co-authored-by: Facundo Batista <facundo@taniquetil.com.ar>

view details

Miss Islington (bot)

commit sha 75c2281762932c4e5f0bd7deae40ef014f704de2

bpo-41526: Fixed layout of final page of the installer (GH-21871) (cherry picked from commit 6444ca946984c638c67a72aac22fd6d3cc650c16) Co-authored-by: Steve Dower <steve.dower@python.org>

view details

Miss Islington (bot)

commit sha 7c288413db8c2b84dd476b0c8a19f85110d99a2f

bpo-41410: Fix outdated info in mkstemp docs (GH-21701) Automerge-Triggered-By: @ericvsmith (cherry picked from commit e55de68be3e5b977a17d3c0ac9805b0feff8fedc) Co-authored-by: Rishav Kundu <rk@rishav.io>

view details

Miss Islington (bot)

commit sha 33d3c64095bcdf9066a3441f6dda5d2e2f4118a8

bpo-41025: Fix subclassing for zoneinfo.ZoneInfo (GH-20965) (GH-21876) Prior to this change, attempting to subclass the C implementation of zoneinfo.ZoneInfo gave the following error: TypeError: unbound method ZoneInfo.__init_subclass__() needs an argument https://bugs.python.org/issue41025 (cherry picked from commit 87d8287865e5c9f137f6b5cf8c34c2c509eb5e9d) Co-authored-by: Paul Ganssle <paul@ganssle.io>

view details

Miss Islington (bot)

commit sha 31bc45c4b275a0bfcb46e5a115276f1daa814523

Fix typo in typing doc (GH-21879) Automerge-Triggered-By: @gvanrossum (cherry picked from commit fa5d7251987c70a9c5d58b59a0b36ac9287eaafa) Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>

view details

Miss Islington (bot)

commit sha fc8ffe27b6f29d67b76fb2ef57466c95af5a9f82

bpo-31122: ssl.wrap_socket() now raises ssl.SSLEOFError rather than OSError when peer closes connection during TLS negotiation (GH-18772) [bpo-31122](): ssl.wrap_socket() now raises ssl.SSLEOFError rather than OSError when peer closes connection during TLS negotiation Reproducer: http://tiny.cc/f4ztnz (tiny url because some bot keeps renaming b.p.o.-nnn as bpo links) (cherry picked from commit 495bd035662fda29639f9d52bb6baebea31d72fa) Co-authored-by: Dima Tisnek <dimaqq@gmail.com>

view details

Miss Islington (bot)

commit sha 1864eacc22485b26c0ec0a059c9330f877861afb

bpo-40878: xlc cannot handle C99 extern inline. (GH-21891) This applies to the default "extc99" mode. Python does not compile with "stdc99". (cherry picked from commit 40e700ad042089120456cc2ee79b8ca69479416b) Authored-by: Stefan Krah <skrah@bytereef.org>

view details

Miss Islington (bot)

commit sha 28bf82661ac9dfaf1b2d0fd0ac98fc0b31cd95bb

bpo-41540: AIX: skip test that is flaky with a default ulimit. (GH-21890) (#21893) - AIX has extreme over-allocation that is in no relation to the physical RAM and swap. (cherry picked from commit 39dab24621122338d01c1219bb0acc46ba9c9956) Authored-by: Stefan Krah <skrah@bytereef.org>

view details

Miss Islington (bot)

commit sha 2c050e52f1ccf5db03819e4ed70690521d67e9fa

[3.9] bpo-41503: Fix race between setTarget and flush in logging.handlers.MemoryHandler (GH-21765) (GH-21897) (cherry picked from commit 2353d77fad7ed9d11d8a4d66b5dd1306cdb94125) Co-authored-by: Irit Katriel <iritkatriel@yahoo.com> Automerge-Triggered-By: @vsajip

view details

Miss Islington (bot)

commit sha d6bdf6d52f0400df1bd1dce24aaad9514015c755

bpo-40782: Change asyncio.AbstractEventLoop.run_in_executor to be a method not a coroutine (GH-21852) asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method. This matches the concrete implementations, and the documentation better. (cherry picked from commit 29f84294d88ec493c2de9d6e8dbc12fae3778771) Co-authored-by: James Weaver <james.barrett@bbc.co.uk>

view details

Miss Islington (bot)

commit sha e3cafebb5cb2bc4df03afb03fa206a37d076d7ee

bpo-41568: Fix refleaks in zoneinfo subclasses (GH-21907) * Fix refleak in C module __init_subclass__ This was leaking a reference to the weak cache dictionary for every ZoneInfo subclass created. * Fix refleak in ZoneInfo subclass's clear_cache The previous version of the code accidentally cleared the global ZONEINFO_STRONG_CACHE variable (and inducing `ZoneInfo` to create a new strong cache) on calls to a subclass's `clear_cache()`. This would not affect guaranteed behavior, but it's still not the right thing to do (and it caused reference leaks). (cherry picked from commit c3dd7e45cc5d36bbe2295c2840faabb5c75d83e4) Co-authored-by: Paul Ganssle <paul@ganssle.io>

view details

Victor Stinner

commit sha 8f88190af529543c84d5dc78f19abbfd73335cf4

[3.9] bpo-40204: Allow pre-Sphinx 3 syntax in the doc (GH-21844) (GH-21901) * bpo-40204: Allow pre-Sphinx 3 syntax in the doc (GH-21844) Enable Sphinx 3.2 "c_allow_pre_v3" option and disable the c_warn_on_allowed_pre_v3 option to make the documentation compatible with Sphinx 2 and Sphinx 3. (cherry picked from commit 423e77d6de497931585d1883805a9e3fa4096b0b) * bpo-40204: Fix Sphinx sytanx in howto/instrumentation.rst (GH-21858) Use generic '.. object::' to declare markers, rather than abusing '.. c:function::' which fails on Sphinx 3. (cherry picked from commit 43577c01a2ab49122db696e9eaec6cb31d11cc81) * bpo-40204: Fix duplicates in the documentation (GH-21857) Fix two Sphinx 3 issues: Doc/c-api/buffer.rst:304: WARNING: Duplicate C declaration, also defined in 'c-api/buffer'. Declaration is 'PyBUF_ND'. Doc/c-api/unicode.rst:1603: WARNING: Duplicate C declaration, also defined in 'c-api/unicode'. Declaration is 'PyObject* PyUnicode_Translate(PyObject *str, PyObject *table, const char *errors)'. (cherry picked from commit 46d10b1237c67ff8347f533eda6a5468d098f7eb) * bpo-40204: Add :noindex: in the documentation (GH-21859) Add :noindex: to duplicated documentation to fix "duplicate object description" errors. For example, fix this Sphinx 3 issue: Doc/library/configparser.rst:1146: WARNING: duplicate object description of configparser.ConfigParser.optionxform, other instance in library/configparser, use :noindex: for one of them (cherry picked from commit d3ded080482beae578faa704b13534a62d066f9f) * bpo-40204, doc: Fix syntax of C variables (GH-21846) For example, fix the following Sphinx 3 errors: Doc/c-api/buffer.rst:102: WARNING: Error in declarator or parameters Invalid C declaration: Expected identifier in nested name. [error at 5] void \*obj -----^ Doc/c-api/arg.rst:130: WARNING: Unparseable C cross-reference: 'PyObject*' Invalid C declaration: Expected end of definition. [error at 8] PyObject* --------^ The modified documentation is compatible with Sphinx 2 and Sphinx 3. (cherry picked from commit 474652fe9346382dbf793f20b671eb74668bebde) * bpo-40204: Fix reference to terms in the doc (GH-21865) Sphinx 3 requires to refer to terms with the exact case. For example, fix the Sphinx 3 warning: Doc/library/pkgutil.rst:71: WARNING: term Loader not found in case sensitive match.made a reference to loader instead. (cherry picked from commit bb0b08540cc93e56f3f1bde1b39ce086d9e35fe1) * bpo-40204: Fix duplicated productionlist names in the doc (GH-21900) Sphinx 3 disallows having more than one productionlist markup with the same name. Simply remove names in this case, since names are not shown anyway. For example, fix the Sphinx 3 warning: Doc/reference/introduction.rst:96: duplicate token description of *:name, other instance in reference/expressions (cherry picked from commit 1abeda80f760134b4233608e2c288790f955b95a)

view details

Miss Islington (bot)

commit sha 3949827a54f79266a2f1434d187c8ac4905db316

Doc: add a missing period (GH-21819) (#21932) (cherry picked from commit 12695f4c6d1167c0863098a586f3dfeb77a7cb9a) Co-authored-by: Mathieu Dupuy <deronnax@gmail.com> Co-authored-by: Mathieu Dupuy <deronnax@gmail.com>

view details

Miss Islington (bot)

commit sha a2d00f04733491a56abec45e7a20fb42282bb4d1

bpo-41572: Fix grammar in BaseTransport.close docstring (GH-21914) (#21929) Fix grammar in BaseTransport.close docstring. https://bugs.python.org/issue41572 Signed-off-by: Cleber Rosa <crosa@redhat.com> (cherry picked from commit 1afb42cfa82dad0ddd726f59c6c5fcb3962314db) Co-authored-by: Cleber Rosa <cleber.gnu@gmail.com>

view details

Miss Islington (bot)

commit sha 429a86a12016ae42ea32d754e0725cbee8e99808

bpo-41573: Update release versions in General FAQ (GH-21915) (#21938) (cherry picked from commit 7173fc84e61b80b19261e47fca38030206a3a78e) Co-authored-by: wyz23x2 <52805709+wyz23x2@users.noreply.github.com>

view details

Miss Islington (bot)

commit sha f497bbeed08e5a7f83adecf330b61fb88e9c3fa6

bpo-40994: Ungroup items in collections.abc documentation for improved clarity (GH-21880) (#21926) Use a less surprising document structure. Automerge-Triggered-By: @csabella (cherry picked from commit 2ce39631f679e14132a54dc90ce764259d26e166) Co-authored-by: Sydney Pemberton <46042811+sydneypemberton1986@users.noreply.github.com>

view details

push time in 5 days

push eventpython/cpython

Łukasz Langa

commit sha 7e356f17e4c91392b6fa45a512efc95923388813

[3.9] bpo-41687: Fix sendfile implementation to work with Solaris (GH-22040) (GH-22273) (cherry picked from commit 8c0be6fd9101746235b63ddfb84106d1e9ca286b) Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>

view details

push time in 5 days

PR merged python/cpython

Reviewers
[3.9] bpo-41687: Fix sendfile implementation to work with Solaris (GH-22040) CLA signed awaiting core review

(cherry picked from commit 8c0be6fd9101746235b63ddfb84106d1e9ca286b)

Co-authored-by: Jakub Kulík Kulikjak@gmail.com

<!-- issue-number: bpo-41687 --> https://bugs.python.org/issue41687 <!-- /issue-number -->

+26 -0

0 comment

3 changed files

ambv

pr closed time in 5 days

issue openedpolyend/TrackerIssues

[1.1.14] Position FX command doesn't work with loops and reverse playback

See attached video.

  1. First it shows the entire sample in Pattern 1.
  2. Then it shows proper position selection with the p command in Pattern 2.
  3. Then still in Pattern 2 it shows the p command not working when the sample playback is set to loop forward instead of single shot. That's problem 1.
  4. Then in Pattern 3 it shows the p command behaves erratically when r<<< is used:
  • it does not change the starting position of reverse playback;
  • but it does affect the duration of playback (note the sample being cut sooner when p greater than zero is selected). That's problem 2 which is a specific case of FX1 and FX2 not working in tandem.

Attachments and links

https://www.dropbox.com/s/a0k49vwnaz3712f/PositionFX-reverse.mov?dl=0

Other important information

  • How often does this bug happen? (every time, often, "it only happened once") every time

  • Does this bug happen in previous firmware versions? yes, tested since at least 1.1.5

  • Does this bug happen in every project? yes

created time in 5 days

pull request commentpython/cpython

bpo-37779 : Add information about the overriding behavior of ConfigParser.read

Looks like the failure is real: the documentation doctest fails with:

File "library/configparser.rst", line 246, in default
Failed example:
    topsecret.getboolean('BatchMode', fallback=True)
Expected:
    False
Got:
    True

...

 Makefile:127: recipe for target 'doctest' failed
make: *** [doctest] Error 1
make: Leaving directory '/home/runner/work/cpython/cpython/Doc'

@sblondon, please confirm you can successfully build the documentation locally by running this in the main directory of your cpython checkout:

make -C Doc/ PYTHON=../python doctest suspicious html
sblondon

comment created time in 5 days

PullRequestEvent

pull request commentpython/cpython

bpo-37779 : Add information about the overriding behavior of ConfigParser.read

Closing and re-opening to re-trigger CI checks which were spuriously failing before.

sblondon

comment created time in 5 days

PR closed python/cpython

Reviewers
bpo-37779 : Add information about the overriding behavior of ConfigParser.read CLA signed awaiting changes skip news type-documentation

This PR adds documentation about the ability to override values when ConfigParser.read(), .read_string(), .read_dict() are called several times from the same instance of ConfigParser.

<!-- issue-number: bpo-37779 --> https://bugs.python.org/issue37779 <!-- /issue-number -->

+24 -0

11 comments

1 changed file

sblondon

pr closed time in 5 days

push eventambv/cpython

Dong-hee Na

commit sha 94ad6c674f7687ef22853cb8d42b440d6b42ddc8

bpo-33660: Fix PosixPath to resolve a relative path on root

view details

MingZhe Hu

commit sha 8c58d2a216ca2b5965361df9b8d8944bc7d4854d

bpo-41624: fix documentation of typing.Coroutine (GH-21952)

view details

Mason

commit sha b260635b3db5715adf7a9a3df542c171fb7296ef

Add missing word (GH-21936) "data to lost" -> "data to be lost"

view details

Irit Katriel

commit sha 022bc7572f061e1d1132a4db9d085b29707701e7

bpo-41609: Fix output of pdb's whatis command for instance methods (GH-21935)

view details

wmeehan

commit sha 97eaf2b5e5c826b9abe59896a363853bef55c5d9

bpo-41524: fix pointer bug in PyOS_mystr{n}icmp (GH-21845) * bpo-41524: fix pointer bug in PyOS_mystr{n}icmp The existing implementations of PyOS_mystrnicmp and PyOS_mystricmp can increment pointers beyond the end of a string. This commit fixes those cases by moving the mutation out of the condition. * 📜🤖 Added by blurb_it. * Address comments Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

view details

Zackery Spytz

commit sha 398575c210f79627830c5c470184f54ace950ac6

bpo-41634: Fix a typo in the curses documentation (GH-21958)

view details

Petr Viktorin

commit sha d9a966ae08258da2ce2a432c943d8194760f09c4

bpo-38787: Clarify docs for PyType_GetModule and warn against common mistake (GH-20215)

view details

SarahPythonista

commit sha 8784d3300ec4ffc58bc0e9ab3cff9a24187dbe4c

Fix error in argparse documentation example (GH-17399) Automerge-Triggered-By: @rhettinger

view details

Stefan Krah

commit sha e6dcd371b2c54a94584dd124e8c592a496d46a47

bpo-19521: Fix parallel build race condition on AIX (GH-21997) Patch by Michael Haubenwallner.

view details

Raymond Hettinger

commit sha 27de28607a248e5ffb8838162fca466a58c2e284

bpo-41513: Save unnecessary steps in the hypot() calculation (#21994)

view details

Roger Iyengar

commit sha c68c5af2dc5ada8875a662f2beaac6234eae2a5a

Improve asyncio-dev 'Concurrency and Multithreading' docs (GH-20882) I added some information to the `Concurrency and Multithreading` section of the `Developing with asyncio` guide. This is all information that would have helped me when I started using asyncio. I incorrectly assumed that `loop.call_soon_threadsafe()` and `run_coroutine_threadsafe()` could be called from a thread in a process separate from the one that the event loop is running in. Explicitly stating that this will not work will probably help some people starting out with asyncio in the future. I also added references to some other functions that can be used for inter-process communication without blocking the event loop. The section already mentions running blocking code in a ThreadPoolExecutor, but I think listing these other options in this section will also be helpful.

view details

Tony Solomonik

commit sha 75c80b0bda89debf312f075716b8c467d411f90e

closes bpo-41533: Fix a potential memory leak when allocating a stack (GH-21847) Free the stack allocated in va_build_stack if do_mkstack fails and the stack is not a small_stack

view details

Raymond Hettinger

commit sha 92c38164a42572e2bc0b1b1490bec2369480ae08

Further improve accuracy of math.hypot() (GH-22013)

view details

Irit Katriel

commit sha 582f13786bb75c73d609790967fea03a5b50148a

bpo-39994: Fix pprint handling of dict subclasses that override __repr__ (GH-21892) Co-authored-by: Palak Kumar Jha

view details

Vinay Sharma

commit sha 475a5fbb5644ea200c990d85d8c264e78ab6c7ea

bpo-41344: Raise ValueError when creating shared memory of size 0 (GH-21556)

view details

Andre Delfino

commit sha c3a651ad2544d7d1be389b63e9a4a58a92a31623

[doc] Fix markup in logging (GH-22008)

view details

Ben Darnell

commit sha ea5a6363c3f8cc90b7c0cc573922b10f296073b6

bpo-39010: Fix errors logged on proactor loop restart (#22017) Stopping and restarting a proactor event loop on windows can lead to spurious errors logged (ConnectionResetError while reading from the self pipe). This fixes the issue by ensuring that we don't attempt to start multiple copies of the self-pipe reading loop.

view details

Andre Delfino

commit sha 3584d4b64a5373440f78237eac734831cfd83f79

[doc] Document VIRTUAL_ENV environment variable (GH-21970)

view details

Ned Deily

commit sha a4c4e17f959621ab00a98086af1704fb0c896466

bpo-41685: Temporarily pin setuptools to 49.2.1 in Docs venv. (GH-22038) See https://github.com/pypa/setuptools/pull/2361

view details

Andre Delfino

commit sha f5a16b4dbf62cb9b48c42098bd5a8cfa665456c3

[doc] Add link to FileHandler in logging (GH-21940) Co-authored-by: Andrés Delfino <adelfino@onapsis.com>

view details

push time in 5 days

PR opened python/cpython

Reviewers
[3.9] bpo-41687: Fix sendfile implementation to work with Solaris (GH-22040)

(cherry picked from commit 8c0be6fd9101746235b63ddfb84106d1e9ca286b)

Co-authored-by: Jakub Kulík Kulikjak@gmail.com

+26 -0

0 comment

3 changed files

pr created time in 5 days

create barnchambv/cpython

branch : backport-8c0be6f-3.9

created branch time in 5 days

issue commentpolyend/TrackerIssues

[1.1.14] Caps Lock Cosmetic Issue

Looks like this works as intended: caps

@MegaTurrican, can you take a picture of the device in the Caps state where the keys are not uppercased?

MegaTurrican

comment created time in 5 days

issue openedpolyend/TrackerIssues

Hex display of pattern position

Decimal positions

Currently pattern positions are decimal and indexing starts at 1: tracker-current-status-no-hex

Hexadecimal positions

I'd like to propose a traditional hexadecimal position numbering with indexes starting at 0: tracker-hex

Advantages

The most important advantage of this design is that when using 4/4 meter, all beats are on power-of-two values. In the screenshot you see beats of the first bar on 00, 04, 08, 0C. What would be the second bar? 10, 14, 18, 1C. Third bar? 20, 24, 28, 2C. Fourth bar? 30, 34, 38, 3C. And so on. As you can see, there's a pattern. Bars start at 00, 10, 20, 30, and so on. Divisions inside bars have predictable values.

Compare this with the current situation: first bar beats are 1, 5, 9, 13. Can you guess what the second bar beats will be? 17, 21, 25, 29. Third is 33, 37, 41, 45. Fourth is 49, 53, 57, 61. Hard to predict, no discernible pattern.

The hexadecimal notation is natural for existing users of tracker software.

Implementation

  • The feature would be toggleable in Config.
  • The feature is global (per device, not per project).
  • This feature request only discusses hexadecimal pattern position.
  • For consistency it would make sense to also make pattern numbers themselves hexadecimal, too.
  • All other numeric values in the Tracker software, in particular instrument indexes, FX values, and automation, would stay decimal, displayed as is today.
  • The change would require display of pattern positions and pattern numbers to be consistently hexadecimal on all screens, including button labels on the bottom part of the screen.
  • Leading zeroes are displayed to help users tell that the hexadecimal mode is enabled.

created time in 5 days

push eventpython/cpython

Pablo Galindo

commit sha 55e0836849c14fb474e1ba7f37851e07660eea3c

[3.9] bpo-41631: _ast module uses again a global state (GH-21961) (GH-22258) Partially revert commit ac46eb4ad6662cf6d771b20d8963658b2186c48c: "bpo-38113: Update the Python-ast.c generator to PEP384 (gh-15957)". Using a module state per module instance is causing subtle practical problems. For example, the Mercurial project replaces the __import__() function to implement lazy import, whereas Python expected that "import _ast" always return a fully initialized _ast module. Add _PyAST_Fini() to clear the state at exit. The _ast module has no state (set _astmodule.m_size to 0). Remove astmodule_traverse(), astmodule_clear() and astmodule_free() functions.. (cherry picked from commit e5fbe0cbd4be99ced5f000ad382208ad2a561c90) Co-authored-by: Victor Stinner <vstinner@python.org>

view details

push time in 6 days

PR merged python/cpython

Reviewers
[3.9] bpo-41631: _ast module uses again a global state (GH-21961) CLA signed awaiting core review

Partially revert commit ac46eb4ad6662cf6d771b20d8963658b2186c48c: "bpo-38113: Update the Python-ast.c generator to PEP384 (gh-15957)".

Using a module state per module instance is causing subtle practical problems.

For example, the Mercurial project replaces the import() function to implement lazy import, whereas Python expected that "import _ast" always return a fully initialized _ast module.

Add _PyAST_Fini() to clear the state at exit.

The _ast module has no state (set _astmodule.m_size to 0). Remove astmodule_traverse(), astmodule_clear() and astmodule_free() functions.. (cherry picked from commit e5fbe0cbd4be99ced5f000ad382208ad2a561c90)

Co-authored-by: Victor Stinner vstinner@python.org

<!-- Thanks for your contribution! Please read this comment in its entirety. It's quite important.

Pull Request title

It should be in the following format:

bpo-NNNN: Summary of the changes made

Where: bpo-NNNN refers to the issue number in the https://bugs.python.org.

Most PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.

Backport Pull Request title

If this is a backport PR (PR made against branches other than master), please ensure that the PR title is in the following format:

[X.Y] <title from the original PR> (GH-NNNN)

Where: [X.Y] is the branch name, e.g. [3.6].

GH-NNNN refers to the PR number from master.

-->

<!-- issue-number: bpo-41631 --> https://bugs.python.org/issue41631 <!-- /issue-number -->

+155 -309

0 comment

7 changed files

pablogsal

pr closed time in 6 days

push eventpython/cpython

Victor Stinner

commit sha e5fbe0cbd4be99ced5f000ad382208ad2a561c90

bpo-41631: _ast module uses again a global state (#21961) Partially revert commit ac46eb4ad6662cf6d771b20d8963658b2186c48c: "bpo-38113: Update the Python-ast.c generator to PEP384 (gh-15957)". Using a module state per module instance is causing subtle practical problems. For example, the Mercurial project replaces the __import__() function to implement lazy import, whereas Python expected that "import _ast" always return a fully initialized _ast module. Add _PyAST_Fini() to clear the state at exit. The _ast module has no state (set _astmodule.m_size to 0). Remove astmodule_traverse(), astmodule_clear() and astmodule_free() functions.

view details

push time in 6 days

PR merged python/cpython

Reviewers
bpo-41631: _ast module uses again a global state CLA signed awaiting merge needs backport to 3.9

Using a different state per module instance is causing subtle practical problems.

For example, the Mercurial project replaces the import() function to implement lazy import, whereas Python expected that "import _ast" always return a fully initialized _ast module.

<!-- Thanks for your contribution! Please read this comment in its entirety. It's quite important.

Pull Request title

It should be in the following format:

bpo-NNNN: Summary of the changes made

Where: bpo-NNNN refers to the issue number in the https://bugs.python.org.

Most PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.

Backport Pull Request title

If this is a backport PR (PR made against branches other than master), please ensure that the PR title is in the following format:

[X.Y] <title from the original PR> (GH-NNNN)

Where: [X.Y] is the branch name, e.g. [3.6].

GH-NNNN refers to the PR number from master.

-->

<!-- issue-number: bpo-41631 --> https://bugs.python.org/issue41631 <!-- /issue-number -->

+160 -309

22 comments

7 changed files

vstinner

pr closed time in 6 days

push eventpolyend/TrackerIssues

Łukasz Langa

commit sha 6079d643c0f94f89e5ef3cfac0bc28a3003ca2cf

Add images

view details

push time in 7 days

push eventpolyend/TrackerIssues

Łukasz Langa

commit sha f0946434a86992d663282f5d8e3247c33304d2b6

Add more structure to the templates

view details

push time in 7 days

push eventpolyend/TrackerIssues

Łukasz Langa

commit sha 42afdc6f21ed33c7fdc959d65831b2e430fd75e8

Add helpful links

view details

push time in 7 days

push eventpolyend/TrackerIssues

Łukasz Langa

commit sha 8cd63f3bad9d56f3ba25f92cf5112c3a606f00b6

Reword the README to format nicer

view details

push time in 7 days

pull request commentpython/cpython

bpo-41490: Update ensurepip to install pip 20.2.1 and setuptools 49.2.1

Note: this should be merged ASAP since the "backports" were.

zooba

comment created time in 7 days

delete branch edgedb/edgedb-cli

delete branch : nightly

delete time in 10 days

push eventedgedb/edgedb-cli

Elvis Pranskevichus

commit sha 690582f187f70a1006c9cdcf5d1d8eeef1a3544d

Sign Windows binaries This adds a build step that embeds a signature in the produced executable.

view details

push time in 10 days

PR merged edgedb/edgedb-cli

Reviewers
Sign Windows binaries

This adds a build step that embeds a signature in the produced executable.

+20 -0

1 comment

2 changed files

elprans

pr closed time in 10 days

pull request commentedgedb/edgedb-cli

Sign Windows binaries

Migrations tests timed out on macOS. Unfortunate but unrelated to this PR.

elprans

comment created time in 10 days

PullRequestReviewEvent

push eventedgedb/edgedb-cli

Elvis Pranskevichus

commit sha 654551736f72768430319f3cf105e4465daecb7b

Add Windows build support for nightly Issue: edgedb/edgedb-pkg#5

view details

push time in 11 days

delete branch edgedb/edgedb-cli

delete branch : nightly

delete time in 11 days

delete branch edgedb/edgedb-pkg

delete branch : use-master-branch-on-windows

delete time in 11 days

create barnchedgedb/edgedb-pkg

branch : use-master-branch-on-windows

created branch time in 11 days

push eventedgedb/metapkg

Elvis Pranskevichus

commit sha b28cbb2c3f9b451ae8d93accbb5277f04c343371

Rudimentary Windows support This treats Windows as a Unix-ish target that has all the necessary GNU tools, Python, Git, Rust etc. Issue: edgedb/edgedb-pkg#5

view details

push time in 11 days

PR merged edgedb/metapkg

Reviewers
Rudimentary Windows support

This treats Windows as a Unix-ish target that has all the necessary GNU tools, Python, Git, Rust etc.

Issue: edgedb/edgedb-pkg#5

+122 -16

0 comment

7 changed files

elprans

pr closed time in 11 days

PR merged edgedb/edgedb-pkg

Rudimentary Windows support

This treats Windows as a Unix-ish target that has all the necessary GNU tools, Python, Git, Rust etc.

Closes: #5

+97 -1

0 comment

3 changed files

elprans

pr closed time in 11 days

issue closededgedb/edgedb-pkg

Add Windows build for edgedb-cli

The majority of this is https://github.com/edgedb/metapkg/issues/1, opening this here for the GitHub workflow bits.

closed time in 11 days

elprans

push eventedgedb/edgedb-pkg

Elvis Pranskevichus

commit sha 79cc9a322dd2dee0a879917b585fc8cc45af1277

Rudimentary Windows support This treats Windows as a Unix-ish target that has all the necessary GNU tools, Python, Git, Rust etc. Closes: #5

view details

push time in 11 days

PullRequestReviewEvent

pull request commentedgedb/edgedb-cli

Add Windows build support for nightly

Do we care about the musl-test failure?

elprans

comment created time in 11 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventedgedb/edgedb-pkg

Łukasz Langa

commit sha d033f9eab39361f7c006eb9840e51c2ef6b2032e

Add test for the new version slot logic

view details

Łukasz Langa

commit sha b2475cf3dd2f0c65de8451badd15726eeaab76c9

Actually compile the changed .ts file

view details

Łukasz Langa

commit sha 00792bb731acf5fabd17b9c44c321f71739890b8

Update dev dependencies

view details

push time in 12 days

PR merged edgedb/edgedb-pkg

Update describe-version action's compiled code and tests

After changing the regular expression I failed to actually compile the code locally, making it still run old code effectively. I added a new test to ensure this is no longer the case.

+34 -11

0 comment

4 changed files

ambv

pr closed time in 12 days

PR opened edgedb/edgedb-pkg

Update describe-version action's compiled code and tests

After changing the regular expression I failed to actually compile the code locally, making it still run old code effectively. I added a new test to ensure this is no longer the case.

+34 -11

0 comment

4 changed files

pr created time in 12 days

push eventedgedb/edgedb-pkg

Łukasz Langa

commit sha e18ad2043509e85db2014617aa6ecf862377841f

Add test for the new version slot logic

view details

Łukasz Langa

commit sha a3ddc932e79658f398abda5d0d6f2beeea7c8d24

Actually compile the changed .ts file

view details

Łukasz Langa

commit sha 620a7c82edf9a79b603e405826205692662edc64

Update dev dependencies

view details

push time in 12 days

create barnchedgedb/edgedb-pkg

branch : new-re-test

created branch time in 12 days

push eventpython/peps

Łukasz Langa

commit sha 7cff39a91d6ce68e1a3304a8aa1dc5e53dedbfe5

[pep-0569] Actual date for 3.8.6rc1

view details

push time in 13 days

push eventambv/aiotone

Łukasz Langa

commit sha e4e999f06d4b649c725085ffc808a059ff4c490c

Describe `mothergen` in the README

view details

push time in 13 days

push eventambv/aiotone

Łukasz Langa

commit sha 980aef32ac3133f1f6dde512aeb36ea0dab781fd

Working subharmonic modulation

view details

push time in 13 days

push eventambv/cpython

Łukasz Langa

commit sha 08bd63da6e64c49130d244ecf8f246089b9c5d9f

Python 3.8.6rc1

view details

Miss Islington (bot)

commit sha ebef6c0b50d94ca7daef6fdb38d043e0183ab7d1

bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (GH-22092) (cherry picked from commit fd4cafd4700dc03cb05fc2e5263c2666d785d6e3) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

view details

Łukasz Langa

commit sha 7c6dc8517ee11ce16d36a8a839ec5d4ba6484a7f

Merge tag 'v3.8.6rc1' into 3.8 Python 3.8.6rc1

view details

Łukasz Langa

commit sha 3cb5073773c52c93c53c750b1537aa1d642b6b75

Post 3.8.6rc1

view details

push time in 13 days

created tagpython/cpython

tagv3.8.6rc1

The Python programming language

created time in 13 days

push eventpython/cpython

Łukasz Langa

commit sha 08bd63da6e64c49130d244ecf8f246089b9c5d9f

Python 3.8.6rc1

view details

Łukasz Langa

commit sha 7c6dc8517ee11ce16d36a8a839ec5d4ba6484a7f

Merge tag 'v3.8.6rc1' into 3.8 Python 3.8.6rc1

view details

Łukasz Langa

commit sha 3cb5073773c52c93c53c750b1537aa1d642b6b75

Post 3.8.6rc1

view details

push time in 13 days

delete branch edgedb/edgedb-pkg

delete branch : dev-build-slot

delete time in 14 days

push eventedgedb/edgedb-pkg

Łukasz Langa

commit sha 045e93e3f662a63eb56b3f6c268053a1abdb6339

Make dev builds (like nightlies) their own slots (#23)

view details

push time in 14 days

PR merged edgedb/edgedb-pkg

Make dev builds (like nightlies) their own slots

Changes the version slot from, say, edgedb-server-1-alpha6 to edgedb-server-1-alpha6-dev5034. The dev part is taken directly from the setuptools-scm version scheme, which is the number of commits on the branch. This should make the dev builds effectively monotonic, easy to parse to the human eye, and useful to say, for example: "yeah this EdgeQL syntax is only available since dev6123".

+47 -33

0 comment

27 changed files

ambv

pr closed time in 14 days

created tagambv/cpython

tagv3.8.6rc1

The Python programming language

created time in 14 days

startedpolyend/TrackerIssues

started time in 14 days

startedtuffy/python-audio-tools

started time in 14 days

push eventambv/cpython

Steve Dower

commit sha a18f22ab11a7bfb5ff3e74c737ca9e1bebe4abf9

bpo-41364: Reduce import overhead of uuid module (GH-21586)

view details

Terry Jan Reedy

commit sha 29df301a9236cbae06762d9569e56197d3f5e6ee

[3.8] bpo-4630: Fix errors in Lib/idlelib/NEWS.txt (GH-21594) Also one in news log. (cherry picked from commit 592527f3ee59616eca2bd1da771f7c14cee808d5) Co-authored-by: Zackery Spytz <zspytz@gmail.com>

view details

Miss Islington (bot)

commit sha 1c562ced2123f4d5a250fe9072ac93504cc41967

bpo-41373: IDLE: Fix saving files loaded with no newlines or mixed newlines (GH-21597) Fixes regression in 3.8.4 and 3.9.0b4. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 0dd463c8a4269137ebed7cc29605c555030df94f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

view details

Terry Jan Reedy

commit sha a667e1c66a62d509c39d30abf11778213a1e1ca0

[3.8] bpo-37309: NEWS for #41373 (GH-21612) Cherry-picked from af08db7.

view details

Miss Islington (bot)

commit sha 949cf93f8ee27c37650483458f0aa3e295011ef6

bpo-38731: Fix NameError in command-line interface of py_compile (GH-21617) (cherry picked from commit 2024d7aca100c3faa9c6730aba3de5f0528750be) Co-authored-by: Berker Peksag <berker.peksag@gmail.com>

view details

Miss Islington (bot)

commit sha b99f770230e0db390aa80c5135b1053f3be48e19

bpo-41314: fixed annotations __future__ version (GH-21616) PEP 563 was updated to change the release where `from __future__ import annotations` becomes the default (and only) behavior from 4.0 to 3.10. Update `__future__.py` and its docs to reflect this. (cherry picked from commit 0028c14073109595e7532ec00bb1e8bf39ecfb4d) Co-authored-by: YoSTEALTH <35307184+YoSTEALTH@users.noreply.github.com>

view details

Miss Islington (bot)

commit sha 755cb49429581679fc7b12905cb3d3ecf439032c

bpo-39868: Add documentation for Assignment Expressions (walrus, PEP 572) (GH-18851) (cherry picked from commit f117cef25b5ffc4db9fbe373ddb65e14f59f0397) Co-authored-by: Shankar Jha <shankarj67@gmail.com>

view details

Miss Islington (bot)

commit sha 33cebe0b9a71da97046fc67c03062987c1049418

bpo-41385: Fix test_executable_without_cwd on Windows (GH-21608) (cherry picked from commit b1a87300a06324c9fc7d6553906ed914489465aa) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

view details

Miss Islington (bot)

commit sha 104adedf641dc686069a20ae1a05c821b56e4aa4

bpo-41384: Raise TclError in tkinter.OptionMenu (GH-21601) ... when an unknown option is passed. TypeError was being raised because a 2to3 fix was missing. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit f1d40f941a6483b1d4ea10f1051ace7b426fb8e7) Co-authored-by: Akuli <akuviljanen17@gmail.com>

view details

Guido van Rossum

commit sha 3baff21f5bb8db7fa1c15788a8f82fa040a90d5d

[3.8] bpo-41045: Document debug feature of f-strings ('=') (GH-21509) (#21647) Co-Authored-By: Rishi <rishi93dev@gmail.com> (cherry picked from commit 13efaec) Co-authored-by: amaajemyfren <32741226+amaajemyfren@users.noreply.github.com>

view details

Miss Islington (bot)

commit sha 59cfba326801a1fd809836c16887f53765f9680f

bpo-41328: Replace mention of Hudson CI with Travis CI and AppVeyor (GH-21653) (cherry picked from commit 5e3826785dcc64f8e1a8a7bde11b88fbb40943be) Co-authored-by: Dmytro Litvinov <litvinov.dmytro.it@gmail.com>

view details

Miss Islington (bot)

commit sha 5e0ce46aeb13f31e4dbe6a2891f583e770e0a808

Fix `List_Append` description, list is extracted at TOS1[-i] (GH-21465) (cherry picked from commit 34cd3e9f6a87f9c50edac893b0d5ae46c4e48ee3) Co-authored-by: Xiang Zhang <angwerzx@126.com>

view details

Miss Islington (bot)

commit sha 7cfede6859586f77f786bda56af4698ae2245f56

closes bpo-38156: Always handle interrupts in PyOS_StdioReadline. (GH-21569) This consolidates the handling of my_fgets return values, so that interrupts are always handled, even if they come after EOF. I believe PyOS_StdioReadline is still buggy in that I/O errors will not result in a proper Python exception being set. However, that is a separate issue. (cherry picked from commit a74eea238f5baba15797e2e8b570d153bc8690a7) Co-authored-by: Benjamin Peterson <benjamin@python.org>

view details

Miss Islington (bot)

commit sha b7722ed0f39120c66186aae0f63a82fdff93c55d

Remove incorrect mention of method.__class__ in descriptor docs (GH-21665) (GH-21668)

view details

Miss Islington (bot)

commit sha 038827d0f59076f52e9797018ead12b1295cddc2

bpo-41426 Fix grammar in curses.getmouse() documentation (GH-21677) Automerge-Triggered-By: @brettcannon (cherry picked from commit ba18c0b13ba3c08077ea3db6658328523823a33f) Co-authored-by: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>

view details

Miss Islington (bot)

commit sha 45d37cbb04279a52c63dd180aacda7d35e02a0ef

bpo-41424: Remove extra words in Tkinter-Packer documentation (GH-21707) (cherry picked from commit ecaf949cc487887883c14dff7a96e09ac9404994) Co-authored-by: Nathan M <nathanmaynes@gmail.com>

view details

Miss Islington (bot)

commit sha 4bc8445c392e22fb926eeea50d3e943b6241affa

bpo-41425: Make tkinter doc example runnable (GH-21706) Co-authored-by: Ankit Chandawala <achandaw@amazon.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit c36dbac588e1d99975f285a874bb20e9f5040af4)

view details

Miss Islington (bot)

commit sha b934d832d1e16bf235c536dcde3006faf29757fc

bpo-41467: Fix asyncio recv_into() on Windows (GH-21720) On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b''). (cherry picked from commit 602a971a2af3a685d625c912c400cadd452718b1) Co-authored-by: Victor Stinner <vstinner@python.org>

view details

Miss Islington (bot)

commit sha 46e448abbf35c051e5306a4695670d7ec7abc4e9

bpo-38156: Fix compiler warning in PyOS_StdioReadline() (GH-21721) incr cannot be larger than INT_MAX: downcast to int explicitly. (cherry picked from commit bde48fd8110cc5f128d5db44810d17811e328a24) Co-authored-by: Victor Stinner <vstinner@python.org>

view details

Miss Islington (bot)

commit sha f0e030cacb940f061e0b09efbffc2fd984b95259

bpo-36346: Doc: Update removal schedule of legacy Unicode (GH-21479) See PEP 623 for detail. (cherry picked from commit 270b4ad4df795783d417ba15080da8f95e598689) Co-authored-by: Inada Naoki <songofacandy@gmail.com>

view details

push time in 14 days

push eventambv/cpython

Miss Islington (bot)

commit sha f599f9ea3cdcf280cdf3a72272148895d8fcb3a4

bpo-40741: Update Windows build to include SQLite 3.32.3 (GH-21570) (cherry picked from commit 84761c3cc4bac31d471e371c53a338686d4b0241) Co-authored-by: Steve Dower <steve.dower@python.org>

view details

push time in 14 days

push eventedgedb/edgedb-pkg

Łukasz Langa

commit sha f7cf908c15cfb23099925c8ec15f391785bf57f1

Adapt regular expressions to the new nightly version format

view details

Łukasz Langa

commit sha 69460292ae881207b1f2b1e6318f8768f814f0ae

Update generated files with the updated regular expressions

view details

push time in 17 days

Pull request review commentpython-attrs/attrs

WIP: Improve (de)serialization and validation capabilities

 Core  .. autodata:: attr.NOTHING -.. autofunction:: attr.s(these=None, repr_ns=None, repr=None, cmp=None, hash=None, init=None, slots=False, frozen=False, weakref_slot=True, str=False, auto_attribs=False, kw_only=False, cache_hash=False, auto_exc=False, eq=None, order=None, auto_detect=False, collect_by_mro=False, getstate_setstate=None, on_setattr=None)+.. autofunction:: attr.s(these=None, repr_ns=None, repr=None, cmp=None, hash=None, init=None, slots=False, frozen=False, weakref_slot=True, str=False, auto_attribs=False, kw_only=False, cache_hash=False, auto_exc=False, eq=None, order=None, auto_detect=False, collect_by_mro=False, getstate_setstate=None, on_setattr=None, transform_hook=None)

+1 to field_transformer

sscherfke

comment created time in 17 days

PullRequestReviewEvent

issue commentpsf/black

Non-prerelease black release

I also came here to offer some advice

Oh please. Your "advice" uses all caps, excessive numbers of exclamation marks and question marks, calls our struggle a joke, and is factually incorrect (the tool you're claiming is "good for every user" has 315 open issues at the time I'm writing this comment).

Quite a feat for such a short comment from an anonymous person who offered no help beyond unsolicited "advice". Continuing this conversation is in fact the opposite of help, escalating negative emotions and noise on an already busy issue tracker.

lig

comment created time in 19 days

issue commentpsf/black

Non-prerelease black release

PLEASE CAN YOU JUST RELEASE THE FLIPPING TOOL??!?

Did you expect this sort of message to be effective? You're a random anonymous stranger, coming to my issue tracker to yell at me because you don't like how a free tool's development is managed.

My advice, and this is coming straight from the heart, is: go away.

lig

comment created time in 19 days

push eventPyCQA/flake8-bugbear

Łukasz Langa

commit sha 55533c95c6f30d8f88db847fb3f01d7ddb57b280

Ignore exception classes which are not types Fixes #135

view details

push time in 20 days

issue closedPyCQA/flake8-bugbear

Traceback when trying to parse except handler with invalid exception type

I just ran into a problem where I made a typo and did:

try:
    # ...
except (MyException, NotImplemented):
    pass

As you can clearly see, it should be NotImplementedError but instead of telling me that, bugbear did traceback:

Traceback (most recent call last):
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/bin/flake8", line 8, in <module>
    sys.exit(main())
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/flake8/main/application.py", line 360, in run
    self._run(argv)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/flake8/main/application.py", line 348, in _run
    self.run_checks()
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/flake8/main/application.py", line 262, in run_checks
    self.file_checker_manager.run()
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/flake8/checker.py", line 334, in run
    self.run_serial()
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/flake8/checker.py", line 318, in run_serial
    checker.run_checks()
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/flake8/checker.py", line 505, in run_ast_checks
    for (line_number, offset, text, _) in runner:
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 36, in run
    visitor.visit(self.tree)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 156, in visit
    super().visit(node)
  File "/usr/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 371, in generic_visit
    self.visit(item)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 156, in visit
    super().visit(node)
  File "/usr/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 288, in visit_ClassDef
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 371, in generic_visit
    self.visit(item)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 156, in visit
    super().visit(node)
  File "/usr/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 278, in visit_AsyncFunctionDef
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 371, in generic_visit
    self.visit(item)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 156, in visit
    super().visit(node)
  File "/usr/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 269, in visit_For
    self.generic_visit(node)
 File "/usr/lib/python3.8/ast.py", line 371, in generic_visit
    self.visit(item)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 156, in visit
    super().visit(node)
  File "/usr/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 292, in visit_Try
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 371, in generic_visit
    self.visit(item)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 156, in visit
    super().visit(node)
  File "/usr/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/root/.cache/pre-commit/repo66mtzu3l/py_env-python3.8/lib/python3.8/site-packages/bugbear.py", line 185, in visit_ExceptHandler
    if issubclass(
TypeError: issubclass() arg 2 must be a class or tuple of classes

closed time in 20 days

wvffle

issue commentPyCQA/flake8-bugbear

Traceback when trying to parse except handler with invalid exception type

Good catch, we'll fix it.

wvffle

comment created time in 20 days

push eventpsf/black

Łukasz Langa

commit sha 6b935a34d08c0b18d858e7da5093dc69a29c55f2

Clarify current trailing comma behavior in the docs

view details

push time in 20 days

push eventpsf/black

Łukasz Langa

commit sha 1af648d0c14342021bb8c4220fb8adcd7362d45d

Mention optional invalid W503 warning in pycodestyle

view details

push time in 20 days

issue commentpsf/black

Left hand-side trailing comma shouldn't be treated as a magic trailing comma

In what situations does this line from the code style apply: "Unnecessary trailing commas are removed if an expression fits in one line."?

I guess you're right that this no longer applies. It hasn't since 19.10b0.

pfalcon

comment created time in 20 days

issue commentpsf/black

Left hand-side trailing comma shouldn't be treated as a magic trailing comma

@dtpc this is deliberate as you can read in my first comment on this very issue. It's documented as well: https://black.readthedocs.io/en/stable/the_black_code_style.html#the-magic-trailing-comma

pfalcon

comment created time in 20 days

Pull request review commentpython/cpython

bpo-39883: Use BSD0 license for code in docs

 make these releases possible. Terms and conditions for accessing or otherwise using Python ============================================================ +Python software and documentation are licensed under the+:ref:`PSF License Agreement <PSF-license>`.+Starting with Python X.X.X, examples, recipes, and other code in

(Both for this to land in 3.8.6rc1 as well as in 3.9.0rc2.)

toddrjen

comment created time in 21 days

PullRequestReviewEvent

Pull request review commentpython/cpython

bpo-39883: Use BSD0 license for code in docs

 make these releases possible. Terms and conditions for accessing or otherwise using Python ============================================================ +Python software and documentation are licensed under the+:ref:`PSF License Agreement <PSF-license>`.+Starting with Python X.X.X, examples, recipes, and other code in

@gvanrossum Perfectly reasonable.

toddrjen

comment created time in 21 days

PullRequestReviewEvent

push eventambv/aiotone

Łukasz Langa

commit sha 812b24639b69737f2b1a313307e1d602a67772ff

Add portamento support to mothergen The portamento is tied to the modwheel which is routed to the Red Mother. I have it patched out from its ASSIGN out and into VCF REZ for both Mothers. The result is quite pleasing, the modwheel becomes a sort of "ACID AMOUNT" macro.

view details

Łukasz Langa

commit sha 09c74df85d80ca78cf5f5cb1af0c7a288df9717d

Upgrade black

view details

Łukasz Langa

commit sha 3a332bf5287f5f1dd64a894b0a71dff9b156c82a

Add support for Subharmonicon

view details

push time in 22 days

issue commentpsf/black

Black removes newline from a multiline docstring.

@laloch In the mean time, a workaround for Black's behavior is starting your docstring text on a newline:

    def p_flow_stmt(self, p):
        """
        flow_stmt : break_stmt
                  | continue_stmt
                  | return_stmt
                  | raise_stmt
                  | yield_stmt
        """
        p[0] = p[1]
omry

comment created time in 23 days

issue commentpsf/black

New version removes blank in doctest, so all doctests fail.

Thanks for your report! I agree Black should do better here but bear in mind that your doctests are very brittle as is. If you tell your text editor (or .editorconfig) to automatically remove trailing spaces on save, the test will fail, too. I'd suggest using >>> repr(f(s)) instead of just >>> f(s) in your doctests. This way you're no longer relying on trailing invisible characters.

henrifroese

comment created time in 23 days

issue commentpsf/black

Black removes newline from a multiline docstring.

@laloch: I cannot reproduce this. Were the grammar rules using tab characters instead of spaces?

omry

comment created time in 23 days

issue commentpsf/black

Left hand-side trailing comma shouldn't be treated as a magic trailing comma

Thanks for your report. You are using pre-release software and the formatting will change between versions. That's why we insist on keeping the beta marker in the versions. Appealing to consistency with previous versions is therefore not actionable for us.

In general 19.10b0 had a feature (magic trailing commas) which was only partially functional. This changed with 20.8b0. In general this is a deliberate change. You did find a bug though: it now over-eagerly explodes also left-hand side trailing commas during tuple unpacking. We'll fix that.

Workaround for now: manually delete the unnecessary trailing comma on the left hand-side of the assignment and Black will do the right thing.

pfalcon

comment created time in 23 days

PR opened edgedb/edgedb-pkg

Make dev builds (like nightlies) their own slots

Changes the version slot from, say, edgedb-server-1-alpha6 to edgedb-server-1-alpha6-dev5034. The dev part is taken directly from the setuptools-scm version scheme, which is the number of commits on the branch. This should make the dev builds effectively monotonic, easy to parse to the human eye, and useful to say, for example: "yeah this EdgeQL syntax is only available since dev6123".

+13 -1

0 comment

1 changed file

pr created time in 24 days

create barnchedgedb/edgedb-pkg

branch : dev-build-slot

created branch time in 24 days

delete branch edgedb/edgedb-cli

delete branch : verbump

delete time in 24 days

push eventedgedb/edgedb-cli

Elvis Pranskevichus

commit sha 26547e8e93e1e39aadf0a07ae876448f28cdab9f

Bump version to 1.0.0-alpha.5 (#142)

view details

push time in 24 days

PR merged edgedb/edgedb-cli

Reviewers
Bump version to 1.0.0-alpha.5
+2 -2

0 comment

2 changed files

elprans

pr closed time in 24 days

push eventedgedb/edgedb-cli

Elvis Pranskevichus

commit sha d61a942433b8acdaffc1d4fdc5ebf7be51a14fe1

workflows: Publish the binary as a generic Docker layer (#130) This adds a step which publishes the static build as a docker image containing only itself, intended to be used as a layer in application images.

view details

push time in 24 days

delete branch edgedb/edgedb-cli

delete branch : docker

delete time in 24 days

PR merged edgedb/edgedb-cli

Reviewers
workflows: Publish the binary as a generic Docker layer

This adds a step which publishes the static build as a docker image containing only itself, intended to be used as a layer in application images.

+82 -88

0 comment

4 changed files

elprans

pr closed time in 24 days

issue commentpsf/black

INTERNAL ERROR: Black produced code that is not equivalent to the source.

This is #1632 and #1635, but with Black actually catching it as and AST discrepancy. Somehow the other examples don't.

mithrandi

comment created time in 25 days

issue closedpsf/black

Different style depending on trailing comma

Hi,

First I would say I really love black, it is an awesome project that I have being using for years now.

I get that the trailing comma is a long standing bug that is now fixed, but I am somewhat not happy with the fix. Black now does this :

  • [1,2,3] stay as is
  • but [1,2,3,] becomes
[
    1,
    2,
    3,
]

Previously the second example would have stay on one line.

This bothers me. A comma is not significant here, and as black removes useless parentheses or spaces, I would expect it removes the useless comma and keep my list on one line.

Now the style will be different if the dev added a useless comma or not.

More pernicious, look at this example :

  • step 1
a = [11111111111111111111111111, 22222222222222222222222222222, 33333333333333333333333, 444444444444444444444]
  • step 2: I run black on it
a = [
    11111111111111111111111111,
    22222222222222222222222222222,
    33333333333333333333333,
    444444444444444444444,
]
  • step 3: I changed my mind, let's remove those 3s and 4s
a = [
    11111111111111111111111111,
    22222222222222222222222222222,
]
  • step 4 : I run black, and … it does nothing

Actually to synthesize what bothers me is that black does nothing when I have this

a = [
    11111111111111111111111111,
    22222222222222222222222222222,
]

a = [11111111111111111111111111, 22222222222222222222222222222]

Those two lists are semantically identical, I would expect black to indent them the same way.

I get this is related to #826 and #1288, and this is a feature. But I don't really see the point. As black can add commas, I would expect it to remove commas to.

Thanks.

closed time in 25 days

erdnaxeli

issue commentpsf/black

Different style depending on trailing comma

This feature has been there since 19.10b0 and documented: https://black.readthedocs.io/en/stable/the_black_code_style.html#the-magic-trailing-comma

It just used to work rather unpredictably which was fixed by 20.8b0.

The rationale is to decrease diff size. If you want to prepare your code for a growing list, dictionary, etc., you use a trailing comma and it keeps the bracket pair exploded with one item per line.

erdnaxeli

comment created time in 25 days

issue closedpsf/black

Regression in 20.8b1: "skip-string-normalisation" is ignored for docstrings

Describe the bug

As of version 20.8b1, the "skip string normalisation" setting is ignored, but only for docstrings

To Reproduce Steps to reproduce the behavior:

Example code

class Hello:
    '''
    Wrong Strings
    '''


def foo():
    '''
    wrong-string
    '''
  1. Run Black on it with these arguments '....'
black --check --diff -S foo.py
  1. See error
--- foo.py      2020-08-27 06:15:44.100921 +0000
+++ foo.py      2020-08-27 06:16:07.598050 +0000
@@ -1,10 +1,10 @@
 class Hello:
-    '''
+    """
     Wrong Strings
-    '''
+    """


 def foo():
-    '''
+    """
     wrong-string
-    '''
+    """
would reformat foo.py
Oh no! 💥 💔 💥
1 file would be reformatted.

Expected behavior

While it is true that single-quoted strings violate PEP-8 via PEP-257 I would still prefer if that the behaviour of black would not change in that respect. In 19.10b0 it was still honouring the "skip-string-normalisation" setting, even for docstrings. This has now changed.

Environment (please complete the following information):

  • Version: 20.8b1
  • OS and Python version: Linux/Python 3.7.0

Does this bug also happen on master?

yes

Additional context

Our team has a fairly large number of Python projects. I just checked my own listing and I have over 170 projects myself, so I assume our team will have easily over 200 projects. Most small libraries, but some are fairly large code-bases. A lot of code conventions are historic and we're switching to black at the moment. The skip-string-normalisation was/is a big helping hand in that migration, as it would otherwise just simply cause too many diffs & thus conflicts.

This option allowed us to have a fairly painless migration to black as we were quite close to PEP-8 already. But the string-normalisation hamstringed us a bit. And now with 20.8b1 it's back. And this morning, coming to the office we were showered with CI-emails of our daily runs with pipeline failures 😦

closed time in 25 days

exhuma
more