profile
viewpoint

aloucks/directx_math 2

DirectXMath for Rust

aloucks/dacite 1

Mirror of https://gitlab.com/dennis-hamester/dacite

aloucks/ash 0

Vulkan bindings for Rust

aloucks/atom-build-cargo 0

Cargo task runner plugin for atom-build

aloucks/backtrace-rs 0

Backtraces in Rust

aloucks/borderless-window 0

A minimal borderless window with the Windows API

aloucks/bucket 0

AWS Bucket Synchronization Tool

aloucks/cargo 0

The Rust package manager

aloucks/cgmath 0

A linear algebra and mathematics library for computer graphics.

issue openedimage-rs/image

Inconsistency with DynamicImage conversion methods

The as methods (e.g. as_rgba8, as_luma16) all contain the component bit depth, while the into and to method do not. For example, there's no way to unwrap to Luma<u16> without a match statement.

I'd like to propose deprecating all of the current into and to methods in favor of adding new ones with the explicit bit depth (e.g. have both into_luma8 and into_luma16).

Finally, some signatures return type aliases where as others do not. I think the type aliases are less helpful than just showing that these all return ImageBuffer with with different pixel types.

I'd like to put in a PR for these changes but wanted to gather feedback first.

created time in 3 hours

starteddtolnay/semver-trick

started time in a day

issue commentrust-analyzer/rust-analyzer

Lambdas are rendering weird

I don't think comment scope is the right choice in either case.

kjeremy

comment created time in a day

issue commentrust-analyzer/rust-analyzer

Lambdas are rendering weird

I think it's the underscore that's causing the problem. I now see a similar issue too after the grammar update.

kjeremy

comment created time in a day

issue commentrust-analyzer/rust-analyzer

Error: Syntax Highlighing in strings after lines starting with '>' in VSCode is incorrect

It's not just strings. I see strange behavior as well with the new grammar. Disabling RA results in correct highlighting.

Everything after the _ is broken for many lines. It seems to think that the underscore means the next character should be "disabled".

let mut normal_image: image::ImageBuffer<image::Rgba<u8>, _> = image::ImageBuffer::from_raw(width, height, normal_buffer_data).unwrap();
h-bex

comment created time in a day

startedEmbarkStudios/rust-gpu

started time in 2 days

issue commentrust-analyzer/rust-analyzer

Latest nightly seems to ignore semantic highlighting settings

Could the new grammar be moved to a separate extension so that it can be iterated on independently?

aloucks

comment created time in 2 days

startedNominom/BCnEncoder.NET

started time in 6 days

issue commentglfw/glfw

Context without API

GLFW has helper functions for creating a vulkan surface: https://www.glfw.org/docs/latest/vulkan_guide.html#vulkan_surface

Or you can use the native functions to acquire raw window primitives and use the Vulkan API directly: https://www.glfw.org/docs/latest/group__native.html https://vulkan-tutorial.com/Drawing_a_triangle/Presentation/Window_surface

Haeri

comment created time in 6 days

startedsebastiencs/shared-arena

started time in 6 days

push eventaloucks/directx_math

Aaron Loucks

commit sha 90ef04c00ebc36099ddbd391987eb17c0b63b19e

Enable debug assertions in XMMatrixReflect and XMMatrixShadow

view details

Aaron Loucks

commit sha b4c5971fceb153f632edf981d1d624cdce9b8f71

Fix clippy warning with u32 to f32 conversion

view details

Aaron Loucks

commit sha 4733743d4b195ca5d7b654e154e0004b6913b258

Add #[inline] to collision functions

view details

push time in 7 days

create barnchaloucks/glfw-rs

branch : remove_winapi

created branch time in 7 days

startedGRASBOCK/makima_spline

started time in 7 days

push eventaloucks/vki

Aaron Loucks

commit sha 323c2fdd5b32e059ba8541cea2d0b92e53e51692

Don't use AllocatorCreateInfo::default()

view details

push time in 7 days

issue commentrust-analyzer/rust-analyzer

Latest nightly seems to ignore semantic highlighting settings

Try "editor.semanticHighlighting.enabled": false.

I've tried that but it has no effect :(

As mentioned above, this all worked as expected prior to today (2020-10-17).

aloucks

comment created time in 8 days

issue openedrust-analyzer/rust-analyzer

Latest nightly seems to ignore semantic highlighting settings

I have semantic highlight disabled via the configuration below. The latest nightly seems to ignore it now and always applies semantic highlighting. I've also tried to disable it via the global Editor -> Semantic Highlighting: Enabled setting.

Disabling of semantic highlighting worked as expected prior to rust-analyzer version: nightly (f0412da).

   "editor.semanticTokenColorCustomizations": {
        "[Atom One Dark]": {
            "enabled": false,
        }
    },

created time in 8 days

issue comment4bb4/implot-rs

drawing is broken when using special characters for axis labels

Did you verify that "€" is represented in the glyph ranges that you used and is it in your texture atlas?

benmkw

comment created time in 11 days

pull request commentgwihlidal/vk-mem-rs

Replace mem::zeroed() in AllocatorCreateInfo::default()

Hi @gwihlidal, would you be able to review? When the current Rust beta is promoted to stable, AllocatorCreateInfo::default() will always panic.

aloucks

comment created time in 13 days

issue openedrust-lang/rustfmt

Rustfmt 2.0: Consider making `newline_style` default to `Unix` on all platforms.

Carriage returns are a vestige of old versions of DOS and Windows and don't serve any practical purpose today. All modern editors support LF style newlines. The last holdout was notepad.exe which now supports LF style line endings in Windows 10.

created time in 14 days

issue commentrust-lang/rfcs

Consider switching to tab-based indenting in new Rust edition

I sympathize with the @clarfonthey's use case, but tabs in code are a never ending source of inconsistent rendering behavior. For example, C++ files sometimes render poorly in github due to the prevalence of tabs. I would hate to see Rust follow this route.

Are there any other options for folks using screen readers without regressing to using tabs?

clarfonthey

comment created time in 14 days

pull request commentgfx-rs/wgpu

Never prefer CPU devices over GPUs

@kvark What about removing the Default variant and not having an impl Default? This would make it explicit and deterministic.

Alternatively, an impl Default could check an environment variable such as WGPU_DEFAULT_POWER_PREFERENCE.

myfreeweb

comment created time in 14 days

pull request commentgfx-rs/wgpu

Never prefer CPU devices over GPUs

@kvark I understand that it can be set explicitly. I'm trying to understand the reasoning behind the behavior for Default. Why prefer integrated when a discrete GPU exists? Generally, the only time two or more adapters will be present is on desktop systems and desktops are not running on battery power.

If the author of the code specifies Default (as is in all the examples) and doesn't expose a way to change it at runtime, the end user gets stuck with using the "slow" GPU. I have the integrated intel GPU enabled for testing purposes but I don't want anything to select it by default.

myfreeweb

comment created time in 15 days

issue closedaloucks/imgui-glfw-support

Not working with the latest wgpu and imgui

Using the current versions the simple example doesn't work Wgpu changed some stuff and seems like imgui did as well

would be nice to update it

thank you

closed time in 15 days

varomix

issue commentaloucks/imgui-glfw-support

Not working with the latest wgpu and imgui

Version 0.4.0 has been published with support for the latest glfw and imgui crates and the examples now use the latest wgpu.

varomix

comment created time in 15 days

push eventaloucks/imgui-glfw-support

Aaron Loucks

commit sha 5e1ab8ab60e890e2f79fe9f56a18a104be5f0605

Version 0.4

view details

push time in 15 days

created tagaloucks/imgui-glfw-support

tagv0.4.0

GLFW support for imgui-rs

created time in 15 days

push eventaloucks/imgui-glfw-support

Aaron Loucks

commit sha 412ca4b49dd95add09d9fb46f79c7b6f299e92f9

Bump imgui to 0.5 and update examples

view details

push time in 15 days

push eventaloucks/imgui-glfw-support

Aaron Loucks

commit sha a2cf2c72ba7fc281acce6f81304df3d4132d0aca

Update GLFW to 0.40

view details

Aaron Loucks

commit sha 90c96fcd624eccb6f1c766b8785c33a885293c07

Bump imgui to 0.5 and update examples

view details

push time in 15 days

pull request commentPistonDevelopers/glfw-rs

Make features to all to make rust-analyzer happy.

You can set the features in Rust Analyzer. Look for the "Cargo: All Features" or "Cargo: Features" settings.

Making all a default will add extra default dependencies that are often not used. I don't think that's the right choice in this case.

One option to improve the situation might be declare the examples explicitly in Cargo.toml and add the required-features option to each one as needed.

uhuntu

comment created time in 15 days

pull request commentgfx-rs/wgpu

Never prefer CPU devices over GPUs

Yes, please! It's very odd that the Default power preference selects my integrated GPU over the discrete one. Chrome, Firefox, and every game I've played always prefer the discrete.

This was fixed in #446, however @kvark suggested checking for a battery and selecting the GPU based on that. The power detection code was later removed. I don't really understand the reasoning behind the current logic. As far as I know mobile and laptops don't really have multiple GPUs. Preferring an integrated GPU over discrete is generally only relevant on desktop and arguably the discrete GPU is always want the end user wants.

myfreeweb

comment created time in 15 days

issue commentbevyengine/bevy

Change default vertex layout to seperate buffers

Something also to consider is that WGPU has limits to the max number of vertex buffers that can be bound. Interleaving is one way to work around that limitation. Ideally the vertex format would be fully customizable as there are use cases for both separate and interleaved.

See also: https://github.com/gpuweb/gpuweb/issues/693 https://github.com/gfx-rs/wgpu/issues/558

julhe

comment created time in 18 days

startedTezza48/Bevy-WoW

started time in 21 days

push eventaloucks/dawn

Bryan Bernhart

commit sha 1f16229c9be9f220e991f1ce9d94d6b72d79c285

Disable MultisampledRenderingTests on NV/D3D12. E2E tests fail to pass with backend validation. Disable these tests until there is resolution from the investigation. BUG=dawn:462 Change-Id: I0325bafb31cc706be122a601ecfe154bf8880b5b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25680 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>

view details

Austin Eng

commit sha 361a0d8334c846bb2b3f6b38cb556f3cf6be6cd6

Update max storage buffer bindings per stage to 6 This is a temporary change to unblock Tensorflow.js until we expose querying and setting GPULimits. Bug: none Change-Id: Iad851b2be260e9fade7c326bc7fcde39b46cf7fd Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25840 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>

view details

Jiawei Shao

commit sha c11a19145f1f5a8846d0123e22c261966949466c

Support buffer lazy initialization before CopyTextureToBuffer BUG=dawn:414 TEST=dawn_end2end_tests Change-Id: I5bdd6333029170d47ea240388e7b7d80750ae5d9 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25643 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

view details

Corentin Wallez

commit sha 5b007a519a28b4638ef58e6781c5fdf34c49e6e7

dawn_wire: Implement MapRead/WriteAsync on top of MapAsync This inverts the shimming to have the old mapping entrypoints be implemented on top of the new mapping entrypoint. Bug: dawn:445 Change-Id: I98c81b2873d506790b1b19048c5289c62d1b83ae Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25700 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>

view details

Tomek Ponitka

commit sha b7ce8970d2e95cd4d916e95d2a786a742300620b

Rolling shader deps Roll third_party/glslang/ 9eef54b25..3ee5f2f1d (11 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9eef54b2513c..3ee5f2f1d331 $ git log 9eef54b25..3ee5f2f1d --date=short --no-merges --format='%ad %ae %s' 2020-07-22 greg Update spirv-tools known-good to most recent stable 2020-07-19 vkushwaha Add changes for SPV_EXT_shader_atomic_float_add 2020-07-14 bclayton Limit visibility of symbols for internal libraries 2020-07-20 john SPV: Update to the latest SPIR-V headers. 2020-07-14 bclayton Deprecate InitializeDll functions 2020-07-14 bclayton Simplify PoolAlloc with use of thread_local. 2020-07-14 malcolm also search global variables assignment for live variables 2020-07-20 bclayton Drop support for VS2013 2020-07-20 bclayton Start glslang 11.0.0 2020-07-20 bclayton Finalize glslang 10.15.3847 2020-07-20 bclayton build_info: Fix parsing of versions with no flavor Created with: roll-dep third_party/glslang Roll third_party/shaderc/ 6af6e6255..cfacaaffd (10 commits; 1 trivial rolls) https://chromium.googlesource.com/external/github.com/google/shaderc/+log/6af6e625573f..cfacaaffd1fe $ git log 6af6e6255..cfacaaffd --date=short --no-merges --format='%ad %ae %s' 2020-07-28 tommek Adding support for the additional fixed sample mask in MSL (#1120) 2020-07-27 rharrison Rolling 2 dependencies and updating expectations (#1121) 2020-07-14 rharrison Clean up issues discovered by Infer 2020-07-23 dneto Start shaderc v2020.3 development 2020-07-23 dneto Finalize shaderc v2020.2 2020-07-23 dneto Update CHANGES 2020-07-23 dneto Use the non-posix MinGW compiler as fallback (#1117) 2020-07-22 dneto glslc: Add -mfmt=wgsl output format option (#1110) 2020-07-20 rharrison Roll 5 dependencies and update expectations (#1111) Created with: roll-dep third_party/shaderc Roll third_party/spirv-cross/ 6575e451f..0376576d2 (5 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross/+log/6575e451f5bf..0376576d2dc0 $ git log 6575e451f..0376576d2 --date=short --no-merges --format='%ad %ae %s' 2020-07-22 tommek Enabling setting a fixed sampleMask in Metal fragment shaders. 2020-02-20 cdavis MSL: Add support for processing more than one patch per workgroup. 2020-07-22 dsinclair Roll GLSLang, SPIRV-Headers and SPIRV-Tools. 2020-07-22 cdavis MSL: Factor creating a uint type into its own method. 2020-07-22 cdavis MSL: Factor a really gnarly condition into its own method. Created with: roll-dep third_party/spirv-cross Roll third_party/spirv-headers/ 7f2ae1193..979924c8b (1 commit) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/7f2ae1193ad8..979924c8bc83 $ git log 7f2ae1193..979924c8b --date=short --no-merges --format='%ad %ae %s' 2020-07-21 alanbaker Support SPV_KHR_terminate_invocation (#163) Created with: roll-dep third_party/spirv-headers Roll third_party/SPIRV-Tools/ c10d6cebb..150be20d4 (34 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/c10d6cebbcb7..150be20d4334 $ git log c10d6cebb..150be20d4 --date=short --no-merges --format='%ad %ae %s' 2020-07-27 andreperezmaselco.developer spirv-fuzz: Add condition to make functions livesafe (#3587) 2020-07-27 rharrison Rolling 4 dependencies (#3601) 2020-07-27 andreperezmaselco.developer spirv-fuzz: Implement the OpTranspose linear algebra case (#3589) 2020-07-27 rdb Fix SyntaxWarning in Python 3.8 (#3388) 2020-07-27 bclayton CMake: Enable building with BUILD_SHARED_LIBS=1 (#3490) 2020-07-27 dneto Avoid operand type range checks (#3379) 2020-07-27 jaebaek Preserve debug info in scalar replacement pass (#3461) 2020-07-27 pierremoreau Update OpenCL capabilities validation (#3149) 2020-07-27 stevenperron build(deps): bump lodash from 4.17.15 to 4.17.19 in /tools/sva (#3596) 2020-07-27 antonikarp spirv-fuzz: adds TransformationReplaceLoadStoreWithCopyMemory (#3586) 2020-07-27 jaebaek Preserve OpenCL.DebugInfo.100 through private-to-local pass (#3571) 2020-07-27 stefanomil spirv-fuzz: Relax type checking for int contants (#3573) 2020-07-27 stefanomil spirv-fuzz: Generalise transformation access chain (#3546) 2020-07-27 stefanomil spirv-fuzz: Split blocks starting with OpPhi before trying to outline (#3581) 2020-07-27 afdx spirv-fuzz: Set message consumer in replayer when shrinking (#3591) 2020-07-24 vasniktel spirv-fuzz: Don't use default parameters (#3583) 2020-07-23 rharrison Change DEPS rolling script to point at external/ (#3584) 2020-07-23 vasniktel spirv-fuzz: Create a helper in fuzzerutil to reuse function type (#3572) 2020-07-23 vasniktel spirv-fuzz: Test usages of IdIsIrrelevant fact (#3578) 2020-07-23 antonikarp spirv-fuzz: adds TransformationReplaceCopyMemoryWithLoadStore (#3575) 2020-07-23 antonikarp spirv-fuzz: adds TransformationReplaceCopyObjectWithStoreLoad (#3567) 2020-07-22 stevenperron Start SPIRV-Tools v2020.5 2020-07-22 stevenperron Finalize SPIRV-Tools v2020.4 2020-07-22 vasniktel spirv-fuzz: Fix usages of irrelevant constants (#3566) 2020-07-22 stevenperron Update CHANGES 2020-07-22 alanbaker Support SPV_KHR_terminate_invocation (#3568) 2020-07-22 stevenperron Sink pointer instructions in merge return (#3569) 2020-07-21 greg Preserve OpenCL.DebugInfo.100 through elim-dead-code-aggressive (#3542) 2020-07-21 vasniktel spirv-fuzz: TransformationReplaceParamsWithStruct (#3455) 2020-07-21 38144211+vkushwaha-nv Add changes for SPV_EXT_shader_atomic_float (#3562) 2020-07-21 vasniktel spirv-fuzz: Use irrelevant constants (#3565) 2020-07-21 stefanomil spirv-fuzz: Extend TransformationRecordSynonymousConstants to allow composite constants (#3537) 2020-07-21 vasniktel spirv-fuzz: Add is_irrelevant parameter (#3563) 2020-07-20 vasniktel spirv-fuzz: Add IdIsIrrelevant fact (#3561) Created with: roll-dep third_party/SPIRV-Tools Roll third_party/tint/ 18c85f52e..e8c12f32f (53 commits) https://dawn.googlesource.com/tint/+log/18c85f52e482..e8c12f32f9a9 $ git log 18c85f52e..e8c12f32f --date=short --no-merges --format='%ad %ae %s' 2020-07-27 dsinclair Remove StatementList. 2020-07-27 dsinclair [spirv-reader] Update to create BlockStatements 2020-07-27 dsinclair [wgsl-reader] Update to create BlockStatements 2020-07-27 dsinclair Convert LoopStatement to use BlockStatement. 2020-07-27 dsinclair Convert IfStatement and ElseStatement to use BlockStatement. 2020-07-27 dsinclair Convert CaseStatement to use BlockStatement. 2020-07-27 dsinclair Convert Function to use BlockStatement. 2020-07-27 dsinclair [spirv-writer] Add BlockStatement emission. 2020-07-27 dsinclair [msl-writer] Emit BlockStatement. 2020-07-27 dsinclair [wgsl-writer] Add emission of BlockStatement. 2020-07-27 dsinclair [ast] Add BlockStatement 2020-07-25 dsinclair [msl-writer] Emit intrinsics. 2020-07-25 dsinclair Remove KillStatement 2020-07-25 dsinclair [spirv-reader] Convert from KillStatement to DiscardStatement 2020-07-25 dsinclair [wgsl-reader] Add `discard` parsing. 2020-07-25 dsinclair [wgsl-writer] Add DiscardStatement support 2020-07-25 dsinclair [msl-writer] Emit DiscardStatement. 2020-07-25 dsinclair [spirv-writer] Add DiscardStatement support. 2020-07-25 dsinclair [ast] Add DiscardStatement AST node. 2020-07-24 sarahmashay [validation] Add a disabled test for re-assigning a constant. 2020-07-24 dsinclair Fixup some doc and compile issues. 2020-07-23 sarahmashay [validation] implement invalidate assignment to a different type. 2020-07-23 dsinclair Handle review feedback. 2020-07-23 dsinclair Add simple test runner. 2020-07-22 rharrison Fix BUILD.gn builds 2020-07-22 dsinclair [msl-writer] Only emit in/out structs if function call requires. 2020-07-22 rharrison Add usage of main from chromium when part of a chromium build 2020-07-22 dsinclair Add return to simple test 2020-07-22 sarahmashay [validation] Add a disabled test for assignment statement. 2020-07-22 dneto [spirv-reader] Support OpAny, OpAll, OpIsInf, OpIsNan 2020-07-21 dsinclair [spirv-writer] Emit select intrinsic. 2020-07-21 dsinclair Add type determination for the select intrinsic. 2020-07-21 dneto [spirv-reader] Add README.md 2020-07-21 dneto [spirv-reader] Support function call returning void 2020-07-21 dj2 [hlsl-writer] Add assignment statement. 2020-07-21 dj2 [hlsl-writer] Add switch statement support 2020-07-21 dj2 [hlsl-writer] Emit case statements. 2020-07-21 dj2 [hlsl-writer] Emit unary operators. 2020-07-21 dj2 [hlsl-writer] Emit break, return and continue. 2020-07-21 dsinclair [hlsl-writer] Add binary operator emission. 2020-07-21 dsinclair Parse void function call. 2020-07-21 dsinclair [hlsl-writer] Add emission of identifiers 2020-07-21 dj2 Emit call statements from the various backends. 2020-07-21 dj2 Type determine the call statement. 2020-07-21 dj2 Add a call ast statement. 2020-07-21 dneto [spirv-reader] Support select over scalars and vectors 2020-07-20 dneto Add missing Doxygen comments on two methods. 2020-07-20 dneto [spirv-reader] Support function calls, except returning void 2020-07-20 dsinclair [hlsl-writer] Scaffold the HLSL backend. 2020-07-20 dsinclair [msl-writer] Emit storage buffers. 2020-07-20 dsinclair [msl-writer] Add import emission. 2020-07-20 dneto [spirv-reader] Drop NonWritable NonReadable for now 2020-07-20 rharrison Fix issues with BUILD.gn Created with: roll-dep third_party/tint Change-Id: Ica53a9561d8161667b3d9ca013aa8b0bdf6afc96 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25880 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Tomek Ponitka <tommek@google.com>

view details

Corentin Wallez

commit sha 0811ecc7756f8913fdaf9c9bf589b8e498badd17

dawn_wire: Implement CreateBufferMapped on top of mappedAtCreation This inverts the shimming to have the old mapping at creation method be implemented on top of the new method.. Also updates Wire tests to use mappedAtCreation instead of CreateBufferMapped. Bug: dawn:445 Change-Id: I77dcfe72040e5bf187c41fe99c8dd785d5156a07 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25701 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>

view details

Kai Ninomiya

commit sha a390d7f84f69bd50f1dba5e9ccb1c67e1fbfb15a

Disable "all" warnings when compiling MSL code Hopefully works around an issue where some Metal drivers treat warnings as errors. Bug: dawn:493 Change-Id: Ia535502a14fd4215ff74eee2662dfbde7e01bc4b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25841 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>

view details

Ryan Harrison

commit sha c4c4ff9eb4b51ec22f8608e7f2ef8028ad57f367

Enable WGSL support by default Explictly turned off for Skia, since it does not yet have Tint in its DEPS. Roll third_party/tint/ e8c12f32f..c5cd8f5bd (3 commits) https://dawn.googlesource.com/tint/+log/e8c12f32f9a9..c5cd8f5bd382 $ git log e8c12f32f..c5cd8f5bd --date=short --no-merges --format='%ad %ae %s' 2020-07-28 rharrison Remove binutils from DEPS and pull in changes to build.gni from Dawn 2020-07-28 rharrison Get 'gn gen --check' passing 2020-07-28 idanr Fix Tint ninja build Created with: roll-dep third_party/tint BUG=tint:123 Change-Id: Icd26c2d1b7329c94afa6f23c5c057de8efaee3e8 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25523 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>

view details

Kai Ninomiya

commit sha bce1cbd0e25689a2f3ccb0aff08f8ef1c5eb5dc6

CMake: add -framework Metal to dawn_native Bug: None Change-Id: Ic71747e48e3d1a737f73bac37cced760af4f195d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25940 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>

view details

Tomek Ponitka

commit sha 225a2b46b0f27376b537fc3c4eb68ae44b713a5e

Enabling sampleMask usage in RenderPipelineMTL Added the sampleMask functionality in Metal. Bug: dawn:491 Change-Id: Id4a14d0cc715dc701c6f29e4588ce327c5b26cba Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25481 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Tomek Ponitka <tommek@google.com>

view details

Corentin Wallez

commit sha b88b1a15c7e4cde561cd7e69be452c1be68467e6

Revert "dawn_wire: Implement CreateBufferMapped on top of mappedAtCreation" This reverts commit 0811ecc7756f8913fdaf9c9bf589b8e498badd17. Reason for revert: Makes the Dawn roll fail. Original change's description: > dawn_wire: Implement CreateBufferMapped on top of mappedAtCreation > > This inverts the shimming to have the old mapping at creation method > be implemented on top of the new method.. > > Also updates Wire tests to use mappedAtCreation instead of > CreateBufferMapped. > > Bug: dawn:445 > > Change-Id: I77dcfe72040e5bf187c41fe99c8dd785d5156a07 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25701 > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Austin Eng <enga@chromium.org> TBR=cwallez@chromium.org,senorblanco@chromium.org,enga@chromium.org Change-Id: Ied940d505fdf576860697dee8df2548c73581eba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:445 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25980 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>

view details

Corentin Wallez

commit sha 9d0b9d721211287773f16526b7a71b161317451d

D3D12Info: programmatically compute the shader profiles. Bug: dawn:426 Change-Id: Ic360b95e908404137e01a00439b93e5b9b1828ce Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24380 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>

view details

Tomek Ponitka

commit sha 9ecb99344fc1bd25218ca20f04027a093aac074e

Roll third_party/spirv-cross/ to enable shader-output mask in HLSL https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross/+log/0376576d2dc0..f5e9f4a1722e $ git log 0376576d2..f5e9f4a17 --date=short --no-merges --format='%ad %ae %s' 2020-07-23 tommek Adding BuiltInSampleMask in HLSL Created with: roll-dep third_party/spirv-cross Change-Id: I1a9702ce1da046e7c987deaa1994de019d570fb3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25900 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Tomek Ponitka <tommek@google.com>

view details

Tomek Ponitka

commit sha ab04da48f45db878e8e160c12d514acc37411606

Enabling alphaToCoverage Added the alphaToCoverage functionality with some end2end tests. There is no validation for disabling alphaToCoverage mode if SV_Coverage is statically used by the shader yet. Bug: dawn:494 Change-Id: I9df15b35697ea05a064b092edae9d5d20f73c4d8 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25761 Commit-Queue: Tomek Ponitka <tommek@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>

view details

Corentin Wallez

commit sha f93fa6acd96d77df9ef48f8f5ff78ea72cebf5ae

dawn_wire: Implement CreateBufferMapped on top of mappedAtCreation Reland with a fix for narrowing of uint64_t to size_t of the buffer size in 32 bit mode. This inverts the shimming to have the old mapping at creation method be implemented on top of the new method.. Also updates Wire tests to use mappedAtCreation instead of CreateBufferMapped. TBR=senorblanco@chromium.org Bug: dawn:445 Change-Id: I89fe84b6e0b5d0d4a5c6a2db7b38cb7d6cd063f0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25981 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>

view details

Tomek Ponitka

commit sha 2c8e1f2f11fa2b294337285cadc835f3f3125d8e

Optimizing memcpy inside Queue::WriteTexture Fixing an earlier TODO. Bug: dawn:483 Change-Id: I19d961512caea1f9d502d7e58b56cd3846c9f7f3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25983 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Tomek Ponitka <tommek@google.com>

view details

Bryan Bernhart

commit sha 03cf7c3eaeaf79325e23937aa7a3069e148fe2aa

Enable GBV by default for correctness tests. Dawn apps using debug builds may hang due to GBV being always on by default. This change turns on GBV for correctness tests only. BUG=dawn:490 Change-Id: I2728d834ed53f9acc7556f8d1178d718c0b49457 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25421 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>

view details

Jiawei Shao

commit sha a36a91a4450cd23f1128f6a7353a389af52cc4e0

Support lazy initialization on the buffers bound into a bind group BUG=dawn:414 Change-Id: Ice592d6427747941406431709999d08778f0f221 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/25861 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

view details

Kai Ninomiya

commit sha 38ba51ce7ad82a4b4935ca5e71ea1570e2dd9ca3

Make shim headers at <webgpu/*> that point to <dawn/*> Emscripten's headers live at <webgpu/*>; this makes it so projects don't have to ifdef which #include path to use. Bug: dawn:160 Change-Id: I39efee44447470551a78db0abd062f4a2fe9083a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26020 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>

view details

Austin Eng

commit sha b8a56af1767c3197eafc967cd2169f41acb4f625

Rephrase Format::aspect enum as an enum class mask Format::aspect should be a mask so that it is easier to iterate over and test if an aspect is present. This CL also re-exports wgpu's EnumClassBitMask helpers in dawn_native. It also adds an EnumMaskIterator which wraps BitSetIterator to allow iterating over the enums in an enum mask. Bug: dawn:439 Change-Id: I08180a45b27c6031e2f80b0fa1801716677fd813 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24682 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> Commit-Queue: Austin Eng <enga@chromium.org>

view details

push time in 21 days

issue commentrust-lang/rust

std::mem::zeroed() panics on nightly with ash::Device, but not on stable

@jyn514 It contains function pointers. I suspected the same, but wanted to confirm and report anyway as it will cause a breaking change when it reaches the stable channel.

aloucks

comment created time in 22 days

issue openedrust-lang/rust

std::mem::zeroed() panics on nightly with ash::Device, but not on stable

As stated in the title, the behavior of mem::zeroed() seems to have changed on the nightly channel and now panics when called with ash::Device as the type parameter. This causing vk_mem::AllocatorCreateInfo::default() to panic in the vk_mem crate.

[dependencies]
ash = "0.31"
#[test]
fn zeroed() {
    let _device = unsafe { std::mem::zeroed::<ash::Device>() }; 
}

The last nightly to behave the same as stable

info: latest update on 2020-09-27, rust version 1.48.0-nightly (623fb90b5 2020-09-26)
$ cargo +nightly-2020-09-27 test
...
running 1 test
test zeroed ... ok

And started failing with

info: latest update on 2020-09-28, rust version 1.48.0-nightly (7f7a1cbfd 2020-09-27)
$ cargo +nightly-2020-09-28 test
...
running 1 test
test zeroed ... FAILED

failures:

---- zeroed stdout ----
thread 'zeroed' panicked at 'attempted to zero-initialize type `ash::Device`, which is invalid', /rustc/7f7a1cbfd3b55daee191247770627afab09eece2\library\core\src\mem\mod.rs:622:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

created time in 22 days

release aloucks/vulkan-ci

v1

released time in 23 days

created tagaloucks/vulkan-ci

tagv1

created time in 23 days

delete tag aloucks/vulkan-ci

delete tag : v1

delete time in 23 days

created tagaloucks/vulkan-ci

tagv1.0.1

created time in 23 days

push eventaloucks/vulkan-ci

Aaron Loucks

commit sha 5f27e734250a9cbf1efc54c270199d93cf67c0c3

Update bl

view details

push time in 23 days

created tagaloucks/vulkan-ci

tagv1.0.0

created time in 23 days

push eventaloucks/vulkan-ci

Aaron Loucks

commit sha 5f27e734250a9cbf1efc54c270199d93cf67c0c3

Update bl

view details

push time in 23 days

create barnchaloucks/vulkan-ci

branch : update-bl

created branch time in 23 days

push eventaloucks/vulkan-ci

Aaron Loucks

commit sha 85d7c27fd3e8f8710f179840b0a5fb471e8775b6

Update node_modules

view details

push time in 23 days

push eventaloucks/vulkan-ci

dependabot[bot]

commit sha 4623bdb928139a9cdd8dddd63715f3bc07c286c6

Bump @actions/core from 1.2.5 to 1.2.6 Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) Signed-off-by: dependabot[bot] <support@github.com>

view details

aloucks

commit sha 20431e78262b1f9c6de698cafcfef5318f61beff

Merge pull request #1 from aloucks/dependabot/npm_and_yarn/actions/core-1.2.6 Bump @actions/core from 1.2.5 to 1.2.6

view details

push time in 23 days

PR merged aloucks/vulkan-ci

Bump @actions/core from 1.2.5 to 1.2.6 dependencies

Bumps @actions/core from 1.2.5 to 1.2.6. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md">@actions/core's changelog</a>.</em></p> <blockquote> <h3>1.2.6</h3> <ul> <li><a href="https://github-redirect.dependabot.com/actions/toolkit/pull/571">Update <code>exportVariable</code> and <code>addPath</code> to use environment files</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/actions/toolkit/commits/HEAD/packages/core">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+4 -4

0 comment

2 changed files

dependabot[bot]

pr closed time in 23 days

push eventaloucks/vk-mem-rs

Aaron Loucks

commit sha d847979ff17c218e66f1c84ee5f5b3daf9438c6e

Cargo fmt

view details

push time in 24 days

PR opened gwihlidal/vk-mem-rs

Replace mem::zeroed() in AllocatorCreateInfo::default()

Fixes an issue where Rust nightly panics with "panicked at 'attempted to zero-initialize type ash::Device, which is invalid".

+27 -4

0 comment

2 changed files

pr created time in 24 days

create barnchaloucks/vk-mem-rs

branch : issue-19

created branch time in 24 days

startedGrokmoo/thyme

started time in 25 days

startedblushft/go-diagrams

started time in a month

startedmozilla/rr

started time in a month

issue commenttokio-rs/rdbc

Replace trait objects with generics

Another approach would be to follow what futures did with the Waker and have the concept of a RawConnection that is constructed from a RawConnectionVTable. The same treatment could be applied to Statement, ResultSet, etc.. This should also eliminate the need to box all of the return types.

For reference: https://doc.rust-lang.org/beta/std/task/struct.RawWaker.html

mversic

comment created time in a month

issue commentRustCrypto/RSA

Easy to Misuse API For PEM Encoding ( On Master )

What benefit to these traits provide over just having the methods on the RSAPrivateKey and RSAPublicKey structs?

zicklag

comment created time in a month

startedLukasKalbertodt/bunt

started time in a month

startedjonasrmichel/rudiments

started time in a month

issue commentbitshifter/glam-rs

Unnecessary handedness in rotation explanation

For what it's worth, I found the documentation helpful and hope that it's not removed. Wouldn't the angles need to be negated if the rotations were following the right-hand rule?

emilk

comment created time in a month

startedrust-lang/rustc-perf

started time in 2 months

Pull request review commentbevyengine/bevy

Low power default option [#366]

 pub struct WgpuRenderer { impl WgpuRenderer {     pub async fn new() -> Self {         let instance = wgpu::Instance::new(wgpu::BackendBit::PRIMARY);+    +        #[cfg(feature = "low_power")]+        let power_preference = wgpu::PowerPreference::Default;

If you want to switch to the more powerful GPU when main power is connected (which is what PowerPreference::Default does)

I don't think this is true any longer. The power module was removed. I believe PowerPreference::Default now always prefers an integrated GPU over discrete when both are available. This behavior is odd as nearly every other software behaves in the opposite way.

lee-orr

comment created time in 2 months

PullRequestReviewEvent

push eventaloucks/directx_math

Aaron Loucks

commit sha a71960842811e7634d488a535f392404904bb26c

Move docs helper to workspace member

view details

push time in 2 months

created tagaloucks/directx_math

tagv0.2.0

DirectXMath for Rust

created time in 2 months

push eventaloucks/directx_math

Aaron Loucks

commit sha 8bc820cba6adea76e18f631c9f46f2285b4233b6

Version 0.2.0

view details

push time in 2 months

push eventaloucks/directx_math

Aaron Loucks

commit sha 6d12ac21d148ad9c6d8b6545f541ce3053d0d5d4

Add flag in BoundingFrustum::CreateFromMatrix to allow for right-hand coordinate system

view details

push time in 2 months

push eventaloucks/vulkan-ci

Aaron Loucks

commit sha b66e0b482d57d04e999accc710de0a2f65fc2824

Update dependencies

view details

push time in 2 months

startedmooman219/fontdue

started time in 2 months

push eventaloucks/directx_math

Aaron Loucks

commit sha 97ecb56c729ede07d1ae8d41ba6bf0c79832866b

Add half-precision conversion functions to cconversion module

view details

push time in 2 months

push eventaloucks/directx_math

Aaron Loucks

commit sha cb0057cbeea5eb11f9f7344d116a625e6773562d

Enable nightly feature(stdsimd) for F16C

view details

push time in 2 months

issue commentrust-lang/rust

Tracking issue for stable SIMD in Rust

Are the half-precision x86/64 functions intended to remain unstable? The stable compiler errors and the documentation points to this issue, but it was closed quite a while ago along with the stabilization PR.

alexcrichton

comment created time in 2 months

push eventaloucks/directx_math

Aaron Loucks

commit sha be01eefa3f9fa7ab542704fe5025ae33b1dd8af1

Add half precision floating point conversion functions

view details

push time in 2 months

issue commentTomGillen/legion

Fix semver releasing

This would certainly be helpful, but technically, the semver specification does explicitly state that breaking changes may be introduced at any point under major version 0. Maybe cargo update is the problem here.

The entirety of the crates ecosystem increments the minor version for breaking changes when the major version is 0.

almindor

comment created time in 2 months

issue commentgltf-rs/gltf

byte_offset and extras of gltf-json::accessor::Accessor should be Option type

I think it would be better to use the serde(skip_serializing) attribute instead.

J-F-Liu

comment created time in 2 months

PR opened rust-lang/rustup

Disable broken color in MSYS2 shells.

Color codes in MSYS shells are currently broken, making the output hard to read. This PR disables color in those shells until a better solution can be found (i.e. migrating to termcolor).

Related: #2292

+5 -2

0 comment

1 changed file

pr created time in 2 months

push eventaloucks/rustup

Aaron Loucks

commit sha 557e2df3e4d276a42b8e8860bd28f85986ce6090

Disable broken color in MSYS2 shells.

view details

push time in 2 months

create barnchaloucks/rustup

branch : msys-disable-color

created branch time in 2 months

fork aloucks/rustup

The Rust toolchain installer

fork in 2 months

issue commentrust-lang/rustup

Colors are broken on Windows + VSCode terminal + MSYS2 shell.

Color is broken in all MSYS terminals, not just when using VSCode.

jamen

comment created time in 2 months

startedbevyengine/bevy

started time in 2 months

issue commentbitshifter/glam-rs

Should Vec4 truncate return Vec3 instead of Vec3A

What about renaming Vec3A back to Vec3 and creating an unaligned module for non-simd types. Everything would then use Vec3 by default and unaligned::Vec3 would be for data load/store (i.e. there would be convenient conversion functions)?

bitshifter

comment created time in 2 months

startedbdbai/firstuwp-rs

started time in 2 months

issue commentrust-lang/rustup

Shift away from `term` crate

What was the issue with termcolor? Isn't that what cargo uses?

kinnison

comment created time in 2 months

startedwoodruffw/steg86

started time in 2 months

push eventaloucks/vki

Aaron Loucks

commit sha 9d08a7731a47897bb3d4b12cab88c4a31cba2295

Remove old actions/cache config

view details

Aaron Loucks

commit sha b161b6876138529035667118661c00ec9a67d977

Disable cached builds on macOS

view details

push time in 2 months

push eventaloucks/vki

Aaron Loucks

commit sha a12eb87fb6bfd5aa218c242904d6399516943167

Check if cargo_incremental fixes cached builds on macos ci

view details

push time in 2 months

Pull request review commentrustgd/cgmath

Add Transform::{look_at_rh, look_at_lh} and deprecate look_at (continued)

 impl<S: BaseFloat> From<Quaternion<S>> for Basis3<S> {  impl<S: BaseFloat> Rotation<Point3<S>> for Quaternion<S> {     #[inline]-    fn look_at(dir: Vector3<S>, up: Vector3<S>) -> Quaternion<S> {

I guess my thinking is that it needs the handedness for it to be consistent and I don't think the implementations are consistent right now (i.e. they're not all LH or all RH and some of the implementations are on the raw structs instead of the traits).

What I think needs to happen is that someone needs to go through the remaining look_ function and determine if it's currently lh or rh and deprecate it in favor of an explicitly named version of that function. While checking these, the corresponding missing lh or rh version can also be added. I think you've done this for Matrix3, but the other ones are missing the handedness suffix. I skipped over the ones I wasn't sure of rather than just renaming them to look_to (without the suffix) because they'll just need to be renamed again.

I was also thinking that it doesn't really make sense to have look_at_ variants for structures that can only represent rotation. I think these should only have look_to_ functions. We should probably sort out these kinds of questions before considering the removal of Rotation.

elrnv

comment created time in 2 months

Pull request review commentrustgd/cgmath

Add Transform::{look_at_rh, look_at_lh} and deprecate look_at (continued)

 impl<S> Matrix2<S> { impl<S: BaseFloat> Matrix2<S> {     /// Create a transformation matrix that will cause `unit_x()` to point at     /// `dir`. `unit_y()` will be perpendicular to `dir`, and the closest to `up`.+    #[deprecated = "Use Matrix2::look_to"]     pub fn look_at(dir: Vector2<S>, up: Vector2<S>) -> Matrix2<S> {-        Matrix2::look_at_stable(dir, up.x * dir.y >= up.y * dir.x)+        Matrix2::look_to(dir, up)     }      /// Crate a transformation that will cause `unit_x()` to point at-    /// `dir`. This is similar to `look_at`, but does not take an `up` vector.+    /// `dir`. This is similar to `look_to`, but does not take an `up` vector.     /// This will not cause `unit_y()` to flip when `dir` crosses over the `up` vector.+    #[deprecated = "Use Matrix2::look_to_stable"]     pub fn look_at_stable(dir: Vector2<S>, flip: bool) -> Matrix2<S> {+        Matrix2::look_to_stable(dir, flip)+    }++    /// Create a transformation matrix that will cause `unit_x()` to point at+    /// `dir`. `unit_y()` will be perpendicular to `dir`, and the closest to `up`.+    pub fn look_to(dir: Vector2<S>, up: Vector2<S>) -> Matrix2<S> {

I think that there is because handedness defines the direction of rotation. However, I had the same (unresolved) question which is why I decided not to modify it in the other PR. My reasoning was that it's probably better to leave it alone until I (or someone else) has time to figure out the correct path forward.

elrnv

comment created time in 2 months

pull request commentrustgd/cgmath

Fixed opposite quaternion slerp bug

All you need to do is check if the dot product is negative. If it is negative, negate the quaternion and recompute the dot product again.

josh65536

comment created time in 2 months

pull request commentaloucks/imgui-glfw-support

Update dependency versions

@8bitkitkat Thank you! v0.3.0 has been published.

8bitkitkat

comment created time in 2 months

created tagaloucks/imgui-glfw-support

tagv0.3.0

GLFW support for imgui-rs

created time in 2 months

push eventaloucks/imgui-glfw-support

Aaron Loucks

commit sha 96247e7cf17aa8eede49b5ea151906390629efc4

Version 0.3.0

view details

push time in 2 months

push eventaloucks/imgui-glfw-support

Ketan Reynolds

commit sha 7abcb15a31941e0f44d04bf7a9c1ae17cc1d968d

Update dependency versions (#2)

view details

push time in 2 months

push eventaloucks/vki

Aaron Loucks

commit sha 0329d7009891ee63c1c4395374d7f0e215504f24

Add more texture formats

view details

push time in 2 months

Pull request review commentrustgd/cgmath

Add Transform::{look_at_rh, look_at_lh} and deprecate look_at (continued)

 impl<S: BaseFloat> From<Quaternion<S>> for Basis3<S> {  impl<S: BaseFloat> Rotation<Point3<S>> for Quaternion<S> {     #[inline]-    fn look_at(dir: Vector3<S>, up: Vector3<S>) -> Quaternion<S> {

There should be {lh|rh} variants.

elrnv

comment created time in 2 months

Pull request review commentrustgd/cgmath

Add Transform::{look_at_rh, look_at_lh} and deprecate look_at (continued)

 impl<S> Matrix2<S> { impl<S: BaseFloat> Matrix2<S> {     /// Create a transformation matrix that will cause `unit_x()` to point at     /// `dir`. `unit_y()` will be perpendicular to `dir`, and the closest to `up`.+    #[deprecated = "Use Matrix2::look_to"]     pub fn look_at(dir: Vector2<S>, up: Vector2<S>) -> Matrix2<S> {-        Matrix2::look_at_stable(dir, up.x * dir.y >= up.y * dir.x)+        Matrix2::look_to(dir, up)     }      /// Crate a transformation that will cause `unit_x()` to point at-    /// `dir`. This is similar to `look_at`, but does not take an `up` vector.+    /// `dir`. This is similar to `look_to`, but does not take an `up` vector.     /// This will not cause `unit_y()` to flip when `dir` crosses over the `up` vector.+    #[deprecated = "Use Matrix2::look_to_stable"]     pub fn look_at_stable(dir: Vector2<S>, flip: bool) -> Matrix2<S> {+        Matrix2::look_to_stable(dir, flip)+    }++    /// Create a transformation matrix that will cause `unit_x()` to point at+    /// `dir`. `unit_y()` will be perpendicular to `dir`, and the closest to `up`.+    pub fn look_to(dir: Vector2<S>, up: Vector2<S>) -> Matrix2<S> {

This should be look_to_{lh|rh}. I didn't update these because I didn't know what the current implementation was.

elrnv

comment created time in 2 months

pull request commentrustgd/cgmath

Add Transform::{look_at_rh, look_at_lh} and deprecate look_at

If it's the latter, I don't mind filling in the last renaming changes, or otherwise submitting another PR for that.

Excellent! It would be great if you want to address other changes in a separate PR.

aloucks

comment created time in 3 months

startedbombomby/optick

started time in 3 months

startedbombomby/optick-rs

started time in 3 months

push eventaloucks/vki

Aaron Loucks

commit sha c0467e3b46291397c6cb246273eb1002f8f354b7

Use actions/cache@v2

view details

push time in 3 months

more