profile
viewpoint
Alexander Regueiro alexreg Erebor London, Great Britain http://noldorin.com/ https://about.me/alexreg

alexreg/git-bzr-ng 4

bi-directional git/bzr bridge

alexreg/Cloudup-Alfred-Workflow 2

Makes it easy to upload files to Cloudup via Alfred

alexreg/ergo-bot 2

Facebook Messenger bot for the Ergo game

alexreg/brew 1

🍺 The missing package manager for macOS

alexreg/brewdo 1

sandboxing for Homebrew

alexreg/Cake.RoslynAnalyzers 1

An addin for Cake that allows for Roslyn code analyzers to be run on solutions and projects

alexreg/cookie-rs 1

HTTP cookie parsing and cookie jar management for rust

alexreg/gist-alfred 1

An alfred workflow for accessing gists

alexreg/homebrew-cask 1

🍻 A CLI workflow for the administration of macOS applications distributed as binaries

alexreg/homebrew-core 1

:beers: Core formulae for the Homebrew package manager

issue commentmicrosoft/vscode

Auto-hide pop-up notifications

@sanket-bhalerao That's helpful, thanks, though I'd still like this feature.

alexreg

comment created time in 8 days

issue openedmicrosoft/vscode

Auto-hide pop-up notifications

It would be nice to have a configuration setting for auto-hiding them after some interval. I think they're called "workbench notifications" — they pop up in the bottom-right of the editor portion of the window.

created time in 9 days

startedrust-secure-code/cargo-geiger

started time in 15 days

issue closedmicrosoft/vscode

Tolerate trailing commas in jsonc format

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

Would it be possible to add tolerance for trailing commas to the jsonc (JSON With Comments) format? Even as an optional setting that is off by default. While I can understand not adding support to the json (spec-compliant) format, there doesn't seem to be a good reason not to add it (either on automatically or configurable) to jsonc.

In case there's any doubt over what I mean, here's an example.

{
    "foo": 123,
    "bar": [
        "abc",
        "def",
        "ghi", // trailing comma: okay!
    ], // trailing comma: okay!
}

closed time in 21 days

alexreg

issue commentmicrosoft/vscode

Tolerate trailing commas in jsonc format

Oh, I thought you meant JSON Schema. That's great, thank you.

alexreg

comment created time in 24 days

startedtoumorokoshi/deepmerge

started time in 25 days

startedInfinidat/munch

started time in 25 days

startedavian2/jsonmerge

started time in 25 days

issue commentmicrosoft/vscode

Tolerate trailing commas in jsonc format

Ah, I see, thanks for explaining. I think you're right... many "jsonc" parsers accept trailing commas, while many don't. The Python one that I'm using happily does (and indeed I chose it partly for that reason).

Indeed, I was the one (as far as I'm aware) who requested the allowTrailingCommas feature for settings files, and that's great. :-)

No, I don't have a JSON schema. Maybe a setting like allowTrailingCommas could be added to the [json] language section in VS Code settings? Ideally this would be configurable on a per-directory or even per-file basis, but I suppose that comes down to how VS Code workspace settings work in general. Perhaps support for that has recently been added?

alexreg

comment created time in 25 days

issue openedmicrosoft/vscode

Tolerate trailing commas in jsonc format

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

Would it be possible to add tolerance for trailing commas to the jsonc (JSON With Comments) format? Even as an optional setting that is off by default. While I can understand not adding support to the json (spec-compliant) format, there doesn't seem to be a good reason not to add it (either on automatically or configurable) to jsonc.

In case there's any doubt over what I mean, here's an example.

{
    "foo": 123,
    "bar": [
        "abc",
        "def",
        "ghi", // trailing comma: okay!
    ], // trailing comma: okay!
}

created time in a month

startedjoh/when-changed

started time in a month

startedKozea/WeasyPrint

started time in a month

startedpuppeteer/puppeteer

started time in a month

startedqt/qtwebkit

started time in a month

startedvaidik/commentjson

started time in a month

startedlinjackson78/jstyleson

started time in a month

startedwkhtmltopdf/wkhtmltopdf

started time in a month

issue commentHomebrew/homebrew-core

batik: Unable to access jarfile

Thanks. (I am in fact not at all sure whether it should exist; I just started using batik.)

alexreg

comment created time in a month

issue openedHomebrew/homebrew-core

batik: Unable to access jarfile

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

  • [x] ran brew update and can still reproduce the problem?
  • [x] ran brew doctor, fixed all issues and can still reproduce the problem?
  • [x] ran brew gist-logs <formula> (where <formula> is the name of the formula that failed) and included the output link?
  • [x] if brew gist-logs didn't work: ran brew config and brew doctor and included their output with your issue?

<!-- To help us debug your issue, please complete these sections: -->

What you were trying to do (and why)

Simply run the batik program. For example,

batik -h

What happened (include command output)

I got an error, "unable to access jarfile". Indeed, the file /usr/local/Cellar/batik/1.13/libexec/batik-1.13.jar does not exist.

<details> <summary>Command output</summary> <pre>

Error: Unable to access jarfile /usr/local/Cellar/batik/1.13/libexec/batik-1.13.jar

</pre> </details>

The contents of the /usr/local/Cellar/batik/1.13/libexec/ directory is:

batik-rasterizer-1.13.jar
batik-slideshow-1.13.jar
batik-squiggle-1.13.jar
batik-svgpp-1.13.jar
batik-ttf2svg-1.13.jar
lib

Here are the Gist logs for the batik formula.

What you expected to happen

The help output should have been successfully printed.

Step-by-step reproduction instructions (by running brew install commands)

brew install batik
batik -h

created time in a month

startedKozea/cssselect2

started time in a month

startedsimonw/soupselect

started time in a month

startedgawel/pyquery

started time in a month

startedKozea/tinycss2

started time in a month

startedmozman/svgwrite

started time in a month

startedapple/swift-log

started time in a month

startedbergkvist/includeimage

started time in a month

startedFamilySearch/gedcomx

started time in 2 months

startedscala-native/scala-native

started time in 2 months

startedswiftwasm/swift

started time in 2 months

startedvcftools/vcftools

started time in 2 months

startedapple/swift

started time in 2 months

push eventalexreg/rust

Philipp Hansch

commit sha 83874d0ee77264a82a59513fa4362e86c39034c4

Make use of Option/Result diagnostic items

view details

Philipp Hansch

commit sha a524be6df505598dabb27902eb9d9fc31b61cab0

cargo dev fmt

view details

LeSeulArtichaut

commit sha b84f9813618e6d8de68e91022e942562940a83cc

Document unsafety in `src/libcore/hash/sip.rs`

view details

Emerentius

commit sha e98c7a45d44cfed922699fbc1d61f3802d08b867

update lints

view details

Michael Sproul

commit sha 23df4a0183e0d954d47db98824295411d50f742e

Disallow bit-shifting in `integer_arithmetic` lint With this change, the lint checks all operations that are defined as being capable of overflow in the Rust Reference.

view details

Rabi Guha

commit sha ab3946d7e9d83e8d177073f27d8ec704b399d687

Fixes #5405: redundant clone false positive with arrays Check whether slice elements implement Copy before suggesting to drop the clone method

view details

Philipp Hansch

commit sha 31c5664f2533057bcbe42acc71815a17f0030d74

Cleanup: Use our `sym!` macro more It's much shorter that Symbol::intern and the result should still be clear.

view details

Philipp Hansch

commit sha e47db677acca8fbf3b1c219e65adf426538d9440

Cleanup: Use rustc's is_proc_macro_attr It's doing exactly the same: https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_ast/expand/mod.rs.html#8-12

view details

Philipp Hansch

commit sha 9a52d520686627ab8835ed6d48dfffe3a1a6adac

result_map_unit_fn: Fix incorrect UI tests `x` and the `HasResult` struct were missing in this file.

view details

Philipp Hansch

commit sha 8ad1d780e98d3c9be2cc69a012ca105d4a500e99

Temporarily disable rustfmt integration test Running rustfmt from master is currently broken: https://github.com/rust-lang/rust/issues/71077

view details

Philipp Hansch

commit sha a4deb5aca55fc1ab18e6c017181dd3f892c614f6

Explain panic on `E0463` in integration tests

view details

bors

commit sha 6d4cc5670353d7636862a187abebb467fe7e72f9

Auto merge of #5461 - phansch:disable_rustfmt_integration_test, r=matthiaskrgr Temporarily disable rustfmt integration test Running rustfmt from master is currently broken and [fails our bors build](https://github.com/rust-lang/rust-clippy/runs/582066368#step:10:19): https://github.com/rust-lang/rust/issues/71077 changelog: none

view details

bors

commit sha 54344c78f464aaf9e640684461ee111d201b8efb

Auto merge of #5448 - Emerentius:update_new_ret_no_self_docs, r=phansch Update documentation for new_ret_no_self changelog: Update documentation for lint new_ret_no_self to reflect that the return type must only contain `Self`, not be `Self` The lint was changed to be more lenient than the documentation implies in PR #3338 (Related issue #3313)

view details

bors

commit sha aa08c39b117ddaa62a19421be726f341bb95a1f6

Auto merge of #5458 - phansch:is-proc-macro-attr, r=matthiaskrgr Cleanup: Use rustc's is_proc_macro_attr It's doing exactly the same: https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_ast/expand/mod.rs.html#8-12 changelog: none

view details

bors

commit sha 74e92566d5cbe670a74a4ce340973716760479db

Auto merge of #5453 - rabisg0:fix/redundant_clone, r=phansch Fixes #5405: redundant clone false positive with arrays Check whether slice elements implement Copy before suggesting to drop the clone method changelog: add a check for slice indexing on redundant_clone lint

view details

Matthias Krüger

commit sha c1f2da40ab63813066c0d573951bff2aab69a811

rustup https://github.com/rust-lang/rust/pull/70643

view details

bors

commit sha 85e8b64c82ab44ce8016b97e3a29ec3190c91445

Auto merge of #5463 - matthiaskrgr:rustup_42, r=phansch rustup https://github.com/rust-lang/rust/pull/70643 changelog: none

view details

bors

commit sha d236b30a1d638340aad8345fa2946cfe9543dcf0

Auto merge of #5457 - phansch:sym, r=matthiaskrgr Cleanup: Use our `sym!` macro more It's much shorter than Symbol::intern and the effect should still be clear --- changelog: none

view details

Oliver Scherer

commit sha 2b25c0cd815f032b2c0b34d7d2316fbb20eda8de

Don't load the same allocation twice when reading a scalar pair from it

view details

Matthias Krüger

commit sha 9eda46ece548f55d2e133d311f73eb5fe570a21d

deps: bump compiletest-rs from 0.4 to 0.5

view details

push time in 3 months

startedmgeisler/textwrap

started time in 3 months

startedgltf-rs/gltf

started time in 3 months

issue commentrust-lang/rustc-dev-guide

Glossary

@tshepang Yep, good point. We can remove that from the list now.

mark-i-m

comment created time in 3 months

issue commentrust-lang/rustc-dev-guide

Glossary

@tshepang I think you meant to take @mark-i-m?

mark-i-m

comment created time in 3 months

pull request commentrust-lang/rust

Prefer `cmake3` to `cmake` when bootstrapping.

@Dylan-DPC In that case, no prob. Shouldn't bitrot much (if at all) in a few days!

alexreg

comment created time in 3 months

pull request commentrust-lang/rust

Prefer `cmake3` to `cmake` when bootstrapping.

@crlf0710 Happy to rebase right after a review... don't want to rebase just for it to sit around a while longer waiting for a review. :-)

alexreg

comment created time in 3 months

startedrust-lang/glacier

started time in 3 months

startedrust-lang/backtrace-rs

started time in 3 months

startedrust-lang/rust-clippy

started time in 3 months

startedrust-lang/rls

started time in 3 months

startedrust-lang/cargo

started time in 3 months

startedrust-lang/miri

started time in 3 months

startedrust-lang/rfcs

started time in 3 months

startedrust-lang/rust

started time in 3 months

startedparitytech/parity-wasm

started time in 3 months

startedmangerlahn/Latest

started time in 3 months

starteddeislabs/krustlet

started time in 3 months

startedmicrosoft/winrt-rs

started time in 3 months

startedamethyst/space-menace

started time in 3 months

startedstepancheg/grpc-rust

started time in 3 months

pull request commentrust-lang/rust

Trait upcasting

@joelpalmer Yep, resolve them locally... going to factor out some of these changes to a separate PR soon.

alexreg

comment created time in 3 months

startedOgeon/palette

started time in 3 months

issue openedsekey/sekey

Installer writes to `~/Library/LaunchAgents`

The installer installs the binary to /usr/local/bin, which is system-wide, but the launch agent to ~/Library/LaunchAgents, which is user local. This sort of inconsistency is not desirable, and it should probably install the launch agent to /Library/LaunchAgents.

In particular, this is problematic because I use brewdo, which means I get permissions errors on installation when the installer tries to write to ~/Library/LaunchAgents.

See also my post on Homebrew Discourse.

created time in 3 months

starteddtolnay/dyn-clone

started time in 3 months

startedm-cat/cargo-deps

started time in 3 months

startedsrijs/deps.rs

started time in 3 months

more