profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/alexey-pelykh/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

alexey-pelykh/webp-android-backport 520

WebP format support for Android <4.0

alexey-pelykh/glTF-Blender-IO 2

Blender glTF 2.0 importer and exporter

alexey-pelykh/argo 0

Argo Workflows: Get stuff done with Kubernetes.

alexey-pelykh/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

alexey-pelykh/filament 0

Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS and WASM/WebGL

alexey-pelykh/gltflib 0

Library for parsing, creating, and converting glTF 2.0 files in Python 3.6+.

alexey-pelykh/HoudiniGLTF 0

Houdini's glTF integration

alexey-pelykh/material-ui 0

React components that implement Google's Material Design.

alexey-pelykh/node 0

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

alexey-pelykh/Pelykh.Common 0

Common .NET libraries

issue closedOCA/currency

[12.0]currency_rate_update_transferwise got nothing (wise.com instead?)

The error is: Currency Rate Provider "TransferWise.com" failed to obtain data since 2021-07-20 until 2021-07-20: decode() argument 1 must be str, not None

closed time in 3 days

batona

issue commentOCA/currency

[12.0]currency_rate_update_transferwise got nothing (wise.com instead?)

You're trying to use it with either personal account, not business one, or you don't have any borderless accounts on your corporate account

batona

comment created time in 3 days

push eventcorporatehub/account-closing

Alexey Pelykh

commit sha 7a770c55ce4bc8c66ec5ff77749a24e97fdf5a56

[FIX] account_multicurrency_revaluation: AMLs on revaluation date should be included

view details

push time in 11 days

push eventcorporatehub/account-closing

Alexey Pelykh

commit sha 6dfe7ea6ad7694851e3dba4b8ea6d28f4cb2a77b

[FIX] account_multicurrency_revaluation: AMLs on revaluation date should be included

view details

push time in 11 days

push eventcorporatehub/account-closing

Alexey Pelykh

commit sha 0c02773f22cd1b37ce217c7c0f35354035be020e

[FIX] account_multicurrency_revaluation: AMLs on revaluation date should be included

view details

push time in 11 days

issue commentgoogle/filament

Depth buffer overflow?

@pixelflinger not actionable in a way it's not an issue any more?

alexey-pelykh

comment created time in 16 days

pull request commentOCA/timesheet

[14.0] [mig] hr_timesheet_task_stage

/ocabot merge nobump

dsolanki-initos

comment created time in 23 days

pull request commentOCA/timesheet

[14.0] [mig] hr_timesheet_task_stage

@dsolanki-initos merging will fail due to https://github.com/OCA/timesheet/runs/2959248967 Please re-run precommit pass

dsolanki-initos

comment created time in 23 days

pull request commentOCA/timesheet

[14.0] [mig] hr_timesheet_task_stage

/ocabot merge nobump

dsolanki-initos

comment created time in 23 days

PullRequestReviewEvent

delete branch alexey-pelykh/filament

delete branch : gltf_extras

delete time in 24 days

Pull request review commentOCA/timesheet

[13.0] [MIG] sale_timesheet_line_exclude

 def _timesheet_should_evaluate_so_line(self, values, check):             ]         ) -    @api.multi     def _timesheet_determine_sale_line_arguments(self, values=None):-        return {-            "task": (self.env["project.task"].sudo().browse(values["task_id"]))-            if values and "task_id" in values-            else self.task_id,-            "employee": (self.env["hr.employee"].sudo().browse(values["employee_id"]))-            if values and "employee_id" in values-            else self.employee_id,-        }+        if values:+            return {+                "task": self.env["project.task"].sudo().browse(values.get("task_id")),+                "employee": self.env["hr.employee"]+                .sudo()

sudo on next line, ugh

Du-ma

comment created time in a month

PullRequestReviewEvent

Pull request review commentOCA/timesheet

[13.0] [MIG] sale_timesheet_line_exclude

 def _onchange_exclude_from_sale_order(self):      @api.constrains("exclude_from_sale_order")     def _constrains_exclude_from_sale_order(self):-        if self.filtered(-            lambda line: line.timesheet_invoice_id-            and line.so_line.product_id.invoice_policy == "delivery"-        ):-            raise ValidationError(-                _(-                    "You can not modify timesheets in a way that would affect"-                    " invoices since these timesheets were already invoiced."+        for line in self:

Optimization?

Du-ma

comment created time in a month

PullRequestReviewEvent

Pull request review commentOCA/timesheet

[14.0] [mig] hr_utilization_analysis

+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink+access_my_wizard_user,my.wizard.user,model_hr_utilization_analysis_wizard,hr.group_hr_manager,1,1,1,1

I don't follow you. Parent menu is accessible to hr_timesheet.group_timesheet_manager, why then this wizard requires hr.group_hr_manager?

schhatbar-initos

comment created time in a month

PullRequestReviewEvent

issue commentOCA/connector-jira

connector_jira_tempo and hr_timesheet_sheet

I'd say nothing was done there to my knowledge, but likely I won't address that anytime soon

alexey-pelykh

comment created time in a month

Pull request review commentOCA/hr

[IMP]: add unit in form selection widget

 def test_6(self):         name = leave_type.with_context(             employee_id=employee.id,         ).name_get()[0][1]-        self.assertTrue('available + credit' in name)+        self.assertIn('available', name, '%s not found in %s' % ('available', name))

Runbot tests in en_US, so probably does not matter

maisim

comment created time in a month

PullRequestReviewEvent

Pull request review commentOCA/hr

[IMP]: add unit in form selection widget

 def test_6(self):         name = leave_type.with_context(             employee_id=employee.id,         ).name_get()[0][1]-        self.assertTrue('available + credit' in name)+        self.assertIn('available', name, '%s not found in %s' % ('available', name))

I'm not sure if that's the correct way, to include localization in testing. I'd refer this to other @OCA/human-resources-maintainers

maisim

comment created time in a month

PullRequestReviewEvent

Pull request review commentOCA/hr

[IMP]: add unit in form selection widget

 def name_get(self):              extra = None             if record.allocation_type != 'no' and context_employee_id:-                if record.virtual_remaining_leaves >= 0:+                amount = float_round(record.virtual_remaining_leaves, precision_digits=2) or 0.0+                if amount >= 0 :+                    if record.request_unit == 'day':+                        extra = _('%g day available') % amount if abs(amount) <= 1 else _('%g days available') % amount+                    elif record.request_unit == 'hour':+                        extra = _('%g hour available') % amount if abs(amount) <= 1 else _('%g hours available') % amount+                    else:+                        extra = _('%g %s available') % (amount, record.request_unit)+                     if record.allow_credit:-                        extra = _('%g available + credit')+                        extra += " " + _('+ credit')++                elif amount < 0:+                    if record.request_unit == 'day':+                        extra = _('%g day used in credit') % amount if abs(amount) <= 1 else _('%g days used in credit') % amount+                    elif record.request_unit == 'hour':+                        extra = _('%g hour used in credit') % amount if abs(amount) <= 1 else _('%g hours used in credit') % amount                     else:-                        extra = _('%g available')-                    extra = extra % (-                        float_round(-                            record.virtual_remaining_leaves,-                            precision_digits=2-                        ) or 0.0,-                    )-                elif record.allow_credit:-                    extra = _('%g used in credit') % (-                        float_round(-                            -record.virtual_remaining_leaves,-                            precision_digits=2-                        ) or 0.0,-                    )+                        extra = _('%g %s used in credit') % (amount, record.request_unit)              if extra:-                record_name = _('%(name)s (%(extra)s)') % {+                record_name = '%(name)s (%(extra)s)' % {

Pay attention to what's inside the _() and compare this

_('%(name)s (%(extra)s)') % {
    'name': 'A',
    'extra': 'B',
}

and

_('%(name)s (%(extra)s)' % {
    'name': 'A',
    'extra': 'B',
})
maisim

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOCA/hr

[IMP]: add unit in form selection widget

 def name_get(self):              extra = None             if record.allocation_type != 'no' and context_employee_id:-                if record.virtual_remaining_leaves >= 0:+                amount = float_round(record.virtual_remaining_leaves, precision_digits=2) or 0.0+                if amount >= 0 :+                    if record.request_unit == 'day':+                        extra = _('%g day available') % amount if abs(amount) <= 1 else _('%g days available') % amount+                    elif record.request_unit == 'hour':+                        extra = _('%g hour available') % amount if abs(amount) <= 1 else _('%g hours available') % amount+                    else:+                        extra = _('%g %s available') % (amount, record.request_unit)+                     if record.allow_credit:-                        extra = _('%g available + credit')+                        extra += " " + _('+ credit')++                elif amount < 0:+                    if record.request_unit == 'day':+                        extra = _('%g day used in credit') % amount if abs(amount) <= 1 else _('%g days used in credit') % amount+                    elif record.request_unit == 'hour':+                        extra = _('%g hour used in credit') % amount if abs(amount) <= 1 else _('%g hours used in credit') % amount                     else:-                        extra = _('%g available')-                    extra = extra % (-                        float_round(-                            record.virtual_remaining_leaves,-                            precision_digits=2-                        ) or 0.0,-                    )-                elif record.allow_credit:-                    extra = _('%g used in credit') % (-                        float_round(-                            -record.virtual_remaining_leaves,-                            precision_digits=2-                        ) or 0.0,-                    )+                        extra = _('%g %s used in credit') % (amount, record.request_unit)              if extra:-                record_name = _('%(name)s (%(extra)s)') % {+                record_name = '%(name)s (%(extra)s)' % {

That's not how translation works in this case. Template is getting localized, not formatted string

maisim

comment created time in a month

Pull request review commentOCA/hr

[IMP]: add unit in form selection widget

 def name_get(self):              extra = None             if record.allocation_type != 'no' and context_employee_id:-                if record.virtual_remaining_leaves >= 0:+                amount = float_round(record.virtual_remaining_leaves, precision_digits=2) or 0.0+                if amount >= 0 :+                    if record.request_unit == 'day':+                        extra = _('%g day available') % amount if abs(amount) <= 1 else _('%g days available') % amount+                    elif record.request_unit == 'hour':+                        extra = _('%g hour available') % amount if abs(amount) <= 1 else _('%g hours available') % amount+                    else:+                        extra = _('%g %s available') % (amount, record.request_unit)+                     if record.allow_credit:-                        extra = _('%g available + credit')+                        extra += " " + _('+ credit')++                elif amount < 0:+                    if record.request_unit == 'day':+                        extra = _('%g day used in credit') % amount if abs(amount) <= 1 else _('%g days used in credit') % amount+                    elif record.request_unit == 'hour':+                        extra = _('%g hour used in credit') % amount if abs(amount) <= 1 else _('%g hours used in credit') % amount                     else:-                        extra = _('%g available')-                    extra = extra % (-                        float_round(-                            record.virtual_remaining_leaves,-                            precision_digits=2-                        ) or 0.0,-                    )-                elif record.allow_credit:-                    extra = _('%g used in credit') % (-                        float_round(-                            -record.virtual_remaining_leaves,-                            precision_digits=2-                        ) or 0.0,-                    )+                        extra = _('%g %s used in credit') % (amount, record.request_unit)              if extra:-                record_name = _('%(name)s (%(extra)s)') % {+                record_name = '%(name)s (%(extra)s)' % {

Why did you remove translation here? RTL languages kind-a have that backwards

maisim

comment created time in a month