profile
viewpoint
Adam Krantz akrantz @microsoft Seattle, Washington Principal Software Engineer at Microsoft. Empowering developers to achieve more with Microsoft M365. he/him

akrantz/Chakra-Samples 0

Repository for Chakra JavaScript engine related samples.

akrantz/ChakraCore 0

ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge

akrantz/ChakraCore-Debugger 0

Debugging companion library for the ChakraCore JavaScript engine

akrantz/ChakraCore-Debugger--old 0

Debugging companion for the ChakraCore JavaScript engine

akrantz/create-react-app 0

Create React apps with no build configuration.

akrantz/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

akrantz/edge-diagnostics-adapter 0

Microsoft Edge Diagnostics Adapter is a protocol adapter that enables tools to debug Microsoft Edge using the Chrome DevTools Protocol.

akrantz/Excel-Custom-Functions 0

Learn about custom functions in Excel.

akrantz/Excel-Custom-Functions-JS 0

Write your own functions in Excel using JavaScript.

akrantz/generator-office 0

Yeoman generator for building Microsoft Office related projects.

issue commentOfficeDev/generator-office

Assets using icon with size 80 pixels, which now is invalid

I had these issues as well when running github actions. They showed up after I fixed icon size. I didn't see them before, so I guess the test has been updated to actually go and fetch the icons. The original error I had was of the form:

incorrect-size

ralphtheninja

comment created time in 5 hours

PR closed OfficeDev/Excel-Custom-Functions

Reviewers
Create Shared Runtime branch for Excel Custom Functions
  • This branch enables Shared Runtime for ECF. The initial thought is that this will be branch off the Excel Custom functions repo called "shared-runtime." We can then also have a "yo-offfice-shared-runtime" for production
  • Added tests to verify taskpane functionality as well, which we didn't previously have for ECF. These changes should get propagated to master as well
  • Verfied branch works on Windows. Following up to verify works on Mac too
+635 -512

3 comments

19 changed files

TCourtneyOwen

pr closed time in 14 hours

push eventOfficeDev/Excel-Custom-Functions

Courtney Owen

commit sha f42c26f6517c17d146fd4c3b34f48908ba637cce

Merge office-addin-taskpane/master

view details

Courtney Owen

commit sha e065851a7d6dd0902ffa35caa6b0f19c59ac16da

Merge pull request #238 from TCourtneyOwen/merge-office-addin-taskpane Merge office-addin-taskpane/master

view details

push time in 14 hours

pull request commentOfficeDev/Excel-Custom-Functions

Merge office-addin-taskpane/master

Tests are failing because of an apparent timing issue - they pass locally

TCourtneyOwen

comment created time in 14 hours

push eventOfficeDev/Office-Addin-TaskPane-Angular

Courtney Owen

commit sha 449d0fc071a7c3c3076271cb5c41efea3244e046

Merge office-addin-taskpane/master

view details

Courtney Owen

commit sha 7127ee309712c96d673a7728937c4679b6186fab

Merge pull request #58 from TCourtneyOwen/merge-office-addin-taskpane Merge office-addin-taskpane/master

view details

push time in 16 hours

push eventOfficeDev/Office-Addin-TaskPane-JS

Courtney Owen

commit sha c693d39795174f2a3a311ae8a006321295054e91

Merge office-addin-taskpane/master

view details

Courtney Owen

commit sha f8cdc8c92500f68637b5cca9bb1ae5f601b5e293

Merge pull request #62 from TCourtneyOwen/merge-office-addin-taskpane Merge office-addin-taskpane/master

view details

push time in 16 hours

push eventOfficeDev/Office-Addin-TaskPane-React

Courtney Owen

commit sha 585f17895d43feedbafa94c6c1bbc2a4b5ebfa58

Merge office-addin-taskpane/master

view details

Courtney Owen

commit sha bc13981fdc0c6cbfcb0939b608e83936afb96edc

Merge pull request #55 from TCourtneyOwen/merge-office-addin-taskpane Merge office-addin-taskpane/master

view details

push time in 16 hours

issue commentOfficeDev/generator-office

Unable to install CA cert for local development on Windows 10 with VSCode

That's great to hear @Nate53085. Thanks for letting us know!

-Courtney

Nate53085

comment created time in 20 hours

issue commentOfficeDev/Office-Addin-Scripts

OfficeRuntime.auth.getAccessToken not working on production

@davidchesnut @Rick-Kirkham Looping in a couple of our Writers in case they know of documentation that perhaps explains how to deploy the SSO project template to Production

arozwalak

comment created time in 20 hours

issue commentOfficeDev/generator-office

Assets using icon with size 80 pixels, which now is invalid

I am noticing our office-addin-manifest tests have started failing recently. Are you seeing errors such as the following during manifest validation:

"{"utcTimestamp":"2020-11-24T17:32:11.2040272+00:00","status":*"Rejected","errors":[{"id":"c8d66ffc-bc7b-41bd-983e-5c6c0459f0ad","title":"High Resolution Icon URL Unreachable","content":"Unable to retrieve an image from the high resolution icon URL.","code":"The HighResolutionIconURL supplied in the app manifest is not reachable, HighResolutionIconURL : https://localhost:3000/assets/icon-80.png."},{"id":"1f9a991b-be34-49c5-939a-46b5170d7dbf","title":"Icon URL Unreachable","content":"Unable to retrieve an image from the icon URL.","code":"The IconURL supplied in the app manifest is not reachable, IconURL : https://localhost:3000/assets/icon-32.png."}],*"

Thanks,

Courtney

ralphtheninja

comment created time in 20 hours

issue closedOfficeDev/generator-office

Unable to install CA cert for local development on Windows 10 with VSCode

Expected behavior

Developer documentation https://docs.microsoft.com/en-us/office/dev/add-ins/quickstarts/outlook-quickstart?tabs=yeomangenerator works as expected

Current behavior

When running the dev server OR when trying to manually install the dev CA cert, I get the following:

The developer certificates have been generated in C:\Users\Nathan.office-addin-dev-certs Installing CA certificate "Developer CA for Microsoft Office Add-ins"... Error: Unable to install the CA certificate.

The larger output when running the dev server (vs directly installing the CA cert) is:

C:\Users\Nathan\source\ask\Ask>npm run dev-server

office-addin-taskpane-js@0.0.1 dev-server C:\Users\Nathan\source\ask\Ask webpack-dev-server --mode development

The developer certificates have been generated in C:\Users\Nathan.office-addin-dev-certs Installing CA certificate "Developer CA for Microsoft Office Add-ins"... office-addin-dev-certs: Unable to install the CA certificate. at install.js:65:19 at Generator.next (<anonymous>) at install.js:9:71 at new Promise (<anonymous>) at __awaiter (install.js:5:12) at installCaCertificate (install.js:54:12) at Object.<anonymous> (install.js:42:23) at Generator.next (<anonymous>) at fulfilled (install.js:6:58) npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! office-addin-taskpane-js@0.0.1 dev-server: webpack-dev-server --mode development npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the office-addin-taskpane-js@0.0.1 dev-server script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\Nathan\AppData\Roaming\npm-cache_logs\2020-11-20T18_35_11_934Z-debug.log

Steps to Reproduce

Smallest repro I could do is:

  1. npm install -g yo generator-office
  2. yo office
  3. Select outlook as the project
  4. npm run dev-server OR npx office-addin-dev-certs install

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Operating System: Windows 10

  • Node version: v10.15.0

  • Office version: Version 2010 Build 13328.20356 Click to Run

  • Tool version: npx office-addin-dev-certs -V resulted in (version not available) Package.json:

    "office-addin-cli": "^1.0.16", "office-addin-debugging": "^3.0.39", "office-addin-dev-certs": "^1.5.9", "office-addin-lint": "^1.0.29", "office-addin-manifest": "1.5.7", "office-addin-prettier-config": "^1.0.12",

Failure Logs

2020-11-20T18_14_43_050Z-debug.log

closed time in 21 hours

Nate53085

issue commentOfficeDev/generator-office

Unable to install CA cert for local development on Windows 10 with VSCode

Refreshing windows to repair powershell fixed the issue. I am now able to install the certificates. Thanks for all your help.

Nate53085

comment created time in 21 hours

issue openedOfficeDev/generator-office

Assets using icon with size 80 pixels, which now is invalid

Prerequisites

Please answer the following questions before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • [x] I am running the latest version of Node and the tools
  • [x] I checked the documentation and found no answer
  • [x] I checked to make sure that this issue has not already been filed

Expected behavior

Please describe the behavior you were expecting

I expect the icons to be of correct size.

Current behavior

Current behavior is using size 80 pixels of the biggest icons. But when running tests against the generated manifest (regardless of host) the test expects the biggest icon to be 64x64 pixels.

Steps to Reproduce

Just create any example project using yo office.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Operating System:
  • Node version:
  • Office version:
  • Tool version:

Failure Logs

Please include any relevant log snippets, screenshots or code samples here.

created time in a day

issue commentOfficeDev/Office-Addin-Scripts

OfficeRuntime.auth.getAccessToken not working on production

I think it would be nice to add information (in bold) that it's not production ready, otherwise the whole documentation is misleading. I've spent 2 weeks trying to make it work on production, reading tons of documentation of microsoft's pages. This is second time I have to work with microsoft's code and again is so annoying and frustraiting. Hope I won't touch this code ever again.

Thank you for no help!

arozwalak

comment created time in a day

push eventOfficeDev/Excel-Custom-Functions

Courtney Owen

commit sha fd9ba82f83ccba3e4a42ecd321e67e7b65b22a10

Create Shared Runtime branch for Excel Custom Functions - This branch enables Shared Runtime for ECF. The initial thought is that this will be branch off the Excel Custom functions repo called "shared-runtime." We can then also have a "yo-offfice-shared-runtime" for production - Added tests to verify taskpane functionality as well, which we didn't previously have for ECF. These changes should get propagated to master as well - Verfied branch works on Windows. Following up to verify works on Mac too

view details

Courtney Owen

commit sha 73048b502514ed8c54a6342ec7d25fd3b36e4e36

Merge remote-tracking branch 'origin/master' into add-shared-runtime-branch

view details

Courtney Owen

commit sha c8af796b18ccea65a22e1232149252551429cc95

Update packages and webpack.config.js

view details

Courtney Owen

commit sha 26e2753050f87885ae6b3348ae5bd13189dd425f

Fix for desktop taskpane issue - Also added debug configs

view details

Courtney Owen

commit sha d8cf825ffebabfa5d9f380edc6771899f16a3c53

Update test manifest and test webpack.config.js

view details

Artur Tarasenko

commit sha 53568d435ae4cc3a8152fbac801176ba6b8fbc6d

Adding ESLint-Plugin-Excel-Custom-Functions to Shared App Template

view details

Artur Tarasenko

commit sha 94b3a5f9e06701e3e6be77b6c33651259315223d

template change while we wait for linter fix

view details

Courtney Owen

commit sha 345112cb6954e6468c1c7128a80de41aa20ed0c8

Update debug configs

view details

Courtney Owen

commit sha 5dd75617146bbe42bb693b67a160182e19ecb9aa

Merge branch 'incorporating-linter-to-shared-app-template' of https://github.com/OfficeDev/Excel-Custom-Functions into incorporating-linter-to-shared-app-template

view details

Courtney Owen

commit sha 2953064087f340845753b47bf2939f7880514d7b

Merge pull request #7 from OfficeDev/incorporating-linter-to-shared-app-template Adding ESLint-Plugin-Excel-Custom-Functions to Shared App Template

view details

Courtney Owen

commit sha d969f35707e1a3601071eb85fb0c9f0a711faf4d

Update taskpane.html - Fix issue with functions.ts

view details

Courtney Owen

commit sha 905f89c273ebe87094e39e377d69580e14dcd9ff

Update test code to match src code - Up the debug timeout

view details

Courtney Owen

commit sha 619ef76dd4a53341703dc658f2083c212f9d20a9

Merge branch 'shared-runtime-master' into add-shared-runtime-branch

view details

Courtney Owen

commit sha 0e5140ec79533331d76320ae160bcf65f9bcd199

Remove DesktopFormFactor section from test - Seems to having the DesktopFormFactor section in the test and then trying to open the taskpane via Office.addin.showAsTaskpane() makes the test very unreliable

view details

Courtney Owen

commit sha 8c6fd38133ac1742f6fecd3e002ab5abf951f2ec

Merge pull request #237 from TCourtneyOwen/add-shared-runtime-branch Add shared runtime branch

view details

push time in 2 days

PR merged OfficeDev/Excel-Custom-Functions

Reviewers
Add shared runtime branch
  • Confirmed shared runtime custom functions, commands and taskpane code works and is all debuggable using debug configs in project
  • Confirmed tests run and pass - tests execute taskpane and custom functions code
+635 -512

1 comment

19 changed files

TCourtneyOwen

pr closed time in 2 days

pull request commentOfficeDev/Excel-Custom-Functions-JS

Shared App Support

No this will not be merged to master - we need to kill this PR because this is a completely different project template. I think @arttarawork largely generated this PR to show me the code changes he made. I am going to kill this PR.

@arttarawork as we discussed, the next time you open a PR for this branch it needs to be against shared-runtime-master and not master

Thanks

arttarawork

comment created time in 2 days

issue commentOfficeDev/vscode-debugger-extension-for-office-addins

Getting error "Error processing "attach": No Edge instances found running on local machine" even though I am running office 365 in Edge and have this office add-in sideloaded and saving in editor is feeding into Edge (i.e. the connect appears to be there in that way)

@korisan It's possible that you might be running Edge Chromium and not Edge. The vscode-debugger-extension-for-office-addins extension doesn't support Edge Chromium. One way to check and see if you indeed running Edge and not Edge Chromium is to start your taskpane add-in, open the taskpane, then open Task Manager, and search for a process called WWAHost.exe. If you don't see a process called WWAHost.exe, you are running Edge Chromium and this debug extension won't work for that. However the Debugger for Microsoft Edge does support Edge Chromium.

Please let me know what you find.

Thanks,

Courtney

korisan

comment created time in 2 days

issue openedOfficeDev/vscode-debugger-extension-for-office-addins

Getting error "Error processing "attach": No Edge instances found running on local machine" even though I am running office 365 in Edge and have this office add-in sideloaded and saving in editor is feeding into Edge (i.e. the connect appears to be there in that way)

[Enter feedback here]


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

created time in 2 days

issue commentOfficeDev/Office-Addin-Scripts

OfficeRuntime.auth.getAccessToken not working on production

@arozwalak @mattgeim @LouMM I think the problem you are running into in Production is that the SSO service in started by office-add-in-sso is unable to get the application secret, which is stored locally for Windows in Windows Credential Manager. At the start of the SSO service, the code gets the application secret here:

public async startSsoService(isTest: boolean = false): Promise<boolean> {
    return new Promise<boolean>(async (resolve, reject) => {
        try {
            if (isTest) {
                process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0";
            }
            await this.getSecret(isTest);
            await this.startServer(this.app.appInstance, this.port);
            this.ssoServiceStarted = true;
            usageDataObject.sendUsageDataSuccessEvent('startSsoService');
            resolve(true);
        } catch(err) {
            usageDataObject.sendUsageDataException('startSsoService', err);
            reject(false);
        }
    });
}

private async getSecret(isTest: boolean = false): Promise<void> {
    const manifestInfo = await manifest.readManifestFile(this.manifestPath);
    const appSecret = getSecretFromCredentialStore(manifestInfo.displayName, isTest);
    if (appSecret === '') {
        const errorMessage: string = 'Call to getSecretFromCredentialStore returned empty string';
        throw new Error(errorMessage);
    }
    process.env.secret = appSecret;
}

You could set up your own SSO service on the Production code that mirrors the code in office-addin-sso and either hard-code the secret in your SSO service code (not ideal) or perhaps use PowerShell on the server to get secret from Azure using the following steps: https://docs.microsoft.com/en-us/powershell/module/azurerm.keyvault/get-azurekeyvaultsecret?view=azurermps-6.13.0.

Currently, the Yo Office SSO project template doesn't provide an easy out-of-box way for deploying to Prod, but this is our backlog to address. We may get to this after the first of the new year.

Thanks,

Courtney

arozwalak

comment created time in 2 days

more