profile
viewpoint
Akos Kiss akosthekiss University of Szeged Szeged, Hungary

akosthekiss/blurmac 11

Bluetooth Rust lib using macOS CoreBluetooth

akosthekiss/0b1100oclock 1

0b1100 O'Clock - a Binary Clockface for Fitbit

akosthekiss/cheeseplate 1

CheesePlate - Auxiliary Benchmark Suite for JerryScript

akosthekiss/heroku-buildpack-doxygen 1

Doxygen Buildpack for Heroku

akosthekiss/Adafruit_Python_BluefruitLE 0

Python library to simplify access to Bluetooth low energy devices and services on Linux (using bluez) and Mac OSX.

akosthekiss/antlerinator 0

ANTLeRinator

akosthekiss/antlr4 0

ANTLR (ANother Tool for Language Recognition) is a powerful parser generator for reading, processing, executing, or translating structured text or binary files.

akosthekiss/cargo 0

The Rust package manager

akosthekiss/chevron 0

A Python implementation of mustache

akosthekiss/clock64 0

Clock64 - a C64-inspired Clockface for Fitbit

push eventakosthekiss/simavr

Akos Kiss

commit sha abe7b8db21c19ba9a05feef23c9bbd4869c77b3e

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART

view details

push time in 5 hours

issue commentjerryscript-project/jerryscript

Stack overflow at ecma_op_object_get_with_receiver jerry-core/ecma/operations/ecma-objects.c:795

Thanks for reporting this issue. (And the follow-ups.) But. Before reporting any more stack overflow issues, please, check whether they are also reproducible if JerryScript is built with stack limit. If the SO does not happen with stack limit, the issue is not valid.

kvenux

comment created time in 2 days

push eventjerryscript-project/jerryscript

Ádám Kallai

commit sha f6cf1400bdb56e0453a75060b92cd3b166fed0be

Fix implicit 'double' conversion reported by Clang 12.0.0 (#4288) JerryScript-DCO-1.0-Signed-off-by: Adam Kallai kadam@inf.u-szeged.hu

view details

push time in 8 days

PR merged jerryscript-project/jerryscript

Fix implicit 'double' conversion reported by Clang 12.0.0 hacktoberfest-accepted

JerryScript-DCO-1.0-Signed-off-by: Adam Kallai kadam@inf.u-szeged.hu

+6 -6

2 comments

3 changed files

kaadam

pr closed time in 8 days

PullRequestReviewEvent

pull request commentbuserror/simavr

Fixes to HD44780

For the record: I've added a commit to this PR that handles the differences in memory segmentation of 1-line and 2-line displays.

akosthekiss

comment created time in 8 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 749f3458c3bd44446ead3c6f0e1d2f270c31ad1f

Handle the difference between 1 and 2-line displays in HD44780 If HD44780 is configured to have a single line of display, AC can be in the range of 0x00..0x00+79, while with two lines, it can be in the ranges 0x00..0x00+39 and 0x40..0x40+39.

view details

Akos Kiss

commit sha a6191731b02df94d7a96eb755dba25288bf49697

Fix typos in comments in HD44780

view details

Akos Kiss

commit sha 734c24fb4892f14184e86211f7ec092c4974a3bf

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART

view details

push time in 8 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 749f3458c3bd44446ead3c6f0e1d2f270c31ad1f

Handle the difference between 1 and 2-line displays in HD44780 If HD44780 is configured to have a single line of display, AC can be in the range of 0x00..0x00+79, while with two lines, it can be in the ranges 0x00..0x00+39 and 0x40..0x40+39.

view details

Akos Kiss

commit sha a6191731b02df94d7a96eb755dba25288bf49697

Fix typos in comments in HD44780

view details

push time in 8 days

push eventakosthekiss/simavr

Akos Kiss

commit sha ed0b5d4c6f4c363e67bb4ee246f428adcbf37077

Handle the difference between 1 and 2-line displays in HD44780 If HD44780 is configured to have a single line of display, AC can be in the range of 0x00..0x00+79, while with two lines, it can be in the ranges 0x00..0x00+39 and 0x40..0x40+39.

view details

Akos Kiss

commit sha 03a01c70dc1b001d06729a2ad42ad2310585d32e

Fix typos in comments in HD44780

view details

push time in 8 days

push eventakosthekiss/simavr

vintagepc

commit sha ecbd0e65585b4c509f41ebd99ed80c6cb86af6ab

Partial for TWI fixes (#137)

view details

Michel Pollet

commit sha 0e03bc6f48b078606b9a970594ee0ef82ffa0117

Merge pull request #401 from vintagepc/Fix-TWI-status-delay Fix high speed TWI delay calcs and ACK bug (#137)

view details

Akos Kiss

commit sha 90113530e96d36ae5cd7536102cbcf582b330ffd

Update links in README - Replace absolute links into github's buserror-uk/simavr repo with relative local links. (This also helps to follow-up the repo slug change to buserror/simavr.) - Turn URLs into markdown inline links. - Update mailing list URL to use https.

view details

Akos Kiss

commit sha 91c624af216b41240dfc22f3d96a076860c00a16

Fix the virtual memory of the HD44780 part In HD44780, the DDRAM has an address space of 0x80 bytes, while CGRAM has 0x40 bytes. To ensure their proper separation, the vram should have 0x80+0x40 bytes with the CGRAM starting at 0x80.

view details

Akos Kiss

commit sha 96553c9a9fd4b4ac02b6a14d24208ad52fabfad6

Fix cursor handling in segmented DDRAM of HD44780 HD44780 has only 80 bytes of DDRAM, which consists of two 40 bytes long segments. The segment starting at address 0x00 contains the data for the first line of the display, while the segment starting at address 0x40 contains the data for the second line of the display. This means that there are invalid ranges in the 7-bit address space of the DDRAM (0x00+40 .. 0x3f and 0x40+40 .. 0x7f). The cursor (address counter) of the HD44780 automatically "jumps over" these regions whenever auto-incremented/decremented. This commit implements this behaviour. Moreover, this commit also fixes the 4-lines mode. When in a 4-lines setup, the first 20 bytes of the first and the second memory segments control what is displayed in the first two lines, as usual. However, the second 20 bytes of the memory segments contain the data for the third and fourth lines of the display. This means that the starting addresses of lines 3 & 4 are 0x00+20 and 0x40+20.

view details

Akos Kiss

commit sha 9e127e535a3c45dadf09f3cd72aeaa9efab941ec

Fix Clear Screen implementation of HD44780 Datasheet mandates filling DDRAM with spaces, setting address counter to DDRAM address 0, and setting entry mode I/D to 1 (increment mode). The "filling with spaces" was implemented but the rest was missing. Now added.

view details

push time in 8 days

push eventakosthekiss/simavr

vintagepc

commit sha ecbd0e65585b4c509f41ebd99ed80c6cb86af6ab

Partial for TWI fixes (#137)

view details

Michel Pollet

commit sha 0e03bc6f48b078606b9a970594ee0ef82ffa0117

Merge pull request #401 from vintagepc/Fix-TWI-status-delay Fix high speed TWI delay calcs and ACK bug (#137)

view details

Akos Kiss

commit sha 90113530e96d36ae5cd7536102cbcf582b330ffd

Update links in README - Replace absolute links into github's buserror-uk/simavr repo with relative local links. (This also helps to follow-up the repo slug change to buserror/simavr.) - Turn URLs into markdown inline links. - Update mailing list URL to use https.

view details

Akos Kiss

commit sha 91c624af216b41240dfc22f3d96a076860c00a16

Fix the virtual memory of the HD44780 part In HD44780, the DDRAM has an address space of 0x80 bytes, while CGRAM has 0x40 bytes. To ensure their proper separation, the vram should have 0x80+0x40 bytes with the CGRAM starting at 0x80.

view details

Akos Kiss

commit sha 96553c9a9fd4b4ac02b6a14d24208ad52fabfad6

Fix cursor handling in segmented DDRAM of HD44780 HD44780 has only 80 bytes of DDRAM, which consists of two 40 bytes long segments. The segment starting at address 0x00 contains the data for the first line of the display, while the segment starting at address 0x40 contains the data for the second line of the display. This means that there are invalid ranges in the 7-bit address space of the DDRAM (0x00+40 .. 0x3f and 0x40+40 .. 0x7f). The cursor (address counter) of the HD44780 automatically "jumps over" these regions whenever auto-incremented/decremented. This commit implements this behaviour. Moreover, this commit also fixes the 4-lines mode. When in a 4-lines setup, the first 20 bytes of the first and the second memory segments control what is displayed in the first two lines, as usual. However, the second 20 bytes of the memory segments contain the data for the third and fourth lines of the display. This means that the starting addresses of lines 3 & 4 are 0x00+20 and 0x40+20.

view details

Akos Kiss

commit sha 9e127e535a3c45dadf09f3cd72aeaa9efab941ec

Fix Clear Screen implementation of HD44780 Datasheet mandates filling DDRAM with spaces, setting address counter to DDRAM address 0, and setting entry mode I/D to 1 (increment mode). The "filling with spaces" was implemented but the rest was missing. Now added.

view details

Akos Kiss

commit sha e40d2af499e4032e6d445ac232534c641fa946f8

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART

view details

push time in 8 days

push eventakosthekiss/simavr

Akos Kiss

commit sha da656d6e816cd85239bcc804dd12df0501515225

Ensure that verbosity is applied in avr-gcc recipes

view details

Akos Kiss

commit sha 2683b6a73a26a6dd3970a281f7bfcb220669696b

Remove execute permission from source and header files

view details

vintagepc

commit sha ecbd0e65585b4c509f41ebd99ed80c6cb86af6ab

Partial for TWI fixes (#137)

view details

Akos Kiss

commit sha 2f136017314453ff9ce9a80b108e939e48a334d9

Update/fix manual - Updated GitHub repository links. - Removed the requirement for a German babel language definition file. - Commented out missing references (citations of external manual and references to non-existing sections). - Added a .gitignore file to the directory of the manual to help git disregard temporary latex files.

view details

Akos Kiss

commit sha 40ceef5f6f868478cdf0fbf4aa34b8b52053c877

List git-ignored executables in one place

view details

Akos Kiss

commit sha 7c551e09d6e85045ec1433717f9f8c36a6906725

Add support for non-auto release to button This allows better control of key press length, if needed. To minimize negative effect on existng code, if the duration argument of button_press is non-zero, functionality is kept as is (i.e., using auto-release). If duration is set to zero, then button will have to be explicitly released using a new API function, button_release. If simulation uses GLUT, it may make use of glutKeyboardUpFunc and glutIgnoreKeyRepeat (in addition to glutKeyboardFunc found in existing examples) to have more exact control over button presses and releases.

view details

Akos Kiss

commit sha 82bc763e5e3939ce2ee376d2f66905ae63a1c8ba

Test-related maintenance - Ensure that make reports an error if any of the tests fail - Don't duplicate compilation commands only for the sake of verbosity control - Simplify recipe for .tst files - Drop outdated and unnecessary .gitignore from tests directory - Add the execution of tests to Travis CI

view details

bsekisser

commit sha e479fb39412f9fb7b1110facd6867997ef839e5d

Set udre flag when (re)enabling uart transmitter. modified: sim/avr_uart.c Previously, disabling the uart transmitter cleared the udrc interrupt and cleared the udre (udrc.raised) flag. Upon reenabling the transmitter, the udre flag is still clear signifying the buffer is full, thus waiting for the udr to clear via udre flag hangs.

view details

bsekisser

commit sha d8c91babc4016b239611b1b9da24f638abd10b10

Formatting and style corrections to avr_regbit.h

view details

bsekisser

commit sha 8ae36e163028e8611b0c3d662129d54a59eebbed

Remove kludge "avr_uart_regbit_clear" from uart modified: sim/avr_uart.c Change use of kludge function avr_uart_regbit_clear to avr_regbit_clear. modified: sim/sim_regbit.h Add check that avr_regbit_clear was passed a valid existing register.

view details

bsekisser

commit sha 0d7783fe663723d3fb280435ecf5648afae78841

fixup

view details

Michel Pollet

commit sha a3eb6c9b00645595ce6307a8ea56279c185a36c4

Merge pull request #409 from akosthekiss/button-release Add support for non-auto release to button

view details

Michel Pollet

commit sha b88c1201026123a3416d36e033b73d88eb0b6dec

Merge pull request #397 from akosthekiss/remove-exec Remove execute permission from source and header files

view details

Michel Pollet

commit sha 8eaeb516c2691b8b7a1c5b10015110c9db6c01ee

Merge pull request #396 from akosthekiss/makecommon-avrgcc-verbose Ensure that verbosity is applied in avr-gcc recipes

view details

Michel Pollet

commit sha 2bb4e6b6b38f1fe134db44539cc08698ab47acbb

Merge pull request #405 from akosthekiss/update-fix-manual Update/fix manual

view details

Michel Pollet

commit sha 26ff19d215552acaf9545b3a6af7f02fdbf22392

Merge pull request #407 from akosthekiss/gitignore-maintenance List git-ignored executables in one place

view details

Michel Pollet

commit sha 54a55cc2f0093103a9bd77d17cb285d198553fd0

Merge pull request #411 from bsekisser/uart_raise_udr_raised_with_tx_enable Set udre flag when (re)enabling uart transmitter.

view details

Michel Pollet

commit sha 877842fef61e27d0cae3ce2bc8578a88b5429ee3

Merge pull request #412 from bsekisser/avr_regbit_h_file_format_corrections Formatting and style corrections to avr_regbit.h

view details

Michel Pollet

commit sha 4dd8619a9c26b7094a10c08ee2d2d584fdb4cc84

Merge pull request #410 from akosthekiss/make-tests Test-related maintenance

view details

Michel Pollet

commit sha 753006e5a9fc3fbea5444088f9e962bcfb9d73e0

Merge pull request #413 from bsekisser/sim_regbit_clear_check_valid_reg Remove kludge "avr_uart_regbit_clear" from uart

view details

push time in 8 days

pull request commentbuserror/simavr

Fixes to HD44780

The original implementation has several issues IMO, let me try to point them out.

This is how the "Set DDRAM address" instruction is implemented:

// Set	DDRAM address
case 7:		// 1 ADD ADD ADD ADD ADD ADD ADD
  b->cursor = b->datapins & 0x7f;
  break;

This extracts the 7-bit address from the instruction byte and stores it directly in the cursor (which corresponds to the Address Counter (AC) of the HD44780). The size of the AC and thus the address space is 7-bit indeed. So, the "user" (the code running on the AVR) could pass any 7-bit value as the operand of the instruction but they must know that not all of the address space is valid. If the user conforms to the datasheet, invalid addresses will not be passed, of course. But then there will be holes, as the user will skip the invalid addresses.

This is how the virtual memory of the HD44780 is defined:

uint8_t  vram[80 + 64];

I assume that the intent was to have 80 bytes for the DDRAM and 64 bytes for the CGRAM. But because of the implementation of the "Set DDRAM instruction", if the user uses valid addresses, then they may set the cursor to an index that points beyond 80 (e.g., last byte of the memory of the second line at address 103 (0x40 + 39)). This will not cause memory corruption because it is still within the bounds of the array, but it actually overwrites CGRAM memory (I guess it is unintended). I think that this hasn't been revealed yet because custom characters are not handled by the GLUT-based UI component.

So, either the implementation of the "Set DDRAM address" should transform the 7-bit address operand of the instruction to a vram index in the range of 0..79, or the vram should be extended to have 128 bytes for the DDRAM but not using actually all of them. I chose the second option. Those extra bytes are not a big cost on the host machine. (Moreover, there is also a "Read busy flag & address" instruction. That returns the value of the AC. If the cursor contains a transformed index, then the reverse has to be applied during the read operation.)

This is how the "Set CGRAM address" instruction is implemented:

// Set	CGRAM address
case 6:		// 0 1 ADD ADD ADD ADD ADD ADD ADD
  b->cursor = 64 + (b->datapins & 0x3f);
  break;

Here, the 6-bit address operand is offset by 64. However, this way it will write into DDRAM memory (if my assumption about the layout of vram was correct). So, this should be either 80 (if cursor is a hole-less index in the DDRAM segment of vram, not the actual AC) or 0x80 (if cursor is the AC when referring to the DDRAM).

Similar issue when reading the AC:

b->readpins = b->cursor < 80 ? b->cursor : b->cursor-64;

This should be either b->cursor < 80 ? b->cursor : b->cursor-80 or b->cursor < 0x80 ? b->cursor : b->cursor-0x80.

One extra note: I just realized that my suggestion does not handle one case correctly, when the display has a single line. Then, the memory is contiguous, not segmented.

Bottom line: So, for a 1-line display, the valid addresses are in the range of 0x00..0x4f, while for a 2-line display the valid ranges of addresses are 0x00..0x27 and 0x40..0x67. And this is totally visible to user code as these are the addresses that have to be passed as operands.

(Sorry for the longish comment. I just tried to shed some light on the "why". I hope I did not make it just more confusing.)

akosthekiss

comment created time in 9 days

push eventakosthekiss/simavr

Akos Kiss

commit sha da656d6e816cd85239bcc804dd12df0501515225

Ensure that verbosity is applied in avr-gcc recipes

view details

Akos Kiss

commit sha 2683b6a73a26a6dd3970a281f7bfcb220669696b

Remove execute permission from source and header files

view details

Akos Kiss

commit sha 2f136017314453ff9ce9a80b108e939e48a334d9

Update/fix manual - Updated GitHub repository links. - Removed the requirement for a German babel language definition file. - Commented out missing references (citations of external manual and references to non-existing sections). - Added a .gitignore file to the directory of the manual to help git disregard temporary latex files.

view details

Akos Kiss

commit sha 40ceef5f6f868478cdf0fbf4aa34b8b52053c877

List git-ignored executables in one place

view details

Akos Kiss

commit sha 7c551e09d6e85045ec1433717f9f8c36a6906725

Add support for non-auto release to button This allows better control of key press length, if needed. To minimize negative effect on existng code, if the duration argument of button_press is non-zero, functionality is kept as is (i.e., using auto-release). If duration is set to zero, then button will have to be explicitly released using a new API function, button_release. If simulation uses GLUT, it may make use of glutKeyboardUpFunc and glutIgnoreKeyRepeat (in addition to glutKeyboardFunc found in existing examples) to have more exact control over button presses and releases.

view details

Akos Kiss

commit sha 82bc763e5e3939ce2ee376d2f66905ae63a1c8ba

Test-related maintenance - Ensure that make reports an error if any of the tests fail - Don't duplicate compilation commands only for the sake of verbosity control - Simplify recipe for .tst files - Drop outdated and unnecessary .gitignore from tests directory - Add the execution of tests to Travis CI

view details

bsekisser

commit sha e479fb39412f9fb7b1110facd6867997ef839e5d

Set udre flag when (re)enabling uart transmitter. modified: sim/avr_uart.c Previously, disabling the uart transmitter cleared the udrc interrupt and cleared the udre (udrc.raised) flag. Upon reenabling the transmitter, the udre flag is still clear signifying the buffer is full, thus waiting for the udr to clear via udre flag hangs.

view details

bsekisser

commit sha d8c91babc4016b239611b1b9da24f638abd10b10

Formatting and style corrections to avr_regbit.h

view details

bsekisser

commit sha 8ae36e163028e8611b0c3d662129d54a59eebbed

Remove kludge "avr_uart_regbit_clear" from uart modified: sim/avr_uart.c Change use of kludge function avr_uart_regbit_clear to avr_regbit_clear. modified: sim/sim_regbit.h Add check that avr_regbit_clear was passed a valid existing register.

view details

bsekisser

commit sha 0d7783fe663723d3fb280435ecf5648afae78841

fixup

view details

Michel Pollet

commit sha a3eb6c9b00645595ce6307a8ea56279c185a36c4

Merge pull request #409 from akosthekiss/button-release Add support for non-auto release to button

view details

Michel Pollet

commit sha b88c1201026123a3416d36e033b73d88eb0b6dec

Merge pull request #397 from akosthekiss/remove-exec Remove execute permission from source and header files

view details

Michel Pollet

commit sha 8eaeb516c2691b8b7a1c5b10015110c9db6c01ee

Merge pull request #396 from akosthekiss/makecommon-avrgcc-verbose Ensure that verbosity is applied in avr-gcc recipes

view details

Michel Pollet

commit sha 2bb4e6b6b38f1fe134db44539cc08698ab47acbb

Merge pull request #405 from akosthekiss/update-fix-manual Update/fix manual

view details

Michel Pollet

commit sha 26ff19d215552acaf9545b3a6af7f02fdbf22392

Merge pull request #407 from akosthekiss/gitignore-maintenance List git-ignored executables in one place

view details

Michel Pollet

commit sha 54a55cc2f0093103a9bd77d17cb285d198553fd0

Merge pull request #411 from bsekisser/uart_raise_udr_raised_with_tx_enable Set udre flag when (re)enabling uart transmitter.

view details

Michel Pollet

commit sha 877842fef61e27d0cae3ce2bc8578a88b5429ee3

Merge pull request #412 from bsekisser/avr_regbit_h_file_format_corrections Formatting and style corrections to avr_regbit.h

view details

Michel Pollet

commit sha 4dd8619a9c26b7094a10c08ee2d2d584fdb4cc84

Merge pull request #410 from akosthekiss/make-tests Test-related maintenance

view details

Michel Pollet

commit sha 753006e5a9fc3fbea5444088f9e962bcfb9d73e0

Merge pull request #413 from bsekisser/sim_regbit_clear_check_valid_reg Remove kludge "avr_uart_regbit_clear" from uart

view details

Akos Kiss

commit sha 06b804a7f050bec2fb9f0b79423327896f20cf0d

Update links in README - Replace absolute links into github's buserror-uk/simavr repo with relative local links. (This also helps to follow-up the repo slug change to buserror/simavr.) - Turn URLs into markdown inline links. - Update mailing list URL to use https.

view details

push time in 9 days

push eventakosthekiss/simavr

Akos Kiss

commit sha da656d6e816cd85239bcc804dd12df0501515225

Ensure that verbosity is applied in avr-gcc recipes

view details

Akos Kiss

commit sha 2683b6a73a26a6dd3970a281f7bfcb220669696b

Remove execute permission from source and header files

view details

Akos Kiss

commit sha 2f136017314453ff9ce9a80b108e939e48a334d9

Update/fix manual - Updated GitHub repository links. - Removed the requirement for a German babel language definition file. - Commented out missing references (citations of external manual and references to non-existing sections). - Added a .gitignore file to the directory of the manual to help git disregard temporary latex files.

view details

Akos Kiss

commit sha 40ceef5f6f868478cdf0fbf4aa34b8b52053c877

List git-ignored executables in one place

view details

Akos Kiss

commit sha 7c551e09d6e85045ec1433717f9f8c36a6906725

Add support for non-auto release to button This allows better control of key press length, if needed. To minimize negative effect on existng code, if the duration argument of button_press is non-zero, functionality is kept as is (i.e., using auto-release). If duration is set to zero, then button will have to be explicitly released using a new API function, button_release. If simulation uses GLUT, it may make use of glutKeyboardUpFunc and glutIgnoreKeyRepeat (in addition to glutKeyboardFunc found in existing examples) to have more exact control over button presses and releases.

view details

Akos Kiss

commit sha 82bc763e5e3939ce2ee376d2f66905ae63a1c8ba

Test-related maintenance - Ensure that make reports an error if any of the tests fail - Don't duplicate compilation commands only for the sake of verbosity control - Simplify recipe for .tst files - Drop outdated and unnecessary .gitignore from tests directory - Add the execution of tests to Travis CI

view details

bsekisser

commit sha e479fb39412f9fb7b1110facd6867997ef839e5d

Set udre flag when (re)enabling uart transmitter. modified: sim/avr_uart.c Previously, disabling the uart transmitter cleared the udrc interrupt and cleared the udre (udrc.raised) flag. Upon reenabling the transmitter, the udre flag is still clear signifying the buffer is full, thus waiting for the udr to clear via udre flag hangs.

view details

bsekisser

commit sha d8c91babc4016b239611b1b9da24f638abd10b10

Formatting and style corrections to avr_regbit.h

view details

bsekisser

commit sha 8ae36e163028e8611b0c3d662129d54a59eebbed

Remove kludge "avr_uart_regbit_clear" from uart modified: sim/avr_uart.c Change use of kludge function avr_uart_regbit_clear to avr_regbit_clear. modified: sim/sim_regbit.h Add check that avr_regbit_clear was passed a valid existing register.

view details

bsekisser

commit sha 0d7783fe663723d3fb280435ecf5648afae78841

fixup

view details

Michel Pollet

commit sha a3eb6c9b00645595ce6307a8ea56279c185a36c4

Merge pull request #409 from akosthekiss/button-release Add support for non-auto release to button

view details

Michel Pollet

commit sha b88c1201026123a3416d36e033b73d88eb0b6dec

Merge pull request #397 from akosthekiss/remove-exec Remove execute permission from source and header files

view details

Michel Pollet

commit sha 8eaeb516c2691b8b7a1c5b10015110c9db6c01ee

Merge pull request #396 from akosthekiss/makecommon-avrgcc-verbose Ensure that verbosity is applied in avr-gcc recipes

view details

Michel Pollet

commit sha 2bb4e6b6b38f1fe134db44539cc08698ab47acbb

Merge pull request #405 from akosthekiss/update-fix-manual Update/fix manual

view details

Michel Pollet

commit sha 26ff19d215552acaf9545b3a6af7f02fdbf22392

Merge pull request #407 from akosthekiss/gitignore-maintenance List git-ignored executables in one place

view details

Michel Pollet

commit sha 54a55cc2f0093103a9bd77d17cb285d198553fd0

Merge pull request #411 from bsekisser/uart_raise_udr_raised_with_tx_enable Set udre flag when (re)enabling uart transmitter.

view details

Michel Pollet

commit sha 877842fef61e27d0cae3ce2bc8578a88b5429ee3

Merge pull request #412 from bsekisser/avr_regbit_h_file_format_corrections Formatting and style corrections to avr_regbit.h

view details

Michel Pollet

commit sha 4dd8619a9c26b7094a10c08ee2d2d584fdb4cc84

Merge pull request #410 from akosthekiss/make-tests Test-related maintenance

view details

Michel Pollet

commit sha 753006e5a9fc3fbea5444088f9e962bcfb9d73e0

Merge pull request #413 from bsekisser/sim_regbit_clear_check_valid_reg Remove kludge "avr_uart_regbit_clear" from uart

view details

Akos Kiss

commit sha 06b804a7f050bec2fb9f0b79423327896f20cf0d

Update links in README - Replace absolute links into github's buserror-uk/simavr repo with relative local links. (This also helps to follow-up the repo slug change to buserror/simavr.) - Turn URLs into markdown inline links. - Update mailing list URL to use https.

view details

push time in 9 days

delete branch akosthekiss/simavr

delete branch : make-tests

delete time in 9 days

delete branch akosthekiss/simavr

delete branch : button-release

delete time in 9 days

delete branch akosthekiss/simavr

delete branch : gitignore-maintenance

delete time in 9 days

delete branch akosthekiss/simavr

delete branch : update-fix-manual

delete time in 9 days

delete branch akosthekiss/simavr

delete branch : remove-exec

delete time in 9 days

delete branch akosthekiss/simavr

delete branch : makecommon-avrgcc-verbose

delete time in 9 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 481415e09cd40de7f6d99c799592f49c4f58e962

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART

view details

push time in 10 days

push eventakosthekiss/simavr

Akos Kiss

commit sha d48b0944075f7ae6c7131c03aa1e722387538e43

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART

view details

push time in 10 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 125a74f9e02ba8c3ddb76b8691528d535921ba46

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART

view details

push time in 11 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 02d2f30187af677108647abc7a698a99d3484034

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART

view details

push time in 11 days

push eventakosthekiss/simavr

Akos Kiss

commit sha dec9ec2701cf8db3f5addf50b14ff48b32dc4c55

Test-related maintenance - Ensure that make reports an error if any of the tests fail - Don't duplicate compilation commands only for the sake of verbosity control - Simplify recipe for .tst files - Drop outdated and unnecessary .gitignore from tests directory - Add the execution of tests to Travis CI

view details

Akos Kiss

commit sha 3c24c8c374f584ce59d74c285119a99f9be4f5b2

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART - Add debugger support

view details

push time in 11 days

push eventakosthekiss/simavr

Akos Kiss

commit sha dec9ec2701cf8db3f5addf50b14ff48b32dc4c55

Test-related maintenance - Ensure that make reports an error if any of the tests fail - Don't duplicate compilation commands only for the sake of verbosity control - Simplify recipe for .tst files - Drop outdated and unnecessary .gitignore from tests directory - Add the execution of tests to Travis CI

view details

push time in 11 days

PR opened buserror/simavr

Test-related maintenance
  • Ensure that make reports an error if any of the tests fail
  • Don't duplicate compilation commands only for the sake of verbosity control
  • Simplify recipe for .tst files
  • Drop outdated and unnecessary .gitignore from tests directory
  • Add the execution of tests to Travis CI
+11 -20

0 comment

3 changed files

pr created time in 11 days

create barnchakosthekiss/simavr

branch : make-tests

created branch time in 11 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 9514c74ed808152dadd5a9c7d817641d83f59d6d

Add support for non-auto release to button This allows better control of key press length, if needed. To minimize negative effect on existng code, if the duration argument of button_press is non-zero, functionality is kept as is (i.e., using auto-release). If duration is set to zero, then button will have to be explicitly released using a new API function, button_release. If simulation uses GLUT, it may make use of glutKeyboardUpFunc and glutIgnoreKeyRepeat (in addition to glutKeyboardFunc found in existing examples) to have more exact control over button presses and releases.

view details

Akos Kiss

commit sha 16ac347b5aa37f435d002fecd2bd36429546fc61

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART - Add debugger support

view details

push time in 11 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 9514c74ed808152dadd5a9c7d817641d83f59d6d

Add support for non-auto release to button This allows better control of key press length, if needed. To minimize negative effect on existng code, if the duration argument of button_press is non-zero, functionality is kept as is (i.e., using auto-release). If duration is set to zero, then button will have to be explicitly released using a new API function, button_release. If simulation uses GLUT, it may make use of glutKeyboardUpFunc and glutIgnoreKeyRepeat (in addition to glutKeyboardFunc found in existing examples) to have more exact control over button presses and releases.

view details

push time in 11 days

PR opened buserror/simavr

Add support for non-auto release to button

This allows better control of key press length, if needed.

To minimize negative effect on existng code, if the duration argument of button_press is non-zero, functionality is kept as is (i.e., using auto-release). If duration is set to zero, then button will have to be explicitly released using a new API function, button_release.

If simulation uses GLUT, it may make use of glutKeyboardUpFunc and glutIgnoreKeyRepeat (in addition to glutKeyboardFunc found in existing examples) to have more exact control over button presses and releases.

+25 -9

0 comment

2 changed files

pr created time in 11 days

create barnchakosthekiss/simavr

branch : button-release

created branch time in 11 days

push eventakosthekiss/simavr

Akos Kiss

commit sha d80070348ab931ba6607908544a03261b2de465f

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM - Implemented pushbutton part without auto-release TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART - Add debugger support

view details

push time in 11 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 998353802285300612909d40fc16f3ce87ee6966

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART - Add debugger support

view details

push time in 11 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 3413baf0641f92a8a12459992695feb77683167f

Fix Clear Screen implementation of HD44780 Datasheet mandates filling DDRAM with spaces, setting address counter to DDRAM address 0, and setting entry mode I/D to 1 (increment mode). The "filling with spaces" was implemented but the rest was missing. Now added.

view details

Akos Kiss

commit sha dec7e43f8349ed7f9791a4c32e7af2efad881a30

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART - Add debugger support

view details

push time in 13 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 3413baf0641f92a8a12459992695feb77683167f

Fix Clear Screen implementation of HD44780 Datasheet mandates filling DDRAM with spaces, setting address counter to DDRAM address 0, and setting entry mode I/D to 1 (increment mode). The "filling with spaces" was implemented but the rest was missing. Now added.

view details

push time in 13 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 3e33b6fabf7b34f126e48a3dd54909cac1699cd6

Fix Clear Screen implementation of HD44780 Datasheet mandates filling DDRAM with spaces, setting address counter to DDRAM address 0, and setting entry mode I/D to 1 (increment mode). The "filling with spaces" was implemented but the rest was missing. Now added.

view details

push time in 13 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 9a8fc0fff43d8b3fcef25dba59c48d0db40a6289

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - get rid of binary integer literals - Add LED - Add UART - Add debugger support

view details

push time in 13 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 7a269be6fb51c20174f37055c9af58763fd47a3b

Fix the virtual memory of the HD44780 part In HD44780, the DDRAM has an address space of 0x80 bytes, while CGRAM has 0x40 bytes. To ensure their proper separation, the vram should have 0x80+0x40 bytes with the CGRAM starting at 0x80.

view details

Akos Kiss

commit sha 8ff494638aa9fe387d33d34eb7e2df6982d87a7d

Fix cursor handling in segmented DDRAM of HD44780 HD44780 has only 80 bytes of DDRAM, which consists of two 40 bytes long segments. The segment starting at address 0x00 contains the data for the first line of the display, while the segment starting at address 0x40 contains the data for the second line of the display. This means that there are invalid ranges in the 7-bit address space of the DDRAM (0x00+40 .. 0x3f and 0x40+40 .. 0x7f). The cursor (address counter) of the HD44780 automatically "jumps over" these regions whenever auto-incremented/decremented. This commit implements this behaviour. Moreover, this commit also fixes the 4-lines mode. When in a 4-lines setup, the first 20 bytes of the first and the second memory segments control what is displayed in the first two lines, as usual. However, the second 20 bytes of the memory segments contain the data for the third and fourth lines of the display. This means that the starting addresses of lines 3 & 4 are 0x00+20 and 0x40+20.

view details

Akos Kiss

commit sha 3434620e621449f0ffe5a09d13f78f59b16ec5f3

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - duplicate cgram characters from 0-7 to 8-15 - get rid of binary integer literals - Add LED - Add UART - Add debugger support

view details

push time in 13 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 7a269be6fb51c20174f37055c9af58763fd47a3b

Fix the virtual memory of the HD44780 part In HD44780, the DDRAM has an address space of 0x80 bytes, while CGRAM has 0x40 bytes. To ensure their proper separation, the vram should have 0x80+0x40 bytes with the CGRAM starting at 0x80.

view details

Akos Kiss

commit sha 8ff494638aa9fe387d33d34eb7e2df6982d87a7d

Fix cursor handling in segmented DDRAM of HD44780 HD44780 has only 80 bytes of DDRAM, which consists of two 40 bytes long segments. The segment starting at address 0x00 contains the data for the first line of the display, while the segment starting at address 0x40 contains the data for the second line of the display. This means that there are invalid ranges in the 7-bit address space of the DDRAM (0x00+40 .. 0x3f and 0x40+40 .. 0x7f). The cursor (address counter) of the HD44780 automatically "jumps over" these regions whenever auto-incremented/decremented. This commit implements this behaviour. Moreover, this commit also fixes the 4-lines mode. When in a 4-lines setup, the first 20 bytes of the first and the second memory segments control what is displayed in the first two lines, as usual. However, the second 20 bytes of the memory segments contain the data for the third and fourth lines of the display. This means that the starting addresses of lines 3 & 4 are 0x00+20 and 0x40+20.

view details

push time in 13 days

push eventakosthekiss/simavr

Akos Kiss

commit sha cb6fcbead0826fdbe54dc0b2218eb77d229c8248

Fix the virtual memory of the HD44780 part In HD44780, the DDRAM has an address space of 0x80 bytes, while CGRAM has 0x40 bytes. To ensure their proper separation, the vram should have 0x80+0x40 bytes with the CGRAM starting at 0x80.

view details

Akos Kiss

commit sha f97e7f0ee0efe49f2adee55cf21e6ff179720d79

Fix cursor handling in segmented DDRAM of HD44780 HD44780 has only 80 bytes of DDRAM, which consists of two 40 bytes long segments. The segment starting at address 0x00 contains the data for the first line of the display, while the segment starting at address 0x40 contains the data for the second line of the display. This means that there are invalid ranges in the 7-bit address space of the DDRAM (0x00+40 .. 0x3f and 0x40+40 .. 0x7f). The cursor (address counter) of the HD44780 automatically "jumps over" these regions whenever auto-incremented/decremented. This commit implements this behaviour. Moreover, this commit also fixes the 4-lines mode. When in a 4-lines setup, the first 20 bytes of the first and the second memory segments control what is displayed in the first two lines, as usual. However, the second 20 bytes of the memory segments contain the data for the third and fourth lines of the display. This means that the starting addresses of lines 3 & 4 are 0x00+20 and 0x40+20.

view details

push time in 13 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 37d9eafe42082081046206d5aab44b8e9fa7a6bb

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - duplicate cgram characters from 0-7 to 8-15 - get rid of binary integer literals - Add LED - Add UART - Add debugger support

view details

push time in 14 days

push eventakosthekiss/simavr

Akos Kiss

commit sha 017ad6c53d2371589989dd46941068287a51b09b

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part - add all character patterns (from ROM Code A00) - duplicate cgram characters from 0-7 to 8-15 - get rid of binary integer literals - Add LED - Add UART - Add debugger support

view details

push time in 14 days

create barnchakosthekiss/simavr

branch : unofficial

created branch time in 14 days

push eventakosthekiss/simavr

Akos Kiss

commit sha e286051b6a09d5d81329bf88b424d6d398e5bd19

Ensure that verbosity is applied in avr-gcc recipes

view details

Akos Kiss

commit sha a0dfab9ddd0b10dabf843ffa84059f61d2dd7927

Remove execute permission from source and header files

view details

Akos Kiss

commit sha 60e74a509a72bd25a34e596694b3723290985d74

Update links in README - Replace absolute links into github's buserror-uk/simavr repo with relative local links. (This also helps to follow-up the repo slug change to buserror/simavr.) - Turn URLs into markdown inline links. - Update mailing list URL to use https.

view details

Akos Kiss

commit sha 79cf881e0ad8bdaf78d45fbe720a18f40f536b83

Update/fix manual - Updated GitHub repository links. - Removed the requirement for a German babel language definition file. - Commented out missing references (citations of external manual and references to non-existing sections). - Added a .gitignore file to the directory of the manual to help git disregard temporary latex files.

view details

Akos Kiss

commit sha 5c2ad827a27fecca83c195806e485c36a31a5159

List git-ignored executables in one place

view details

Akos Kiss

commit sha 0c445ea00b923aa6ce920575a5939b36e1f165ec

Fix the virtual memory of the HD44780 part In HD44780, the DDRAM has 0x80 bytes (with lines starting at 0x00, 0x40, 0x20, 0x60), while CGRAM has 0x40 bytes. So, the vram should have 0x80+0x40 bytes with the CGRAM starting at 0x80.

view details

Akos Kiss

commit sha b47c7a35dfd36d38b705d6cf0d6736553acdaf0f

Experimental implementation of the Olimex AVR-MT128 development board - Board simulation supports LCD and buttons. - Two example firmware: Olimex's display example and a Mini Tetris game - Extended LCD part with support for CGRAM TODOs: - Improve LCD part to deal with 5x8 characters (now: 5x7 only) - Add LED - Add UART - Add debugger support

view details

push time in 14 days

create barnchakosthekiss/grammarinator

branch : fix-lint-issues

created branch time in 15 days

push eventakosthekiss/grammarinator

Akos Kiss

commit sha 480f82ed2395e0155ba3ba24b3266843dd2a5fbb

Rework the processing of charsets Fixed inverted/negated/not-sets to use "dot" as the base charset (always subtracted the specified charset from the set of printable unicode characters previously, even if "dot" was the set of printable ASCII characters). This required the move of the computation of the charsets from runtime to processing-time. Which enabled the simplification of the internal graph representation of charsets and token/string literals. The codegen template was adapted to the changed internal graph representation. Also realized that Generator base class was still in charge of randomly selecting characters from charsets. However, random aspects (alternatives, quantifiers) are the responsibilities of models. So, extended the models API with a method to deal with charsets and moved the existing functionality from Generator to DefaultModel. The codegen template was adapted to use the new API.

view details

Akos Kiss

commit sha 493fc17e340cac05af70323091ee441e7d0b4e4b

Ensure proper maintenance of child-parent relation in runtime tree

view details

Akos Kiss

commit sha bfde275cc9122f4ebafcb22b22b2f64a95a9e0f4

Improve README - Update requirements (drop ANTLR, as its jar file is automatically downloaded by ANTLeRinator, so it is not a direct requirement; but add Java as it is needed even by grammarinator-process). - Unify how Grammarinator is written (italics and capitalize first letter). - Better highlight notes (but use block quotes, as Github does not render the note directive or any other admonition). - In command-line examples, indent continuation lines for readability (and get command-line argument order in sync across examples). - Some wording improvements.

view details

push time in 15 days

PR opened buserror/simavr

List git-ignored executables in one place
+1 -1

0 comment

2 changed files

pr created time in 16 days

create barnchakosthekiss/simavr

branch : gitignore-maintenance

created branch time in 16 days

PR opened buserror/simavr

Fix the virtual memory of the HD44780 part

In HD44780, the DDRAM has 0x80 bytes (with lines starting at 0x00, 0x40, 0x20, 0x60), while CGRAM has 0x40 bytes. So, the vram should have 0x80+0x40 bytes with the CGRAM starting at 0x80.

+9 -10

0 comment

2 changed files

pr created time in 16 days

create barnchakosthekiss/simavr

branch : fix-hd44780-memory

created branch time in 17 days

PR opened buserror/simavr

Update/fix manual
  • Updated GitHub repository links.
  • Removed the requirement for a German babel language definition file.
  • Commented out missing references (citations of external manual and references to non-existing sections).
  • Added a .gitignore file to the directory of the manual to help git disregard temporary latex files.
+21 -11

0 comment

5 changed files

pr created time in 17 days

create barnchakosthekiss/simavr

branch : update-fix-manual

created branch time in 17 days

create barnchakosthekiss/simavr

branch : olimex-avr-mt128

created branch time in 20 days

PR closed jerryscript-project/jerryscript

improve docs invalid

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

Before submitting a PR, please, make sure that:

  • Changes are in a separate branch, not in master.
  • The branch contains only one commit on top of master (if not, squash them into one commit).
  • The commit has a descriptive commit message with a concise title (first line).
  • The commit message contains fixes #XXXX or closes #XXXX to auto-close the issue(s) that the PR fixes (if any).
  • Tests for the changes have been added (for bug fixes / features).
  • Documentation has been added / updated (if applicable).
  • All new and existing tests passed locally (if not, fix them first and amend the commit).

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

+3 -0

2 comments

1 changed file

pranali27-web

pr closed time in 21 days

pull request commentjerryscript-project/jerryscript

improve docs

Obvious Hacktoberfest spam. Labeled as invalid. Closing.

If you think that this PR has been closed in error, please explain in a comment.

pranali27-web

comment created time in 21 days

PR opened buserror/simavr

Update links in README
  • Replace absolute links into github's buserror-uk/simavr repo with relative local links. (This also helps to follow-up the repo slug change to buserror/simavr.)
  • Turn URLs into markdown inline links.
  • Update mailing list URL to use https.
+6 -6

0 comment

1 changed file

pr created time in a month

create barnchakosthekiss/simavr

branch : readme-links

created branch time in a month

create barnchakosthekiss/simavr

branch : remove-exec

created branch time in a month

create barnchakosthekiss/simavr

branch : makecommon-avrgcc-verbose

created branch time in a month

fork akosthekiss/simavr

simavr is a lean, mean and hackable AVR simulator for linux & OSX

fork in a month

delete branch akosthekiss/ossapps

delete branch : patch-1

delete time in a month

PR opened Fitbit/ossapps

Add Clock64 to clock face list
+1 -0

0 comment

1 changed file

pr created time in 2 months

push eventakosthekiss/ossapps

Akos Kiss

commit sha ae09b3832d54df14b48f323682336515125dfef9

Add Clock64 to clock face list

view details

push time in 2 months

fork akosthekiss/ossapps

A non-exhaustive list of open sourced clock faces, applications and modules from the community.

fork in 2 months

push eventakosthekiss/clock64

Akos Kiss

commit sha 021e5b833029842ab36e0350111028fd53ec5c94

Add link to Fitbit Gallery

view details

push time in 2 months

push eventakosthekiss/0b1100oclock

Akos Kiss

commit sha 3e75ea29c0178934503a4252f239b11da0f7696b

Add link to Fitbit Gallery

view details

push time in 2 months

push eventakosthekiss/0b1100oclock

Akos Kiss

commit sha 8ce6d64df8c1488837a3ab77483376ed2bb85ae4

Update package.json - Add Versa 2 (mira) to build targets. - Bump SDK to 4.1.0. - Add debug script. - Update dependencies in package-lock.

view details

push time in 2 months

created tagakosthekiss/clock64

tag1.0.0

Clock64 - a C64-inspired Clockface for Fitbit

created time in 2 months

create barnchakosthekiss/clock64

branch : master

created branch time in 2 months

created repositoryakosthekiss/clock64

Clock64 - a C64-inspired Clockface for Fitbit

created time in 2 months

issue commentjerryscript-project/jerryscript

Memory corruption in in opfunc_for_in (jerryscript/jerry-core/vm/opcodes.c:350)

Ah, just spotted some misleading info in the report:

  • version: v2.3.0 is incorrect, jerry --version shows Version: 2.4.0 (5b3f01af) for this commit. I.e., this report is not against the release but against latest master.
  • --profile=es2015-subset should not be used anymore, it is deprecated (it was last non-deprecated in 2.3.0). Currently, the successor profile name is es.next. However, it doesn't have to be declared explicitly as it is the default profile now.
Aurorainfinity

comment created time in 2 months

issue commentjerryscript-project/jerryscript

Memory corruption in in opfunc_for_in (jerryscript/jerry-core/vm/opcodes.c:350)

Confirmed to reproduce on latest master (5b3f01af9d3c134b90eaeefe1fb8a05e0a6c1464), build platform Ubuntu 18.04.4 LTS (Linux 4.15.0-112-generic x86_64), gcc compiler 7.5.0, with build command:

tools/build.py --lto=off --debug --logging=on --compile-flag=-fsanitize=address --stack-limit=15
Aurorainfinity

comment created time in 2 months

push eventakosthekiss/jerryscript

Szilagyi Adam

commit sha ccca998f43a73a5829484bc2c4a9b397714f0fb1

Implement Proxy object [[Set]] internal method (#3605) The algorithm is based on ECMA-262 v6, 9.5.9 JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

view details

Szilagyi Adam

commit sha 56b9f098ab008f2942dd7fae69698b50b70cc378

Impement Proxy object [[isExtensible]] internal method (#3599) The algorithm is based on ECMA-262 v6, 9.5.3 JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

view details

Robert Fancsik

commit sha bfd2639634bf47330719b0ff4ca48ce2b3123398

Rework the core of class parsing/runtime semantic (#3598) Changes: - Use the pre-scanner to provide information for the parser about the existence of the class constructor - The allocation of the super declarative environment is no longer needed - The VM frame context holds the information about the this binding status - Reduce the number of class related VM/CBC instructions - Improve ecma_op_function_{construct, call} to properly set new.target JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

view details

Robert Fancsik

commit sha 1a8276c4935ce88e39f2bc00eb991ceeff7494eb

Conditional expression should be parsed as AssignmentExpression (#3610) This patch fixes #3553 and fixes #3608. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

view details

Szilagyi Adam

commit sha bc7c39d893671e087ac90b8044c15ea78e4761d9

Implement helper method for Proxy object internals (#3612) This method generally does the steps 2-5 in the proxy internal methods JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

view details

Robert Fancsik

commit sha 7f6779532647bbd9093e1c6eec9ff53ef516ee83

Spread operator should not update the scanner context's binding type (#3613) This patch fixes #3595. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

view details

Robert Fancsik

commit sha c305aee80f093d33cef962482606119d3cc48b6b

Fix for-in/off block context initialization for empty destructuring patterns (#3614) This patch fixes #3611. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

view details

Szilagyi Adam

commit sha 7ea93aff4ceeb44c039eaa871253651b31dd7b53

Fix assignment validation in parser_append_binary_token (#3594) Fixes #3589 JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

view details

Zoltan Herczeg

commit sha 1cfda262bddfb2b541ddd7638a7b41b707499ed1

Catch paramter must not be scanned as function in ES5.1 (#3618) Fixes #3554 JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com

view details

Roland Takacs

commit sha 51a9575fd03f40a459789056e4c66832cf371465

Use array based storage in container objects (#3600) Currently, collections use object based solutions for storing elements and iterating on them. If an element is deleted and re-inserted, the storage position is the same as before so the iteration order is wrong. This patch replaces the object based storage with an array based solution that helps to store and iterate elements as expected. JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs@inf.u-szeged.hu

view details

Szilagyi Adam

commit sha 85fced26323f0aa3d136829b7f4c19dbe4b1a393

Impelement Proxy object [[preventExtensions]] internal method (#3620) The algorithm is based on ECMA-262 v6, 9.5.4 JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

view details

Szilagyi Adam

commit sha b2e54e915b53c98e7f29905e5ca0d37107660650

Implement Proxy object [[Delete]] internal method (#3616) The algorithm is based on ECMA-262 v6, 9.5.10 JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

view details

Robert Fancsik

commit sha 5b6d4f39b1b43907d8d60ea3b17bbf147f02415e

Add missing ecma_free_value to opfunc_init_class (#3626) This patch fixes #3625. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

view details

Péter Gál

commit sha 655110ad7b3c214047a2b7e9b8c0d83485127120

Add a Proxy C unittest (#3633) Previously only the Proxy api was tested. Added a unittest to check the C callbacks via proxy. JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com

view details

Szilagyi Adam

commit sha 56832d772ea6fc6b82ca69abf32e034429331338

Implement Proxy object [[getPrototypeOf]] internal method (#3623) The algorithm is based on ECMA-262 v6, 9.5.1 JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

view details

Szilagyi Adam

commit sha d539d30bf9838712473556baa0720698f01053df

Update the RegExp constructor to ECMA-262 v6 (#3538) The following methods have been implemented: - RegExpAlloc, based on ECMA-262 v6, 21.2.3.2.1 - RegExpInitialize, based on ECMA-262 v6, 22.2.3.2.2 - RegExpCreate, based on ECMA-262 v6, 21.2.3.2.3 Co-authored-by: Robert Fancsik frobert@inf.u-szeged.hu JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

view details

Virag Orkenyi

commit sha 18a4cba06299e32fc718f85601185846b45f83ac

Implement Number.parseFloat and Number.parseInt (#3576) The Global object parseFloat and parseInt fuctions have been moved to the number helpers and intrinsic properties have been created the are used for both the Number and Global methods. JerryScript-DCO-1.0-Signed-off-by: Virag Orkenyi orkvi@inf.u-szeged.hu

view details

Akos Kiss

commit sha f29e6f9020d89d5b071ada8a59a962ce78a656d3

Fix undefined overflow behavior when converting double to integer (#3629) Overflows in conversions from floating-point to integer are undefined behavior in the C99 standard. (Clause 6.3.1.4: "If the value of the integral part cannot be represented by the integer type, the behavior is undefined.") When UBSAN is enabled, this gets reported at `srand()` calls. (The random seed is usually initialized using the date port API, which represents dates as `double`s. But `srand` takes an `unsigned int`. A simple cast from `double` to `unsigned` becomes undefined behavior if the value is too large. And "now" is too large nowadays. So, effectively, all executions start with an undefined behavior.) This patch fixes this by casting the floating-point value of the date to an integer through a union. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

view details

Szilagyi Adam

commit sha 6a022eb265f31d0ce7b60113722019efbb1060f4

Implement Proxy object [[setPrototypeOf]] internal method (#3631) The algorithm is based on ECMA-262 v6, 9.5.2 JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

view details

Péter Gál

commit sha 43a36c9673fbdae269fadec3a9624ab9fbc0756f

Fix VLA error in strings unittest (#3632) In the test-api-string.c there was an error if the unittests are built in release. Full error message: ``` tests/unit-core/test-api-strings.c:89:20: error: variable-length array bound is unknown [-Werror=vla-larger-than=] 89 | JERRY_VLA (char, string_from_cesu8_string, cesu8_sz); ``` The problem is that the compiler does not know if the buffer size is always greater than zero. Added an extra check to the TEST_ASSERT a line above to resolve the error. JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com

view details

push time in 2 months

issue commentjerryscript-project/jerryscript

No class support

There was a significant change in the default language version, see #3737 . Version 2.3.0 was the last release to have ES5.1 as default. If you plan to use that version, you will have to add --profile=es2015-subset to your build command line to enable classes. If you are OK with using the master branch, then ES.Next will already be the default profile, i.e., classes are enabled.

szdytom

comment created time in 2 months

issue commentjerryscript-project/jerryscript

No class support

@szdytom How did you build the project (and which version)? In previous versions, es5.1 was default and the so-called es2015-subset profile had to be selected explicitly. Latest master has es.next profile as the default, though.

szdytom

comment created time in 2 months

issue commentrenatahodovan/grammarinator

Using MySqlGrammar generator SelectStatement unrecognizable Code

@xlw712 A major charset rework has landed, which changes how (and when) inverted/negated/not sets are calculated. Could you try and see whether it solves your issue?

Is the latest master branch?

Yes, latest changes are available from the master branch.

xlw712

comment created time in 2 months

issue commentrenatahodovan/grammarinator

Using MySqlGrammar generator SelectStatement unrecognizable Code

@xlw712 A major charset rework has landed, which changes how (and when) inverted/negated/not sets are calculated. Could you try and see whether it solves your issue?

xlw712

comment created time in 2 months

issue commentrenatahodovan/grammarinator

Unlexer generates forbidden characters

@abyss7 The charset rework has landed. Could you try and see whether it solves your issue?

abyss7

comment created time in 2 months

issue commentrenatahodovan/grammarinator

Using MySqlGrammar generator SelectStatement unrecognizable Code

Was that a problem with a negated set (aka. not set)?

xlw712

comment created time in 2 months

issue commentrenatahodovan/grammarinator

Using MySqlGrammar generator SelectStatement unrecognizable Code

@xlw712 So, I guess you've managed to install via python3 setup.py install. And you still see those special characters. Could you share the relevant portion of your grammar that is responsible for those parts? Or would it be possible to share a modified minimal grammar that exhibits the same behavior?

xlw712

comment created time in 2 months

push eventakosthekiss/picireny

Akos Kiss

commit sha b6f9bb95ccc91bd1e14e4d76eba77636093b70c3

Handle tokens section in grammars Identifiers in a `tokens { Token1, ..., TokenN }` section are definitions of token names without an associated lexer rule. We don't know anything about them, but they are added with a dummy representation to the grammar tree that is used for minimal replacement string calculation to avoid dead links (as they may be referenced from other (parser) rules). Fixes #16

view details

push time in 2 months

issue commentrenatahodovan/grammarinator

Unlexer generates forbidden characters

Hi @abyss7,

Thanks for reporting this issue. It's been known for some time that there is something off around multirange_diff. However, we have seen it as a sub-optimality only, not as a source of bug, until now.

We have a bigger rework of charset handling, lingering around for some months now, that hasn't been released yet because of the above. But now that it is proven to cause problems, we shall land it soon.

abyss7

comment created time in 2 months

issue commentrenatahodovan/picireny

Minimizing Python programs

Hi @rohanpadhye,

As it turns out, the Python grammar makes use of the tokens { ... } section, which defines tokens without specifying rules for them. This was the original cause of the problem in the grammar analysis phase.

While writing the fix (soon to land in master), I've executed some minimization sessions. I figured it may be interesting to write some notes about them.

Experiment with the reported example

I've executed a minimization with the input, test, and grammar files submitted as part of the issue report.

run:

picireny --input=foo.py --test=test.sh --grammar=Python3.g4 --start=file_input --subset-iterator=skip --complement-iterator=backward

foo.py (result):

print(A if False else "B")

Notes:

  • --subset-iterator=skip --complement-iterator=backward may (or may not) result in faster reduction. By experience, it helps when the input is code, but this is only heuristics.
  • The output is not that small, it only got rid of the quotes from around "A". However, actually, no more reduction can be expected from HDD (the algorithm under the hood of Picireny). To get print("B") as a result, something called hoisting would be needed. However that's not implemented in Picireny. Yet.

Experiment with the second reported example

I've named the second test file as foo2.py and adapted the tester script as follows:

test.sh:

#!/bin/bash
python $1 | grep "^B$"

This reproduced the reported assertion failure, but then I've amended the command line:

picireny --input=foo2.py --test=test.sh --grammar=Python3.g4 --start=file_input --subset-iterator=skip --complement-iterator=backward --build-hidden-tokens

foo2.py (result):

if True:
  print('' if False else "B")

Notes:

  • --build-hidden-tokens directs Picireny to build tokens from ANTLR's so-called hidden channel in the tree representation that is used during reduction. Usually, this is whitespace. For most of the input formats, this doesn't matter, and not even building them in the tree helps reduction performance. However, this is Python, where whitespace is quite important.
  • The test script uses $1 to refer to the reduced candidate. (The test script in the issue report used a hard-coded file name.)
  • During this reduction, "A" got replaced by '' (not by A as above). At the moment, I have no idea why the difference... (If I added --build-hidden-tokens to the first example's command line, the result changed there, too.)

Another experiment

I've also executed a minimization on the classic example of the program slicing domain, where the sum and product of the first 10 natural numbers are calculated in one go, but we are interested in only one of the results.

sumprod10.py:

#!/usr/bin/env python3

sum = 0
prod = 1
for i in range(1,11):
    sum += i
    prod *= i

print('sum: %d' % sum)
print('prod: %d' % prod)

test-prod.sh:

#! /bin/bash
python3 $1 2>&1 | grep -q "prod: 3628800"

run:

PYTHONOPTIMIZE=1 picireny --input=sumprod10.py --test=test-prod.sh --grammar=Python3.g4 --start=file_input --subset-iterator=skip --complement-iterator=backward --build-hidden-tokens

sumprod10.py (result):

prod = 1
for i in range(1,11):
    prod *= i

print('prod: %d' % prod)

Notes:

  • PYTHONOPTIMIZE=1 is to disable asserts. That will reduce the number of test executions. I.e., faster reduction in the end. (Disclaimer: Those asserts help catch incorrectly written test.sh scripts or flaky tests. Disabling them will remove these safeguards.)

Yet another experiment with Picire

Python is quite line-oriented, so one may be tempted to use a line-based reducer instead of a grammar-based one. Therefore, I've executed a minimization on the same example as show above, but using Picire.

run:

PYTHONOPTIMIZE=1 picire --input=sumprod10.py --test=test-prod.sh --subset-iterator=skip --complement-iterator=backward

sumprod10.py (result):

prod = 1
for i in range(1,11):
    prod *= i
print('prod: %d' % prod)

Notes:

  • In this case, line-based reduction works just as well as grammar-based minimization. This definitely cannot be expected in the general case.
  • Still, if a grammar is not available, Picire (i.e., DD under the hood) can work as a fallback.

P.S.

@rohanpadhye: It would be appreciated if you'd give feedback whether the soon-to-be-landed commit and --build-hidden-tokens works for you in more complex scenarios.

rohanpadhye

comment created time in 2 months

pull request commentSamsung/libtuv

Use generic in the platform name instead of noarch

Please, note that this is only a patch in libtuv, which will have to be followed up with a similar PR in iotjs. Modules and the like are in the territory of iotjs, so this will have to be discussed there.

akosthekiss

comment created time in 3 months

pull request commentSamsung/libtuv

Use generic in the platform name instead of noarch

Fallout from https://github.com/jerryscript-project/iotjs/pull/1947#pullrequestreview-459064793

akosthekiss

comment created time in 3 months

PR opened Samsung/libtuv

Use generic in the platform name instead of noarch

libtuv-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

+4 -5

0 comment

5 changed files

pr created time in 3 months

create barnchakosthekiss/libtuv

branch : noarch-generic

created branch time in 3 months

push eventakosthekiss/iotjs

Daniel Balla

commit sha 4d4fa973291c69c4e035af0953bdc996b9ccd720

Add an extra check to the stats object (#1919) Fixes #1917 IoT.js-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu

view details

Daniel Balla

commit sha 7c42b75e0fb6f707279b28f62baad337a568cf4c

Correctly free handle info in uart module (#1918) Fixes #1915 Co-authored-by: Robert Fancsik <frobert@inf.u-szeged.hu> IoT.js-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu

view details

Akos Kiss

commit sha 1534b2aff6d4da386cdef29c905c7d230c4398cc

Add a "Hello IoT.js!" program to the tests (#1902) The current code base does not contain any "first JavaScript program" for those who build IoT.js. The existing tests are just that: tests, giving passed/failed information but nothing eye candy. This patch adds a simple JS script that can act as a warm welcome to anyone after the first successful build trying to run something proving that IoT.js works. IoT.js-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

view details

Péter Gál

commit sha 4632203b09c93ce3978f6840637c67082f8e1463

Fix the repl example (#1920) The REPL example was unable to use the 'require' call. IoT.js-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com

view details

Péter Gál

commit sha 26cfc2567c4a29e668c57f17154439d0e72a9b96

Simplify the TLS checks in WebSocket (#1922) The TLS checks in the WebSocket module involved requesting the TLS module's keys as an array. This is uses extra memory, a simple true/false check on the TLS object is enough to validate if the 'require' call loaded the module. IoT.js-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com

view details

Péter Gál

commit sha 6baab7edf4f50611be923b7c30209f3bc2d68415

Improve WebSocket server handshake handling (#1921) The WebSocket server incorrectly used http headers: * The 'Connection' header field value can have multiple elements, not just 'Upgrade'. * The header field names should be handled in a case-insensitive way. * If there is an error reporting a 400 error should also terminate the connection and correctly add http header termination lines. IoT.js-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com

view details

Daniel Balla

commit sha e154ebccf4a616d8eadeeadff272836709ab1f01

Add proper checks to udp module send (#1924) Fixes #1904 IoT.js-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu

view details

Haesik Jun

commit sha 60265704ba6d298df1a234da1869a91ae2e2c0d2

Remove unused module dependency on tizen build (#1926) openssl and libcurl are no longer used on tizen platform IoT.js-DCO-1.0-Signed-off-by: Haesik Jun haesik.jun@samsung.com

view details

kisbg

commit sha 17685a88de0aedb57bd7fb746bf3d2905a9f4275

Removed unused break in iotjs_env.c (#1927) IoT.js-DCO-1.0-Signed-off-by: bence gabor kis kisbg@inf.u-szeged.hu

view details

Haesik Jun

commit sha ada0d20ff01a3645187caca776c8fc16d6be22fe

Add tizen 5.5 M1 configuration (#1928) IoT.js-DCO-1.0-Signed-off-by: Haesik Jun haesik.jun@samsung.com

view details

HoSung Kim

commit sha e0414633e70b8f659fa94d374763df198994d88b

Fix svace issue (#1929) IoT.js-DCO-1.0-Signed-off-by: Kim HoSung hs852.kim@samsung.com

view details

kisbg

commit sha d6ead6c409a5e2511409ed7840e8a0940fd4b221

Fixed SonarQube analyzes. (#1930) Fixed repository name after recent project renaming. IoT.js-DCO-1.0-Signed-off-by: bence gabor kis kisbg@inf.u-szeged.hu

view details

kisbg

commit sha 48bf8d951667bd52c9516187e967bcb54ec24cb3

Removed Artik053 job from travis (#1934) IoT.js-DCO-1.0-Signed-off-by: bence gabor kis kisbg@inf.u-szeged.hu

view details

Ádám Kallai

commit sha 7659b3d2468a354fc3d089a741d47b82b4fe70ac

Fixed some typos in API documentation (#1935) IoT.js-DCO-1.0-Signed-off-by: Adam Kallai kadam@inf.u-szeged.hu

view details

Roland Takacs

commit sha c35e675449ff7a4223e6772ce336dd1b6319fb68

Use absolute paths for file resources (#1936) NuttX based operating systems require absolute paths. IoT.js-DCO-1.0-Signed-off-by: Roland Takacs r.takacs2@partner.samsung.com

view details

Haesik Jun

commit sha 4ec67469a048566b1579b823af4d201829f8f107

Add pie flag to support ASLR (#1942) IoT.js-DCO-1.0-Signed-off-by: Haesik Jun haesik.jun@samsung.com

view details

Philippe Coval

commit sha bf715a9b70df36d1cbcc0710e3ceebe685e3ad7c

Subject: cmake: Allow one to select python3 from env (#1946) This will be useful for next debian release shipping python3 Version can be specified as cmake option using: CMAKE_OPTIONS=-DPYTHON="python3" Bug: https://github.com/jerryscript-project/iotjs/issues/1945 Bug-Debian: https://bugs.debian.org/936738 Forwarded: https://github.com/jerryscript-project/iotjs/pull/1946 Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master Relate-to: https://travis-ci.org/github/TizenTeam/iotjs/builds/712336077 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

view details

Philippe Coval

commit sha 4cde5a8fedf38e935a65510392154c86eca26b5b

build: Set board as generic if not defined (#1943) Observed issue using cmake: CMake Error at CMakeLists.txt:136 (string): string no output variable specified This will help to keep iotjs in debian repo. Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050 Forwarded: https://github.com/jerryscript-project/iotjs/pull/1943 Bug: https://github.com/jerryscript-project/iotjs/issues/1945 Bug-Debian: https://bugs.debian.org/957364 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/build/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

view details

Philippe Coval

commit sha d3a73d76dc68de583fb78e322c487ae52caa66ab

build: Set noarch as default TARGET_ARCH (#1947) This will help for debian upgrade Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050 Forwarded: https://github.com/jerryscript-project/iotjs/pull/1947 Bug: https://github.com/jerryscript-project/iotjs/issues/1945 Bug-Debian: https://bugs.debian.org/957364 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

view details

push time in 3 months

push eventjerryscript-project/iotjs

Philippe Coval

commit sha d3a73d76dc68de583fb78e322c487ae52caa66ab

build: Set noarch as default TARGET_ARCH (#1947) This will help for debian upgrade Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050 Forwarded: https://github.com/jerryscript-project/iotjs/pull/1947 Bug: https://github.com/jerryscript-project/iotjs/issues/1945 Bug-Debian: https://bugs.debian.org/957364 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

view details

push time in 3 months

PR merged jerryscript-project/iotjs

build: Set noarch as default TARGET_ARCH

This will help for debian upgrade

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050 Forwarded: https://github.com/jerryscript-project/iotjs/pull/rzr Bug: https://github.com/jerryscript-project/iotjs/issues/1945 Bug-Debian: https://bugs.debian.org/957364 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/cmake/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

+4 -0

1 comment

1 changed file

rzr

pr closed time in 3 months

push eventjerryscript-project/iotjs

Philippe Coval

commit sha 4cde5a8fedf38e935a65510392154c86eca26b5b

build: Set board as generic if not defined (#1943) Observed issue using cmake: CMake Error at CMakeLists.txt:136 (string): string no output variable specified This will help to keep iotjs in debian repo. Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050 Forwarded: https://github.com/jerryscript-project/iotjs/pull/1943 Bug: https://github.com/jerryscript-project/iotjs/issues/1945 Bug-Debian: https://bugs.debian.org/957364 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/build/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

view details

push time in 3 months

PR merged jerryscript-project/iotjs

build: Set board as generic if not defined

Observed issue using cmake:

CMake Error at CMakeLists.txt:136 (string):
string no output variable specified

This will help to keep iotjs in debian repo.

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050 Forwarded: https://github.com/jerryscript-project/iotjs/pulls?q=author%3Arzr IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

+3 -0

1 comment

1 changed file

rzr

pr closed time in 3 months

Pull request review commentjerryscript-project/iotjs

build: Install to system's path (prefixed by destdir)

 endif() if(NOT BUILD_LIB_ONLY)   set(TARGET_IOTJS iotjs)   message(STATUS "CMAKE_BINARY_DIR        ${CMAKE_BINARY_DIR}")-  message(STATUS "BINARY_INSTALL_DIR      ${INSTALL_PREFIX}/bin")-  message(STATUS "LIBRARY_INSTALL_DIR     ${INSTALL_PREFIX}/lib")+  message(STATUS "BINARY_INSTALL_DIR      ${INSTALL_PREFIX}/${BIN_INSTALL_DIR}")

Either this message is incorrectly stating that the binary install directory is ${INSTALL_PREFIX}/${BIN_INSTALL_DIR} or lines 580 and 585 miss the ${INSTALL_PREFIX}/. Which one? (If the prefix is not needed for "bin", why is that, i.e., why is it still needed for libraries?)

rzr

comment created time in 3 months

push eventjerryscript-project/iotjs

Philippe Coval

commit sha bf715a9b70df36d1cbcc0710e3ceebe685e3ad7c

Subject: cmake: Allow one to select python3 from env (#1946) This will be useful for next debian release shipping python3 Version can be specified as cmake option using: CMAKE_OPTIONS=-DPYTHON="python3" Bug: https://github.com/jerryscript-project/iotjs/issues/1945 Bug-Debian: https://bugs.debian.org/936738 Forwarded: https://github.com/jerryscript-project/iotjs/pull/1946 Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master Relate-to: https://travis-ci.org/github/TizenTeam/iotjs/builds/712336077 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

view details

push time in 3 months

PR merged jerryscript-project/iotjs

cmake: Allow to select python3 from env

This will be useful for next debian release shipping python3

Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795 Bug: https://github.com/jerryscript-project/iotjs/issues/1945 Bug-Debian: https://bugs.debian.org/936738 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

+5 -1

4 comments

1 changed file

rzr

pr closed time in 3 months

Pull request review commentjerryscript-project/iotjs

Update JerryScript submodule to post 2.3 version

 message(STATUS "EXTERNAL_LIBS            ${EXTERNAL_LIBS}") message(STATUS "EXTERNAL_MODULES         ${EXTERNAL_MODULES}") message(STATUS "IOTJS_LINKER_FLAGS       ${IOTJS_LINKER_FLAGS}") message(STATUS "IOTJS_PROFILE            ${IOTJS_PROFILE}")-message(STATUS "JERRY_DEBUGGER           ${FEATURE_DEBUGGER}")-message(STATUS "JERRY_HEAP_SIZE_KB       ${MEM_HEAP_SIZE_KB}")-message(STATUS "JERRY_MEM_STATS          ${FEATURE_MEM_STATS}")-message(STATUS "JERRY_PROFILE            ${FEATURE_PROFILE}")+message(STATUS "JERRY_DEBUGGER           ${JERRY_DEBUGGER}")+message(STATUS "JERRY_HEAP_SIZE_KB       ${JERRY_GLOBAL_HEAP_SIZE}")

Hm, what I mean is that the name that is printed is not the actual name of the variable that's printed. Shouldn't this be message(STATUS "JERRY_GLOBAL_HEAP_SIZE ${JERRY_GLOBAL_HEAP_SIZE}")?

galpeter

comment created time in 3 months

more