profile
viewpoint
Jack Lawson ajacksified @inrupt Mars http://www.thejacklawson.com Engineering lead @inrupt. Prior: @reddit, @airbnb, others.

ajacksified/Clark 8

It's like Spark, but in Coffeescript.

ajacksified/Craftyjs-Presentation 4

Lightning talk for a Craftyjs presentation for SF GamesJS

ajacksified/coffee-protocol 3

Classes for implementation of RFC 2325

ajacksified/Ergojack 2

Ergodox Infinity Layout

ajacksified/bard 1

Node bootstrap. Server + Client rendering. Mustache and Backbone. Sockets and REST.

ajacksified/chariot-example 1

an example for chariot

ajacksified/connect4 1

Seemed like a good idea at the time

ajacksified/csswords 1

What words can you spell using css?

PullRequestReviewEvent

PR opened inrupt/pod-browser

Reviewers
Ignore .next directory when testing

This prevents jest from looking at the .next directory, which includes some copied test files.

+1 -1

0 comment

1 changed file

pr created time in 11 days

create barnchinrupt/pod-browser

branch : fix/build

created branch time in 11 days

Pull request review commentinrupt/pod-browser

Fix/delete resource policy resource

 import { hasAcpConfiguration } from "../../accessControl/acp/index"; export default function useIsLegacyAcp(resourceInfo) {   const { fetch } = useSession();   return useSWR(-    resourceInfo ? acp.getLinkedAcrUrl(resourceInfo) : null,+    [resourceInfo ? acp.getLinkedAcrUrl(resourceInfo) : null, fetch],

...although this one returns undefined, instead of null, so this ternary belongs here. I've started a conversation in the SDK team to align on when we return null vs undefined.

VirginiaBalseiro

comment created time in 13 days

Pull request review commentinrupt/pod-browser

Fix/delete resource policy resource

 export function isCustomPolicy(type) { export function isNamedPolicy(type) {   return namedPolicies.find((policy) => policy.name === type) !== undefined; }++export const deletePoliciesContainer = async (containerIri, fetch) => {+  try {+    await deleteContainer(containerIri, { fetch });+  } catch (err) {+    if (+      !isHTTPError(err.message, 409) &&+      !isHTTPError(err.message, 404) &&+      !isHTTPError(err.message, 403)

Do we only want to specifically catch these three, or should this catch any error responses?

VirginiaBalseiro

comment created time in 13 days

Pull request review commentinrupt/pod-browser

Fix/delete resource policy resource

 import {   isEmptyAccess, } from "../../solidClientHelpers/permissions"; import { chain, createResponder } from "../../solidClientHelpers/utils";-import {-  deletePoliciesContainer,-  getOrCreateDatasetOld,-} from "../../solidClientHelpers/resource";+// eslint-disable-next-line import/no-cycle

We should definitely fix this (separately.)

VirginiaBalseiro

comment created time in 13 days

Pull request review commentinrupt/pod-browser

Fix/delete resource policy resource

  */  import { useSession } from "@inrupt/solid-ui-react";+import { getSourceUrl } from "@inrupt/solid-client"; import useSWR from "swr"; import { getAccessControl } from "../../accessControl"; import usePoliciesContainerUrl from "../usePoliciesContainerUrl"; import useIsLegacyAcp from "../useIsLegacyAcp";  export default function useAccessControl(resourceInfo, swrOptions = {}) {-  const policiesContainerUrl = usePoliciesContainerUrl(resourceInfo);+  const resourceUrl = resourceInfo ? getSourceUrl(resourceInfo) : null;

getSourceUrl returns string | null, so you shouldn't need this ternary.

VirginiaBalseiro

comment created time in 13 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch inrupt/pod-browser

delete branch : dependabot/npm_and_yarn/normalize-url-4.5.1

delete time in 13 days

PR merged inrupt/pod-browser

Bump normalize-url from 4.5.0 to 4.5.1 dependencies

Bumps normalize-url from 4.5.0 to 4.5.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/sindresorhus/normalize-url/commits">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

1 comment

1 changed file

dependabot[bot]

pr closed time in 13 days

push eventinrupt/pod-browser

push time in 13 days

push eventinrupt/pod-browser

push time in 13 days

delete branch inrupt/pod-browser

delete branch : dependabot/npm_and_yarn/semver-regex-3.1.3

delete time in 13 days

PR merged inrupt/pod-browser

Bump semver-regex from 3.1.2 to 3.1.3 dependencies

Bumps semver-regex from 3.1.2 to 3.1.3. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/sindresorhus/semver-regex/commits">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

1 comment

1 changed file

dependabot[bot]

pr closed time in 13 days

push eventinrupt/pod-browser

push time in 13 days

delete branch inrupt/pod-browser

delete branch : dependabot/npm_and_yarn/path-parse-1.0.7

delete time in 13 days

PR merged inrupt/pod-browser

Bump path-parse from 1.0.6 to 1.0.7 dependencies

Bumps path-parse from 1.0.6 to 1.0.7. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/jbgutierrez/path-parse/commits/v1.0.7">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

1 comment

1 changed file

dependabot[bot]

pr closed time in 13 days

push eventinrupt/pod-browser

push time in 13 days

delete branch inrupt/pod-browser

delete branch : dependabot/npm_and_yarn/tmpl-1.0.5

delete time in 13 days

PR merged inrupt/pod-browser

Bump tmpl from 1.0.4 to 1.0.5 dependencies

Bumps tmpl from 1.0.4 to 1.0.5. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/daaku/nodejs-tmpl/commits/v1.0.5">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

1 comment

1 changed file

dependabot[bot]

pr closed time in 13 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

PR closed inrupt/pod-browser

Reviewers
Chore/upgrade solid-ui-react

In this PR:

  • upgrade solid-ui-react
  • update tests and fix some false positives
+12813 -2452

2 comments

9 changed files

VirginiaBalseiro

pr closed time in 13 days

pull request commentinrupt/pod-browser

Chore/upgrade solid-ui-react

Closing; we've upgraded past this version.

VirginiaBalseiro

comment created time in 13 days

push eventinrupt/solid-client-js

Jack Lawson

commit sha d378098a625007e47484e0fe7e64f05ad3636ceb

Use node 16.x in tests and development

view details

Matthieu Bosquet

commit sha f5bb92662ef704ed30b1eeeec072fbac283d99c2

Disable browser based tests in CI/CD

view details

push time in 14 days

delete branch inrupt/solid-client-js

delete branch : chore/node-16

delete time in 14 days

PR merged inrupt/solid-client-js

Reviewers
Use node 16.x in tests and development

This PR updates the .nvmrc to use Node 16, updates the CI / CD workflows to include 16 in the test matrix and for builds, and rebuilds the package-lock.json using NPM 8.

+17144 -41

3 comments

7 changed files

ajacksified

pr closed time in 14 days

more