profile
viewpoint
Ben Cohen airspeedswift @apple Cupertino http://airspeedvelocity.net/ Swift standard library at Apple

airspeedswift/SwooshKit 51

Library of code from the Airspeed Velocity blog

airspeedswift/ImmutableSwiftSnake 10

A version of Snake in Swift that prints to the console and tries to avoid mutable variables

airspeedswift/swift 2

The Swift Programming Language

airspeedswift/swift-evolution 2

This maintains proposals for changes and user-visible enhancements to the Swift Programming Language.

milseman/swift 2

The Swift Programming Language

airspeedswift/swift-compiler-crashes 1

A collection of test cases crashing the Swift compiler.

airspeedswift/swift-lldb 1

This is the version of LLDB that supports the Swift programming language & REPL.

airspeedswift/Dollar 0

A functional tool-belt for Swift Language similar to Lo-Dash or Underscore.js in Javascript

pull request commentapple/swift

[WIP] Break loadborrow

Switched this to a draft PR since it's WIP

atrick

comment created time in 11 days

create barnchairspeedswift/swift

branch : main

created branch time in 24 days

PR closed apple/swift

Reviewers
[stdlib] Switch some cold paths to inline-never

Fetching the non-native implementation or creating a bridged wrapper shouldn't need to be inlinable.

+2 -2

4 comments

2 changed files

airspeedswift

pr closed time in 25 days

PR closed apple/swift

[DNM] Experimentally disable speculative devirtualization

Just an experiment looking at code size vs benchmark impact.

+1 -0

7 comments

1 changed file

airspeedswift

pr closed time in 25 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventapple/swift-evolution

Ben Cohen

commit sha aecced4919ab297f343dafd7235d392d8b859839

Update 0284 to implemented

view details

push time in a month

PullRequestReviewEvent

pull request commentapple/swift

Fixes example snippets in Array.swift considering endianness

@swift-ci please smoke test

valeriyvan

comment created time in 2 months

pull request commentapple/swift

[stdlib] Dispatch to concrete implementations of known types for generic BinaryFloatingPoint and FixedWidthInteger initialisers

or something like the polymorphic builtins support that has been suggested elsewhere

It may be worth recapping that initiative and where we stand with it on the forums as it’s mostly been point to point discussion.

troughton

comment created time in 2 months

pull request commentapple/swift

[stdlib] Dispatch to concrete implementations of known types for generic BinaryFloatingPoint and FixedWidthInteger initialisers

(including improving the optimizer instead of working around it)

troughton

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

push eventapple/swift

eeckstein

commit sha 908f1051b058f44128fa2e6b3451d3bb465ec781

CSE: disable CSE of lazy property getters of struct (#33741) We cannot prove that the whole struct is overwritten between two lazy property getters. We would need AliasAnalysis for this, but currently this is not used in CSE. rdar://problem/67734844

view details

push time in 2 months

PR merged apple/swift

[5.3] CSE: disable CSE of lazy property getters of struct r5.3

We cannot prove that the whole struct is overwritten between two lazy property getters. We would need AliasAnalysis for this, but currently this is not used in CSE.

Original: #33713

  • Radar: rdar://problem/67734844

  • Explanation: This fixes a miscompile with lazy struct properties.

  • Scope: This is a bug which was introduced by a new optimization in 5.3. It shows up if a value type (e.g. a struct) with a lazy property is overwritten between two accesses of the property.

  • Risk: Low. The only change is to add an additional bail-out condition,.

  • Reviewer: @atrick

+91 -4

1 comment

3 changed files

eeckstein

pr closed time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentapple/swift

Add warning about spaces in the Xcode path.

 The required version of Xcode changes frequently, and is often a beta release. Check this document or the host information on <https://ci.swift.org> for the current required version. +Swift's build tooling is meant to support spaces in the paths passed to them, but using spaces sometimes tickles bugs in Swift's build scripts or the tools they rely on. For example, https://bugs.swift.org/browse/SR-13441 is caused by a space in the Xcode path used on macOS. If you see Swift's build tooling misbehave due to a space in a path, please report the bug on the Swift bug tracker and then change the path to work around it.
Swift's build tooling is meant to support spaces in the paths passed to them, but using spaces sometimes tickles bugs in Swift's build scripts or the tools they rely on. For example, [SR-13441](https://bugs.swift.org/browse/SR-13441) is caused by a space in the Xcode path used on macOS. If you see Swift's build tooling misbehave due to a space in a path, please report the bug on the Swift bug tracker and then change the path to work around it.
davidungar

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentapple/swift

Add warning about spaces in the Xcode path.

 Please make sure you use Python 2.x. Python 3.x is not supported currently. To build for macOS, you need [Xcode 12 beta 3](https://developer.apple.com/xcode/resources/). The required version of Xcode changes frequently, and is often a beta release. Check this document or the host information on <https://ci.swift.org> for the-current required version.+current required version. The path name for the Xcode app must not include any spaces.

So something like "Due to [link to jira] the Xcode app must not include any spaces.

davidungar

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentapple/swift-tools-support-core

Move `Triple` to TSCUtility

+/*+ This source file is part of the Swift.org open source project++ Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors+ Licensed under Apache License v2.0 with Runtime Library Exception++ See http://swift.org/LICENSE.txt for license information+ See http://swift.org/CONTRIBUTORS.txt for Swift project authors+ */++import TSCBasic++/// Triple - Helper class for working with Destination.target values+///+/// Used for parsing values such as x86_64-apple-macosx10.10 into+/// set of enums. For os/arch/abi based conditions in build plan.+///+/// @see Destination.target+/// @see https://github.com/apple/swift-llvm/blob/stable/include/llvm/ADT/Triple.h+///+public struct Triple: Encodable, Equatable {+    public let tripleString: String++    public let arch: Arch+    public let vendor: Vendor+    public let os: OS+    public let abi: ABI++    public enum Error: Swift.Error {+        case badFormat+        case unknownArch+        case unknownOS+    }++    public enum Arch: String, Encodable {+        case x86_64+        case x86_64h+        case i686+        case powerpc64le+        case s390x+        case aarch64+        case armv7+        case arm+        case arm64+        case arm64e+        case wasm32+    }++    public enum Vendor: String, Encodable {+        case unknown+        case apple+    }++    public enum OS: String, Encodable, CaseIterable {+        case darwin+        case macOS = "macosx"

ಠ_ಠ

neonichu

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentapple/swift

Add warning about spaces in the Xcode path.

 Please make sure you use Python 2.x. Python 3.x is not supported currently. To build for macOS, you need [Xcode 12 beta 3](https://developer.apple.com/xcode/resources/). The required version of Xcode changes frequently, and is often a beta release. Check this document or the host information on <https://ci.swift.org> for the-current required version.+current required version. The path name for the Xcode app must not include any spaces.

Sounds like we should tweak to wording to make it clear we’re flagging an existing bug you might hit (can we get a Jira for it too rather than just a radar?). Do we know yet if the bug is in the script vs in some dependency that makes it harder to fix?

davidungar

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentapple/swift

Add warning about spaces in the Xcode path.

Sounds like we should tweak to wording to make it clear we’re flagging an existing bug (can we get a Jira for it too rather than just a radar?). Do we know yet if the bug is in the script vs in some dependency that makes it harder to fix?

davidungar

comment created time in 2 months

pull request commentapple/swift

Fixes example snippet in Array.swift

@swift-ci please smoke test and merge

valeriyvan

comment created time in 2 months

PR closed apple/swift

Remove unnecessary @available check in Identifiable.swift

Removed the unnecessary @available check in Identifiable.swift

I don't see any reason why these are here in the first place since it is a language feature! maybe someone can explain to me if I am missing something

Thanks!

+0 -2

2 comments

1 changed file

omaralbeik

pr closed time in 2 months

pull request commentapple/swift

Remove unnecessary @available check in Identifiable.swift

Even types that are part of “the language” like Identifiable need availability on ABI-stable platforms. To work, they need symbols and code to be present in `libswiftCore.dylib and this ships in the OS, hence the OS version determines availability.

omaralbeik

comment created time in 2 months

pull request commentapple/swift

[stdlib] Floating-point random-number improvements

As for @_specialize - it's just a suggestion due to Ben's reservations about the amount of inlined code...It's worth considering how often we expect people to be generating lots of random values of their custom floating-point types

At the standard library, we definitely need to serve the needs of custom numeric types (like those you might find in swift-numerics), so @_specialize won't work here (though, once it can serve up pre-specialized versions as ABI, that'll definitely be worth it and might mitigate the binary size impact).

NevinBR

comment created time in 2 months

pull request commentapple/swift

[stdlib] [NFC] FloatingPointRandom.swift created

@swift-ci please test

NevinBR

comment created time in 2 months

pull request commentapple/swift

[stdlib] [NFC] FloatingPointRandom.swift created

@swift-ci please test

NevinBR

comment created time in 3 months

Pull request review commentapple/swift

[stdlib] [NFC] FloatingPointRandom.swift created

+//===----------------------------------------------------------------------===//

I'm a bit mystified how it compiled and passed tests without doing this...

NevinBR

comment created time in 3 months

pull request commentapple/swift

[stdlib] Floating-point random-number improvements

WIP commits should be squashed together, so separate commits should group logical changes rather than just when the work was done. I wish I knew how to do this.

https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

NevinBR

comment created time in 3 months

pull request commentapple/swift

[stdlib] Floating-point random-number improvements

I've not reviewed the code itself (I'll leave that to @stephentyrone) but the quantity of new code to be inlined into the caller gives me a little bit of pause. Maybe it's not materially different though, hopefully the benchmarks will give us an idea.

NevinBR

comment created time in 3 months

Pull request review commentapple/swift

[stdlib] Floating-point random-number improvements

+// RUN: %target-run-simple-swiftgyb+// REQUIRES: executable_test++import StdlibUnittest++var FloatingPointRandom = TestSuite("FloatingPointRandom")+defer { runAllTests() }++extension BinaryFloatingPoint where RawSignificand: FixedWidthInteger {+  // Basic sanity check+  static func isRandomInRange(_ range: Range<Self>) -> Bool {+    let x = Self.random(in: range)+    return range.contains(x)+  }+  +  // Basic sanity check

Please don't use the term "sanity check", prefer "invariant check" or similar.

NevinBR

comment created time in 3 months

pull request commentapple/swift

[stdlib] Floating-point random-number improvements

I wouldn't describe that as a trick so much as What You Should Do.

NevinBR

comment created time in 3 months

pull request commentapple/swift

Start using optimization (-O0/-O2/-O3/-Os) and debug (-g) flags from CMAKE_CXX_FLAGS_${CFLAGS_BUILD_TYPE}

We really need to do a benchmark run and see the impact on that.

kubamracek

comment created time in 3 months

pull request commentapple/swift

Avoid using -sil-inline-generics and -sil-partial-specialization when building MinSizeRel stdlib to save ~15% on codesize

I'm guessing this won't benchmark this change, since it's for a new config.

kubamracek

comment created time in 3 months

push eventapple/swift

Joe Groff

commit sha df007a4f27e71bc1c890570ae61fa9d78ce3bb13

IRGen: ObjC method lists are not const. (#33338) Put them in __objc_data instead of __objc_const. rdar://problem/66630432

view details

push time in 3 months

PR merged apple/swift

[5.3] IRGen: ObjC method lists are not const. r5.3

Explanation: We incorrectly placed method lists in __DATA,__objc_const, causing us to dirty pages in the shared cache that are intended to remain clean

Scope: Performance issue

Issue: rdar://problem/66630432

Risk: Low. Should be no impact to end user code

Testing: Swift CI

Reviewed by: @mikeash

+57 -49

2 comments

11 changed files

jckarter

pr closed time in 3 months

push eventapple/swift

Ben Cohen

commit sha 08af5070952168a93ae8432c0cea36925f39e399

Revert "Refactor Mirror to reduce metadata allocation (#32041) (#32957)" (#33328) This reverts commit a7542a511b7857d86fb196ea4da4af746cfa2e1e.

view details

push time in 3 months

delete branch apple/swift

delete branch : revert-32957-such-lazy-children

delete time in 3 months

PR merged apple/swift

Reviewers
Revert "[5.3] Refactor Mirror to reduce metadata allocation"

Reverts apple/swift#32957

Seems to have some odd ABI interactions, so speculatively backing this out while we investigate.

+91 -300

1 comment

8 changed files

airspeedswift

pr closed time in 3 months

pull request commentapple/swift

[stdlib] Preserve random-access Mirror.children inside AnyCollection

@swift-ci please test

airspeedswift

comment created time in 3 months

push eventairspeedswift/swift

Ben Cohen

commit sha 83de1b5d2cc4c8f7a77b9c17a62c84ebb676c69b

Preserve random-access Mirror.children inside AnyCollection

view details

push time in 3 months

pull request commentapple/swift

Revert "[5.3] Refactor Mirror to reduce metadata allocation"

@swift-ci please test

airspeedswift

comment created time in 3 months

PR opened apple/swift

Revert "[5.3] Refactor Mirror to reduce metadata allocation"

Reverts apple/swift#32957

Seems to have some odd ABI interactions, so speculatively backing this out while we investigate.

+91 -300

0 comment

8 changed files

pr created time in 3 months

create barnchapple/swift

branch : revert-32957-such-lazy-children

created branch time in 3 months

pull request commentapple/swift

[stdlib] Preserve random-access Mirror.children inside AnyCollection

@swift-ci please test

airspeedswift

comment created time in 3 months

push eventairspeedswift/swift

Ben Cohen

commit sha ca2f68dee149cd14e2be9562d1e15f61af8b4190

Preserve random-access Mirror.children inside AnyCollection

view details

push time in 3 months

pull request commentapple/swift

[stdlib] Preserve random-access Mirror.children inside AnyCollection

@swift-ci please test

airspeedswift

comment created time in 3 months

PR opened apple/swift

[stdlib] Preserve random-access Mirror.children inside AnyCollection

#32041 unintentionally lost the random-access nature of some collections. While the returned type is AnyCollection, you could restore random-access via AnyRandomAccessCollection(mirror.children), but this now returned nil for some children. This PR restores this.

+25 -1

0 comment

2 changed files

pr created time in 3 months

create barnchairspeedswift/swift

branch : random-children

created branch time in 3 months

push eventairspeedswift/swift

swift-ci

commit sha e74e914122ef7648f665213b7f645ec98dec28d9

Merge pull request #32651 from eeckstein/module-version

view details

Xi Ge

commit sha 84dd4db0b17740ae73422f7647df6db71d758b0d

Dependencies Scanner: report compiled Swift module paths if they are available For the explicit module mode, swift-driver uses -compile-module-from-interface to generate modules from interfaces found by the dependency scanner. However, we don't need to build the binary module if up-to-date modules are available, either adjacent to the interface file or in the prebuilt module cache directory. This patch teaches dependencies scanner to report these ready-to-use binary modules.

view details

Robert Widmann

commit sha b766544327cab05d4c4ca90e629c2438eb24b197

Merge pull request #32642 from CodaFi/ossignpost [Gardening] Clean Up OS Conditionals With canImport and Vendor=apple

view details

Robert Widmann

commit sha 5a8fdafc543e0b8b62b813d9caba3abdfedc4849

Merge pull request #32638 from CodaFi/let-it-override Use Formal Access To Compute Override Elision Check

view details

Erik Eckstein

commit sha 723a205f0bdb53267136f0d1eeb636597881e781

Revert "SILCombine: Constant-fold MemoryLayout<T>.offset(of: \.literalKeyPath)" This reverts commit d7d829c0596ea376a0c19acbc4689b28bb984da9. The test stdlib/KeyPath.swift is failing on linux. rdar://problem/64997950

view details

Saleem Abdulrasool

commit sha 93df7f4276f8b6507e61e2d51fc4c0d18fc6ae6a

PathSanitizingFileCheck: improve Python3 compatibility Adjust the regex match to do a better job of sanitizing the paths. This improves the test coverage pass rate with Python 3. Furthermore, handle the unicode conversion properly that breaks with Python 3. This further improves the Python 3 test coverage pass rate.

view details

Saleem Abdulrasool

commit sha 96127ca3ce6c7766fa3aed4c589a0430b621ed0c

Update round-trip-syntax-test Try harder to appease the python linter

view details

Ben Langmuir

commit sha c03ea7ad44e417c2a52982411cc7432df1941c87

Merge pull request #32546 from dylansturg/add_swift_format_product Add a build product and presets for swift-format.

view details

Hamish Knight

commit sha 890df575152b6e1930b411af0c265e0664b24a24

Merge pull request #32654 from hamishknight/all-for-ir-and-ir-for-all

view details

Meghana Gupta

commit sha 906b3cbafbddd0db243296cf21c07c174e6f918c

Add -sil-inline-never-function flag (#32660) -sil-inline-never-functions already exists, but it does a substring match. This is not desired all the time. Add -sil-inline-never-function flag that does a full string match and avoids inlining functions with that name

view details

3405691582

commit sha a7679c09cdaaec8d97b4f79365a6e7099e998faa

[test] Add OpenBSD to stable ABI testing targets. See #30391, #30296. Neither IRGen/conditional_conformances.swift nor IRGen/class_resilience.swift pass on OpenBSD unless target_mandates_stable_abi = TRUE.

view details

swift-ci

commit sha 3da8595cd5b8eff49a036adf4061ce5f3e57a734

Merge pull request #32664 from eeckstein/revert-offsetof-opt

view details

Varun Gandhi

commit sha cacfb01f9794c45c3d408c09178d93732faa2bd9

Revert subset of "[Gardening] Clean Up OS-Test Patterns Across The Codebase" Removes usage of #canImport(Darwin) from stdlib/public. This reverts a subset of commit cddf73ecdbd79edf456fe17a7dba19a8adff9186.

view details

Xi Ge

commit sha 50142f896bdc894ced38d11f362ad06fea3e5673

AST: address code review comments on isEquivalentToExtendedContext()

view details

Yuta Saito

commit sha 20bc0af42bd22aa46b254d2c560107224c247cb1

[LTO] Support LLVM LTO for IRGen and frontend This commit adds -lto flag for frontend to enable LTO at LLVM level. When -lto=llvm given, compiler emits LLVM bitcode file instead of object file and adds index summary for LTO. In addition for ELF format, emit llvm.dependent-libraries section to embed auto linking information

view details

Xi Ge

commit sha 3e8166eab549fc9673823ca14aa486656fe2f426

Merge pull request #32633 from nkcsgexi/build-forward-module-from-command-line Dependencies Scanner: report compiled Swift module paths if they are available

view details

Holly Borla

commit sha 2ac8d7ea1786f8edf1b4666c6e5d901bb3800674

[ConstraintSystem] Add support for type checking an out-of-line initialized wrapped property via SolutionApplicationTarget.

view details

Onyekachi Ezeoke

commit sha ff26a062574708614c0d1e2aa8fc563cf59c5797

fix broken test

view details

Slava Pestov

commit sha 844ab508e6564f51ffd35cab37f894e47834288a

AST: Add more asserts for same-type constraints in generic signatures

view details

Xi Ge

commit sha 665eb51928987e34ec7008a5df8709226c86c459

Merge pull request #32667 from nkcsgexi/comments-on-64538537-5.3 AST: address code review comments on isEquivalentToExtendedContext()

view details

push time in 3 months

pull request commentapple/swift

[stdlib] Freeze some internal std lib protocols

@swift-ci please clean test macOS

airspeedswift

comment created time in 3 months

pull request commentapple/swift

[stdlib] Freeze some internal std lib protocols

@swift-ci please test

airspeedswift

comment created time in 3 months

push eventairspeedswift/swift

Ben Cohen

commit sha 05a7d923349059e5ebd3b7523ba7dc60e7cba039

Update ABI to reflect newly frozen protocols

view details

push time in 3 months

push eventapple/swift

Joe Groff

commit sha 9a3a92b99f565aca85df8a83acb29a0efd7d6b96

IRGen: Give ObjC metadata symbols internal linkage. (#33193) This preserves the symbol names in (unstripped) binaries, so we can use them for link ordering and memory usage analysis.

view details

push time in 3 months

PR merged apple/swift

[5.3] IRGen: Give ObjC metadata symbols internal linkage. r5.3

Explanation: This preserves the symbol names for ObjC metadata for Swift classes in (unstripped) binaries, so we can use them for link ordering and memory usage analysis.

Risk: Low, should be no impact on runtime behavior

Issue: rdar://problem/66292096

Testing: Swift CI

Reviewed by: @aschwaighofer

+82 -82

6 comments

25 changed files

jckarter

pr closed time in 3 months

pull request commentapple/swift

[stdlib] Freeze some internal std lib protocols

@swift-ci please test

airspeedswift

comment created time in 3 months

push eventairspeedswift/swift

Valeriy Van

commit sha dd237b984b45f8bdd1b639eb9061423e3a76e4a0

Eliminates redundant buffer zeroing in internal func in UnicodeScalarProperties by using `init(unsafeUninitializedCapacity:initializingWith:)`

view details

Butta

commit sha 32d341e244d4a56185ed04c60542250b5b5047e9

[build] extend support for building with a prebuilt toolchain to the corelibs and llbuild

view details

Varun Gandhi

commit sha 986f27f7713c04149bedb25411e54202c88ac8a5

[NFC] Separate out trace import filtering into a separate function.

view details

Holly Borla

commit sha c8e9018c4d6c7936c3ce4ea9ce35bf8aa705574d

[CSGen] Don't merge type variables for literals in computeFavoredTypeForExpr

view details

Brent Royal-Gordon

commit sha 57469a64724d6994a3813326036eb7b7a6359943

Allow shadowing of unavailable members This change permits a subclass to redeclare an unavailable member from a superclass. For instance, suppose you write this code (or, more likely, a version where `Base` is an ObjC class): ```swift class Base { @available(*, unavailable) init() {} } class Derived: Base { /* override */ init() {} } ``` Previously, Swift would reject `Derived.init()` without the `override` keyword, telling you that you should add it, but it would also reject it *with* the `override` keyword, telling you that you can't override something that's unavailable. This PR makes Swift accept it without the `override` keyword; declaring it with the keyword is still forbidden. Fixes rdar://65702529.

view details

Holly Borla

commit sha 71b3ac4d811b16888d40d7c74d7a4b08a5b3d3b5

[CSGen] Remove literal type variable tracking from LinkedTypeInfo.

view details

Ben Langmuir

commit sha 9c08fc0ddd7a8d80781568b52ce2cb51065614f4

[test] Fix annotation test to have same behaviour before and after update The goal of the test is to test the behaviour when the edit is range-shifted, but in the (rare) case where the document update happens before the edit finishes, we need the ranges to be the same. In particular, using separate statements ensures that the tokens not touched by the edit are not affected by the edit. Re-enable the test disabled on ASan, since this seems to be the underlying issue. rdar://65934938

view details

Ben Langmuir

commit sha 8e352b8006634d2391a7215f35e282bcb7b6ae1b

[sourcekitd] Fix range shifting "race" with a fast semantic update If a semantic update finishes fast enough, the token snapshot may be identical to the edit snapshot, but because of getBufferForSnapshot consolidating edits into a new buffer, we were not detecting that case properly, and it could cause an assertion failure (or potentially incorrect range shifting in a release build). This would have reproduced very rarely in practice, but I can reproduce it by putting `sleep(2)` calls right before we read the semantic info in open and edit requests. Incidentally, fix sourcekit-test and unit tests for the (rare) case where an open or edit already has updated semantic info.

view details

Ktwu

commit sha b89a119e9bcdd2bf8012a9cdfeda4ef9e3b5db51

Fix stdlib builds

view details

3405691582

commit sha a86a540d520b93a5f7f3c57b6f73d75aeec84f75

[test] Invert stdlib_dir conditional sense. In #32903, a substitution pseudovariable was introduced to refer to the path containing Swift.swiftmodule. Since builds on Linux put this file in a path with a subdirectory named after the architecture name -- and presumably builds on mac OS do not, a conditional was required to distinguish these two cases. However, builds on OpenBSD for example also put Swift.swiftmodule in a similar subdirectory like Linux. Thus, invert the sense of this conditional to encompass both Linux, OpenBSD, and make mac OS the specific case, which it is here.

view details

Ben Langmuir

commit sha 589b919ad19b6d288b1297699df8723614ef6490

Merge pull request #33063 from benlangmuir/racing-edit [sourcekitd] Fix range shifting vs semantic update timing issues

view details

Saleem Abdulrasool

commit sha deff87d4e83d3afe22f191b1b27ca4cbe114295d

validation-test: make scale-test explicitly handle encoding During the Python 2 to Python 3 conversion, the difference in encoding became apparent. Explicitly handle the encoding by opening the file with an explicit encoding. This prevents falling back to the `C` locale which will use ASCII for UTF-8 which fails.

view details

Suyash Srijan

commit sha 42779d66c7fb76c61caa7c3d1c055a5715bfe63c

[NFC] Remove some dead variadic tuple code (#33059) * [ASTDemangler] Remove 'isVariadic' parameter from 'createTupleType' * [TypeDecoder] Remove 'variadic' argument from 'createTupleType' call * [Reflection] Remove support for variadic from TupleTypeRef * [Remote] Remove 'variadic' argument from 'createTupleType' call * [Runtime] Remove 'variadic' parameter from createTupleType in MetadataLookup * [Test] Remove variadic tuple typeref tests * [Reflection] Restore accidentally deleted code from 'visitFunctionTypeRef'

view details

Rintaro Ishizaki

commit sha f2502b9f61eeecb898818658e437f5101d48d06a

[Test] Add indexing test cases for ExplicitCastExpr

view details

Mishal Shah

commit sha a43626639f920b7a03d2645dd066dcc0c787beb1

Only execute test for supported simulator plaforms

view details

zoecarver

commit sha 5c3ccf50506543d39d8fc3d227909e1e6ee5bb16

[cxx-interop] Temporarily disable emitting debug info for C++ types. When we try to emit debug info from C++ types we crash because we can't deserialize them. This is a temporary fix to circumnavigate the crash before a real fix can be created.

view details

Mishal Shah

commit sha 3dc8b38bbeeb99dad9205e08389e216cb6836c0a

Merge pull request #32922 from buttaface/prebuilt [build] extend support for building with a prebuilt toolchain to the corelibs and llbuild

view details

zoecarver

commit sha b2e6068d4f2444cd8a60e86d17b81a18df05cb1a

[cxx-interop] Rename ClangRecordTypeInfo -> LoadableClangRecordTypeInfo. This is a more accurate and clear name. This change will help further differenciate between LoadableClangRecordTypeInfo and (the soon to be added) AddressOnlyClangRecordTypeInfo.

view details

Saleem Abdulrasool

commit sha d6ea573092c8b3da1435dc850e3abaf8af093755

Merge pull request #33051 from compnerd/encoded validation-test: make scale-test explicitly handle encoding

view details

Saleem Abdulrasool

commit sha 9f0e0a6e2edd27f53913fb9339742d3a95296423

build: remove PythonKit integration

view details

push time in 3 months

more