profile
viewpoint

push eventafinch7/deno

Mark Tiedemann

commit sha 953a5a31dbda1d79065d842cf312e3149d2c70a4

Adjust powershell installer commands (#2627)

view details

Ryan Dahl

commit sha d7fa8c3207751259a647c7b90aa5e2591401834a

Update deno.land links v0.11 (#2628)

view details

Bartek Iwańczuk

commit sha 963d56fc5e5a410108dcdff083d64c0a762658c0

fix for '-' arg after script name (#2631)

view details

Bert Belder

commit sha db5c66a638d399d5ebb2832bb7b52e8f76ced49d

Upgrade rust to v1.36.0

view details

Bert Belder

commit sha abe8a113ad8004f160eac5f3f115cb28c5072ba7

Refactor error to use dynamic dispatch and traits This is in preperation for dynamic import (#1789), which is more easily implemented when errors are dynamic.

view details

Ryan Dahl

commit sha 1fde15c0bc77e0c5cc6f7cbf27b4e072e1ad6c46

Fix REPL when it receives EOF (#2638)

view details

Ryan Dahl

commit sha bd6ebb32df11641e148fd0adca41e7188f16afce

hyper_hello should be in its own crate (#2641) So that "cargo build" will build it when the gn frontend is eventually removed.

view details

Yoshiya Hinosawa

commit sha 9c454998646ef49f652bc919f53503ed07a1c55c

Support window.onload (#2643)

view details

afinch7

commit sha fb33832a02e519775126d7d70423b65589f8588a

Feature: Native plugins

view details

push time in an hour

Pull request review commentdenoland/deno

[WIP] Refactor to use new futures api

 fn resolve_uri_from_location(base_uri: &Uri, location: &str) -> Uri {  #[cfg(test)] use crate::tokio_util;+#[cfg(test)]+use futures::future::FutureExt;+#[cfg(test)]+use hyper::Body;

SGTM

afinch7

comment created time in an hour

Pull request review commentdenoland/deno

[WIP] Refactor to use new futures api

 impl Resource {           "Another accept task is ongoing",         ));       }-      t.replace(futures::task::current());+      // TODO(afinch7) replace this.+      // t.replace(futures::task::current());

AtomicWaker ?

afinch7

comment created time in an hour

push eventafinch7/deno

Ryan Dahl

commit sha bd6ebb32df11641e148fd0adca41e7188f16afce

hyper_hello should be in its own crate (#2641) So that "cargo build" will build it when the gn frontend is eventually removed.

view details

Yoshiya Hinosawa

commit sha 9c454998646ef49f652bc919f53503ed07a1c55c

Support window.onload (#2643)

view details

afinch7

commit sha f980a97c3e5ca5c95d1bfe3d9ccaa9db84a00963

use new std::future

view details

push time in 2 hours

Pull request review commentdenoland/deno

[WIP] Refactor to use new futures api

 fn resolve_uri_from_location(base_uri: &Uri, location: &str) -> Uri {  #[cfg(test)] use crate::tokio_util;+#[cfg(test)]+use futures::future::FutureExt;+#[cfg(test)]+use hyper::Body;

We can, but it's a bit of a pain. I figured I would hold off on that for now.

afinch7

comment created time in 2 hours

push eventafinch7/deno

afinch7

commit sha 3aab4b179cab8001b8deb493a19655db9c5e2a68

use new std::future

view details

push time in 4 days

push eventafinch7/deno

Bartek Iwańczuk

commit sha 963d56fc5e5a410108dcdff083d64c0a762658c0

fix for '-' arg after script name (#2631)

view details

Bert Belder

commit sha db5c66a638d399d5ebb2832bb7b52e8f76ced49d

Upgrade rust to v1.36.0

view details

Bert Belder

commit sha abe8a113ad8004f160eac5f3f115cb28c5072ba7

Refactor error to use dynamic dispatch and traits This is in preperation for dynamic import (#1789), which is more easily implemented when errors are dynamic.

view details

Ryan Dahl

commit sha 1fde15c0bc77e0c5cc6f7cbf27b4e072e1ad6c46

Fix REPL when it receives EOF (#2638)

view details

afinch7

commit sha 928685455e5c9ebfd37840dc7b5c99c9726dac39

use new std::future

view details

push time in 4 days

push eventafinch7/deno

afinch7

commit sha f0e3f4e0f893f97612c6a18b2f5b05e6d4e9f2e9

fixes

view details

push time in 4 days

push eventafinch7/deno

afinch7

commit sha 095f7382aeb4f2fb8d5d2a1180da4d483db47001

fix

view details

push time in 4 days

push eventafinch7/deno

afinch7

commit sha 2e676f6839f5b500f007eae531a730bd9df4183e

updated cli

view details

push time in 5 days

push eventafinch7/tokio

afinch7

commit sha 93964c092d50b0c02839ff36fc06806325fd8f05

fmt

view details

push time in 5 days

push eventafinch7/tokio

afinch7

commit sha 8bc56b62aa6e7303400769a0cd3318d9f17882cc

update windows implementations

view details

afinch7

commit sha f19ad51bec5815b034ef878e27d20ed6377ff446

move futures-util-preview to dev dependencies

view details

afinch7

commit sha 9d0d30c4bd04218e6401011dda02e57de25bb1ae

uncomment tokio-fs in tokio dependencies

view details

push time in 5 days

push eventafinch7/tokio

afinch7

commit sha a4557d8995efe5f2b5fd2fbd53f446dbcbeba606

rename examples folder

view details

push time in 6 days

push eventafinch7/tokio

afinch7

commit sha 7d84b796496cca8517471e66a0e0cfe44d6e5b78

enable tokio-fs tests

view details

push time in 6 days

push eventafinch7/tokio

afinch7

commit sha 3b4767f2e896d446cf50d9100ce9538fc7aec462

enable tokio-fs tests

view details

push time in 6 days

pull request commenttokio-rs/tokio

Update tokio-fs to use `std::future`

Just realized the tests are still meaning less need to uncomment this https://github.com/tokio-rs/tokio/blob/7ac8bfc82133a19cabc917e5ab55902e3b2441df/azure-pipelines.yml#L33

afinch7

comment created time in 6 days

push eventafinch7/tokio

afinch7

commit sha a82bc8c225a805e2eaa8ec322c1a5f5a1f275c0a

fixed read/write functions and unit tests

view details

push time in 6 days

push eventafinch7/deno

Ryan Dahl

commit sha 33cb79d24cf03c2c771dfa499e4cc8ee7bcee800

Fix links (#2614)

view details

Yoshiya Hinosawa

commit sha a948f9ff541e5983bc29113d1e0f1898206f8581

io: change Reader interface (#2591) Instead of returning { nread: number, eof: bool }, read() returns EOF | number.

view details

Ryan Dahl

commit sha 92ac616708cb067a1b895283913c5ecd25c6d873

v0.11.0

view details

Bert Belder

commit sha 9b1997b8b6f82e17e42c43aae3621e2b932f5843

core: clearly define when module lookup is path-based vs URL-based The rules are now as follows: * In `import` statements, as mandated by the WHATWG specification, the import specifier is always treated as a URL. If it is a relative URL, it must start with either / or ./ or ../ * A script name passed to deno as a command line argument may be either an absolute URL or a local path. - If the name starts with a valid URI scheme followed by a colon, e.g. 'http:', 'https:', 'file:', 'foo+bar:', it always interpreted as a URL (even if Deno doesn't support the indicated protocol). - Otherwise, the script name is interpreted as a local path. The local path may be relative, and operating system semantics determine how it is resolved. Prefixing a relative path with ./ is not required.

view details

Bartek Iwańczuk

commit sha 72d9045528ad69ec32d7de9707cea65fab9f405e

cli: refactor deno_dir to use Url instead of String

view details

Bert Belder

commit sha f4c9b314056b002a01ac0bd5fc33f6503aba5ab2

core: replace ModuleSpecifier::to_url() by as_url()

view details

Bert Belder

commit sha afd66bb0105d87fd67e59b7455f77a6a4d1429e2

cli: generate default file name for bundle when URL ends in a slash

view details

Bert Belder

commit sha 958a80e6db9b87985898acf2f4f33e46d4740c3b

rustfmt: disable format_macro_bodies It doesn't work since we're not using rustfmt-nightly.

view details

Bert Belder

commit sha 79c3439f269f1e0e24003518e363988fa4f1da33

Pass env vars through in build_extra/rust/run.py This fixes an appveyor issue that arrises when implementing snapshot_creator in Rust.

view details

Bartek Iwańczuk

commit sha d641782c823317a2d2f64d646a0d5b8b6c22b771

Rewrite snapshot_creator in Rust

view details

Ryan Dahl

commit sha 52c0764e4fd56928fca0b201c9d402b25d3f2145

Upgrade v8 to 7.7.200 (#2624)

view details

Mark Tiedemann

commit sha 953a5a31dbda1d79065d842cf312e3149d2c70a4

Adjust powershell installer commands (#2627)

view details

Ryan Dahl

commit sha d7fa8c3207751259a647c7b90aa5e2591401834a

Update deno.land links v0.11 (#2628)

view details

afinch7

commit sha 3e5ff661a089108f2846e1144b5f7ffc112199ef

first pass on core

view details

afinch7

commit sha fd4a9b68aae3d03f2d9ed11c2dbc32087562cbb1

wip

view details

push time in 6 days

create barnchafinch7/deno_third_party

branch : add_futures_preview

created branch time in 6 days

push eventafinch7/deno

afinch7

commit sha 80fe8f179a6cc5a83da79f02acfe030105be1f0b

fix std submodule

view details

push time in 6 days

create barnchafinch7/deno

branch : ci_release_mode

created branch time in 6 days

push eventafinch7/deno

afinch7

commit sha fbc66ea1948deb9b68dd1ad1277b55d97b758919

use build_mode to determine build mode and add --release flag to travis build

view details

push time in 6 days

push eventafinch7/deno

afinch7

commit sha 2f715c9b222a2018dcd857e91f6389dabff879a5

add test plugin cargo build to build.py

view details

push time in 7 days

push eventafinch7/deno

Ryan Dahl

commit sha 33cb79d24cf03c2c771dfa499e4cc8ee7bcee800

Fix links (#2614)

view details

Yoshiya Hinosawa

commit sha a948f9ff541e5983bc29113d1e0f1898206f8581

io: change Reader interface (#2591) Instead of returning { nread: number, eof: bool }, read() returns EOF | number.

view details

Ryan Dahl

commit sha 92ac616708cb067a1b895283913c5ecd25c6d873

v0.11.0

view details

Bert Belder

commit sha 9b1997b8b6f82e17e42c43aae3621e2b932f5843

core: clearly define when module lookup is path-based vs URL-based The rules are now as follows: * In `import` statements, as mandated by the WHATWG specification, the import specifier is always treated as a URL. If it is a relative URL, it must start with either / or ./ or ../ * A script name passed to deno as a command line argument may be either an absolute URL or a local path. - If the name starts with a valid URI scheme followed by a colon, e.g. 'http:', 'https:', 'file:', 'foo+bar:', it always interpreted as a URL (even if Deno doesn't support the indicated protocol). - Otherwise, the script name is interpreted as a local path. The local path may be relative, and operating system semantics determine how it is resolved. Prefixing a relative path with ./ is not required.

view details

Bartek Iwańczuk

commit sha 72d9045528ad69ec32d7de9707cea65fab9f405e

cli: refactor deno_dir to use Url instead of String

view details

Bert Belder

commit sha f4c9b314056b002a01ac0bd5fc33f6503aba5ab2

core: replace ModuleSpecifier::to_url() by as_url()

view details

Bert Belder

commit sha afd66bb0105d87fd67e59b7455f77a6a4d1429e2

cli: generate default file name for bundle when URL ends in a slash

view details

Bert Belder

commit sha 958a80e6db9b87985898acf2f4f33e46d4740c3b

rustfmt: disable format_macro_bodies It doesn't work since we're not using rustfmt-nightly.

view details

Bert Belder

commit sha 79c3439f269f1e0e24003518e363988fa4f1da33

Pass env vars through in build_extra/rust/run.py This fixes an appveyor issue that arrises when implementing snapshot_creator in Rust.

view details

Bartek Iwańczuk

commit sha d641782c823317a2d2f64d646a0d5b8b6c22b771

Rewrite snapshot_creator in Rust

view details

Ryan Dahl

commit sha 52c0764e4fd56928fca0b201c9d402b25d3f2145

Upgrade v8 to 7.7.200 (#2624)

view details

afinch7

commit sha 5cdf630e121bcfaacedf0a34e3afa00419219720

Merge remote-tracking branch 'upstream/master' into native_bindings

view details

push time in 7 days

push eventafinch7/deno_third_party

Ryan Dahl

commit sha 0c73a12659afc92cee1b227f37f4df85188b0850

Upgrade V8 to 7.7.200

view details

Ryan Dahl

commit sha e319136a1744710ffd3c2ea372a7dfc1d462f120

Float patch to fix non-ICU build https://chromium-review.googlesource.com/c/v8/v8/+/1687278

view details

afinch7

commit sha 828e597fb278a074e1d8f5fd203c7e6db411bbda

add crate dlopen

view details

push time in 7 days

push eventafinch7/tokio

andy

commit sha c3546721be48d34791ec665e8272a243e7896bf7

refactored tokio-fs tests to use tokio::test

view details

push time in 10 days

push eventafinch7/tokio

andy

commit sha 92f636012cade5a038e61f82863223ea9ab8219c

fmt + remote explicit Unpin implementations

view details

push time in 10 days

Pull request review commenttokio-rs/tokio

Update tokio-fs to use `std::future`

 where     } } +impl<P> Unpin for CreateFuture<P> {} 

Kinda new to Pin/Unpin. Didn't really occur to me that this would satisfy the requirements for Unpin global implementations. :+1:

afinch7

comment created time in 10 days

push eventafinch7/tokio

afinch7

commit sha f68d0845eab20647bca3e7b5dbda542f635ad9d6

wip

view details

push time in 11 days

push eventafinch7/tokio

Taiki Endo

commit sha 7b86acb71d11664f64104854ea69d41d9772786e

chore: Update futures-preview to 0.3.0-alpha.17 (#1267)

view details

afinch7

commit sha a4e723712f542132c066190dce8bf5645f30d7d3

wip

view details

push time in 11 days

pull request commentdenoland/deno

Feature: Native plugins

@ry I don't think so. Also I forgot to mention that patch is for //build. Maybe just add "cargo build -p test_plugin ${release ? '--release' : '' }" or something similar to //tools/build.py for now? Your plan is to move all builds to cargo in the future right?

afinch7

comment created time in 12 days

push eventafinch7/deno

afinch7

commit sha bebb351ee9dc4acfe46bc4309493b14facffbc2d

wip

view details

push time in 12 days

PR opened tokio-rs/tokio

Update tokio-fs to use `std::future`
+303 -167

0 comment

33 changed files

pr created time in 12 days

push eventafinch7/tokio

afinch7

commit sha 117f9800d51ed8ee997481eaae1ca8ef313f35f1

wip

view details

push time in 12 days

create barnchafinch7/tokio

branch : new_futures_tokio_fs

created branch time in 12 days

PR closed tokio-rs/tokio

Move try_ready macro to tokio-futures

Preparing to work on #1192

+18 -15

1 comment

3 changed files

afinch7

pr closed time in 12 days

pull request commenttokio-rs/tokio

Move try_ready macro to tokio-futures

I saw that, wasn't sure though.

afinch7

comment created time in 12 days

PR opened tokio-rs/tokio

Move try_ready macro to tokio-futures
+18 -15

0 comment

3 changed files

pr created time in 12 days

create barnchafinch7/tokio

branch : move_try_ready_macro

created branch time in 12 days

fork afinch7/tokio

A runtime for writing reliable, asynchronous, and slim applications with the Rust programming language.

https://tokio.rs

fork in 12 days

PR opened denoland/deno

[WIP] Refactor to use new futures api

Currently depends on a alpha version of futures-preview, but with std::future now on stable we should get a stable release of futures 0.3 soon.

+519 -402

0 comment

7 changed files

pr created time in 12 days

create barnchafinch7/deno

branch : rust_futures_api

created branch time in 12 days

pull request commentdenoland/deno

Feature: Native plugins

In further testing I discovered that asyncs don't work correctly. futures::task::current() is completely broken in any loaded plugins. This is a limitation of the current version of the futures crate. The only real solution here is to convert everything to use the new futures api that landed with rust 1.36.0.

afinch7

comment created time in 12 days

create barnchafinch7/deno

branch : native_bindings_rust_futures_api

created branch time in 13 days

push eventafinch7/deno

afinch7

commit sha 4d3862f2f21011ed5dab0dde2b5d3839959a79bc

add async test op to test plugin

view details

push time in 14 days

push eventafinch7/deno

afinch7

commit sha 1961a123021117c583bb18af026f434be80dede0

add async test op to test plugin

view details

push time in 14 days

push eventafinch7/deno

afinch7

commit sha a07c5962f721053496d8934f89a1041c06b68977

add async test op to test plugin

view details

push time in 14 days

push eventafinch7/deno

andy finch

commit sha 83fe39701651058ae8c824621b7ef3849704fe07

update rust version for ci (#2599)

view details

matzkoh

commit sha 1b48d67fbba55d64372052879d26bf8e2143d9c7

docs(style_guide): fix typoFixes a small syntax error (#2567)

view details

Ryan Dahl

commit sha cde81c6a53bcb7e5e12a1f8d6003826544eff38e

manual: adjust windows build instructions (#2601)

view details

Bartek Iwańczuk

commit sha 38cf346d5c0f69dfb0919781fb61db7a6597ded1

feat: parse flags after script name (#2596)

view details

Bartek Iwańczuk

commit sha 5a4bebb77080d8a72a3faa594a388c6bce46e346

fix: test output for completions (#2597)

view details

Yoshiya Hinosawa

commit sha 1068b4848c4d6d9a444d2d2bca5f25d822c42ff5

ts_library_builder: update README (#2604)

view details

Bartek Iwańczuk

commit sha 9d18f97327e94ecf6fd0ae7b75a88abfeac07d7e

fix: normalize Deno.execPath (#2598)

view details

Bert Belder

commit sha 32cde32e54a0c8c73b7bc3da9a3ade8d739cc0b5

core: return useful error when import path has no prefix like ./

view details

andy finch

commit sha 6a3bdb74bc17e982cc298c07434754a2c3e9a14e

Merge branch 'master' into native_bindings

view details

push time in 15 days

push eventafinch7/deno_std

andy

commit sha 8c4b70fd1ee8fdd6a515fa2d8851d64cb5d94cd4

fmt

view details

push time in 17 days

push eventafinch7/deno_std

andy

commit sha 908a88531f31556061392a336f0f9ba7620192be

basic cargo binding plugin

view details

push time in 17 days

push eventafinch7/deno_std

Yoshiya Hinosawa

commit sha 7daa887b09d4662710ad58e68de1a01a318455bb

Check file changes during test (#476)

view details

Xin Du (Clark)

commit sha 3041edb152e9215952c1c69522d3dedb2b345428

datetime: use assertThrows in test (#473)

view details

Kitson Kelly

commit sha 2292fbe6b1935588e19bc2736b364e82b7c5d38e

Remove console.error from asserts. (#483)

view details

Xin Du (Clark)

commit sha c64734cbd980dad79ebc04015a16de0b9f654325

use unknown instead of any (#486)

view details

Ryan Dahl

commit sha 86b7499e658a70d734e1e02fef50e1d9e26f6f56

upgrade: deno to v0.8.0 (#487)

view details

Kitson Kelly

commit sha fe7f6e117fee724bf8f9b44526de1add7da7dfdd

Add bundle loader (#480)

view details

Sam Reghenzi

commit sha 3ec3a8b4f1eee8b5c6d90db6a30a6ab38afa05c8

fix wrong field name in example code (#490)

view details

Bartek Iwańczuk

commit sha a3015be14195df46486a49e5c791afba4dfe084a

feat: installer (#489)

view details

Ryan Dahl

commit sha 1679ba0b57e27624b3d3fdc303dccbe69a9d798d

installer: Print name of installed file (#492)

view details

Ryan Dahl

commit sha 33bc3db00105e2572a7e3abd6da8591cbc5abae1

ci: bump version to v0.9.0 (#493)

view details

Axetroy

commit sha aa628cb926078375c3164711e49af1bd71825983

fix installer readme (#495)

view details

Axetroy

commit sha 418cdff25d022e8abfd4423f1535173c2e7c2210

add encoding/hex module (#434)

view details

Axetroy

commit sha a68527f3fe0a006a64a2df9c5f380f5a2274a531

Installer: support windows (#499)

view details

Axetroy

commit sha b04fda30c8949b6347094b898bfa427c0b9a6162

lint: add max line length rules (#507)

view details

Vincent LE GOFF

commit sha d44a47a08d53a5a5d94de8aabde6c1682b8e54c6

Testing: Pretty output + Silent mode (#314)

view details

Axetroy

commit sha 4317af11d18e67dbc79b0df9839180f8e4e55613

installer: quote commands correctly (#510)

view details

Bartek Iwańczuk

commit sha b13441fe8af151f60cdc2336c53a7196f56fd5b0

improve installer (#512) - remove uninstall command - add --reload to deno fetch - to ensure subsequent installation upgrades script and deps - fix executable shebang - fix prompt for subsequent installation - support custom installation dir via -d/--dir flag

view details

Amen

commit sha 4804e50b23e7a2a494bce270f18fa89eb1c20ebe

typo (#515)

view details

Kitson Kelly

commit sha 02262c61612fdeda1ddd9e987f04f320d17b0c89

bundle/run handles Deno.args better. (#514)

view details

Bartek Iwańczuk

commit sha 4772c34521f7abba6c7038273e185c6a96f8f216

fix: pin eslint version for CI (#518) https://github.com/typescript-eslint/typescript-eslint/issues/637

view details

push time in 17 days

pull request commentdenoland/deno

Feature: Native plugins

This patch resolves the issue with windows, but it wouldn't really be a debug build anymore

diff --git a/config/BUILD.gn b/config/BUILD.gn
index 3f37c75c1..d41dd38ef 100644
--- a/config/BUILD.gn
+++ b/config/BUILD.gn
@@ -148,7 +148,6 @@ config("feature_flags") {
 
 config("debug") {
   defines = [
-    "_DEBUG",
     "DYNAMIC_ANNOTATIONS_ENABLED=1",
     "WTF_USE_DYNAMIC_ANNOTATIONS=1",
   ]
diff --git a/config/win/BUILD.gn b/config/win/BUILD.gn
index b5a58459a..9963db297 100644
--- a/config/win/BUILD.gn
+++ b/config/win/BUILD.gn
@@ -422,7 +422,7 @@ config("release_crt") {
 config("dynamic_crt") {
   if (is_debug) {
     # This pulls in the DLL debug CRT and defines _DEBUG
-    cflags = [ "/MDd" ]
+    cflags = [ "/MD" ]
   } else {
     cflags = [ "/MD" ]
   }
@@ -431,7 +431,7 @@ config("dynamic_crt") {
 config("static_crt") {
   if (is_debug) {
     # This pulls in the static debug CRT and defines _DEBUG
-    cflags = [ "/MTd" ]
+    cflags = [ "/MT" ]
   } else {
     cflags = [ "/MT" ]
   }

It seems like we need to add a arg to the linker via -Clink-args ideally near this https://github.com/denoland/deno/blob/1b48d67fbba55d64372052879d26bf8e2143d9c7/build_extra/rust/rust.gni#L247-L252 I.E.

if (is_debug) {
  args += "-Clink-args='/someflag'"
}
afinch7

comment created time in 17 days

push eventafinch7/deno

Evgeniy Karagodin

commit sha d089f9797830a2729cbd45cb4ea6312eb43a28de

Add homeDir to Deno namespace (#2578)

view details

Bartek Iwańczuk

commit sha 6906a2f75e428221f8b9bfa28b2c6821eb3ebe30

feat: deno completions command (#2577)

view details

Jimmy Cao

commit sha fb6d57a28172aeaaa5fdb31d5775e190bdfaa1c1

fix: run blocking function on a different task (#2570) This avoids freezing the current task if the fn blocks indefinitely

view details

Gurwinder Singh

commit sha d7d3e9f9dea7bf3f6e0c6e15e1bb3d2326f0fdf9

Fix multiple error messages for a missing file (#2587)

view details

迷渡

commit sha a5441003fe54dbdd93d243d2a5f3732447464e0c

rename shellsession to shell (#2583)

view details

afinch7

commit sha 7d34bf5ddc4245e3d7d6f631bded1235482fa20d

update rust version for ci

view details

afinch7

commit sha 197e06b886ebc2fb2a2053b3f3f33305e4b9e18f

Feature: Native Plugins

view details

Ryan Dahl

commit sha 280a431e155e1bec9efc25981d9e43344f41d804

fix

view details

afinch7

commit sha 102cd0a774c41f08114637a604aa28c85cd647e0

renames

view details

afinch7

commit sha 36c244d9d05a115066b46de27a3a1b2c3aeefda9

format test plugin

view details

afinch7

commit sha e050b431b35a59576586720671458e898c61b934

simplify plugin dispatch

view details

afinch7

commit sha 6b92e095b0a52442502c6b94c62328ce45355efa

fixes

view details

Ryan Dahl

commit sha 2ac483efb54d66aaed886f3be1cc10d70cc61258

Add //tests/plugin/BUILD.gn

view details

push time in 18 days

PR opened denoland/deno

Update rust for ci

This seems to fix the issues with #2385 appveyor build.

+2 -2

0 comment

2 changed files

pr created time in 18 days

create barnchafinch7/deno

branch : update_rust

created branch time in 18 days

Pull request review commentdenoland/deno

Feature: Native plugins

 const { openPlugin, pluginFilename, env } = Deno;  const plugin = openPlugin(-  env().DENO_BUILD_PATH + "/" + pluginFilename("test_plugin")+  env().DENO_BUILD_PATH + "/rust_crates/" + pluginFilename("test_plugin")

tools/build.py --release works fine on windows, but tools/build.py doesn't for some reason.

afinch7

comment created time in 19 days

push eventafinch7/deno

Ryan Dahl

commit sha 49817d0c8c99e2c8e78c525e026ab3add8e882a2

Add //tests/plugin/BUILD.gn

view details

push time in 20 days

Pull request review commentdenoland/deno

Feature: Native plugins

+const { openPlugin, pluginFilename, env } = Deno;++const plugin = openPlugin(+  env().DENO_BUILD_PATH + "/" + pluginFilename("test_plugin")+);+const testOp = plugin.loadOp("test_op");++interface TestOptions {+  // eslint-disable-next-line @typescript-eslint/no-explicit-any+  data: any;+  // eslint-disable-next-line @typescript-eslint/no-explicit-any+  zeroCopyData: any;+}++interface TestResponse {+  data: Uint8Array;+}++const textEncoder = new TextEncoder();++// eslint-disable-next-line @typescript-eslint/no-explicit-any+function encodeTestOp(args: any): Uint8Array {

I don't think so.

afinch7

comment created time in 20 days

Pull request review commentdenoland/deno

Feature: Native plugins

 const { openPlugin, pluginFilename, env } = Deno;  const plugin = openPlugin(-  env().DENO_BUILD_PATH + "/" + pluginFilename("test_plugin")+  env().DENO_BUILD_PATH + "/rust_crates/" + pluginFilename("test_plugin")

It is, but it works. Any idea what is up with the appveyor build?

afinch7

comment created time in 20 days

push eventafinch7/deno

afinch7

commit sha 1c162f7758fed57f8e28c3d764f2c91a8611ba1e

fixes

view details

push time in 21 days

Pull request review commentdenoland/deno

Feature: Native plugins

 install:   # Clone the third_party submodule.   - ps: |-       try {-        Exec { & git submodule update --init --force --depth 1 }+        Exec { & git submodule update --init --force --recursive --depth 2 }       } catch {         # Git will fail if the `third_party` directory was restored from cache,         # but the `.git/modules` directory wasn't. Rebuild it from scratch.         Delete-Tree $env:DENO_THIRD_PARTY_PATH-        Exec -NoNewLines { & git submodule update --init --force --depth 1 }+        Exec -NoNewLines { & git submodule update --init --force --recursive --depth 2 }

old

afinch7

comment created time in 21 days

push eventafinch7/deno

afinch7

commit sha cb5c5695f42dd8e92479f8af4d225c9ec65fdd39

simplify plugin dispatch

view details

push time in 21 days

push eventafinch7/deno

Ryan Dahl

commit sha d1482c6b8abfdd8201f8d1845a5de75105f3cbc4

Upgrade deno_std (#2565)

view details

Ryan Dahl

commit sha 046cbef4f0f11e37d6ffb8b01c6362c8ce0b750d

simplify check_net test

view details

Bert Belder

commit sha 89216c7baaab8ade3daf9103572647addeb404f3

third_party: add rust crate 'termcolor'

view details

Ryan Dahl

commit sha 3a4d88475b40a17f2ce17b775a3f07c78be83d79

Port code from Cargo and use for progress A lot of its functionality is unused still, but the goal it to slowly migrate logging functionality to it. There is also a useful progress bar which can be ported over later - it depends on this module. https://github.com/rust-lang/cargo/blob/4c1fa54d10f58d69ac9ff55be68e1b1c25ecb816/src/cargo/util/progress.rs

view details

Ryan Dahl

commit sha c56df45355c8e68eabbfa62021e7ca7484115c0b

v0.10.0

view details

afinch7

commit sha 8131917fbe40eb96a3df5fdf5d314d667c59eddd

Feature: Native Plugins

view details

Ryan Dahl

commit sha 5141b45719837717c199fba18b4314c9c4b20de4

fix

view details

afinch7

commit sha 1c2f6be6359becf299e984c67a7e097efe6819ae

renames

view details

afinch7

commit sha 10036615d75044503b7d1bc25c992891e9dfc063

format test plugin

view details

push time in 21 days

push eventafinch7/deno

afinch7

commit sha 16ea973557fe3b5f5eb00e5f246f5e6e20878781

update third party

view details

push time in 21 days

push eventafinch7/deno_third_party

Bert Belder

commit sha 4c9d6c9f133cae292528d3b68e55249acd8c1b16

Add rust crate 'termcolor'

view details

Ryan Dahl

commit sha 159c954ab0e11f655c7cb2a36302c0261c3e121b

Add fwdansi

view details

afinch7

commit sha 62b961e7d4c40114ffafd728875689918c372e47

add crate dlopen

view details

push time in 21 days

push eventafinch7/deno

afinch7

commit sha a2e047082024f20610ef4595656773f1900039fe

renames

view details

afinch7

commit sha 6492888d127b1873e57f0425542c357d35df9042

format test plugin

view details

push time in 21 days

push eventafinch7/deno

afinch7

commit sha 6d2fc5cda0dbc9d9d678de2cd939d092acd0cc64

renames

view details

afinch7

commit sha b8c0e11f45db75792a347dfff68d20116a9644b7

format test plugin

view details

afinch7

commit sha 04c0bdc1ff5dc6e40aed465a354f5f67f9c4f7fe

Merge branch 'native_bindings' of https://github.com/afinch7/deno into native_bindings

view details

push time in 21 days

Pull request review commentdenoland/deno

Feature: Native plugins

+use crate::isolate::Op;+use crate::libdeno::PinnedBuf;+use std::fmt;+use std::io;++pub type PluginResult<T> = std::result::Result<T, PluginError>;++#[derive(Debug)]+pub struct PluginError {+  repr: Repr,+}++#[derive(Debug)]+enum Repr {+  Simple(String),+  IoErr(io::Error),+}++pub fn new_plugin_error(msg: String) -> PluginError {+  PluginError {+    repr: Repr::Simple(msg),+  }+}++impl fmt::Display for PluginError {+  fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {+    match self.repr {+      Repr::Simple(ref err_str) => f.pad(err_str),+      Repr::IoErr(ref err) => err.fmt(f),+    }+  }+}++impl std::error::Error for PluginError {+  fn description(&self) -> &str {+    match self.repr {+      Repr::Simple(ref msg) => msg.as_str(),+      Repr::IoErr(ref err) => err.description(),+    }+  }++  fn cause(&self) -> Option<&dyn std::error::Error> {+    match self.repr {+      Repr::Simple(ref _msg) => None,+      Repr::IoErr(ref err) => Some(err),+    }+  }+}++impl From<io::Error> for PluginError {+  #[inline]+  fn from(err: io::Error) -> Self {+    Self {+      repr: Repr::IoErr(err),+    }+  }+}++/// Base result type for a plugin op represents either a Sync or Async value+pub type PluginOp = Op<PluginError>;++/// Complete return type for a plugin op including Sync errors+pub type PluginOpResult = PluginResult<PluginOp>;++/// Funciton type for plugin ops+pub type PluginDispatchFn =+  fn(is_sync: bool, data: &[u8], zero_copy: Option<PinnedBuf>)+    -> PluginOpResult;

How does sendInternal know what to expect?

afinch7

comment created time in 21 days

Pull request review commentdenoland/deno

Feature: Native plugins

+use crate::isolate::Op;+use crate::libdeno::PinnedBuf;+use std::fmt;+use std::io;++pub type PluginResult<T> = std::result::Result<T, PluginError>;++#[derive(Debug)]+pub struct PluginError {+  repr: Repr,+}++#[derive(Debug)]+enum Repr {+  Simple(String),+  IoErr(io::Error),+}++pub fn new_plugin_error(msg: String) -> PluginError {+  PluginError {+    repr: Repr::Simple(msg),+  }+}++impl fmt::Display for PluginError {+  fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {+    match self.repr {+      Repr::Simple(ref err_str) => f.pad(err_str),+      Repr::IoErr(ref err) => err.fmt(f),+    }+  }+}++impl std::error::Error for PluginError {+  fn description(&self) -> &str {+    match self.repr {+      Repr::Simple(ref msg) => msg.as_str(),+      Repr::IoErr(ref err) => err.description(),+    }+  }++  fn cause(&self) -> Option<&dyn std::error::Error> {+    match self.repr {+      Repr::Simple(ref _msg) => None,+      Repr::IoErr(ref err) => Some(err),+    }+  }+}++impl From<io::Error> for PluginError {+  #[inline]+  fn from(err: io::Error) -> Self {+    Self {+      repr: Repr::IoErr(err),+    }+  }+}++/// Base result type for a plugin op represents either a Sync or Async value+pub type PluginOp = Op<PluginError>;++/// Complete return type for a plugin op including Sync errors+pub type PluginOpResult = PluginResult<PluginOp>;++/// Funciton type for plugin ops+pub type PluginDispatchFn =+  fn(is_sync: bool, data: &[u8], zero_copy: Option<PinnedBuf>)+    -> PluginOpResult;

Also how do you want to handle sync/async?

afinch7

comment created time in 21 days

Pull request review commentdenoland/deno

Feature: Native plugins

+use crate::isolate::Op;+use crate::libdeno::PinnedBuf;+use std::fmt;+use std::io;++pub type PluginResult<T> = std::result::Result<T, PluginError>;++#[derive(Debug)]+pub struct PluginError {+  repr: Repr,+}++#[derive(Debug)]+enum Repr {+  Simple(String),+  IoErr(io::Error),+}++pub fn new_plugin_error(msg: String) -> PluginError {+  PluginError {+    repr: Repr::Simple(msg),+  }+}++impl fmt::Display for PluginError {+  fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {+    match self.repr {+      Repr::Simple(ref err_str) => f.pad(err_str),+      Repr::IoErr(ref err) => err.fmt(f),+    }+  }+}++impl std::error::Error for PluginError {+  fn description(&self) -> &str {+    match self.repr {+      Repr::Simple(ref msg) => msg.as_str(),+      Repr::IoErr(ref err) => err.description(),+    }+  }++  fn cause(&self) -> Option<&dyn std::error::Error> {+    match self.repr {+      Repr::Simple(ref _msg) => None,+      Repr::IoErr(ref err) => Some(err),+    }+  }+}++impl From<io::Error> for PluginError {+  #[inline]+  fn from(err: io::Error) -> Self {+    Self {+      repr: Repr::IoErr(err),+    }+  }+}++/// Base result type for a plugin op represents either a Sync or Async value+pub type PluginOp = Op<PluginError>;++/// Complete return type for a plugin op including Sync errors+pub type PluginOpResult = PluginResult<PluginOp>;++/// Funciton type for plugin ops+pub type PluginDispatchFn =+  fn(is_sync: bool, data: &[u8], zero_copy: Option<PinnedBuf>)+    -> PluginOpResult;

Errors?

afinch7

comment created time in 21 days

Pull request review commentdenoland/deno

Feature: Native plugins

+// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.+const { dlname, dlopen } = Deno;++let localPath: any = import.meta.url.split("/");+localPath.pop();+localPath = localPath.join("/");++const dLib = dlopen(env().DL_PATH_TEST_BINDING + "/" + dlname("test_plugin"));

dlname can be implemented purely in TS.

Is it not already?

afinch7

comment created time in 21 days

PR opened denoland/deno

TextEncoder.encodeInto

closes #2556

+65 -1

0 comment

2 changed files

pr created time in 25 days

create barnchafinch7/deno

branch : encode_into

created branch time in 25 days

issue commentdenoland/deno

TextEncoder missing implementation for encodeInto

This code will fail in deno, but works fine in chrome

let someBytes = new Uint8Array(128);
const textEncoder = new TextEncoder();
textEncoder.encodeInto("some text", someBytes);
afinch7

comment created time in 25 days

issue openeddenoland/deno

TextEncoder missing implementation for encodeInto

see https://encoding.spec.whatwg.org/#interface-textencoder

created time in 25 days

push eventafinch7/deno

Bartek Iwańczuk

commit sha 01858f115ae4c051a0beb5c1719c59431562f43e

fix: use Loader::resolve in op_fetch_module_meta_data (#2519)

view details

Jed Fox

commit sha 43f48386d7921612c5cbe7d39a4dfb82a3f3367e

website: use css variables and prefers-color-scheme (#2547) This uses `prefers-color-scheme: dark` to automatically switch to dark mode if the user specifies it in their system settings. Dark mode is supported in Firefox 67, Chrome 76, Safari 12.1, and iOS 13 as of this commit, but the current status can be checked here: https://caniuse.com/#feat=prefers-color-scheme Additionally, this uses CSS Variables to implement the color-switching mechanism. This isn’t supported in IE, but the site degrades reasonably well with them disabled. Support table: https://caniuse.com/#feat=css-variables

view details

Kitson Kelly

commit sha 425df50484f315dcd63b4d93ab6911702779899e

Combine CLI Errors (#2487)

view details

迷渡

commit sha 6a5177dc11936687e6da95c3c45e3e41a7856d79

event `isTrusted` is enumerable (#2543)

view details

Ryan Dahl

commit sha f2c50fae844b34cf6d8488ab1fbc599eb935a919

Fix silent failure of WebAssembly.instantiate() (#2548) By making WASM compilation synchronous. We'll have to do more work to make it properly async.

view details

afinch7

commit sha 0f67f8d91754a5bb02ea9fe4e74cd08ce4599075

Feature: Native Plugins

view details

push time in a month

push eventafinch7/deno

afinch7

commit sha ba7e7d133244c108875a96a237a1da123bb64e81

more cleanups and renames

view details

push time in a month

push eventafinch7/deno

afinch7

commit sha f1ef2161c962f461adfa9ae5079c6689f6a52bca

more cleanups and renames

view details

push time in a month

Pull request review commentdenoland/deno

Feature: Native plugins

 def filter_test_suite(suite, pattern):   def run_tests(test_cases=None):+    os.environ["DENO_BUILD_PATH"] = build_path()

What do you mean by explicit? We need to provide an absolute path, and that path is going to be different for release/debug builds.

afinch7

comment created time in a month

Pull request review commentdenoland/deno

Feature: Native plugins

 def filter_test_suite(suite, pattern):   def run_tests(test_cases=None):+    os.environ["DENO_BUILD_PATH"] = build_path()

This won't have any affect if DENO_BUILD_PATH is already set.

def build_path():
    if "DENO_BUILD_PATH" in os.environ:
        return os.environ["DENO_BUILD_PATH"]
    else:
        return os.path.join(root_path, "target", build_mode())
afinch7

comment created time in a month

push eventafinch7/deno

afinch7

commit sha d7b3bb64af3c0c68c690f80b844685e6e0448aa6

fix

view details

push time in a month

push eventafinch7/deno

afinch7

commit sha 082021119a471602e73e494a319a1e8921e7f253

fix

view details

push time in a month

push eventafinch7/deno

afinch7

commit sha 604cb3d005b40f62550bb03fb1c26d835ad4afbf

revert badly_formatted.js

view details

push time in a month

Pull request review commentdenoland/deno

Feature: Native plugins

--console.log(-  "Hello World"-)+console.log("Hello World");

🤔 not sure why this got formatted.

afinch7

comment created time in a month

Pull request review commentdenoland/deno

Feature: Native plugins

 def filter_test_suite(suite, pattern):   def run_tests(test_cases=None):+    os.environ["DENO_BUILD_PATH"] = build_path()

I need some way to locate the built version of test_plugin(see //tests/033_native_plugins.ts).

afinch7

comment created time in a month

push eventafinch7/deno

afinch7

commit sha db96bca3fd55396a8b3665fcb7f15b3849e8a59c

renames

view details

push time in a month

push eventafinch7/deno

afinch7

commit sha 76cfbdaa9d6acf7d6c8b5532e2bd4752c190a81b

renames

view details

push time in a month

Pull request review commentdenoland/deno

Feature: Native plugins

 pub fn op_selector_std(inner_type: msg::Any) -> Option<CliDispatchFn> {     msg::Any::CreateWorker => Some(op_create_worker),     msg::Any::Cwd => Some(op_cwd),     msg::Any::Dial => Some(op_dial),+    msg::Any::DlOpen => Some(op_dl_open),+    msg::Any::DlSym => Some(op_dl_sym),+    msg::Any::DlCall => Some(op_dl_call),

👍

afinch7

comment created time in a month

pull request commentdenoland/deno

Feature: Native plugins

@ry @piscisaureus ready for review.

afinch7

comment created time in a month

PR closed denoland/deno

Increase the size of the shared buffer

This seems to provide a decent performance lift across the board, but not enough to make back the performance lost in #2452

+2 -1

2 comments

2 changed files

afinch7

pr closed time in a month

pull request commentdenoland/deno

Increase the size of the shared buffer

Was looking at the benchmarks in CI. Doing some more testing it looks like this is an outlier.

afinch7

comment created time in a month

push eventafinch7/deno

afinch7

commit sha 4219f9b8b7350045fed64f2d75df1eff5ba3d37f

fmt

view details

push time in a month

push eventafinch7/deno

迷渡

commit sha 9ad5b0653e3821915d7ab7438d5ed4fe373c569a

clearTimeout should convert to number (#2539)

view details

andy finch

commit sha 76d51b0f9a4bd0ff86150d0dfa78df7c8410b7ea

refactor dispatch take 2 (#2533)

view details

迷渡

commit sha d5e80ad67744bbd2646af0a0abe27cc38205f990

fix clearTimeout.name / clearInterval.name (#2540)

view details

Kitson Kelly

commit sha ed390a51cac08ec238b45c793a5ddd65fcae1b78

Add dyn to be rust nightly compatible (#2538)

view details

afinch7

commit sha 54706f0cb31fe69255f21bac267a6c007eadb148

Feature: Native plugins

view details

afinch7

commit sha 9655e9a7da2d3c2d02ca1e95d31bb8c3f6f7af27

update third party

view details

afinch7

commit sha 332580d57adf487a32bf39114c579e1d8f4c6fb1

fmt

view details

afinch7

commit sha 2e83479bb6d608c10ee4b03d1ed4e54291c44f0d

fmt

view details

push time in a month

push eventafinch7/deno

afinch7

commit sha b6b199064b6edd8344d68f8089f9617d3aa2f46e

update Cargo.lock

view details

push time in a month

push eventafinch7/deno

afinch7

commit sha 6dfd8c0e886d9eca8489b1b5f3ad4c8078356507

fmt

view details

push time in a month

push eventafinch7/deno

Ryan Dahl

commit sha 7b06aa37342c021f9f1fac99125847d134e67001

v0.9.0

view details

David Stone

commit sha 76329cf610af1612d4e9c562a1ee3a4dd6082a37

Fixes benchmark page spinner on Edge #2508 (#2525)

view details

迷渡

commit sha a95319074240a869dce088fa580e46a067a8e7d1

fix urlSearchParams custom symbol iterator (#2537)

view details

afinch7

commit sha f80d673ae03304678c8f90d73fb4db3700535107

Merge remote-tracking branch 'upstream/master' into native_bindings

view details

push time in a month

push eventafinch7/deno

Bartek Iwańczuk

commit sha 3dff147d0ca1a2cd8d264d20a178d71cb38b1c4e

feat: add deno install command (#2522)

view details

Ryan Dahl

commit sha 1361e302234b17ab8079107b134dfd0ddf288439

Revert "Refactor dispatch handling (#2452)" Due to performance regression: https://github.com/denoland/deno/commit/dc60fe9f300043f191286ef804a365e16e455f87#commitcomment-33943711 This reverts commit dc60fe9f300043f191286ef804a365e16e455f87.

view details

Bert Belder

commit sha 77737707e4e07d7421d9a4f813d6dcd27ecf54fe

third_party: upgrade rust crates

view details

Bartek Iwańczuk

commit sha 061f6dd4832320ff654ee2a7a07901852b702639

fix deno install (#2529)

view details

Ryan Dahl

commit sha 9142a7df46fd1335c9ee007edcc4e83eb589a794

Upgrade INSTALLER_URL to include fixes (#2532) denoland/deno_std#492

view details

afinch7

commit sha 930a1e845b16439059e22c0819aa10e17da3ed89

refactor dispatch take 2

view details

afinch7

commit sha e238573ffb586a1fffaf776c3ef16ef3f5f95375

Feature: Native plugins

view details

afinch7

commit sha bec5069338d4c488a97919215779188cbf9b9be6

update third party

view details

afinch7

commit sha b7f6670f9084197c5170fe71d7e8f41388ae71a8

fmt

view details

push time in a month

push eventafinch7/deno

afinch7

commit sha 13de6b3827ea4fe9d4c5eb1a8dfd49029bc3b366

update third party

view details

push time in a month

push eventafinch7/deno_third_party

afinch7

commit sha 745f9b38eba039d0494189c9380a405089ebcb6b

update rust crates

view details

push time in a month

more