profile
viewpoint

afilini/AskFmApi 11

Ask.fm php api

afilini/afilini.com 4

Source code of afilini.com

afilini/cie-mrtd-python-sdk 4

Libreria leggera e portabile in Python per l'estrazione delle informazioni contenute nella CIE 3.0, con e senza autenticazione EAC.

afilini/bdk 3

A modern, lightweight, descriptor-based wallet written in Rust!

afilini/arm32v7-bitcoind 1

bitcoind Docker image for arm32v7 (armhf)

afilini/bifrost 1

Bifröst, the RGB "bridge" Server

afilini/bitcoin-things 1

Models for bitcointhings.org

afilini/c-rgb 1

Rust wrapper over rgb exposing the APIs as it was a C library

afilini/cie-nis-sdk 1

SDK for reading the NIS code from an Italian Electronic Identity Card (CIE)

startedSergioBenitez/Rocket

started time in 2 hours

pull request commentbitcoindevkit/bdk

Documentation

Sorry about the force push, but I needed a rebase to avoid a merge commit. Also cherry-picked your clippy fix into the release/0.3.0 branch.

tcharding

comment created time in a day

push eventbitcoindevkit/bdk

Tobin Harding

commit sha 01585227c54b4422bc65fab7f294dc19f32f476b

Use contains combinator As suggested by clippy, use the `contains` combinator instead of doing manual range check on floats.

view details

push time in a day

push eventbitcoindevkit/bitcoindevkit.org

github-actions

commit sha 884f0ec281fd7518ea515eea76a0dc53e3ce2182

Publishing to gh-pages (publish.sh)

view details

push time in a day

PR merged bitcoindevkit/bdk

Documentation

Description

While familiarizing myself with the project I did a few minor documentation improvements.

  • Patch 1 is a grammar fix
  • Patch 2 is whitespace, I've tried to work out the project style, please feel free to correct me if I've misunderstood.
  • Patch 3 is super trivial, add a couple of full stops.

Checklists

All Submissions:

  • [x] I've signed all my commits
  • [x] I followed the contribution guidelines ~* [ ] I ran cargo fmt and cargo clippy before committing~ Documentation only, no rust files touched.
+8 -12

4 comments

3 changed files

tcharding

pr closed time in a day

push eventbitcoindevkit/bdk

Tobin Harding

commit sha 84db6ce45345a933a7e4887c36a727891765d7cc

Do minor grammar fix

view details

Tobin Harding

commit sha 082db351c0a3fd9e9120b89add10267244898e62

Remove unexplainable newlines It seems the documentation of this project uses arbitrarily long lines (i.e. no set column width) along with the occasional newline before some sentences (within a paragraph). When to split a sentence onto a newline does not seem to follow any discernible pattern. There are a few instances of newline characters appearing randomly in the middle of a sentence and since, as observed above, there is no fixed column width is use these new lines are out of place. Remove them so the documentation is slightly more uniform and nice to read in an editor. This patch is whitespace only, no other textual changes.

view details

Tobin Harding

commit sha 4686ebb4200bcdd0d0f572076bc59bbd8541c10c

Add full stops to list items Super anal patch to make list items uniform, add full stop to the items where it is missing.

view details

Tobin Harding

commit sha 03b7c1b46b16f85a1240ab88efc608cbd4af95df

Use contains combinator As suggested by clippy, use the `contains` combinator instead of doing manual range check on floats.

view details

push time in a day

pull request commentbitcoindevkit/bdk

Documentation

Thanks, looks good!

ACK 04030bc

tcharding

comment created time in a day

pull request commentbitcoindevkit/bdk

[blockchain] Upgrade tokio

Still debugging it so I can't really say what's causing it (maybe it's not this specific PR), but I think we need a bit more testing before merging this just in case..

I can also confirmed it is working with bdk-cli and I got it to build for the wasm playground after some little code fixes to work with bdk-cli, but I can't figure out how to package/run it. After wasm-pack build what steps do I need to do?

justinmoon

comment created time in a day

created repositoryRCasatta/bitcoin_logger

created time in a day

push eventbitcoindevkit/bitcoindevkit.org

github-actions

commit sha 1e2c136f48b6944896ecdae7effa5d4d9537a39d

Publishing to gh-pages (publish.sh)

view details

push time in a day

pull request commentbitcoindevkit/bdk

Documentation

I'm not sure why CI is failing, this PR only touches markdown files?

Our CI always tests against the current stable rust version and it looks like you're the lucky winner of the first PR since the rust stable version changed from 1.48.0 to 1.49.0. Apparently 1.49.0 includes a new clippy warning, it's just a one line fix needed so can you add it in this PR?

error: manual `!RangeInclusive::contains` implementation
   --> src/blockchain/mod.rs:172:12
    |
172 |         if progress < 0.0 || progress > 100.0 {
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0.0..=100.0).contains(&progress)`
    |
    = note: `-D clippy::manual-range-contains` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains

Awesome, thanks. Done.

tcharding

comment created time in a day

startedBlockstream/blind_pin_server

started time in a day

fork valerio-vaccaro/seedsigner

Use an air-gapped Raspberry Pi Zero to generate the 24th word of a Bitcoin wallet seed phrase (and do other cool stuff)

fork in 3 days

startedJoinMarket-Org/joinmarket-clientserver

started time in 3 days

pull request commentbitcoindevkit/bdk

Documentation

I'm not sure why CI is failing, this PR only touches markdown files?

Our CI always tests against the current stable rust version and it looks like you're the lucky winner of the first PR since the rust stable version changed from 1.48.0 to 1.49.0. Apparently 1.49.0 includes a new clippy warning, it's just a one line fix needed so can you add it in this PR?

error: manual `!RangeInclusive::contains` implementation
   --> src/blockchain/mod.rs:172:12
    |
172 |         if progress < 0.0 || progress > 100.0 {
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0.0..=100.0).contains(&progress)`
    |
    = note: `-D clippy::manual-range-contains` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
tcharding

comment created time in 4 days

pull request commentbitcoindevkit/bdk

Documentation

I'm not sure why CI is failing, this PR only touches markdown files?

tcharding

comment created time in 4 days

PR opened bitcoindevkit/bdk

Documentation

Description

While familiarizing myself with the project I did a few minor documentation improvements.

  • Patch 1 is a grammar fix
  • Patch 2 is whitespace, I've tried to work out the project style, please feel free to correct me if I've misunderstood.
  • Patch 3 is super trivial, add a couple of full stops.

Checklists

All Submissions:

  • [x] I've signed all my commits
  • [x] I followed the contribution guidelines ~* [ ] I ran cargo fmt and cargo clippy before committing~ Documentation only, no rust files touched.
+7 -11

0 comment

2 changed files

pr created time in 4 days

issue openedbitcoindevkit/bdk-jni

Upgrade `bdk` version to "^0.2"

created time in 4 days

startedRCasatta/estimate_ml_fee

started time in 4 days

startedopen-quantum-safe/liboqs

started time in 5 days

MemberEvent

pull request commentbitcoindevkit/bdk

[blockchain] Upgrade tokio

I'm going to try testing this out with bdk-cli and the bitcoindevkit.org playground page since those are the only thing using wasm I can think of and not covered by the automated tests. Any one have any other suggestions on how to verify this change?

justinmoon

comment created time in 5 days

Pull request review commentbitcoindevkit/bdk

[blockchain] Upgrade tokio

 readme = "README.md" license = "MIT"  [dependencies]-bdk-macros = "0.2"+bdk-macros = { path = "./macros" }

I think this is the best way to do it, and will be updated to an actual version when this PR is included in a release.

justinmoon

comment created time in 5 days

pull request commentbitcoindevkit/bdk-cli

Specify none timeout, to allow using proxy

Yes I think so, but I think it still needs to wait for bdk 0.3.0 to be released so it can use that version in the dependencies?

RCasatta

comment created time in 5 days

pull request commentbitcoindevkit/bdk

[blockchain] Upgrade tokio

Updated changelog and GPG-signed my commit. Was having GPG trouble so I ended up squashing to one commit which is probably better anyway ...

justinmoon

comment created time in 6 days

startedthunderbiscuit/padawan-wallet

started time in 6 days

startedthunderbiscuit/padawan-wallet

started time in 6 days

more