afilini ( Alekos Filini )

commit sha 84db6ce45345a933a7e4887c36a727891765d7cc

Do minor grammar fix

commit sha 082db351c0a3fd9e9120b89add10267244898e62

Remove unexplainable newlines It seems the documentation of this project uses arbitrarily long lines (i.e. no set column width) along with the occasional newline before some sentences (within a paragraph). When to split a sentence onto a newline does not seem to follow any discernible pattern. There are a few instances of newline characters appearing randomly in the middle of a sentence and since, as observed above, there is no fixed column width is use these new lines are out of place. Remove them so the documentation is slightly more uniform and nice to read in an editor. This patch is whitespace only, no other textual changes.

commit sha 4686ebb4200bcdd0d0f572076bc59bbd8541c10c

Add full stops to list items Super anal patch to make list items uniform, add full stop to the items where it is missing.

commit sha 03b7c1b46b16f85a1240ab88efc608cbd4af95df

Use contains combinator As suggested by clippy, use the `contains` combinator instead of doing manual range check on floats.

push time in a day

pull request commentbitcoindevkit/bdk

Thanks, looks good!

ACK 04030bc

tcharding

comment created time in a day

pull request commentbitcoindevkit/bdk

Still debugging it so I can't really say what's causing it (maybe it's not this specific PR), but I think we need a bit more testing before merging this just in case..

I can also confirmed it is working with bdk-cli and I got it to build for the wasm playground after some little code fixes to work with bdk-cli, but I can't figure out how to package/run it. After wasm-pack build what steps do I need to do?

justinmoon

comment created time in a day

PR opened bitcoindevkit/bitcoindevkit.org

fee estimation for light clients

+519 -0

1 commit in RCasatta/bitcoindevkit.org/tree/ml bitcoindevkit/bitcoindevkit.org/tree/master

0 comment

8 changed files

pr created time in a day

created repositoryRCasatta/bitcoin_logger

created time in a day

push eventbitcoindevkit/bitcoindevkit.org

github-actions

commit sha 1e2c136f48b6944896ecdae7effa5d4d9537a39d

Publishing to gh-pages (publish.sh)

push time in a day

pull request commentbitcoindevkit/bdk

I'm not sure why CI is failing, this PR only touches markdown files?

Our CI always tests against the current stable rust version and it looks like you're the lucky winner of the first PR since the rust stable version changed from 1.48.0 to 1.49.0. Apparently 1.49.0 includes a new clippy warning, it's just a one line fix needed so can you add it in this PR?
error: manual `!RangeInclusive::contains` implementation
   --> src/blockchain/mod.rs:172:12
    |
172 |         if progress < 0.0 || progress > 100.0 {
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0.0..=100.0).contains(&progress)`
    |
    = note: `-D clippy::manual-range-contains` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains

Awesome, thanks. Done.

tcharding

comment created time in a day

startedBlockstream/blind_pin_server

started time in a day

fork valerio-vaccaro/seedsigner

Use an air-gapped Raspberry Pi Zero to generate the 24th word of a Bitcoin wallet seed phrase (and do other cool stuff)

SeedSigner/seedsigner valerio-vaccaro/seedsigner

fork in 3 days

startedJoinMarket-Org/joinmarket-clientserver

started time in 3 days

pull request commentbitcoindevkit/bdk

I'm not sure why CI is failing, this PR only touches markdown files?

Our CI always tests against the current stable rust version and it looks like you're the lucky winner of the first PR since the rust stable version changed from 1.48.0 to 1.49.0. Apparently 1.49.0 includes a new clippy warning, it's just a one line fix needed so can you add it in this PR?

error: manual `!RangeInclusive::contains` implementation
   --> src/blockchain/mod.rs:172:12
    |
172 |         if progress < 0.0 || progress > 100.0 {
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0.0..=100.0).contains(&progress)`
    |
    = note: `-D clippy::manual-range-contains` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains

tcharding

comment created time in 4 days

pull request commentbitcoindevkit/bdk

Upgrade `bdk` version to "^0.2"

I'm not sure why CI is failing, this PR only touches markdown files?

tcharding

comment created time in 4 days

PR opened bitcoindevkit/bdk

Documentation

Description

While familiarizing myself with the project I did a few minor documentation improvements.

Patch 1 is a grammar fix
Patch 2 is whitespace, I've tried to work out the project style, please feel free to correct me if I've misunderstood.
Patch 3 is super trivial, add a couple of full stops.

Checklists

All Submissions:

[x] I've signed all my commits
[x] I followed the contribution guidelines ~* [ ] I ran cargo fmt and cargo clippy before committing~ Documentation only, no rust files touched.

+7 -11

3 commit in tcharding/bdk/tree/documentation bitcoindevkit/bdk/tree/master

0 comment

2 changed files

pr created time in 4 days

issue openedbitcoindevkit/bdk-jni

created time in 4 days

startedRCasatta/estimate_ml_fee

started time in 4 days

startedopen-quantum-safe/liboqs

started time in 5 days

MemberEvent

pull request commentbitcoindevkit/bdk

I'm going to try testing this out with bdk-cli and the bitcoindevkit.org playground page since those are the only thing using wasm I can think of and not covered by the automated tests. Any one have any other suggestions on how to verify this change?

justinmoon

comment created time in 5 days

Pull request review commentbitcoindevkit/bdk

[wallet] Add "needed" and "available" metadata to Error::Insufficient…

 readme = "README.md" license = "MIT"  [dependencies]-bdk-macros = "0.2"+bdk-macros = { path = "./macros" }

I think this is the best way to do it, and will be updated to an actual version when this PR is included in a release.

justinmoon

comment created time in 5 days

pull request commentbitcoindevkit/bdk

utACK 7bc8c3c

justinmoon

comment created time in 5 days

pull request commentbitcoindevkit/bdk-cli

Specify none timeout, to allow using proxy

Yes I think so, but I think it still needs to wait for bdk 0.3.0 to be released so it can use that version in the dependencies?

RCasatta

comment created time in 5 days

pull request commentbitcoindevkit/bdk

[wallet] Add "needed" and "available" metadata to Error::Insufficient…

Rebased

justinmoon

comment created time in 6 days

pull request commentbitcoindevkit/bdk