profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/aethys256/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Quentin Giraud aethys256 My-Serious-Game Tours, France https://www.herodamage.com/ Passionate by programming since childhood. Tech Lead @My-Serious-Game, Co-Founder of @HeroTC and @SimCMinMax.

herotc/hero-rotation 104

WoW Addon - Attempt to provide the useful and precise information to execute the best possible DPS rotation in every situation.

SimCMinMax/AutoSimC 47

Python script to create multiple profiles for Simcraft to find Best-in-Slot and best enchants/gems/talents combination.

herotc/hero-lib 24

WoW Addon - Core Library used by HeroRotation and AethysTools, can also be used by others 3rd-Party Addons.

aethys256/notes 10

My notes about a bunch of stuff

aethys256/AethysTools 8

WoW Addon - Quality of Life + Extra Features using HeroLib.

aethys256/artifact-power 2

Fork of https://repos.curseforge.com/wow/artifact-power

SimCMinMax/CombinX 2

Simulationcraft profiles automation

aethys256/cv-resume 0

My CV/Resume

aethys256/Diminish 0

Lightweight DR Tracker addon for World of Warcraft.

aethys256/gpt-size-mapping-generator 0

Script to generate Google Publisher Tag size mapping.

push eventherotc/hero-rotation

Cilraaz

commit sha af986b70df5591cfd7a092eacf8265d2fca9f224

feat(Shadow): Update to Wrathful Faerie usage in multi-target

view details

push time in a day

push eventherotc/hero-rotation

Cilraaz

commit sha a8d06746662ebb581d4e15a11e5dbd470b7af4f3

feat(Holy): Add Holy Priest support

view details

push time in 2 days

Pull request review commentherotc/hero-rotation

fix: fixed some stuff about combustion

 local function combustion_phase()   --&buff.combustion.up&(!buff.firestorm.react|buff.infernal_cascade.remains<0.5)&!buff.hot_streak.react&hot_streak_spells_in_flight+buff.heating_up.react<2   if S.FireBlast:IsCastable() and (EnemiesCount8ySplash <= UnitsWithIgniteCount or not S.PhoenixFlames:IsCastable()) and S.InfernalCascade:ConduitEnabled() and S.FireBlast:Charges() >= 1   and (var_expected_fire_blasts >= var_needed_fire_blasts or var_extended_combustion_remains <= S.InfernalCascade:BaseDuration() or Player:BuffStack(S.InfernalCascadeBuff) or Player:BuffRemains(S.InfernalCascadeBuff) < Player:GCD() or (Player:Covenant() == "Night Fae" and S.ShiftingPower:CooldownRemains() and EnemiesCount18yMelee >= var_combustion_shifting_power))-  and Player:BuffUp(S.Combustion) and (Player:BuffDown(S.FirestormBuff) or Player:BuffRemains(S.InfernalCascadeBuff)) and Player:BuffDown(S.HotStreakBuff) and (num(Player:BuffUp(S.HeatingUpBuff)) + num(S.Pyroblast:InFlight() or S.Fireball:InFlight() or S.PhoenixFlames:InFlight()) < 2) then+  and Player:BuffUp(S.Combustion) and (Player:BuffDown(S.FirestormBuff) or Player:BuffRemains(S.InfernalCascadeBuff)) and Player:BuffDown(S.HotStreakBuff) and hot_streak_spells_in_flight() < 2 then     if Settings.Fire.ShowFireBlastLeft then       if HR.CastLeft(S.FireBlast) then return "fire_blast combustion_phase 9 left"; end     else       if HR.Cast(S.FireBlast) then return "fire_blast combustion_phase 9"; end     end   end-  --counterspell,if=runeforge.disciplinary_command&buff.disciplinary_command.down&buff.disciplinary_command_arcane.down&cooldown.buff_disciplinary_command.ready&!talent.rune_of_power-  if S.Counterspell:IsCastable() and DisciplinaryCommandEquipped and Player:BuffDown(S.DisciplinaryCommandBuff) and Player:BuffDown(S.DisciplinaryCommandArcaneBuff) and S.DisciplinaryCommandBuff:TimeSinceLastAppliedOnPlayer() > 30 and not S.RuneofPower:IsAvailable() then-    if HR.Cast(S.Counterspell) then return "counterspell combustion_phase 10"; end-  end-  --arcane_explosion,if=runeforge.disciplinary_command&buff.disciplinary_command.down&buff.disciplinary_command_arcane.down&cooldown.buff_disciplinary_command.ready&!talent.rune_of_power-  if S.ArcaneExplosion:IsCastable() and DisciplinaryCommandEquipped and Player:BuffDown(S.DisciplinaryCommandBuff) and Player:BuffDown(S.DisciplinaryCommandArcaneBuff) and S.DisciplinaryCommandBuff:TimeSinceLastAppliedOnPlayer() > 30 and not S.RuneofPower:IsAvailable()  then-    if HR.Cast(S.ArcaneExplosion) then return "arcane_explosion combustion_phase 11"; end-  end-  --frostbolt,if=runeforge.disciplinary_command&buff.disciplinary_command.down&buff.disciplinary_command_frost.down-  if S.Frostbolt:IsCastable() and DisciplinaryCommandEquipped and S.DisciplinaryCommandBuff:TimeSinceLastAppliedOnPlayer() > 30 and Player:BuffDown(S.DisciplinaryCommandFrostBuff) then-    if HR.Cast(S.Frostbolt, nil, nil, not Target:IsSpellInRange(S.Frostbolt)) then return "frostbolt combustion_phase 12"; end-  end-  --frost_nova,if=runeforge.grisly_icicle&buff.combustion.down-  if S.FrostNova:IsCastable() and GrislyIcicleEquipped and Player:BuffDown(S.Combustion) then-    if HR.Cast(S.FrostNova, nil, nil, not Target:IsSpellInRange(S.FrostNova)) then return "living_bomb combustion_phase 13"; end-  end

These weren't in the APL so I removed them

deibeljc

comment created time in 3 days

push eventherotc/hero-rotation

Matt Redmond

commit sha b46f6460f95f56518966f6c81034e811c6c0a9da

[brewmaster] in process refactor, makes script more usable

view details

push time in 3 days

created tagherotc/hero-rotation

tag9.0.2.32

WoW Addon - Attempt to provide the useful and precise information to execute the best possible DPS rotation in every situation.

created time in 4 days

release herotc/hero-rotation

9.0.2.32

released time in 4 days

push eventherotc/hero-rotation

Cilraaz

commit sha 57b57222f5f3759aae407e1027ed58828d47d255

build(TOC): 9.0.2.32 release

view details

push time in 4 days

push eventherotc/hero-rotation

Cilraaz

commit sha 4988de5dda1f5773db3f50ae8770f993a2d8789e

feat(Balance): Update to latest APL (AoE changes)

view details

push time in 4 days

push eventherotc/hero-lib

Jon Deibel

commit sha a4bc3df04ea083363bebc0ddfdca48e418d457d4

fix: flame strike ID (#58)

view details

push time in 4 days

PR merged herotc/hero-lib

fix: flame strike ID
+1 -1

0 comment

1 changed file

deibeljc

pr closed time in 4 days

PR opened herotc/hero-lib

fix: flame strike ID
+1 -1

0 comment

1 changed file

pr created time in 4 days

PR closed herotc/hero-rotation

First pass at Destruction Lock for Shadowlands

First pass at getting a functional APL for Destruction Warlocks in Shadowlands. What is included in this PR:

  • SIMC profile updated to T26_Raid
  • Bit of a code spring cleaning: Removed things that are not meaningful for Shadowlands (i.e., BfA essences, Legion-specific skills and functions, a few obsolete config entries)

TODOs / known bugs:

  • APL entries depending on runeforge abilities or soulbinds are not implemented yet (need to figure out Spell IDs for these spells)
  • Not all covenant specific APL entries have been implemented. I'm intending to do it in the near future, pending my availability to change covenants (or have someone else test these on my behalf)
  • Range detection is mostly non-functional. With the exception of a couple spells using Everyone.CastCycle() all spells using HR.Cast() are failing to identify if the target is in range
  • Profile is sometimes capping Soul Shards when Infernal is active. I'm hoping this is somehow related to a bug I might have added in the Player.SoulShardsP() override and not due to a non-optimal SIMC for Destro Warlocks
+470 -24

1 comment

5 changed files

domingosnovo

pr closed time in 4 days

pull request commentherotc/hero-rotation

First pass at Destruction Lock for Shadowlands

I'll eventually fix the range issue and the issues with capping soul shards will infernal is active. If there is no rotation for Destro and the team is interested in contributions from the community, I'll send a new pull request with it. In the meantime I'm closing this one as there is not a lot of traction around this.

domingosnovo

comment created time in 4 days

issue closedherotc/hero-rotation

Dragon roar warrior fury solo rotation

Hi :) is it possible to put in the mono rotation the dragon roar ? What if some people don't prefer to have it, put it in the addon's menu, and be able to activate/deactivate it at any time ? Thank you for the work you do like every time :). ( and if you do it, don't forget that it's used in the rage period and adds 10 more rage ).

closed time in 5 days

alexmr06

issue commentherotc/hero-rotation

Dragon roar warrior fury solo rotation

Dragon Roar is only suggested with more than one target, as per the SimC APL.

alexmr06

comment created time in 5 days

issue closedherotc/hero-rotation

[Balance Druid] Inc: Chosen of Elune Suggested when not taken

Incarnation: chosen of elune is suggested as a spell even when the talent is not taken. This only started happening after I made the Balance of All Things legendary.

closed time in 5 days

RussellAnas

issue commentherotc/hero-rotation

[Balance Druid] Inc: Chosen of Elune Suggested when not taken

This was previously fixed in commit 9f8e375fff560460e59216e7454d28d250637eaa

It will be included in the next release version.

RussellAnas

comment created time in 5 days

issue openedherotc/hero-rotation

[Balance Druid] Inc: Chosen of Elune Suggested when not taken

Incarnation: chosen of elune is suggested as a spell even when the talent is not taken. This only started happening after I made the Balance of All Things legendary.

created time in 5 days

push eventherotc/hero-rotation

Julien Rechaussat

commit sha 5510890c6c71fe1ce6a01c94630726c7255c5442

[Elem] precombat casts

view details

push time in 5 days

push eventherotc/hero-rotation

Julien Rechaussat

commit sha 4fa91e82ba073b2676b34ae04d6342e8557afb3b

[Elem] Offgcd for earth Elem and stormkeeper

view details

push time in 5 days

push eventherotc/hero-rotation

Julien Rechaussat

commit sha 106a7314ead250de2127ccf9e5d482ce1f5dd7b6

[Elem] Small adjustments to fluidify rotation

view details

push time in 5 days

issue commentherotc/hero-rotation

[FDK] BoS cannot last long in rotation

I just noticed. That the rotation does not correspond to the apple on which the rotation is going. Here is a screenshot of the raidbots of my rotation simcraft. https://imgur.com/a/oloesCh and it is directly radically different from the rotation that is now in the addon. Please correct. Since there is an assumption that the error is due to the fact that BoS does not work correctly in this particular rotation.

narvell3

comment created time in 5 days

issue openedherotc/hero-rotation

Dragon roar warrior fury solo rotation

Hi :) is it possible to put in the mono rotation the dragon roar ? What if some people don't prefer to have it, put it in the addon's menu, and be able to activate/deactivate it at any time ? Thank you for the work you do like every time :). ( and if you do it, don't forget that it's used in the rage period and adds 10 more rage ).

created time in 6 days

issue openedherotc/hero-rotation

[FDK] BoS cannot last long in rotation

Yesterday in a raid I decided to test Frost DK in the BoS build, and saw that the addon could not hold BoS. At the beginning of the battle, we are gaining 50 runic power, and the addon suggests using BoS. And I noticed that in the middle of the battle, when the BoS build is offered to be pressed, he calmly holds it for 45sec +. Is it possible to somehow correct the beginning of the rotation so that the addon gains more runic power? And make obliterate priority higher during BoS, so that we ignore Rime when we have little rune power.

created time in 6 days

push eventherotc/hero-rotation

Cilraaz

commit sha 099a2bd7308ad7d0bf4ce0e6a7dc89daa7178635

feat(Balance): Tweak Ravenous Frenzy usage; re-number debug texts

view details

push time in 7 days