profile
viewpoint

push eventaduh95/aduh95.github.io

Antoine du HAMEL

commit sha 8e82691a11665c3f0e09d84c082cc2f19fd30894

Add favicons

view details

push time in 3 days

push eventaduh95/aduh95.github.io

Antoine du HAMEL

commit sha 2b35a42a97dbf7e76358061881db546d38335b42

Remove preloading of images

view details

push time in 3 days

push eventaduh95/aduh95.github.io

Antoine du HAMEL

commit sha 7656338564a3fbb7b27b7fff1a24e7cd3aaccfbe

Replace deprectaed clip by SVG

view details

Antoine du HAMEL

commit sha 835fa5e040653ea3af884d3c94d8ad5ee5593d35

Update balloon-css dependency

view details

Antoine du HAMEL

commit sha 3131e8498033e42b02783e08b4c57c291aa87924

Update deps

view details

push time in 3 days

issue commentnodejs/node

ESM modules and json importing [feature request]

Hasn't this issue been addressed by #26745?

damianobarbati

comment created time in 8 days

push eventaduh95/yuml2svg-playground

Antoine du HAMEL

commit sha 35e8d18acbc0126b68c4b80be72c51d5910dba14

Updates

view details

push time in 9 days

push eventaduh95/yuml2svg-playground

Antoine du HAMEL

commit sha 87d063d8cb728b72fad3c896b451e3abd2f7e2dc

Swap flex to grid layout Remove unnecessary DOM wrapper, Add responsive design.

view details

Antoine du HAMEL

commit sha 76642a95b023ddcda8c896bfc710cab3af3c7f3c

Add lang attribute to html element

view details

Antoine du HAMEL

commit sha 050238859065365b605ec3478a69c530d1259f1f

Add meta description for SEO

view details

Antoine du HAMEL

commit sha d0c575e1a76359d0018234193ca543f2a5b046c2

Remove console logging

view details

Antoine du HAMEL

commit sha 55afe1f86e5e886b29dcbf85fcf5c5486200151f

Preview yuml while loading the editor

view details

push time in 9 days

push eventaduh95/yuml2svg-playground

Antoine du HAMEL

commit sha 87d063d8cb728b72fad3c896b451e3abd2f7e2dc

Swap flex to grid layout Remove unnecessary DOM wrapper, Add responsive design.

view details

Antoine du HAMEL

commit sha 76642a95b023ddcda8c896bfc710cab3af3c7f3c

Add lang attribute to html element

view details

Antoine du HAMEL

commit sha 050238859065365b605ec3478a69c530d1259f1f

Add meta description for SEO

view details

Antoine du HAMEL

commit sha d0c575e1a76359d0018234193ca543f2a5b046c2

Remove console logging

view details

Antoine du HAMEL

commit sha 55afe1f86e5e886b29dcbf85fcf5c5486200151f

Preview yuml while loading the editor

view details

push time in 9 days

push eventaduh95/yuml2svg-playground

Antoine du HAMEL

commit sha b516e7d348b9e6de75b46d37ec7d92f041dcae95

Add dynamic import (trash)

view details

Antoine du HAMEL

commit sha 4dc252c297c1c8fa1012c6fdc2abebac0f111c23

Upgrade deps

view details

Antoine du HAMEL

commit sha 7f31ec096e23ca9efb35d5d269f5e460369bc2a9

Switch to preact

view details

Antoine du HAMEL

commit sha 11fc235a4f39af32f0e7ee4c5ed0a01372d0790b

Lazy load ace to improve startup time

view details

Antoine du HAMEL

commit sha c3fe42fd3cdde45d112f7a06d8bce3a46d491640

Use beta sheild on the web UI

view details

push time in 10 days

create barnchaduh95/yuml2svg-playground

branch : preact

created branch time in 10 days

push eventaduh95/yuml2svg-playground

Antoine du HAMEL

commit sha c3f9cce655f7110c1aa3847e961093d0aab804fd

Updates

view details

push time in 10 days

push eventaduh95/yuml2svg-playground

Antoine du HAMEL

commit sha b516e7d348b9e6de75b46d37ec7d92f041dcae95

Add dynamic import (trash)

view details

Antoine du HAMEL

commit sha 4dc252c297c1c8fa1012c6fdc2abebac0f111c23

Upgrade deps

view details

push time in 10 days

push eventaduh95/yuml2svg-playground

Antoine du HAMEL

commit sha 70a79f73d86c2fe93ea3ec8ab1845295caba120b

Updates

view details

push time in 10 days

push eventaduh95/yuml2svg-playground

Antoine du HAMEL

commit sha 30ec351c0ec55e4599861db6309389526fa7ecb6

Upgrade deps

view details

push time in 10 days

push eventaduh95/yuml2svg-playground

Antoine du HAMEL

commit sha 990e003c830d993658fc9f0d076c223a519bc27e

Upgrade deps

view details

push time in 10 days

created tagaduh95/yuml2svg

tagv5.0.0-beta.3

yUML SVG generator

created time in 10 days

created tagaduh95/yuml2svg

tagv5.0.0-beta.4

yUML SVG generator

created time in 10 days

push eventaduh95/yuml2svg

Antoine du HAMEL

commit sha 87b59ffa321f51714672211fc1512aef7945200c

v5.0.0-beta.4

view details

push time in 10 days

push eventaduh95/yuml2svg

Visnu Pitiyanuvath

commit sha 01d681bb977b80577c7735f0bbe73115585837e1

explicitly fill: none for open arrow

view details

Antoine du HAMEL

commit sha 4f07e0b7429b66bf02725616f9e4f51fd1285ea9

Update engine requirements and deps

view details

push time in 10 days

push eventaduh95/yuml2svg

Antoine du Hamel

commit sha 2a82134c290ec54a14299eef7f62905ff5630bb6

Use MJS and dynamic imports

view details

Antoine du Hamel

commit sha ba637657bc4f268e77028c72a181d9e95800fe58

Remove usage of CJS

view details

Antoine du HAMEL

commit sha 5cba11cfb454b2aa9cff82f1832fba8ece086aba

Add support for webpack

view details

Antoine du HAMEL

commit sha 99845754390710edddde2fe24054777087178e02

Fix syntax for Node 12

view details

Antoine du HAMEL

commit sha a0ac8b67ac92746c20005560d2958776c3f75c50

Add tests

view details

Antoine du HAMEL

commit sha bf88b53d4d466f5924ba59315e214e51a59155da

Upgrade deps

view details

Antoine du HAMEL

commit sha 401ce87b2d64e61427eb0c6d45c0971f118a71c1

Upgrade linter

view details

Antoine du HAMEL

commit sha 360f90943b2e8474256afaac4ef9bdde6a88012b

Fix test on Windows

view details

Antoine du HAMEL

commit sha 275d14776e18bbbeb25cd9150ee4056453275eb0

Add test for old issues

view details

Antoine du HAMEL

commit sha 8db1c03436ccd917c2165e0b7bf795d07c07260b

Improve test output

view details

Visnu Pitiyanuvath

commit sha 01d681bb977b80577c7735f0bbe73115585837e1

explicitly fill: none for open arrow

view details

Antoine du HAMEL

commit sha 4f07e0b7429b66bf02725616f9e4f51fd1285ea9

Update engine requirements and deps

view details

push time in 10 days

PR merged aduh95/yuml2svg

Use MJS and dynamic imports

This is still an experimental technology, so I don't expect this PR to be merged any time soon.

Use ES2015 module, and ES2018 import() syntax to load only modules needed for each graph rendering.

The main goal of this change is to diminish startup time.

+2185 -761

0 comment

48 changed files

aduh95

pr closed time in 10 days

delete branch aduh95/node

delete branch : backport-25491-to-v10.x

delete time in 20 days

pull request commentjaime-olivares/yuml-diagram

explicitly fill: none for open arrow

For sync use a single > For async use double >>

Seems reasonable to me, FWIW plantuml is using the same syntax.

visnup

comment created time in a month

pull request commentjaime-olivares/yuml-diagram

explicitly fill: none for open arrow

Hey, that's great for async diagrams, but is there a way to still have a synchronous diagram? Ideally we would have a way to have both synchronous and asynchronous messages, but I'm not sure if yUML allows that.

visnup

comment created time in a month

push eventaduh95/node

Antoine du Hamel

commit sha 77276a4a3708d9709bcad79fc185ad31a1a7e57d

Fix line change

view details

push time in a month

PR opened nodejs/node

[v10.x backport] esm: fix esm load bug

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Original PR: #25491

Fixes #27846

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines
+17 -4

0 comment

2 changed files

pr created time in a month

create barnchaduh95/node

branch : backport-25491-to-v10.x

created branch time in a month

created tagaduh95/schwifty-markdown

tagv2.0.0-beta.1

Convert Markdown documents to HTML on the fly, including yUML and Plantuml diagrams and graph charts rendering

created time in a month

push eventaduh95/schwifty-markdown

Antoine du HAMEL

commit sha 63a833dbdbdc71a970a8ec73ee5f3217f65e6b36

Move scripts to bin folder

view details

Antoine du HAMEL

commit sha d632a594692699d8804b89b8ace13e671746e502

Fix failing test

view details

Antoine du HAMEL

commit sha 0b259490b1a58afbfe0ef31dd2342268b97681c6

Export check dependency function

view details

Antoine du HAMEL

commit sha 0b385a6e1ab2dbef1c1622d750eb7219cf8d9278

Allow tests to be run in an env without java

view details

Antoine du HAMEL

commit sha a9bfef9370dab6584656b0c4aad16243439fc4b9

Fix tests race condition

view details

Antoine du HAMEL

commit sha c650c6831f88de465b1221f7a050dd0e9a003867

Update deps

view details

Antoine du HAMEL

commit sha 5840a3bc2ed7efbe717308643a23f760d031ba85

Use Array.from to improve readability

view details

Antoine du HAMEL

commit sha da486ffa62349af43a341e23b73ef38b2171e4ba

v2.0.0-beta.1

view details

push time in a month

push eventaduh95/jsdom

Antoine du Hamel

commit sha 1931cad93b82a505dfbb4724e9b20144f15090d5

Fix typo

view details

push time in a month

fork aduh95/jsdom

A JavaScript implementation of the WHATWG DOM and HTML standards, for use with node.js

fork in a month

push eventaduh95/yuml2svg

Antoine du Hamel

commit sha d29a2535522ef2e7482ecca27c275f3034af30df

deps: upgrade dev dependencies

view details

Antoine du Hamel

commit sha a9948e17eeb3c84031c816fe7e66036ff8f9981a

v4.2.0

view details

Jaime Olivares

commit sha 4904294d0a2cdedbe10464e24e709c7b2d962c78

cherry-pick commit from upstream Original commit message: Fixes issue #9

view details

Jaime Olivares

commit sha ef3c14df41779405e630dc7c223a40eca2449252

cherry pick commit from upstream Original commit message: Fixed issue https://github.com/jaime-olivares/yuml-diagram/issues/18

view details

Antoine du HAMEL

commit sha 296478523482dae59c51bc55f1fc419d9a3c4d98

Upgrade deps

view details

Antoine du HAMEL

commit sha a187fc3b3a0cb33f0b42dcaad3a9f9b3ec9dcb19

v4.2.1

view details

Antoine du Hamel

commit sha 2a82134c290ec54a14299eef7f62905ff5630bb6

Use MJS and dynamic imports

view details

Antoine du Hamel

commit sha ba637657bc4f268e77028c72a181d9e95800fe58

Remove usage of CJS

view details

Antoine du HAMEL

commit sha 5cba11cfb454b2aa9cff82f1832fba8ece086aba

Add support for webpack

view details

Antoine du HAMEL

commit sha 99845754390710edddde2fe24054777087178e02

Fix syntax for Node 12

view details

Antoine du HAMEL

commit sha a0ac8b67ac92746c20005560d2958776c3f75c50

Add tests

view details

Antoine du HAMEL

commit sha bf88b53d4d466f5924ba59315e214e51a59155da

Upgrade deps

view details

Antoine du HAMEL

commit sha 401ce87b2d64e61427eb0c6d45c0971f118a71c1

Upgrade linter

view details

Antoine du HAMEL

commit sha 360f90943b2e8474256afaac4ef9bdde6a88012b

Fix test on Windows

view details

Antoine du HAMEL

commit sha 275d14776e18bbbeb25cd9150ee4056453275eb0

Add test for old issues

view details

Antoine du HAMEL

commit sha 8db1c03436ccd917c2165e0b7bf795d07c07260b

Improve test output

view details

push time in a month

push eventaduh95/node

Joyee Cheung

commit sha 2b24ffae2240163a74ae11e49ee198e98abb07dc

lib: print to stdout/stderr directly instead of using console This patch adds an internal function that prints to stdout or stderr by directly writing to the known file descriptor, and uses it internally in common cases to avoid the overhead of the console implementation. PR-URL: https://github.com/nodejs/node/pull/27320 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Joyee Cheung

commit sha c5817abff5033da7c09302256a331e64473422a8

benchmark: add benchmark for node -p PR-URL: https://github.com/nodejs/node/pull/27320 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Joyee Cheung

commit sha 757f3f8b2cf9854292caaa143a1b0a7fbac5e0ea

process: reduce the number of internal frames in async stack trace Previously, we call the JS land `runNextTicks` implementation immediately from JS land after evaluating the main module or the input, so these synchronous JS call frames would show up in the stack trace of the async errors, which can be confusing. This patch moves those calls into C++ so that more of these internal scheduler implementation details can be hidden and the users can see a cleaner a cleaner async JS stack trace. PR-URL: https://github.com/nodejs/node/pull/27392 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Rongjian Zhang

commit sha 73a686f1bbacbdb40d552388d22a815340ae012a

test: add mustCall to net-connect-buffer test PR-URL: https://github.com/nodejs/node/pull/27446 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

tonyhty

commit sha fa3714d721e32acd16776d262ab970da405dbda4

test: add mustCall to test-fs-readfile-pipe PR-URL: https://github.com/nodejs/node/pull/27450 Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

jyjunyz

commit sha 558e5c43676d4d2ca7d6903a5399964381d93c1b

test: add mustcall in test-dgram-connect-send-callback-buffer-length add mustcall() on client.bind callback PR-URL: https://github.com/nodejs/node/pull/27464 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

tongshouyu

commit sha a4fff9a72f036a5e5dfa88757d1dd0796e1e2dad

test: add mustCall to test-net-eaddrinuse test PR-URL: https://github.com/nodejs/node/pull/27448 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

lixin.atom

commit sha 7cbbd51479a9637694ab14e985880758ee24c656

test: add "mustCall" for test-net-buffersize PR-URL: https://github.com/nodejs/node/pull/27451 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>

view details

luoyu

commit sha 54c973cee7536cc534679c223098fd39ded2199c

test: add mustCall to test-fs-readfile-pipe-large PR-URL: https://github.com/nodejs/node/pull/27460 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>

view details

xinyulee

commit sha 2c7b5332d6be2e729a5699dab33481864e13d08e

test: add mustCall to net-can-reset-timeout PR-URL: https://github.com/nodejs/node/pull/27462 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Joyee Cheung

commit sha 377939eef847d2475768c0db0b3eb1a699f545f1

deps: V8: cherry-pick 5d0cf6b Original commit message: [snapshot] Use Handle to track name in `CodeSerializer::Deserialize` The `Script::InitLineEnds(Handle<Script>(script, isolate));` line may lead to objects being moved around on the heap, so it’s necessary to use a `Handle` to track that. This was causing crashes in Node.js in Debug mode when using the code cache in combination with the CPU profiler. Refs: https://github.com/nodejs/node/issues/27307 Change-Id: I392b4c00c6ebad44753f87fcbf2e3278ea7799a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575698 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61036} Refs: https://github.com/v8/v8/commit/5d0cf6bcd58aa63c86f2664c801538c4e731170b PR-URL: https://github.com/nodejs/node/pull/27423 Fixes: https://github.com/nodejs/node/issues/27307 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Anto Aravinth

commit sha d69f00465790f1ac7788ac111bb61689543536ae

repl: add autocomplete for filesystem modules PR-URL: https://github.com/nodejs/node/pull/26648 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Daniel Bevenius

commit sha 274364580a218f331b10e832d0face7a713bb8f0

test: skip fs-copyfile-respect-permission if root Currently, if this test is run as the root user the following failure will occur: === release test-fs-copyfile-respect-permissions === Path: parallel/test-fs-copyfile-respect-permissions assert.js:89 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Missing expected exception (check). at Object.<anonymous> (/node/test/parallel/test-fs-copyfile-respect-permissions.js:38:10) at Module._compile (internal/modules/cjs/loader.js:759:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10) at Module.load (internal/modules/cjs/loader.js:628:32) at Function.Module._load (internal/modules/cjs/loader.js:555:12) at Function.Module.runMain (internal/modules/cjs/loader.js:826:10) at internal/main/run_main_module.js:17:11 Command: out/Release/node test/parallel/test-fs-copyfile-respect-permissions.js [05:41|% 100|+ 2620|- 1]: Done This commit adds a root user check and skips this test if running as the user root. PR-URL: https://github.com/nodejs/node/pull/27378 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

view details

hardfist

commit sha 4cf8b4212c9b6be3d606dbb4da94f56ac9dc756c

test: add mustCallAtLeast to test-fs-read-stream-fd test PR-URL: https://github.com/nodejs/node/pull/27461 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

shenchen

commit sha 77b9007395b68c5858356f790fef7e90f60a731b

test: add mustCall to test-dgram-connect-send-callback-buffer PR-URL: https://github.com/nodejs/node/pull/27466 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>

view details

zhoujiamin

commit sha eecf100049dd2d3ce6e4864a553cca43561a6a91

test: add common.mustCall test-dgram-listen-after-bind PR-URL: https://github.com/nodejs/node/pull/27454 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

view details

Chenxi Yuan

commit sha c3d49332101abc68e64f13c96f4c165d4716d416

test: add mustCall to test-dgram-implicit-bind.js PR-URL: https://github.com/nodejs/node/pull/27452 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

view details

nilianzhu

commit sha f5e2ad784ff8d51db275a7268660fc72cf58289d

test: add mustCallAtLeast to test-fs-read-stream-inherit PR-URL: https://github.com/nodejs/node/pull/27457 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Weijia Wang

commit sha 8b04d5c3ba9f6c2c1de8056dc25659278b7ad8c4

lib: remove outdated optimizations PR-URL: https://github.com/nodejs/node/pull/27380 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>

view details

cjihrig

commit sha e30b119194266c9dca83ff84c118c48b749b87c7

test: document NODE_TEST_KNOWN_GLOBALS PR-URL: https://github.com/nodejs/node/pull/27434 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in a month

issue openedmicrosoft/vscode

Support javascript private properties defined with #

<!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. --> I'm trying to resuscitate #56566 now that the proposal is stage 3 and the syntax has shipped to V8 7.3 (chromium 73+, Node JS 12+).

Currently vscode throws an invalid character error when defining javascript private methods or properties started with # symbol:

example

created time in 2 months

created tagaduh95/web_logger

tagv0.4.0

Python logger through a web interface

created time in 2 months

push eventaduh95/web_logger

Antoine du HAMEL

commit sha 0c26032e550708249f76922d2afdb760403ce3cd

Add support for touchscreen and keyboard scrolling

view details

push time in 2 months

push eventaduh95/web_logger

Antoine du HAMEL

commit sha f583f93dd22136ca11b5047fcc6c69a6262ee4d3

Remove global JS variable

view details

Antoine du HAMEL

commit sha 3a2d79028c8d81786c34afe1131fdfe2c3833e8b

Remove "Uncaught error" warning

view details

Antoine du HAMEL

commit sha 158acc697a55a228e0990708d56d1c747ee02508

Update minimal browser requirement feature: Optional catch binding

view details

push time in 2 months

Pull request review commentdenoland/deno

Implement Web Storage

 export type TextDecoder = textEncoding.TextDecoder;  window.performance = new performanceUtil.Performance(); +export type Storage = storage.Storage;+export type SessionStorage = storage.SessionStorage;

Do we need to export this type? It is not part of the HTML spec.

sh7dm

comment created time in 2 months

Pull request review commentdenoland/deno

Implement Web Storage

+import { test, assertEqual } from "./test_util.ts";++test(function storeItems() {+  assertEqual(sessionStorage.getItem("test"), undefined);+  sessionStorage.setItem("test", "John Doe");+  assertEqual(sessionStorage.getItem("test"), "John Doe");+  sessionStorage.clear(); // Clear for next tests+});++test(function removeItems() {+  assertEqual(sessionStorage.getItem("test"), undefined);
  assertEqual(sessionStorage.getItem("test"), null);
sh7dm

comment created time in 2 months

Pull request review commentdenoland/deno

Implement Web Storage

+export interface Storage {+  readonly length: number;++  key(index: number): string;+  getItem(key: string): string;+  setItem(key: string, value: string): void;+  removeItem(key: string): void;+  clear(): void;+}++export class SessionStorage implements Storage {+  private _storage: Record<string, string> = {};++  get length(): number {+    return Object.keys(this._storage).length;

IMHO using a Map instead of an Object would make this way more efficient.

sh7dm

comment created time in 2 months

Pull request review commentdenoland/deno

Implement Web Storage

+import { test, assertEqual } from "./test_util.ts";++test(function storeItems() {+  assertEqual(sessionStorage.getItem("test"), undefined);+  sessionStorage.setItem("test", "John Doe");+  assertEqual(sessionStorage.getItem("test"), "John Doe");+  sessionStorage.clear(); // Clear for next tests+});++test(function removeItems() {+  assertEqual(sessionStorage.getItem("test"), undefined);+  sessionStorage.setItem("test", "John Doe");+  assertEqual(sessionStorage.getItem("test"), "John Doe");+  sessionStorage.removeItem("test");+  assertEqual(sessionStorage.getItem("test"), undefined);+  sessionStorage.clear(); // Clear for next tests+});++test(function clear() {+  sessionStorage.setItem("test", "John Doe");+  assertEqual(sessionStorage.getItem("test"), "John Doe");+  assertEqual(sessionStorage.length, 1);+  sessionStorage.clear();+  assertEqual(sessionStorage.getItem("test"), undefined);
  assertEqual(sessionStorage.getItem("test"), null);
sh7dm

comment created time in 2 months

Pull request review commentdenoland/deno

Implement Web Storage

+export interface Storage {+  readonly length: number;++  key(index: number): string;+  getItem(key: string): string;+  setItem(key: string, value: string): void;+  removeItem(key: string): void;+  clear(): void;+}++export class SessionStorage implements Storage {+  private _storage: Record<string, string> = {};++  get length(): number {+    return Object.keys(this._storage).length;+  }++  key(index: number): string {+    return Object.keys(this._storage)[index];+  }+  getItem(key: string): string {+    return this._storage[key];

The spec says:

Returns the current value associated with the given key, or null if the given key does not exist in the list associated with the object.

    return this._storage[key] || null;
sh7dm

comment created time in 2 months

Pull request review commentdenoland/deno

Implement Web Storage

+import { test, assertEqual } from "./test_util.ts";++test(function storeItems() {+  assertEqual(sessionStorage.getItem("test"), undefined);+  sessionStorage.setItem("test", "John Doe");+  assertEqual(sessionStorage.getItem("test"), "John Doe");+  sessionStorage.clear(); // Clear for next tests+});++test(function removeItems() {+  assertEqual(sessionStorage.getItem("test"), undefined);+  sessionStorage.setItem("test", "John Doe");+  assertEqual(sessionStorage.getItem("test"), "John Doe");+  sessionStorage.removeItem("test");+  assertEqual(sessionStorage.getItem("test"), undefined);
  assertEqual(sessionStorage.getItem("test"), null);
sh7dm

comment created time in 2 months

Pull request review commentdenoland/deno

Implement Web Storage

+export interface Storage {+  readonly length: number;++  key(index: number): string;+  getItem(key: string): string;+  setItem(key: string, value: string): void;+  removeItem(key: string): void;+  clear(): void;+}++export class SessionStorage implements Storage {+  private _storage: Record<string, string> = {};++  get length(): number {+    return Object.keys(this._storage).length;+  }++  key(index: number): string {+    return Object.keys(this._storage)[index];+  }+  getItem(key: string): string {
  getItem(key: string): string | null {
sh7dm

comment created time in 2 months

Pull request review commentdenoland/deno

Implement Web Storage

+import { test, assertEqual } from "./test_util.ts";++test(function storeItems() {+  assertEqual(sessionStorage.getItem("test"), undefined);+  sessionStorage.setItem("test", "John Doe");+  assertEqual(sessionStorage.getItem("test"), "John Doe");+  sessionStorage.clear(); // Clear for next tests+});++test(function removeItems() {+  assertEqual(sessionStorage.getItem("test"), undefined);+  sessionStorage.setItem("test", "John Doe");+  assertEqual(sessionStorage.getItem("test"), "John Doe");+  sessionStorage.removeItem("test");+  assertEqual(sessionStorage.getItem("test"), undefined);+  sessionStorage.clear(); // Clear for next tests+});++test(function clear() {+  sessionStorage.setItem("test", "John Doe");+  assertEqual(sessionStorage.getItem("test"), "John Doe");+  assertEqual(sessionStorage.length, 1);+  sessionStorage.clear();+  assertEqual(sessionStorage.getItem("test"), undefined);+  assertEqual(sessionStorage.length, 0);+});++test(function length() {+  assertEqual(sessionStorage.length, 0);+  sessionStorage.setItem("test", "John Doe");+  assertEqual(sessionStorage.length, 1);+  sessionStorage.setItem("test1", "Jane Doe");+  assertEqual(sessionStorage.length, 2);+  sessionStorage.clear();+  assertEqual(sessionStorage.length, 0);+});++test(function key() {+  sessionStorage.setItem("test", "John Doe");+  sessionStorage.setItem("test1", "Jane Doe");+  assertEqual(sessionStorage.key(0), "test");+  assertEqual(sessionStorage.key(1), "test1");+  sessionStorage.clear();+  assertEqual(sessionStorage.key(0), undefined);
  assertEqual(sessionStorage.key(0), null);
sh7dm

comment created time in 2 months

issue commenttc39/proposal-dynamic-import

What's keeping this from stage 4?

Also, I believe the PR is already opened with the spec text: https://github.com/tc39/ecma262/pull/1482

isiahmeadows

comment created time in 2 months

issue commentnodejs/node

VS2019 Build Error Node 12.0.0

Duplicate of #27214?

smamran

comment created time in 2 months

Pull request review commentnodejs/node

esm: fix esm load bug

 Module.prototype.load = function(filename) {     // Create module entry at load time to snapshot exports correctly     const exports = this.exports;     if (module !== undefined) { // called from cjs translator-      module.reflect.onReady((reflect) => {-        reflect.exports.default.set(exports);-      });+      if (module.reflect) {+        module.reflect.onReady((reflect) => {+          reflect.exports.default.set(exports);+        });+      }

I think I managed to isolate the big in this PR: https://github.com/nodejs/node/pull/27443

ZYSzys

comment created time in 2 months

push eventaduh95/node

Antoine du HAMEL

commit sha a3b07f61c04b9aa2aa60b9ace51fae8d06a220e7

test: clearing require cache crashes esm loader This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: https://github.com/nodejs/node/issues/25482

view details

push time in 2 months

push eventaduh95/node

Antoine du HAMEL

commit sha b753255e2c22d10ce8024986ba6924ccb8db5e84

test: clearing require cache crashes esm loader This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: https://github.com/nodejs/node/issues/25482

view details

push time in 2 months

push eventaduh95/node

Antoine du HAMEL

commit sha 6905126b7f539cc302af2d1c87431cf5d7d2095f

test: clearing require cache crashes esm loader This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: https://github.com/nodejs/node/issues/25482

view details

push time in 2 months

pull request commentnodejs/node

module: add test for cjs loader with esm flag

Most of the code in the test comes from the stealthy-require module, which is under the ISC license: https://github.com/analog-nico/stealthy-require/blob/master/lib/index.js

I don't know if it's fine to release it under the MIT license, maybe we can get the feedback of the author.. @analog-nico, what do you think?

aduh95

comment created time in 2 months

Pull request review commentnodejs/Release

Update README.md with newest schedule information

 The Release schedule is available also as a [JSON][] file.  ### End-of-Life Releases -| Release | Status              | Codename   |Initial Release | Active LTS Start | Maintenance LTS Start | End-of-life               |-| :--:    | :---:               | :---:      | :---:          | :---:            | :---:                 | :---:                     |-| v0.10.x | **End-of-Life**     | -          | 2013-03-11     | -                | 2015-10-01            | 2016-10-31                |-| v0.12.x | **End-of-Life**     | -          | 2015-02-06     | -                | 2016-04-01            | 2016-12-31                |-| [4.x][] | **End-of-Life**     | [Argon][]  | 2015-09-08     | 2015-10-01       | 2017-04-01            | 2018-04-30                |-| 5.x     | **End-of-Life**     |            | 2015-10-29     |                  |                       | 2016-06-30                |-| 7.x     | **End-of-Life**     |            | 2016-10-25     |                  |                       | 2017-06-30                |-| 9.x     | **End-of-Life**     |            | 2017-10-01     |                  |                       | 2018-06-30                |+| Release | Status              | Codename   |Initial Release | Active LTS Start | Maintenance LTS Start | End-of-life                 |+| :--:    | :---:               | :---:      | :---:          | :---:            | :---:                 | :---:                       |+| v0.10.x | **End-of-Life**     | -          | 2013-03-11     | -                | 2015-10-01            | 2016-10-31                 |+| v0.12.x | **End-of-Life**     | -          | 2015-02-06     | -                | 2016-04-01            | 2016-12-31                 |+| [4.x][] | **End-of-Life**     | [Argon][]  | 2015-09-08     | 2015-10-01       | 2017-04-01            | 2018-04-30                 |+| [5.x][] | **End-of-Life**     |            | 2015-10-29     |                  |                       | 2016-06-30                 |+| [6.x][] | **Maintenance LTS** | [Boron][]  | 2016-04-26     | 2016-10-18       | 2018-04-30            | 2019-04-30                 |

Shouldn't that be

| [6.x][] | **End-of-Life** | [Boron][]  | 2016-04-26     | 2016-10-18       | 2018-04-30            | 2019-04-30                 |
BridgeAR

comment created time in 2 months

issue commentnodejs/node

exec node --experimental-modules

Here is how I am doing it:

run.js

#!/usr/bin/env node
const QUIET_OPTION = false; // flag to disable output from your server
const FLAGS = "--experimental-modules";
const EXEC_FILE = path.join(__dirname, "server.mjs");

const options = [FLAGS, EXEC_FILE];
const subprocess = spawn(process.argv0, options, {
        windowsHide: true,
});

if (!QUIET_OPTION) {
        subprocess.stderr.pipe(process.stderr);
        subprocess.stdout.pipe(process.stdout);
}

Using argv0 instead of passing node to the system shell is very useful when you have several version of Node.js on your machine.

node run.js
node-lts run.js
NickRimer03

comment created time in 2 months

issue commentnodejs/node

esm: Bug in dynamic modules refactoring

I am able to reproduce the bug, I think I am able to isolate it: https://github.com/nodejs/node/pull/27443/files#diff-70c342fdfc37efdb30644b25547cbac2

Steps to reproduce: Execute the file with the --experimental-modules flag => crashes Execute the file without the --experimental-modules flag => works fine

Unfortunately I didn't find a successful fix, I feel I don't have enough experience on the CJS loader to understand the bug. I am leaving my test available for anyone who wants to work on that.

guybedford

comment created time in 2 months

create barnchaduh95/yuml2svg-playground

branch : no-react

created branch time in 2 months

push eventaduh95/yuml2svg-playground

Michael Daines

commit sha 62bda3ec0c141192e8a0520ffaba69a24689fc9b

Initial commit

view details

Michael Daines

commit sha 37fa276fd3761ccec604495e090749873f84c9dc

Make it look a little more like the current version.

view details

Michael Daines

commit sha 750d45794975d26e11715f16a0a034cb6e3b7764

Add disabled style to checkbox.

view details

Michael Daines

commit sha d9a892303110c898baf39f909b3f59fc18dd469c

Reorganize CSS

view details

Michael Daines

commit sha 18715821e2ae4d14dc92f8b38dd43443649c1269

Edit viz.js to act as a Web Worker and move out of public.

view details

Michael Daines

commit sha 51d3176404a855f265cf82c3b1524de684c61603

Add deploy command.

view details

Michael Daines

commit sha 01563dac6b3e16e48c7dc04532ee5cd18ca969f4

Remove extra logging.

view details

Michael Daines

commit sha 0ce6bba7b726052c38bdfc9f4bc7ad7bea288595

Free results.

view details

Michael Daines

commit sha 1b8d13be24d357a9891223a92d6d2b2160cc1e06

Add worker option.

view details

Michael Daines

commit sha 915afb1259949c385b9e4cf8d7a899cd25f90b22

Keep WorkerWrapper in an instance of Viz.

view details

Michael Daines

commit sha 41dcfa8373b4400a40f3e8279ee07b7c87edbf4d

Set to undefined, not null.

view details

Michael Daines

commit sha 1292afdc15fa113f4350293da4e675fb404a4b23

Use the prerelease.

view details

Michael Daines

commit sha 95407057e18e81fccbe7b2d2869b9d5ad873b7a1

Update Viz.js to 2.0.0-pre.5

view details

Michael Daines

commit sha 271ad1ca9aab6673fc05a29b0960419da01c40c9

Put raw output in a textarea.

view details

Michael Daines

commit sha 2e6e2c1320cb64836e3b75c4fd1bf761f795ba3f

Use just a plain Webpack config, not react-scripts.

view details

Michael Daines

commit sha 95d818b3dc6e668d42aafa29fc8abafb63433f4b

Add beforeunload handler.

view details

Michael Daines

commit sha ff9df040f8490d38e2923d2fcb3443af59a485ff

Update Viz.js.

view details

Michael Daines

commit sha cfea2486d2c42cc8bcfd191d055b7ea55189f357

Import ext-searchbox.

view details

Antoine du HAMEL

commit sha d1ce78b51a8403cf1bb0d640f91200187e9618f9

Fork for yuml2svg

view details

Antoine du HAMEL

commit sha 2f33e48969792e850174e744a4c7beb2c2b653d6

Update page title

view details

push time in 2 months

push eventaduh95/yuml2svg-playground

Antoine du HAMEL

commit sha 9f8e39a5a8042b7f4d9002f928e6e076f70dca17

Upgrade deps

view details

push time in 2 months

push eventaduh95/yuml2svg-playground

Antoine du HAMEL

commit sha 68515c4577a5361c0592e5ff5611e6a2cdc9a64b

Updates

view details

push time in 2 months

push eventaduh95/schwifty-markdown

Antoine du HAMEL

commit sha d49d6cee12789e0eb6e3f8e339d49ca93b7fbce7

Experiment dynamic imports to improve startup time

view details

Antoine du HAMEL

commit sha 5b4a0d983c726ac8901c11427a8fdcf78bc0e823

Fix import syntax for Node 12

view details

Antoine du HAMEL

commit sha cc59d0f5936150eae8776083460bdc6c1977bdbb

Update Cypress tests

view details

Antoine du HAMEL

commit sha fdcdc34b88737cb7b52db048d04188204a45f585

Upgrade deps

view details

Antoine du HAMEL

commit sha 32979d34f4c910d2eae12c2121e09502f9aeb0eb

Fix broken imports

view details

Antoine du HAMEL

commit sha a031a4ea5604eb936678dc0ad4317042a05922c0

Fix ignored errors

view details

push time in 2 months

issue commenttc39/proposal-dynamic-import

What's keeping this from stage 4?

Here it is: https://github.com/tc39/tc39-notes/blob/master/es10/2019-03/mar-28.md#dynamic-import-for-stage-4-in-june

isiahmeadows

comment created time in 2 months

PR opened nodejs/node

module: add test for cjs loader with esm flag

When using the --experimental-modules flag with node, the CJS loader crashes sometime aas described in the related issue. I don' t have sufficient background to understand the module loading, but I have managed to isolate the bug and right a test, hoping that would encourages someone with a better background to tackle the issue.

I have observed the bug to be triggered by stealthy-require module, but only when the --experimental-modules flag is specified, even if no .mjs are imported. This is going to be a problem when we remove the esm flag as the module has more than 4M weekly download on npm.

Refs: https://github.com/nodejs/node/issues/25482

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines
+111 -0

0 comment

1 changed file

pr created time in 2 months

create barnchaduh95/node

branch : fix-esm-load

created branch time in 2 months

created tagaduh95/yuml2svg

tagv4.2.1

yUML SVG generator

created time in 2 months

push eventaduh95/yuml2svg

Jaime Olivares

commit sha ef3c14df41779405e630dc7c223a40eca2449252

cherry pick commit from upstream Original commit message: Fixed issue https://github.com/jaime-olivares/yuml-diagram/issues/18

view details

Antoine du HAMEL

commit sha 296478523482dae59c51bc55f1fc419d9a3c4d98

Upgrade deps

view details

Antoine du HAMEL

commit sha a187fc3b3a0cb33f0b42dcaad3a9f9b3ec9dcb19

v4.2.1

view details

push time in 2 months

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha ba2d3d697c82199a252258d6c22d6c9eba441584

Improve failing Apple Pay error message

view details

push time in 2 months

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 89741bfd09c3731abcd45fe663a99acd586a3fc3

Fix typo

view details

push time in 2 months

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 997c82efebf6b4e472f3d96a268fc1752b0d28f3

Check Apple Pay availibality Apply Apple Pay styles only if payment can be made.

view details

push time in 2 months

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 2580f80587ce3c308d66306d5773fe2558fa9a73

Change currency selector behavior

view details

push time in 2 months

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 5e408c44c08e0be9ff0599324080f527269edf8e

Add warning message for Apple Pay outside of Safari

view details

push time in 2 months

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha a13cb307f3a06393a2d3cbdc0d02d2822ae1985e

Add warning for unsupported backend validation

view details

push time in 2 months

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha a6d6044b86441ddc802466be842c87321247d6de

Update index.html

view details

push time in 2 months

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 5ad1607b56629cf40fbff73eb668cd6b07b9157a

Add Apple Pay demo data

view details

push time in 2 months

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 33640e4136b9f74a96fc4ae61a91ad8266c133c3

Create index.html

view details

push time in 2 months

create barnchaduh95/payment-request-test

branch : master

created branch time in 2 months

created repositoryaduh95/payment-request-test

Test for Payment Request API

created time in 2 months

issue commenttruedread/netflix-1080p

Netfix 1080p extenstion on Windows Xp Chrome 49

I don't think editing the Netflix 1080p extension to work for Chrome 49 would be too complicated, so I really do hope that truedread sees into this.

If that is not too complicated, I encourage you to open a pull request with a fix.

Windows XP has been released almost 18 years ago, all the industry leaders has abandoned it 3 years ago... I think it is crazy to expect the maintainer to spend time to make this works whereas there are so many compelling reasons for you NOT to use an OS as old and unmaintained as Windows XP (ever heard of WannaCry?).

I do use Ubuntu sometimes, for some things. It's great how lightweight it is compared to Win10, but the UI is too simplistic for me to make it my main OS.

Just so you know, you don't have to stick with Ubuntu if you do not like it, the Linux world is full of alternatives: I can suggest you to take a look at this article if that interests you. There are even a (now dormant) project to replicate the Windows XP UI: ndwarshuis/CinnXP.

Plus that I have too much windows software that I use..

FYI, Wine lets you run Windows software on GNU/Linux.

TL,DR: you should use a maintained OS and you should not expect the open source community to support them for you.

ahm5jnhi5

comment created time in 2 months

push eventaduh95/aduh95.github.io

Antoine du HAMEL

commit sha 8585f25626e062f74b9ccc97c0758cbaa96ce9fa

Fix timezone for intl dates

view details

push time in 3 months

push eventaduh95/aduh95.github.io

Antoine du HAMEL

commit sha bb094f9dca1d8cfd91abc2f293d6c80e4f66b508

Fix missing redirection on dev environment

view details

Antoine du HAMEL

commit sha be4a88d6e597f94a5e781ed7309f52ef9569cbf3

Update web app manifest

view details

push time in 3 months

more