push eventaduh95/payment-request-test

Antoine du Hamel

commit sha ba2d3d697c82199a252258d6c22d6c9eba441584

Improve failing Apple Pay error message

view details

push time in 9 hours

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 89741bfd09c3731abcd45fe663a99acd586a3fc3

Fix typo

view details

push time in 9 hours

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 997c82efebf6b4e472f3d96a268fc1752b0d28f3

Check Apple Pay availibality Apply Apple Pay styles only if payment can be made.

view details

push time in 9 hours

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 2580f80587ce3c308d66306d5773fe2558fa9a73

Change currency selector behavior

view details

push time in 9 hours

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 5e408c44c08e0be9ff0599324080f527269edf8e

Add warning message for Apple Pay outside of Safari

view details

push time in 9 hours

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha a13cb307f3a06393a2d3cbdc0d02d2822ae1985e

Add warning for unsupported backend validation

view details

push time in 9 hours

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha a6d6044b86441ddc802466be842c87321247d6de

Update index.html

view details

push time in 11 hours

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 5ad1607b56629cf40fbff73eb668cd6b07b9157a

Add Apple Pay demo data

view details

push time in 11 hours

push eventaduh95/payment-request-test

Antoine du Hamel

commit sha 33640e4136b9f74a96fc4ae61a91ad8266c133c3

Create index.html

view details

push time in 11 hours

create barnchaduh95/payment-request-test

branch : master

created branch time in 11 hours

created repositoryaduh95/payment-request-test

Test for Payment Request API

created time in 11 hours

issue commenttruedread/netflix-1080p

Netfix 1080p extenstion on Windows Xp Chrome 49

I don't think editing the Netflix 1080p extension to work for Chrome 49 would be too complicated, so I really do hope that truedread sees into this.

If that is not too complicated, I encourage you to open a pull request with a fix.

Windows XP has been released almost 18 years ago, all the industry leaders has abandoned it 3 years ago... I think it is crazy to expect the maintainer to spend time to make this works whereas there are so many compelling reasons for you NOT to use an OS as old and unmaintained as Windows XP (ever heard of WannaCry?).

I do use Ubuntu sometimes, for some things. It's great how lightweight it is compared to Win10, but the UI is too simplistic for me to make it my main OS.

Just so you know, you don't have to stick with Ubuntu if you do not like it, the Linux world is full of alternatives: I can suggest you to take a look at this article if that interests you. There are even a (now dormant) project to replicate the Windows XP UI: ndwarshuis/CinnXP.

Plus that I have too much windows software that I use..

FYI, Wine lets you run Windows software on GNU/Linux.

TL,DR: you should use a maintained OS and you should not expect the open source community to support them for you.

ahm5jnhi5

comment created time in a day

push eventaduh95/aduh95.github.io

Antoine du HAMEL

commit sha 8585f25626e062f74b9ccc97c0758cbaa96ce9fa

Fix timezone for intl dates

view details

push time in 22 days

push eventaduh95/aduh95.github.io

Antoine du HAMEL

commit sha bb094f9dca1d8cfd91abc2f293d6c80e4f66b508

Fix missing redirection on dev environment

view details

Antoine du HAMEL

commit sha be4a88d6e597f94a5e781ed7309f52ef9569cbf3

Update web app manifest

view details

push time in 22 days

push eventaduh95/node

Joyee Cheung

commit sha d18b0a01320e392e48f0c475effd8d4db2bb71a8

process: make tick callback and promise rejection callback more robust - Rename `internalTickCallback` to `processTicksAndRejections`, make sure it does not get called if it's not set in C++. - Rename `emitPromiseRejectionWarnings` to `processPromiseRejections` since it also emit events that are not warnings. - Sets `SetPromiseRejectCallback` in the `Environment` constructor to make sure it only gets called once per-isolate, and make sure it does not get called if it's not set in C++. - Wrap promise rejection callback initialization into `listenForRejections()`. - Add comments. PR-URL: https://github.com/nodejs/node/pull/25200 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Joyee Cheung

commit sha 6c0162149bc96de44e7596ebb8c668e46256279d

src: move arch, platform and release into node_metadata.cc Move definitions of more metadata into node_metadata{.h, .cc} so the data can be reused and easily inspected in C++. PR-URL: https://github.com/nodejs/node/pull/25293 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

cjihrig

commit sha 853bee0acfb79ce64202c4e23dc4343b491fa864

lib: move DEP0023 to end of life This commit moves DEP0023 to end of life status. The os.getNetworkInterfaces() method was introduced in the unstable 0.5.0 release, and runtime deprecated in 0.6.0, the first stable release of its existence. This commit also fixes an inaccuracy in the deprecation, as the replacement (os.networkInterfaces()) is actually a method. PR-URL: https://github.com/nodejs/node/pull/25280 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Daniel Bevenius

commit sha 398916a821b9cd49528644942a9ecd2783895a86

src: remove unused isolate variable Currently the following compiler warning is generated: ../src/node_task_queue.cc:93:12: warning: unused variable 'isolate' [-Wunused-variable] Isolate* isolate = env->isolate(); ^ 1 warning generated. This commit removes the unused variable. PR-URL: https://github.com/nodejs/node/pull/25368 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Corey Farrell

commit sha e7c6f4f68adf3bea6a8cdcfe6870f423efeccfce

doc: fs.mkdir('/') throws EPERM on Windows Fixes: https://github.com/nodejs/node/issues/25110 PR-URL: https://github.com/nodejs/node/pull/25340 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com>

view details

Rich Trott

commit sha 6f27f5350caa41b6a174386c07a4f2e72dc94f77

test: fix test-benchmark-zlib The addition of brotli to zlib benchmarks means that test-benchmark-zlib needs to be modified. This is that modification. PR-URL: https://github.com/nodejs/node/pull/25365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 7ed790e9dbf7827056b2859a57e9ad72863c1d50

test: remove flag for test-addon-uv-handle-leak test-addon-uv-handle-leak only requires worker_threads for the subprocess which it explicitly calls with --experimental-worker. The main test itself does not need it. Remove Flags: comment and move loading of worker_threads into subprocess-only logic. PR-URL: https://github.com/nodejs/node/pull/25327 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Tobias Nießen

commit sha 7afdfaec083310baa66c05daf33409a7b55528dd

crypto: fix key object wrapping in sync keygen PR-URL: https://github.com/nodejs/node/pull/25326 Fixes: https://github.com/nodejs/node/issues/25322 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ben Noordhuis

commit sha 5717dc2ae151ef8d0e02fb5afb6f26fb6d487dd8

src: remove unused method declaration PR-URL: https://github.com/nodejs/node/pull/25329 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Furqan Shaikh

commit sha 076d8b9f9da195fd3ff1d8cadeac0605cbd91d7b

test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH PR-URL: https://github.com/nodejs/node/pull/25296 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

cjihrig

commit sha ec5884a94f24351b2920ac3e54960999fdc05054

tools: update ESLint to 5.12.0 Update ESLint to 5.12.0. PR-URL: https://github.com/nodejs/node/pull/25347 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Rich Trott

commit sha a5c9491e730940a28001249fd62e547740725a69

test: fix test-tls-securepair-client test-tls-securepair-client has been failing for over a year but no one noticed because pummel tests are almost never run. In preparation for running pummel tests once a day in CI, fix test-tls-securepair-client. PR-URL: https://github.com/nodejs/node/pull/25222 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 0066fdb0720ce02c02f4541496d326676143600f

test: move test-tls-securepair-client out of pummel test-tls-securepair-client does not seem to need to be in the pummel directory. Move it to sequential. (It can't go into parallel because it uses common.PORT and therefore might conflict with another test that is using system-assigned available ports.) PR-URL: https://github.com/nodejs/node/pull/25222 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Sakthipriyan Vairamani (thefourtheye)

commit sha 309e7723eac0442972bbaa6a725366b8ab150892

doc: update behaviour of fs.writeFile As per the decision in https://github.com/nodejs/node/issues/23433, the `fs.writeFile` will always write from the current position if it is used with file descriptors. This patch updates it. Ref: https://github.com/nodejs/node/pull/23709 PR-URL: https://github.com/nodejs/node/pull/25080 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Roy Sommer

commit sha 5774688e2614ccb89749ea2f523014c6479616aa

lib: support overriding http\s.globalAgent Overriding `require('http[s]').globalAgent` is now respected by consequent requests. In order to achieve that, the following changes were made: 1. Implmentation in `http`: `module.exports.globalAgent` is now defined through `Object.defineProperty`. Its getter and setter return \ set `require('_http_agent').globalAgent`. 2. Implementation in `https`: the https `globalAgent` is not the same as `_http_agent`, and is defined in `https` module itself. Therefore, the fix here was to simply use `module.exports.globalAgent` to support mutation. 3. According tests were added for both `http` and `https`, where in both we create a server, set the default agent to a newly created instance and make a request to that server. We then assert that the given instance was actually used by inspecting its sockets property. Fixes: https://github.com/nodejs/node/issues/23281 PR-URL: https://github.com/nodejs/node/pull/25170 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Vse Mozhet Byt

commit sha 27a03b84c42a021c94649b3f601800b7502a9c15

doc: make modules.md more accurate PR-URL: https://github.com/nodejs/node/pull/25357 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Tobias Nießen

commit sha ae2d1f0e05449221ee770a393e5c967b359d9b1b

crypto: always accept private keys as public keys Some APIs already accept private keys instead of public keys. This changes all relevant crypto APIs to do so. PR-URL: https://github.com/nodejs/node/pull/25217 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Joyee Cheung

commit sha 9db9e7e541c1ff9a30b7f1b61c6d3a7b6d30fab3

src: move per-process global variables into node::per_process So that it's easier to tell whether we are manipulating per-process global states that may need to be treated with care to avoid races. Also added comments about these variables and moved some of them to a more suitable compilation unit: - Move `v8_initialized` to `util.h` since it's only used in `util.cc` and `node.cc` - Rename `process_mutex` to `tty_mutex` and move it into `node_errors.cc` since that's the only place it's used to guard the tty. - Move `per_process_opts_mutex` and `per_process_opts` into `node_options.h` and rename them to `per_process::cli_options[_mutex]` - Rename `node_isolate[_mutex]` to `per_process::main_isolate[_mutex]` PR-URL: https://github.com/nodejs/node/pull/25302 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

Anna Henningsen

commit sha 86ae2c182b425e08e8a98fcd47220d452cc94f53

doc: fix process.stdin example Fixes: https://github.com/nodejs/node/issues/20503 PR-URL: https://github.com/nodejs/node/pull/25344 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ali Ijaz Sheikh

commit sha f39b3e33719cdb7102e9ae7b67a13de4dd681949

src: trace_events: fix race with metadata events Multiple threads may be concurrently adding to the metadata_events list. Protect access with a mutex. Fixes: https://github.com/nodejs/node/issues/24129 PR-URL: https://github.com/nodejs/node/pull/25235 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in a month

pull request commentnodejs/ecmascript-modules

[WIP] New ESM Implementation

this changes the default file extension solution, specifically what .js should be considered

I guess that also changes behavior for extension-less files, right?

MylesBorins

comment created time in a month

issue commentbrave/brave-browser

Package Brave for chocolatey

What is the current status of this? The latest available version on Chocolatey is behind the release channel (currently 0.58.21, which is two months old)...

bsclifton

comment created time in 2 months

issue commentbrave/brave-browser

Widevine support for Linux

@StarFscker it is already working on Brave 62, you can install it already, instructions are here: https://brave-browser.readthedocs.io/en/latest/installing-brave.html#development-channel-installation

bbondy

comment created time in 2 months

push eventaduh95/aduh95.github.io

Antoine du HAMEL

commit sha ee14dfbbf32802113d917f59eebb5348e1734228

Fix animation for non-JS users

view details

Antoine du HAMEL

commit sha e08b9c7092163037cfb3ac9fd25acb1a530e1892

Update index file

view details

push time in 2 months

push eventaduh95/aduh95.github.io

Antoine du HAMEL

commit sha 9ed6ab6c9cd927b93aed086bb497e180c62c40ee

Use DOM iterator instead of array-like for NodeList

view details

Antoine du HAMEL

commit sha bcde0e41e4fc9862e597cb8cdff0237fea353dce

Add missing CSS licences

view details

Antoine du HAMEL

commit sha d4270e0c8b918622ef452080a9aa535a6aa4da3c

Using FS promises in gulp file

view details

Antoine du HAMEL

commit sha a27efc99889390644e1ecb0b359525fa55f45c7b

Fix paragraph animation

view details

Antoine du HAMEL

commit sha 702ade890bd4bc1753650e3a49cf3fcb580a37fb

Improve perf using canvas to estimate animation height

view details

Antoine du HAMEL

commit sha 0ff3d24315e5701b33d05bfa87a873722850bd47

Update experience list

view details

Antoine du HAMEL

commit sha c059059d62939e8605a06cc3cffca1ca48890a48

Update index file

view details

push time in 2 months

push eventaduh95/aduh95.github.io

Antoine du HAMEL

commit sha 49ae61c1bf7d7b3af6bb78bbc018ff97e45d1518

Fix typos

view details

Antoine du HAMEL

commit sha 6dbd29916811382cf59aabfba5afa97d5c42d6b4

Bump deps

view details

Antoine du HAMEL

commit sha 17c2ddde5d0a01849db865e440e3eeb947b9a769

Use ES2015 modules instead of typescript namespaces

view details

Antoine du HAMEL

commit sha bd9d4233d320b11c591439fd036ce1c8df192037

Fix JS module loader

view details

push time in 2 months

PR closed aduh95/aduh95.github.io

fix typo

embedding instead of embeding

+1 -1

1 comment

1 changed file

lethenju

pr closed time in 2 months

pull request commentaduh95/aduh95.github.io

fix typo

Thanks for the report, however you made the fix in the "compiled" file instead of the PHP one. I will fix it on my end, have a good day.

lethenju

comment created time in 2 months

push eventaduh95/schwifty-markdown

Antoine du HAMEL

commit sha 2fbadd237616b39075562fd0f133ebe247319cf4

Export md2html function

view details

Antoine du HAMEL

commit sha d9af67efea79ef35973080b2e6ac1b96372c305c

Separate md2html from file reading

view details

Antoine du HAMEL

commit sha fbc36c4f0cc7a210658bda2f00f81b51e5f5fabe

Export hash function to a separate module

view details

Antoine du HAMEL

commit sha 8c38bcd1a32fb1a7770fd5f0d95fec2b3e574ae2

Improve SVG error visibility

view details

Antoine du HAMEL

commit sha 89bd3fcbde6ed81b36eaf68ae266da2ba25f6325

Fix HTML error in temporary response

view details

push time in 2 months

push eventaduh95/yuml2svg

Jaime Olivares

commit sha 4904294d0a2cdedbe10464e24e709c7b2d962c78

cherry-pick commit from upstream Original commit message: Fixes issue #9

view details

push time in 2 months

pull request commentdenoland/deno

Implement Web Storage

sessionStorage is supposed to be readonly as per the specs. Should we try to have that in Deno as well?

sh7dm

comment created time in 2 months

startedaduh95/yuml2svg

started time in 2 months

delete branch aduh95/yuml2svg

delete branch : patch-1

delete time in 3 months

pull request commentnodejs/node

deps: upgrade npm to 6.6.0

@aeschright should this PR be updated to have npm 6.7.0 instead of 6.6.0?

aeschright

comment created time in 3 months

more