profile
viewpoint
Adrian Heine né Lang adrianheine Berlin https://hire.adrianheine.de Profile picture by Veronica Jonsson, cc-by-2.0

acornjs/acorn 6474

A small, fast, JavaScript-based JavaScript parser

acornjs/acorn-stage3 14

Support for stage 3 proposals in acorn

acornjs/acorn-class-fields 10

Class fields support for acorn

acornjs/acorn-bigint 9

Support for BigInt in acorn

acornjs/acorn-import-meta 7

Support for import.meta in acorn

acornjs/acorn-numeric-separator 7

Support for numeric separators in acorn

acornjs/acorn-private-methods 6

Private methods, getters and setters support for acorn

acornjs/acorn-async-iteration 3

Support for async iteration in acorn

acornjs/acorn-optional-catch-binding 3

Support for optional catch binding in acorn

acornjs/acorn-parse-regexps 2

Improved regular expressions support for Acorn

Pull request review commentytdl-org/youtube-dl

[bitchute] Fix error for geoblocking

 def _real_extract(self, url):             for format_url in orderedSet(format_urls)]          if not formats:-            formats = self._parse_html5_media_entries(-                url, webpage, video_id)[0]['formats']+            entries = self._parse_html5_media_entries(+                url, webpage, video_id)+            if not entries:+                error = self._html_search_regex(r'<h1 class="page-title">([^<]+)</h1>', webpage, 'error', default='Cannot find video')+                if error == 'Video Unavailable':+                    raise GeoRestrictedError(error)

Like that?

adrianheine

comment created time in 13 hours

PullRequestReviewEvent

push eventadrianheine/youtube-dl

Adrian Heine

commit sha 79d72c6f8c15e1fd066deea22237a6dd5969d804

[bitchute] Fix error for geoblocking Closes #26564.

view details

push time in 13 hours

pull request commentlezer-parser/website

Fix description, update dependencies

:hand: from one glazier to the other

adrianheine

comment created time in 10 days

issue commentytdl-org/youtube-dl

Error for videos from https://www.rtp.pt/play/

This is a duplicate of #23707 and hopefully fixed by #23877.

alsilva28

comment created time in 11 days

PR opened ytdl-org/youtube-dl

[bitchute] Fix error for geoblocking

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [x] I am the original author of this code and I am willing to release it under Unlicense
  • [ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • [x] Bug fix
  • [ ] Improvement
  • [ ] New extractor
  • [ ] New feature

Description of your pull request and other information

Closes #26564.

+10 -2

0 comment

1 changed file

pr created time in 11 days

push eventadrianheine/youtube-dl

Adrian Heine

commit sha 37fb591c0b566d75fe49f8524944505f1c8667ec

[bitchute] Fix error for geoblocking Closes #26564.

view details

push time in 11 days

create barnchadrianheine/youtube-dl

branch : 26564

created branch time in 11 days

issue commentytdl-org/youtube-dl

Unable to download videos from claystation.com

This is a duplicate of #23919 and hopefully fixed by #24689.

antdude

comment created time in 11 days

issue commentytdl-org/youtube-dl

Non-latin channel names does not supported.

Works fine for me and downloads all videos (at least in simulation mode)

5x3

comment created time in 11 days

issue commentytdl-org/youtube-dl

Unable to download videos from platzi.com

I currently get 503 for all Platzi URLs.

aaRonRJ

comment created time in 11 days

issue commentytdl-org/youtube-dl

https://videa.hu - Broken site support

Might be fixed by #26301. Can you give a link?

pcroland

comment created time in 15 days

push eventadrianheine/openid-ldap

Adrian Heine

commit sha 066923a3e6b172ded62ea3b58b535ba53ea9fdf5

Avoid NOTICEs

view details

push time in 15 days

push eventadrianheine/openid-ldap

Adrian Heine

commit sha 4859e1365b5bdebddd52cdfe6d5ad1309036d3b5

Move config to separate, untracked file

view details

push time in 15 days

delete branch adrianheine/node-acme

delete branch : letsencrypt

delete time in 17 days

push eventadrianheine/node-acme

Adrian Heine

commit sha eb175bd04f55f6e4b93508d91e5f53fb356c8d12

Update supertest dependency

view details

Adrian Heine

commit sha b8e230bda4b3b97f9e47444a28239ea963413766

Don't fail on csrs without subject

view details

Adrian Heine

commit sha a22c9eabf1f909694866da2c06d594000d775ecc

Fix basePath option

view details

Adrian Heine

commit sha 57e4d319db3564dcc7a45fc9ce9564bc48afa678

Abort after rejecting promise

view details

Adrian Heine

commit sha 5e9785badec7bdbdf99b92cb329cd998765dab02

Pass acme-tiny

view details

Adrian Heine

commit sha 673c498f11dea4e75a8d112f550bbb0fd941004a

Serial numbers

view details

Adrian Heine

commit sha 038d44317354271fdd9e3b66ee1c884db5b9f7a5

Check key length

view details

Adrian Heine

commit sha aea7e29435d0482403ad252197bd30f35e901c16

Adapt tests to recent changes

view details

Adrian Heine

commit sha 7583a347598d0ed99d69bc58ec7e99f292815888

Support LE's style and the IETF draft

view details

Adrian Heine

commit sha 21baba1036812b0dffda94137830495aa43b05ac

WIP

view details

Adrian Heine

commit sha 7c1e48acf01c75d72a8fdb26b30bf346842c8f6c

Add terms

view details

Adrian Heine

commit sha 63b6704ef222d82c440b6892cf37fdf2f7f6d60b

Make it work with api-v2

view details

Adrian Heine

commit sha c1f877184daef41b7c0027340d36b82a5f8b0495

Fix return value and timing issue

view details

push time in 17 days

create barnchadrianheine/node-acme

branch : letsencrypt

created branch time in 17 days

issue closedtc39/test262

Negative tests for complex rest properties are missing

As I pointed out in https://github.com/tc39/test262/issues/865#issuecomment-343862188. @rwaldron originally promised those in https://github.com/tc39/test262/issues/1050#issuecomment-303495480.

closed time in 18 days

adrianheine

issue commenttc39/test262

Negative tests for complex rest properties are missing

Ok :)

adrianheine

comment created time in 18 days

PullRequestReviewEvent

issue commentrust-lang/rust-clippy

default_trait_access should only fire on simple types

That's a very good observation, thanks! See also #5990 about this.

I think the nicest would be to explicitly include all types that can be »empty«, i. e. whose Default implementation does not depend on some other non-optional type parameter being Default. In this case, that would be RefCell<HashMap>::default(), but that's not valid syntax. RefCell::<HashMap<_, _>>::default() looks ugly. As such, I agree with your suggestion to just use the out-most type name. That's also something the lint already accepts, so this is really just about the suggested solution.

adrianheine

comment created time in 22 days

issue openedrust-lang/rust-clippy

default_trait_access suggests invalid syntax

#![deny(clippy::default_trait_access)]
fn main () {
    let x: Vec<u32> = Default::default();
}

clippy suggests std::vec::Vec<u32>::default()

error: comparison operators cannot be chained
 --> src/main.rs:3:36
  |
3 |     let x: Vec<u32> = std::vec::Vec<u32>::default();
  |                                    ^   ^
  |
help: use `::<...>` instead of `<...>` to specify type arguments
  |
3 |     let x: Vec<u32> = std::vec::Vec::<u32>::default();

created time in 22 days

issue commentrust-lang/rust-clippy

default_trait_access should only fire on simple types

Sure!

#![deny(clippy::default_trait_access)]
use std::cell::RefCell;
use std::collections::HashMap;
use std::future::Future;
use std::pin::Pin;

struct X {
    c: RefCell<HashMap<String, Pin<Box<dyn Future<Output = ()>>>>>
}

fn main() {
    let x = X { c: Default::default() };
}

gives

error: calling `std::cell::RefCell<std::collections::HashMap<std::string::String, std::pin::Pin<std::boxed::Box<dyn std::future::Future<Output = ()>>>>>::default()` is more clear than this expression
  --> src/main.rs:12:20
   |
12 |     let x = X { c: Default::default() };
   |                    ^^^^^^^^^^^^^^^^^^ help: try: `std::cell::RefCell<std::collections::HashMap<std::string::String, std::pin::Pin<std::boxed::Box<dyn std::future::Future<Output = ()>>>>>::default()`
   |
adrianheine

comment created time in 22 days

Pull request review commentytdl-org/youtube-dl

[hrfernsehen] add extractor

+# coding: utf-8+from __future__ import unicode_literals++import json+import re++from youtube_dl.utils import int_or_none+from .common import InfoExtractor+++class HRFernsehenIE(InfoExtractor):+    IE_NAME = 'hrfernsehen'+    _VALID_URL = r'^https?://www\.(?:hr-fernsehen|hessenschau)\.de/.*,video-[0-9]{6}\.html'++    _TESTS = [{+        'url': 'https://www.hessenschau.de/tv-sendung/hessenschau-vom-26082020,video-130546.html',+        'md5': '5c4e0ba94677c516a2f65a84110fc536',+        'info_dict': {+            'id': '130546',+            'ext': 'mp4',+            'description': 'Sturmtief Kirsten fegt über Hessen / Die Corona-Pandemie – eine Chronologie / '+                           'Sterbehilfe: Die Lage in Hessen / Miss Hessen leitet zwei eigene Unternehmen / '+                           'Pop-Up Museum zeigt Schwarze Unterhaltung und Black Music',+            'title': 'hessenschau vom 26.08.2020'+        }+    }, {+        'url': 'https://www.hessenschau.de/tv-sendung/hessenschau-vom-26082020,video-130546.html',+        'only_matching': True+    }]++    _GEO_COUNTRIES = ['DE']++    def _real_extract(self, url):+        video_id = re.search(r'video-([0-9]+)', url).group(1)

I think it's customary to use _VALID_URL for id matching if possible.

blocktrron

comment created time in 25 days

PullRequestReviewEvent

Pull request review commentytdl-org/youtube-dl

[hrfernsehen] add extractor

+# coding: utf-8+from __future__ import unicode_literals++import json+import re++from youtube_dl.utils import int_or_none+from .common import InfoExtractor+++class HRFernsehenIE(InfoExtractor):+    IE_NAME = 'hrfernsehen'+    _VALID_URL = r'^https?://www\.(?:hr-fernsehen|hessenschau)\.de/.*,video-[0-9]{6}\.html'++    _TESTS = [{+        'url': 'https://www.hessenschau.de/tv-sendung/hessenschau-vom-26082020,video-130546.html',+        'md5': '5c4e0ba94677c516a2f65a84110fc536',+        'info_dict': {+            'id': '130546',+            'ext': 'mp4',+            'description': 'Sturmtief Kirsten fegt über Hessen / Die Corona-Pandemie – eine Chronologie / '+                           'Sterbehilfe: Die Lage in Hessen / Miss Hessen leitet zwei eigene Unternehmen / '+                           'Pop-Up Museum zeigt Schwarze Unterhaltung und Black Music',+            'title': 'hessenschau vom 26.08.2020'+        }+    }, {+        'url': 'https://www.hessenschau.de/tv-sendung/hessenschau-vom-26082020,video-130546.html',

This URL is the same as above.

blocktrron

comment created time in 25 days

PullRequestReviewEvent

issue openedrust-lang/rust-clippy

default_trait_access should only fire on simple types

Calling std::cell::RefCell<std::collections::HashMap<R, futures::future::Shared<std::pin::Pin<std::boxed::Box<dyn futures::Future<Output = ()>>>>>>::default() is more clear than this expression

I don't agree

Calling std::marker::PhantomData<(L, B)>::default() is more clear than this expression

For PhantomData I think I always prefer Default::default().

created time in a month

Pull request review commentytdl-org/youtube-dl

[aparat] Fixed RegexNotFoundError

   class AparatIE(InfoExtractor):-    _VALID_URL = r'https?://(?:www\.)?aparat\.com/(?:v/|video/video/embed/videohash/)(?P<id>[a-zA-Z0-9]+)'+    _VALID_URL = r'https?://(?:www\.)?aparat\.com/(?:v/|video/video/embed/videohash/)(?P<id>[a-zA-Z0-9]+/|vt/frame)'

Shouldn't that slash be optional at least?

Bayany

comment created time in a month

Pull request review commentytdl-org/youtube-dl

[doodstream] new extractor

+# coding: utf-8+from __future__ import unicode_literals++import string+import random+import time++from .common import InfoExtractor+++class DoodStreamIE(InfoExtractor):+    _VALID_URL = r'https?://(?:www\.)?dood\.(?:to|watch)/[ed]/(?P<id>[a-z0-9]+)'+    _TESTS = [{+        'url': 'http://dood.to/e/5s1wmbdacezb',+        'md5': '4568b83b31e13242b3f1ff96c55f0595',+        'info_dict': {+            'id': '5s1wmbdacezb',+            'ext': 'mp4',+            'title': 'Kat Wonders - Monthly May 2020',+            'description': 'Kat Wonders - Monthly May 2020 | DoodStream.com',+            'thumbnail': 'https://img.doodcdn.com/snaps/flyus84qgl2fsk4g.jpg',+        }+    }, {+        'url': 'https://dood.to/d/jzrxn12t2s7n',+        'md5': '3207e199426eca7c2aa23c2872e6728a',+        'info_dict': {+            'id': 'jzrxn12t2s7n',+            'ext': 'mp4',+            'title': 'Stacy Cruz Cute ALLWAYSWELL',+            'description': 'Stacy Cruz Cute ALLWAYSWELL | DoodStream.com',+            'thumbnail': 'https://img.doodcdn.com/snaps/8edqd5nppkac3x8u.jpg',+        }+    }]++    def _real_extract(self, url):+        video_id = self._match_id(url)+        webpage = self._download_webpage(url, video_id)++        if '/d/' in url:+            url = "https://dood.to" + self._html_search_regex(+                r'<iframe src="(/e/[a-z0-9]+)"', webpage, 'embed')+            video_id = self._match_id(url)+            webpage = self._download_webpage(url, video_id)++        title = self._og_search_title(webpage) or self._html_search_meta(+            'twitter:title', webpage, default=None)+        thumb = self._og_search_thumbnail(webpage) or self._html_search_meta(+            'twitter:image', webpage, default=None)+        token = self._html_search_regex(r'[?&]token=([a-z0-9]+)[&\']', webpage, 'token')+        description = self._og_search_description(webpage) or self._html_search_meta(+            'description', webpage, default=None) or self._html_search_meta(+            'twitter:description', webpage, default=None)

I think some of these should be collapsed.

sxvghd

comment created time in a month

issue commentSimonBrazell/privacy-redirect

Option to not redirect instagram.com

Ah, thanks for the clarification :)

ToughGuyKunio

comment created time in a month

issue commentSimonBrazell/privacy-redirect

Option to not redirect instagram.com

That's »Bibliogram redirects«, isn't it?

ToughGuyKunio

comment created time in a month

PR opened ytdl-org/youtube-dl

[ABC] Fix abc.net.au/news and introduce abc.net.au/btn

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [x] I am the original author of this code and I am willing to release it under Unlicense
  • [ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • [x] Bug fix
  • [ ] Improvement
  • [x] New extractor
  • [ ] New feature

The first commit fixes abc.net/au/news (i. e. TestDownload.test_ABC_2), the second one introduces support for abc.net.au/btn (i. e. #21254).

+84 -20

0 comment

1 changed file

pr created time in a month

create barnchadrianheine/youtube-dl

branch : abc

created branch time in a month

pull request commentytdl-org/youtube-dl

[youtube] Fix age gate detection

This fixes the currently-failing TestAgeRestriction.test_youtube.

random-nick

comment created time in a month

PR opened ytdl-org/youtube-dl

[rutv] Fix JSON URL

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [x] I am the original author of this code and I am willing to release it under Unlicense
  • [ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • [x] Bug fix
  • [ ] Improvement
  • [ ] New extractor
  • [ ] New feature

Description of your pull request and other information

See #26333.

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchadrianheine/youtube-dl

branch : rutv

created branch time in a month

issue commentytdl-org/youtube-dl

youtube-dl doesn't detect videos from "vesti.ru", only live streams

That video is not available anymore.

Lirk88

comment created time in a month

push eventadrianheine/ada

Adrian Heine

commit sha 527cb6f85e343ddd02fb0485aaa1ccf3866cccfb

Add FOSS against capitalism?

view details

Adrian Heine

commit sha d65bc0f7b55f42f9186a0e62d28a1d041a8750ef

Link fixes

view details

push time in a month

issue commentacornjs/acorn-private-methods

acorn-private-class-elements is not bundled

What would be the benefits of bundling?

ngzhian

comment created time in a month

pull request commenttc39/notes

Add Adam to delegates.txt

This is superseded by #62.

codehag

comment created time in a month

created tagacornjs/acorn-stage3

tag4.0.0

Support for stage 3 proposals in acorn

created time in a month

push eventacornjs/acorn-stage3

Adrian Heine

commit sha 98d90e9e4ea19d75b82dc970cea1284801d7a6c9

Require acorn ^7.4 or ^8

view details

Adrian Heine

commit sha 722b6122455c391a8522c6125c611244dd2dcfce

4.0.0

view details

push time in a month

issue closedacornjs/acorn-stage3

Support for acorn-walk

The README states it's not compatible with acorn-walk, is there any plan to add support for this? I have a project that depends on that to be updated to acorn@7.x. Thanks!

closed time in a month

karellm

issue commentacornjs/acorn-stage3

Support for acorn-walk

I don't have plans to implement that. There's also #1 about this.

karellm

comment created time in a month

created tagacornjs/acorn-stage3

tag3.1.0

Support for stage 3 proposals in acorn

created time in a month

push eventacornjs/acorn-stage3

Adrian Heine

commit sha b3fcacfe279a134bfdad10e4e223bde769e97f3b

Bump all

view details

Adrian Heine

commit sha 7570a41b01f41127d25ef4beb20d20534c37ab90

3.1.0

view details

push time in a month

created tagacornjs/acorn-private-methods

tag0.3.3

Private methods, getters and setters support for acorn

created time in a month

push eventacornjs/acorn-private-methods

Adrian Heine

commit sha 795ac6b8f48684670a72800ba1fca6fcaec354d5

Fixup ESM introduction

view details

Adrian Heine

commit sha 1766cc80b88c753e8f2a63f96cce39e759ba0439

Mark compatible with acorn@8, bump dependencies

view details

Adrian Heine

commit sha 818f666eee2951c243bb88faf48ff5772391b5ba

0.3.3

view details

push time in a month

push eventacornjs/acorn-private-methods

Ng Zhi An

commit sha d778d94021d365d40fefb0f26de08c525e232072

Migrate to ESM We've recently migrated Chrome DevTools to ESM, and have traditionally been using acorn as the parser for various features including the prettifier. In the context of https://crbug.com/1084349we are looking into including private fields support in Chrome DevTools via this plugin, and in order to make that easier with our build system, I've added support for ESM output here in addition to the CJS output. (Basically the same change as https://github.com/acornjs/acorn-numeric-separator/pull/2)

view details

push time in a month

PR merged acornjs/acorn-private-methods

Migrate to ESM

We've recently migrated Chrome DevTools to ESM, and have traditionally been using acorn as the parser for various features including the prettifier. In the context of https://crbug.com/1084349we are looking into including private fields support in Chrome DevTools via this plugin, and in order to make that easier with our build system, I've added support for ESM output here in addition to the CJS output.

(Basically the same change as https://github.com/acornjs/acorn-numeric-separator/pull/2)

+31 -5

2 comments

5 changed files

ngzhian

pr closed time in a month

created tagacornjs/acorn-class-fields

tag0.3.7

Class fields support for acorn

created time in a month

push eventacornjs/acorn-class-fields

Adrian Heine

commit sha dc8d549b125931e04644a263ffba0d75e6a8800e

Mark as compatible with acorn@8

view details

Adrian Heine

commit sha f07b4de7c88e1f5855a4c79c8b3278d4db7faa16

Update test262 and test against acorn@8

view details

Adrian Heine

commit sha cbd8bc5467a4002e115de759e4ce9fd6399ac2c7

Don't break methods with line break after name Closes #14.

view details

Adrian Heine

commit sha 028dafefd5e76f7438e7865cbd915afa2e7e6bf1

lint

view details

Adrian Heine

commit sha 0af7c4692e5a68598e154317008e5b2dcaef8f8c

0.3.7

view details

push time in a month

issue closedacornjs/acorn-class-fields

Line break between method name and parenthesis breaks plugin

This works:

const {Parser} = require('acorn');

Parser.parse(`
class X { 
    x
    () {} 
}`);

This fails:

const {Parser} = require('acorn');
const classFields = require('acorn-class-fields');
Parser.extend(classFields).parse(`
class X { 
    x
    () {} 
}`);

with Unexpected token (4:4).

closed time in a month

ArtemGovorov

push eventacornjs/acorn-class-fields

Guy Bedford

commit sha 1372a66f9fe00ebb4124c4cb9ea69674ebb978a7

support await (#13)

view details

push time in a month

PR merged acornjs/acorn-class-fields

Support await

This attempts to fix https://github.com/acornjs/acorn-class-fields/issues/12.

It's a little odd that the state isn't already right to detect this without custom branches, but it does the job. Certainly not viable code for upstreaming though.

+10 -2

0 comment

2 changed files

guybedford

pr closed time in a month

issue closedacornjs/acorn-class-fields

Does not support top-level await

For example the following code:

export default class RequestParams {
    constructor(storage) {
        this._storage = storage;
    }

    headers = {
        'Authorization': await this._storage.getItem(`${domainPrefix}.auth.lockchain`),
        'Accept': 'application/json',
        'Content-Type': 'application/json',
        'X-Device-Version': '49365f68-42e1-11e8-842f-0ed5f89f718b'
    }
}

will throw an error due to the await keyword.

closed time in a month

guybedford

created tagacornjs/acorn-static-class-features

tag0.2.4

Static class features support for Acorn

created time in a month

push eventacornjs/acorn-static-class-features

Adrian Heine

commit sha e62e056289c054b9278462cab8c4e84d4d529f31

Mark as compatible with acorn@8, bump dependencies

view details

Adrian Heine

commit sha 18cb177aec2720b57fd808695eedda36aa7f3ee1

lint

view details

Adrian Heine

commit sha e46c56775200565fdb6f9902e3e4346b0d64dcf0

0.2.4

view details

push time in a month

created tagacornjs/acorn-private-class-elements

tag0.2.7

Helpers for supporting private class methods and fields in acorn

created time in a month

push eventacornjs/acorn-private-class-elements

Adrian Heine

commit sha 2936ac786143e6575b243a81c6f17875d36b073a

Mark as compatible with acorn@8

view details

Adrian Heine

commit sha 03a30eabf8d54d0b2c975e35c4c2d235453f3a4f

0.2.7

view details

push time in a month

push eventacornjs/acorn-static-class-features

Adrian Heine

commit sha e2a35d76833fc7054986c3cfb6cd367c6a6785a0

Allow super in field initializer (closes #7)

view details

push time in a month

issue closedacornjs/acorn-static-class-features

Parse error when "super" is used in a static class field

Originally via rollup/rollup#3702:

At the moment, the following example throws with "'super' keyword outside a method" when parsed:

class Foo extends Bar {
  static field = super.field + 1;
}

This should be supported and actually runs fine in e.g. current Chrome.

closed time in a month

lukastaegert

push eventacornjs/acorn-static-class-features

Adrian Heine

commit sha eb185aa38bc188a6a2f7f59a4510309c5f2ab541

Support keywords as field name (closes #6)

view details

push time in a month

issue closedacornjs/acorn-static-class-features

throw keyword static field name

require('acorn').Parser().extend(
    require('acorn-class-fields'),
    require('acorn-static-class-features'),
).parse('class X{static delete}');
SyntaxError: Unexpected token (1:21)
    at Object.pp$4.raise (/node_modules/acorn/dist/acorn.js:2893:15)
    at Object.pp.unexpected (/node_modules/acorn/dist/acorn.js:697:10)
    at Object.pp.expect (/node_modules/acorn/dist/acorn.js:691:28)
    at Object.pp$3.parseMethod (/node_modules/acorn/dist/acorn.js:2679:10)
    at Object.pp$1.parseClassMethod (/node_modules/acorn/dist/acorn.js:1398:25)
    at Object.pp$1.parseClassElement (/node_modules/acorn/dist/acorn.js:1387:10)
    at Object.parseClassElement (/node_modules/acorn-class-fields/index.js:52:38)
    at Object.parseClassElement (/node_modules/acorn-static-class-features/index.js:30:40)
    at Object.pp$1.parseClass (/node_modules/acorn/dist/acorn.js:1325:26)
    at Object.parseClass (/node_modules/acorn-private-class-elements/index.js:85:29)
    at Object.pp$1.parseStatement (/node_modules/acorn/dist/acorn.js:841:19)
    at Object.pp$1.parseTopLevel (/node_modules/acorn/dist/acorn.js:754:23)
    at Object.parse (/node_modules/acorn/dist/acorn.js:554:17)
    at Function.parse (/node_modules/acorn/dist/acorn.js:577:37)

closed time in a month

LongTengDao

push eventacornjs/acorn-numeric-separator

Adrian Heine

commit sha 57f830558d1a35a994c0a6f47d79d3aa131cfb19

Mark as compatible with acorn@8, bump dev dependencies

view details

Adrian Heine

commit sha c3cd04ce7d3558362048c5ad6718a8136ac40468

0.3.6

view details

push time in a month

push eventacornjs/acorn-logical-assignment

Adrian Heine

commit sha 806bfb37876680401f094c9c558b8425a029e237

Add dist/ to package, fix build with yarn

view details

Adrian Heine

commit sha 5526e0664a7ff7d59418a0eff101aa41e8e180b8

Mark as working with acorn@8, bump dev dependencies

view details

Adrian Heine

commit sha d5cad561e78032684451e0987b1266960a85b002

0.1.4

view details

push time in a month

issue closedacornjs/acorn-numeric-separator

v0.3.3 tarball's dist folder does not contain mjs

$ curl https://registry.npmjs.org/acorn-numeric-separator/-/acorn-numeric-separator-0.3.3.tgz | tar ztvf -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7736  100  7736    0     0   160k      0 --:--:-- --:--:-- --:--:--  160k
drwxr-xr-x 0/0               0 2020-06-13 08:17 package
-rw-r--r-- 0/0               6 2020-06-13 08:16 package/.eslintignore
-rw-r--r-- 0/0            9264 2020-06-13 08:16 package/.eslintrc.json
-rw-r--r-- 0/0             480 2020-06-13 08:16 package/CHANGELOG.md
-rw-r--r-- 0/0            1064 2018-09-14 02:17 package/LICENSE
-rw-r--r-- 0/0            1089 2020-06-13 08:16 package/README.md
drwxr-xr-x 0/0               0 2020-06-13 08:07 package/dist
-rw-r--r-- 0/0            1051 2020-06-13 08:16 package/package.json
-rw-r--r-- 0/0             332 2020-06-13 08:16 package/rollup.config.js
-rw-r--r-- 0/0             737 2020-05-03 05:19 package/run_test262.js
drwxr-xr-x 0/0               0 2020-06-13 08:16 package/src
drwxr-xr-x 0/0               0 2020-06-13 08:00 package/test
-rw-r--r-- 0/0            6187 2020-06-13 08:17 package/dist/acorn-numeric-separator.js
-rw-r--r-- 0/0            6034 2020-06-13 08:16 package/src/index.js
-rw-r--r-- 0/0              45 2017-12-16 15:17 package/test/.eslintrc.json
-rw-r--r-- 0/0            7600 2020-05-03 05:19 package/test/test.js

See how dist only contains acorn-numeric-separator.js, but not acorn-numeric-separator.mjs.

I tried running npm pack --dry-run locally:

$ npm pack --dry-run 2>&1 | grep mjs
src/index.js → dist/acorn-numeric-separator.js, dist/acorn-numeric-separator.mjs...
created dist/acorn-numeric-separator.js, dist/acorn-numeric-separator.mjs in 65ms
npm notice 13.4kB dist/acorn-numeric-separator.mjs.map
npm notice 6.2kB  dist/acorn-numeric-separator.mjs

and the mjs should be included in the tar.

closed time in a month

ngzhian

issue commentacornjs/acorn-numeric-separator

v0.3.3 tarball's dist folder does not contain mjs

Fixed with 0.3.5. Just creating a new pack didn't work for me with yarn, though.

ngzhian

comment created time in a month

push eventacornjs/acorn-numeric-separator

Adrian Heine

commit sha d3a3dcf4544e9067239a70247227fea2592b1ad9

Add .npmignore to include dist/

view details

Adrian Heine

commit sha 485f8a3e1c26e68f9270a11b39739dc18cfaf505

0.3.5

view details

push time in a month

push eventacornjs/acorn-numeric-separator

Adrian Heine

commit sha 14349135e6060bf492785c5620a82158dd7a5681

Make build independent of npm

view details

push time in a month

created tagacornjs/acorn-numeric-separator

tag0.3.4

Support for numeric separators in acorn

created time in a month

push eventacornjs/acorn-numeric-separator

Adrian Heine

commit sha 079bfbf5728642d1fdcc0699641323bb1754e54e

0.3.4

view details

push time in a month

issue closedacornjs/acorn-private-class-elements

Didn't handle error friendly

TEST.js:

'use strict';
Error.stackTraceLimit = 100;
const Parser = require('acorn').Parser.extend(require('acorn-class-fields'));
Parser.parse('a.#1=c;');

The error thrown is not friendly with loc info any more:

        if (!this._privateBoundNamesStack.length || !this._privateBoundNamesStack[this._privateBoundNamesStack.length - 1][node.property.name]) {
                                          ^
TypeError: Cannot read property 'length' of undefined
    at Object.parseSubscript             (/node_modules/acorn-class-fields/node_modules/acorn-private-class-elements/index.js:101:43)
    at Object.pp$3.parseSubscripts       (/node_modules/acorn/dist/acorn.js:2104:26)
    at Object.pp$3.parseExprSubscripts   (/node_modules/acorn/dist/acorn.js:2092:23)
    at Object.pp$3.parseMaybeUnary       (/node_modules/acorn/dist/acorn.js:2066:19)
    at Object.parseMaybeUnary            (/node_modules/acorn-class-fields/node_modules/acorn-private-class-elements/index.js:112:29)
    at Object.pp$3.parseExprOps          (/node_modules/acorn/dist/acorn.js:2010:21)
    at Object.pp$3.parseMaybeConditional (/node_modules/acorn/dist/acorn.js:1993:21)
    at Object.pp$3.parseMaybeAssign      (/node_modules/acorn/dist/acorn.js:1968:21)
    at Object.pp$3.parseExpression       (/node_modules/acorn/dist/acorn.js:1933:21)
    at Object.pp$1.parseStatement        (/node_modules/acorn/dist/acorn.js:877:47)
    at Object.pp$1.parseTopLevel         (/node_modules/acorn/dist/acorn.js:746:23)
    at Object.parse                      (/node_modules/acorn/dist/acorn.js:553:17)
    at Function.parse                    (/node_modules/acorn/dist/acorn.js:576:37)
    at Object.<anonymous>                (/TEST.js:4:8)
    at Module._compile                   (internal/modules/cjs/loader.js:955:30)
    at Object.Module._extensions..js     (internal/modules/cjs/loader.js:991:10)
    at Module.load                       (internal/modules/cjs/loader.js:811:32)
    at Function.Module._load             (internal/modules/cjs/loader.js:723:14)
    at Function.Module.runMain           (internal/modules/cjs/loader.js:1043:10)
    at                                   (internal/main/run_main_module.js:17:11)

closed time in a month

LongTengDao

issue commentacornjs/acorn-private-class-elements

Didn't handle error friendly

This now throws a SyntaxError: Usage of undeclared private name, I think that's alright.

LongTengDao

comment created time in a month

issue closedacornjs/acorn-private-class-elements

Keyword support

The following throws an error:

class P {
  delete = 5;
}

with the above is supported in eg Babel. Yet the corresponding class method definition is fine:

class P {
  delete () {
  }
}

I wonder if we should run the parseIdentifier with liberal to cater to this flexibility? I'm not sure which would be exactly correct by the spec, but I feel like it likely would be similar to class definitions surely?

closed time in a month

guybedford

issue commentacornjs/acorn-private-class-elements

Keyword support

That's fixed with acornjs/acorn-class-fields#10, right?

guybedford

comment created time in a month

issue closedacornjs/acorn

Dynamic import parsing throws 'import' and 'export' may only appear at the top level

The following change is throwing an error for dynamic module imports. image. Setting topLevel flag to null in parseStatement function which raises the

"'import' and 'export' may only appear at the top level"

Dynamic module import use to work in 5.7.3 with same settings.

I'm using angular-cli to compile my app which updated webpack to 4.29.9 with new acorn changes. Not sure if this is an angular-cli, webpack or acorn issue but after debugging I noticed these differences in acorn.

closed time in a month

xsurge83

issue commentytdl-org/youtube-dl

[Videa] now returns : ERROR: Unable to download XML: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>)

Note that the video from the issue is not available anymore.

sebma

comment created time in a month

push eventadrianheine/youtube-dl

Adrian Heine

commit sha 34675f9de91bd0e8a98b151b6bff4a795d7f2428

[videa] Adapt to updates Closes #26288, closes #25973, closes #25650.

view details

push time in a month

PR opened ytdl-org/youtube-dl

[videa] Adapt to updates

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [x] I am the original author of this code and I am willing to release it under Unlicense
  • [ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • [x] Bug fix
  • [ ] Improvement
  • [ ] New extractor
  • [ ] New feature

Description of your pull request and other information

Closes #26288, closes #25973, closes #25650.

+55 -2

0 comment

1 changed file

pr created time in a month

create barnchadrianheine/youtube-dl

branch : videa

created branch time in a month

push eventadrianheine/hire-adrian-heine

Adrian Heine

commit sha e097150c752ec24b2e69f64e22d119f6fb9947d8

Update CV

view details

push time in a month

push eventadrianheine/hire-adrian-heine

Adrian Heine

commit sha 32940942234162359ef6bfc589b93e9b2c53fd5f

Update CV

view details

push time in a month

push eventadrianheine/hire-adrian-heine

Adrian Heine

commit sha e2ea732af4e9b505c8e2f0e5c024a4b073cb1461

Avoid express security issue

view details

push time in a month

push eventadrianheine/hire-adrian-heine

Adrian Heine

commit sha 9d33d8d0f339d6af1524d937db650c601272afa7

Update eslint, fix style

view details

Adrian Heine

commit sha 97f8c5b1887cfe13ba6ce24ce9d1400620ab3f2a

Update a few skill scores

view details

push time in a month

issue commentytdl-org/youtube-dl

Youtube-dl no longer downloads from videa.hu

Duplicate of #25973.

pampi9

comment created time in a month

Pull request review commentytdl-org/youtube-dl

[Mildom] Add new extractor

+# coding: utf-8+from __future__ import unicode_literals++import re++from .common import InfoExtractor+from ..compat import compat_str+from ..utils import try_get+++class MildomIE(InfoExtractor):+    _VALID_URL = r'https?://(?:www\.)?mildom\.com/playback/(?P<channel>[0-9]+)\?v_id=(?P<id>[-0-9]+)'+    _VIDEO_INFO_BASE_URL = 'https://cloudac.mildom.com/nonolive/videocontent/playback/getPlaybackDetail'+    _TEST = {+        'url': 'https://www.mildom.com/playback/10819667?v_id=10819667-1594032863',+        'md5': 'bed067a7dff3492184bd06d6131dd8be',+        'info_dict': {+            'id': '10819667-1594032863',+            'ext': 'mp4',+            'title': '月曜!雀荘ほめちぎり #1',+            'thumbnail': r're:^https?://.*\.png$',+            'description': '#1 記念すべき初回の出演者は声優の高木美佑さんとVtuber界の麻雀つよつよ先生こと千羽黒乃さん!\nMildom公式番組『麻雀番組』毎週月曜に生放送!\n麻雀アプリも使った視聴者対戦型麻雀バラエティ!',+            'uploader': '月曜!雀荘ほめちぎり'+        }+    }++    def _real_extract(self, url):+        channel_id, video_id = re.match(self._VALID_URL, url).groups()++        webpage = self._download_webpage(url, video_id)+        video_data = self._download_json(+            self._VIDEO_INFO_BASE_URL + '?v_id=%s' % video_id, video_id)

I think it's better to directly include '?v_id=%s' in _VIDEO_INFO_BASE_URL.

rli99

comment created time in a month

pull request commentytdl-org/youtube-dl

[myvideoge] New extractor

Thanks for your PR! Please open separate pull requests for separate changes.

fonkap

comment created time in a month

Pull request review commentytdl-org/youtube-dl

[Mildom] Add new extractor

+# coding: utf-8+from __future__ import unicode_literals++import re++from .common import InfoExtractor+from ..compat import compat_str+from ..utils import try_get+++class MildomIE(InfoExtractor):+    _VALID_URL = r'https?://(?:www\.)?mildom\.com/playback/(?P<channel>[0-9]+)\?v_id=(?P<id>[-0-9]+)'+    _VIDEO_INFO_BASE_URL = 'https://cloudac.mildom.com/nonolive/videocontent/playback/getPlaybackDetail'+    _TEST = {+        'url': 'https://www.mildom.com/playback/10819667?v_id=10819667-1594032863',+        'md5': 'bed067a7dff3492184bd06d6131dd8be',+        'info_dict': {+            'id': '10819667-1594032863',+            'ext': 'mp4',+            'title': '月曜!雀荘ほめちぎり #1',+            'thumbnail': r're:^https?://.*\.png$',+            'description': '#1 記念すべき初回の出演者は声優の高木美佑さんとVtuber界の麻雀つよつよ先生こと千羽黒乃さん!\nMildom公式番組『麻雀番組』毎週月曜に生放送!\n麻雀アプリも使った視聴者対戦型麻雀バラエティ!',+            'uploader': '月曜!雀荘ほめちぎり'+        }+    }++    def _real_extract(self, url):+        channel_id, video_id = re.match(self._VALID_URL, url).groups()++        webpage = self._download_webpage(url, video_id)+        video_data = self._download_json(+            self._VIDEO_INFO_BASE_URL + '?v_id=%s' % video_id, video_id)+        playback_data = video_data['body']['playback']++        video_url = playback_data['source_url']+        description = playback_data.get('video_intro')+        uploader = try_get(playback_data, lambda x: x['author_info']['login_name'], compat_str)+        title = playback_data.get('title')+        if not title:+            title = self._html_search_meta(+                ['og:description', 'description'],+                webpage, 'title', default=None)+        thumbnail = playback_data.get('video_pic')+        if not thumbnail:+            thumbnail = self._html_search_meta(+                'og:image',+                webpage, 'thumbnail', default=None)

This could use _og_search_thumbnail instead:

thumbnail = self._og_search_thumbnail(webpage, default=None)
rli99

comment created time in a month

Pull request review commentytdl-org/youtube-dl

[Mildom] Add new extractor

+# coding: utf-8+from __future__ import unicode_literals++import re++from .common import InfoExtractor+from ..compat import compat_str+from ..utils import try_get+++class MildomIE(InfoExtractor):+    _VALID_URL = r'https?://(?:www\.)?mildom\.com/playback/(?P<channel>[0-9]+)\?v_id=(?P<id>[-0-9]+)'+    _VIDEO_INFO_BASE_URL = 'https://cloudac.mildom.com/nonolive/videocontent/playback/getPlaybackDetail'+    _TEST = {+        'url': 'https://www.mildom.com/playback/10819667?v_id=10819667-1594032863',+        'md5': 'bed067a7dff3492184bd06d6131dd8be',+        'info_dict': {+            'id': '10819667-1594032863',+            'ext': 'mp4',+            'title': '月曜!雀荘ほめちぎり #1',+            'thumbnail': r're:^https?://.*\.png$',+            'description': '#1 記念すべき初回の出演者は声優の高木美佑さんとVtuber界の麻雀つよつよ先生こと千羽黒乃さん!\nMildom公式番組『麻雀番組』毎週月曜に生放送!\n麻雀アプリも使った視聴者対戦型麻雀バラエティ!',+            'uploader': '月曜!雀荘ほめちぎり'+        }+    }++    def _real_extract(self, url):+        channel_id, video_id = re.match(self._VALID_URL, url).groups()++        webpage = self._download_webpage(url, video_id)

Maybe this could be done only if necessary to save one request?

rli99

comment created time in a month

Pull request review commentytdl-org/youtube-dl

[Mildom] Add new extractor

+# coding: utf-8+from __future__ import unicode_literals++import re++from .common import InfoExtractor+from ..compat import compat_str+from ..utils import try_get+++class MildomIE(InfoExtractor):+    _VALID_URL = r'https?://(?:www\.)?mildom\.com/playback/(?P<channel>[0-9]+)\?v_id=(?P<id>[-0-9]+)'+    _VIDEO_INFO_BASE_URL = 'https://cloudac.mildom.com/nonolive/videocontent/playback/getPlaybackDetail'+    _TEST = {+        'url': 'https://www.mildom.com/playback/10819667?v_id=10819667-1594032863',+        'md5': 'bed067a7dff3492184bd06d6131dd8be',+        'info_dict': {+            'id': '10819667-1594032863',+            'ext': 'mp4',+            'title': '月曜!雀荘ほめちぎり #1',
            'title': '月曜!雀荘ほめちぎり #1 【麻雀】',

(according to json)

rli99

comment created time in a month

push eventadrianheine/youtube-dl

willbeaufoy

commit sha 46d0baf9412eca5c9241fa55ddc133682e2f2ad7

[options] Clarify doc on --exec command (closes #19087) (#24883)

view details

Philipp Stehle

commit sha 2cdfe977d7e006ae93c427868ec1c5701d49cf1a

[prosiebensat1] Improve extraction and remove 7tv.de support (#24948)

view details

Sergey M․

commit sha 38db9a405ada5ccf333d43004f4a5394f47ef905

[prosiebensat1] Extract series metadata

view details

Sergey M․

commit sha c97f5e934f30309237f5229b16dc9ea1da4e18f2

[tenplay] Relax _VALID_URL (closes #25001)

view details

Remita Amine

commit sha 700265bfcf77f19bdf56062865c1fdf18ca3c9da

[tvplay] fix Viafree extraction(closes #15189)(closes #24473)(closes #24789)

view details

Remita Amine

commit sha 2468a6fa6416fbe617aea00d8203abc74f481d87

[yahoo] fix GYAO Player extraction and relax title URL regex(closes #24178)(closes #24778)

view details

Sergey M․

commit sha 011e75e641ad2b7fa141a05fa35d3e5d6d0b736b

[youtube] Use redirected video id if any (closes #25063)

view details

Sergey M․

commit sha e40c758c2a8f049cd254ad73f0e6ade00bd004d9

[youtube] Improve player id extraction and add tests

view details

Sergey M․

commit sha 4433bb02457f961dc2a753b3d4350a4a8cae138f

[extractor/common] Extract multiple JSON-LD entries

view details

Sergey M․

commit sha 6ffc3cf74ab3d7044c46e2ff4cd5265aeca347f1

[crunchyroll] Fix and improve extraction (closes #25096, closes #25060)

view details

Sergey M․

commit sha 66f32ca0e1fbacdc4a61451c5496553439002bdb

[ChangeLog] Actualize [ci skip]

view details

Sergey M․

commit sha 00a41ca4c32ff4b4b30c0bb6d9fbdf74d8230dc6

release 2020.05.03

view details

Sergey M․

commit sha f7f304910d1c1fc19313231d424daba304e1de71

[puhutv] Remove no longer available HTTP formats (closes #25124)

view details

Sergey M․

commit sha c380cc28c4e94b4b61db7f86d35e48197b407266

[utils] Improve cookie files support + Add support for UTF-8 in cookie files * Skip malformed cookie file entries instead of crashing (invalid entry len, invalid expires at)

view details

Sergey M․

commit sha 676723e0daf86eafb31d82ba07813ebc98b334dd

[dailymotion] Fix typo

view details

Sergey M․

commit sha 6d874fee2a4b54272c48960f3082072d37a7e0ae

[compat] Introduce compat_cookiejar_Cookie

view details

Sergey M․

commit sha 6c22cee673f59407a63b2916d8f0623a95a8ea20

[extractor/common] Use compat_cookiejar_Cookie for _set_cookie (closes #23256, closes #24776) To always ensure cookie name and value are bytestrings on python 2.

view details

hh0rva1h

commit sha 1328305851bf2b708f74140b35a600c955d58394

[orf] Add support for more radio stations (closes #24938) (#24968)

view details

Remita Amine

commit sha ce7db64bf1a558759be63e92f34550d7ba0e4052

[uol] fix extraction(closes #22007)

view details

Sergey M․

commit sha f7b42518dc4c10d6027bfe7f5e7f186d526b1a4b

[downloader/http] Finish downloading once received data length matches expected Always do this if possible, i.e. if Content-Length or expected length is known, not only in test. This will save unnecessary last extra loop trying to read 0 bytes.

view details

push time in 2 months

more