profile
viewpoint

llvm/llvm-project 6332

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. Note: the repository does not accept github pull requests at this moment. Please submit your patches at http://reviews.llvm.org.

adrian-prantl/adventure 15

an advanced text adventure engine with a web interface, written in prolog

adrian-prantl/edg4x-rose 0

(C++11 Branch) A compiler infrastructure to build source-to-source program transformation and analysis tools.

adrian-prantl/GSoC-2018 0

The post about my GSoC'18 project.

adrian-prantl/homebrew 0

The missing package manager for OS X.

adrian-prantl/rose 0

A compiler infrastructure to build source-to-source program transformation and analysis tools.

adrian-prantl/swift 0

The Swift Programming Language

adrian-prantl/swift-lldb 0

This is the version of LLDB that supports the Swift programming language & REPL.

PullRequestReviewEvent

PR opened apple/llvm-project

Bind generic types in the expression evaluator if dybamic types are r…

https://github.com/apple/llvm-project/pull/2014

+14 -15

0 comment

3 changed files

pr created time in 7 hours

create barnchadrian-prantl/llvm-project

branch : binding-next

created branch time in 7 hours

create barnchadrian-prantl/llvm-project

branch : binding-main

created branch time in 7 hours

push eventapple/llvm-project

Adrian Prantl

commit sha 6fd82025613a99aac5f8076e0ee2fe0091228e09

Use the use_dynamic option to determine whether to dynamically resolve self in Swift expressions. This is a more principled approach over always dynamically resolving all types and fixes a regression hidden by the recent @swiftTest decorator bug. (cherry picked from commit 46fd0aea2476e835245250bac231b7ec097da654)

view details

adrian-prantl

commit sha 71d299185477b2af11b52ac2662cf389fce402e5

Merge pull request #2008 from adrian-prantl/dynamic-next Use the use_dynamic option to determine whether to dynamically resolve

view details

push time in 7 hours

PR merged apple/llvm-project

Use the use_dynamic option to determine whether to dynamically resolve

self in Swift expressions.

This is a more principled approach over always dynamically resolving all types and fixes a regression hidden by the recent @swiftTest decorator bug.

(cherry picked from commit d1bfc99b848f097e85e8f90d9bd0956dc69e2d89)

+69 -45

1 comment

12 changed files

adrian-prantl

pr closed time in 7 hours

push eventapple/llvm-project

Adrian Prantl

commit sha 46fd0aea2476e835245250bac231b7ec097da654

Use the use_dynamic option to determine whether to dynamically resolve self in Swift expressions. This is a more principled approach over always dynamically resolving all types and fixes a regression hidden by the recent @swiftTest decorator bug.

view details

adrian-prantl

commit sha c6d7adbdbade1a2c4c2c144f34224db44a3b1457

Merge pull request #2007 from adrian-prantl/dynamic-main Use the use_dynamic option to determine whether to dynamically resolve

view details

push time in 7 hours

PR merged apple/llvm-project

Use the use_dynamic option to determine whether to dynamically resolve

self in Swift expressions.

This is a more principled approach over always dynamically resolving all types and fixes a regression hidden by the recent @swiftTest decorator bug.

+69 -47

3 comments

13 changed files

adrian-prantl

pr closed time in 7 hours

PR opened apple/llvm-project

Remove obsolote early exit.

…eb06ed376801251bdfd992905a66f276c

(cherry picked from commit 202bca8ce065d6543aee512cdf37f2ade93521ad)

https://github.com/apple/llvm-project/pull/2012

+1 -4

0 comment

2 changed files

pr created time in 9 hours

create barnchadrian-prantl/llvm-project

branch : nodeforprinting-next

created branch time in 9 hours

create barnchadrian-prantl/llvm-project

branch : nodeforprinting-main

created branch time in 9 hours

pull request commentapple/llvm-project

Use the use_dynamic option to determine whether to dynamically resolve

@swift-ci test

adrian-prantl

comment created time in 11 hours

push eventadrian-prantl/llvm-project

Adrian Prantl

commit sha 6fd82025613a99aac5f8076e0ee2fe0091228e09

Use the use_dynamic option to determine whether to dynamically resolve self in Swift expressions. This is a more principled approach over always dynamically resolving all types and fixes a regression hidden by the recent @swiftTest decorator bug. (cherry picked from commit 46fd0aea2476e835245250bac231b7ec097da654)

view details

push time in 12 hours

push eventadrian-prantl/llvm-project

Adrian Prantl

commit sha 46fd0aea2476e835245250bac231b7ec097da654

Use the use_dynamic option to determine whether to dynamically resolve self in Swift expressions. This is a more principled approach over always dynamically resolving all types and fixes a regression hidden by the recent @swiftTest decorator bug.

view details

push time in 12 hours

push eventadrian-prantl/llvm-project

Vitaly Buka

commit sha f97ca48b1cbbf5da065e94271cb3af4f1c907dd4

[sanitizer] Fix compilation on older systems Fixes https://bugs.llvm.org/show_bug.cgi?id=47896

view details

git apple-llvm automerger

commit sha 5e6b1d72b9cc72827799435f3b87297db0bf48b0

Merge commit 'f97ca48b1cbb' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha c401b7a08b5da332fceeedbd7444976a93842b65

Merge commit '5e6b1d72b9cc' from apple/main into swift/next

view details

Fangrui Song

commit sha 2484e9159c54def19aac69c4a217a55329da54d2

[Driver] Clean up -gz & --compress-debug-sections * Make cc1 and cc1as --compress-debug-sections an alias for --compress-debug-sections=zlib * Make -gz an alias for -gz=zlib The new behavior is consistent with GCC when binutils>=2.26 is detected: -gz is translated to --compress-debug-sections=zlib instead of --compress-debug-sections.

view details

git apple-llvm automerger

commit sha 2347933f94e186ac455682a0b00431886ede92a1

Merge commit '2484e9159c54' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha 970ef66389b904613042a51526e9c4961c389490

Merge commit '2347933f94e1' from apple/main into swift/next

view details

Igor Kudrin

commit sha 1329944c221ce2187acd30920dde8d443f8dac19

[LTO][Legacy] Eliminate an unused member of llvm::LTOModule. NFC. This is a follow-up for D62935 where the corresponding API methods were removed. Differential Revision: https://reviews.llvm.org/D89472

view details

git apple-llvm automerger

commit sha 125e28c14300a55f7a4d18b683fdbcc6b216b79e

Merge commit '1329944c221c' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha c8f0387ab684a14b3cdab5417e98bb57222b0ba2

Merge commit '125e28c14300' from apple/main into swift/next

view details

Richard Smith

commit sha 08c8d5bc51c512e605840b8003fcf38c86d0fc96

Properly track whether a variable is constant-initialized. This fixes miscomputation of __builtin_constant_evaluated in the initializer of a variable that's not usable in constant expressions, but is readable when constant-folding. If evaluation of a constant initializer fails, we throw away the evaluated result instead of keeping it as a non-constant-initializer value for the variable, because it might not be a correct value. To avoid regressions for initializers that are foldable but not formally constant initializers, we now try constant-evaluating some globals in C++ twice: once to check for a constant initializer (in an mode where is_constannt_evaluated returns true) and again to determine the runtime value if the initializer is not a constant initializer.

view details

git apple-llvm automerger

commit sha 015871b54d5ad55056e82db1ecf4f873b7546591

Merge commit '08c8d5bc51c5' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha 770e497efecd6258f3c7cca22ad6f40f202f7837

Merge commit '015871b54d5a' from apple/main into swift/next

view details

Atmn Patel

commit sha 595c6156068458481395d0f87da16e51a3121a4e

[IR] Adds mustprogress as a LLVM IR attribute This adds the LLVM IR attribute `mustprogress` as defined in LangRef through D86233. This attribute will be applied to functions with in languages like C++ where forward progress is guaranteed. Functions without this attribute are not required to make progress. Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D85393

view details

git apple-llvm automerger

commit sha 9f51b549a845be7a16bedeadab8ec1bd504daf49

Merge commit '595c61560684' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha 60b892342526e5f32127f437f8d81b839e0d812b

Merge commit '9f51b549a845' from apple/main into swift/next

view details

Alex Zinenko

commit sha 39613c2cbc8f11ff6246211385134f0a548b5b57

[mlir] Expose Value hierarchy to C API The Value hierarchy consists of BlockArgument and OpResult, both of which derive Value. Introduce IsA functions and functions specific to each class, similarly to other class hierarchies. Also, introduce functions for pointer-comparison of Block and Operation that are necessary for testing and are generally useful. Reviewed By: stellaraccident, mehdi_amini Differential Revision: https://reviews.llvm.org/D89714

view details

git apple-llvm automerger

commit sha ff02a8177cb9ed25179f8be789e6d667ae0bfd40

Merge commit '39613c2cbc8f' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha a89e75828e59d1dd55c092296ba3192d5aa63fee

Merge commit 'ff02a8177cb9' from apple/main into swift/next

view details

David Green

commit sha 6dcbc323fd8778ba6db1c4e76c809f93fc82efc5

Revert "[ARM][LowOverheadLoops] Adjust Start insertion." This reverts commit 38f625d0d1360b035271422bab922d22ed04d79a. This commit contains some holes in its logic and has been causing issues since it was commited. The idea sounds OK but some cases were not handled correctly. Instead of trying to fix that up later it is probably simpler to revert it and work to reimplement it in a more reliable way.

view details

git apple-llvm automerger

commit sha f06fd0c2440aa22ddcca3820e66b92b762474390

Merge commit '6dcbc323fd87' from llvm.org/master into apple/main

view details

push time in 12 hours

pull request commentapple/llvm-project

Use the use_dynamic option to determine whether to dynamically resolve

@swift-ci test

adrian-prantl

comment created time in 12 hours

push eventadrian-prantl/llvm-project

Adrian Prantl

commit sha a42807e40fa83f729ada18116a781bb55ca662e5

Use the use_dynamic option to determine whether to dynamically resolve self in Swift expressions. This is a more principled approach over always dynamically resolving all types and fixes a regression hidden by the recent @swiftTest decorator bug.

view details

push time in 12 hours

Pull request review commentapple/llvm-project

Use the use_dynamic option to determine whether to dynamically resolve

 func apply<Type>(_ T : Type, fn: (Type) -> Type) -> Type { return fn(T) } public func f<Type>(_ value : Type) {   apply(value) { arg in-    return arg //% self.expect('po arg', substrs=['3735928559'])+    return arg //% self.expect('expr -o -d run TestSwiftGenericStructDebugInfoGenericApply.py -- arg', substrs=['3735928559'])

I think this is an artifact of how arguments are parsed (and how I copied &pasted)

adrian-prantl

comment created time in 12 hours

PullRequestReviewEvent

Pull request review commentapple/llvm-project

Use the use_dynamic option to determine whether to dynamically resolve

 func apply<Type>(_ T : Type, fn: (Type) -> Type) -> Type { return fn(T) } public func f<Type>(_ value : Type) {   apply(value) { arg in-    return arg //% self.expect('po arg', substrs=['3735928559'])+    return arg //% self.expect('expr -o -d run TestSwiftGenericStructDebugInfoGenericApply.py -- arg', substrs=['3735928559'])

Wow.

adrian-prantl

comment created time in 12 hours

PullRequestReviewEvent

pull request commentapple/llvm-project

Use the use_dynamic option to determine whether to dynamically resolve

https://github.com/apple/llvm-project/pull/2007

adrian-prantl

comment created time in a day

PR opened apple/llvm-project

Use the use_dynamic option to determine whether to dynamically resolve

self in Swift expressions.

This is a more principled approach over always dynamically resolving all types and fixes a regression hidden by the recent @swiftTest decorator bug.

(cherry picked from commit d1bfc99b848f097e85e8f90d9bd0956dc69e2d89)

+68 -44

0 comment

11 changed files

pr created time in a day

create barnchadrian-prantl/llvm-project

branch : dynamic-next

created branch time in a day

PR opened apple/llvm-project

Use the use_dynamic option to determine whether to dynamically resolve

self in Swift expressions.

This is a more principled approach over always dynamically resolving all types and fixes a regression hidden by the recent @swiftTest decorator bug.

+68 -45

0 comment

12 changed files

pr created time in a day

push eventadrian-prantl/llvm-project

Adrian Prantl

commit sha f6b1a6a54bcd70baad35e594fc40fc5b24201359

Add support for more OS types to AddClangModuleCompilationOptionsForSDKType() This patch also avoids hardcoding the clang options, which makes it less likely for them to become out-of-date. rdar://problem/63791367+66927829 Differential Revision: https://reviews.llvm.org/D89428 (cherry picked from commit cf245086518efbdf96c2d86697298a8da5c97669) Conflicts: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

view details

adrian-prantl

commit sha 1322305e1787ffde943dde3a2548dfea2c539b79

Merge pull request #1983 from adrian-prantl/66927829 Add support for more OS types to AddClangModuleCompilationOptionsForS…

view details

git apple-llvm automerger

commit sha e7b3fd96f873f8307d4d6175c36bb8d60660baf7

Merge commit '1322305e1787' from apple/stable/20200714 into swift/main

view details

adrian-prantl

commit sha 162a8bc445fd583a89aef653c46676511e8da145

Merge pull request #2002 from adrian-prantl/unxfail-main Fix some regressions uncovered by https://github.com/apple/llvm-project/pull/1997

view details

Adrian Prantl

commit sha d1bfc99b848f097e85e8f90d9bd0956dc69e2d89

Use the use_dynamic option to determine whether to dynamically resolve self in Swift expressions. This is a more principled approach over always dynamically resolving all types and fixes a regression hidden by the recent @swiftTest decorator bug.

view details

push time in a day

push eventapple/llvm-project

Adrian Prantl

commit sha 9a8083d9629d9b4e287cf0d218b9a65af235d3ac

Remove validation from GetTypeBitAlign. This method doesn't use VALIDATE_AND_RETURN because except for fixed-size types the SwiftASTContext implementation forwards to SwiftLanguageRuntime anyway and for some fixed-size types the fixed layout still returns an incorrect default alignment of 0.

view details

Adrian Prantl

commit sha 5c10c169a0d44587361f29e64326bcffc91c19e0

Remove obsolete early exit.

view details

Adrian Prantl

commit sha 9e8e885bb80d569d7de661a7d6a198f1f3c67f5f

delete commented-out code

view details

Adrian Prantl

commit sha 66359bb34b4bf3917650cc425b2473f1ad3607e9

unxfail passing tests

view details

adrian-prantl

commit sha 162a8bc445fd583a89aef653c46676511e8da145

Merge pull request #2002 from adrian-prantl/unxfail-main Fix some regressions uncovered by https://github.com/apple/llvm-project/pull/1997

view details

push time in a day

create barnchadrian-prantl/llvm-project

branch : dynamic-main

created branch time in a day

push eventapple/llvm-project

Adrian Prantl

commit sha 7d7332cea820cf5a4dfbb652fcd337ef1642573c

Remove validation from GetTypeBitAlign. This method doesn't use VALIDATE_AND_RETURN because except for fixed-size types the SwiftASTContext implementation forwards to SwiftLanguageRuntime anyway and for some fixed-size types the fixed layout still returns an incorrect default alignment of 0. (cherry picked from commit 9a8083d9629d9b4e287cf0d218b9a65af235d3ac)

view details

Adrian Prantl

commit sha 1a3642d4dd19d8d209eb9477b06c9d6a697afbbb

Remove obsolete early exit. (cherry picked from commit 5c10c169a0d44587361f29e64326bcffc91c19e0)

view details

Adrian Prantl

commit sha 4308a306a1cc68690281aa9dd363fc524c35b0f8

delete commented-out code (cherry picked from commit 9e8e885bb80d569d7de661a7d6a198f1f3c67f5f)

view details

adrian-prantl

commit sha 160a585ef0af440084ec8262de4645db7d12558c

Merge pull request #2003 from adrian-prantl/unxfail-next Fix some regressions uncovered by https://github.com/apple/llvm-project/pull/1997

view details

push time in a day

Pull request review commentapple/llvm-project

TypeSystem: Avoid the ISO646 spelling of the logical operators

 template <> struct less<swift::ClusteredBitVector> {     for (; iL >= 0 && iR >= 0; --iL, --iR) {

That was more a question for the room — I know you're just the messenger :-)

compnerd

comment created time in a day

PullRequestReviewEvent

create barnchadrian-prantl/llvm-project

branch : unxfail-next

created branch time in a day

pull request commentapple/llvm-project

[lldb][swift] Make swiftTest decorator not always skip and skipIf regressed tests temporarily

@Teemperor please don't forget to cherry-pick this to swift/next

but don't cherry-pick the XFAILs

Teemperor

comment created time in a day

create barnchadrian-prantl/llvm-project

branch : unxfail-main

created branch time in a day

Pull request review commentapple/llvm-project

TypeSystem: Avoid the ISO646 spelling of the logical operators

 template <> struct less<swift::ClusteredBitVector> {     for (; iL >= 0 && iR >= 0; --iL, --iR) {

why does this even exist? Are we putting them into a std::map?

compnerd

comment created time in a day

PullRequestReviewEvent

pull request commentapple/llvm-project

[lldb][swift] Make swiftTest decorator not always skip and skipIf regressed tests temporarily

@Teemperor please don't forget to cherry-pick this to swift/next

Teemperor

comment created time in a day

push eventapple/llvm-project

Raphael Isemann

commit sha 386224aa218ced4bd417a3936cc1033ec59758df

[lldb][swift] Make swiftTest decorator not always skip _get_bool_config_skip_if_decorator returns a decorator, but the is_not_swift_compatible function is supposed to return a bool. The skipTestIfFn is supposed to create the decorator from the function we define. As _get_bool_config_skip_if_decorator's return value is just interpreted as True, this ends up causing that we skip all Swift tests all the time. This just adds a _get_bool_config() function that actually returns a bool. We could probably also solve this by doing a function composition of the returned decorator and the decorator we create from our local function, but just having a bool seems less likely to break.

view details

Raphael Isemann

commit sha 603a9446d9bb41cc1941baa96d6dfae62f1a277d

[lldb][swift] Skip all failing tests Adds skipIf to all the tests that regressed since 2c911bceb06ed376801251bdfd992905a66f276c landed and disabled the Swift tests unintentionally.

view details

adrian-prantl

commit sha bb018f45614235c90a699fc29a26f9c52b63cafe

Merge pull request #1997 from Teemperor/MakeSwiftTestDecoratorNotAlwaysSkip [lldb][swift] Make swiftTest decorator not always skip and skipIf regressed tests temporarily

view details

push time in a day

PR merged apple/llvm-project

[lldb][swift] Make swiftTest decorator not always skip and skipIf regressed tests temporarily

_get_bool_config_skip_if_decorator returns a decorator, but the is_not_swift_compatible function is supposed to return a bool. The skipTestIfFn is supposed to create the decorator from the function we define.

As _get_bool_config_skip_if_decorator's return value is just interpreted as True, this ends up causing that we skip all Swift tests all the time.

This just adds a _get_bool_config() function that actually returns a bool. We could probably also solve this by doing a function composition of the returned decorator and the decorator we create from our local function, but just having a bool seems less likely to break.

Also re-enables and skipIf's the tests that are crashing/failing since the commit landed for now.

+25 -8

5 comments

12 changed files

Teemperor

pr closed time in a day

push eventapple/llvm-project

Adrian Prantl

commit sha f6b1a6a54bcd70baad35e594fc40fc5b24201359

Add support for more OS types to AddClangModuleCompilationOptionsForSDKType() This patch also avoids hardcoding the clang options, which makes it less likely for them to become out-of-date. rdar://problem/63791367+66927829 Differential Revision: https://reviews.llvm.org/D89428 (cherry picked from commit cf245086518efbdf96c2d86697298a8da5c97669) Conflicts: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

view details

adrian-prantl

commit sha 1322305e1787ffde943dde3a2548dfea2c539b79

Merge pull request #1983 from adrian-prantl/66927829 Add support for more OS types to AddClangModuleCompilationOptionsForS…

view details

push time in a day

PR merged apple/llvm-project

Add support for more OS types to AddClangModuleCompilationOptionsForS…

…DKType()

This patch also avoids hardcoding the clang options, which makes it less likely for them to become out-of-date.

rdar://problem/63791367+66927829

Differential Revision: https://reviews.llvm.org/D89428

(cherry picked from commit cf245086518efbdf96c2d86697298a8da5c97669)

Conflicts: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

+47 -27

2 comments

1 changed file

adrian-prantl

pr closed time in a day

create barnchadrian-prantl/llvm-project

branch : bitalign-validation

created branch time in a day

push eventapple/llvm-project

Adrian Prantl

commit sha 47f0bb63e6dadade508bf044b8aaa2937ceee889

Only print validation warnings when actually triggering an assertion. (cherry picked from commit ef4906d6fda5f14597da3dac08891fe0e73572ee)

view details

adrian-prantl

commit sha be91b157243458ecb6464550065c0659559278a3

Merge pull request #1989 from adrian-prantl/less-verbose-next Only print validation warnings when actually triggering an assertion.

view details

push time in 2 days

PR merged apple/llvm-project

Only print validation warnings when actually triggering an assertion.

(cherry picked from commit ef4906d6fda5f14597da3dac08891fe0e73572ee)

https://github.com/apple/llvm-project/pull/1988

+5 -5

0 comment

1 changed file

adrian-prantl

pr closed time in 2 days

push eventapple/llvm-project

Adrian Prantl

commit sha ef4906d6fda5f14597da3dac08891fe0e73572ee

Only print validation warnings when actually triggering an assertion.

view details

adrian-prantl

commit sha 4308eeb286fe120996fce9a614dc4f208d4ad6f1

Merge pull request #1988 from adrian-prantl/less-verbose Only print validation warnings when actually triggering an assertion.

view details

push time in 2 days

PR closed apple/llvm-project

Implement TypeSystemSwiftTypeRef::IsErrorType()

(cherry picked from commit 2bb0ce859ad3a370d728e9f8680f2b99f7b133b3)

https://github.com/apple/llvm-project/pull/1985

+35 -3

0 comment

5 changed files

adrian-prantl

pr closed time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentapple/llvm-project

Implement TypeSystemSwiftTypeRef::IsErrorType()

I also realized that I no longer need this function, so maybe I'll just close this PR...

adrian-prantl

comment created time in 4 days

pull request commentapple/llvm-project

Implement TypeSystemSwiftTypeRef::IsErrorType()

The name would suggest so, but looking at the uses of this utility, we can probably get away with just existentials conforming to Error (i.e., the way it is implemented now.)

adrian-prantl

comment created time in 4 days

PullRequestReviewEvent

PR opened apple/llvm-project

Only print validation warnings when actually triggering an assertion.

(cherry picked from commit ef4906d6fda5f14597da3dac08891fe0e73572ee)

https://github.com/apple/llvm-project/pull/1988

+5 -5

0 comment

1 changed file

pr created time in 5 days

create barnchadrian-prantl/llvm-project

branch : less-verbose-next

created branch time in 5 days

pull request commentapple/llvm-project

Only print validation warnings when actually triggering an assertion.

@swift-ci test

adrian-prantl

comment created time in 5 days

create barnchadrian-prantl/llvm-project

branch : less-verbose

created branch time in 5 days

PR opened apple/llvm-project

Implement TypeSystemSwiftTypeRef::IsErrorType()

(cherry picked from commit 2bb0ce859ad3a370d728e9f8680f2b99f7b133b3)

https://github.com/apple/llvm-project/pull/1985

+35 -3

0 comment

5 changed files

pr created time in 5 days

push eventadrian-prantl/llvm-project

Artem Belevich

commit sha c36c0fabd17a57513fa00ebd5579f307f889cb64

[VectorCombine] Avoid crossing address space boundaries. We can not bitcast pointers across different address spaces, and VectorCombine should be careful when it attempts to find the original source of the loaded data. Differential Revision: https://reviews.llvm.org/D89577

view details

git apple-llvm automerger

commit sha 914c659644d223e37d46da7080aa1e51366da738

Merge commit 'c36c0fabd17a' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha 7e7f3ed7ac4efaa638e9dbb2cf93973124b6eb26

Merge commit '914c659644d2' from apple/main into swift/next

view details

Richard Smith

commit sha 48c70c1664aa4512cb7e08352dd8eb33dde4807c

Extend memset-to-zero optimization to C++11 aggregate functional casts Aggr{...}. We previously missed these cases due to not stepping over the additional AST nodes representing their syntactic form.

view details

git apple-llvm automerger

commit sha d0fd893f3f0c979bb8c050e6552771ddcde74be6

Merge commit '48c70c1664aa' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha f8017ae8f740f7fa25e4840dde2bd7cb7c47574a

Merge commit 'd0fd893f3f0c' from apple/main into swift/next

view details

Richard Smith

commit sha 7e801ca0efa99f7cec7a2aea30513ad282030b51

Treat constant contexts as being in the default rounding mode. This addresses a regression where pretty much all C++ compilations using -frounding-math now fail, due to rounding being performed in constexpr function definitions in the standard library. This follows the "manifestly constant evaluated" approach described in https://reviews.llvm.org/D87528#2270676 -- evaluations that are required to succeed at compile time are permitted even in regions with dynamic rounding modes, as are (unfortunately) the evaluation of the initializers of local variables of const integral types. Differential Revision: https://reviews.llvm.org/D89360

view details

git apple-llvm automerger

commit sha 138038c36f468b655a05f2faefc62d0aac43f991

Merge commit '7e801ca0efa9' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha 9fabdd82a19044ecae950f6828330990ed43968f

Merge commit '138038c36f46' from apple/main into swift/next

view details

Jameson Nash

commit sha ac2def2d8d8c9aa6f96f0c869a5b988ae602385a

make the AsmPrinterHandler array public This lets external consumers customize the output, similar to how AssemblyAnnotationWriter lets the caller define callbacks when printing IR. The array of handlers already existed, this just cleans up the code so that it can be exposed publically. Differential Revision: https://reviews.llvm.org/D74158

view details

git apple-llvm automerger

commit sha de07c07e20183e5deb3a5b874d62c922bc968766

Merge commit 'ac2def2d8d8c' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha 6e6775fd58f14abf04bd704888625e582ea0a2a6

Merge commit 'de07c07e2018' from apple/main into swift/next

view details

Renato Golin

commit sha 66506eeb37b293b9be5b943d51ec087608396d8c

Fix Windows llvm-objdump tests Broken in e95f9a23fad with path issues.

view details

git apple-llvm automerger

commit sha be394d171b97b4c9ec3ec83a2de5cb6912f1d311

Merge commit '66506eeb37b2' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha ce44fcd64ec62773cfb7ff7990efac2cbad0f6e6

Merge commit 'be394d171b97' from apple/main into swift/next

view details

Adrian Prantl

commit sha d3fcddf48a849af4a17545e459383b25cfa71953

Implement TypeSystemSwiftTypeRef::IsErrorType() (cherry picked from commit 2bb0ce859ad3a370d728e9f8680f2b99f7b133b3)

view details

push time in 5 days

create barnchadrian-prantl/llvm-project

branch : iserror-next

created branch time in 5 days

pull request commentapple/llvm-project

Implement TypeSystemSwiftTypeRef::IsErrorType()

@swift-ci test

adrian-prantl

comment created time in 5 days

PR opened apple/llvm-project

Implement TypeSystemSwiftTypeRef::IsErrorType()
+217333 -13001

0 comment

2650 changed files

pr created time in 5 days

create barnchadrian-prantl/llvm-project

branch : is_error

created branch time in 5 days

PR opened apple/llvm-project

Add support for more OS types to AddClangModuleCompilationOptionsForS…

…DKType()

This patch also avoids hardcoding the clang options, which makes it less likely for them to become out-of-date.

rdar://problem/63791367+66927829

Differential Revision: https://reviews.llvm.org/D89428

(cherry picked from commit cf245086518efbdf96c2d86697298a8da5c97669)

Conflicts: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

+47 -27

0 comment

1 changed file

pr created time in 5 days

create barnchadrian-prantl/llvm-project

branch : 66927829

created branch time in 5 days

push eventllvm/llvm-project

Adrian Prantl

commit sha cf245086518efbdf96c2d86697298a8da5c97669

Add support for more OS types to AddClangModuleCompilationOptionsForSDKType() This patch also avoids hardcoding the clang options, which makes it less likely for them to become out-of-date. rdar://problem/63791367+66927829 Differential Revision: https://reviews.llvm.org/D89428

view details

push time in 5 days

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 class SwiftPersistentExpressionState : public PersistentExpressionState {    // This just adds this module to the list of hand-loaded modules, it doesn't   // actually load it.-  void AddHandLoadedModule(ConstString module_name) {-    m_hand_loaded_modules.insert(module_name);+  void AddHandLoadedModule(+      ConstString module_name,+      swift::AttributedImport<swift::ImportedModule> attributed_import) {+    // TODO: Refactor to m_hand_loaded_modules.insert_or_assign when C++17 is+    // available.+    if (m_hand_loaded_modules.find(module_name) != m_hand_loaded_modules.end())+      m_hand_loaded_modules.erase(module_name);

Okay we may need the function because it's called from outside the class, but the implementation could be a lot shorter :-)

medismailben

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 class SwiftPersistentExpressionState : public PersistentExpressionState {    // This just adds this module to the list of hand-loaded modules, it doesn't   // actually load it.-  void AddHandLoadedModule(ConstString module_name) {-    m_hand_loaded_modules.insert(module_name);+  void AddHandLoadedModule(+      ConstString module_name,+      swift::AttributedImport<swift::ImportedModule> attributed_import) {+    // TODO: Refactor to m_hand_loaded_modules.insert_or_assign when C++17 is+    // available.+    if (m_hand_loaded_modules.find(module_name) != m_hand_loaded_modules.end())+      m_hand_loaded_modules.erase(module_name);

Can you add a comment here why we erase the old entry? Also, do we need this function at all? If m_hand_loaded_modules were a DenseMap, wouldn't it be the same to write m_hand_loaded_modules[module_name] = ...?

medismailben

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 namespace lldb_private { /// 0-based counter for naming result variables. //---------------------------------------------------------------------- class SwiftPersistentExpressionState : public PersistentExpressionState {-  typedef std::set<lldb_private::ConstString> HandLoadedModuleSet;++  typedef std::map<ConstString, swift::AttributedImport<swift::ImportedModule>>+      HandLoadedModuleSet;

Do we need the sortedness of std::map or could we use an llvm::DenseMap or perhaps even an llvm::StringMap here?

medismailben

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 static llvm::Expected<ParsedExpression> ParseAndImport(    swift::ImplicitImportInfo importInfo;   importInfo.StdlibKind = swift::ImplicitStdlibKind::Stdlib;-  for (auto *module : additional_imports)-    importInfo.AdditionalImports.emplace_back(swift::ImportedModule(module),-                                              swift::ImportOptions());+  for (auto &attributed_import : additional_imports) {+    importInfo.AdditionalImports.emplace_back(attributed_import);+  }

Nit: LLVM style doesn't put {} around single statements.

medismailben

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 bool SwiftUserExpression::Parse(DiagnosticManager &diagnostic_manager,                                  "couldn't start parsing (no target)");     return false;   }++  StackFrame *frame = exe_ctx.GetFramePtr();+  if (!frame) {+    LLDB_LOG(log, "  [SUE::Parse] Null stack frame");+    return false;+  }++  // Make sure the target's SwiftASTContext has been setup before doing any+  // Swift name lookups.+  llvm::Optional<SwiftASTContextReader> maybe_swift_ast_ctx =+      target->GetScratchSwiftASTContext(err, *frame);+  if (!maybe_swift_ast_ctx) {+    LLDB_LOG(log, "  [SUE::Parse] NULL Swift AST Context");+    return false;+  }++  SwiftASTContext *swift_ast_ctx = maybe_swift_ast_ctx->get();+   if (auto *persistent_state = GetPersistentState(target, exe_ctx)) {-    persistent_state->AddHandLoadedModule(ConstString("Swift"));++    ConstString module_name("Swift");

Sure, that would make sense!

medismailben

comment created time in 6 days

PullRequestReviewEvent

pull request commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

This LGTM with mine an Jonas' comments addressed. Please don't forget to cherry-pick to swift/next!

medismailben

comment created time in 6 days

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 bool SwiftASTContext::GetImplicitImports(       sc.target_sp->GetSwiftPersistentExpressionState(exe_scope);    // Get the hand-loaded modules from the SwiftPersistentExpressionState.-  for (ConstString name : persistent_expression_state->GetHandLoadedModules()) {-    SourceModule module_info;-    module_info.path.push_back(name);-    auto *module = LoadOneModule(module_info, swift_ast_context, stack_frame_wp,-                                 error);-    if (!module)-      return false;+  for (auto module_pair : persistent_expression_state->GetHandLoadedModules()) {+    if (!module_pair.second.module.importedModule) {

if (module_pair.second.module.importedModule) { modules.push_back(swift::ImportedModule(module)); continue; } ... // Comment that explains what the other path does...

medismailben

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventapple/llvm-project

Adrian Prantl

commit sha 00ab9634e5f7caba79f9f39934fc9b67c70736b3

Sort the cases in GetTypeClass (NFC) (cherry picked from commit 63182b1454ea518bf0eab26fbe661d83eded4709) (cherry picked from commit bfe698971c2fc2e04151b3bfa494ccdb1a3ad4af)

view details

adrian-prantl

commit sha 2f529f926af09d72991782a821e9aad29cef11d9

Merge pull request #1969 from adrian-prantl/66928085-next Sort the cases in GetTypeClass (NFC)

view details

push time in 6 days

PR merged apple/llvm-project

Sort the cases in GetTypeClass (NFC)

(cherry picked from commit 63182b1454ea518bf0eab26fbe661d83eded4709) (cherry picked from commit bfe698971c2fc2e04151b3bfa494ccdb1a3ad4af) https://github.com/apple/llvm-project/pull/1968

+14 -38

0 comment

1 changed file

adrian-prantl

pr closed time in 6 days

push eventapple/llvm-project

Adrian Prantl

commit sha bfe698971c2fc2e04151b3bfa494ccdb1a3ad4af

Sort the cases in GetTypeClass (NFC) (cherry picked from commit 63182b1454ea518bf0eab26fbe661d83eded4709)

view details

adrian-prantl

commit sha 2f79cf79fa7f5a3f10058a74ac86240d98967120

Merge pull request #1968 from adrian-prantl/66928085 Sort the cases in GetTypeClass (NFC)

view details

push time in 6 days

PR merged apple/llvm-project

Sort the cases in GetTypeClass (NFC)

(cherry picked from commit 63182b1454ea518bf0eab26fbe661d83eded4709)

+14 -38

1 comment

1 changed file

adrian-prantl

pr closed time in 6 days

push eventapple/llvm-project

Adrian Prantl

commit sha 7494f23cbfadce4b2151a2404918fea5c9f67b9d

Refactor LookupClangType to take a module holder rather than a module. This allows look up types in an entire expression context in addition to looking types up in just one lldb::Module. (cherry picked from commit e161d5c2891525d19129a36fb661beac4fcbd669)

view details

Adrian Prantl

commit sha 23961562d6c31ba650c8a87e9a20a89ce6f593ab

Use the dynamic type of self in the expression evaluator. This allows LLDB to resolve generic self types even if no type parameters are present (for example, because they were optimized out) because class objects and other entities carry all their dynamic type information in the *object*. rdar://problem/69020595 (cherry picked from commit eaceb46661c6833f11fa98659223652f6d549f4a)

view details

Adrian Prantl

commit sha e2ed022a635af03d561d37dbf33c96ea06984c08

Appease older compilers (cherry picked from commit 4863244efddfaf49822880371f88e57cf5374a24)

view details

adrian-prantl

commit sha 7892b91b560a481c3d41d579a6f6648d42a18335

Merge pull request #1967 from adrian-prantl/69020595-next Use the dynamic type of self in the expression evaluator.

view details

push time in 7 days

PR merged apple/llvm-project

Use the dynamic type of self in the expression evaluator.

https://github.com/apple/llvm-project/pull/1966

+232 -97

0 comment

11 changed files

adrian-prantl

pr closed time in 7 days

push eventapple/llvm-project

Adrian Prantl

commit sha e161d5c2891525d19129a36fb661beac4fcbd669

Refactor LookupClangType to take a module holder rather than a module. This allows look up types in an entire expression context in addition to looking types up in just one lldb::Module.

view details

Adrian Prantl

commit sha eaceb46661c6833f11fa98659223652f6d549f4a

Use the dynamic type of self in the expression evaluator. This allows LLDB to resolve generic self types even if no type parameters are present (for example, because they were optimized out) because class objects and other entities carry all their dynamic type information in the *object*. rdar://problem/69020595

view details

Adrian Prantl

commit sha 4863244efddfaf49822880371f88e57cf5374a24

Appease older compilers

view details

adrian-prantl

commit sha 2ea629d94ab01c30bd899427bb96820ee95bb153

Merge pull request #1966 from adrian-prantl/69020595 Use the dynamic type of self in the expression evaluator.

view details

push time in 7 days

PR merged apple/llvm-project

Use the dynamic type of self in the expression evaluator.

This allows LLDB to resolve generic self types even if no type parameters are present (for example, because they were optimized out) because class objects and other entities carry all their dynamic type information in the object.

rdar://problem/69020595

+235 -97

2 comments

13 changed files

adrian-prantl

pr closed time in 7 days

more