profile
viewpoint
Adam Conrad acconrad Anon Consulting Boston, MA https://www.conradadam.com UX Engineer. Consultant. AR/VR, Performance, Accessibility

issue openedRobinBuschmann/sequelize-typescript

Next version missing interfaces

Versions

  • sequelize: 5.15.1
  • sequelize-typescript: next
  • typescript: 3.5.3

I'm submitting a ... [x] bug report [ ] feature request

Actual behavior: Code does not compile:

import { IIncludeOptions } from 'sequelize-typescript';
// '"sequelize-typescript/dist"' has no exported member 'IIncludeOptions'

This is because the interfaces are not being properly exported to the node_modules/sequelize-typescript/dist folder:

Screen Shot 2019-08-20 at 5 05 09 PM

Expected behavior: The code should compile and I should have access to IIncludeOptions or any interface

Steps to reproduce:

  1. npm install sequelize-typescript@next
  2. Add the import listed above into your code

created time in 4 days

issue commentRobinBuschmann/sequelize-typescript

Sequelize v5.13.0 not supported

@RobinBuschmann I actually am having trouble getting this to work. I pulled the latest from sequelize-typescript@next and the thing is I can see in the code that interfaces/* should be exported via index.ts but I'm not seeing it show up when I actually install the folder into my node_modules

Screen Shot 2019-08-20 at 5 05 09 PM

Is it possible that not all folders (such as interfaces) are being properly exposed when you distribute the plugin?

justinlottes

comment created time in 4 days

issue commentdenoland/deno

Feature Request: requestAnimationFrame

Diving into this late but I'd agree with @kitsonk that deno serves as a server-side runtime; rAF is a very client-focused implementation detail. We do implement a good deal of the DOM spec but rAF is not part of the official spec so I can't see a practical use case for it here

Fenzland

comment created time in 25 days

issue commentdenoland/deno

help wanted: Web APIs' implementation

can confirm i added the last of the Web API implementations as @kt3k pointed out, this should be all set!

kyranet

comment created time in a month

issue commentdenoland/deno

Major features necessary for 1.0

@ry I'll take this:

When you visit a deno.land script url

Where would the CSS live for that? Where is the website server code within deno?

ry

comment created time in 2 months

delete branch acconrad/deno

delete branch : acc-event-target-impl

delete time in 3 months

pull request commentdenoland/deno

Web API: EventTarget implementation

alright @ry finally everything is passing - let me know when you want to get this in

acconrad

comment created time in 3 months

push eventacconrad/deno

Adam Conrad

commit sha 70d1df80c3bcc9714dd0b2633d9bb3c50c9d569a

update build gn

view details

push time in 3 months

push eventacconrad/deno

Adam Conrad

commit sha a9b9fac460d361fef18cc45792d5423988dc0c6b

make writable

view details

push time in 3 months

push eventacconrad/deno

Adam Conrad

commit sha 753bf99dda5a2c92eaf3cefc295b252c87e7de57

update properties

view details

push time in 3 months

push eventacconrad/deno

Adam Conrad

commit sha 14f850b11093ba3c9bdedaf8bc42afb52b5f18e3

fix EventTarget tests

view details

push time in 3 months

more