profile
viewpoint
Adam Conrad acconrad Anon Consulting Boston, MA https://www.conradadam.com UX Engineer. Consultant. AR/VR, Performance, Accessibility

issue commentdenoland/deno

Major features necessary for 1.0

@ry I'll take this:

When you visit a deno.land script url

Where would the CSS live for that? Where is the website server code within deno?

ry

comment created time in 11 days

delete branch acconrad/deno

delete branch : acc-event-target-impl

delete time in a month

pull request commentdenoland/deno

Web API: EventTarget implementation

alright @ry finally everything is passing - let me know when you want to get this in

acconrad

comment created time in a month

push eventacconrad/deno

Adam Conrad

commit sha 70d1df80c3bcc9714dd0b2633d9bb3c50c9d569a

update build gn

view details

push time in a month

push eventacconrad/deno

Adam Conrad

commit sha a9b9fac460d361fef18cc45792d5423988dc0c6b

make writable

view details

push time in a month

push eventacconrad/deno

Adam Conrad

commit sha 753bf99dda5a2c92eaf3cefc295b252c87e7de57

update properties

view details

push time in a month

push eventacconrad/deno

Adam Conrad

commit sha 14f850b11093ba3c9bdedaf8bc42afb52b5f18e3

fix EventTarget tests

view details

push time in a month

pull request commentdenoland/deno

Web API: EventTarget implementation

Alright @ry I was able to reproduce this locally now that I've upgraded rust, here's the full stack trace from the error we're seeing on CI:

failures:

---- js_errors::tests::js_error_apply_source_map_2 stdout ----
thread 'js_errors::tests::js_error_apply_source_map_2' panicked at 'assertion failed: actual.frames[0].script_name.ends_with("js/util.ts")', ../../cli/js_errors.rs:398:5
stack backtrace:
   0:        0x103b56b13 - std::sys::unix::backtrace::tracing::imp::unwind_backtrace::h2e1a54aafa1209de
   1:        0x103b4f752 - std::sys_common::backtrace::_print::h670ed14fc4950210
   2:        0x103b530b6 - std::panicking::default_hook::{{closure}}::h5d2e6205d52978de
   3:        0x103b52c1e - std::panicking::default_hook::h8e6307de267f5f56
   4:        0x103b5382f - std::panicking::rust_panic_with_hook::h9bb34120d55c0ca9
   5:        0x1058f11f7 - std::panicking::begin_panic::h98b762b2d3e5c3f2
   6:        0x1061b421c - cli_test_bin::js_errors::tests::js_error_apply_source_map_2::h8e9815dcc728f727
   7:        0x1061b3b20 - cli_test_bin::js_errors::tests::js_error_apply_source_map_2::{{closure}}::h48d4326d76b7e769
   8:        0x105fad280 - core::ops::function::FnOnce::call_once::h0fa00a676e0297cc
   9:        0x103af8241 - <F as alloc::boxed::FnBox<A>>::call_box::h57df398114e3caca
  10:        0x103b6351e - __rust_maybe_catch_panic
  11:        0x103b14ba6 - test::run_test::run_test_inner::{{closure}}::h462d8984151dee76
  12:        0x103af05f4 - std::sys_common::backtrace::__rust_begin_short_backtrace::h3ba2b968d1f10d0e
  13:        0x103af0ca4 - std::panicking::try::do_call::h32a52f1f76578234
  14:        0x103b6351e - __rust_maybe_catch_panic
  15:        0x103af83e4 - <F as alloc::boxed::FnBox<A>>::call_box::hf0fc41817deacef6
  16:        0x103b6232b - std::sys::unix::thread::Thread::new::thread_start::hf63bd47663b691b4
  17:     0x7fff6213d2ea - _pthread_body
  18:     0x7fff62140248 - _pthread_start


failures:
    js_errors::tests::js_error_apply_source_map_2

test result: FAILED. 94 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
acconrad

comment created time in a month

pull request commentdenoland/deno

Web API: EventTarget implementation

@ry yeah that issue I can't seem to repro (the JS one)

acconrad

comment created time in a month

pull request commentdenoland/deno

Web API: EventTarget implementation

Not sure if my builds are failing because of this:

[1/38] ACTION //core:deno_rustc(//build/toolchain/mac:clang_x64)
FAILED: rust_crates/libdeno.rlib
python ../../build_extra/rust/run.py /Users/me/Code/deno/prebuilt/mac/sccache rustc ../../core/lib.rs --crate-name=deno --crate-type=rlib --emit=link,dep-info --edition=2018 --out-dir=rust_crates -Cextra-filename= -Cmetadata=\"_rustc\ 1.31.1\ \(b6c32da9b\ 2018-12-18\)\" -L dependency=rust_crates --color=always -g -Dwarnings --extern futures=rust_crates/libfutures.rlib --extern libc=rust_crates/liblibc.rlib --extern serde_json=rust_crates/libserde_json.rlib --extern log=rust_crates/liblog.rlib
error[E0658]: imports can only refer to extern crate names passed with `--extern` on stable channel (see issue #53130)
   --> ../../core/libdeno.rs:143:9
    |
90  | / pub struct PinnedBufRaw {
91  | |   data_ptr: *mut u8,
92  | |   data_len: usize,
93  | |   pin: *mut c_void,
94  | | }
    | |_- not an extern crate passed with `--extern`
...
143 |   pub use PinnedBufRaw as deno_pinned_buf;
    |           ^^^^^^^^^^^^
    |
note: this import refers to the struct defined here
   --> ../../core/libdeno.rs:90:1
    |
90  | / pub struct PinnedBufRaw {
91  | |   data_ptr: *mut u8,
92  | |   data_len: usize,
93  | |   pin: *mut c_void,
94  | | }
    | |_^

error: aborting due to previous error
acconrad

comment created time in a month

push eventacconrad/deno

Adam Conrad

commit sha 08a5ccc4be04f2d4d8eb4ccbc898c0e29682bb3e

last of linter errors

view details

push time in a month

push eventacconrad/deno

Adam Conrad

commit sha dcd27616aae3b222f9a9acfb9137dd837b5cee4a

fix more linter errors

view details

push time in a month

push eventacconrad/deno

Adam Conrad

commit sha 1335cdd2aa1274524c9fa991958a60f26f2c61fa

fix linter errors

view details

push time in a month

PR opened denoland/deno

Web API: EventTarget implementation

This PR implements the EventTarget Web API spec.

One big decision that @ry and co will need to make is around implementing the Node standard as a tree. The event target implementation is a beast but it makes a lot of assumptions that there is this base Node object which, according to this implementation of JS DOM encompasses way more than I believe #1047 bargained for.

So in effort to get a more robust implementation in, I commented some things out and left some TODOs in place but there's a lot at stake here that needs to be considered.

+710 -40

0 comment

3 changed files

pr created time in a month

create barnchacconrad/deno

branch : acc-event-target-impl

created branch time in a month

fork acconrad/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in a month

PR closed denoland/deno

Web API: EventTarget

This PR implements the EventTarget Web API spec.

One big decision that @ry and co will need to make is around implementing the Node standard as a tree. The event target implementation is a beast but it makes a lot of assumptions that there is this base Node object which, according to this implementation of JS DOM encompasses way more than I believe #1047 bargained for.

So in effort to get a more robust implementation in, I commented some things out and left some TODOs in place but there's a lot at stake here that needs to be considered.

+713 -43

1 comment

6 changed files

acconrad

pr closed time in a month

push eventacconrad/deno

Adam Conrad

commit sha e32b9066597195a861d6f032821ce43c1a382484

format impl

view details

push time in a month

push eventacconrad/deno

Ryan Dahl

commit sha 6744bb8d750b9ab11d2ec9448334732b98feb58a

Call ninja directly from build.rs (#2020)

view details

Ryan Dahl

commit sha e9910d8ae510fcef54ae2f0a83199daa81c15df1

Rename crate deno_core to deno (#2022)

view details

Ryan Dahl

commit sha 3ba4c3c2b08f9827af67b208f276e95082b625bd

Remove deno_core_http_bench from core/Cargo.toml (#2023) So we don't have to have an optional tokio dependency. We build deno_core_http_bench using GN anyway.

view details

Bert Belder

commit sha 97265895baaf7e90180f10f7ef741e9bbf1dcfd0

Publish rust crate on crates.io (#2024)

view details

Bert Belder

commit sha ff1c80d6d896a3c1cb45d767a6c667ce99eb000b

third_party: add rust crate 'clap'

view details

迷渡

commit sha c855d0edd2ef5098b806ac6368eb7b0a85d0d0c9

Update `deno -h` output in manual (#2030)

view details

Kitson Kelly

commit sha ada5ffa610d2b5400b612917b35d91b98bee2309

Upgrade to TypeScript 3.4.1 (#2027)

view details

迷渡

commit sha 659acadf77fdbeef8579a37839a464feb408437a

Improve new TextDecoder().toString() (#2032)

view details

andy finch

commit sha b0a23beb8fae964be3cdd8c23c38af66257d34c7

Add web worker JS API (#1993) * Refactored the way worker polling is scheduled and errors are handled. * Share the worker future as a Shared

view details

Vincent LE GOFF

commit sha e44084c90dec8cafbc66d4e485ff24479c56ec2e

add scoop in the install (#2035)

view details

Kevin (Kun) "Kassimo" Qian

commit sha 534b8d30219a605c82bac706bc5429d44ae53c32

Follow redirect location as new referrers for nested module imports (#2031) Fixes #1742 Fixes #2021

view details

JaePil Jung

commit sha efbe44eb33bb8d19a68bc1a0889c4f2780894184

Fix missing return type (#2038)

view details

Bert Belder

commit sha b735155712b944004ac87ba5d3be7a9baccbf53e

Clippy fixes

view details

Bert Belder

commit sha 5f1e42f8ac3a051e83908dcdd0c1f9735b32a79a

cli: refactor compile_sync() for readability

view details

Ryan Dahl

commit sha 2b0f553e2e1b83ed8ff605f2ea25e2c31bb4c889

Add deno_core::RecursiveLoad for async module loading (#2034)

view details

Bert Belder

commit sha 917e68f30f25c22a87d0f8b8a2f39d27bc8ca906

Refactor deno_core::RecursiveLoad to be more idiomatic (#2034)

view details

迷渡

commit sha 6463a75b44a4f7aad6ffe04d0c5ae073fb5ca137

web-compatibility console (#2042)

view details

迷渡

commit sha 5f97c041d9115c480e3b9f428cfee27b109b3883

fix console.log when error has been caught (#2041)

view details

迷渡

commit sha bb617d24781d7c1e67e8e825cc07faba9a5df075

fix toString for some web objects (#2040)

view details

迷渡

commit sha 8c8576619852ee8b8095ca735f6d517a7e707e79

fix JSDoc (#2043)

view details

push time in a month

push eventacconrad/deno

Adam Conrad

commit sha 33cf58e297069a4953be759dab311ea15d254983

fix event target impl

view details

push time in a month

issue closedcode-corps/stripity_stripe

Stripe.SubscriptionItem.Usage missing

I've got the latest (2.2.2) version and when running mix deps.get my deps/stripity_stripe plugin is missing the usage.ex file:

Screen Shot 2019-04-21 at 10 57 52 PM

It seems to be the only file missing. Might the version need to be bumped to get this to appear correctly?

closed time in a month

acconrad

Pull request review commentBlakeWilliams/Elixir-Slack

[BREAKING CHANGE] Replace rtm.start with rtm.connect

 def application do end  def deps do-  [{:slack, "~> 0.18.0"}]+  [{:slack, "~> 1.0.0"}] end ``` +## Upgrading from 0.x to 1.0++The newest version of the Slack client introduces breaking changes with regards to starting and connecting to the Real Time Messaging API. `rtm.start` is now [deprecated](https://api.slack.com/methods/rtm.start) and has since been replaced with [`rtm.connect`](https://api.slack.com/methods/rtm.connect). **This has removed the list of  `bots`, `channels`, `groups`, `users`, and `ims` that are normally returned from `rtm.start`**. Additionally, these lists are now rate-limited. In order to achieve relative parity to the old way of doing things, you'll need to make one change in your code:++### Make additional calls to the Slack API fo grab bots, channels, groups, users, and IMs++Wherever you grab the passed in `slack` state, add in additional calls to populate these lists:++```elixir+slack

oh good point, I would recommend purging them since those maps are no longer needed. Will save connections and also improve performance.

acconrad

comment created time in 2 months

pull request commentBlakeWilliams/Elixir-Slack

[BREAKING CHANGE] Replace rtm.start with rtm.connect

@BlakeWilliams alright conflicts resolved - this should be good to go!

acconrad

comment created time in 2 months

push eventacconrad/Elixir-Slack

Adam Conrad

commit sha 164655f2acfe461f786547a8df206c121865963b

Revert rtm.connect => rtm.start PR

view details

Adam Conrad

commit sha b62170c1d5186f5efdd6d543bac73c7062e112d2

Merge branch 'master' into acc-revert-connect

view details

Adam Conrad

commit sha 850de90bb7d4174696d718bf34445ca94723452c

Add in deprecation docs message

view details

Adam Conrad

commit sha 5338f16739ee44989f8edddcf19db1c915f39d85

Merge branch 'acc-revert-connect' of github.com:acconrad/Elixir-Slack into acc-revert-connect

view details

Blake Williams

commit sha 522c01787f85ab6596836ac5454fbe334b716ab6

Merge pull request #190 from acconrad/acc-revert-connect Revert rtm.connect => rtm.start PR

view details

Adam Conrad

commit sha edd81cadf7e3b9e34721441c409fa95d10b7944b

fix conflicts

view details

push time in 2 months

issue commentcode-corps/stripity_stripe

Stripe.SubscriptionItem.Usage missing

@maartenvanvliet would it be worth a patch bump to 2.2.3 just in case?

acconrad

comment created time in 2 months

issue openedcode-corps/stripity_stripe

Stripe.SubscriptionItem.Usage missing

I've got the latest (2.2.2) version and when running mix deps.get my deps/stripity_stripe folder is missing the usage.ex file:

Screen Shot 2019-04-21 at 10 57 52 PM

It seems to be the only file missing. Might the version need to be bumped to get this to appear correctly?

created time in 2 months

pull request commentdenoland/deno

Upgrade Typescript to 3.4.3

Is this worth it if typescript just upgraded to 3.4.4?

ry

comment created time in 2 months

pull request commentBlakeWilliams/Elixir-Slack

[BREAKING CHANGE] Replace rtm.start with rtm.connect

#190 just went in so I'll fix the conflicts tonight and this can be RTM

acconrad

comment created time in 2 months

delete branch acconrad/Elixir-Slack

delete branch : acc-revert-connect

delete time in 2 months

push eventacconrad/Elixir-Slack

Adam Conrad

commit sha 850de90bb7d4174696d718bf34445ca94723452c

Add in deprecation docs message

view details

Adam Conrad

commit sha 5338f16739ee44989f8edddcf19db1c915f39d85

Merge branch 'acc-revert-connect' of github.com:acconrad/Elixir-Slack into acc-revert-connect

view details

push time in 2 months

push eventacconrad/Elixir-Slack

Adam Conrad

commit sha 6435955cd5a8b2cafad13a7ffeda4edb1285e374

Bump to major version to properly remove rtm.start

view details

Adam Conrad

commit sha 1c2d34729252b6360bb92b90c2b666f13dd30b56

Merge branch 'acc-fix-rtm-connect' of github.com:acconrad/Elixir-Slack into acc-fix-rtm-connect

view details

push time in 2 months

pull request commentBlakeWilliams/Elixir-Slack

[BREAKING CHANGE] Replace rtm.start with rtm.connect

@Slotos @BlakeWilliams @chulkilee

OKAY!

This should go in after #190 - first, we add in #190 to fix everyone's problems with rtm.connect. Then we introduce this fix to properly deprecate the Slack API while also providing a deprecation guide on how to upgrade and maintain current functionality (if you so desire all of those lists).

All tests are passing, there is no longer a dependency on the mock library since those tests are no longer necessary, and the code is just simpler overall.

Let me know what you think!

acconrad

comment created time in 2 months

push eventacconrad/Elixir-Slack

Anil Kulkarni

commit sha 8cb172be257b0fbd0b4e996720a18becb5541809

Add missing replies json

view details

Anil Kulkarni

commit sha 8e9ad855e68d32327f5522510f7b8332d6296c57

Add postEphemeral

view details

Anil Kulkarni

commit sha 5f59ce7a63cd2434f6b164f5e21e2c04c3474424

Add im.replies

view details

Vince Foley

commit sha 12fc7b452553fc0725b727da041326cfad701795

Update group topic

view details

Vince Foley

commit sha 2cda14aa1031bbd6e7d86910d41d60505b0ad74a

Use put_in, test

view details

Vince Foley

commit sha a1d87eadaf427d3f88fe45617d4dca17e7dc4153

channel_topic too

view details

Jason Axelson

commit sha acd6d51ac7594747ff5f1efc24ac27d42f76dec9

Create separate token generation instructions doc

view details

Jason Axelson

commit sha 970fe4c4db0fe2d73a008f1a4b96226c235f36ac

Fix links

view details

Jason Axelson

commit sha dc074dafaf4bc190c78f9f3f4f8808251b70a7bc

Crop image

view details

Ian Fosbery

commit sha 5f277d1752d85f7bd3efbdb5731b43257c960ec3

Add users.lookupByEmail method to API

view details

Jim Kirkbride

commit sha f02d5074a668c9c4f5763e625b19c07d8a221429

Bumping the version reference in the README to the latest release.

view details

Ian Fosbery

commit sha 41ac5cbe485f817116c821d34fd7aab9c8a9cd59

Add error msg for `missing_scope` on lookup_by_email request

view details

Jim Kirkbride

commit sha f4ad603b1d6fda98bb506a6cf98bf45d9e38adc6

Updating the gitignore with intellij project files.

view details

Jim Kirkbride

commit sha 0f4c7b5e42be531795184b20c7c4c8ff44d5af3e

Correcting a typo in the README.

view details

Jim Kirkbride

commit sha 7890b9ca0d753d8392062fe9353757b245207033

Adding support for looking up user names for user_ids that start with 'W'.

view details

Jim Kirkbride

commit sha 834fe1f347b0f1e0075e50ac4832a77596600420

Sending a message by user_id does not perform a username lookup now.

view details

Jim Kirkbride

commit sha c4fcf472732b6559a04800162773bd3db221e90c

Renaming find_user_by_name to find_username_by_id to be more accurate.

view details

Blake Williams

commit sha 01fbdb75633fa5e3b85808b76a4d33cb09164ff1

Merge pull request #185 from fozcodes/master Add Users.lookup_by_email to Web API

view details

Jim Kirkbride

commit sha 590cf06c086d7921e74fa3f598418831c0cf6680

Adding logging statements with the @USER_NAME warning. Fixed a typo.

view details

Blake Williams

commit sha c50a3ccdded783340c500647a15185f6c40d89e1

Merge pull request #183 from axelson/update-token-generation-instructions Create separate token generation instructions doc

view details

push time in 2 months

push eventacconrad/Elixir-Slack

Adam Conrad

commit sha 933bca072b8e34a5e6f323d5b91cfe441ebeb1e1

Bump to major version to properly remove rtm.start

view details

push time in 2 months

PullRequestEvent

Pull request review commentBlakeWilliams/Elixir-Slack

Revert rtm.connect => rtm.start PR

 defmodule Slack.Mixfile do   def project do     [       app: :slack,-      version: "0.18.0",+      version: "0.19.0",

@Slotos this version will be what everyone can target to fix their apps

acconrad

comment created time in 2 months

push eventacconrad/Elixir-Slack

Anil Kulkarni

commit sha 8cb172be257b0fbd0b4e996720a18becb5541809

Add missing replies json

view details

Anil Kulkarni

commit sha 8e9ad855e68d32327f5522510f7b8332d6296c57

Add postEphemeral

view details

Anil Kulkarni

commit sha 5f59ce7a63cd2434f6b164f5e21e2c04c3474424

Add im.replies

view details

Vince Foley

commit sha 12fc7b452553fc0725b727da041326cfad701795

Update group topic

view details

Vince Foley

commit sha 2cda14aa1031bbd6e7d86910d41d60505b0ad74a

Use put_in, test

view details

Vince Foley

commit sha a1d87eadaf427d3f88fe45617d4dca17e7dc4153

channel_topic too

view details

Jason Axelson

commit sha acd6d51ac7594747ff5f1efc24ac27d42f76dec9

Create separate token generation instructions doc

view details

Jason Axelson

commit sha 970fe4c4db0fe2d73a008f1a4b96226c235f36ac

Fix links

view details

Jason Axelson

commit sha dc074dafaf4bc190c78f9f3f4f8808251b70a7bc

Crop image

view details

Ian Fosbery

commit sha 5f277d1752d85f7bd3efbdb5731b43257c960ec3

Add users.lookupByEmail method to API

view details

Jim Kirkbride

commit sha f02d5074a668c9c4f5763e625b19c07d8a221429

Bumping the version reference in the README to the latest release.

view details

Ian Fosbery

commit sha 41ac5cbe485f817116c821d34fd7aab9c8a9cd59

Add error msg for `missing_scope` on lookup_by_email request

view details

Jim Kirkbride

commit sha f4ad603b1d6fda98bb506a6cf98bf45d9e38adc6

Updating the gitignore with intellij project files.

view details

Jim Kirkbride

commit sha 0f4c7b5e42be531795184b20c7c4c8ff44d5af3e

Correcting a typo in the README.

view details

Jim Kirkbride

commit sha 7890b9ca0d753d8392062fe9353757b245207033

Adding support for looking up user names for user_ids that start with 'W'.

view details

Jim Kirkbride

commit sha 834fe1f347b0f1e0075e50ac4832a77596600420

Sending a message by user_id does not perform a username lookup now.

view details

Jim Kirkbride

commit sha c4fcf472732b6559a04800162773bd3db221e90c

Renaming find_user_by_name to find_username_by_id to be more accurate.

view details

Blake Williams

commit sha 01fbdb75633fa5e3b85808b76a4d33cb09164ff1

Merge pull request #185 from fozcodes/master Add Users.lookup_by_email to Web API

view details

Jim Kirkbride

commit sha 590cf06c086d7921e74fa3f598418831c0cf6680

Adding logging statements with the @USER_NAME warning. Fixed a typo.

view details

Blake Williams

commit sha c50a3ccdded783340c500647a15185f6c40d89e1

Merge pull request #183 from axelson/update-token-generation-instructions Create separate token generation instructions doc

view details

push time in 2 months

PR opened BlakeWilliams/Elixir-Slack

Revert rtm.connect => rtm.start PR

Revert to get everyone's apps working again. Keep this locked to a minor version bump and then we'll upgrade to use rtm.connect in a major version bump with a deprecation guide.

+34 -27

0 comment

7 changed files

pr created time in 2 months

push eventacconrad/Elixir-Slack

Adam Conrad

commit sha 164655f2acfe461f786547a8df206c121865963b

Revert rtm.connect => rtm.start PR

view details

push time in 2 months

create barnchacconrad/Elixir-Slack

branch : acc-revert-connect

created branch time in 2 months

PR closed BlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

Fixes #181 - tests are broken though because there is no test for mocked Web API endpoints. @BlakeWilliams would be helpful to get some guidance on this

+93 -38

10 comments

6 changed files

acconrad

pr closed time in 2 months

pull request commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

If possible, please revert rtm.start commit and release a minor version bump

@Slotos after reading all of these comments I'm just going to close this PR and re-open it with a major version bump since it has breaking changes. I don't want to be the one who is releasing the actual V1 of this but I think it's necessary to expose the gravity of the upgrade required. Revert PR incoming.

acconrad

comment created time in 2 months

Pull request review commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

 defmodule Slack.Bot do       token: token,       me: rtm.self,       team: rtm.team,-      bots: rtm_list_to_map(rtm.bots),-      channels: rtm_list_to_map(rtm.channels),-      groups: rtm_list_to_map(rtm.groups),-      users: rtm_list_to_map(rtm.users),-      ims: rtm_list_to_map(rtm.ims)+      bots: bot_to_map(Bots.info(%{token: token}) |> Map.get("bot")),

Is this a permissions problem because Bots.info requires you have the bot permission enabled for your app?

acconrad

comment created time in 2 months

Pull request review commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

 defmodule Slack.Bot do       token: token,       me: rtm.self,       team: rtm.team,-      bots: rtm_list_to_map(rtm.bots),-      channels: rtm_list_to_map(rtm.channels),-      groups: rtm_list_to_map(rtm.groups),-      users: rtm_list_to_map(rtm.users),-      ims: rtm_list_to_map(rtm.ims)+      bots: bot_to_map(Bots.info(%{token: token}) |> Map.get("bot")),+      channels: rtm_list_to_map(Channels.list(%{token: token}) |> Map.get("channels")),+      groups: rtm_list_to_map(Groups.list(%{token: token}) |> Map.get("groups")),+      users: rtm_list_to_map(Users.list(%{token: token}) |> Map.get("members")),+      ims: rtm_list_to_map(Im.list(%{token: token}) |> Map.get("ims"))

All these lists are likely partial responses.

So if it's at parity with rtm.start then are we losing any more functionality than we already had?

acconrad

comment created time in 2 months

Pull request review commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

 defmodule Slack.Bot do    def websocket_handle(_, _conn, state), do: {:ok, state} +  defp bot_to_map(bot) do+    %{"#{bot.id}" => bot}

The tests pass for my original code and fail for your suggestion. Using what I think you want to use, Map.get(bot, "id") will result in nil => %{id: "123"} for the tests instead of the appropriate "123" => %{id: "123"} - what version of Elixir are you using? If you're on the supported version these tests should pass for you

acconrad

comment created time in 2 months

issue commentDevExpress/testcafe

JavaScript error with Apollo on page change since upgrading from 1.1.0 -> 1.1.2

@AlexKamaev I just re-ran and my yarn.lock as well as package.json did indeed confirm version 1.1.2. I should also say this only happens in Chrome. Running this in Safari works as intended.

acconrad

comment created time in 2 months

pull request commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

@BlakeWilliams just checking in - fixed conflicts, ready when you are

acconrad

comment created time in 2 months

push eventacconrad/Elixir-Slack

Jason Axelson

commit sha acd6d51ac7594747ff5f1efc24ac27d42f76dec9

Create separate token generation instructions doc

view details

Jason Axelson

commit sha 970fe4c4db0fe2d73a008f1a4b96226c235f36ac

Fix links

view details

Jason Axelson

commit sha dc074dafaf4bc190c78f9f3f4f8808251b70a7bc

Crop image

view details

Ian Fosbery

commit sha 5f277d1752d85f7bd3efbdb5731b43257c960ec3

Add users.lookupByEmail method to API

view details

Jim Kirkbride

commit sha f02d5074a668c9c4f5763e625b19c07d8a221429

Bumping the version reference in the README to the latest release.

view details

Ian Fosbery

commit sha 41ac5cbe485f817116c821d34fd7aab9c8a9cd59

Add error msg for `missing_scope` on lookup_by_email request

view details

Blake Williams

commit sha 01fbdb75633fa5e3b85808b76a4d33cb09164ff1

Merge pull request #185 from fozcodes/master Add Users.lookup_by_email to Web API

view details

Blake Williams

commit sha c50a3ccdded783340c500647a15185f6c40d89e1

Merge pull request #183 from axelson/update-token-generation-instructions Create separate token generation instructions doc

view details

Blake Williams

commit sha aace91c5d9187702a15e2c06a2a8250258e044f4

Merge pull request #187 from jameskbride/version-bump-in-readme README Update - Version Bump

view details

Adam Conrad

commit sha f54d9d8d3e3ea98bd2db359621009089d2e927a6

Merge branch 'master' into acc-fix-rtm-connect

view details

push time in 2 months

push eventacconrad/Elixir-Slack

Adam Conrad

commit sha 139b8f5bea1e7a836654fbea40a623372d6be0c3

resolve conflict

view details

push time in 2 months

issue openedDevExpress/testcafe

JavaScript error with Apollo on page change since upgrading from 1.1.0 -> 1.1.2

What is your Test Scenario?

  • For a given user, log in and view a page

What is the Current behavior?

A JavaScript error appears on the Testcafe CLI when run against Chrome even when --js-skip-errors flag is added

What is the Expected behavior?

No errors shown (can confirm there are no errors when repeating this workflow on a local instance repeating the exact same steps)

What is your web application and your TestCafe test code?

Unfortunately I do not have anything publicly accessible since this is my company's code but I can show you the error I am receiving:

   1) - Error while restoring configuration after Role switch -
      A JavaScript error occurred on "http://localhost:3000/error".
      At this moment, TestCafe tracks uncaught JavaScript errors on the page. Try to manually perform the test
      scenario.
      If this error still occurs then it means you site has uncaught JavaScript errors. To disable JavaScript error
      tracking you can turn the --skip-js-errors option on.
      If the error occurs only with TestCafe then it is a bug. Write a new issue about it at:
      "https://github.com/DevExpress/testcafe/issues/new?template=bug-report.md".

      JavaScript error details:
      Invariant Violation: Could not find "client" in the context or passed in as a prop. Wrap the root component in
      an <ApolloProvider>, or pass an ApolloClient instance in via props.
          at new InvariantError (http://localhost:3000/static/js/2.chunk.js:231617:24)
          at invariant (http://localhost:3000/static/js/2.chunk.js:231630:11)
          at getClient (http://localhost:3000/static/js/2.chunk.js:231822:86)
          at new Query (http://localhost:3000/static/js/2.chunk.js:232036:20)
          at constructClassInstance (http://localhost:3000/static/js/2.chunk.js:251232:22)
          at updateClassComponent (http://localhost:3000/static/js/2.chunk.js:254710:9)
          at beginWork (http://localhost:3000/static/js/2.chunk.js:255710:20)
          at performUnitOfWork (http://localhost:3000/static/js/2.chunk.js:259730:16)
          at workLoop (http://localhost:3000/static/js/2.chunk.js:259771:28)
          at HTMLUnknownElement.callCallback (http://localhost:3000/static/js/2.chunk.js:239621:18)
          at HTMLUnknownElement.dispatchEvent (http://192.168.1.135:56419/hammerhead.js:6:21481)
          at Object.invokeGuardedCallbackDev (http://localhost:3000/static/js/2.chunk.js:239670:20)
          at invokeGuardedCallback (http://localhost:3000/static/js/2.chunk.js:239724:35)
          at replayUnitOfWork (http://localhost:3000/static/js/2.chunk.js:258954:9)
          at renderRoot (http://localhost:3000/static/js/2.chunk.js:259884:17)
          at performWorkOnRoot (http://localhost:3000/static/js/2.chunk.js:260808:11)
          at performWork (http://localhost:3000/static/js/2.chunk.js:260718:11)
          at performSyncWork (http://localhost:3000/static/js/2.chunk.js:260692:7)
          at requestWork (http://localhost:3000/static/js/2.chunk.js:260547:9)
          at scheduleWork (http://localhost:3000/static/js/2.chunk.js:260360:9)
          at Object.enqueueForceUpdate (http://localhost:3000/static/js/2.chunk.js:251078:9)
          at Query.push../node_modules/react/cjs/react.development.js.Component.forceUpdate
      (http://localhost:3000/static/js/2.chunk.js:272163:20)
          at Query._this.updateCurrentData (http://localhost:3000/static/js/2.chunk.js:231944:35)
          at Object.error (http://localhost:3000/static/js/2.chunk.js:231926:17)
          at notifySubscription (http://localhost:3000/static/js/2.chunk.js:300275:18)
          at onNotify (http://localhost:3000/static/js/2.chunk.js:300314:3)
          at SubscriptionObserver.error (http://localhost:3000/static/js/2.chunk.js:300371:7)
          at http://localhost:3000/static/js/2.chunk.js:80353:35
          at Array.forEach (<anonymous>)
          at Object.error (http://localhost:3000/static/js/2.chunk.js:80352:25)
          at QueryManager.<anonymous> (http://localhost:3000/static/js/2.chunk.js:81163:30)
          at step (http://localhost:3000/static/js/2.chunk.js:294693:19)
          at Object.next (http://localhost:3000/static/js/2.chunk.js:294623:14)
          at http://localhost:3000/static/js/2.chunk.js:294598:67
          at new Promise (<anonymous>)
          at __awaiter (http://localhost:3000/static/js/2.chunk.js:294575:10)
          at http://localhost:3000/static/js/2.chunk.js:81136:69
          at http://localhost:3000/static/js/2.chunk.js:81587:9
          at Array.forEach (<anonymous>)
          at http://localhost:3000/static/js/2.chunk.js:81586:10
          at Map.forEach (<anonymous>)
          at QueryManager.broadcastQueries (http://localhost:3000/static/js/2.chunk.js:81582:18)
          at http://localhost:3000/static/js/2.chunk.js:81107:27

Your Environment details:

  • testcafe version: 1.1.2
  • node.js version: 10.15.3 LTS
  • command-line arguments: testcafe chrome test/e2e/tests/ --js-skip-errors
  • browser name and version: Chrome 73.0.3683
  • platform and version: macOS 10.14.4
  • other: This worked totally fine on 1.1.0. Only when upgrading to 1.1.2 did this issue start occurring.

created time in 2 months

pull request commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

@BlakeWilliams ready to merge when you are

acconrad

comment created time in 3 months

Pull request review commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

 defmodule Slack.Bot do       token: token,       me: rtm.self,       team: rtm.team,-      bots: rtm_list_to_map(rtm.bots),-      channels: rtm_list_to_map(rtm.channels),-      groups: rtm_list_to_map(rtm.groups),-      users: rtm_list_to_map(rtm.users),-      ims: rtm_list_to_map(rtm.ims)+      bots: bot_to_map(Bots.info(%{token: token}) |> Map.get("bot")),

The code you presented causes the tests to fail. I don't think these refactoring changes are worth it if they aren't going to keep the code working properly.

acconrad

comment created time in 3 months

Pull request review commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

 defmodule Slack.Bot do       token: token,       me: rtm.self,       team: rtm.team,-      bots: rtm_list_to_map(rtm.bots),-      channels: rtm_list_to_map(rtm.channels),-      groups: rtm_list_to_map(rtm.groups),-      users: rtm_list_to_map(rtm.users),-      ims: rtm_list_to_map(rtm.ims)+      bots: bot_to_map(Bots.info(%{token: token}) |> Map.get("bot")),+      channels: rtm_list_to_map(Channels.list(%{token: token}) |> Map.get("channels")),

Feel free to update my PR and change this but I don't think this is simpler or easier to read.

acconrad

comment created time in 3 months

Pull request review commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

 defmodule Slack.Bot do       token: token,       me: rtm.self,       team: rtm.team,-      bots: rtm_list_to_map(rtm.bots),-      channels: rtm_list_to_map(rtm.channels),-      groups: rtm_list_to_map(rtm.groups),-      users: rtm_list_to_map(rtm.users),-      ims: rtm_list_to_map(rtm.ims)+      bots: bot_to_map(Bots.info(%{token: token}) |> Map.get("bot")),

I'm not really understanding your question - that is what I'm doing. What are you suggesting I do differently?

acconrad

comment created time in 3 months

Pull request review commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

 defmodule Slack.BotTest do   @rtm %{     url: "http://example.com",     self: %{name: "fake"},-    team: %{name: "Foo"},-    bots: [%{id: "123"}],-    channels: [%{id: "123"}],-    groups: [%{id: "123"}],-    users: [%{id: "123"}],-    ims: [%{id: "123"}]+    team: %{name: "Foo"}   }    test "init formats rtm results properly" do-    {:reconnect, %{slack: slack, bot_handler: bot_handler}} =-      Slack.Bot.init(%{-        bot_handler: Bot,-        rtm: @rtm,-        client: FakeWebsocketClient,-        token: "ABC",-        initial_state: nil-      })--    assert bot_handler == Bot-    assert slack.me.name == "fake"-    assert slack.team.name == "Foo"-    assert slack.bots == %{"123" => %{id: "123"}}-    assert slack.channels == %{"123" => %{id: "123"}}-    assert slack.groups == %{"123" => %{id: "123"}}-    assert slack.users == %{"123" => %{id: "123"}}-    assert slack.ims == %{"123" => %{id: "123"}}+    with_mocks([

I tried for a few hours on Saturday and this was the only way I could think of to mock out the external Web calls

acconrad

comment created time in 3 months

Pull request review commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

 defmodule Slack.Bot do       token: token,       me: rtm.self,       team: rtm.team,-      bots: rtm_list_to_map(rtm.bots),-      channels: rtm_list_to_map(rtm.channels),-      groups: rtm_list_to_map(rtm.groups),-      users: rtm_list_to_map(rtm.users),-      ims: rtm_list_to_map(rtm.ims)+      bots: bot_to_map(Bots.info(%{token: token}) |> Map.get("bot")),

@chulkilee the response returns a map within a map - so in order to get the bot property I need to go 1 layer deeper.

acconrad

comment created time in 3 months

Pull request review commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

 defmodule Slack.Bot do       token: token,       me: rtm.self,       team: rtm.team,-      bots: rtm_list_to_map(rtm.bots),-      channels: rtm_list_to_map(rtm.channels),-      groups: rtm_list_to_map(rtm.groups),-      users: rtm_list_to_map(rtm.users),-      ims: rtm_list_to_map(rtm.ims)+      bots: bot_to_map(Bots.info(%{token: token}) |> Map.get("bot")),

it's meant to map to the original functionality as you can see from the test

acconrad

comment created time in 3 months

PR opened denoland/deno

[WIP] Web API: EventTarget

This PR implements the EventTarget Web API spec.

I'm still stuck on this but wanted some initial eyes because I feel like a lot of the dispatching work that has to be done specifically relating to the Shadow DOM or Window seems unnecessary in the context of Deno. If I can make those assumptions that this stuff will always be a non-issue than this simplifies the implementation quite a bit.

@ztplz I know you were planning on working on an implementation of EventTarget would this be a good base for you to take over the line?

+710 -47

0 comment

3 changed files

pr created time in 3 months

PR closed denoland/deno

[WIP] Web API: EventTarget

This PR implements the EventTarget Web API spec.

I'm still stuck on this but wanted some initial eyes because I feel like a lot of the dispatching work that has to be done specifically relating to the Shadow DOM or Window seems unnecessary in the context of Deno. If I can make those assumptions that this stuff will always be a non-issue than this simplifies the implementation quite a bit.

@ztplz I know you were planning on working on an implementation of EventTarget would this be a good base for you to take over the line?

+710 -47

1 comment

3 changed files

acconrad

pr closed time in 3 months

issue commentdenoland/deno

help wanted: Web APIs' implementation

Broken but an initial look at EventTarget: https://github.com/denoland/deno/pull/2028

kyranet

comment created time in 3 months

PR opened denoland/deno

[WIP] Web API: EventTarget

This PR implements the EventTarget Web API spec.

I'm still stuck on this but wanted some initial eyes because I feel like a lot of the dispatching work that has to be done specifically relating to the Shadow DOM or Window seems unnecessary in the context of Deno. If I can make those assumptions that this stuff will always be a non-issue than this simplifies the implementation quite a bit.

+710 -47

0 comment

3 changed files

pr created time in 3 months

create barnchacconrad/deno

branch : acc-add-event-target

created branch time in 3 months

issue commentdenoland/deno

help wanted: Web APIs' implementation

Just to update - everything here is done except for EventTarget which is an incomplete spec. I'm working on finalizing it today.

kyranet

comment created time in 3 months

fork acconrad/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 3 months

delete branch acconrad/csstree

delete branch : acc-bump-mdn-data

delete time in 3 months

push eventacconrad/Elixir-Slack

Adam Conrad

commit sha 8efc5adeb295e382fadfc794a8f00d34019bbc25

Formatting

view details

push time in 3 months

push eventacconrad/Elixir-Slack

Adam Conrad

commit sha bdf2f1bb002fa2dffb1afb1600dc5db9081d17f6

Fix tests and add deprecation

view details

push time in 3 months

pull request commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

@BlakeWilliams all set! I also fixed the tests, added the deprecation and bumped it by 1 minor version and provided the appropriate documentation

acconrad

comment created time in 3 months

push eventacconrad/Elixir-Slack

Adam Conrad

commit sha 83148746433405bd1276b86831894fea1ac3c1f7

Fix tests and add deprecation

view details

push time in 3 months

pull request commentBlakeWilliams/Elixir-Slack

Fix rtm.connect startup issue

@BlakeWilliams so I looked into the call and the problem is that the init function is never called in your library. It's only called via websocket_client the Erlang library, so there is no way for me to force in that argument (or alternative function).

Here is what I would recommend: we push this up right now so we can fix everyone's issue and bump the version so 0.16 -> 0.17. At the next version 0.2 (or 1.0, whatever the next breaking bump) you just need to change the README to state that the slack state no longer returns everything that it originally did and probably include a conversion guide (happy to provide that for you).

acconrad

comment created time in 3 months

pull request commentcsstree/csstree

Bump MDN/Data NPM library

all set @lahmatiy

acconrad

comment created time in 3 months

push eventacconrad/csstree

Adam Conrad

commit sha 57101464f9d2ce81613057d68a2d6b35d8159679

updated yarn lock file

view details

push time in 3 months

push eventacconrad/csstree

Adam Conrad

commit sha 70aad20ff22506733afc64db261d8f12e7730276

change the changelog

view details

push time in 3 months

more