profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/abhiabhi94/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Abhyudai abhiabhi94 @scdotin तेतारपुर, सैदपुर hackadda.com

abhiabhi94/ANPR 5

Detecting number plates of a car and identifying its category based upon the registration plate. Also identifying whether the car breaches the "Stopping at pedestrian crossing rule".

abhiabhi94/Face-detection-and-Recognition 4

Detect and recognize faces from an image

abhiabhi94/django-flag-app 3

A pluggable django application that adds the ability for users to flag(or report) your models.

abhiabhi94/battery-monitor 2

A desktop app that uses python and ACPI to give notification regarding battery percentages.

abhiabhi94/OCR 2

Optical Character Recognition using openCV, Python

abhiabhi94/Motion-Detection 1

We try to detect the moving objects from a video. The surrounding objects need to be really still to correctly detect the moving objects.

abhiabhi94/send-bulk-emails 1

Sending bulk emails through a python script

abhiabhi94/aima-python 0

Python implementation of algorithms from Russell And Norvig's "Artificial Intelligence - A Modern Approach"

abhiabhi94/CADL 0

Course materials/Homework materials for the Kadenze Academy course on "Creative Applications of Deep Learning w/ Tensorflow" #CADL

abhiabhi94/care 0

Care is a single point to link Hospitals, Corona Care Centers and Volunteers to the unified Corona Safe Network so that the Kerala Chief Ministers Office has direct access to live reports of health data v/s our total. healthcare capacity

fork reyesvicente/django-flag-app

A pluggable django application that adds the ability for users to flag(or report) your models.

fork in 12 hours

push eventRadi85/Comment

Radi85

commit sha cec3b97150a9b0766d79654ee6eb0d2a56d35cce

fix(#157): pluralization issue closes #157

view details

push time in a day

PR opened Radi85/Comment

fix(#157): pluralization issue

closes #157

+112 -87

0 comment

4 changed files

pr created time in a day

create barnchRadi85/Comment

branch : fix-translation-issue

created branch time in a day

startedabhiabhi94/django-flag-app

started time in a day

push eventRadi85/Comment

Radi85

commit sha 750c855a769c0b22e54583b95b9c778017b200e4

feat(#158): allow rendering new line in comment

view details

push time in a day

PR opened Radi85/Comment

feat(#158): allow rendering new line in comment

closes #158

+66 -17

0 comment

11 changed files

pr created time in a day

create barnchRadi85/Comment

branch : allow-new-line-in-content

created branch time in a day

issue commentRadi85/Comment

{{ request.path }} Does not work for me

can you please specify the steps to reproduce the bug?

What are the expected and the current behaviors?

mohhammaddaberi

comment created time in 2 days

created repositoryjvns/zig-include

created time in 4 days

starteddoy/teleterm

started time in 4 days

issue commentRadi85/Comment

Use custom style and remove bootstrap.

Would you really need it as a feature though? I replaced it in my project by overriding the templates.

Can you share how you did this or maybe the repo where you did this? Utility frameworks are foreign to me :) I added similar feature requesting support for Tailwind. Your code might help make me changes.

Sorry for taking so long to answer this (I had bookmarked it and then forgotten about it). It's not overly complicated. Just like any Django project, you can override the templates of any third-party app by creating HTML files with the same names in your root template folder.

An easy way to do it is to create a comment folder inside your templates folder (as that's the name of this app) and copy all the content from this location into your project. Then you can treat these template files as your own and change them as you wish (just don't change their names).

Radi85

comment created time in 4 days

PublicEvent

issue openedRadi85/Comment

{{ request.path }} Does not work for me

Screenshot (42)_LI Screenshot (44)_LI Screenshot (46)

Environment

  • python version 3.8
  • django Version 3.1
  • django-comments-dab 2.5

Describe the bug

Note: I uninstalled the app from the packages section and put it in my directory Apps

Steps To Reproduce

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

created time in 6 days

issue commentRadi85/Comment

Any plans for Tailwind CSS support?

Good to know. That makes sense,

spsphulse

comment created time in 8 days

startedrobotology-playground/pybullet-robot-envs

started time in 10 days

startedpetercorke/robotics-toolbox-python

started time in 10 days

push eventRadi85/Comment

abhiabhi94

commit sha 3d7f3f0a73478a08189cd56ac1c5739199946b70

feat(#128): Allow custom user model fields - custom username and email fields set inside user model can now be used. resolves #128

view details

push time in 11 days

PR merged Radi85/Comment

feat(#128): Allow custom user model fields
  • custom username and email fields set inside user model can now be used.

resolves #128

+58 -44

0 comment

10 changed files

abhiabhi94

pr closed time in 11 days

issue closedRadi85/Comment

Use django built-in EMAIL_FIELD and USERNAME_FIELD

<!-- NOTE: This template is for use by maintainers only. Please do not submit an issue using this template. -->

Change Type

[x] Refactor/Enhancement [ ] Testing [ ] CI/CD [ ] Other

Proposed Changes

Replace all occurrences of user.username and user.email with django built-in fields USERNAME_FIELD and EMAIL_FIELD respectively.

This will allow us to use the actual username and email fields on the user model instead of using the default one.

closed time in 11 days

Radi85

issue commentRadi85/Comment

Any plans for Tailwind CSS support?

Hey @spsphulse,

Glad to hear your feedback :)

As you already noticed in #15, our plan is to make the app independent from 3rd party libraries.

We have already replaced JQuery by Vanilla JS and our plan is to replace BS by custom style so there is no point of using Tailwind at all.

The milestone for #15 is 3.0.0 but I would move it to 2.7.0

spsphulse

comment created time in 12 days

issue commentRadi85/Comment

Use custom style and remove bootstrap.

Would you really need it as a feature though? I replaced it in my project by overriding the templates.

Can you share how you did this or maybe the repo where you did this? Utility frameworks are foreign to me :) I added similar feature requesting support for Tailwind. Your code might help make me changes.

Radi85

comment created time in 12 days

issue openedRadi85/Comment

Any plans for Tailwind CSS support?

This is an amazing utility honestly, Do you have any plans of adding tailwind support in the future?

created time in 12 days

Pull request review commentRadi85/Comment

feat(#128): Allow custom user model fields

  from comment.managers import CommentManager from comment.conf import settings-from comment.utils import is_comment_moderator, get_username_for_comment+from comment.utils import is_comment_moderator   class Comment(models.Model):     user = models.ForeignKey(get_user_model(), on_delete=models.CASCADE, blank=True, null=True)-    email = models.EmailField(blank=True)+    email = models.EmailField(blank=True, null=True)

To avoid future instances of such cases where people aren't using email but only usernames. There are a lot more scenarios for this.

You are checking if the user object has an email attribute and you use it if any, otherwise you are using the default value from getattr, what scenarios can be other than this???

I don't understand what's so concerning about the migration as to say.

Avoid adding unnecessary code specially migrations.

Also, unless and until we have null=True on the model field, how can we set an empty string for it? An EmailField won't allow those value.

We didn't have any issue so far on creating comment with an empty email value. The user can still create a comment even if their email value is empty.

abhiabhi94

comment created time in 15 days

Pull request review commentRadi85/Comment

feat(#128): Allow custom user model fields

  from comment.managers import CommentManager from comment.conf import settings-from comment.utils import is_comment_moderator, get_username_for_comment+from comment.utils import is_comment_moderator   class Comment(models.Model):     user = models.ForeignKey(get_user_model(), on_delete=models.CASCADE, blank=True, null=True)-    email = models.EmailField(blank=True)+    email = models.EmailField(blank=True, null=True)

I mean we didn't have any issue with the current state, why would we need to do this change now? I think you can replace None with empty string to avoid new migration. The chabne should be in the _set_email method: https://github.com/Radi85/Comment/pull/164/files#diff-c4e5567003cbea1eddb9e40211f2c07e1608ac78a0a54f221d18b0332ed36a2fL75-L78

self.email = getattr(self.user, self.user.EMAIL_FIELD, '')
abhiabhi94

comment created time in 15 days

Pull request review commentRadi85/Comment

feat(#128): Allow custom user model fields

  from comment.managers import CommentManager from comment.conf import settings-from comment.utils import is_comment_moderator, get_username_for_comment+from comment.utils import is_comment_moderator   class Comment(models.Model):     user = models.ForeignKey(get_user_model(), on_delete=models.CASCADE, blank=True, null=True)-    email = models.EmailField(blank=True)+    email = models.EmailField(blank=True, null=True)

What the purpose of this change?

abhiabhi94

comment created time in 16 days

pull request commentRadi85/Comment

ci(#165): Solve CI issue with django master

Hmmm, the ci in the commit message should be replaced by chore as per https://github.com/Radi85/Comment/blob/develop/CONTRIBUTING.rst#pr-and-commit-messages.

Note for future commits.

abhiabhi94

comment created time in 16 days

push eventRadi85/Comment

abhiabhi94

commit sha 9f0b13098fa93f5b0e0b4932fa2a787342485339

ci(#165): Solve CI issue with django master - use python version >= 3.8 for the tests on the master branch of django. fixes #165

view details

push time in 16 days

issue closedRadi85/Comment

Use python version >=3.8 for running tests for the master branch of django

<!-- NOTE: This template is for use by maintainers only. Please do not submit an issue using this template. -->

Change Type

[ ] Refactor/Enhancement [ ] Testing [x ] CI/CD [ ] Other

Proposed Changes

Since the support for 3.6 and 3.7 was dropped in the commit https://github.com/django/django/commit/ec0ff406311de88f4e2a135d784363424fe602aa for the master branch of django, we would have to incorporate the changes in our tox tests.

closed time in 16 days

abhiabhi94

PR merged Radi85/Comment

ci(#165): Solve CI issue with django master
  • use python version >= 3.8 for the tests on the master branch of django.
+4 -1

0 comment

2 changed files

abhiabhi94

pr closed time in 16 days