profile
viewpoint

abeyuya/actions-mention-to-slack 13

Github Action for convert Github mention to Slack mention.

abeyuya/action-lgtm-reaction 0

GitHub Action to send LGTM reaction

abeyuya/ActionSheetPicker-3.0 0

Quickly reproduce the dropdown UIPickerView / ActionSheet functionality from Safari on iPhone/ iOS / CocoaTouch.

abeyuya/Alamofire 0

Elegant HTTP Networking in Swift

abeyuya/amazon-dash-slack-status 0

Change slack status by pushing amazon-dash-button

abeyuya/amazon-list-scraper 0

Scrape items from a public Amazon's list

abeyuya/amazon-wish-list 0

NPM module to find amazon wish lists by their ID or multiple lists by customer ID.

abeyuya/amazon-wish-lister 0

Retrieve Amazon Wishlist and output to JSON, XML, or PHP Array Object

abeyuya/Android-Iconics 0

Android-Iconics - Use any icon font, or vector (.svg) as drawable in your application.

issue commentfacebook/react-native

Unable to find a specification for `React-Core (= 0.63.0)` depended upon by `React`

@enaluz I manage to fix this issue, Actually it was my bad, I missed to add use_react_native!(:path => config["reactNativePath"]) in pod file.

Where to add this line in podfile ?

waheedakhtar694

comment created time in 2 hours

issue commentfacebook/react-native

React Native fonts don`t work

Have you checked the font in Font-book's name? Font names on iOS devices are sometimes not the same as the file name. Open the font in font-book and use the PostScript's name instead of the file name.

From #25852

ksielyov

comment created time in 2 hours

issue commentfacebook/react-native

ReferenceError: Can't find variable: BigInt

Try to add the @babel/plugin-syntax-bigint plugin in your babel configuration file.

My babel.config.js file before

module.exports = {
  presets: ['module:metro-react-native-babel-preset']
};

My babel.config.js file now

module.exports = {
  presets: ['module:metro-react-native-babel-preset'],
  plugins: ["@babel/plugin-syntax-bigint"]
};

I fixed it in this way

ryuheimat

comment created time in 3 hours

issue commentfacebook/react-native

Android TextInput onKeyPress not fired

System: OS: macOS 11.0.1 CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz Memory: 46.17 MB / 16.00 GB Shell: 5.8 - /bin/zsh Binaries: Node: 14.9.0 - /usr/local/bin/node Yarn: 1.22.5 - /usr/local/bin/yarn npm: 6.14.7 - /usr/local/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman Managers: CocoaPods: 1.9.3 - /usr/local/bin/pod SDKs: iOS SDK: Platforms: iOS 14.2, DriverKit 20.0, macOS 11.0, tvOS 14.2, watchOS 7.1 Android SDK: Not Found IDEs: Android Studio: 4.0 AI-193.6911.18.40.6626763 Xcode: 12.2/12B45b - /usr/bin/xcodebuild Languages: Java: 1.8.0_265 - /usr/bin/javac Python: 2.7.16 - /usr/bin/python npmPackages: @react-native-community/cli: Not Found react: 16.13.1 => 16.13.1 react-native: 0.63.2 => 0.63.2 react-native-macos: Not Found npmGlobalPackages: react-native: Not Found

canerd7u

comment created time in 3 hours

issue commentfacebook/react-native

ReferenceError: Can't find variable: BigInt

Same Issue here!

ryuheimat

comment created time in 3 hours

pull request commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

<!-- 0 failure: 1 warning: :grey_question: B...

DangerID: danger-id-Danger; -->

<table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Warnings</th> </tr> </thead> <tbody><tr> <td>:warning:</td> <td>

:grey_question: Base Branch - <i>The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.</i> </td> </tr> </tbody> </table>

<p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against 8d5ef5bdca032f1a7e05ff06100165c6ce3e1fa8 </p>

tido64

comment created time in 3 hours

issue commentfacebook/react-native

Android TextInput onKeyPress not fired

<table><tbody><tr><th width="50">:warning:</th><th width="100%"> Missing Environment Information </th></tr><tr><td>:information_source:</td><td> Your issue may be missing information about your development environment. You can obtain the missing information by running <code>react-native info</code> in a console. </td></tr></tbody></table>

canerd7u

comment created time in 3 hours

issue openedfacebook/react-native

Android TextInput onKeyPress not fired

Textınput onKeyPress function not fired with keyboardType "numeric" or "number-pad" ...

This function, which was added 2 years ago, should now be updated.

created time in 3 hours

pull request commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

Note to self: Don't change the base branch on GitHub.

tido64

comment created time in 3 hours

pull request commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

Maybe then we should have this PR point directly to the 0.64 branch instead on master? That way we can roll it back once we have the proper codegen fix?

Yeah I think this makes sense 👍

tido64

comment created time in 3 hours

Pull request review commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

 def flipper_post_install(installer)  # Pre Install processing for Native Modules def codegen_pre_install(installer, options={})-  # Path to React Native-  prefix = options[:path] ||= "../node_modules/react-native"+  # Path to React Native relative to where `pod install` was invoked. This can+  # sometimes be inside the `ios` folder (i.e. `pod install `), or outside+  # (e.g. `pod install --project_directory=ios`).+  prefix = options[:path] ||= resolve_module "react-native"

Sorry, didn't see your replies until after I had posted this. The scenario you mentioned in the last post is a very real one for us. I'd rather leave it like this.

tido64

comment created time in 3 hours

issue commentfacebook/react-native

Android TextInput font family incorrect after switching `secureTextEntry`

If you see a crash on iOS here's how I fixed it.

useEffect(() => {
      ref.current.setNativeProps({
        style: { fontFamily: Platform.OS === "android" ? "roboto-regular" : undefined }
      });
  }, []);
timomeara

comment created time in 4 hours

pull request commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

It makes sense to update the Podfile with a path tho, as a part of making it easier for users to play around with the RC.

Maybe then we should have this PR point directly to the 0.64 branch instead? That way we can roll it back until we have the proper codegen fix?

tido64

comment created time in 4 hours

Pull request review commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

 def flipper_post_install(installer)  # Pre Install processing for Native Modules def codegen_pre_install(installer, options={})-  # Path to React Native-  prefix = options[:path] ||= "../node_modules/react-native"+  # Path to React Native relative to where `pod install` was invoked. This can+  # sometimes be inside the `ios` folder (i.e. `pod install `), or outside+  # (e.g. `pod install --project_directory=ios`).+  prefix = options[:path] ||= resolve_module "react-native"

Not quite sure I understand what you mean here… The root of this issue is that we cannot use the same path for both use_react_native! and codegen_pre_install. use_react_native! needs paths that are relative to the Podfile because CocoaPods will be resolving modules later. codegen_pre_install, on the other hand, needs the paths to be relative to the current working directory because it is invoked right away.

tido64

comment created time in 4 hours

pull request commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

It makes sense to update the Podfile with a path tho, as a part of making it easier for users to play around with the RC.

tido64

comment created time in 4 hours

pull request commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

@tido64, the PR referenced by @alloy is listed on the release thread as a "non RC blocking" to be resolved ahead of stable release. Waiting for @hramos to be back next week to get better understanding of the path going forward for codegen and whether this one is indeed required for stable.

tido64

comment created time in 4 hours

pull request commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

I.e. I don’t think there needs to be too much work done here, as it will likely be removed soon anyways.

@alloy: If codegen is going to be moved out of Podfile, wouldn't it make sense to do that now before we ship 0.64? Are we telling consumers to add this function, then remove it in the next version?

tido64

comment created time in 5 hours

pull request commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

@grabbou It’s a good question, but think that's moot at this point, as the intent is to move invocation of the codegen compiler out of the Podfile entirely as it needs to be part of the build pipeline: https://github.com/facebook/react-native/pull/30449

tido64

comment created time in 5 hours

Pull request review commentfacebook/react-native

Ensure codegen runs at Xcode buildtime

 pre_install do |installer|   frameworks_pre_install(installer) if ENV['USE_FRAMEWORKS'] == '1'   if ENV['USE_CODEGEN'] != '0'     prefix_path = "../.."-    codegen_pre_install(installer, {path:prefix_path})+    codegen_path = "../../packages/react-native-codegen"+    system("./#{codegen_path}/scripts/oss/build.sh") or raise "Could not build react-native-codegen package"+    codegen_pre_install(installer, {path:prefix_path, codegen_path:codegen_path})

I’m unsure why codegen is still invoked at all as part of pod install. Having it be part of the actual build pipeline means it will always run when necessary, right? So then it seems needlessly redundant to me to still invoke it here too.

hramos

comment created time in 5 hours

CommitCommentEvent

issue commentfacebook/react-native

Hide strong password TextInput

Still happening to me. Maybe it should be something related to Xcode12?

jaroslav009

comment created time in 5 hours

issue commentfacebook/react-native

If anyone is facing the same issue, because of the "http" just add `android:usesCleartextTraffic="true"` to the Manifest, and you should be good.

This should be true by default when you create a new project with react-native-cli so that this upgrade helper will include it. https://react-native-community.github.io/upgrade-helper/?from=0.59.9&to=0.63.3

tirthpatel1

comment created time in 5 hours

issue commentfacebook/react-native

App freezes when coming from background in RN 0.63.3

@fangasvsass Not yet. I'm rebuilding the app from the ground trying to find the issue. :/

luco

comment created time in 5 hours

pull request commentfacebook/react-native

Expose the testID to black-box testing frameworks on Android

Thank you for shedding some light on this @TwFlem :smiley:, I suppose you need to build Android because the PR modifies a .java file. At the time I just gave up and created a special testing environment then sprinkled some ifs thoughout the code base to either test or show proper descriptions. As you said, hope they merge this one, will save a lot of headaches.

jdeff

comment created time in 5 hours

issue commentfacebook/react-native

Invariant Violation: ListView has been removed from React Native

@omarichatman did you find an answer? please share I'm facing the same problem. I'm not using ListView in my project but still I am facing this error

omarichatman

comment created time in 6 hours

CommitCommentEvent

Pull request review commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

 def flipper_post_install(installer)  # Pre Install processing for Native Modules def codegen_pre_install(installer, options={})-  # Path to React Native-  prefix = options[:path] ||= "../node_modules/react-native"+  # Path to React Native relative to where `pod install` was invoked. This can+  # sometimes be inside the `ios` folder (i.e. `pod install `), or outside+  # (e.g. `pod install --project_directory=ios`).+  prefix = options[:path] ||= resolve_module "react-native"

Technically, the assumption of react-native-codegen living side by side react-native can be false in the following scenario:

node_modules/react-native-codegen (0.0.7)
packageA/node_modules/react-native (0.64.0-rc.0)
packageB/node_modules/react-native (0.64.0-rc.1)

In other words, two React Native packages sharing same React Native codegen version.

In that case, it may be worth to leave resolve_module just for react-native-codegen or... we make sure that react-native-codegen is always versioned together with the React Native (same version as the RC, with patch bump).

This is the idea going forward, but at the time of writing, the aforementioned scenario is technically possible.

tido64

comment created time in 6 hours

issue commentfacebook/react-native

App freezes when focus TextInput

These steps resolved my problem.

Reset simulator: Device > "Erase All Contents and Settings..."

Screen Shot 2020-11-25 at 4 18 33 PM

Disable pastebin sync: Edit > "Automatically Sync Pasteboard"

Screen Shot 2020-11-25 at 4 19 31 PM

perlo27

comment created time in 6 hours

pull request commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

I am also trying to understand why did we introduce another script, codegen_pre_install, at all? It seems to be required and needs to be always included. Otherwise iOS apps will fail to build as there are missing files.

Why don't we just make it part of use_react_native?

CC: @alloy

tido64

comment created time in 6 hours

Pull request review commentfacebook/react-native

fix(iOS): `pod install` fails outside `ios` folder

 # This source code is licensed under the MIT license found in the # LICENSE file in the root directory of this source tree. -def use_react_native! (options={})+def resolve_module(request)+  script = "console.log(path.dirname(require.resolve('#{request}/package.json')));"+  Pod::Executable.execute_command('node', ['-e', script], true).strip+end++def use_react_native!(options={})   # The prefix to the react-native   prefix = options[:path] ||= "../node_modules/react-native"

@Titozzz we always pass options.path by default in the template, which is absolute location of React Native as resolved by the CLI.

tido64

comment created time in 6 hours

more