profile
viewpoint

kefniark/Coopa 1

Simple and reliable Typescript utility library

Yuuki77/algorithm-visualizer 0

:fireworks:Interactive Online Platform that Visualizes Algorithms from Code

Yuuki77/AStar 0

AStar example with community contributions

Yuuki77/awesome-streamerrc 0

Current .vimrc configs for various streamers on Twitch.

Yuuki77/cli 0

GitHub’s official command line tool

Yuuki77/Coopa 0

Simple and reliable Typescript utility library

Yuuki77/lazygit 0

simple terminal UI for git commands

PR opened microsoft/vscode-pull-request-github

Allow to see commits of a PR without checking out to it

Fixes https://github.com/microsoft/vscode-pull-request-github/issues/2201 now you can see the commits without checking out

So use files folder and commit folder image

+8 -10

0 comment

1 changed file

pr created time in 5 hours

push eventYuuki77/vscode-pull-request-github

Yuki Osaki

commit sha ea312c7a206924077cc21c13738a79bacb10faed

Allow to see commits of a PR without checkig out to it

view details

push time in 5 hours

create barnchYuuki77/vscode-pull-request-github

branch : feature-commints

created branch time in 9 hours

push eventYuuki77/MyStudy

Yuki Osaki

commit sha c69771992d1e9a184817b557711a302b6c7f7e23

Union find

view details

Yuki Osaki

commit sha 1463689f3fd3bca247f7482920ddc695d0f458b6

Merge branch 'master' of https://gitlab.com/Yuuki77/linearalgebra

view details

Yuki Osaki

commit sha 64361a912be8fa043f2572914d7beeadda201d4c

commit

view details

Yuki Osaki

commit sha 4375ac6ddab0d3a9c78f92b679867bb5e18ea33c

stuff

view details

Yuki Osaki

commit sha c309dafb501d68043ebd0d50d8872bfeba28c677

push

view details

Yuki Osaki

commit sha 3fda0dea0b0d0b5584c86745bfb0a84c58b515a8

commit test

view details

Yuki Osaki

commit sha 32f43a378d6d98bf416b6c048d0265aa9d6d4f87

this is the commi

view details

Yuki Osaki

commit sha 126b6968d194e6b542b051df132a1b4e43f24abe

test

view details

Yuki Osaki

commit sha fcb5f9eb6369b063ee18fe2e24634cf7a672cffe

all stack test success

view details

Yuki Osaki

commit sha 1a98c798d48547f0a32d482eaa300fcae2941a07

temp

view details

Yuki Osaki

commit sha 998fa7e6bc7331cf1720bddfc57e6a0cb27086a1

temp

view details

push time in a day

startedjwasham/coding-interview-university

started time in 3 days

startedTSiege/Tech-Interview-Cheat-Sheet

started time in 4 days

startedc-bata/go-prompt

started time in 4 days

push eventdegica/barcelona-cli

David Siaw

commit sha 498a191e7b2ea8d0c7f94df64292216e228dc652

test app operations, and mock user inputs

view details

David Siaw

commit sha 0e3685a363e5277f7743549d5fa59ba343725e86

review fixes

view details

Yuki Osaki

commit sha 3250f90c40999d83f602068bc2a5d39ac883e68a

Merge pull request #37 from degica/more-testing More testing

view details

push time in 9 days

PR merged degica/barcelona-cli

More testing

This PR moves a bunch of the app command out to its own operation and stubs out a bunch of things that it uses in order to enable testing on it. Yes that includes testing user input

Additionally, the following changes are made:

  • Make Print a member of Heritage instead of PrintHeritage
  • Moved User input commands into the utils package
  • Create a utils.UserInputReader interface that allows me to stub out user input and test behaviour for various kinds of input.

As with other parts of barcelona-cli, there is some heavy golang action here so feel free to ask any questions.

+266 -111

3 comments

12 changed files

davidsiaw

pr closed time in 9 days

PullRequestReviewEvent

Pull request review commentdegica/barcelona-cli

More testing

+package operations++import (+	"bytes"+	"io"+)++type MockAppOperationApiClient struct {+}++func (client MockAppOperationApiClient) Get(path string, body io.Reader) ([]byte, error) {+	return bytes.NewBufferString("{\"say\":\"hello\"}").Bytes(), nil+}++func (client MockAppOperationApiClient) Delete(path string, body io.Reader) ([]byte, error) {+	return bytes.NewBufferString("").Bytes(), nil+}++type MockAppOperationInputReaderNo struct {+}++func (_ MockAppOperationInputReaderNo) Read(_ bool) (string, error) {+	return "n\n", nil+}++type MockAppOperationInputReaderYes struct {+}++func (_ MockAppOperationInputReaderYes) Read(_ bool) (string, error) {+	return "y\n", nil+}++func ExampleAppOperation_run_delete_no_confirm_output() {+	client := &MockAppOperationApiClient{}+	oper := NewAppOperation("asd", Delete, true, client, nil /* because it doesnt matter */)++	oper.run()

I did not know that 😄 good to learn

davidsiaw

comment created time in 9 days

PullRequestReviewEvent

Pull request review commentdegica/barcelona-cli

More testing

+package utils++import (+	"bufio"+	"fmt"+	"os"+	"strings"+	"syscall"++	"golang.org/x/crypto/ssh/terminal"+)++type UserInputReader interface {+	Read(secret bool) (string, error)+}++type StdinInputReader struct{}++func NewStdinInputReader() *StdinInputReader {+	return &StdinInputReader{}+}++func (reader StdinInputReader) Read(secret bool) (string, error) {+	if secret {+		bytePassword, err := terminal.ReadPassword(int(syscall.Stdin))+		if err != nil {+			return "", err+		}+		response := string(bytePassword)+		return response, nil++	} else {+		reader := bufio.NewReader(os.Stdin)+		response, err := reader.ReadString('\n')+		if err != nil {+			return "", err+		}+		return response, nil+	}+}++func AreYouSure(message string, reader UserInputReader) bool {+	for {+		res := Ask(fmt.Sprintf("%s [y/n]", message), false, false, reader)+		if res == "y" {+			return true+		} else if res == "n" {+			return false+		}

I think you can do something like this.

		res := Ask(fmt.Sprintf("%s [y/n]", message), false, false, reader)
	        return res == "y"
davidsiaw

comment created time in 9 days

Pull request review commentdegica/barcelona-cli

More testing

+package operations++import (+	"bytes"+	"io"+)++type MockAppOperationApiClient struct {+}++func (client MockAppOperationApiClient) Get(path string, body io.Reader) ([]byte, error) {+	return bytes.NewBufferString("{\"say\":\"hello\"}").Bytes(), nil+}++func (client MockAppOperationApiClient) Delete(path string, body io.Reader) ([]byte, error) {+	return bytes.NewBufferString("").Bytes(), nil+}++type MockAppOperationInputReaderNo struct {+}++func (_ MockAppOperationInputReaderNo) Read(_ bool) (string, error) {+	return "n\n", nil+}++type MockAppOperationInputReaderYes struct {+}++func (_ MockAppOperationInputReaderYes) Read(_ bool) (string, error) {+	return "y\n", nil+}++func ExampleAppOperation_run_delete_no_confirm_output() {+	client := &MockAppOperationApiClient{}+	oper := NewAppOperation("asd", Delete, true, client, nil /* because it doesnt matter */)++	oper.run()

I thought that if the function name started with a lowercase letter, it is a private function.

davidsiaw

comment created time in 9 days

Pull request review commentdegica/barcelona-cli

More testing

+package operations++import (+	"fmt"+	"io"++	"encoding/json"++	"github.com/degica/barcelona-cli/api"+	"github.com/degica/barcelona-cli/utils"+)++type AppOperationApiClient interface {+	Get(path string, body io.Reader) ([]byte, error)+	Delete(path string, body io.Reader) ([]byte, error)+}++type AppOperation struct {+	name         string+	optype       OperationType+	no_confirm   bool+	client       AppOperationApiClient+	input_reader utils.UserInputReader+}++func NewAppOperation(name string, optype OperationType, no_confirm bool, client AppOperationApiClient, input_reader utils.UserInputReader) *AppOperation {+	return &AppOperation{+		name:         name,+		optype:       optype,+		no_confirm:   no_confirm,+		client:       client,+		input_reader: input_reader,+	}+}++func app_delete(oper AppOperation) *runResult {+	fmt.Printf("You are attempting to delete %s\n", oper.name)+	if !oper.no_confirm && !utils.AreYouSure("This operation cannot be undone. Are you sure?", oper.input_reader) {+		return nil+	}++	_, err := oper.client.Delete("/heritages/"+oper.name, nil)+	if err != nil {+		return error_result(err.Error())+	}+	fmt.Printf("Deleted %s\n", oper.name)++	return ok_result()+}++func app_show(oper AppOperation) *runResult {+	resp, err := oper.client.Get("/heritages/"+oper.name, nil)+	if err != nil {+		return error_result(err.Error())+	}+	var hResp api.HeritageResponse+	err = json.Unmarshal(resp, &hResp)+	if err != nil {+		return error_result(err.Error())+	}+	if hResp.Heritage == nil {+		return error_result("No such heritage")+	}+	hResp.Heritage.Print()++	return ok_result()+}++func (oper AppOperation) run() *runResult {

Is this should be pointer receiver? it is because you donot update AppOperation here?

davidsiaw

comment created time in 9 days

Pull request review commentdegica/barcelona-cli

More testing

+package utils++import (+	"bufio"+	"fmt"+	"os"+	"strings"+	"syscall"++	"golang.org/x/crypto/ssh/terminal"+)++type UserInputReader interface {+	Read(secret bool) (string, error)+}++type StdinInputReader struct{}++func NewStdinInputReader() *StdinInputReader {+	return &StdinInputReader{}+}++func (reader StdinInputReader) Read(secret bool) (string, error) {+	if secret {+		bytePassword, err := terminal.ReadPassword(int(syscall.Stdin))+		if err != nil {+			return "", err+		}+		response := string(bytePassword)+		return response, nil++	} else {

Do you need else here? It seems like if you are inside if, it return value

davidsiaw

comment created time in 9 days

Pull request review commentdegica/barcelona-cli

More testing

+package operations++import (+	"fmt"+	"io"++	"encoding/json"++	"github.com/degica/barcelona-cli/api"+	"github.com/degica/barcelona-cli/utils"+)++type AppOperationApiClient interface {+	Get(path string, body io.Reader) ([]byte, error)+	Delete(path string, body io.Reader) ([]byte, error)+}++type AppOperation struct {+	name         string+	optype       OperationType+	no_confirm   bool+	client       AppOperationApiClient+	input_reader utils.UserInputReader+}++func NewAppOperation(name string, optype OperationType, no_confirm bool, client AppOperationApiClient, input_reader utils.UserInputReader) *AppOperation {+	return &AppOperation{+		name:         name,+		optype:       optype,+		no_confirm:   no_confirm,+		client:       client,+		input_reader: input_reader,+	}+}++func app_delete(oper AppOperation) *runResult {

This is hard for me to understand what oper means. operation is more descriptive

davidsiaw

comment created time in 9 days

Pull request review commentdegica/barcelona-cli

More testing

+package operations++import (+	"fmt"+	"io"++	"encoding/json"++	"github.com/degica/barcelona-cli/api"+	"github.com/degica/barcelona-cli/utils"+)++type AppOperationApiClient interface {+	Get(path string, body io.Reader) ([]byte, error)+	Delete(path string, body io.Reader) ([]byte, error)+}++type AppOperation struct {+	name         string+	optype       OperationType

I think this should be called as op_type or operation_type

davidsiaw

comment created time in 9 days

PullRequestReviewEvent
PullRequestReviewEvent

startedbayard-search/bayard

started time in 12 days

push eventdegica/barcelona

James Dunn

commit sha 2f837c844a18f18d1a0b055b1ed2d272897cf63d

allow underscores to be passed as review app subject

view details

Yuki Osaki

commit sha 1417b77994c0bde14f2f49a221044d576c932edd

Merge pull request #603 from degica/allow_underscore_subject_review_app Allow underscores to be passed in as review app subject

view details

push time in 17 days

PR merged degica/barcelona

Reviewers
Allow underscores to be passed in as review app subject

This is kind of a selfish PR, but I tend to use snake_case naming scheme for git branch names which does not pass the review app subject validation.

Underscores aren't legal characters in subdomains, so in this PR we check the subject for them and convert to hyphens if necessary.

Feel free to reject if handling underscores is deemed unnecessary

+37 -4

3 comments

2 changed files

jdgc

pr closed time in 17 days

pull request commentdegica/barcelona

Allow underscores to be passed in as review app subject

LGTM!

jdgc

comment created time in 17 days

startedkoekeishiya/yabai

started time in 19 days

startedsimnalamburt/vim-mundo

started time in a month

issue openedChristianChiarulli/nvim

Cannot edit file in lazygit

When I open the lazygit and I get an error when I press the e button on a change file. I am using mac os image

created time in a month

issue commentAPZelos/blamer.nvim

let g:blamer_enabled = 1 not working

never mind. it seems work now 🙏

Yuuki77

comment created time in a month

issue closedAPZelos/blamer.nvim

let g:blamer_enabled = 1 not working

Thank you for the great plugins When I set let g:blamer_enabled = 1, It will behave strangely. :BlamerToggle seems to work correctly. It might be my setting issue though 😓

closed time in a month

Yuuki77

issue openedAPZelos/blamer.nvim

let g:blamer_enabled = 1 not working

Thank you for the great plugins When I set let g:blamer_enabled = 1, It will behave strangely. :BlamerToggle seems to work correctly. It might be my setting issue though 😓

created time in a month

pull request commentcli/cli

Comment on issues from editor

@vilmibm I am sorry that I missed the help-wanted thing. Yeah Please let me know how this goes 😄 I'd be happy to contribute in any form

Yuuki77

comment created time in a month

push eventYuuki77/cli

Yuki Osaki

commit sha a6bc33681bd14eaa8ca68b581530e9c7342e1245

fix linter issue

view details

push time in a month

PR opened cli/cli

Display url for pr status

I think this is convenient to display url in gh pr status 😄 image

+2 -0

0 comment

1 changed file

pr created time in a month

create barnchYuuki77/cli

branch : feature/dispalyUrl

created branch time in a month

pull request commentcli/cli

Comment on issues from editor

will fix the tests 😓

Yuuki77

comment created time in a month

Pull request review commentcli/cli

Comment on issues from editor

+package comment

will add more tests

Yuuki77

comment created time in a month

PullRequestReviewEvent

PR opened cli/cli

Comment on issues from editor

Fix #517

It is now possible to comment on an issue from the editor.

gh issue comment <url> or <issue number>

How to test

1 . create a issue 2.gh comment issueissue number`` 3 add the body from editor 4 submit the comment 5 test same for url

6 please test if gh comment issue <issue number> -b "your comment"work as well 7. please check if the cancel works as well.

image

This is my first pr to this repo. If you have any comments, please let me know 😄

+340 -0

0 comment

4 changed files

pr created time in a month

create barnchYuuki77/cli

branch : feature/commentIssue

created branch time in a month

create barnchYuuki77/cli

branch : temp

created branch time in a month

fork Yuuki77/cli

GitHub’s official command line tool

https://cli.github.com

fork in a month

startedextrawurst/gitui

started time in a month

pull request commentjesseduffield/lazygit

Support copy file name

@jesseduffield Sorry I missed them. It should be good now 💪

Yuuki77

comment created time in a month

push eventYuuki77/lazygit

Yuki Osaki

commit sha 5cfcb6a0756c64ff05c96af8697b485f5124ccd6

Change the descriptions to lowercase

view details

push time in a month

pull request commentjesseduffield/lazygit

Support copy file name

@jesseduffield Thank you for the review! I just updated it 😄

Yuuki77

comment created time in a month

push eventYuuki77/lazygit

Yuki Osaki

commit sha 4f5e9c5be3361c37c7955d4252ad764a9c3edcf1

Update pkg/i18n/english.go Co-authored-by: Jesse Duffield <jessedduffield@gmail.com>

view details

push time in a month

push eventYuuki77/Vim

renovate[bot]

commit sha 4983b3a20c2c7856fed6bda1852ea8909f5bd0eb

chore(deps): update dependency husky to v4.3.0 (#5170) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

sql-koala

commit sha caa8b6368e7301b22b9690eeed7978f49d52844e

Folding: fix a few bugs & small refactor (#5169) Fixes #5167, fixes #5168

view details

renovate[bot]

commit sha b85eb6eb486abf3df9fc23139edd7730ebb8a353

Update dependency webpack-merge to v5.1.4 (#5172) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 714071ab7502e1468acb19df6df5f0b101e5c66f

Update dependency pretty-quick to v3.0.1 (#5174) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 374d21c8d8672fc7d4e5ebd003772ec49e33e4a3

Update dependency pretty-quick to v3.0.2 (#5175) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Ayman Bagabas

commit sha b348e08bb7021b9ed80f3814ec55dccc086c0fe8

Add support for smartRelativeLine (#5010) Adds support for smartRelativeLine, which toggles VSCode's line numbers between absolute and relative depending on the current mode. Fixes #3020

view details

Risto McIntosh

commit sha f80afd6b8a250da152dc2f1fac863b7dc963295e

Fix key binding typo in README (#5183)

view details

renovate[bot]

commit sha b746f50da66d7d60ca90173b3ddc05962820b670

chore(deps): update dependency prettier to v2.1.2 (#5190) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha a4365a7acbef15ae5900e00e8cb737c2d7a0414c

chore(deps): update dependency webpack to v4.44.2 (#5195) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 7bf96233de0bd8558618be21eb481ebf90694b2f

chore(deps): update dependency typescript to v4.0.3 (#5199) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha dad9c847ce59d92e1507c56cae585a5e25f206d3

chore(deps): update dependency ts-loader to v8.0.4 (#5200) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Yuki Osaki

commit sha 3da10e0af18222e3e6d3f00f3dd5ebe831b32904

Merge branch 'master' into feature/hlsearchF

view details

push time in a month

PR opened jesseduffield/lazygit

Support copy file name

Fix #998

You can copy the file nae by clicking ctrl+o in inside of a commit or inside the files panel. This is my first pr to this repo If you have any comments, please let me know 😄

+24 -0

0 comment

3 changed files

pr created time in a month

create barnchYuuki77/lazygit

branch : feature-copy-filename

created branch time in a month

fork Yuuki77/lazygit

simple terminal UI for git commands

fork in a month

startedjesseduffield/lazygit

started time in a month

startedcli/cli

started time in a month

startedMikeMitterer/vue-ts-starter

started time in a month

pull request commentasvetliakov/vscode-neovim

Remove <C-w>gf command

@Shatur95 done! 😄

Yuuki77

comment created time in 2 months

push eventYuuki77/vscode-neovim

Yuki Osaki

commit sha 8bf74f5fcc1b42a070ea650043eec0c4ca0c9bce

map r<C-w>gf to revealDefinitionAside

view details

push time in 2 months

pull request commentasvetliakov/vscode-neovim

Remove <C-w>gf command

Sure let me update it

Yuuki77

comment created time in 2 months

PR opened asvetliakov/vscode-neovim

Remove <C-w>gf command

Currently When you type <C-w>gf, it does not work because editor.action. revealDeclarationAside does not exist in vscode.

image

+1 -3

0 comment

2 changed files

pr created time in 2 months

create barnchYuuki77/vscode-neovim

branch : remove/revealDeclarationAside

created branch time in 2 months

create barnchYuuki77/vscode-neovim

branch : remove/peekDeclaration

created branch time in 2 months

delete branch Yuuki77/vscode-neovim

delete branch : remove/revealDeclarationAside

delete time in 2 months

PR closed asvetliakov/vscode-neovim

Remove <C-w>gf command

Currently When you type <C-w>gf, it does not work because editor.action.peekDeclaration does not exist in vscode.

image

+1 -3

0 comment

2 changed files

Yuuki77

pr closed time in 2 months

PullRequestEvent

PR closed asvetliakov/vscode-neovim

Remove <C-w>gf command

Currently When you type <C-w>gf, it does not work because editor.action.revealDefinitionAside does not exist in vscode.

image

+1 -3

0 comment

2 changed files

Yuuki77

pr closed time in 2 months

PR opened asvetliakov/vscode-neovim

Remove <C-w>gf command

Currently When you type <C-w>gf, it does not work because editor.action.revealDefinitionAside does not exist in vscode.

image

+1 -3

0 comment

2 changed files

pr created time in 2 months

create barnchYuuki77/vscode-neovim

branch : remove/revealDeclarationAside

created branch time in 2 months

fork Yuuki77/vscode-neovim

VSCode Neovim integration

fork in 2 months

startedChristianChiarulli/nvim

started time in 2 months

push eventYuuki77/Vim

Jason

commit sha 691cb7746907bb89263ed0b79431199fadd944a8

Improvements to .vimrc syntax highlighting

view details

Yuki Osaki

commit sha 58b7017eaa9f720c4910cf3e04d257b22647161d

Merge branch 'master' into feature/hlsearchF

view details

push time in 2 months

push eventYuuki77/Vim

Jason Fields

commit sha 3ceaa2f246947a646706e547a22879c9da657261

Refactor: make VimState.recordedMacro nullable (and rename to macro) A macro is being recorded if VimState.macro is not undefined. Most VimStates will never use a macro, so no sense constructing one eagerly.

view details

Jason Fields

commit sha 86a97d53a9449ae97e55d71bd5b77255f28320ca

Make EasyMotion TextEditorDecorationTypes static No need to re-construct these every time a VimState is created

view details

Jason Fields

commit sha 523aca282cbb35bebe2493e1e43cb8c41083f110

Make a handful of Loggers static We were constructing several Loggers (each with a few transport streams) for each VimState. I think these are relatively lightweight, but still - totally unnecessary. Should reduce memory usage a bit.

view details

renovate[bot]

commit sha 131bdf7a632b91b41f6b087e8320b72173d96b31

Update dependency mocha to v8.1.3 (#5155) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha f654eac9bb957d594d37746bec9a80b759fa7561

Update dependency @types/lodash to v4.14.161 (#5157) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 73227d74b97db217e278c2c2b4836399cff1d06b

Update dependency webpack-merge to v5.1.3 (#5159) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 7275183a988759a664a91949587192b6721b2564

Update dependency webpack-stream to v6.1.0 (#5160) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Jason Fields

commit sha 5b89cec1c22c8ea2d0028d75a201c57faac34c2d

vimrc: support for toggling comments

view details

Yuki Osaki

commit sha 391d078fa83d8537417c69a3e9405f4773538c50

Merge branch 'master' into feature/hlsearchF

view details

push time in 2 months

pull request commentVSCodeVim/Vim

Enable to highlight f key searches by a option

@J-Fields 😄

Yuuki77

comment created time in 2 months

push eventYuuki77/Vim

Jason

commit sha fd3ae79d9ab8ee1af59794b00591b7d6e3400a07

Call `closeParameterHints` when exiting insert mode Occasionally the parameter hint popup would "stick" (I'm not totally sure why), but it should close when you leave insert mode, so let's make sure that's done explicitly.

view details

Jason Fields

commit sha b982dbcef55e13d4d4152fc247dbf9eb4539fbdc

Typescript 4.0 adoption: fancy new assignment operators

view details

Jason Fields

commit sha acbd84f1a6714e21704c58148e089c999af9076b

Make `SurroundState.range` a `vscode.Range` Refs #4585

view details

Jason Fields

commit sha 1a55f891c7364ba705654a3dc815d4f36cd8d749

Fix closing parameter hints Tried to do this in fd3ae79d9ab8ee1af59794b00591b7d6e3400a07, but neglected that <Esc> in insert mode is handled by a different action.

view details

Jason Fields

commit sha 9cb685dc5dbb5a2f93a2755da7b44760c242107f

Put a Range instead of two Positions on ReplaceTextTransformation This is a baby step toward #4585. Really, this Range should be a vscode.Range, but let's first bring ReplaceTextTransformation in line with other transformation types.

view details

renovate[bot]

commit sha a8560c5f81600052d931817eeb2895a1bbce322f

Update dependency webpack-stream to v6 (#5154) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Jason Fields

commit sha dfe5e3966cdc46606b06982e41801dd81f216a9f

Remove VimState.registerName This isn't used anywhere; the "active" register is held on RecordedState.

view details

Yuki Osaki

commit sha bcfbc9ba088665a81404818c8a6dc768a67b0d66

Merge branch 'master' into feature/hlsearchF

view details

push time in 2 months

push eventYuuki77/Vim

renovate[bot]

commit sha 64fb187114a5c9ec97dc3f7fd456ea4bc2184c23

Update dependency prettier to v2.1.1 (#5149) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Yuki Osaki

commit sha 1a2c833af96f81aa229a2b0c3f07845937aa0db0

Merge branch 'master' into feature/hlsearchF

view details

push time in 2 months

startedronakg/dotfiles

started time in 2 months

push eventYuuki77/Vim

renovate[bot]

commit sha f802b578a6dfee790abfa699582d473973ca3457

Update dependency typescript to v4 (#5138) https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#whats-new

view details

renovate[bot]

commit sha eff57430e92c0a689312591e4a3f268531efc578

Update dependency pretty-quick to v2.0.2 (#5139) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 7e2fa4731e8e1f88ea1dfb191439ddff0f8f2faf

Update dependency pretty-quick to v3 (#5140) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Jason Fields

commit sha 86d75fcd5eb29324feccf079cf4e160ad94ac130

Surround refactor Surround is one of the ugliest ducklings in the codebase; here's an attempt to make it a bit saner. None of the structure has really changed (yet); most of this is just rearrangement, clean up, comments, etc. Only real behavioral change is a reduction of the number of transformations done from 4 to 2 when deleting or changing a surrounding tag. I'm not sure why it was written as it was, and it still seems to work 🤞

view details

renovate[bot]

commit sha eec9969c60fc186bd46cbaa72b5e3cba5ba5ab2b

Update dependency @types/sinon to v9.0.5 (#5141) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha ee9a2c3cbc994b7e729793d8f226d94bd7d09c38

Update dependency ts-loader to v8.0.3 (#5143) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha bf9f4068944a5df9bf3db69f18ace066c34df359

Update dependency prettier to v2.1.0 (#5144) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 923b0d9cae70ca75191ece13ff329a4d37e29108

Update dependency @types/lodash to v4.14.160 (#5146) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 9beac712fc9c0d62d21dc42582bfd4de50718da1

Update dependency mocha to v8.1.2 (#5148) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Yuki Osaki

commit sha 4c16761c4109275758a42eed110ab579a5108ded

Merge branch 'master' into feature/hlsearchF

view details

push time in 2 months

PullRequestEvent

pull request commentVSCodeVim/Vim

Enable to highlight f key searches by a option

@ronakg @J-Fields Thank you for the feedback I guess This feature would be useful for some users. What do you think? I am going to reopen this pr

Yuuki77

comment created time in 2 months

fork Yuuki77/awesome-streamerrc

Current .vimrc configs for various streamers on Twitch.

fork in 2 months

PR closed VSCodeVim/Vim

Enable to highlight f key searches by a option

<!-- Yay! Thanks for sending us a PR! 🎊

Please ensure your PR adheres to:

  • [ ] Commit messages has a short & issue references when necessary
  • [ ] Each commit does a logical chunk of work.
  • [ ] It builds and tests pass (e.g gulp) -->

What this PR does / why we need it:

Often when I'm using f to search for characters in the current line, I'll run into more occurrences of the character than I expected so highlighting each search match would be nice.

Therefore I added an option called hlsearchF

Which issue(s) this PR fixes No <!-- Commits in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged) -->

Special notes for your reviewer:

  • When you test it, please Vim: Sneak Replaces F to false. Ideally it works with Sneak search.
  • This Also, the highlighted characters will be the characters between the beginning and the end of the line, ignoring the current cursor position. This means that the result will be the same as a search from the beginning of the line.
  • This changes the kind of behaviour of f command. I though this is convenient, but if you disagree, I can start the search from where the current cursor position is at on the line

This is my first pr to VSCodeVim so If you have any suggestions, please let me know

Aug-01-2020 01-52-59

+124 -10

3 comments

7 changed files

Yuuki77

pr closed time in 2 months

pull request commentVSCodeVim/Vim

Enable to highlight f key searches by a option

@J-Fields Thanks I did now know there is a pr for Sneak highlighting. Most users use Sneak highlighting, so that's better! I am going to close this pr.

Yuuki77

comment created time in 2 months

pull request commentVSCodeVim/Vim

Enable to highlight f key searches by a option

@J-Fields What do you think about this feature? I would love to hear your opinion 😄

Yuuki77

comment created time in 2 months

push eventYuuki77/Vim

renovate[bot]

commit sha f103a1c0c0e7d374a255670b205f17258b975ea0

Update dependency webpack-merge to v5.1.2 (#5135) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Yuki Osaki

commit sha c94b23067184071ec5c6569331ec9f91e236a2ec

Merge branch 'master' into feature/hlsearchF

view details

push time in 2 months

push eventYuuki77/Vim

Jason Fields

commit sha c7e5ca2435ad85fd7db32caa23ec02102af1b434

Sort registers properly in `:reg[isters]` command

view details

Jason Fields

commit sha b1f5d95ed7a8dabb20fb5c48c2e948e2f625e880

Refactor: stop passing VimState around in ModeHandler This is entirely unnecessary, as each ModeHandler only ever deals with a single VimState, and that's `this.vimState`, which is never re-assigned. Baby step toward #4698

view details

renovate[bot]

commit sha 066075a43b49d213bc3ec0386c6cf7e8b595036e

Update dependency @types/mocha to v8.0.3 (#5132) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Jason Fields

commit sha 41dbba15b7dd97185917b4c78261b71c3304d9ad

Refactor: stop returning VimState from actions We ALWAYS mutate VimState, we never make a new one in an Action, so returning the parameter back to ModeHandler is useless noise. Refs #4698

view details

Yuki Osaki

commit sha c26f04a64a7cfdb3ccaa4c75631f6d5b3ee94267

Merge branch 'master' into feature/hlsearchF

view details

push time in 2 months

push eventYuuki77/Vim

Jason

commit sha 2254e8e9f65930c405e9019c121da3afdd06de0e

Merge Register.get() and Register.getByKey() Just a small refactor to simplify the register API slightly

view details

berknam

commit sha 91ca71f8607458c0558f9aff61e230c6917d4b51

Overhaul remapping logic (#4735) This is a pretty massive change; see pull request #4735 for full details Most notably: - Support for operator-pending mode, including remaps and a half-cursor decoration - Correct handling of ambiguous remaps with timeout - Correct handling of recursive special case when the RHS starts with the LHS - Correct handling of multi-key remaps in insert mode - Failed movements that occur partway through a remap stop & discard the rest of the remap - Implement `unmap` and `mapclear` in .vimrc Refs #463, refs #4908 Fixes #1261, fixes #1398, fixes #1579, fixes #1821, fixes #1835 Fixes #1870, fixes #1883, fixes #2041, fixes #2234, fixes #2466 Fixes #2897, fixes #2955, fixes #2975, fixes #3082, fixes #3086 Fixes #3171, fixes #3373, fixes #3413, fixes #3742, fixes #3768 Fixes #3988, fixes #4057, fixes #4118, fixes #4236, fixes #4353 Fixes #4464, fixes #4530, fixes #4532, fixes #4563, fixes #4674 Fixes #4756, fixes #4883, fixes #4928, fixes #4991, fixes #5016 Fixes #5057, fixes #5067, fixes #5084, fixes #5125

view details

Jason

commit sha 84e3e722b3dce1f6163f01655d5c881aa11c06e9

Better error handling when a register has no value Register.get() will now return undefined when the given register has no value, which lets us throw E353, etc.

view details

Jason

commit sha 605064d91ae849cfbb8b5d60095debc02a1a2fe3

Save registers (except for macros) across sessions Fixes #4704

view details

Yuki Osaki

commit sha dbc6d9955cf2cbba1e759b69c46bd7e48d3537ad

Merge branch 'master' into feature/hlsearchF

view details

push time in 2 months

push eventYuuki77/Vim

Jason Fields

commit sha 7e88c8485b0b8d45a312fbaa8013a280307ae105

A bit of cleanup to 'put' commands I may end up writing this from scratch rather than trying to salvage the existing code, but this attempt at making it slightly more legible should be useful regardless.

view details

Jason Fields

commit sha c3d6e13e8c5f4a21cfd58dfeda72a93e1d9de3cf

Remove BaseAction.isOperator This seems to be an unused relic, good riddance.

view details

Jason Fields

commit sha 7522ec79cf57380dd0e6c78c70b78527a3c8e016

Make BaseOperator abstract

view details

Jason Fields

commit sha e2ce8865f8631227cc645f012a9623ca32fe49a6

Get rid of Actions class, in favor of directly exporting getRelevantAction() Refs #4429

view details

Jason Fields

commit sha 3ed96eccf2ab94f8ba02ba5ea05dd4a45c065121

Make BaseAction abstract

view details

Jason Fields

commit sha ac9c4059017c26903a2900105b01cfeea9598dbd

Remove a bunch of type assertions, enable tslint rule disallowing unnecessary type assertions

view details

Jason Fields

commit sha b74ccf6244e4da4f152812e72f9a8771dbf8473d

A bit of cleanup in jump tracking logic

view details

J.R. Maingat

commit sha e0da682ac0b9ba3e94a48e7be4371e96de14a42a

Fix :p[ut] command neovim capability and subparser (#5063) Enables neovim capability and fixes arg parsing for the `:p[ut]` command. Apparently the put command allows no whitespace between the command name and the register name, so commands like `:put"` are perfectly valid. I've added some subparser tests to document this. Fixes #5052 Fixes #5090

view details

Yuki Osaki

commit sha f64a0516072633b88d2ebd94cda40df2015efa8c

Merge branch 'master' into feature/hlsearchF

view details

push time in 2 months

push eventYuuki77/Vim

berknam

commit sha 3879f4374b57e570ccbbe95e1853ae5c0b392a6a

Change easymotion default decorations (#5108) - Make easymotion default decorations have the same defaults as the Vim plugin. - Deprecate no longer needed configurations like 'easymotionMarkerMargin' and 'easymotionMarkerWidthPerChar'. - Change 'easymotionMarkerFontWeight' default to 'bold' - Add seperate color for each character of two-character markers, default values are the same as the Vim plugin. (two different yellows) - Add color for dimmed characters, default value is the same as the Vim plugin. (grey) - Add color for higlighting characters searched with search n-characters command, default value is the same as the Vim plugin. (green) - Add changes to README file and update the default values. - Change easymotion TextEditorDecorations to make them simpler to use and understand. Remove all unnecessary parts. - Fix the dimming zones that were including the markers as well. - Fix the hack for two consecutive markers that wasn't checking if those markers were on the same line. Fixes #5092 Fixes #5022 Fixes #4252 Fixes #1746

view details

renovate[bot]

commit sha c0a8e7e9e4426cfd9d5cb636dfdf3b69b0cc7874

Update dependency sinon to v9.0.3 (#5121) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 7227749c34cd738e02ed054a67033139b196c754

Update dependency @types/mocha to v8.0.2 (#5120) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Jason Fields

commit sha 897af3e0392602fef63a5171bfdc73d046d242cc

Lift error handling logic into taskQueue After all, not all errors happen when running an Action

view details

Jason Fields

commit sha 50edf6422a094dcf0c36b3f22a110c2e152b0d5f

Fix error when file is shortened by an external program This solution isn't perfect (see TODO), but it does improve matters. Fixes #5086

view details

Jason Fields

commit sha 1b39f67081feb1985176c51479fc2d29a119421a

Move `BaseCommand` from actions.ts to base.ts That's surely where it belongs, and in general, I'd like to split actions.ts up.

view details

Jason Fields

commit sha 36ce7f6db97a0751c72e4621be60e5be2e4cc6c2

Move put commands (p, P, gp, gP, ]p, [p) into their own file

view details

Jason Fields

commit sha 43e0912dee9ea328335cf313d0107dcf1af69768

Add `[P` and `]P` as aliases for `[p`

view details

Yuki Osaki

commit sha cfd578403ca7bdd527b7d2d76fdc5366c6daea94

Merge branch 'master' into feature/hlsearchF

view details

push time in 3 months

startedjunegunn/fzf

started time in 3 months

push eventYuuki77/Vim

Jason Fields

commit sha bc5f3e067996441666a18454ae0dc92cdf139b8b

Maintain visual selection after failed movement Fixes #4512

view details

renovate[bot]

commit sha 438d1ffe4641f07b191e4869cff1332c75ae2750

Update dependency mocha to v8.1.1 (#5112) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Jason Fields

commit sha 6bc75a7560507e1d632f5f2c1fd8266c49b27c6a

Add button to error popup to automatically report issue (with stack trace!) This should hopefully make those mysterious "Failed to handle key" bugs easier to understand and fix, since we'll at least know what the stack looked like.

view details

renovate[bot]

commit sha 178ffb3ef0136659c64799052737a8e2ef70f0ee

Update dependency @types/lodash to v4.14.159 (#5114) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Jason Fields

commit sha 59b8d3115cb85d0992b920218f0efd9840484874

Enable `--resolveJsonModule` to get type safety on package.json import

view details

Jason Fields

commit sha ff37d589cc668d12a6b23ae04f0b3707917c67e1

Refactor register code by using a Map Even after this commit, our handling of registers is horrendously over-complicated and inconsistent, but this is a definite step in the right direction.

view details

Yuki Osaki

commit sha 8b7816ba39a0ca890fd700c349247fced887432d

Merge branch 'master' into feature/hlsearchF

view details

push time in 3 months

push eventYuuki77/Vim

renovate[bot]

commit sha b2772dc527600f2a63e7ffbeeef2a4e5db08dd30

Update dependency ts-loader to v8.0.2 (#5101) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 3242adecb9c08a351a6f851ae881c98e10158ec2

Update dependency webpack-merge to v5.1.0 (#5107) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha f525b61d25e4f5684597c114c9a71f76ec618eff

Update dependency webpack-merge to v5.1.1 (#5110) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Yuki Osaki

commit sha f431a46450af67bb18e31eeb8491d0bdd4aeea47

Merge branch 'master' into feature/hlsearchF

view details

push time in 3 months

push eventYuuki77/Vim

renovate[bot]

commit sha 6ecbac83e0d5151b73ce6ff622df872afe27f48a

Update dependency tslint to v6.1.3 (#5096) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 6e7492e3ab4ff724af7fe60158e14f58cdb2a32b

Update dependency @types/mocha to v8.0.1 (#5099) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Yuki Osaki

commit sha 99ebce1cb23a4e0fa4148136cf2c06928a795b07

Merge branch 'master' into feature/hlsearchF

view details

push time in 3 months

push eventYuuki77/Vim

Yuki Osaki

commit sha 61f3d72c8002c50de186ccff7c2abaeefde9daab

Add hlsearchF option * If this option is enabled, the f command will highlight the characters in a search * This Also, the highlighted characters will be the characters between the beginning and the end of the line, ignoring the current curser position. This means that the result will be the same as a search from the beginning of the line.

view details

Yuki Osaki

commit sha 935efef881ee3f1e28cbdc5f1a0a3239517cbbb0

Add test

view details

push time in 3 months

push eventYuuki77/Vim

Yuki Osaki

commit sha b48916d52c384a6d39d316973a75f57a0192a9a7

Add unit tests for hlsearchF options

view details

push time in 3 months

push eventYuuki77/Vim

Yuki Osaki

commit sha e717054f5f1b64e5bd7857a039ae75df395f4be9

Add unit tests for hlsearchF options

view details

push time in 3 months

push eventYuuki77/Vim

Yuki Osaki

commit sha 9be733284e61061b30ee2a2c4774f300bd360aa2

Add unit tests for hlsearchF options

view details

push time in 3 months

push eventYuuki77/Vim

Yuki Osaki

commit sha a811f2373d250fc95d5711b57eb39f215bc7e760

Add unit tests for hlsearchF options

view details

push time in 3 months

PR opened VSCodeVim/Vim

Highlight f key searches as a option

<!-- Yay! Thanks for sending us a PR! 🎊

Please ensure your PR adheres to:

  • [ ] Commit messages has a short & issue references when necessary
  • [ ] Each commit does a logical chunk of work.
  • [ ] It builds and tests pass (e.g gulp) -->

What this PR does / why we need it: Often when I'm using f to search for characters in the current line, I'll run into more occurrences of the character than I expected so highlighting each search match would be nice.

Therefor I added an option called hlsearchF

Which issue(s) this PR fixes No <!-- Commits in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged) -->

Special notes for your reviewer:

  • When you test it, please Vim: Sneak Replaces F to false. Ideally it works with Sneak search.
  • This Also, the highlighted characters will be the characters between the beginning and the end of the line, ignoring the current curser position. This means that the result will be the same as a search from the beginning of the line.
  • This kind of changes the behaviour of f command. I though this is convenient, but you disagree. I can start the search from where you are at on the line

This is my first pr to VSCodeVim so If you have any suggestions, please let me know

+127 -11

0 comment

7 changed files

pr created time in 3 months

push eventYuuki77/Vim

Yuki Osaki

commit sha 4fabd9efd55e58c3f87f96916a167a5198ab4f81

Add hlsearchF option * If this option is enabled, the f command will highlight the characters in a search * This Also, the highlighted characters will be the characters between the beginning and the end of the line, ignoring the current curser position. This means that the result will be the same as a search from the beginning of the line.

view details

Yuki Osaki

commit sha 568068575bcc20a7f6402e183da9fcb9274e60ff

Add unit tests for hlsearchF options

view details

push time in 3 months

push eventYuuki77/Vim

Yuki Osaki

commit sha 3e73c93c16620670ecd7975e330a552cca157405

Add hlsearchF option * If this option is enabled, the f command will highlight the characters in a search * This Also, the highlighted characters will be the characters between the beginning and the end of the line, ignoring the current curser position. This means that the result will be the same as a search from the beginning of the line.

view details

push time in 3 months

create barnchYuuki77/Vim

branch : feature/hlsearchF

created branch time in 3 months

more