profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/Yajo/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

copier-org/copier 371

Library and command-line utility for rendering projects templates.

OCA/oca-addons-repo-template 13

OCA Repository Template

Antiun/odoo 1

Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.

Yajo/doodba-devel 1

Personal Doodba-based development environment (use as an example for yours if you want, but this is forever-WIP repo)

Tecnativa/event 0

Event Management addons

Yajo/account-closing 0

Odoo Accountant closing tools

Yajo/ansible 0

Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/

issue commentmicrosoft/vscode-python

Slow virtualenv activation in terminal

I use fish and the same problem happens.

Yajo

comment created time in 11 hours

pull request commentOCA/event

[ADD] sale_crm_event_reservation: sell events like a boss

Ready to review.

Yajo

comment created time in 17 hours

push eventcopier-org/copier

Timothée Mazzucotelli

commit sha 98a41a6a65b9c5d559eba633688dd5c567b940c6

docs: Tell about creating the venv in the project

view details

push time in 19 hours

PR merged copier-org/copier

docs: Tell about creating the venv in the project

Fixes #154

The docs tell the user to run poetry config virtualenvs.in-project true --local, which will create a poetry.toml file, which is why we ignore it in .gitignore. If you believe the file should be tracked instead, let me know, though I'd probably argue against.

+4 -0

1 comment

2 changed files

pawamoy

pr closed time in 19 hours

issue closedcopier-org/copier

Update CONTRIBUTING.md

Once the dev setup has stabilized it will be time to reflect the changes back into the dev docs: CONTRIBUTING.md.

See also: #129 #132

closed time in 19 hours

pykong
PullRequestReviewEvent

Pull request review commentcopier-org/copier

fix: Fix unicode error on binary files

 def _render_file(self, src_abspath: Path) -> None:         if dst_relpath is None:             return         if src_abspath.name.endswith(self.template.templates_suffix):-            tpl = self.jinja_env.get_template(str(src_relpath))-            new_content = tpl.render(**self._render_context()).encode()+            try:+                tpl = self.jinja_env.get_template(src_relpath)+            except UnicodeDecodeError:+                if self.template.templates_suffix:+                    # suffix is not emtpy, re-raise+                    raise+                # suffix is empty, fallback to copy+                print(+                    colors.warn+                    | f"{src_relpath} could not be read as a Jinja2 template, falling back to a simple copy",+                    file=sys.stderr,+                )

I prefer to silent this.

A warning printed to the user might make him think he did something wrong, while the template was working as expected.

It's better to add such warning in the template creation docs. Maybe under the docs for templates_suffix.

pawamoy

comment created time in 19 hours

PullRequestReviewEvent
PullRequestReviewEvent

issue commentcopier-org/copier

bug: _templates_suffix: "" gives UnicodeDecodeError on binary files ( .ico or .png for example )

I prefer to keep it simple, consistent and straightforward.

If you really care about what files are templated and what files not, then use a suffix. It's more predictable and easier to understand, and you don't have the load of going to the copier.yaml file, reading the specific configuration, and even interpreting the ignore patterns to know why/if a certain file will be a template or not.

karolzlot

comment created time in 19 hours

PullRequestReviewEvent

Pull request review commentOCA/social

[14.0][MIG] mass_mailing_custom_unsubscribe: Migration to 14.0

+/* Copyright 2016 Jairo Llopis <jairo.llopis@tecnativa.com>+ * License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl). */++/* This JS module replaces core AJAX submission because it is impossible+ * to extend it as it is currently designed. It is almost a copy+paste from+ * upstream, to allow easier version/patch updates, so linter is disabled+ * and prettier is ignore. */

@Tardo I'll mark as resolved some of your comments because of what is explained here (btw @pedrobaeza you can see the comment is already in place).

ernestotejeda

comment created time in 20 hours

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentOCA/oca-addons-repo-template

[ADD] Automatic PR / Issue stale workflow

To me this is ready to merge (squashing). @sbidoul I'd like to see your approval here.

ivantodorovich

comment created time in 20 hours

pull request commentOCA/oca-addons-repo-template

Test with GitHub actions

Can you please fix the conflicts before reviewing?

sbidoul

comment created time in 20 hours

PR opened OCA/calendar

[FIX] resource_booking: suggest involved partners as followers

Includes those coming from requester and from resource combination.

+55 -1

0 comment

2 changed files

pr created time in 20 hours

create barnchTecnativa/calendar

branch : 13.0-resource_booking-suggest_followers

created branch time in 20 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentcopier-org/copier

fix: Fix unicode error on binary files

 def _render_file(self, src_abspath: Path) -> None:         if dst_relpath is None:             return         if src_abspath.name.endswith(self.template.templates_suffix):-            tpl = self.jinja_env.get_template(str(src_relpath))-            new_content = tpl.render(**self._render_context()).encode()+            try:+                tpl = self.jinja_env.get_template(src_relpath)+            except UnicodeDecodeError:+                if self.template.templates_suffix:+                    # suffix is not emtpy, re-raise+                    print(+                        colors.warn+                        | f"{src_relpath} could not be read as a Jinja2 template, falling back to a simply copy",+                        file=sys.stderr,+                    )

In this case the message is a lie, so just remove it and let the exception raise. The designer deliberately added .jinja to a binary file, and that's a bug on his side.

pawamoy

comment created time in a day

issue commentcopier-org/copier

bug: _templates_suffix: "" gives UnicodeDecodeError on binary files ( .ico or .png for example )

I don't want to support the copy without render setting because you can just use the templates suffix for that. There's no need to have 2 ways of doing things IMHO.

karolzlot

comment created time in a day

delete branch Tecnativa/calendar

delete branch : 13.0-resource_booking-autoconfirm

delete time in 4 days

push eventTecnativa/calendar

Jairo Llopis

commit sha a0294fe7176514ca8460e5520ef5b8d8ff281401

[IMP] resource_booking: add organizer This allows better filtering while in the normal calendar view. By default, the organizer will be whoever created the booking. Calendar invitations will go out in his name. Also, avoid sending calendar event modification notifications if the modification isn't the schedule. @Tecnativa TT31240

view details

push time in 4 days

PR opened OCA/calendar

[IMP] resource_booking: add organizer

This allows better filtering while in the normal calendar view.

By default, the organizer will be whoever created the booking. Calendar invitations will go out in his name.

Also, avoid sending calendar event modification notifications if the modification isn't the schedule.

@Tecnativa TT31240

+55 -4

0 comment

3 changed files

pr created time in 4 days

create barnchTecnativa/calendar

branch : 13.0-resource_booking-imp_organizer

created branch time in 4 days

delete branch Tecnativa/calendar

delete branch : 13.0-resource_booking-imp_rb_autoselect_text

delete time in 4 days

pull request commentOCA/calendar

[IMP] resource_booking: improve auto-assignment readability

/ocabot merge patch

Yajo

comment created time in 4 days

PR opened OCA/calendar

[IMP] resource_booking: improve auto-assignment readability

https://user-images.githubusercontent.com/973709/127641282-6586bad6-830d-4acd-a5c4-92faf39837a7.mp4

@Tecnativa TT31239

+10 -1

0 comment

1 changed file

pr created time in 4 days