profile
viewpoint
Lukas Wirth Veykril Germany https://veykril.github.io/ CompSci student at the University of Paderborn.

Veykril/blend2d-rs 18

Blend2D Bindings for Rust

Veykril/cubism-rs 18

A rust wrapper around the Live2D Cubism SDK with extra functionality

Veykril/crab-claw 6

A mesh slicing library written in rust

Veykril/blender-sro-plugin 5

A Silkroad Resource Import Addon for Blender

Veykril/imgui-dx9-renderer 5

A directx9 renderer for imgui-rs

Veykril/GFXFileManager 3

A Joymax File Manager Wrapper written in Rust

Veykril/base65536-python 2

base65536 implementation written in python

Veykril/DestinyChildBot 2

A Destiny Child Bot For Discord

Veykril/d3d11-glyph 1

A d3d11 renderer for https://github.com/alexheretic/glyph-brush/tree/master/glyph-brush

startedjdan/compiler.lean

started time in an hour

issue commentrust-analyzer/rust-analyzer

Analysis randomly stops before finishing files

This error only seems to happen when my toolchain is set to the nightly branch. On stable, there is no issue. So I rolled back my nightly rust version night by night until I found a version where this error did not appear. The last working version for me is nightly-2020-10-26-x86_64-unknown-linux-gnu - rustc 1.49.0-nightly (4760b8fb8 2020-10-25)

noxabellus

comment created time in an hour

pull request commentrust-analyzer/rust-analyzer

add new assist to change visibility of all struct fields

I just wrote this because it was painful for me and after talking with other rustacean it seems I'm not the only one but yes you know... always hard to know if it could fit also for other people

bnjjj

comment created time in 2 hours

issue commentrust-analyzer/rust-analyzer

Analysis randomly stops before finishing files

I have just tried rolling my version back up to a few months ago and it doesn't resolve the issue, though I wasn't having this problem last week. I'm guessing this is something to do with updating rust itself and not the extension/server

noxabellus

comment created time in 2 hours

issue openedrust-analyzer/rust-analyzer

Analysis randomly stops before finishing files

In the latest stable release of the extension, I am getting random failures of analysis. The analysis appears to stop before processing all of the items in a file. As shown here, a function at the bottom of my file has no information available, while the same types and information are available for the function right above it. rust-analyzer-fail

created time in 2 hours

startedvarkor/quiver

started time in 2 hours

push eventrust-analyzer/rust-analyzer

bors[bot]

commit sha dfba633aa017e42d1d6fa4113d654c12e706873d

deploy: ac30710ada112984c9cf79c4af39ad666d000171

view details

push time in 2 hours

PR merged rust-analyzer/rust-analyzer

Support self in reference search

The approach here is simply checking the descendants of the function body for PathExpr then checking whether it only contains a single self PathSegment, this is to prevent us from picking up self tokens from local UseTrees.

+103 -1

2 comments

2 changed files

Veykril

pr closed time in 2 hours

push eventrust-analyzer/rust-analyzer

Lukas Wirth

commit sha de4ada22d484950a6f416f25c85566ea9d1830a9

Support self in reference search

view details

bors[bot]

commit sha ac30710ada112984c9cf79c4af39ad666d000171

Merge #6665 6665: Support self in reference search r=matklad a=Veykril The approach here is simply checking the descendants of the function body for `PathExpr` then checking whether it only contains a single `self` `PathSegment`, this is to prevent us from picking up `self` tokens from local `UseTree`s. Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

view details

push time in 2 hours

startedwithoutboats/notty

started time in 2 hours

issue openedrust-analyzer/rust-analyzer

[Question] Find types that implement given trait

Hi guys. Thanks for rust-analyzer, it is awesome!

Is it possible to show all types that implement a trait(when a cursor is located on a trait)?

I found this, but it is not clear whether this is implemented or not. https://github.com/rust-analyzer/rust-analyzer/issues/620

Thanks

created time in 2 hours

delete branch rust-analyzer/rust-analyzer

delete branch : staging.tmp

delete time in 2 hours

push eventrust-analyzer/rust-analyzer

Lukas Wirth

commit sha de4ada22d484950a6f416f25c85566ea9d1830a9

Support self in reference search

view details

bors[bot]

commit sha ac30710ada112984c9cf79c4af39ad666d000171

Merge #6665 6665: Support self in reference search r=matklad a=Veykril The approach here is simply checking the descendants of the function body for `PathExpr` then checking whether it only contains a single `self` `PathSegment`, this is to prevent us from picking up `self` tokens from local `UseTree`s. Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

view details

push time in 2 hours

push eventrust-analyzer/rust-analyzer

Lukas Wirth

commit sha de4ada22d484950a6f416f25c85566ea9d1830a9

Support self in reference search

view details

bors[bot]

commit sha 66f33f0358bd8b779229bb955ac6b3e45c32128c

[ci skip][skip ci][skip netlify] -bors-staging-tmp-6665

view details

push time in 2 hours

create barnchrust-analyzer/rust-analyzer

branch : staging.tmp

created branch time in 2 hours

push eventrust-analyzer/rust-analyzer

bors[bot]

commit sha a0bc026cf5b7e9ea8111f8600b593cbd0d3719c8

deploy: 25ebcca224dc220c0439d9c82c6ef5ffa131c409

view details

push time in 3 hours

PR merged rust-analyzer/rust-analyzer

Add attribute highlight modifier to all tokens inside attributes

This has the side effect that we also emit attribute.attribute highlights now, as in, the tokens that get the attribute semantic type also get the attribute modifier. I personally don't think it's really a problem but maybe it is to some? It's just that it was really simple to implement it this way, which is why I just went this route for now.

Fixes #6536

+23 -10

4 comments

4 changed files

Veykril

pr closed time in 3 hours

push eventrust-analyzer/rust-analyzer

Lukas Wirth

commit sha 1f87a4198956fd3a8b57d01c2bce19481fe2c610

Add attribute highlight modifier to all tokens inside attributes

view details

bors[bot]

commit sha 25ebcca224dc220c0439d9c82c6ef5ffa131c409

Merge #6599 6599: Add attribute highlight modifier to all tokens inside attributes r=matklad a=Veykril This has the side effect that we also emit `attribute.attribute` highlights now, as in, the tokens that get the attribute semantic type also get the attribute modifier. I personally don't think it's really a problem but maybe it is to some? It's just that it was really simple to implement it this way, which is why I just went this route for now. Fixes #6536 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

view details

push time in 3 hours

issue closedrust-analyzer/rust-analyzer

Semantic Highlighting: Some tokens within rust attributes are missing "attribute" modifier.

I'm loving the Semantic Highlighting feature, but it makes quite a mess of (macro/derive/etc) attributes. I suspect reliable highlighting within attributes is not feasible, but at least marking all encompassed tokens with the "attribute" modifier would allow users to override the colors of the worst offenders. (e.g. through configuring "*.attribute" : "#XXXXXX" color settings)

An example featuring attributes from the smart-default crate:

example

This crate allows specifying default values with arbitrary expressions passed via attributes. With Semantic Hightlighting enabled there are numerous problems with the token handling of said expressions. For one, enums/operators/structs/etc are not recognized at all. For other token types, such as number/punctuation, they do not receive the "attribute" modifier, and thus are not contextually-customizable.

Another example from the native-windows-gui crate. nwg

I personally find the random/inconsistent highlighting within attributes to be distracting and unpleasant. If it were possible, on my end I would simply override all attribute token colors with a single value, but without consistent modifier presence it cannot be done.

TL;DR I would love if rust-analyzer's semantic highlighting feature tagged all tokens enclosed within #[...] or #![...] brackets with the "attribute" modifier.

closed time in 3 hours

Greatness7

push eventrust-analyzer/rust-analyzer

Lukas Wirth

commit sha 1f87a4198956fd3a8b57d01c2bce19481fe2c610

Add attribute highlight modifier to all tokens inside attributes

view details

bors[bot]

commit sha 25ebcca224dc220c0439d9c82c6ef5ffa131c409

Merge #6599 6599: Add attribute highlight modifier to all tokens inside attributes r=matklad a=Veykril This has the side effect that we also emit `attribute.attribute` highlights now, as in, the tokens that get the attribute semantic type also get the attribute modifier. I personally don't think it's really a problem but maybe it is to some? It's just that it was really simple to implement it this way, which is why I just went this route for now. Fixes #6536 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

view details

push time in 3 hours

delete branch rust-analyzer/rust-analyzer

delete branch : staging.tmp

delete time in 3 hours

push eventrust-analyzer/rust-analyzer

Lukas Wirth

commit sha 1f87a4198956fd3a8b57d01c2bce19481fe2c610

Add attribute highlight modifier to all tokens inside attributes

view details

bors[bot]

commit sha 9d1132fade24ee3492f177971f8eea4ae3b2d748

[ci skip][skip ci][skip netlify] -bors-staging-tmp-6599

view details

push time in 3 hours

create barnchrust-analyzer/rust-analyzer

branch : staging.tmp

created branch time in 3 hours

push eventrust-analyzer/rust-analyzer

bors[bot]

commit sha 17ce99849e2828e6ccd965cb82ce29fdb397bd96

deploy: f8726d781a971752a6918a20eea10cddca2114ed

view details

push time in 3 hours

push eventrust-analyzer/rust-analyzer

Benjamin Coenen

commit sha 775c69183cd6c7a2a5c9f27e23e4f4b7bc67f06f

add let and letm postfix to turn expressions into variables Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>

view details

Benjamin Coenen

commit sha 474ebd60d1ae1057165e189bb539ba6a410e1d68

add let and letm postfix to turn expressions into variables Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>

view details

bors[bot]

commit sha f8726d781a971752a6918a20eea10cddca2114ed

Merge #6601 6601: add let and letm postfix to turn expressions into variables r=matklad a=bnjjj Partially resolve #6426 Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>

view details

push time in 3 hours

more