Pluralize a word
A repository to make changes to the vscode Wiki on GitHub
A collection of data structures written in JavaScript
A collection of sorting algorithms written in Python.
A collection of sorting algorithms written in JavaScript.
Makes <abbr> element title attributes touch accessible
A collection of code samples from my blog
gwtw/js-interview-questions 39
A collection of interview question answers written in JavaScript
A JavaScript implementation of the Fibonacci heap data structure
A collection of sorting algorithms written in Java.
startedpodrain/podrain
started time in 3 hours
PR opened xtermjs/xterm.js
Fixes #3056.
I guess this needs another breaking change when LinkMatchers are removed, to replace the ILinkMatcherOptions
argument to the WebLinksAddon
constructor with something not referring to LinkMatchers..
pr created time in 5 hours
startedtwitter/TwitterTextEditor
started time in 8 hours
startedtc39/proposal-iterator-helpers
started time in 10 hours
issue commentxtermjs/xterm.js
Errors while building xterm to run demo from git clone
I think my issue was that yarn install didn’t work first time. It went on and on for greater than 30m stuck on puppeteer and failed (most likely chrome failed to download). From then on it was somewhat messed up since not all postInstall scripts ran.
I tried second time after clean node_modules and got to same issue. Then I had to go and mess with the guts to get whatever yarn start needed installed one by one.
comment created time in 14 hours
startedTyriar/vscode-snazzy
started time in 15 hours
issue commentmicrosoft/vscode-wiki
Filename 'Test:-Smoke-Test-Template.md' prevents checkout onto Windows
@Tyriar I'm not yet seeing the rename at https://github.com/microsoft/vscode-wiki
comment created time in 17 hours
startedthatch/python-grammar-changes
started time in a day
issue commentxtermjs/xterm.js
Webgl renderer does not render when writing if a selection exists
Created a PR fixing this if it's of any help
comment created time in a day
PR opened xtermjs/xterm.js
Fixes #3221
Also fixes the following issue:
- Make a selection
- Resize terminal rows or columns
- :bug: Selected text is rendered incorrectly
I chose to behave as the canvas renderer by removing the selection when resizing
pr created time in a day
startedoblador/hush
started time in a day
pull request commentxtermjs/xterm.js
Feature/xterm addon serialize restore layout and cursor
@Tyriar I removed the separate dummy buffer cell in favor of just remember where did the cursor style comes from. And also, the test utility is moved into separate file. (Is it proper to put it in the test directory?)
I am not sure whether there is some edge case that I didn't handle correctly. Probably it needs a fuzz test someday to check whether it will choke on some specified pattern.
comment created time in a day
issue commentxtermjs/xterm.js
mouse clicks don't work in xterm/vscode terminal
I got the demo up after a bunch of trial and error. Confirmed that mouse support does work in demo indeed.
Would love to land it in vscode. Happy to make a PR if this is relatively straight forward.
comment created time in a day
issue closedxtermjs/xterm.js
Errors while building xterm to run demo from git clone
Steps to reproduce
- Clone repo
- Run
yarn
- Run
yarn start
Expected
Demo starts up.
Actual
Takes a a really long time (preferably downloading puppeteer) for 30 mins. Then see this error
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(12,29)
TS2307: Cannot find module '../addons/xterm-addon-attach/out/AttachAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(13,26)
TS2307: Cannot find module '../addons/xterm-addon-fit/out/FitAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(14,45)
TS2307: Cannot find module '../addons/xterm-addon-search/out/SearchAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(15,32)
TS2307: Cannot find module '../addons/xterm-addon-serialize/out/SerializeAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(16,31)
TS2307: Cannot find module '../addons/xterm-addon-web-links/out/WebLinksAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(17,28)
TS2307: Cannot find module '../addons/xterm-addon-webgl/out/WebglAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(18,32)
TS2307: Cannot find module '../addons/xterm-addon-unicode11/out/Unicode11Addon' or its corresponding type declarations.
I have no idea why it's not being built.
xterm.js (master): yarn presetup
yarn run v1.21.1
$ node ./bin/install-addons.js
pulling addon dependencies...
Skipped xterm-addon-attach
Skipped xterm-addon-fit
Skipped xterm-addon-search
Skipped xterm-addon-serialize
Skipped xterm-addon-unicode11
Skipped xterm-addon-web-links
Skipped xterm-addon-webgl
✨ Done in 0.27s.
xterm.js (master) 1s ✔
Install works fine
closed time in a day
nojvekissue commentxtermjs/xterm.js
Errors while building xterm to run demo from git clone
I figured it out. Seems there is another pre-setup that I had to dig out. Need to run yarn install && yarn build && yarn start
.
comment created time in a day
issue openedxtermjs/xterm.js
Errors while building xterm.js from github
Steps to reproduce
- Clone repo
- Run
yarn
- Run
yarn start
Expected
Demo starts up.
Actual
Takes a a really long time (preferably downloading puppeteer) for 30 mins. Then see this error
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(12,29)
TS2307: Cannot find module '../addons/xterm-addon-attach/out/AttachAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(13,26)
TS2307: Cannot find module '../addons/xterm-addon-fit/out/FitAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(14,45)
TS2307: Cannot find module '../addons/xterm-addon-search/out/SearchAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(15,32)
TS2307: Cannot find module '../addons/xterm-addon-serialize/out/SerializeAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(16,31)
TS2307: Cannot find module '../addons/xterm-addon-web-links/out/WebLinksAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(17,28)
TS2307: Cannot find module '../addons/xterm-addon-webgl/out/WebglAddon' or its corresponding type declarations.
ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(18,32)
TS2307: Cannot find module '../addons/xterm-addon-unicode11/out/Unicode11Addon' or its corresponding type declarations.
I have no idea why it's not being built.
xterm.js (master): yarn presetup
yarn run v1.21.1
$ node ./bin/install-addons.js
pulling addon dependencies...
Skipped xterm-addon-attach
Skipped xterm-addon-fit
Skipped xterm-addon-search
Skipped xterm-addon-serialize
Skipped xterm-addon-unicode11
Skipped xterm-addon-web-links
Skipped xterm-addon-webgl
✨ Done in 0.27s.
xterm.js (master) 1s ✔
Install works fine
created time in a day
PR opened xtermjs/xterm.js
Also works with right click select. Fixes #682.
This relies on the fact that before a user (double/right)-clicks a link, the cursor will hover the link, triggering the asynchronous link provider(s). By the time the click event fires, the link provider "should" have done its thing, and the link is used. If not, this falls back to the old behavior. This seemed good enough to me. If it is not, one probably would have to expose some inner state of the linkifier to provide some way to check if there are currently link providers resolving and to wait for them to finish before selecting.
I feel a bit bad about duplicating the magic "-1"s (on both x and y for start, only on y for end) from Linkifier2._fireUnderlineEvent
, but I couldn't think of a good way to extract that logic.
It seems to me to produce the correct results.
pr created time in a day
issue commentxtermjs/xterm.js
I've opened a pr princjef/font-ligatures#22 as the first step to get this done
comment created time in 2 days
startedwowts/tstolua
started time in 2 days
startedelken/doom-modeline-now-playing
started time in 2 days
push eventxtermjs/xterm.js
commit sha d3c9f70bec852b0abf54c177afb80bcef44af30b
replace expect testing with assert
commit sha bee4b0ff06b8efff92a8ad85d63373b411567fcc
Merge branch 'master' into replace_expect_testing
commit sha 28bcd88fb0f7d32c686461dc4594996d1877920e
Merge pull request #3229 from jerch/replace_expect_testing replace expect testing with assert
push time in 2 days
PR merged xtermjs/xterm.js
Only a cleanup PR, but since this bugged me for a while and I have to deal with testing for the async PR anyway, time to replace the uglier expect based testing code with some simple assertion testing.
@Tyriar The replacements only use .equal
, deepEqual
and doesNotThrow
from chai.assert
. Not sure if this could be used to get rid of chai
someday and just use nodejs' assert lib. I remember we once had an issue regarding this, but dont recall why it was not possible in the end (different semantics?)
pr closed time in 2 days
startedapple/swift-http-structured-headers
started time in 2 days
PR opened xtermjs/xterm.js
Only a cleanup PR, but since this bugged me for a while and I have to deal with testing for the async PR anyway, time to replace the uglier expect based testing code with some simple assertion testing.
@Tyriar The replacements only use .equal
, deepEqual
and doesNotThrow
from chai.assert
. Not sure if this could be used to get rid of chai
someday and just use nodej's assert lib. I remember we once has an issue regarding this, but dont recall why it was not possible in the end.
pr created time in 3 days