Fixes #3056.

I guess this needs another breaking change when LinkMatchers are removed, to replace the ILinkMatcherOptions argument to the WebLinksAddon constructor with something not referring to LinkMatchers..

I think my issue was that yarn install didn’t work first time. It went on and on for greater than 30m stuck on puppeteer and failed (most likely chrome failed to download). From then on it was somewhat messed up since not all postInstall scripts ran.

I tried second time after clean node_modules and got to same issue. Then I had to go and mess with the guts to get whatever yarn start needed installed one by one.

@Tyriar I'm not yet seeing the rename at https://github.com/microsoft/vscode-wiki

Created a PR fixing this if it's of any help

Fixes #3221

Also fixes the following issue:

1. Make a selection
2. Resize terminal rows or columns
3. :bug: Selected text is rendered incorrectly

I chose to behave as the canvas renderer by removing the selection when resizing

@Tyriar I removed the separate dummy buffer cell in favor of just remember where did the cursor style comes from. And also, the test utility is moved into separate file. (Is it proper to put it in the test directory?)

I am not sure whether there is some edge case that I didn't handle correctly. Probably it needs a fuzz test someday to check whether it will choke on some specified pattern.

I got the demo up after a bunch of trial and error. Confirmed that mouse support does work in demo indeed.

Would love to land it in vscode. Happy to make a PR if this is relatively straight forward.

Steps to reproduce

1. Clone repo
2. Run yarn
3. Run yarn start

Expected

Demo starts up.

Actual

Takes a a really long time (preferably downloading puppeteer) for 30 mins. Then see this error

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(12,29)
      TS2307: Cannot find module '../addons/xterm-addon-attach/out/AttachAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(13,26)
      TS2307: Cannot find module '../addons/xterm-addon-fit/out/FitAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(14,45)
      TS2307: Cannot find module '../addons/xterm-addon-search/out/SearchAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(15,32)
      TS2307: Cannot find module '../addons/xterm-addon-serialize/out/SerializeAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(16,31)
      TS2307: Cannot find module '../addons/xterm-addon-web-links/out/WebLinksAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(17,28)
      TS2307: Cannot find module '../addons/xterm-addon-webgl/out/WebglAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(18,32)
      TS2307: Cannot find module '../addons/xterm-addon-unicode11/out/Unicode11Addon' or its corresponding type declarations.

I have no idea why it's not being built.

xterm.js (master): yarn presetup
yarn run v1.21.1
$ node ./bin/install-addons.js
pulling addon dependencies...
Skipped xterm-addon-attach
Skipped xterm-addon-fit
Skipped xterm-addon-search
Skipped xterm-addon-serialize
Skipped xterm-addon-unicode11
Skipped xterm-addon-web-links
Skipped xterm-addon-webgl
✨  Done in 0.27s.
xterm.js (master) 1s ✔ 

Install works fine

I figured it out. Seems there is another pre-setup that I had to dig out. Need to run yarn install && yarn build && yarn start.

Steps to reproduce

1. Clone repo
2. Run yarn
3. Run yarn start

Expected

Demo starts up.

Actual

Takes a a really long time (preferably downloading puppeteer) for 30 mins. Then see this error

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(12,29)
      TS2307: Cannot find module '../addons/xterm-addon-attach/out/AttachAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(13,26)
      TS2307: Cannot find module '../addons/xterm-addon-fit/out/FitAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(14,45)
      TS2307: Cannot find module '../addons/xterm-addon-search/out/SearchAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(15,32)
      TS2307: Cannot find module '../addons/xterm-addon-serialize/out/SerializeAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(16,31)
      TS2307: Cannot find module '../addons/xterm-addon-web-links/out/WebLinksAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(17,28)
      TS2307: Cannot find module '../addons/xterm-addon-webgl/out/WebglAddon' or its corresponding type declarations.

ERROR in /Users/nojvek/git/xterm.js/demo/client.ts
./demo/client.ts
[tsl] ERROR in /Users/nojvek/git/xterm.js/demo/client.ts(18,32)
      TS2307: Cannot find module '../addons/xterm-addon-unicode11/out/Unicode11Addon' or its corresponding type declarations.

I have no idea why it's not being built.

xterm.js (master): yarn presetup
yarn run v1.21.1
$ node ./bin/install-addons.js
pulling addon dependencies...
Skipped xterm-addon-attach
Skipped xterm-addon-fit
Skipped xterm-addon-search
Skipped xterm-addon-serialize
Skipped xterm-addon-unicode11
Skipped xterm-addon-web-links
Skipped xterm-addon-webgl
✨  Done in 0.27s.
xterm.js (master) 1s ✔ 

Install works fine

Also works with right click select. Fixes #682.

This relies on the fact that before a user (double/right)-clicks a link, the cursor will hover the link, triggering the asynchronous link provider(s). By the time the click event fires, the link provider "should" have done its thing, and the link is used. If not, this falls back to the old behavior. This seemed good enough to me. If it is not, one probably would have to expose some inner state of the linkifier to provide some way to check if there are currently link providers resolving and to wait for them to finish before selecting.

I feel a bit bad about duplicating the magic "-1"s (on both x and y for start, only on y for end) from Linkifier2._fireUnderlineEvent, but I couldn't think of a good way to extract that logic. It seems to me to produce the correct results.

I've opened a pr princjef/font-ligatures#22 as the first step to get this done

Only a cleanup PR, but since this bugged me for a while and I have to deal with testing for the async PR anyway, time to replace the uglier expect based testing code with some simple assertion testing.

@Tyriar The replacements only use .equal, deepEqual and doesNotThrow from chai.assert. Not sure if this could be used to get rid of chai someday and just use nodejs' assert lib. I remember we once had an issue regarding this, but dont recall why it was not possible in the end (different semantics?)

Only a cleanup PR, but since this bugged me for a while and I have to deal with testing for the async PR anyway, time to replace the uglier expect based testing code with some simple assertion testing.

@Tyriar The replacements only use .equal, deepEqual and doesNotThrow from chai.assert. Not sure if this could be used to get rid of chai someday and just use nodej's assert lib. I remember we once has an issue regarding this, but dont recall why it was not possible in the end.