profile
viewpoint
Daniel Imms Tyriar @Microsoft Seattle, WA http://www.growingwiththeweb.com Aussie software engineer building VS Code and @xtermjs

sindresorhus/plur 108

Pluralize a word

gwtw/js-data-structures 70

A collection of data structures written in JavaScript

microsoft/vscode-wiki 66

A repository to make changes to the vscode Wiki on GitHub

gwtw/py-sorting 61

A collection of sorting algorithms written in Python.

Tyriar/abbr-touch 53

Makes <abbr> element title attributes touch accessible

gwtw/js-sorting 52

A collection of sorting algorithms written in JavaScript.

gwtw/growing-with-the-web 47

A collection of code samples from my blog

gwtw/js-interview-questions 39

A collection of interview question answers written in JavaScript

gwtw/js-fibonacci-heap 25

A JavaScript implementation of the Fibonacci heap data structure

gwtw/java-sorting 23

A collection of sorting algorithms written in Java.

push eventTyriar/xterm.js

dependabot-preview[bot]

commit sha 4f59d1561a74a229de0e8ced5c2c69b813b574ab

Bump webpack-cli from 3.3.11 to 3.3.12 Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.3.11 to 3.3.12. - [Release notes](https://github.com/webpack/webpack-cli/releases) - [Changelog](https://github.com/webpack/webpack-cli/blob/v3.3.12/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-cli/compare/v3.3.11...v3.3.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha f6bf7dcd92cb3596692f3ff052d9ff6adcd3f872

Merge pull request #2977 from xtermjs/dependabot/npm_and_yarn/webpack-cli-3.3.12 Bump webpack-cli from 3.3.11 to 3.3.12

view details

dependabot-preview[bot]

commit sha 0cf32d9b4dd77c73aa818c34aa75fe8daa02d298

Bump @types/webpack from 4.41.17 to 4.41.18 Bumps [@types/webpack](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/webpack) from 4.41.17 to 4.41.18. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/webpack) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha 4a0cb00450899957f05f0db26e612d13ce93b3a2

Merge pull request #2982 from xtermjs/dependabot/npm_and_yarn/types/webpack-4.41.18 Bump @types/webpack from 4.41.17 to 4.41.18

view details

dependabot-preview[bot]

commit sha fbc34b649c85f1137fff78769ca8b133d70157c2

Bump @types/ws from 7.2.5 to 7.2.6 Bumps [@types/ws](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ws) from 7.2.5 to 7.2.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ws) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha 3e6bcc09b3f20896aff455798aa6ac9d6ca2a485

Merge pull request #2984 from xtermjs/dependabot/npm_and_yarn/types/ws-7.2.6 Bump @types/ws from 7.2.5 to 7.2.6

view details

dependabot-preview[bot]

commit sha b6259d3e7e82683495663dd54c8c578517c8daba

Bump source-map-loader from 1.0.0 to 1.0.1 Bumps [source-map-loader](https://github.com/webpack-contrib/source-map-loader) from 1.0.0 to 1.0.1. - [Release notes](https://github.com/webpack-contrib/source-map-loader/releases) - [Changelog](https://github.com/webpack-contrib/source-map-loader/blob/master/CHANGELOG.md) - [Commits](https://github.com/webpack-contrib/source-map-loader/compare/v1.0.0...v1.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha 7ce47c474a1a28c270b3f88a3ba02428f8bc8db4

Merge pull request #2985 from xtermjs/dependabot/npm_and_yarn/source-map-loader-1.0.1 Bump source-map-loader from 1.0.0 to 1.0.1

view details

dependabot-preview[bot]

commit sha 04655b1db54962f0d2da8ebec48db1beeb00f860

Bump @types/glob from 7.1.2 to 7.1.3 Bumps [@types/glob](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/glob) from 7.1.2 to 7.1.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/glob) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha cb0242782a1b0292bd0af08e4807c23056814a5a

Bump @types/webpack from 4.41.18 to 4.41.20 Bumps [@types/webpack](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/webpack) from 4.41.18 to 4.41.20. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/webpack) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha 7e7be15ab81e64825a1f4b7eafdfe0348a92ac86

Merge pull request #2990 from xtermjs/dependabot/npm_and_yarn/types/glob-7.1.3 Bump @types/glob from 7.1.2 to 7.1.3

view details

Daniel Imms

commit sha a551c69e9e9f7d5a6bd2a6f18744fb0d08a03ea9

Merge pull request #2991 from xtermjs/dependabot/npm_and_yarn/types/webpack-4.41.20 Bump @types/webpack from 4.41.18 to 4.41.20

view details

dependabot-preview[bot]

commit sha 0c953a88c3ea9a24a82ce7431351230b36971a15

Bump ws from 7.3.0 to 7.3.1 Bumps [ws](https://github.com/websockets/ws) from 7.3.0 to 7.3.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/7.3.0...7.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha ea2336b68e20f17a36e9f59cb49266ab26529d56

Merge pull request #2989 from xtermjs/dependabot/npm_and_yarn/ws-7.3.1 Bump ws from 7.3.0 to 7.3.1

view details

dependabot-preview[bot]

commit sha 612b922eeb1978e59269c91b852c7438a13ab1fa

Bump typescript from 3.9.5 to 3.9.6 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.9.5 to 3.9.6. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha 2479660028e97b66552a83939fcf0a928c1e086f

Merge pull request #2986 from xtermjs/dependabot/npm_and_yarn/typescript-3.9.6 Bump typescript from 3.9.5 to 3.9.6

view details

push time in 2 hours

issue closedmicrosoft/vscode

Deleting integrated terminal connected to remote crashes VS Code

Issue Type: <b>Bug</b>

  1. Connect (ssh) to a remote Linux computer;
  2. Run command that will not stop for a while ( e.g. du / );
  3. delete terminal (trash can icon) before command finishes.

VS Code stops responding:

  1. cannot run any command;
  2. cannot open any menu;
  3. cannot close, minimize or maximize window;
  4. cannot place or move cursor in any open file.

Only option that works is to forcibly close from Task Manager.

VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z) OS version: Windows_NT x64 10.0.18363

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 15.88GB (7.06GB free)
Process Argv
Screen Reader no
VM 0%

</details><details><summary>Extensions (5)</summary>

Extension Author (truncated) Version
better-toml bun 0.3.2
macros ged 1.2.1
sftp lix 1.12.9
python ms- 2020.6.90262
rust rus 0.7.8

</details> <!-- generated by issue reporter -->

closed time in 2 hours

clayms

issue commentmicrosoft/vscode

Deleting integrated terminal connected to remote crashes VS Code

/duplicate https://github.com/microsoft/vscode/issues/76548

clayms

comment created time in 2 hours

issue closedmicrosoft/vscode

Terminal Orientation

Issue Type: <b>Feature Request</b>

It would be great if the terminal's orientation can be changed to vertical instead of horizontal . This is because it is quite time consuming to review all of the code when the terminal is also open .

VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z) OS version: Windows_NT x64 10.0.17763

<!-- generated by issue reporter -->

closed time in 2 hours

bnkalya1502

issue commentmicrosoft/vscode

Terminal Orientation

Along the same lines, we are investing in a more flexible workbench which will eventually likely allow you to split the terminal in both directions regardless of where it is.

bnkalya1502

comment created time in 2 hours

issue commentmicrosoft/vscode

Terminal filled with ^[[D^[[D^[[D^[[D when alt-clicking a link

Looks like this is an issue where the alt+click feature (move cursor when clicking) is conflicting with links, only when "editor.multiCursorModifier": "ctrlCmd" is used.

notpushkin

comment created time in 2 hours

issue commentmicrosoft/vscode

Bash Integrated Terminal No Cursor/Can't Type

Can you run ver in cmd to get your windows build number?

/label "needs more info" integrated-terminal

gavinuhran

comment created time in 3 hours

issue commentmicrosoft/vscode

Terminal blank on windows 10

Does changing the terminal.integrated.rendererType setting help?

Gowthami11

comment created time in 3 hours

issue commentmicrosoft/vscode

vscode not being able to open files and folders

A lot of things will break when you delete the folder that's opened.

gurrrung

comment created time in 3 hours

issue commentPowerShell/PSReadLine

Expand PSReadLine MenuComplete to work in Visual Studio Code for non-english default languages

Well if we just need to enable PSEUDOCONSOLE_WIN32_INPUT_MODE to get this then yes, it will be months before conpty ships in Windows 10 though.

WorrenB

comment created time in 5 hours

issue openedmicrosoft/vscode

Hover widget should restrict height when it's too large

Context: https://github.com/microsoft/vscode/issues/97496#issuecomment-652651297

image

created time in 5 hours

issue commentmicrosoft/vscode

I have this error message "The terminal process terminated with exit code: 4294967295" while opening the integrated terminal. How do i solve this issue. I didn't get it.

See https://code.visualstudio.com/docs/supporting/troubleshoot-terminal-launch for steps on how to investigate what's going on.

sshude

comment created time in 5 hours

issue closedmicrosoft/vscode

I have this error message "The terminal process terminated with exit code: 4294967295" while opening the integrated terminal. How do i solve this issue. I didn't get it.

I have this error message "The terminal process terminated with exit code: 4294967295" while opening the integrated terminal. How do i solve this issue. I didn't get it.

closed time in 5 hours

sshude

issue commentxtermjs/xterm.js

Cannot read property 'features' of undefined - while using ligatures addon

To me this looks problematic, as the module code relies on nodejs env (loading system fonts through additional modules), while xterm.js itself is a completely decoupled browser frontend thingy.

This is an Electron-only addon and soon won't even work in VS Code as we want to disable node in the renderer all together.

Furthermore I am not a big fan of spinoffs

👍 ideally this would get fixed in the upstream package.

LabhanshAgrawal

comment created time in 5 hours

issue commentxtermjs/xterm.js

when open mutil terminal in one page , use long time .

Additionally that is using the canvas renderer which we want to get rid of eventually, the webgl addon is available for fast hardware acceleration or the dom renderer for slower but best compatibility.

herolyle

comment created time in 5 hours

issue closedxtermjs/xterm.js

when open mutil terminal in one page , use long time .

<!-- ⚠️ Please search existing issues to avoid creating duplicates. ⚠️ --> <!-- Describe the bug here. -->

Details

  • Browser and browser version:chrome 版本 83.0.4103.116(正式版本) (64 位)
  • OS version:mac os
  • xterm.js version: xterm@3.8.0

Steps to reproduce

In one page ,have many tabs/terminal ,when I open new tab need long time 。。

execute many times clearColor FunctionclearColor @ CharAtlasGenerator.js:73

closed time in 5 hours

herolyle

issue commentmicrosoft/vscode

The "ELECTRON_MIRROR" environment variable in the terminal does not work

This happens because we remove any environment variables of the form ELECTRON_.* when creating processes. We could go to a more specific list of variables like it used to but historically we ended up having variables slip in.

https://github.com/microsoft/vscode/blob/b8131113576908b042d2c4fab86128047181a09d/src/vs/base/common/processes.ts#L109-L114

linlexing

comment created time in 5 hours

push eventxtermjs/xterm.js

dependabot-preview[bot]

commit sha 612b922eeb1978e59269c91b852c7438a13ab1fa

Bump typescript from 3.9.5 to 3.9.6 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.9.5 to 3.9.6. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha 2479660028e97b66552a83939fcf0a928c1e086f

Merge pull request #2986 from xtermjs/dependabot/npm_and_yarn/typescript-3.9.6 Bump typescript from 3.9.5 to 3.9.6

view details

push time in 5 hours

delete branch xtermjs/xterm.js

delete branch : dependabot/npm_and_yarn/typescript-3.9.6

delete time in 5 hours

PR merged xtermjs/xterm.js

Bump typescript from 3.9.5 to 3.9.6 dependencies

Bumps typescript from 3.9.5 to 3.9.6. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/Microsoft/TypeScript/commits">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+3 -3

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 5 hours

pull request commentmicrosoft/vscode

Detect links in the terminal that don't have a path separator

I don't think this will cause so much extra filesystem access, because it only checks it if you hover over a line 🤷‍♂️

Even though it's only on hover now, it would do this for every "word" on the line and the cache is short lived currently as well. For example dragging the mouse over this terminal would result in ~50 fs requests of which could potentially take seconds to complete.

image

Currently I would expect the number to be around 4 (folder name and url).

Changing the regex to only match files without slashes if they are followed by a line number, so that in a line such as file.cpp:1:1: error only the file file.cpp will be checked, instead of also error.

This is what I was thinking when labelling https://github.com/microsoft/vscode/issues/101155 as :<line> at the end of the word is a very good indicator that it's likely a file.

Changing the search in workspace regex to treat dangling colons as separators, like it treats quotes and commas, except only if they are at the edge ("trimming" colons).

Less of a fan of this approach as currently search in workspace is a very simple fallback, the complexity/edge cases live at in more specific providers.

NotWearingPants

comment created time in 5 hours

issue closedmicrosoft/vscode

Switching workspace shortcut (Ctlr+W) doesn't work when Terminal is active

Issue Type: <b>Bug</b>

Open more than one project Make sure pressing Ctrl+W activates workspace selector Open Terminal windows and place cursor in it Press Ctrl+W. Now workspace switch is not activated

VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:17:14.222Z) OS version: Darwin x64 19.5.0

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) 1, 2, 4
Memory (System) 16.00GB (4.08GB free)
Process Argv -psn_0_53261
Screen Reader no
VM 0%

</details><details><summary>Extensions (7)</summary>

Extension Author (truncated) Version
vscode-eslint dba 2.1.5
EditorConfig Edi 0.15.1
vscode-docker ms- 1.3.1
debugger-for-chrome msj 4.12.8
vscode-extension-auto-import Nuc 1.4.3
autoimport ste 1.5.3
vscode-js-import wan 0.15.5

</details> <!-- generated by issue reporter -->

closed time in 9 hours

jelnur

issue closedmicrosoft/vscode

The terminal process terminated with exit code: 4294901760

We have written the needed data into your clipboard because it was too large to send. Please paste.

My terminal stopped

VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z) OS version: Windows_NT x64 10.0.18362

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (4 x 3192)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 7.89GB (1.23GB free)
Process Argv
Screen Reader no
VM 0%

</details><details> <summary>Process Info</summary>

CPU %	Mem MB	   PID	Process
    1	    71	  5600	code main
    0	   233	  3384	   gpu-process
    0	   171	  3724	   window (Settings - myfst - Visual Studio Code)
    0	    53	  2868	     extensionHost
    0	    22	   232	       "C:\Users\hasib\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\hasib\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\html-language-features\server\dist\htmlServerMain" --node-ipc --clientProcessId=2868
    0	    28	  5088	       "C:\Users\hasib\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\hasib\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\jsonServerMain" --node-ipc --clientProcessId=2868
    0	     9	  4340	     watcherService 
    0	     4	  9060	       console-window-host (Windows internal process)
    0	    34	 12304	     searchService
    5	    72	  6928	   window (Issue Reporter)
    0	     9	 11384	   electron-crash-reporter
    0	    50	 11712	   shared-process
    0	    21	 12280	   utility

</details> <details> <summary>Workspace Info</summary>

|  Window (Settings - myfst - Visual Studio Code)
|    Folder (myfst): 2 files
|      File types: htm(1) html(1)
|      Conf files:;

</details> Extensions: none <!-- generated by issue reporter --> OS: Windows_NT x64 10.0.18362

closed time in 9 hours

Hasib-z

issue commentmicrosoft/vscode

The terminal process terminated with exit code: 4294901760

Please see https://code.visualstudio.com/docs/supporting/troubleshoot-terminal-launch to help diagnose.

Hasib-z

comment created time in 9 hours

issue commentmicrosoft/vscode

there seems to be no obvious way to "unsplit" a splitted terminal

I guess you're asking to be able to unsplit terminals so they becomes tabs instead?

weinand

comment created time in 9 hours

issue commentmicrosoft/vscode

the console does not show multiple unicode characters correctly

Please provide a screenshot of a gif illustrating the problem (attaching images won't work via email, you need to go to github.com). See this wiki page for more general info on how to report actionable terminal issues.

/label "needs more info" integrated-terminal

lugeke

comment created time in 9 hours

issue closedxtermjs/xterm.js

The height cannot be changed

<!-- ⚠️ Please search existing issues to avoid creating duplicates. ⚠️ --> <!-- Describe the bug here. --> Hello, after I call the fit() method, the width has changed and the height cannot be changed. Why is it always 600px?

Details

  • Browser and browser version: chrome 83.0.4103.116
  • OS version: Mac 10.12.6
  • xterm.js version: 4.6.0

Steps to reproduce

Create a new xterm, output multiple lines of code, the height is fixed at 600px, can not adapt, the fit() method has been used

closed time in 9 hours

RanX12

issue commentmicrosoft/vscode

Integrated terminal highly unstable and crashes VSCode

/duplicate https://github.com/microsoft/vscode/issues/76548

samdoeswork

comment created time in 9 hours

issue closedmicrosoft/vscode

Integrated terminal highly unstable and crashes VSCode

I frequently have issues where the integrated terminal causes a total crash of VSCode. This will happen a %age of all times run task is used, and quite reliably when stopping and starting a terminal task a couple of times.

This happens in Insider, and with --disable-extensions (the code --status dump below was with --disable-extensions).

  • VSCode Version: 1.46.1
  • OS Version:

Steps to Reproduce:

  1. Start a terminal via. run task (in this case a NPM script to webpack)
  2. Restart this job (will also frequently fail when you stop, wait, start)

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

Version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z) OS Version: Windows_NT x64 10.0.18362 CPUs: Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 x 3600) Memory (System): 15.94GB (3.66GB free) VM: 0% Screen Reader: no Process Argv: --disable-extensions GPU Status: 2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled

CPU % Mem MB PID Process 0 78 34768 code main 0 116 1424 gpu-process 0 25 6216 utility 0 205 6524 window (exchangeReply.ts - JustAddFeatures-Workspace (Workspace) - Visual Studio Code) 0 6 6456 console-window-host (Windows internal process) 0 4 8160 C:\WINDOWS\System32\cmd.exe /d /c npm run debug_exchangeReply 0 27 23272 "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" run debug_exchangeReply 0 4 38784 C:\WINDOWS\system32\cmd.exe /d /s /c npx webpack && node --inspect node_modules/@google-cloud/functions-framework --target=exchangeReply --port=13023 0 20 7128 "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npx-cli.js" webpack 0 4 30372 C:\WINDOWS\system32\cmd.exe /d /s /c "webpack" 0 256 4992 electron_node webpack.js 0 15 10424 watcherService 0 11 10664 console-window-host (Windows internal process) 0 4 11856 C:\WINDOWS\System32\cmd.exe 0 6 14432 console-window-host (Windows internal process) 0 6 22780 console-window-host (Windows internal process) 0 69 26328 extensionHost 0 32 2712 "C:\Users\Sam\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\Sam\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\jsonServerMain" --node-ipc --clientProcessId=26328 0 52 7176 electron_node tsserver.js 0 186 35092 electron_node tsserver.js 0 58 26776 electron_node typingsInstaller.js typesMap.js 0 74 20452 shared-process 0 14 34136 electron-crash-reporter

Workspace Stats: | Window (exchangeReply.ts - JustAddFeatures-Workspace (Workspace) - Visual Studio Code) | Folder (jaf): 2581 files | File types: ts(613) js(570) map(371) json(163) html(139) css(117) | yaml(78) gcloudignore(25) png(22) hbs(22) | Conf files: package.json(37) webpack.config.js(26) tsconfig.json(21) | tslint.json(3) launch.json(1) settings.json(1) | tasks.json(1) | Launch Configs: node(10) cloudcode.kubernetes chrome

closed time in 9 hours

samdoeswork

issue commentmicrosoft/vscode

VS Code interpreter / REPL

In my vision, ideally, after launching vs code, clicking Ctrl+N for creating a new temp file at an undisclosed location, should allow me rename the file to indicate its type (let's say *.cpp or *.cs).

You can write an extension to do this.

weitzhandler

comment created time in 9 hours

issue closedmicrosoft/vscode

Setting sync "too many requests"

Issue Type: <b>Bug</b>

I got the 'too many requests' error from setting sync in what I think is a fairly normal workflow:

  1. Searched for an extension
  2. Installed it in my remote
  3. Used the "add to recommended extensions (workspace) folder"
  4. Reloaded the window
  5. Received the error that settings sync made too many requests

Here's the log from the last several minutes:

<details> <pre> [2020-07-05 15:11:15.451] [userDataSync] [info] Auto Sync: Triggered by Interval [2020-07-05 15:11:16.144] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:11:16.144] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:11:16.151] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:11:16.154] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:11:16.224] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:11:16.224] [userDataSync] [info] Sync done. Took 101ms [2020-07-05 15:12:54.678] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:12:55.052] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:12:55.052] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:12:55.059] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:12:55.063] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:12:55.172] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:12:55.172] [userDataSync] [info] Sync done. Took 152ms [2020-07-05 15:17:55.173] [userDataSync] [info] Auto Sync: Triggered by Interval [2020-07-05 15:17:55.931] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:17:55.931] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:17:55.939] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:17:55.943] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:17:56.016] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:17:56.016] [userDataSync] [info] Sync done. Took 110ms [2020-07-05 15:22:56.017] [userDataSync] [info] Auto Sync: Triggered by Interval [2020-07-05 15:22:56.863] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:22:56.863] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:22:56.871] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:22:56.874] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:22:56.945] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:22:56.945] [userDataSync] [info] Sync done. Took 103ms [2020-07-05 15:27:56.946] [userDataSync] [info] Auto Sync: Triggered by Interval [2020-07-05 15:27:57.774] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:27:57.774] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:27:57.782] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:27:57.786] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:27:57.876] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:27:57.876] [userDataSync] [info] Sync done. Took 125ms [2020-07-05 15:30:59.654] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:31:00.460] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:31:00.460] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:31:00.468] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:31:00.471] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:31:00.562] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:31:00.562] [userDataSync] [info] Sync done. Took 127ms [2020-07-05 15:31:22.564] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:31:22.939] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:31:22.939] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:31:22.948] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:31:24.192] [userDataSync] [info] GlobalState: Updated remote ui state [2020-07-05 15:31:24.201] [userDataSync] [info] GlobalState: Updated last synchronized ui state [2020-07-05 15:31:24.294] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:31:24.294] [userDataSync] [info] Sync done. Took 1379ms [2020-07-05 15:31:24.294] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:31:24.668] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:31:24.668] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:31:24.675] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:31:24.678] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:31:24.741] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:31:24.741] [userDataSync] [info] Sync done. Took 88ms [2020-07-05 15:31:38.282] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:31:38.654] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:31:38.654] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:31:38.662] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:31:39.850] [userDataSync] [info] GlobalState: Updated remote ui state [2020-07-05 15:31:39.857] [userDataSync] [info] GlobalState: Updated last synchronized ui state [2020-07-05 15:31:39.925] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:31:39.925] [userDataSync] [info] Sync done. Took 1299ms [2020-07-05 15:31:50.058] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:31:50.506] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:31:50.506] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:31:50.516] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:31:50.521] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:31:50.588] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:31:50.588] [userDataSync] [info] Sync done. Took 97ms [2020-07-05 15:32:03.477] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:32:03.988] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:32:03.988] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:32:03.995] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:32:05.158] [userDataSync] [info] GlobalState: Updated remote ui state [2020-07-05 15:32:05.173] [userDataSync] [info] GlobalState: Updated last synchronized ui state [2020-07-05 15:32:05.266] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:32:05.266] [userDataSync] [info] Sync done. Took 1305ms [2020-07-05 15:32:05.266] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:32:05.785] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:32:05.785] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:32:05.791] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:32:05.795] [userDataSync] [info] GlobalState: No changes found during synchronizing ui state. [2020-07-05 15:32:05.865] [userDataSync] [info] Extensions: No changes found during synchronizing extensions. [2020-07-05 15:32:05.865] [userDataSync] [info] Sync done. Took 96ms [2020-07-05 15:32:10.460] [userDataSync] [info] Auto Sync: Triggered by Activity [2020-07-05 15:32:10.844] [userDataSync] [info] Settings: No changes found during synchronizing settings. [2020-07-05 15:32:10.844] [userDataSync] [info] Keybindings: Skipped synchronizing keybindings as it is disabled. [2020-07-05 15:32:10.852] [userDataSync] [info] Snippets: No changes found during synchronizing snippets. [2020-07-05 15:32:11.076] [userDataSync] [error] RemoteTooManyRequests (UserDataSyncError) : POST request 'https://vscode-sync.trafficmanager.net/v1/resource/globalState' failed because of too many requests (429). at S.request (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:528:815) at async S.write (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:525:84) at async e.updateRemoteUserData (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:436:214) at async e.applyPreview (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:454:478) at async e.doSync (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:432:852) at async e.performSync (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:432:8) at async e.sync (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:430:431) at async w.doSync (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:517:206) at async y.doSync (file:///C:/Users/Connor/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:511:638) [2020-07-05 15:32:11.076] [userDataSync] [info] Auto Sync: Disabled because sync is disabled [2020-07-05 15:32:11.077] [userDataSync] [info] Auto sync: Canelled sync that is in progress [2020-07-05 15:32:11.077] [userDataSync] [info] Auto Sync: Stopped [2020-07-05 15:32:11.083] [userDataSync] [info] Did reset the local sync state. [2020-07-05 15:32:11.083] [userDataSync] [info] Auto Sync: Turned off sync because of making too many requests to server </pre> </details>

VS Code version: Code - Insiders 1.47.0-insider (04545fa88043fd10d1f3edefd26be1b8245b516f, 2020-07-02T05:48:37.715Z) OS version: Windows_NT x64 10.0.18363 Remote OS version: Linux x64 4.19.76-linuxkit

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 31.96GB (15.54GB free)
Process Argv
Screen Reader no
VM 0%
Item Value
Remote Dev Container: Wordpress
OS Linux x64 4.19.76-linuxkit
CPUs Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (2 x 3407)
Memory (System) 1.94GB (0.30GB free)
VM 0%

</details> <!-- generated by issue reporter -->

closed time in 9 hours

connor4312

issue commentmicrosoft/vscode

Setting sync "too many requests"

/duplicate #101504

connor4312

comment created time in 9 hours

issue commentmicrosoft/vscode

shared integrated terminal 11 characters wide on guest side

Please report to the live share ext https://github.com/MicrosoftDocs/live-share

dgh1000

comment created time in 9 hours

issue commentmicrosoft/vscode

shared integrated terminal 11 characters wide on guest side

Might be https://github.com/microsoft/vscode/issues/55718

dgh1000

comment created time in 9 hours

issue commentmicrosoft/vscode

Minimize Terminal Button

@misolori FYI feedback on x to minimize panel

yaddly

comment created time in 9 hours

issue commentmicrosoft/vscode

Allow extensions to contribute links to the terminal (aka link providers)

@DanTup the old proposal comment isn't up to date: https://github.com/microsoft/vscode/blob/d95b65443d9785a3f7a119a1d6fae340885a0a81/src/vs/vscode.proposed.d.ts#L1067-L1070

Tyriar

comment created time in 9 hours

issue commentmicrosoft/vscode

Preferences sync fails "RemoteTooManyRequests"

Just catching up from vacation now, this will probably be the first thing I'll be looking at after that.

selfagency

comment created time in 9 hours

push eventxtermjs/xterm.js

dependabot-preview[bot]

commit sha 0c953a88c3ea9a24a82ce7431351230b36971a15

Bump ws from 7.3.0 to 7.3.1 Bumps [ws](https://github.com/websockets/ws) from 7.3.0 to 7.3.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/7.3.0...7.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha ea2336b68e20f17a36e9f59cb49266ab26529d56

Merge pull request #2989 from xtermjs/dependabot/npm_and_yarn/ws-7.3.1 Bump ws from 7.3.0 to 7.3.1

view details

push time in 9 hours

delete branch xtermjs/xterm.js

delete branch : dependabot/npm_and_yarn/ws-7.3.1

delete time in 9 hours

PR merged xtermjs/xterm.js

Bump ws from 7.3.0 to 7.3.1 dependencies

Bumps ws from 7.3.0 to 7.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/websockets/ws/releases">ws's releases</a>.</em></p> <blockquote> <h2>7.3.1</h2> <h1>Bug fixes</h1> <ul> <li>Improved <code>websocket.bufferedAmount</code> accuracy (e1349c04, a1629426).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/websockets/ws/commit/d09daaf67c282e301eeebe21797215ddffd819c5"><code>d09daaf</code></a> [dist] 7.3.1</li> <li><a href="https://github.com/websockets/ws/commit/a162942649e27174590bb0162bbbc63912941ce7"><code>a162942</code></a> [fix] Use <code>socket._writableState.length</code> instead of <code>socket.bufferSize</code></li> <li><a href="https://github.com/websockets/ws/commit/41b0f9b36749ca1498d22726d22f72233de1424a"><code>41b0f9b</code></a> [minor] Fix nit</li> <li><a href="https://github.com/websockets/ws/commit/44bcbc85313373e31eef8a5ca7b2be4447982763"><code>44bcbc8</code></a> [minor] Fix JSDoc comments</li> <li><a href="https://github.com/websockets/ws/commit/e1349c047d7f1c120ca606364e35d5c4c627c599"><code>e1349c0</code></a> [fix] Take into account the data that is being compressed</li> <li><a href="https://github.com/websockets/ws/commit/0954abcebe027aa10eb4cb203fc717291e1b3dbd"><code>0954abc</code></a> [doc] Add clarification for <code>http{,s}.request()</code> options (<a href="https://github-redirect.dependabot.com/websockets/ws/issues/1773">#1773</a>)</li> <li><a href="https://github.com/websockets/ws/commit/88d0345997ea14b262519c7d5b5baaf6f9d78035"><code>88d0345</code></a> [pkg] Update prettier to version 2.0.5</li> <li><a href="https://github.com/websockets/ws/commit/b6ae22a5b54dbdaba11dc3dfb5cb77747598d72b"><code>b6ae22a</code></a> [pkg] Update eslint to version 7.2.0</li> <li><a href="https://github.com/websockets/ws/commit/c4c7f3c545e96d273ba27fe24641eda12831463f"><code>c4c7f3c</code></a> [ci] Run the lint script only once</li> <li><a href="https://github.com/websockets/ws/commit/14d53d72507ab367cff3e4609889bd8a7f68d1df"><code>14d53d7</code></a> [pkg] Do not run the lint script before the test script</li> <li>Additional commits viewable in <a href="https://github.com/websockets/ws/compare/7.3.0...7.3.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+5 -5

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 9 hours

issue commentmicrosoft/vscode

Git does not work when VS code is open

https://stackoverflow.com/q/47929881/1156119 looks similar which says it could be low disk space, permissions or not using mapped drives? The only thing I can think of is this is a limitation of winpty and you need to update to the new terminal backend which is maintained by Microsoft so weird permissions-related things like this don't happen, you need to be on Windows 1903+ to use the new system.

clayms

comment created time in 9 hours

push eventxtermjs/xterm.js

dependabot-preview[bot]

commit sha cb0242782a1b0292bd0af08e4807c23056814a5a

Bump @types/webpack from 4.41.18 to 4.41.20 Bumps [@types/webpack](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/webpack) from 4.41.18 to 4.41.20. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/webpack) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha a551c69e9e9f7d5a6bd2a6f18744fb0d08a03ea9

Merge pull request #2991 from xtermjs/dependabot/npm_and_yarn/types/webpack-4.41.20 Bump @types/webpack from 4.41.18 to 4.41.20

view details

push time in 9 hours

delete branch xtermjs/xterm.js

delete branch : dependabot/npm_and_yarn/types/webpack-4.41.20

delete time in 9 hours

PR merged xtermjs/xterm.js

Bump @types/webpack from 4.41.18 to 4.41.20 dependencies

⚠️ Dependabot is rebasing this PR ⚠️

If you make any changes to it yourself then they will take precedence over the rebase.


Bumps @types/webpack from 4.41.18 to 4.41.20. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/webpack">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+5 -5

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 9 hours

push eventxtermjs/xterm.js

dependabot-preview[bot]

commit sha 04655b1db54962f0d2da8ebec48db1beeb00f860

Bump @types/glob from 7.1.2 to 7.1.3 Bumps [@types/glob](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/glob) from 7.1.2 to 7.1.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/glob) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha 7e7be15ab81e64825a1f4b7eafdfe0348a92ac86

Merge pull request #2990 from xtermjs/dependabot/npm_and_yarn/types/glob-7.1.3 Bump @types/glob from 7.1.2 to 7.1.3

view details

push time in 9 hours

delete branch xtermjs/xterm.js

delete branch : dependabot/npm_and_yarn/types/glob-7.1.3

delete time in 9 hours

PR merged xtermjs/xterm.js

Bump @types/glob from 7.1.2 to 7.1.3 dependencies

Bumps @types/glob from 7.1.2 to 7.1.3. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/glob">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+5 -5

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 9 hours

issue openedzgoat/goatcounter

Clicking "day" results in "end date before start date" error

On (mine).goatcounter.com:

recording (3)

created time in 5 days

push eventmicrosoft/vscode-docs

Daniel Imms

commit sha 8ec7ca27f737f7301dc3bb3c522ccc61939dbc01

Add screenshot to link provider

view details

push time in 6 days

push eventmicrosoft/vscode-docs

Daniel Imms

commit sha 2974b42be1b06ca7c631c58ce8ba34179ad93ae8

Add terminal link provider

view details

push time in 6 days

issue commentmicrosoft/vscode

Make notebook cell focus & indicator themeable

@misolori the current pattern seems to be:

Active, not focused list:

image

Hovered list:

image

Focused list:

image

In the editor the active line is solid regardless of whether it's focused or not:

image

Maybe try a dotted line for the outer focus borders when there is an inner focus?

misolori

comment created time in 6 days

issue closedmicrosoft/vscode

VS Code Freezes sometimes after killing the in-built terminal of it

VS Code Freezes Sometime

Sometimes, when I click on the kill button of in-built terminal, it freezes for no reason. Please fix the bug.

closed time in 6 days

soumya-99

issue commentmicrosoft/vscode

VS Code Freezes sometimes after killing the in-built terminal of it

/duplicate https://github.com/microsoft/vscode/issues/76548

soumya-99

comment created time in 6 days

issue closedmicrosoft/vscode

Terminal not showing text

Issue Type: <b>Bug</b>

VS Code integrated terminal showing blank. Also some formatting style changed => angular modules: imports and declarations used to show at different color but now showing in the same color as keywords like NgModule

VS Code version: Code 1.46.0 (a5d1cc28bb5da32ec67e86cc50f84c67cc690321, 2020-06-10T09:03:20.462Z) OS version: Windows_NT x64 10.0.18363

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 1992)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: disabled_software<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: enabled<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled_readback<br>webgl2: enabled_readback
Load (avg) undefined
Memory (System) 15.67GB (3.01GB free)
Process Argv --folder-uri file:///d%3A/Dev/merchantrademoney/MerchantradeMoney.Admin/src
Screen Reader no
VM 0%

</details><details><summary>Extensions (23)</summary>

Extension Author (truncated) Version
ng-template Ang 0.901.11
bracket-pair-colorizer Coe 1.0.61
vscode-eslint dba 2.1.5
gitlens eam 10.2.2
EditorConfig Edi 0.15.1
tslint eg2 1.0.44
vscode-npm-script eg2 0.3.12
auto-close-tag for 0.5.7
auto-complete-tag for 0.1.0
auto-rename-tag for 0.1.3
angular-essentials joh 9.0.1
Angular2 joh 9.1.2
vscode-peacock joh 3.7.2
debugger-for-chrome msj 4.12.8
debugger-for-edge msj 1.0.15
angular2-inline nat 0.0.17
angular-console nrw 12.0.0
material-icon-theme PKi 4.1.0
typescript-hero rbb 3.0.0
code-settings-sync Sha 3.4.3
autoimport ste 1.5.3
move-ts str 1.12.0
highlight-matching-tag vin 0.9.9

(5 theme extensions excluded)

</details> <!-- generated by issue reporter -->

closed time in 6 days

ersuman

issue commentmicrosoft/vscode

Terminal not showing text

That text color looks like semantic tokens, it's probably as designed but you can create a new issue if you want.

ersuman

comment created time in 6 days

issue commentmicrosoft/vscode

Terminal errors: include settings ID in the error message

This is not as straightforward as it might first seem as the source of the executable for example could be many things (setting, task, debug, ext host). It would definitely be a nice improvement though, especially if terminal.integrated.shellArgs.osx was a link to the settings UI.

egamma

comment created time in 6 days

push eventmicrosoft/vscode

Daniel Imms

commit sha 06b9d1850f21c5abcc5c414a9295414fb39d8647

Don't call ext link provider for empty lines Fixes #101452

view details

push time in 6 days

issue closedmicrosoft/vscode

Avoid calling `provideTerminalLinks` for empty lines

Testing #101300

While an extension can easily filter this, I think we should avoid the processing overhead when a line is missing or effectively blank.

closed time in 6 days

eamodio

issue commentmicrosoft/vscode

Consider changing TerminalLink endIndex to length

I liked length as well but changed it to align with (some) other VS Code APIs. The xterm.js API uses length.

eamodio

comment created time in 6 days

push eventmicrosoft/vscode

Daniel Imms

commit sha 0fe3b64da887b7984242dc59b50969bef3df40b0

Add warning about async usage of provideTerminalLinks Fixes #101458

view details

push time in 6 days

issue closedmicrosoft/vscode

Add a note of caution about using shared regex in `provideTerminalLinks`

Testing #101300

If an extension uses a shared RegExp instance with the global flag in provideTerminalLinks with await calls , it could lead to unexpected results. This is because a RegExp object with global flag maintains state as you loop over the matches, and if there are any await calls inside that loop, another call to provideTerminalLinks could be executed, re-using that same RegExp instance -- effectively mixing/corrupting the results.

Since IMO, RegExp parsing (especially with the global flag) will likely be common within this API, I think it is worth a note of caution.

closed time in 6 days

eamodio

issue closedmicrosoft/vscode

LiveShare Terminal doesn't resize properly

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version:
    • Version: 1.46.1 (user setup)
    • Commit: cd9ea6488829f560dc949a8b2fb789f3cdc05f5d
    • Date: 2020-06-17T21:13:20.174Z
    • Electron: 7.3.1
    • Chrome: 78.0.3904.130
    • Node.js: 12.8.1
    • V8: 7.8.279.23-electron.0
  • OS Version: Windows_NT x64 10.0.19041 (Windows 10 Home)

Steps to Reproduce:

  1. Open VSCode on two devices A and B
  2. Start a LiveShare session on A
  3. Connect to the LiveShare session on B
  4. Start a terminal instance on A
  5. Open the terminal on B
  6. Resize your window / the terminal
  7. The terminal section won't expand, but instead will be squished in the original small part: image

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled? No, because LiveShare doesn't work in this case

closed time in 6 days

marcelgarus

issue commentmicrosoft/vscode

LiveShare Terminal doesn't resize properly

/duplicate https://github.com/microsoft/vscode/issues/55718

marcelgarus

comment created time in 6 days

issue closedmicrosoft/vscode

Adding a new terminal window of a type other than the default type without having to change the default type setting

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. --> The current UI for adding a new terminal suggests that a developer sets one type of terminal as default and keeps on adding/opening multiple terminal of that same type.

But if I use two types of terminals in my day to day work I always have to add a terminal then go change the default type then add another one and if the last one is not the one I want to be as default then I have to go and set the default again.

I would like to be able to add a new terminal window of a type other than the default by just choosing it, without the need to go and change the default type.

Something like this:

image

My setup info: Version: 1.46.1 (user setup) Commit: cd9ea6488829f560dc949a8b2fb789f3cdc05f5d Date: 2020-06-17T21:13:20.174Z Electron: 7.3.1 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.18363

Thank you

closed time in 6 days

BaherWael

issue commentmicrosoft/vscode

Add bottom margin to issue hover

@alexr00 quick fix seems to be adding this to the spans: display: inline-block; margin-bottom: 4px, not sure what the right fix is though.

isidorn

comment created time in 6 days

issue commentmicrosoft/vscode

Preferences sync fails "RemoteTooManyRequests"

@sandy081 the log with execution id should be enough, I think that's only available in trace logs? (F1, "set log level", "trace")

selfagency

comment created time in 6 days

push eventmicrosoft/vscode

Daniel Imms

commit sha 37ca38a4fbada14761595cc2a641b8dabe8b2fc0

Add note about re-using options objects Fixes #101495

view details

push time in 6 days

issue commentmicrosoft/vscode

Allow extensions to contribute links to the terminal (aka link providers)

Things to discuss in API call:

  • Consider adding a command object to TerminalLink rather than the handleTerminalLink method https://github.com/microsoft/vscode/issues/101457
  • Consider making handleTerminalLink return a Promise https://github.com/microsoft/vscode/issues/101391
  • TerminalLink endIndex should be inclusive (and it should say that in the documentation) https://github.com/microsoft/vscode/issues/101394
Tyriar

comment created time in 6 days

push eventmicrosoft/vscode

Daniel Imms

commit sha 71b845cca22a09cbb6549f14dc38fb982ab08cf1

Shell path -> shell executable Fixes #101482

view details

push time in 6 days

issue closedmicrosoft/vscode

Align error message with task configuration terminology

Testing https://github.com/microsoft/vscode/issues/101299

In the task.json the shell is configured with the property executable

image

The error message uses the term path

image

For example: ... Shell execrable "foo" does not exist.

closed time in 6 days

egamma

issue commentmicrosoft/vscode

Add bottom margin to issue hover

I don't think @isidorn is complaining about a 1px gap though, which is possibly due to the font anyway. The reason the original screenshot looks weird is because the background takes up 4 out of 8 pixels in the bottom padding. It should look like the left side of this:

image

isidorn

comment created time in 6 days

issue commentmicrosoft/vscode

Issue hover should not go away this easy

Oh I see the flash now, I think there's an issue with the implementation in issues then. @alexr00 have you set up your hover target to be an element the size of the full list item without a gap between it and the hover?

isidorn

comment created time in 6 days

push eventmicrosoft/vscode

Daniel Imms

commit sha 1a62c8a641b4a333768497e831723ff82a285df0

Require ctrl on link provider link Fixes #101473

view details

push time in 6 days

issue closedmicrosoft/vscode

Links should only be "handled" on ctrl+click

Testing #101300

It seems that links are executed on click, not only ctrl+click

closed time in 6 days

eamodio

issue openedmicrosoft/vscode

Add opt-in setting for settings sync in stable

This is in addition to the preview warning when enabling sync. Proposal: sync.enablePreview

created time in 6 days

issue commentmicrosoft/vscode

Issue hover should not go away this easy

@isidorn do you expect some delay allowing you to mouse out and mouse back in? Note that GitHub doesn't have that.

isidorn

comment created time in 6 days

issue commentmicrosoft/vscode

Add bottom margin to issue hover

The padding is just right for terminal links:

image

It looks like the background around the text is drawing into that padding?

isidorn

comment created time in 6 days

push eventxtermjs/xterm.js

dependabot-preview[bot]

commit sha b6259d3e7e82683495663dd54c8c578517c8daba

Bump source-map-loader from 1.0.0 to 1.0.1 Bumps [source-map-loader](https://github.com/webpack-contrib/source-map-loader) from 1.0.0 to 1.0.1. - [Release notes](https://github.com/webpack-contrib/source-map-loader/releases) - [Changelog](https://github.com/webpack-contrib/source-map-loader/blob/master/CHANGELOG.md) - [Commits](https://github.com/webpack-contrib/source-map-loader/compare/v1.0.0...v1.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Daniel Imms

commit sha 7ce47c474a1a28c270b3f88a3ba02428f8bc8db4

Merge pull request #2985 from xtermjs/dependabot/npm_and_yarn/source-map-loader-1.0.1 Bump source-map-loader from 1.0.0 to 1.0.1

view details

push time in 6 days

delete branch xtermjs/xterm.js

delete branch : dependabot/npm_and_yarn/source-map-loader-1.0.1

delete time in 6 days

PR merged xtermjs/xterm.js

Bump source-map-loader from 1.0.0 to 1.0.1 dependencies

Bumps source-map-loader from 1.0.0 to 1.0.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/webpack-contrib/source-map-loader/releases">source-map-loader's releases</a>.</em></p> <blockquote> <h2>v1.0.1</h2> <h3><a href="https://github.com/webpack-contrib/source-map-loader/compare/v1.0.0...v1.0.1">1.0.1</a> (2020-06-30)</h3> <h3>Bug Fixes</h3> <ul> <li>webpack protocol (<a href="https://github.com/webpack-contrib/source-map-loader/commit/a2e4cd6be7f9ff9024c201093f1410431f7a48e9">a2e4cd6</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/webpack-contrib/source-map-loader/blob/master/CHANGELOG.md">source-map-loader's changelog</a>.</em></p> <blockquote> <h3><a href="https://github.com/webpack-contrib/source-map-loader/compare/v1.0.0...v1.0.1">1.0.1</a> (2020-06-30)</h3> <h3>Bug Fixes</h3> <ul> <li>webpack protocol (<a href="https://github.com/webpack-contrib/source-map-loader/commit/a2e4cd6be7f9ff9024c201093f1410431f7a48e9">a2e4cd6</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/webpack-contrib/source-map-loader/commit/7d127a942e7d340a7be9865a987a3c09c2dfff09"><code>7d127a9</code></a> chore(release): 1.0.1</li> <li><a href="https://github.com/webpack-contrib/source-map-loader/commit/a2e4cd6be7f9ff9024c201093f1410431f7a48e9"><code>a2e4cd6</code></a> fix: webpack protocol</li> <li>See full diff in <a href="https://github.com/webpack-contrib/source-map-loader/compare/v1.0.0...v1.0.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+5 -5

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 6 days

IssuesEvent

issue commentmicrosoft/vscode

"synced undefined"

This never went away for me, it's still there after uninstalling the language pack.

image

Tyriar

comment created time in 7 days

issue commentmicrosoft/vscode

Consider making `handleTerminalLink` return a Promise

What would it return? I removed the old TerminalLink.target? property which could be filled in as I thought this was simpler.

alexr00

comment created time in 7 days

issue commentmicrosoft/vscode

TerminalLink endIndex should be inclusive (and it should say that in the documentation)

InputBoxOptions.valueSelection uses exclusive end index, so does String.prototype.substring. Opinions @jrieken?

alexr00

comment created time in 7 days

issue openedmicrosoft/vscode

options in showSaveDialog/showOpenDialog should be optional

Testing #101279

// Works
vscode.window.showSaveDialog({});

// Doesn't work:
vscode.window.showSaveDialog();

Options objects are optional in showTextDocument and showQuickPick for example.

created time in 7 days

issue openedmicrosoft/vscode

Welcome page can have vertical scroll bar when product header is visible

It looks like this is not meant to happen:

recording (2)

created time in 7 days

issue commentmicrosoft/vscode

SCM Open and Open in New Window do the same thing

Also consider swapping the "Open" action based on the setting as well, eg the buttons could be either "Open" and "Open in New Window", or "Open" and "Open in This Window".

Tyriar

comment created time in 7 days

issue openedmicrosoft/vscode

SCM context menu vertical alignment is off

Testing #101302

image

created time in 7 days

issue openedmicrosoft/vscode

Publish to GitHub uses opened folder for the repo name, not the workspace that was clicked on

Testing #101302

Expected Tyriar/test when clicking publish for the "test" folder, not its parent:

image

created time in 7 days

push eventmicrosoft/vscode

Daniel Imms

commit sha 639a21b145ba38007a2b5ee9d4233ac6a6067e89

Add ending period to terminal launch notification messages Fixes #101344

view details

push time in 7 days

issue closedmicrosoft/vscode

Small type in trouble shoot message

Testing #101299

capture

The sentence should have a ending period.

closed time in 7 days

dbaeumer

issue openedmicrosoft/vscode

SCM Open and Open in New Window do the same thing

Testing #101302

image

These do the same thing when "window.openFoldersInNewWindow": "on" is set. Open recent respects this only when not using modifiers:

image

created time in 7 days

issue commentmicrosoft/vscode

SCM: Improve repositories CSS layout

@joaomoreno I suggest only showing the actions when the section is hovered or expanded as that's when they seem to be useful. When you're not actively working on a repo the change count and branch are probably the most important, the latter of which gets truncated currently.

sstoychev

comment created time in 7 days

issue commentmicrosoft/vscode

Support hyperlink ansi escapes in the integrated terminal

@ssbarnea what you're point out is by design, the file is recognized and is opened in the editor just like any other file. You can create a feature request for this if you would like, as I don't think it has anything to do with this issue.

sindresorhus

comment created time in 7 days

push eventmicrosoft/vscode

Daniel Imms

commit sha 01d0314308fdf83801c3d7abf43b7a2702ea9263

Change troubleshoot button to 'Open Help' Fixes #101345

view details

push time in 7 days

issue closedmicrosoft/vscode

The TroubelShoot button promises too much

Testing #101299

As a Windows user I was expecting a troubleshoot wizard. May be we should name the button 'Open Documentation' or 'Open Help'

closed time in 7 days

dbaeumer
more