profile
viewpoint
Michael Matloka Twixes @PostHog nullptr https://matloka.com Software Engineer

Twixes/SF-Mono-Powerline 279

Apple's SF Mono font patched for Powerline support

Twixes/somsiad 8

The Polish Discord bot

Twixes/pypi-assistant 3

pip requirements files now enhanced with up-to-date package information at a glance – a VS Code extension

Twixes/debris 2

Discord-based file hosting built with Express and Vue

PostHog/posthog-zapier 1

Zapier integration for PostHog.

Twixes/adder 0

Expression adder

Twixes/antimark 0

A teacher evaluation platform built with Django and Vue

Twixes/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

Twixes/matloka.com 0

A professional website

Twixes/movieproxy 0

A Django REST API exercise

PR opened PostHog/posthog

Update Node dependencies

Changes

Some non-breaking dependencies and devDependencies updates. Also removed react-stripe-elements, as they seemed unused (at least at the moment).

+1124 -916

0 comment

2 changed files

pr created time in 3 hours

create barnchPostHog/posthog

branch : node-module-updates-2020-08

created branch time in 3 hours

push eventPostHog/posthog

Eric Duong

commit sha c0b4500d3a6d9fea6037e741b0db42713cdaa091

Remove trends empty condition (#1416) * remove empty condition * update tests * remove unnecesary time freeze * Add no events provided test Co-authored-by: Twixes <dev@twixes.com>

view details

push time in 3 hours

delete branch PostHog/posthog

delete branch : remove-show-all-empty

delete time in 3 hours

PR merged PostHog/posthog

Reviewers
Remove trends empty condition

Changes

Please describe.
Trends had a snippet that loaded all actions when none were specified. This causes an overload

If this affects the front-end, include screenshots.
Screen Shot 2020-08-12 at 3 03 12 PM

Suggesting a removal because it was unexpected UX when I encountered it

Checklist

  • [ ] All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • [ ] Backend tests (if this PR affects the backend)
  • [ ] Cypress E2E tests (if this PR affects the front and/or backend)
+42 -22

1 comment

2 changed files

EDsCODE

pr closed time in 3 hours

push eventPostHog/posthog

Twixes

commit sha 9e25be2837c696c3425198fde06c195d00ecefb5

Add no events provided test

view details

push time in 4 hours

push eventPostHog/posthog

Yakko Majuri

commit sha 3bcfecbe9ea5fa107f3ee6b51901298ebb686d56

Added warning for unset SECRET_KEY (#1426) * Added warning for unset SECRET_KEY * added process exit * Reword message This should be just a bit clearer (also "Process exited with code …" is redundant, I think). * added SECRET_KEY to github actions * updated to add docker placeholder key * minor update to default secret key Co-authored-by: Michael Matloka <dev@twixes.com>

view details

push time in 6 hours

delete branch PostHog/posthog

delete branch : secret-key-warning

delete time in 6 hours

PR merged PostHog/posthog

Reviewers
Added warning for unset SECRET_KEY

Changes

Please describe.
If this affects the front-end, include screenshots.

Currently, if the user doesn't set a SECRET_KEY, we just fall back to a default key. This seems ok but it isn't. We're open source, so that default key is public knowledge.

In my view, we should actually consider exiting if the user hasn't set their own SECRET_KEY. Nevertheless, at least a warning is in order. However, if the user is in TEST or DEBUG mode the warning is suppressed.

Here's some reading on the topic.

Checklist

  • [ ] All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • [ ] Backend tests (if this PR affects the backend)
  • [ ] Cypress E2E tests (if this PR affects the front and/or backend)
+17 -1

6 comments

3 changed files

yakkomajuri

pr closed time in 6 hours

pull request commentPostHog/posthog

Added warning for unset SECRET_KEY

What about using just one DEFAULT_SECRET_KEY with value "<randomly generated secret key>"? That should makes things clearer.

yakkomajuri

comment created time in 8 hours

PR opened PostHog/posthog

1269 funnel trends

Changes

This adds funnel trends. A few changes to existing code: For clarity on what is what, "FunnelViz" now refers to funnel visualizations in general, while steps in particular became "FunnelSteps". Trends are "FunnelTrends". Made use of Enum for endpoint cache types. In general Enums are tremendously practical, so it'd be good to make use of them in a few more places (better in another PR). A few more components are TypeScript now, types spark joy (though I see the changes to ChartFilter were too drastic for Git's diff algorithm, which claims it's a new file altogether – doesn't spark joy).

Frontend's not as functional as it should be atm (a bit tricky to mash trends and funnels logic here nicely), so draft until that's done ASAP.

Checklist

  • [x] All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • [ ] Backend tests (if this PR affects the backend)
  • [ ] Cypress E2E tests (if this PR affects the front and/or backend)
+599 -274

0 comment

37 changed files

pr created time in 10 hours

push eventPostHog/posthog

Twixes

commit sha f5a0339606fa436a309a0272d8eb9cb28e3219cc

Refactor InsightTabs into insightFilters

view details

Twixes

commit sha fdceda4405077623ee8022b2dc291778488b34e8

Improve card style

view details

Twixes

commit sha ec31d8156c7c6a5600a865461ad861cd1fdb06b4

Add most of funnel trends

view details

push time in 11 hours

pull request commentPostHog/posthog

Kea TypeGen 0.2

Also, VS Code won't include these in workspace search results anymore. 👌

mariusandra

comment created time in 11 hours

pull request commentPostHog/posthog

Added warning for unset SECRET_KEY

SECRET_KEY will have to be added to GitHub actions.

yakkomajuri

comment created time in 16 hours

push eventPostHog/posthog

Michael Matloka

commit sha 47892a479141761f38ae31a57d825d3c4dc80768

Reword message This should be just a bit clearer (also "Process exited with code …" is redundant, I think).

view details

push time in 16 hours

create barnchPostHog/posthog.com

branch : securing-posthog-missing-space

created branch time in 19 hours

create barnchPostHog/posthog.com

branch : array-1.13.0-extraneous-period

created branch time in 19 hours

pull request commentPostHog/posthog

Added warning for unset SECRET_KEY

I think sys.exit(1) after that print_warning would make sense.

yakkomajuri

comment created time in 20 hours

Pull request review commentPostHog/posthog

Fix Heatmap broken CSS selector with button[href=]

 export function elementToSelector(element: ElementType): string {             .map((a) => `.${cssEscape(a)}`)             .join('')     }-    if (element.href) {+    if (element.href && element.tag_name === 'a') {

Ah, so the the parent anchor's href was pulled into its child's selector 👍 (well, technically a button could have href too, but only for some dev purposes really).

mariusandra

comment created time in a day

Pull request review commentPostHog/posthog

Fix Heatmap broken CSS selector with button[href=]

 export function elementToSelector(element: ElementType): string {             .map((a) => `.${cssEscape(a)}`)             .join('')     }-    if (element.href) {+    if (element.href && element.tag_name === 'a') {

[href=*] selectors only work on anchor elements?

mariusandra

comment created time in a day

pull request commentPostHog/posthog.com

Landing page v2

Soviet Union was literally what Gosha Sans' designers were going for. 😄 Here's even a sample that they used on the font's page.

USSR

I like it though (while not knowing cyrillic).

berntgl

comment created time in a day

issue commentPostHog/posthog

[EPIC] Move to ClickHouse

Shouldn't testing be the same as it is now? The output data should be the same regardless of the DB. Is there more to this than that?

timgl

comment created time in a day

issue commentPostHog/posthog.com

Keyboard navigation accessibility problems

I agree that outline is crucial. If we only want it visible on keyboard navigation, I've found https://github.com/WICG/focus-visible to be a really simple and reliable solution.

ungless

comment created time in 2 days

issue commentPostHog/posthog

Upgrading 1.21.1

Sure!

yormy

comment created time in 2 days

issue openedPostHog/posthog

HTTPS warning in production

Is your feature request related to a problem?

It should be emphasized that PostHog should be ran in production with TLS.

Describe the solution you'd like

A fixed bar – similar to the debug one – warning that TLS (https://) is a must when running over http:// with DEBUG false.

Additional context

This was suggested by @mariusandra in the onboarding rework Figma document.

Thank you for your feature request – we love each and every one!

created time in 2 days

issue openedPostHog/posthog.com

Change media page images

Our media page should contain PNGs of the logos (best in a smaller and in a larger size), since that's usually more practical than vectors. Also, vector images don't need two size versions – the data is the same for both anyway.

created time in 2 days

issue closedPostHog/posthog

Upgrading 1.21.1

I tried upgrading to 1.21.1 but I still see 1.12 in my version

 docker-compose pull web
 docker rm posthog_web -f
 docker-compose up -d web

Something I noticed is that on docker hub the latest release is : 2585e95 When I go to that commit in github i see in the changelog : Bump version 1.12.0 (#1301) When I shell into the web container, I cannot see the changelog so I cannot verify what version is in the container. But I assume that docker-hub still has 1.12 and not 1.12.1

closed time in 2 days

yormy

issue commentPostHog/posthog

Upgrading 1.21.1

Sorry for that mismatch! VERSION was left on 1.12.0 in settings.py, bumped it properly now. We're just about to release 1.13.0 though, so that'll be the Docker image to watch out for.

yormy

comment created time in 2 days

push eventPostHog/posthog

Michael Matloka

commit sha 47e34d0d820a3e3871048e210e150770eb69baa4

Bump settings.VERSION to 1.12.1 (#1421)

view details

push time in 2 days

delete branch PostHog/posthog

delete branch : bump-1.12.1

delete time in 2 days

PR merged PostHog/posthog

Bump settings.VERSION to 1.12.1

Changes

It remained on 1.12.0, while our update server says 1.12.1 is the latest version.

+1 -1

0 comment

1 changed file

Twixes

pr closed time in 2 days

pull request commentPostHog/posthog

Fixes silent fail on empty capture request

Quite odd, not sure what's the problem. 🤔

paolodamico

comment created time in 2 days

PR opened PostHog/posthog

Bump settings.VERSION to 1.12.1

Changes

It remained on 1.12.0, while our update server says 1.12.1 is the latest version.

+1 -1

0 comment

1 changed file

pr created time in 2 days

create barnchPostHog/posthog

branch : bump-1.12.1

created branch time in 2 days

push eventpaolodamico/posthog

Twixes

commit sha 3d15a7f657a3812242335a8fc9c1acffe85d959f

Change a few words in /capture error messages

view details

push time in 2 days

Pull request review commentPostHog/posthog.com

Close #296: Update Webhook Docs

 showTitle: true 1. The dialog window will present a unique URL that will map to the channel. Make sure that you copy and save the URL—you will need to provide it to the outside service. 1. Select the Done button. The webhook will be available in the team channel. -[See Microsoft Team's documentation for more info](https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/add-incoming-webhook#add-an-incoming-webhook-to-a-teams-channel)+[See the Microsoft Teams Documentation for more info](https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/add-incoming-webhook#add-an-incoming-webhook-to-a-teams-channel).

I think "documentation" could be lowercase, it's not the name of a product or anything

yakkomajuri

comment created time in 2 days

Pull request review commentPostHog/posthog.com

Close #296: Update Webhook Docs

 showTitle: true ---  ## 1. Create app-Go to https://api.slack.com/apps?new_app=1 and create a new app. Call it "PostHog" and connect it to the workspace of your choice.-Feel free to use [this image](https://user-images.githubusercontent.com/53387/78905411-3ad92a00-7a7e-11ea-82e2-ba53e44ec4e3.png) as the app's logo.+Go to the [Slack page to create apps](https://api.slack.com/apps?new_app=1) and create a new app. Call it "PostHog" and connect it to the workspace of your choice.++Feel free to use an image from [here](/media) as the app's logo.  ![image](https://user-images.githubusercontent.com/53387/78574619-86939580-782a-11ea-8617-caf1ffe2783a.png)  ## 2. Create Webhook-Go to the "incoming webhooks" page and click on "add a new webhook". Select the channel that the notifications will be posted to:+Go to the 'Incoming Webhooks' page for your newly-created app and toggle 'Activate Incoming Webhooks' to turn it on. Then click on 'Add New Webhook to Workspace' and select the channel that the notifications will be posted to:  ![image](https://user-images.githubusercontent.com/53387/78574881-ec801d00-782a-11ea-9b87-8a40e49dd912.png) -## 3. Copy URL-Copy the webhook URL into the PostHog Setup page:+## 3. Setup Webhook in Posthog

PostHog

yakkomajuri

comment created time in 2 days

pull request commentPostHog/posthog.com

Close #296: Update Webhook Docs

Ah, I didn't notice "View more details"! So that's really handy

yakkomajuri

comment created time in 2 days

pull request commentPostHog/posthog.com

Close #296: Update Webhook Docs

Is there a way to see a preview deployment of these with GitHub?

yakkomajuri

comment created time in 2 days

push eventPostHog/posthog

Twixes

commit sha c4b6436abf7129785986e2d70d06199d5d595cc4

Take new User query into account in test

view details

push time in 2 days

issue commentPostHog/posthog

Issue running locally with Docker

How long did you wait for it to build? It might take a minute or two.

paolodamico

comment created time in 2 days

issue commentPostHog/posthog

Issue running locally with Docker

There's no screenshot!

paolodamico

comment created time in 2 days

pull request commentPostHog/posthog

Launch Toolbar cleanup

I feel like such a tooltip would be too loaded. Maybe just a quick explanation of what the Toolbar allows you to do, and a "See what it can do for you" type link to a page showing such animated examples.

Twixes

comment created time in 3 days

pull request commentPostHog/posthog

Launch Toolbar cleanup

This looks pretty good actually, I think.

HogIcon

Twixes

comment created time in 3 days

push eventPostHog/posthog

Twixes

commit sha 7e69d429791d0491bd727710f0082ba9b6fe7694

Replace RocketOutlined with HogIcon

view details

push time in 3 days

pull request commentPostHog/posthog

Launch Toolbar cleanup

There are a few modal fixes in here as well, so I can revert the button to the current look or make it toolbar-like the way I showed before. Which would be better?

Twixes

comment created time in 3 days

pull request commentPostHog/posthog

[WIP] #1353 Updated README

I'd definitely love to make the demo more elegant. Not much of an effort, so I think I'll take this on quickly after some backend work I'm currently on (unless something else turns out to be particularly important).

yakkomajuri

comment created time in 3 days

pull request commentPostHog/posthog

Launch Toolbar cleanup

I'd say we could merge this for now and put a larger overhaul of feature discoverability on the roadmap for a bit later.

Twixes

comment created time in 3 days

issue commentPostHog/posthog

Event capturing bug

No, that seems to work as expected, at least to me. Maybe there's something else at play here.

paolodamico

comment created time in 3 days

issue commentPostHog/posthog

Event capturing bug

Hm, I tried reproducing and seems like a malformed timestamp causes a quiet failure, but didn't experience any unexpected behavior other than that.

paolodamico

comment created time in 3 days

pull request commentPostHog/posthog.com

Added API Key Auth to Docs

Definitely safer to have this as a draft for now.

yakkomajuri

comment created time in 4 days

pull request commentPostHog/posthog

Fix clicks counted multiple times

What is domElements.length is > 1?

mariusandra

comment created time in 4 days

create barnchPostHog/posthog.com

branch : revert-227-personal-api-keys

created branch time in 4 days

pull request commentPostHog/posthog.com

Describe personal API key auth

https://github.com/PostHog/posthog/pull/1281 hasn't gone live yet! And probably won't this week, so this should stay on hold

Twixes

comment created time in 4 days

push eventPostHog/posthog

Marius Andra

commit sha e9d9b98d63ad3619c79e1f0497b4059071d14a50

Upgrade posthog-js to 1.4.2 (#1401)

view details

push time in 4 days

delete branch PostHog/posthog

delete branch : 1352-capture-toolbar-clicks

delete time in 4 days

PR merged PostHog/posthog

Reviewers
Capture toolbar clicks

Changes

  • Resolves #1352
  • Related: https://github.com/PostHog/posthog-js/pull/78

Checklist

  • [ ] All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • [ ] Backend tests (if this PR affects the backend)
  • [ ] Cypress E2E tests (if this PR affects the front and/or backend)
+5 -5

0 comment

2 changed files

mariusandra

pr closed time in 4 days

issue closedPostHog/posthog

[Toolbar] We should capture clicks even when toolbar is open

Bug description

As a user who's just using the toolbar, it's confusing that when I create an action it doesn't have any clicks (even by me).

Expected behavior

We should capture events. We should have better ways of not capturing data of test users

How to reproduce

  1. Open toolbar

Environment

  • PostHog cloud or self-managed? both
  • PostHog version/commit latest

Additional context

This came out of a customer interview

Thank you for your bug report – we love squashing them!

closed time in 4 days

timgl

pull request commentPostHog/posthog-js

Capture actions if using toolbar

Has this problem been reported by a customer? I'd say we shouldn't count devs/admins snooping around, but if this is confusing to them, then this should fine.

I think a general solution to internal traffic skewing numbers would be PostHog sever-side IP exclusion settings, the way Google Analytics does it. Mentioned this in https://github.com/PostHog/posthog/issues/966#issuecomment-652932807.

mariusandra

comment created time in 4 days

startedPostHog/posthog-js-lite

started time in 4 days

startedPostHog/posthog-js

started time in 4 days

startedPostHog/posthog.com

started time in 4 days

startedPostHog/posthog

started time in 4 days

startedPostHog/posthog

started time in 4 days

pull request commentPostHog/posthog

Add enterprise edition and licensing

What's the use case for multiple licenses per team?

timgl

comment created time in 4 days

issue openedPostHog/posthog.com

Update webhooks usage docs

created time in 4 days

pull request commentPostHog/posthog.com

Slack integration docs

To be merged on next app deploy.

ungless

comment created time in 4 days

push eventPostHog/posthog

Twixes

commit sha 090640a674187b209307955350b38ed998671600

Minor fixes

view details

push time in 4 days

push eventPostHog/posthog

Twixes

commit sha d8f6e2643b85108f5f72e64a5fcc5dd76cba3338

Make message format input clearer

view details

Twixes

commit sha 7eada4b412a9a3b2f3180e62e9435719d67082f2

Make post_event_to_webhook more resilient with retries

view details

push time in 4 days

pull request commentPostHog/posthog

Enhancement (#1156) Adding more slack context via tokenisation

Made the UI just a bit friendlier. This will probably require updating the docs (screenshots too).

Edit action

Setup

ungless

comment created time in 4 days

push eventPostHog/posthog

Twixes

commit sha 6a4defe89e8c387c275a25c0fe0b621c42ced3e2

Change tasks.slack to tasks.webhooks

view details

push time in 4 days

push eventPostHog/posthog

Twixes

commit sha 49edb753cc2f7b59bc8f10348a0393445966dc47

Refactor webhooks to be more universal

view details

push time in 4 days

push eventPostHog/posthog

Twixes

commit sha ae6caf07619a87dea003417350abcc45f3ffc8be

Improve Edit action webhook configuration UI

view details

push time in 4 days

push eventPostHog/posthog

Twixes

commit sha 6af1c750c4e96985025b7f382e72786a3d024989

Update test_user.py

view details

push time in 4 days

push eventPostHog/posthog

Twixes

commit sha d6ef0254f44e8ce857bfc79052bd680c5a3ee500

Reword Setup #webhooks description

view details

push time in 4 days

push eventPostHog/posthog

Twixes

commit sha 8f7137a851cbef980a1444b409a76f1a99084df6

Refactor slightly and improve UX

view details

push time in 4 days

push eventPostHog/posthog

Marius Andra

commit sha c4eef98f0eec17be97af226554027f471a5e1439

update posthog-js (#1385)

view details

Marius Andra

commit sha 7a1a7d9a28c2e9b0bc6764e9c4043f04a814b057

remove samesite middleware (#1384)

view details

Michael Matloka

commit sha 85fe3b9a62408d11d8aab5bff316c59b43c8ae12

Add DEBUG overlay bar (#1378) * Add DEBUG overlay bar * Add z-index * Implement a tricolor bottom bar * Add close button and replaced version with git branch * Improve responsiveness * Remove extra span opening tag

view details

Michael Matloka

commit sha 7b9abe4d6183aa1830740161b593cda812568130

Enhance version notice (#1386) * Enhance version notice * Update notice and use TypeScript * Use "newest" everywhere

view details

Marius Andra

commit sha aaf004a5ebeddf668dce34fffc60bbbb90eb9fc3

Extract people merging to Person, add cohort support. (#1362)

view details

James Greenhill

commit sha eec2445dbc00a495947cf454f8d7302f9e0aa080

Bugfix: Github actions can't use off the shelf docker images. Install packer manually (#1304)

view details

Eric Duong

commit sha 9cc2a46bfe7c7d913c2717e3a57e44c56a157d81

Poll funnels (#1366) * working poll funnels * remove packages * update test to use polling * fix types

view details

Michael Matloka

commit sha 22e92f9da13395465121c6844946e88ef9f5722b

Merge branch 'master' into improve-github-workflows

view details

push time in 4 days

Pull request review commentPostHog/posthog

Enhance and optimize PR GitHub workflows

 django-redis==4.12.1 django-statsd==2.5.2 djangorestframework==3.11.0 djangorestframework-csv==2.1.0+freezegun==0.3.15

Hm, wouldn't be a problem but yeah, since only tests need freezegun and they're run with prod requirements.txt only, I just put it into the GH workflow.

Twixes

comment created time in 4 days

push eventPostHog/posthog

Twixes

commit sha ffa779d6a425a13541c4444065017e42b9b82742

Revert "Put freezegun into prod requirements" This reverts commit 460e3942d10194e9f46c8a2196ebd9ecc1f23c6f.

view details

Twixes

commit sha b690e682f3e97e67505cb35364251e577068c674

Install freezegun in workflow and update dev.txt

view details

push time in 4 days

pull request commentPostHog/posthog

Personal API keys and Zapier integration

If you want to test Zapier integration locally, create a private integration with https://github.com/PostHog/posthog-zapier. It should be a smooth process.

Twixes

comment created time in 5 days

push eventPostHog/posthog

Twixes

commit sha e082fc6ac30773620f6787cc1dd00842c43c7191

Remove extra span opening tag

view details

push time in 7 days

pull request commentPostHog/posthog

Add DEBUG overlay bar

I think this should be clear enough?

DEBUG

Twixes

comment created time in 7 days

Pull request review commentPostHog/posthog

Enhance version notice

 export function ChangelogModal({ onDismiss }) {             footer={<Button onClick={onDismiss}>Close</Button>}             style={{ top: 20, minWidth: '70%', fontSize: 16 }}         >-            {window.location.href.indexOf('app.posthog.com') === -1 ? (+            {!window.location.href.includes('app.posthog.com') ? (                 <span>-                    You're currently on version <strong>{user.posthog_version}</strong>+                    You're on version <b>{user.posthog_version}</b> of PostHog.{' '}+                    {latestVersion &&+                        (latestVersion !== user.posthog_version ? (+                            'This is the latest one.'+                        ) : (+                            <>+                                The latest one is <b>{latestVersion}</b>.

Maybe

You're on PostHog 1.2.3. The newest version is 1.2.4. You're on PostHog 1.2.4. This is the newest version.

instead?

Twixes

comment created time in 8 days

push eventPostHog/posthog

Twixes

commit sha a3e59adcd854a687f37998654c598cf34e5f0a8c

Use "newest" everywhere

view details

push time in 8 days

push eventPostHog/posthog

Twixes

commit sha ad4df5181851ded5d5caa95cb2220723e55a5d14

Update notice and use TypeScript

view details

push time in 8 days

PR opened PostHog/posthog

Enhance version notice

Changes

This makes it clear which version is the latest one even if https://update.posthog.com/changelog hasn't been updated.

Version behind Version behind

Version up to date Version up to date

+34 -11

0 comment

3 changed files

pr created time in 8 days

create barnchPostHog/posthog

branch : version-notice

created branch time in 8 days

pull request commentPostHog/posthog

Add DEBUG overlay bar

It should fit in one line on mobile now.

Twixes

comment created time in 8 days

push eventPostHog/posthog

Twixes

commit sha 111e2bfd7bca204e367eaaa37f02a45cfc9bcd94

Improve responsiveness

view details

push time in 8 days

pull request commentPostHog/posthog

Add DEBUG overlay bar

Take a look at this then:

Debug toolbar with changes

Twixes

comment created time in 8 days

push eventPostHog/posthog

Twixes

commit sha 0dfcfa8e6210003b1d5f224888409dca40d57589

Add close button and replaced version with git branch

view details

push time in 8 days

Pull request review commentPostHog/posthog

Close #1292: Added tabs for distinguishing between different users

+/// <reference types="cypress" />+// ***********************************************************+// This example plugins/index.js can be used to load plugins+//+// You can change the location of this file or turn off loading+// the plugins file with the 'pluginsFile' configuration option.+//+// You can read more here:+// https://on.cypress.io/plugins-guide+// ***********************************************************++// This function is called when a project is opened or re-opened (e.g. due to+// the project's config changing)++/**+ * @type {Cypress.PluginConfig}+ */+module.exports = (on, config) => {+  // `on` is used to hook into various events Cypress emits+  // `config` is the resolved Cypress config+}

What's the point of this addition?

yakkomajuri

comment created time in 8 days

push eventyakkomajuri/posthog

Twixes

commit sha 4fc5dc713d19e40cce5574c26de8f232659b2d55

Improve variable naming

view details

push time in 8 days

push eventyakkomajuri/posthog

Twixes

commit sha 49e593f5a1a45a5325ff0781b9a188ed27e21d95

Improve code style

view details

Twixes

commit sha 6969dc1fa256770a4c3f93b68781f581ecb7ed8a

Improve regex and add compatilibity with demo data

view details

push time in 8 days

push eventPostHog/posthog

Marius Andra

commit sha c4eef98f0eec17be97af226554027f471a5e1439

update posthog-js (#1385)

view details

push time in 8 days

delete branch PostHog/posthog

delete branch : posthog-js-1.3.8

delete time in 8 days

PR merged PostHog/posthog

Reviewers
Update posthog-js to 1.3.8

Changes

Update posthog-js to 1.3.8, which includes some cookie fixes (Secure is set if running over https)

Checklist

  • [ ] All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • [ ] Backend tests (if this PR affects the backend)
  • [ ] Cypress E2E tests (if this PR affects the front and/or backend)
+5 -5

5 comments

2 changed files

mariusandra

pr closed time in 8 days

pull request commentPostHog/posthog

Update posthog-js to 1.3.8

Right, yarn.lock standing in the way. Alright, let's get just this in at 3 AM and wonder about other changes at not-3 AM.

mariusandra

comment created time in 8 days

more