profile
viewpoint
Bogdan Chadkin TrySound @realadvisor https://twitter.com/IAmTrySound Frontend-man! Love to Rollup and React. Gonna treeshake the world!

bvaughn/react-virtualized 20449

React components for efficiently rendering large lists and tabular data

bvaughn/js-search 1591

JS Search is an efficient, client-side search library for JavaScript and JSON objects

andreypopp/react-derivable 124

React bindings for derivable state computation library

ben-eb/postcss-svgo 85

DEPRECATED, see https://github.com/cssnano/cssnano | Optimise inline SVG with PostCSS.

ben-eb/postcss-zindex 77

DEPRECATED, see https://github.com/cssnano/cssnano | Reduce z-index values with PostCSS.

ben-eb/postcss-discard-comments 75

DEPRECATED, see https://github.com/cssnano/cssnano | Discard comments in your CSS files with PostCSS.

ben-eb/postcss-merge-rules 72

DEPRECATED (see https://github.com/cssnano/cssnano/tree/master/packages/postcss-merge-rules). Merge CSS rules with PostCSS.

ben-eb/css-values 59

Validate CSS property value pairs.

ben-eb/postcss-discard-duplicates 57

DEPRECATED, see https://github.com/cssnano/cssnano | Discard duplicate rules in your CSS files with PostCSS.

issue commentbabel/babel

SyntaxError: unknown: 'with' in strict mode

Thanks for the solution. This works well.

I have one more question.. I also need to instrument the contents of <script type='module> tags. This tag's contents should be treated as module, not script, right? Then is it that there will be cases that we get a transformation error when we give the sourceType: 'script' option for this?

gogo9th

comment created time in a few seconds

issue commenttesting-library/react-testing-library

Cannot find module 'pretty-format'

PR to fix that? sorry I'm still starting with this library, so I'm not enough expert for contribute in fixing errors.

losvedir

comment created time in 3 minutes

issue commentemotion-js/emotion

support remove styles of `injectGlobal`

This is an interesting use case but it's also quite problematic to handle right now and supporting this out of the box in the current injectGlobal could have been a breaking change.

You can implement your own version of injectGlobal under 20 LOC that would support this:

import { serializeStyles } from "@emotion/serialize";
import { StyleSheet } from "@emotion/sheet";
import { serialize, compile, middleware, rulesheet, stringify } from "stylis";

function injectGlobal(...args) {
  const { name, styles } = serializeStyles(...args);
  const sheet = new StyleSheet({
    key: `global-${name}`,
    container: document.head
  });
  const stylis = (styles) =>
    serialize(
      compile(styles),
      middleware([
        stringify,
        rulesheet((rule) => {
          sheet.insert(rule);
        })
      ])
    );
  stylis(styles);
  return () => sheet.flush();
}

You can check out the demo here. It's using React for rendering as that was just convenient for me but doesn't use any React-specific APIs for styling.

zhaoyao91

comment created time in 6 minutes

issue commenttesting-library/react-testing-library

Cannot find module 'pretty-format'

@jordisantamaria sure! if that's an issue would you like to submit a PR, please? 😃

losvedir

comment created time in 9 minutes

push eventrollup/plugins

Lukas Taegert-Atkinson

commit sha 0cc77c594f513d03bc87cbc1135a9ec3248ff4a7

chore(commonjs): Add logging

view details

push time in 10 minutes

issue commenttesting-library/react-testing-library

Cannot find module 'pretty-format'

Can can this error also be resolve for @testing-library/vue please.

losvedir

comment created time in 11 minutes

issue commentmui-org/material-ui

makeStyles overload breakage with TypeScript 4.1

Yeah, in hindsight, I think that we will do something this week. We still need to add support for React v17 and we can release.

danvk

comment created time in 11 minutes

issue commentmui-org/material-ui

[Select] menu breaks when container has CSS transform property

You can search them with the "Select" label, there are too many.

iddanh

comment created time in 14 minutes

issue commentmui-org/material-ui

makeStyles overload breakage with TypeScript 4.1

Ahh that's a bummer - I was also hoping for a soon v4 release of this as we will need to work on many upgrades like Typescript 4.1, react 17, ... and preparing for the Material UI v5 release 🎉 . Waiting until Q1 would mean also hold off on all other upgrades and then we would need to do all at once 🙈 - so if there is away (other than sprinkling @ts-ignores over all components) that would be much appreciated 🙏🏻

danvk

comment created time in 15 minutes

issue commentjonschlinkert/remarkable

Checkboxes support

I don't understand why this is not already in the plugin. Such an important addition

filipstefansson

comment created time in 16 minutes

issue commentmui-org/material-ui

[Select] menu breaks when container has CSS transform property

@oliviertassinari Thanks for the reply. Can you link those other issues here?

iddanh

comment created time in 16 minutes

issue commentfacebook/react

Feedback on useEffect depndencies change error

Yup - if you look at the code, it would seem that you can replace

    if (nextDeps.length !== prevDeps.length) {
      warning(
        false,
        'The final argument passed to %s changed size between renders. The ' +
          'order and size of this array must remain constant.\n\n' +
          'Previous: %s\n' +
          'Incoming: %s',
        currentHookNameInDev,
        `[${prevDeps.join(', ')}]`,
        `[${nextDeps.join(', ')}]`,
      );
    }

with

if (nextDeps.length !== prevDeps.length)
  return false

and then my use case would be supported and there would be no other negative effects.

So I'm asking the team what is the purpose of this warning and also why not change it?

We should do this.

togakangaroo

comment created time in 20 minutes

issue commentdraft-js-plugins/draft-js-plugins

[draftjs-mention-plugin] MentionSuggestions popover is not triggering immediately after mentionTrigger until some text is added.

Hey! Not sure about the solution. Would need to look into it. But feel free to create a PR.

Mangaraju-Velpula

comment created time in 20 minutes

issue commentfacebook/react

Feedback on useEffect depndencies change error

Anyway for your code, I feel there's a more efficient way.

const userIds = users.map(u => id)

useEffect(() => {
  if(!userIds.length)
    return
  ...load more stuff by querying endpoints about these ids and set state..
  // since you are setting state here, component will be rerendered, causing the above array.map
  // to re-run and thus userIds is re-computed every render unnecessarilty.
}, userIds)

What could be better

// so now userIds is only re-computed when users change and not whenever state is set
const userIds = useMemo(() => users.map(u => id), [users])

// here effect only re-run when userIds is recomputed, which in turn depends on users
useEffect(() => {
  if(!userIds.length)
    return
  ...load more stuff by querying endpoints about these ids and set state..
}, [userIds])

Or if you don't need to use variable userIds anywhere else

// this case, same as above, effect only re-runs when users change
useEffect(() => {
  const userIds = users.map(u => id)
  // ....
}, [users])

Some other props of user may be changed, but useEffect should depend only on users.map(u => u.id). How to accomplish in this case?

togakangaroo

comment created time in 21 minutes

push eventrollup/plugins

Lukas Taegert-Atkinson

commit sha badb09ed859615c1ae3c27bf20b969db2a70a168

chore(commonjs): Add logging

view details

push time in 21 minutes

issue commentatlassian/react-beautiful-dnd

redux connect(Droppable) returns state of library

I really cannot find out why the difference between codesandbox and the project

Yes, i use connect(mapStateToProps, mapDispatchToProps)(Card)

olsem25

comment created time in 23 minutes

push eventrollup/plugins

Lukas Taegert-Atkinson

commit sha c9273bf3501ae6ebfb805d1d8ac62116b385ce6a

chore(commonjs): Add logging

view details

push time in 27 minutes

push eventnetlify/netlify-cms

Renovate Bot

commit sha 0cb8117c64c1acd76621f38d4e0b1ef26341370e

chore(deps): update gatsby monorepo

view details

push time in 28 minutes

issue openeddate-fns/date-fns

`add` in browser issue with leap year

It seems that February 29th is not accounted for when using add in a browser.

in node: add(new Date('2020-02-28'), { days: 14 }) // returns "2020-03-13"

Screen Shot 2020-11-24 at 12 13 43 AM

in browser: add(new Date('2020-02-28'), { days: 14 }) // returns "2020-03-12"

Screen Shot 2020-11-24 at 12 14 22 AM

created time in 30 minutes

pull request commentfrenic/csstype

Add content visibility option

Thank you! I added this PR https://github.com/mdn/data/pull/450 in hopes it gets merged before applying this patch

artem-malko

comment created time in 32 minutes

issue commentmui-org/material-ui

[docs] Allow to follow system/OS preferences for dark mode

@benknight I don't think that it would be good enough, we need to demonstrate dark mode is supported without forcing developers to change their whole OS settings.

benknight

comment created time in 36 minutes

push eventrollup/plugins

Lukas Taegert-Atkinson

commit sha c7ccf1b0e34f4169da34714d05205f7b2615af70

chore(commonjs): Add logging

view details

push time in 36 minutes

issue commentmui-org/material-ui

Accordion expansion width is greather than parent

Please provide a minimal reproduction test case with v5. This would help a lot 👷 . A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

codingedgar

comment created time in 38 minutes

pull request commentSchniz/fnm

link to PowerShell $PROFILE docs

Makes sense. Sorry for my ignorance 😄 Maybe we should still provide a path? and if you think not — consider also contributing to Starship with this very helpful link: https://github.com/starship/starship/blob/master/docs/README.md#powershell 😃

ctaggart

comment created time in 41 minutes

issue commentdraft-js-plugins/draft-js-plugins

[draftjs-mention-plugin] MentionSuggestions popover is not triggering immediately after mentionTrigger until some text is added.

Thank you @artursvonda for re-opening. Is there a plan to fix this soon? If not, can you tell if what @YoonjiJang suggested (changing the > to >=) is a good fix?

Mangaraju-Velpula

comment created time in 42 minutes

issue commentSchniz/fnm

Windows: A required privilege is not held by the client.

Wow! thanks. We need to add it to the docs. Thanks for solving the mystery 🙏

ctaggart

comment created time in an hour

IssuesEvent

issue openedmjmlio/mjml

Background-image for Yahoo mail

When compiling, the background is set without quotes. Such background rejects Yahoo mail. How to get single quotes during compilation. Or how to display a background for Yahoo. Thanks! Screenshot_1

should be:

style="background: url('https//.....')..."

created time in an hour

push eventSchniz/fnm

Gal Schlezinger

commit sha 7951a9e29a6230d3110642f925444a85f2f248cb

Newer Rust version changed locations of snapshots

view details

push time in an hour

more