profile
viewpoint
Rich Trott Trott San Francisco, CA I create software, rock operas, and pizzas. I am a member of the Node.js Technical Steering Committee and work for the University of California. he/him

nlf/precommit-hook 482

An npm installable git pre-commit hook used to lint and test your code

davidmarkclements/v8-perf 256

Exploring v8 performance characteristics in Node across v8 versions 5.1, 5.8, 5.9, 6.0 and 6.1

inikulin/dmn 95

Janitor for your node_modules

nlf/git-validate 95

A module to help you create your own git hooks

Swaagie/stackexchange 48

Node.js implementation of the stackexchange/stackoverflow API

nodejs/core-validate-commit 41

Validate commit messages for Node.js core

nodejs/make-node-meeting 8

Generate a text for a GitHub issue announcing a Node.js working group meeting

nodejs/node.js.org 5

As a community service, redirecting node.js.org to nodejs.org.

nodejs/node-meeting-agenda 2

Generate an agenda for a Node.js working group based on GitHub issue labels

PullRequestReviewEvent

pull request commentnpm/cli

chore: bump tar@4.4.13 to tar@6.0.5

Oh, bummer. If I'm understanding the test results, it looks like latest needs to support back to Node.js 6.x, but the oldest fixed version of tar (5.0.2) requires Node.js 8.x and above, and the version here (6.0.5) requires Node.js 10.x and above.

When will latest not need to support Node.js 6.x anymore? Is there a viable path forward for this at this time if it can only support Node.js 8.x and above?

Trott

comment created time in 3 hours

push eventTrott/cli

Rich Trott

commit sha 462068d570d6dda660283aaead724c7b160429a5

chore: bump tar@4.4.13 to tar@6.0.5 This has the benefit of removing a `process.umask()` that causes a runtime deprecation warning if commands such as `npm ls` are run either with Node.js pending deprecations enabled or with the current 15.0.0 RC. Refs: https://github.com/nodejs/node/pull/35332#issuecomment-699660584 Refs: https://github.com/npm/cli/issues/1103

view details

push time in 3 hours

PR opened npm/cli

chore: bump tar@4.4.13 to tar@6.0.5

<!-- What / Why --> tar@4.4.13 has a dependency on an outdated version of fs-minipass that calls process.umask() with no arguments. That causes a runtime deprecation warning if commands such as npm ls are run either with Node.js pending deprecations enabled or with the current Node.js 15.0.0 rc.

<!-- Describe the request in detail. What it does and why it's being changed. --> Update tar@4.4.13 to tar@6.0.5.

References

<!-- Examples: Related to #0 Depends on #0 Blocked by #0 Fixes #0 Closes #0 --> Related to https://github.com/nodejs/node/pull/35332#issuecomment-699660584 Related to https://github.com/npm/cli/issues/1103

+128 -35

0 comment

2 changed files

pr created time in 3 hours

create barnchTrott/cli

branch : feature/bump-tar-6

created branch time in 3 hours

pull request commentnodejs/node

Revert "src: runtime deprecate process.umask()"

@ruyadorno could you have a look at npm 6 to fix this? That would be great :-)

If I'm not mistaken, the problem is in the fs-minipass dependency and has been fixed since fs-minipass@2.0.1 but that npm depends on an older version due to its dependency on tar.

npm@6.14.8 /Users/trott/cli
└─┬ tar@4.4.13
  └── fs-minipass@1.2.7 

And it looks like updating to tar@5.0.2 or later would solve the issue.

Looks like there's an existing issue in the npm issue tracker. I tried updating to tar@6 and all the tests still passed, so I'll submit a PR and move conversation over to that issue.

BethGriggs

comment created time in 3 hours

pull request commentnodejs/node

Revert "src: runtime deprecate process.umask()"

@ruyadorno could you have a look at npm 6 to fix this? That would be great :-)

If I'm not mistaken, the problem is in the fs-minipass dependency and has been fixed since fs-minipass@2.0.1 but that npm depends on an older version due to its dependency on tar.

npm@6.14.8 /Users/trott/cli
└─┬ tar@4.4.13
  └── fs-minipass@1.2.7 

And it looks like updating to tar@5.0.2 or later would solve the pissue.

BethGriggs

comment created time in 4 hours

pull request commentnodejs/node

Revert "src: runtime deprecate process.umask()"

@ruyadorno could you have a look at npm 6 to fix this? That would be great :-)

If I'm not mistaken, the problem is in the fs-minipass dependency and has been fixed since fs-minipass@2.0.1 but that npm depends on an older version due to its dependency on tar.

npm@6.14.8 /Users/trott/cli
└─┬ tar@4.4.13
  └── fs-minipass@1.2.7 
BethGriggs

comment created time in 4 hours

push eventTrott/cli

claudiahdz

commit sha 2e052984b08c09115ed75387fb2c961631d85d77

chore(docs): fixed links to cli commands This reverts commit 0eac801cdef344e9fbda6270145e062211255b0e. PR-URL: https://github.com/npm/cli/pull/1459 Credit: @claudiahdz Close: #1459 Reviewed-by: @claudiahdz

view details

Peter Fich

commit sha 0ca3509ca940865392daeeabb39192f7d5af9f5e

Update npm-link.md Fix typo. PR-URL: https://github.com/npm/cli/pull/1283 Credit: @peterfich Close: #1283 Reviewed-by: @claudiahdz

view details

Maxwell Gerber

commit sha 3dd429e9aad760ce2ff9e522b34ebfebd85b460c

docs: Add note about dropped `*` filenames In https://github.com/npm/npm-packlist/pull/32, NPM started to drop filenames containing the `*` character. See: - https://github.com/npm/cli/issues/1096 - https://github.com/npm/cli/issues/1048 PR-URL: https://github.com/npm/cli/pull/1377 Credit: @maxwellgerber Close: #1377 Reviewed-by: @claudiahdz

view details

Kyle E. Mitchell

commit sha c49b6ae28791ff7184288be16654f97168aa9705

spdx-license-ids@3.0.5 PR-URL: https://github.com/npm/cli/pull/1418 Credit: @kemitchell Close: #1418 Reviewed-by: @claudiahdz

view details

Sean Poulter

commit sha 9a2e2e797e5c91e7f4f261583a1906e2c440cc2f

docs: Fix typo PR-URL: https://github.com/npm/cli/pull/1429 Credit: @seanpoulter Close: #1429 Reviewed-by: @claudiahdz

view details

vanishcode

commit sha b7ad77598112908d60195d0fbc472b3c84275fd5

fix: wrong `npm doctor` command result

view details

vanishcode

commit sha 1aec4cb6effefbf51033d3964cce2a909c918c0d

test: add test for `npm doctor` that ping registry returns error

view details

vanishcode

commit sha 479e45c03be7b452cbe346e96c750d36597c3eb6

style: fix lint error with no trailing comma PR-URL: https://github.com/npm/cli/pull/1416 Credit: @vanishcode Close: #1416 Reviewed-by: @claudiahdz

view details

claudiahdz

commit sha a9857b8f6869451ff058789c4631fadfde5bbcbc

chore: remove auth info from logs

view details

claudiahdz

commit sha 94eca637756376b949edfb697e179a1fdcc231ee

npm-registry-fetch@4.0.5

view details

claudiahdz

commit sha 66aab417f836a901f8afb265251f761bb0422463

docs: changelog for 6.14.6

view details

claudiahdz

commit sha 46e91d9adc07906699e1e3f81254b293638b8d73

update AUTHORS

view details

claudiahdz

commit sha 66092d5ce22b326c4d4aed1c5073ae7a6a4f4aa2

6.14.6

view details

claudiahdz

commit sha 6a6151f377063c6aca852c859c01910edd235ec6

libnpx@10.2.4

view details

claudiahdz

commit sha 2d78481c7ec178e628ce23df940f73a05d5c6367

deps: update mkdirp on tacks

view details

claudiahdz

commit sha 4e129d105eba3b12d474caa6e5ca216a98deb75a

deps: uninstall npm-registry-couchapp

view details

claudiahdz

commit sha 8e1869e278d1dd37ddefd6b4e961d1bb17fc9d09

deps: fix outdated dev deps

view details

Jean-Charles Sisk

commit sha de5108836189bddf28d4d3542f9bd5869cc5c2e9

fix: npm explore spawn shell correctly PR-URL: https://github.com/npm/cli/pull/784 Credit: @jasisk Close: #784 Reviewed-by: @claudiahdz

view details

claudiahdz

commit sha 36e6c01d334c4db75018bc6a4a0bef726fd41ce4

fix: git tag handling regression on shrinkwrap

view details

Martin Packman

commit sha 1961c9369c92bf8fe530cecba9834ca3c7f5567c

Fix package id in shrinkwrap lifecycle step output Currently all logging related to shrinkwrap steps reports 'undefined' for the package in output and log messages. This is due to the package associated with the `idealTree` being recreated in the `savePackageJson()` method which precedes these steps. For now, just copy forward the `_id` attribute which lifecycle logging expects, but note that mutating `package` here is surprising. Fixes npm/npm#20756 PR-URL: https://github.com/npm/cli/pull/288 Credit: @bz2 Close: #288 Reviewed-by: @claudiahdz

view details

push time in 4 hours

push eventTrott/io.js

Daijiro Wachi

commit sha 589dbf13925d2429abf2c63942c3bb4fdefeee50

test: update wpt tests for url Refs: https://github.com/web-platform-tests/wpt/pull/25086 PR-URL: https://github.com/nodejs/node/pull/35329 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 5 hours

PullRequestReviewEvent

pull request commentnodejs/nodejs.org

Correct example code for "How to serve static files"

The knowledge base is definitely out of date in many places. And it is a shame that it recommends specific packages in a lot of places. But yeah, if this makes it correct (and judging from the node-static README, it does), then 👍 and thanks for the udpate.

sethbattin

comment created time in 5 hours

pull request commentnodejs/nodejs.org

Revert the Windows slashes workaround

The package is explicitly deprecated with this message:

No longer maintained; Migrate to the following package: @metalsmith/permalinks

Any chance that's a viable option?

XhmikosR

comment created time in 5 hours

PR opened nodejs/node

doc: make minor edits for consistency
  • We use noop and no-op in different docs. Use no-op everywhere.
  • When referring to functions, add () to indicate that.
  • Remove backticks from non-code destroyed.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+12 -12

0 comment

2 changed files

pr created time in 6 hours

create barnchTrott/io.js

branch : no-op-destroyed-etc

created branch time in 6 hours

PR closed nodejs/node

doc: add history entry for breaking destroy() change doc stream

Fixes https://github.com/nodejs/node/pull/29197#issuecomment-698252186.

Checklist

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+12 -0

1 comment

1 changed file

kanongil

pr closed time in 6 hours

pull request commentnodejs/node

doc: add history entry for breaking destroy() change

Landed in 7fcbeb4e7e63.

kanongil

comment created time in 6 hours

push eventTrott/io.js

Gil Pedersen

commit sha 7fcbeb4e7e63a11bf9de91ccf54a7d745b73c9d1

doc: add history entry for breaking destroy() change Refs: https://github.com/nodejs/node/pull/29197#issuecomment-698252186 PR-URL: https://github.com/nodejs/node/pull/35326 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 6 hours

push eventnodejs/node

Gil Pedersen

commit sha 7fcbeb4e7e63a11bf9de91ccf54a7d745b73c9d1

doc: add history entry for breaking destroy() change Refs: https://github.com/nodejs/node/pull/29197#issuecomment-698252186 PR-URL: https://github.com/nodejs/node/pull/35326 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 6 hours

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

delete branch Trott/io.js

delete branch : cp-windows

delete time in 7 hours

pull request commentnodejs/node

doc: revise introductory child_process text

Landed in c3ab062ae50a

Trott

comment created time in 7 hours

PR merged nodejs/node

doc: revise introductory child_process text child_process doc

This consolidates information about Windows environment variables and has a few other smaller improvements (punctuation, present tense, etc.).

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+15 -16

0 comment

1 changed file

Trott

pr closed time in 7 hours

push eventnodejs/node

Rich Trott

commit sha c3ab062ae50a8d2ab51d4b30441dca3d21b1e5a7

doc: revise introductory child_process text This consolidates information about Windows environment variables and has a few other smaller improvements (punctuation, present tense, etc.). PR-URL: https://github.com/nodejs/node/pull/35344 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in 7 hours

push eventTrott/io.js

Rich Trott

commit sha c3ab062ae50a8d2ab51d4b30441dca3d21b1e5a7

doc: revise introductory child_process text This consolidates information about Windows environment variables and has a few other smaller improvements (punctuation, present tense, etc.). PR-URL: https://github.com/nodejs/node/pull/35344 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in 7 hours

push eventTrott/io.js

Rich Trott

commit sha 895832cdbfc33d44da519f0265c3dc5bf2682f90

doc: put landing specifics in details tag Showing all the steps isn't usually useful and makes it seem like the collaborator is meant to follow the manual steps. I've seen this happen during at least one onboarding. The section is also a bit long to comfortably scroll over quickly to find the next section. Let's put those steps in a details block to make it more obvious that it is there for unusual situations only. Co-authored-by: Shelley Vohr <codebytere@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35296 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Rich Trott

commit sha c25cf34ac1cfb8e3a9508c232d42100e45abd8e9

doc: move DEP0018 to End-of-Life 3b10f7f93 resolves DEP0018. Move it to End-of-Life. Co-authored-by: Anna Henningsen <github@addaleax.net> PR-URL: https://github.com/nodejs/node/pull/35316 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Ikko Ashimine

commit sha 109a296e2ad15221b89a33efec9ba3ff56df3d27

quic: fix typo in code comment successfull -> successful PR-URL: https://github.com/nodejs/node/pull/35308 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha 03c4ee91d003da2a6ff4c19b91c7c7dafa705a55

doc: update napi_make_callback documentation Calling napi_make_callback() with no async_context is not resulting in using the current async context instead an empty context (id 0) is used. Using NULL is like using node::Makecallback without async_context which is deprecated since Node.js 10 (DEP0099). PR-URL: https://github.com/nodejs/node/pull/35321 Fixes: https://github.com/nodejs/node/issues/35188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Tobias Nießen

commit sha 2089b558351341f4e257584590a8e65009b3af59

doc: avoid referring to C array size The size of arrays is measured in bytes in C, not in the number of elements. The napi_get_cb_info function takes the length of the array, that is, the number of elements it can contain, and not its size. PR-URL: https://github.com/nodejs/node/pull/35300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Gabriel Schulhof

commit sha b54dd8d91d451d54aea3b2148180d109ecd1897e

doc: improve N-API string-to-native doc Mention null termination handling in the string size accounting and string truncation. PR-URL: https://github.com/nodejs/node/pull/35322 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Guy Bedford

commit sha 226b186a9371cf9781c676e18f69bb241e4ab21b

doc: refine require/import conditions constraints PR-URL: https://github.com/nodejs/node/pull/35311 Reviewed-By: Jan Krems <jan.krems@gmail.com>

view details

Shelley Vohr

commit sha aa99bb47bfbfc0fdf0d0ca4f452b527b02b83d2d

deps: upgrade to c-ares v1.16.1 PR-URL: https://github.com/nodejs/node/pull/35324 Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha ff38165820da2a9eaddabbce23f3e75aa502900b

src: allow N-API addon in `AddLinkedBinding()` `AddLinkedBinding()` can be used to load old-style Node.js addons, but currently not N-API addons. There’s no good reason not to support N-API addons as well, so add that. PR-URL: https://github.com/nodejs/node/pull/35301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Anatoly Korniltsev

commit sha ff028016ffd1e5a157b8665c07356966c0ea9f2a

src: fix incorrect SIGSEGV handling in NODE_USE_V8_WASM_TRAP_HANDLER Pass SA_SIGINFO to sa_flags so the TrapWebAssemblyOrContinue is treated as sa_sigaction, not sa_handler, otherwise siginfo_t* info contains some garbage PR-URL: https://github.com/nodejs/node/pull/35282 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Rich Trott

commit sha 325df03a6e29c1fd51294767235273e8a2ec3977

test,child_process: add tests for signalCode value Prior to this change, none of the child_process tests checked the signalCode property for a value other than null. Add a check to an existing test. PR-URL: https://github.com/nodejs/node/pull/35327 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

NickNaso

commit sha d7dfa66baa4c3e8c69841455bb170479147889cf

doc: added version 7 to N-API version matrix Node.js version 14.12.0 released the N-API version 7, but it's not present on the N-API version matrix. This change should fix the problem in the documentation. PR-URL: https://github.com/nodejs/node/pull/35319 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Danielle Adams

commit sha b15ed6515323ec6cae2bde78feabf805c2fbb6b1

doc: add gpg key export directions to releases doc Adds an extra step with instructions for exporting a gpg key to be uploaded to the key server. PR-URL: https://github.com/nodejs/node/pull/35298 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha af9231790974677a5ac35450ec86d1555a9cbf56

deps: upgrade to libuv 1.40.0 Notable changes: - The UV_UDP_MMSG_FREE flag has been added. - UV__EPROTO has been remapped from 4046 to -4046 for consistency with other error codes. - On Windows, UTF-16 surrogate pairs are no longer replaced with the Unicode replacement character. - uv_timer_get_due_in() has been added. PR-URL: https://github.com/nodejs/node/pull/35333 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Pooja D.P

commit sha 73900983f0180f563b9a6959fee378789db6854c

test: replace annonymous functions with arrow PR-URL: https://github.com/nodejs/node/pull/34921 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

view details

Victor Antonio Barzana Crespo

commit sha c15a227cfde831eeb5455a5e449945373cfab16c

doc: set encoding to hex before piping hash I found out that piping a hash to the stdout output would print a non-hex set of characters, however, the examples are intended to print out a hex-encoded output so, my proposal here is simple, we set the encoding to `hex` before piping the response of the hash algo by calling `hash.setEncoding('hex');`. With this the example is fixed PR-URL: https://github.com/nodejs/node/pull/35338 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha c3ab062ae50a8d2ab51d4b30441dca3d21b1e5a7

doc: revise introductory child_process text This consolidates information about Windows environment variables and has a few other smaller improvements (punctuation, present tense, etc.). PR-URL: https://github.com/nodejs/node/pull/35344 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in 7 hours

pull request commentnodejs/node

doc: Setting the encoding to hex before piping the hash

Landed in c15a227cfde8.

Thanks for the contribution! 🎉

vbarzana

comment created time in 7 hours

PR merged nodejs/node

doc: Setting the encoding to hex before piping the hash author ready crypto doc

I found out that piping a hash to the stdout output would print a non-hex set of characters, however, the examples are intended to print out a hex-encoded output so, my proposal here is simple, we set the encoding to hex before piping the response of the hash algo by calling hash.setEncoding('hex');. With this addition, the example is fixed My 2 cents! Thanks, Victor

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -1

2 comments

1 changed file

vbarzana

pr closed time in 7 hours

push eventnodejs/node

Victor Antonio Barzana Crespo

commit sha c15a227cfde831eeb5455a5e449945373cfab16c

doc: set encoding to hex before piping hash I found out that piping a hash to the stdout output would print a non-hex set of characters, however, the examples are intended to print out a hex-encoded output so, my proposal here is simple, we set the encoding to `hex` before piping the response of the hash algo by calling `hash.setEncoding('hex');`. With this the example is fixed PR-URL: https://github.com/nodejs/node/pull/35338 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 7 hours

push eventTrott/io.js

Victor Antonio Barzana Crespo

commit sha c15a227cfde831eeb5455a5e449945373cfab16c

doc: set encoding to hex before piping hash I found out that piping a hash to the stdout output would print a non-hex set of characters, however, the examples are intended to print out a hex-encoded output so, my proposal here is simple, we set the encoding to `hex` before piping the response of the hash algo by calling `hash.setEncoding('hex');`. With this the example is fixed PR-URL: https://github.com/nodejs/node/pull/35338 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 7 hours

push eventvbarzana/node

Victor Antonio Barzana Crespo

commit sha c15a227cfde831eeb5455a5e449945373cfab16c

doc: set encoding to hex before piping hash I found out that piping a hash to the stdout output would print a non-hex set of characters, however, the examples are intended to print out a hex-encoded output so, my proposal here is simple, we set the encoding to `hex` before piping the response of the hash algo by calling `hash.setEncoding('hex');`. With this the example is fixed PR-URL: https://github.com/nodejs/node/pull/35338 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 7 hours

push eventvbarzana/node

Rich Trott

commit sha 895832cdbfc33d44da519f0265c3dc5bf2682f90

doc: put landing specifics in details tag Showing all the steps isn't usually useful and makes it seem like the collaborator is meant to follow the manual steps. I've seen this happen during at least one onboarding. The section is also a bit long to comfortably scroll over quickly to find the next section. Let's put those steps in a details block to make it more obvious that it is there for unusual situations only. Co-authored-by: Shelley Vohr <codebytere@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35296 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Rich Trott

commit sha c25cf34ac1cfb8e3a9508c232d42100e45abd8e9

doc: move DEP0018 to End-of-Life 3b10f7f93 resolves DEP0018. Move it to End-of-Life. Co-authored-by: Anna Henningsen <github@addaleax.net> PR-URL: https://github.com/nodejs/node/pull/35316 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Ikko Ashimine

commit sha 109a296e2ad15221b89a33efec9ba3ff56df3d27

quic: fix typo in code comment successfull -> successful PR-URL: https://github.com/nodejs/node/pull/35308 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha 03c4ee91d003da2a6ff4c19b91c7c7dafa705a55

doc: update napi_make_callback documentation Calling napi_make_callback() with no async_context is not resulting in using the current async context instead an empty context (id 0) is used. Using NULL is like using node::Makecallback without async_context which is deprecated since Node.js 10 (DEP0099). PR-URL: https://github.com/nodejs/node/pull/35321 Fixes: https://github.com/nodejs/node/issues/35188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Tobias Nießen

commit sha 2089b558351341f4e257584590a8e65009b3af59

doc: avoid referring to C array size The size of arrays is measured in bytes in C, not in the number of elements. The napi_get_cb_info function takes the length of the array, that is, the number of elements it can contain, and not its size. PR-URL: https://github.com/nodejs/node/pull/35300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Gabriel Schulhof

commit sha b54dd8d91d451d54aea3b2148180d109ecd1897e

doc: improve N-API string-to-native doc Mention null termination handling in the string size accounting and string truncation. PR-URL: https://github.com/nodejs/node/pull/35322 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Guy Bedford

commit sha 226b186a9371cf9781c676e18f69bb241e4ab21b

doc: refine require/import conditions constraints PR-URL: https://github.com/nodejs/node/pull/35311 Reviewed-By: Jan Krems <jan.krems@gmail.com>

view details

Shelley Vohr

commit sha aa99bb47bfbfc0fdf0d0ca4f452b527b02b83d2d

deps: upgrade to c-ares v1.16.1 PR-URL: https://github.com/nodejs/node/pull/35324 Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha ff38165820da2a9eaddabbce23f3e75aa502900b

src: allow N-API addon in `AddLinkedBinding()` `AddLinkedBinding()` can be used to load old-style Node.js addons, but currently not N-API addons. There’s no good reason not to support N-API addons as well, so add that. PR-URL: https://github.com/nodejs/node/pull/35301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Anatoly Korniltsev

commit sha ff028016ffd1e5a157b8665c07356966c0ea9f2a

src: fix incorrect SIGSEGV handling in NODE_USE_V8_WASM_TRAP_HANDLER Pass SA_SIGINFO to sa_flags so the TrapWebAssemblyOrContinue is treated as sa_sigaction, not sa_handler, otherwise siginfo_t* info contains some garbage PR-URL: https://github.com/nodejs/node/pull/35282 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Rich Trott

commit sha 325df03a6e29c1fd51294767235273e8a2ec3977

test,child_process: add tests for signalCode value Prior to this change, none of the child_process tests checked the signalCode property for a value other than null. Add a check to an existing test. PR-URL: https://github.com/nodejs/node/pull/35327 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

NickNaso

commit sha d7dfa66baa4c3e8c69841455bb170479147889cf

doc: added version 7 to N-API version matrix Node.js version 14.12.0 released the N-API version 7, but it's not present on the N-API version matrix. This change should fix the problem in the documentation. PR-URL: https://github.com/nodejs/node/pull/35319 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Danielle Adams

commit sha b15ed6515323ec6cae2bde78feabf805c2fbb6b1

doc: add gpg key export directions to releases doc Adds an extra step with instructions for exporting a gpg key to be uploaded to the key server. PR-URL: https://github.com/nodejs/node/pull/35298 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha af9231790974677a5ac35450ec86d1555a9cbf56

deps: upgrade to libuv 1.40.0 Notable changes: - The UV_UDP_MMSG_FREE flag has been added. - UV__EPROTO has been remapped from 4046 to -4046 for consistency with other error codes. - On Windows, UTF-16 surrogate pairs are no longer replaced with the Unicode replacement character. - uv_timer_get_due_in() has been added. PR-URL: https://github.com/nodejs/node/pull/35333 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Pooja D.P

commit sha 73900983f0180f563b9a6959fee378789db6854c

test: replace annonymous functions with arrow PR-URL: https://github.com/nodejs/node/pull/34921 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

view details

Victor Antonio Barzana Crespo

commit sha ca9eaecd4e1ec91b85ece227764a35c369f42e1b

Setting the encoding to hex before piping the hash I found out that piping a hash to the stdout output would print a non-hex set of characters, however, the examples are intended to print out a hex-encoded output so, my proposal here is simple, we set the encoding to `hex` before piping the response of the hash algo by calling `hash.setEncoding('hex');`. With this the example is fixed My 2 cents! Thanks, Victor PR-URL: https://github.com/nodejs/node/pull/35338 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 7 hours

PullRequestReviewEvent

push eventTrott/io.js

Pooja D.P

commit sha 73900983f0180f563b9a6959fee378789db6854c

test: replace annonymous functions with arrow PR-URL: https://github.com/nodejs/node/pull/34921 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

view details

push time in 7 hours

push eventTrott/io.js

cjihrig

commit sha af9231790974677a5ac35450ec86d1555a9cbf56

deps: upgrade to libuv 1.40.0 Notable changes: - The UV_UDP_MMSG_FREE flag has been added. - UV__EPROTO has been remapped from 4046 to -4046 for consistency with other error codes. - On Windows, UTF-16 surrogate pairs are no longer replaced with the Unicode replacement character. - uv_timer_get_due_in() has been added. PR-URL: https://github.com/nodejs/node/pull/35333 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

push time in 17 hours

PullRequestReviewEvent

push eventTrott/io.js

Rich Trott

commit sha c9b87b653bad57fb45b417bed3f5a9714f493df5

Update doc/api/child_process.md

view details

push time in 21 hours

Pull request review commentnodejs/node

doc: revise introductory child_process text

 ls.on('close', (code) => { ```  By default, pipes for `stdin`, `stdout`, and `stderr` are established between-the parent Node.js process and the spawned child. These pipes have-limited (and platform-specific) capacity. If the child process writes to-stdout in excess of that limit without the output being captured, the child-process will block waiting for the pipe buffer to accept more data. This is+the parent Node.js process and the spawned subprocess. These pipes have+limited (and platform-specific) capacity. If the subprocess writes to+stdout in excess of that limit without the output being captured, the+subprocess blocks waiting for the pipe buffer to accept more data. This is identical to the behavior of pipes in the shell. Use the `{ stdio: 'ignore' }` option if the output will not be consumed. -The command lookup will be performed using `options.env.PATH` environment-variable if passed in `options` object, otherwise `process.env.PATH` will be-used. To account for the fact that Windows environment variables are-case-insensitive Node.js will lexicographically sort all `env` keys and choose-the first one case-insensitively matching `PATH` to perform command lookup.-This may lead to issues on Windows when passing objects to `env` option that-have multiple variants of `PATH` variable.--On Windows Node.js will sanitize the `env` by removing case-insensitive-duplicates. Only first (in lexicographic order) entry will be passed to the-child process.+The command lookup is performed using the `options.env.PATH` environment+variable if it is in the `options` object. Otherwise, `process.env.PATH` is+used.++On Windows, environment variables are case-insensitive. Node.js+lexicographically sorts the `env` keys and uses the first one that+case-insensitively matches. Only first (in lexicographic order) entry will be+passed to the subprocess. This might lead to issues on Windows when passing+objects to `env` option that have multiple variants of the same key, such as
objects to the `env` option that have multiple variants of the same key, such as
Trott

comment created time in 21 hours

PullRequestReviewEvent

push eventTrott/io.js

Rich Trott

commit sha 5f697139761743c35276311758d2d06ec87fe6ff

Update doc/api/child_process.md

view details

push time in 21 hours

Pull request review commentnodejs/node

doc: revise introductory child_process text

 ls.on('close', (code) => { ```  By default, pipes for `stdin`, `stdout`, and `stderr` are established between-the parent Node.js process and the spawned child. These pipes have-limited (and platform-specific) capacity. If the child process writes to-stdout in excess of that limit without the output being captured, the child-process will block waiting for the pipe buffer to accept more data. This is+the parent Node.js process and the spawned subprocess. These pipes have+limited (and platform-specific) capacity. If the subprocess writes to+stdout in excess of that limit without the output being captured, the+subprocess blocks waiting for the pipe buffer to accept more data. This is identical to the behavior of pipes in the shell. Use the `{ stdio: 'ignore' }` option if the output will not be consumed. -The command lookup will be performed using `options.env.PATH` environment-variable if passed in `options` object, otherwise `process.env.PATH` will be-used. To account for the fact that Windows environment variables are-case-insensitive Node.js will lexicographically sort all `env` keys and choose-the first one case-insensitively matching `PATH` to perform command lookup.-This may lead to issues on Windows when passing objects to `env` option that-have multiple variants of `PATH` variable.--On Windows Node.js will sanitize the `env` by removing case-insensitive-duplicates. Only first (in lexicographic order) entry will be passed to the-child process.+The command lookup is performed using the `options.env.PATH` environment+variable if it is in the `options` object. Otherwise, `process.env.PATH` is+used.++On Windows, environment variables are case-insensitive. Node.js+lexicographically sorts the `env` keys and uses the first one that+case-insensitively matches. Only first (in lexicographic order) entry will be+passed to the subprocess. This may lead to issues on Windows when passing
passed to the subprocess. This may lead to issues on Windows when passing
Trott

comment created time in 21 hours

PullRequestReviewEvent

pull request commentnodejs/nodejs.org

Add Package Maintenance WG

/ping @nodejs/website This could use reviews.

rxmarbles

comment created time in a day

pull request commentnodejs/nodejs.org

Add Package Maintenance WG

Thanks for doing this. I have comments above, but nothing blocking it landing if others review it.

rxmarbles

comment created time in a day

pull request commentnodejs/nodejs.org

Add Package Maintenance WG

It's possible that listing goals is better than listing responsibilities--I haven't thought about that--but all the other entries list the responsibilities, and those are listed in https://github.com/nodejs/TSC/pull/880. So maybe that's what should be here rather goals?

rxmarbles

comment created time in a day

Pull request review commentnodejs/nodejs.org

Add Package Maintenance WG

 Responsibilities include: * Assisting in the implementation of stream providers within Node.js. * Recommending versions of `readable-stream` to be included in Node.js. * Messaging about the future of streams to give the community advance notice of changes.++### [Package Mainentance](https://github.com/nodejs/package-maintenance)++The Package Maintenance Working Group working group brings together+Node.js collaborators, package maintainers, and package consumers to+work together with the goal of ensuring the health of the package ecosystem.++Our goals are:++* Define and document how to prioritize which packages are key to+  the Node.js ecosystem, and how/what assistance can/should be provided.+  One key aspect is understanding what communication channels are+  needed in order to identify when specific issues are slowing+  migration from one Node.js version to another,  or causing friction in the ecosystem.+* Building and documenting guidance, tools and processes so businesses+  can identify the packages they depend on. Businesses can use the information+  to build a business case which supports both the organization and developers+  helping to maintain those packages.+* Documenting a backlog and providing resources to help businesses identify+  how their developers can contribute, and get engaged. Developers can test+  and validate a workflow to help with issues slowing migration to Node.js 10.x.+* Building, documenting and evangelizing guidance, tools and processes+  (for example LTS for modules) can make it easier for maintainers to manage multiple streams,+  and accept help from those who depend on their module.

Same thing about alphabetical order...this section should be moved up a bit.

rxmarbles

comment created time in a day

PullRequestReviewEvent

Pull request review commentnodejs/nodejs.org

Add Package Maintenance WG

 Core Working Groups are created by the * [Release](#release) * [Security](#security) * [Streams](#streams)+* [Package Maintenance](#package-maintenance)

The working groups are listed in alphabetical order so this should be moved up a few lines.

* [Package Maintenance](#package-maintenance)
* [Release](#release)
* [Security](#security)
* [Streams](#streams)
rxmarbles

comment created time in a day

PullRequestReviewEvent
CommitCommentEvent

issue commentnodejs/nodejs.org

How long will you continue?

but ultimately it's a @nodejs/tsc decision.

...and also @nodejs/community-committee. So TSC and CommComm jointly.

ippei0605

comment created time in a day

pull request commentnodejs/nodejs.org

doc: remove BLM TODO

I assume the comment was added in good faith and was merely intended as a reminder that when the BLM call-to-action is removed, the styling can also be removed. But yeah, if it's being treated as an indicator of any kind of decision on that, let's remove the comment.

MylesBorins

comment created time in a day

PullRequestReviewEvent

issue commentnodejs/node

Buffer.from(string, 'hex') needs a documentation update (was: Buffer.from(x, `hex`).toString(`hex`) does not return x for certain values of x)

Then it is very inconsistent: let n = 1000 console.log(n.toString(16)) => results in 3e8 console.log(Buffer.from(n.toString(16), 'hex')) => results in <Buffer 3e>

I suppose that suggests another possibility: add a leading 0 if needed so that '3e8' is treated like '03e8'. In addition to being a breaking change, that gets challenging for edge cases and may end up affecting performance. You wouldn't want to pad '3ez' but you would want to pad '3e8'. Things probably get weird fast there. @nodejs/buffer

iamrenejr

comment created time in a day

Pull request review commentnodejs/node

doc: add history entry for breaking destroy() change

 See also: [`writable.uncork()`][], [`writable._writev()`][stream-_writev]. ##### `writable.destroy([error])` <!-- YAML added: v8.0.0+changes:+  - version: v14.0.0+    pr-url: https://github.com/nodejs/node/pull/29197+    description: Work as noop when called on an already `destroyed` stream.

Optional suggestion for here and below:

    description: Work as noop when called on an already-destroyed stream.
kanongil

comment created time in a day

PullRequestReviewEvent

PR merged nodejs/node

doc: add gpg key export directions doc

Adds an extra step with instructions for exporting a GPG key to be uploaded to the key server.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+8 -2

1 comment

1 changed file

danielleadams

pr closed time in a day

pull request commentnodejs/node

doc: add gpg key export directions

Landed in b15ed6515323

danielleadams

comment created time in a day

push eventnodejs/node

Danielle Adams

commit sha b15ed6515323ec6cae2bde78feabf805c2fbb6b1

doc: add gpg key export directions to releases doc Adds an extra step with instructions for exporting a gpg key to be uploaded to the key server. PR-URL: https://github.com/nodejs/node/pull/35298 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a day

push eventTrott/io.js

Danielle Adams

commit sha b15ed6515323ec6cae2bde78feabf805c2fbb6b1

doc: add gpg key export directions to releases doc Adds an extra step with instructions for exporting a gpg key to be uploaded to the key server. PR-URL: https://github.com/nodejs/node/pull/35298 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a day

push eventdanielleadams/node

Christoph Tavan

commit sha 219e9fe600339cf0b1773ef9e6d84bff94890402

module: fix crash on multiline named cjs imports The node process crashes when trying to parse a multiline import statement for named exports of a CommonJS module: TypeError: Cannot read property '0' of null at ModuleJob._instantiate (internal/modules/esm/module_job.js:112:77) at async ModuleJob.run (internal/modules/esm/module_job.js:137:5) at async Loader.import (internal/modules/esm/loader.js:165:24) at async rejects.name (file:///***/node/test/es-module/test-esm-cjs-named-error.mjs:56:3) at async waitForActual (assert.js:721:5) at async rejects (assert.js:830:25), The reason is that the regexp that is currently used to decorate the original error fails for multi line import statements. Unfortunately the undecorated error stack only contains the single line which causes the import to fail: file:///***/node/test/fixtures/es-modules/package-cjs-named-error/multi-line.mjs:2 comeOn, ^^^^^^ SyntaxError: The requested module './fail.cjs' does not provide an export named 'comeOn' at ModuleJob._instantiate (internal/modules/esm/module_job.js:98:21) at async ModuleJob.run (internal/modules/esm/module_job.js:141:5) at async Loader.import (internal/modules/esm/loader.js:165:24) at async rejects.name (file:///***/node/test/es-module/test-esm-cjs-named-error.mjs:56:3) at async waitForActual (assert.js:721:5) at async rejects (assert.js:830:25) Hence, for multiline import statements we cannot create an equivalent piece of code that uses default import followed by an object destructuring assignment. In any case the node process should definitely not crash. So until we have a more sophisticated way of extracting the entire problematic multiline import statement, show the code example only for single-line imports where the current regexp approach works well. Refs: https://github.com/nodejs/node/issues/35259 PR-URL: https://github.com/nodejs/node/pull/35275 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Antoine du Hamel

commit sha 0b8fdb70acc2fbd47c2c89755585e042baf9588a

tools,doc: upgrade dependencies PR-URL: https://github.com/nodejs/node/pull/35244 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Antoine du Hamel

commit sha 7794d36a372b7cb448f5a637765a8fe2e1431d95

tools,doc: enforce alphabetical order for md refs PR-URL: https://github.com/nodejs/node/pull/35244 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Ruy Adorno

commit sha 25d845656380d824a75a4f21c517d89fe3107896

2020-09-22, Version 14.12.0 (Current) Notable changes: - deps: - update to uvwasi 0.0.11 (Colin Ihrig) [#35104](https://github.com/nodejs/node/pull/35104) - n-api: - create N-API version 7 (Gabriel Schulhof) [#35199](https://github.com/nodejs/node/pull/35199) - add more property defaults (Gerhard Stoebich) [#35214](https://github.com/nodejs/node/pull/35214) PR-URL: https://github.com/nodejs/node/pull/35285

view details

Dan Fabulich

commit sha 3b10f7f933dee3607649b6bd1ca24876704222ac

process: change default --unhandled-rejections=throw This is a semver-major change that resolves DEP0018. All users that have set an unhandledRejection hook or set a non-default value for the --unhandled-rejections flag will see no change in behavior after this change. Refs: https://nodejs.org/dist/latest/docs/api/deprecations.html#deprecations_dep0018_unhandled_promise_rejections PR-URL: https://github.com/nodejs/node/pull/33021 Fixes: https://github.com/nodejs/node/issues/20392 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

view details

Yang Guo

commit sha a11788736a9eb17152f06fe28643ac2c270f4024

build: remove --build-v8-with-gn configure option This option is now outdated and not used any longer. PR-URL: https://github.com/nodejs/node/pull/27576 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Clark Kozak

commit sha 81379d1a006684e6b23d6fd41c6807b948cd85f4

doc: add `socket.readyState` + description of `socket.readyState` Note: YAML tag found in commit e697cfb6fc020c08afa2c794ee5802e5a4d2b97b Co-authored-by: Michael Auderer <mike@silverstone.io> PR-URL: https://github.com/nodejs/node/pull/35262 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha 6be80e1893679cffcb00c27b0b9df2606c4e4b3b

stream: fix legacy pipe error handling Fixes: https://github.com/nodejs/node/issues/35237 PR-URL: https://github.com/nodejs/node/pull/35257 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Thomas Hunter II

commit sha d6fe46f749bf39f8cb0a9b29f13f34672122c4eb

doc: fix heading space bug in assert.md Fixing a heading rendering bug PR-URL: https://github.com/nodejs/node/pull/35310 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ash Cripps

commit sha 77dd44078ee390458089c4bc706235ef913004d6

tools: ignore build folder when checking links We checkout build as a subdirectory as part of CI and if you run `make test` instead of `make test-ci` you get loads of errors about markdown link breaks. Ignore this directory as we don't need to examine another repo PR-URL: https://github.com/nodejs/node/pull/35315 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 163030eded94c010837e8cf62a618b5d973e0305

doc: revise dependency redirection text in policy.md PR-URL: https://github.com/nodejs/node/pull/35276 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 9687348577347cf41f10617a6b3b457825347cf2

doc: replace "this guide" link text with guide title PR-URL: https://github.com/nodejs/node/pull/35283 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Linn Dahlgren

commit sha e36ffb72bebae55091304da51837ca204367dc16

doc: change type of child_process.signalCode to string During testing, and interfacing with child_processes, I found that the child_process.signalCode property to be the string representation of the signal, not number. PR-URL: https://github.com/nodejs/node/pull/35223 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Bartosz Sosnowski

commit sha abd8cdfc4e7d0d7f563a9b0f91523fe8395d5e25

win, child_process: sanitize env variables On Windows environment variables are case-insensitive. When spawning child process certain apps can get confused if some of the variables are duplicated. This adds a step on Windows to normalizeSpawnArguments that removes such duplicates, keeping only the first (in lexicographic order) entry in the env key of options. This is partly already done for the PATH entry. Fixes: https://github.com/nodejs/node/issues/35129 PR-URL: https://github.com/nodejs/node/pull/35210 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Anna Henningsen

commit sha 785a5f9ae1674118ffeae4525080c6d3ede8fd3e

doc: fixup lutimes metadata Refs: https://github.com/nodejs/node/pull/35320#discussion_r493912423 PR-URL: https://github.com/nodejs/node/pull/35328 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 895832cdbfc33d44da519f0265c3dc5bf2682f90

doc: put landing specifics in details tag Showing all the steps isn't usually useful and makes it seem like the collaborator is meant to follow the manual steps. I've seen this happen during at least one onboarding. The section is also a bit long to comfortably scroll over quickly to find the next section. Let's put those steps in a details block to make it more obvious that it is there for unusual situations only. Co-authored-by: Shelley Vohr <codebytere@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35296 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Rich Trott

commit sha c25cf34ac1cfb8e3a9508c232d42100e45abd8e9

doc: move DEP0018 to End-of-Life 3b10f7f93 resolves DEP0018. Move it to End-of-Life. Co-authored-by: Anna Henningsen <github@addaleax.net> PR-URL: https://github.com/nodejs/node/pull/35316 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Ikko Ashimine

commit sha 109a296e2ad15221b89a33efec9ba3ff56df3d27

quic: fix typo in code comment successfull -> successful PR-URL: https://github.com/nodejs/node/pull/35308 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha 03c4ee91d003da2a6ff4c19b91c7c7dafa705a55

doc: update napi_make_callback documentation Calling napi_make_callback() with no async_context is not resulting in using the current async context instead an empty context (id 0) is used. Using NULL is like using node::Makecallback without async_context which is deprecated since Node.js 10 (DEP0099). PR-URL: https://github.com/nodejs/node/pull/35321 Fixes: https://github.com/nodejs/node/issues/35188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Tobias Nießen

commit sha 2089b558351341f4e257584590a8e65009b3af59

doc: avoid referring to C array size The size of arrays is measured in bytes in C, not in the number of elements. The napi_get_cb_info function takes the length of the array, that is, the number of elements it can contain, and not its size. PR-URL: https://github.com/nodejs/node/pull/35300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

push time in a day

push eventdanielleadams/node

Rich Trott

commit sha 36ac97e85b316207cab663a50dcd99c28b852edb

Update doc/guides/releases.md

view details

push time in a day

PullRequestReviewEvent

Pull request review commentnodejs/node

doc: add gpg key export directions

 signed by someone who has been authorized to create a release.  The GPG keys should be fetchable from a known third-party keyserver. The SKS Keyservers at <https://sks-keyservers.net> are recommended. Use the-[submission](https://pgp.mit.edu/) form to submit a new GPG key. Keys should be-fetchable via:+[submission](https://pgp.mit.edu/) form to submit a new GPG key. You'll need to+do an ASCII-armored export your key first:
do an ASCII-armored export of your key first:
danielleadams

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentnodejs/node

doc: added version 7 to N-API version matrix

Landed in d7dfa66baa4c

NickNaso

comment created time in a day

PR merged nodejs/node

doc: added version 7 to N-API version matrix doc n-api

Node.js version 14.12.0 released the N-API version 7, but it's not present on the N-API version matrix. This change should fix the problem in the documentation.

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+9 -0

1 comment

1 changed file

NickNaso

pr closed time in a day

push eventnodejs/node

NickNaso

commit sha d7dfa66baa4c3e8c69841455bb170479147889cf

doc: added version 7 to N-API version matrix Node.js version 14.12.0 released the N-API version 7, but it's not present on the N-API version matrix. This change should fix the problem in the documentation. PR-URL: https://github.com/nodejs/node/pull/35319 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a day

push eventTrott/io.js

NickNaso

commit sha d7dfa66baa4c3e8c69841455bb170479147889cf

doc: added version 7 to N-API version matrix Node.js version 14.12.0 released the N-API version 7, but it's not present on the N-API version matrix. This change should fix the problem in the documentation. PR-URL: https://github.com/nodejs/node/pull/35319 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a day

push eventNickNaso/node

Ash Cripps

commit sha 77dd44078ee390458089c4bc706235ef913004d6

tools: ignore build folder when checking links We checkout build as a subdirectory as part of CI and if you run `make test` instead of `make test-ci` you get loads of errors about markdown link breaks. Ignore this directory as we don't need to examine another repo PR-URL: https://github.com/nodejs/node/pull/35315 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 163030eded94c010837e8cf62a618b5d973e0305

doc: revise dependency redirection text in policy.md PR-URL: https://github.com/nodejs/node/pull/35276 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 9687348577347cf41f10617a6b3b457825347cf2

doc: replace "this guide" link text with guide title PR-URL: https://github.com/nodejs/node/pull/35283 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Linn Dahlgren

commit sha e36ffb72bebae55091304da51837ca204367dc16

doc: change type of child_process.signalCode to string During testing, and interfacing with child_processes, I found that the child_process.signalCode property to be the string representation of the signal, not number. PR-URL: https://github.com/nodejs/node/pull/35223 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Bartosz Sosnowski

commit sha abd8cdfc4e7d0d7f563a9b0f91523fe8395d5e25

win, child_process: sanitize env variables On Windows environment variables are case-insensitive. When spawning child process certain apps can get confused if some of the variables are duplicated. This adds a step on Windows to normalizeSpawnArguments that removes such duplicates, keeping only the first (in lexicographic order) entry in the env key of options. This is partly already done for the PATH entry. Fixes: https://github.com/nodejs/node/issues/35129 PR-URL: https://github.com/nodejs/node/pull/35210 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Anna Henningsen

commit sha 785a5f9ae1674118ffeae4525080c6d3ede8fd3e

doc: fixup lutimes metadata Refs: https://github.com/nodejs/node/pull/35320#discussion_r493912423 PR-URL: https://github.com/nodejs/node/pull/35328 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 895832cdbfc33d44da519f0265c3dc5bf2682f90

doc: put landing specifics in details tag Showing all the steps isn't usually useful and makes it seem like the collaborator is meant to follow the manual steps. I've seen this happen during at least one onboarding. The section is also a bit long to comfortably scroll over quickly to find the next section. Let's put those steps in a details block to make it more obvious that it is there for unusual situations only. Co-authored-by: Shelley Vohr <codebytere@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35296 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Rich Trott

commit sha c25cf34ac1cfb8e3a9508c232d42100e45abd8e9

doc: move DEP0018 to End-of-Life 3b10f7f93 resolves DEP0018. Move it to End-of-Life. Co-authored-by: Anna Henningsen <github@addaleax.net> PR-URL: https://github.com/nodejs/node/pull/35316 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Ikko Ashimine

commit sha 109a296e2ad15221b89a33efec9ba3ff56df3d27

quic: fix typo in code comment successfull -> successful PR-URL: https://github.com/nodejs/node/pull/35308 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha 03c4ee91d003da2a6ff4c19b91c7c7dafa705a55

doc: update napi_make_callback documentation Calling napi_make_callback() with no async_context is not resulting in using the current async context instead an empty context (id 0) is used. Using NULL is like using node::Makecallback without async_context which is deprecated since Node.js 10 (DEP0099). PR-URL: https://github.com/nodejs/node/pull/35321 Fixes: https://github.com/nodejs/node/issues/35188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Tobias Nießen

commit sha 2089b558351341f4e257584590a8e65009b3af59

doc: avoid referring to C array size The size of arrays is measured in bytes in C, not in the number of elements. The napi_get_cb_info function takes the length of the array, that is, the number of elements it can contain, and not its size. PR-URL: https://github.com/nodejs/node/pull/35300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Gabriel Schulhof

commit sha b54dd8d91d451d54aea3b2148180d109ecd1897e

doc: improve N-API string-to-native doc Mention null termination handling in the string size accounting and string truncation. PR-URL: https://github.com/nodejs/node/pull/35322 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Guy Bedford

commit sha 226b186a9371cf9781c676e18f69bb241e4ab21b

doc: refine require/import conditions constraints PR-URL: https://github.com/nodejs/node/pull/35311 Reviewed-By: Jan Krems <jan.krems@gmail.com>

view details

Shelley Vohr

commit sha aa99bb47bfbfc0fdf0d0ca4f452b527b02b83d2d

deps: upgrade to c-ares v1.16.1 PR-URL: https://github.com/nodejs/node/pull/35324 Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha ff38165820da2a9eaddabbce23f3e75aa502900b

src: allow N-API addon in `AddLinkedBinding()` `AddLinkedBinding()` can be used to load old-style Node.js addons, but currently not N-API addons. There’s no good reason not to support N-API addons as well, so add that. PR-URL: https://github.com/nodejs/node/pull/35301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Anatoly Korniltsev

commit sha ff028016ffd1e5a157b8665c07356966c0ea9f2a

src: fix incorrect SIGSEGV handling in NODE_USE_V8_WASM_TRAP_HANDLER Pass SA_SIGINFO to sa_flags so the TrapWebAssemblyOrContinue is treated as sa_sigaction, not sa_handler, otherwise siginfo_t* info contains some garbage PR-URL: https://github.com/nodejs/node/pull/35282 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Rich Trott

commit sha 325df03a6e29c1fd51294767235273e8a2ec3977

test,child_process: add tests for signalCode value Prior to this change, none of the child_process tests checked the signalCode property for a value other than null. Add a check to an existing test. PR-URL: https://github.com/nodejs/node/pull/35327 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

NickNaso

commit sha d7dfa66baa4c3e8c69841455bb170479147889cf

doc: added version 7 to N-API version matrix Node.js version 14.12.0 released the N-API version 7, but it's not present on the N-API version matrix. This change should fix the problem in the documentation. PR-URL: https://github.com/nodejs/node/pull/35319 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a day

PullRequestReviewEvent

delete branch Trott/io.js

delete branch : signalCode

delete time in a day

pull request commentnodejs/node

test,child_process: add tests for signalCode value

Landed in 325df03a6e29

Trott

comment created time in a day

PR merged nodejs/node

test,child_process: add tests for signalCode value test

Prior to this change, none of the child_process tests checked the signalCode property for a value other than null. Add a check to an existing test.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+2 -0

2 comments

1 changed file

Trott

pr closed time in a day

push eventnodejs/node

Rich Trott

commit sha 325df03a6e29c1fd51294767235273e8a2ec3977

test,child_process: add tests for signalCode value Prior to this change, none of the child_process tests checked the signalCode property for a value other than null. Add a check to an existing test. PR-URL: https://github.com/nodejs/node/pull/35327 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

push time in a day

push eventTrott/io.js

Rich Trott

commit sha 325df03a6e29c1fd51294767235273e8a2ec3977

test,child_process: add tests for signalCode value Prior to this change, none of the child_process tests checked the signalCode property for a value other than null. Add a check to an existing test. PR-URL: https://github.com/nodejs/node/pull/35327 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

push time in a day

push eventTrott/io.js

Bartosz Sosnowski

commit sha abd8cdfc4e7d0d7f563a9b0f91523fe8395d5e25

win, child_process: sanitize env variables On Windows environment variables are case-insensitive. When spawning child process certain apps can get confused if some of the variables are duplicated. This adds a step on Windows to normalizeSpawnArguments that removes such duplicates, keeping only the first (in lexicographic order) entry in the env key of options. This is partly already done for the PATH entry. Fixes: https://github.com/nodejs/node/issues/35129 PR-URL: https://github.com/nodejs/node/pull/35210 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Anna Henningsen

commit sha 785a5f9ae1674118ffeae4525080c6d3ede8fd3e

doc: fixup lutimes metadata Refs: https://github.com/nodejs/node/pull/35320#discussion_r493912423 PR-URL: https://github.com/nodejs/node/pull/35328 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 895832cdbfc33d44da519f0265c3dc5bf2682f90

doc: put landing specifics in details tag Showing all the steps isn't usually useful and makes it seem like the collaborator is meant to follow the manual steps. I've seen this happen during at least one onboarding. The section is also a bit long to comfortably scroll over quickly to find the next section. Let's put those steps in a details block to make it more obvious that it is there for unusual situations only. Co-authored-by: Shelley Vohr <codebytere@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35296 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Rich Trott

commit sha c25cf34ac1cfb8e3a9508c232d42100e45abd8e9

doc: move DEP0018 to End-of-Life 3b10f7f93 resolves DEP0018. Move it to End-of-Life. Co-authored-by: Anna Henningsen <github@addaleax.net> PR-URL: https://github.com/nodejs/node/pull/35316 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Ikko Ashimine

commit sha 109a296e2ad15221b89a33efec9ba3ff56df3d27

quic: fix typo in code comment successfull -> successful PR-URL: https://github.com/nodejs/node/pull/35308 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha 03c4ee91d003da2a6ff4c19b91c7c7dafa705a55

doc: update napi_make_callback documentation Calling napi_make_callback() with no async_context is not resulting in using the current async context instead an empty context (id 0) is used. Using NULL is like using node::Makecallback without async_context which is deprecated since Node.js 10 (DEP0099). PR-URL: https://github.com/nodejs/node/pull/35321 Fixes: https://github.com/nodejs/node/issues/35188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Tobias Nießen

commit sha 2089b558351341f4e257584590a8e65009b3af59

doc: avoid referring to C array size The size of arrays is measured in bytes in C, not in the number of elements. The napi_get_cb_info function takes the length of the array, that is, the number of elements it can contain, and not its size. PR-URL: https://github.com/nodejs/node/pull/35300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Gabriel Schulhof

commit sha b54dd8d91d451d54aea3b2148180d109ecd1897e

doc: improve N-API string-to-native doc Mention null termination handling in the string size accounting and string truncation. PR-URL: https://github.com/nodejs/node/pull/35322 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Guy Bedford

commit sha 226b186a9371cf9781c676e18f69bb241e4ab21b

doc: refine require/import conditions constraints PR-URL: https://github.com/nodejs/node/pull/35311 Reviewed-By: Jan Krems <jan.krems@gmail.com>

view details

Shelley Vohr

commit sha aa99bb47bfbfc0fdf0d0ca4f452b527b02b83d2d

deps: upgrade to c-ares v1.16.1 PR-URL: https://github.com/nodejs/node/pull/35324 Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha ff38165820da2a9eaddabbce23f3e75aa502900b

src: allow N-API addon in `AddLinkedBinding()` `AddLinkedBinding()` can be used to load old-style Node.js addons, but currently not N-API addons. There’s no good reason not to support N-API addons as well, so add that. PR-URL: https://github.com/nodejs/node/pull/35301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Anatoly Korniltsev

commit sha ff028016ffd1e5a157b8665c07356966c0ea9f2a

src: fix incorrect SIGSEGV handling in NODE_USE_V8_WASM_TRAP_HANDLER Pass SA_SIGINFO to sa_flags so the TrapWebAssemblyOrContinue is treated as sa_sigaction, not sa_handler, otherwise siginfo_t* info contains some garbage PR-URL: https://github.com/nodejs/node/pull/35282 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Rich Trott

commit sha 325df03a6e29c1fd51294767235273e8a2ec3977

test,child_process: add tests for signalCode value Prior to this change, none of the child_process tests checked the signalCode property for a value other than null. Add a check to an existing test. PR-URL: https://github.com/nodejs/node/pull/35327 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

push time in a day

push eventTrott/io.js

Gerhard Stoebich

commit sha 03c4ee91d003da2a6ff4c19b91c7c7dafa705a55

doc: update napi_make_callback documentation Calling napi_make_callback() with no async_context is not resulting in using the current async context instead an empty context (id 0) is used. Using NULL is like using node::Makecallback without async_context which is deprecated since Node.js 10 (DEP0099). PR-URL: https://github.com/nodejs/node/pull/35321 Fixes: https://github.com/nodejs/node/issues/35188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Tobias Nießen

commit sha 2089b558351341f4e257584590a8e65009b3af59

doc: avoid referring to C array size The size of arrays is measured in bytes in C, not in the number of elements. The napi_get_cb_info function takes the length of the array, that is, the number of elements it can contain, and not its size. PR-URL: https://github.com/nodejs/node/pull/35300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Gabriel Schulhof

commit sha b54dd8d91d451d54aea3b2148180d109ecd1897e

doc: improve N-API string-to-native doc Mention null termination handling in the string size accounting and string truncation. PR-URL: https://github.com/nodejs/node/pull/35322 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Guy Bedford

commit sha 226b186a9371cf9781c676e18f69bb241e4ab21b

doc: refine require/import conditions constraints PR-URL: https://github.com/nodejs/node/pull/35311 Reviewed-By: Jan Krems <jan.krems@gmail.com>

view details

Shelley Vohr

commit sha aa99bb47bfbfc0fdf0d0ca4f452b527b02b83d2d

deps: upgrade to c-ares v1.16.1 PR-URL: https://github.com/nodejs/node/pull/35324 Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha ff38165820da2a9eaddabbce23f3e75aa502900b

src: allow N-API addon in `AddLinkedBinding()` `AddLinkedBinding()` can be used to load old-style Node.js addons, but currently not N-API addons. There’s no good reason not to support N-API addons as well, so add that. PR-URL: https://github.com/nodejs/node/pull/35301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Anatoly Korniltsev

commit sha ff028016ffd1e5a157b8665c07356966c0ea9f2a

src: fix incorrect SIGSEGV handling in NODE_USE_V8_WASM_TRAP_HANDLER Pass SA_SIGINFO to sa_flags so the TrapWebAssemblyOrContinue is treated as sa_sigaction, not sa_handler, otherwise siginfo_t* info contains some garbage PR-URL: https://github.com/nodejs/node/pull/35282 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

push time in a day

PR opened nodejs/node

doc: edit n-api.md for minor improvements

Not a comprehensive edit. Just a few things I noticed.

  • Favor present tense where there's a choice
  • Added a comma for clarity
  • Added a missing word ("in")

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+9 -9

0 comment

1 changed file

pr created time in a day

create barnchTrott/io.js

branch : napiedits

created branch time in a day

pull request commentnodejs/node

lib: fix readFile flag option

@nodejs/collaborators This could use reviews.

O4epegb

comment created time in 2 days

PR closed nodejs/node

doc: Revert refine conditions constraints PR doc

This reverts the PR https://github.com/nodejs/node/pull/35311 which landed before the 7 day limit required for PRs with one approval.

This was a misinterpretation from my side of the previous relaxation of the waiting period, which I thought had also been applied to these cases.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+6 -9

4 comments

1 changed file

guybedford

pr closed time in 2 days

pull request commentnodejs/node

doc: Revert refine conditions constraints PR

I'm going to optimistically close this, but any other collaborator who feels differently should absolutely feel free to mash the "re-open" button.

guybedford

comment created time in 2 days

pull request commentnodejs/node

Refine "require" / "import" conditions constraints

@Trott I've created a revert PR in #35357. Happy to fast track that and wait the full time here before landing.

I won't stop if others feel strongly about enforcing the process here, but I'd prefer we don't revert. We have enough trouble getting stuff landed. This is a narrow doc change. If someone objects to it, they can open the revert PR or better yet open a PR with further revisions that can hopefully get consensus.

guybedford

comment created time in 2 days

pull request commentnodejs/node

Refine "require" / "import" conditions constraints

I had it in my head that the 7 day limit had been removed in a previous PR to the guidelines. Or was the waiting period only removed for PRs with two approvals? That was my misunderstanding of that change then, apologies.

No worries. The fact that you and 100+ other people are expected to keep the various rules straight is a bit of a process bug in my opinion. These things are simply going to happen from time to time. (Until we get a robust commit-queue that everyone is using!)

guybedford

comment created time in 2 days

pull request commentnodejs/node

doc: Revert refine conditions constraints PR

I'd prefer we leave it rather than revert. It's a doc change. If someone doesn't like it, they can change it again....

guybedford

comment created time in 2 days

push eventTrott/slug

dependabot-preview[bot]

commit sha 1c46fedaa315dfa1f558af9cf9066732ce028dc6

chore(deps-dev): bump karma from 5.2.2 to 5.2.3 Bumps [karma](https://github.com/karma-runner/karma) from 5.2.2 to 5.2.3. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v5.2.2...v5.2.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 2 days

PR merged Trott/slug

chore(deps-dev): bump karma from 5.2.2 to 5.2.3 dependencies

Bumps karma from 5.2.2 to 5.2.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/karma-runner/karma/releases">karma's releases</a>.</em></p> <blockquote> <h2>v5.2.3</h2> <h2><a href="https://github.com/karma-runner/karma/compare/v5.2.2...v5.2.3">5.2.3</a> (2020-09-25)</h2> <h3>Bug Fixes</h3> <ul> <li>update us-parser-js dependency (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3564">#3564</a>) (<a href="https://github.com/karma-runner/karma/commit/500ed25d7e523efe7e7cff2ec70830be7e6e797a">500ed25</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/karma-runner/karma/blob/master/CHANGELOG.md">karma's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/karma-runner/karma/compare/v5.2.2...v5.2.3">5.2.3</a> (2020-09-25)</h2> <h3>Bug Fixes</h3> <ul> <li>update us-parser-js dependency (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3564">#3564</a>) (<a href="https://github.com/karma-runner/karma/commit/500ed25d7e523efe7e7cff2ec70830be7e6e797a">500ed25</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/karma-runner/karma/commit/ead31cd99238da86ab8b2d8ff5aff465959f4106"><code>ead31cd</code></a> chore(release): 5.2.3 [skip ci]</li> <li><a href="https://github.com/karma-runner/karma/commit/500ed25d7e523efe7e7cff2ec70830be7e6e797a"><code>500ed25</code></a> fix: update us-parser-js dependency (<a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3564">#3564</a>)</li> <li>See full diff in <a href="https://github.com/karma-runner/karma/compare/v5.2.2...v5.2.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+20 -12

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 2 days

pull request commentnodejs/node

Refine "require" / "import" conditions constraints

This landed without the required second approval. Just noting it as a polite FYI. Human error happens. ¯\(ツ)/¯ One more data point that switching to the commit-queue (after it has been sufficiently real-world tested) as the primary (only?) means to land things will help us enforce a consistent process.

guybedford

comment created time in 2 days

pull request commentnodejs/node

deps: upgrade to c-ares v1.16.1

Might be good to run an internet test in CI for this since there are a bunch of DNS tests there that are often overlooked (but we run them nightly in the node-daily-master job in CI).

Internet CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/16563/

codebytere

comment created time in 2 days

PullRequestReviewEvent

push eventnodejs/nodejs.org

dependabot-preview[bot]

commit sha c70244a056c9bb789f6d4823da8f6eecae4d0fbc

build(deps-dev): bump stylelint from 13.7.1 to 13.7.2 Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.7.1 to 13.7.2. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](https://github.com/stylelint/stylelint/compare/13.7.1...13.7.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 2 days

delete branch nodejs/nodejs.org

delete branch : dependabot/npm_and_yarn/stylelint-13.7.2

delete time in 2 days

PR merged nodejs/nodejs.org

build(deps-dev): bump stylelint from 13.7.1 to 13.7.2 dependencies javascript

Bumps stylelint from 13.7.1 to 13.7.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/stylelint/stylelint/releases">stylelint's releases</a>.</em></p> <blockquote> <h2>13.7.2</h2> <ul> <li>Fixed: regression for disable commands and adjacent double-slash comments (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/pull/4950">#4950</a>).</li> <li>Fixed: use of full file path without converting it to glob (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/pull/4931">#4931</a>).</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md">stylelint's changelog</a>.</em></p> <blockquote> <h2>13.7.2</h2> <ul> <li>Fixed: regression for disable commands and adjacent double-slash comments (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/pull/4950">#4950</a>).</li> <li>Fixed: use of full file path without converting it to glob (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/pull/4931">#4931</a>).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/stylelint/stylelint/commit/2b8215b2eb1ced1c8cafb4de523789f525038906"><code>2b8215b</code></a> 13.7.2</li> <li><a href="https://github.com/stylelint/stylelint/commit/119c42ecd315c9a51989fb6ce29ceb34124f1aee"><code>119c42e</code></a> Prepare 13.7.2</li> <li><a href="https://github.com/stylelint/stylelint/commit/65ab12ebfa08cf92525626836bd9847c8e740da9"><code>65ab12e</code></a> Add missing <code>media-feature-name-value-whitelist</code> to rule list (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/issues/4946">#4946</a>)</li> <li><a href="https://github.com/stylelint/stylelint/commit/9499a3a62f2e9149f575e7a34d899f645bd769d6"><code>9499a3a</code></a> Add a specific meta to the deprecated rules (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/issues/2622">#2622</a>) (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/issues/4943">#4943</a>)</li> <li><a href="https://github.com/stylelint/stylelint/commit/248d83ca902bb09adcb44bc1aca14dd71224165f"><code>248d83c</code></a> Describe missing <code>reportedDisables</code> and <code>reportDescriptionlessDisables</code> (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/issues/4939">#4939</a>)</li> <li><a href="https://github.com/stylelint/stylelint/commit/ca6c9caca290f9ff682e545a575842f60456196d"><code>ca6c9ca</code></a> Update CHANGELOG.md</li> <li><a href="https://github.com/stylelint/stylelint/commit/4f068be333fdfa622f22a215487b3731acc43701"><code>4f068be</code></a> Improve inline comment merging (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/issues/4950">#4950</a>)</li> <li><a href="https://github.com/stylelint/stylelint/commit/7449dc004c9e75119423cd7e4f3780ba895b5c89"><code>7449dc0</code></a> Bump husky from 4.2.5 to 4.3.0 (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/issues/4941">#4941</a>)</li> <li><a href="https://github.com/stylelint/stylelint/commit/d38ee62dce41543b9a9d7218acdc51f9e5146d81"><code>d38ee62</code></a> Update CHANGELOG.md</li> <li><a href="https://github.com/stylelint/stylelint/commit/1dfd78bb61c3286f71441eea22e392de25a450df"><code>1dfd78b</code></a> Removed "hasMagic" check before escaping paths. (<a href="https://github-redirect.dependabot.com/stylelint/stylelint/issues/4931">#4931</a>)</li> <li>Additional commits viewable in <a href="https://github.com/stylelint/stylelint/compare/13.7.1...13.7.2">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+77 -93

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 2 days

PullRequestReviewEvent

pull request commentnodejs/node

Make recursive rmdir more strict

A little bit of a heads up that I'm wondering if we can come up with a better name than strict but I don't have any proposal yet. The flag affects one narrow-ish aspect of behavior so I'm wondering if it can be more descriptive. requireDirectoryPath or errorOnNonDirectoryPath are kind of along the lines of what I'm thinking, but those both have bigger problems.

iansu

comment created time in 2 days

issue commentbcoe/c8

`c8 ignore next` comment does not quite appropriately compensate for branches

Even simpler reproduction:

return true;
/* c8 ignore next */
console.log('never runs');
Trott

comment created time in 2 days

more