An npm installable git pre-commit hook used to lint and test your code
Exploring v8 performance characteristics in Node across v8 versions 5.1, 5.8, 5.9, 6.0 and 6.1
npm/roadmap 129
Public roadmap for npm
inikulin/dmn 95
Janitor for your node_modules
A module to help you create your own git hooks
npm/feedback 51
Public feedback discussions for npm
Node.js implementation of the stackexchange/stackoverflow API
nodejs/core-validate-commit 42
Validate commit messages for Node.js core
Generate a text for a GitHub issue announcing a Node.js working group meeting
As a community service, redirecting node.js.org to nodejs.org.
pull request commentnodejs/node
lib: refactor to use validateObject
CI: https://ci.nodejs.org/job/node-test-pull-request/35771/
comment created time in an hour
Pull request review commentnodejs/node
tools: make comma-dangle ESLint rule more stringent
function connectionListenerInternal(server, socket) { server.maxHeaderSize || 0, server.insecureHTTPParser === undefined ? isLenient() : server.insecureHTTPParser,- server.headersTimeout || 0,+ server.headersTimeout || 0
Is there a way to avoid having to remove these trailing commas?
comment created time in 2 hours
pull request commentnodejs/node
Update on the Fedora machines: https://github.com/nodejs/build/issues/2527#issuecomment-768065385
Green Linux run for this PR: https://ci.nodejs.org/job/node-test-commit-linux/39601/
Re-run of node-test-pull-request initiated here: https://ci.nodejs.org/job/node-test-pull-request/35770/, will be interesting to see it consistently green, 🤞 .
comment created time in 2 hours
pull request commentnodejs/node
CI: https://ci.nodejs.org/job/node-test-pull-request/35770/
comment created time in 2 hours
create barnchTrott/new.nodejs.org
branch : dependabot/npm_and_yarn/marked-1.2.8
created branch time in 2 hours
PR opened Trott/new.nodejs.org
Bumps marked from 1.2.7 to 1.2.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/markedjs/marked/releases">marked's releases</a>.</em></p> <blockquote> <h2>v1.2.8</h2> <h2><a href="https://github.com/markedjs/marked/compare/v1.2.7...v1.2.8">1.2.8</a> (2021-01-26)</h2> <h3>Bug Fixes</h3> <ul> <li>leave whitespace only lines alone (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1889">#1889</a>) (<a href="https://github.com/markedjs/marked/commit/53c79ee9196bfd06ad15aad8904a7a4d61e0f400">53c79ee</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/markedjs/marked/commit/57d41b88801566eb063cd66a210d7c34249cb7dc"><code>57d41b8</code></a> chore(release): 1.2.8 [skip ci]</li> <li><a href="https://github.com/markedjs/marked/commit/608ba7cc8b77c4b599edcc6d9b9269eadf772df4"><code>608ba7c</code></a> 🗜️ build [skip ci]</li> <li><a href="https://github.com/markedjs/marked/commit/53c79ee9196bfd06ad15aad8904a7a4d61e0f400"><code>53c79ee</code></a> fix: leave whitespace only lines alone (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1889">#1889</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/42a18f1cdecbc0facc957bb095b03f748373a41b"><code>42a18f1</code></a> chore(deps-dev): Bump rollup from 2.36.2 to 2.38.0 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1910">#1910</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/be27b84286587badff95933f40e35a60079cb99b"><code>be27b84</code></a> chore(deps-dev): Bump uglify-js from 3.12.4 to 3.12.5 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1911">#1911</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/5f4a93152e8eebad2a5bc2098c80309b3c9b887c"><code>5f4a931</code></a> chore(deps-dev): Bump jasmine from 3.6.3 to 3.6.4 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1912">#1912</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/c457c5359cf301d79b70eb17bfd9909ef1afa2c2"><code>c457c53</code></a> chore(deps-dev): Bump semantic-release from 17.3.3 to 17.3.7 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1913">#1913</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/e1392c2563864804d41f9d65a10a89e5f9aa4d49"><code>e1392c2</code></a> chore(deps-dev): Bump rollup from 2.36.1 to 2.36.2 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1901">#1901</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/e9ce0ee0473b5a11a573c942760b0e6df4c81674"><code>e9ce0ee</code></a> chore(deps-dev): Bump eslint from 7.17.0 to 7.18.0 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1902">#1902</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/e3e33ee7fcf29ff88d89b776f97be9d9b2e6eaae"><code>e3e33ee</code></a> chore(deps-dev): Bump semantic-release from 17.3.1 to 17.3.3 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1903">#1903</a>)</li> <li>Additional commits viewable in <a href="https://github.com/markedjs/marked/compare/v1.2.7...v1.2.8">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase
.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
pr created time in 2 hours
issue commentnodejs/node
Array.prototype.find(),return -1?
ok
comment created time in 2 hours
issue closednodejs/node
Array.prototype.find(),return -1?
node: 10.23.0
const messages = [{ value: 'hello node' }]; const messageWithoutValue = messages.find(message => message.value === undefined);
result: messageWithoutValue=-1 expect: undefined
closed time in 2 hours
zhengrzcreate barnchnodejs/nodejs.org
branch : dependabot/npm_and_yarn/marked-1.2.8
created branch time in 3 hours
PR opened nodejs/nodejs.org
Bumps marked from 1.2.7 to 1.2.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/markedjs/marked/releases">marked's releases</a>.</em></p> <blockquote> <h2>v1.2.8</h2> <h2><a href="https://github.com/markedjs/marked/compare/v1.2.7...v1.2.8">1.2.8</a> (2021-01-26)</h2> <h3>Bug Fixes</h3> <ul> <li>leave whitespace only lines alone (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1889">#1889</a>) (<a href="https://github.com/markedjs/marked/commit/53c79ee9196bfd06ad15aad8904a7a4d61e0f400">53c79ee</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/markedjs/marked/commit/57d41b88801566eb063cd66a210d7c34249cb7dc"><code>57d41b8</code></a> chore(release): 1.2.8 [skip ci]</li> <li><a href="https://github.com/markedjs/marked/commit/608ba7cc8b77c4b599edcc6d9b9269eadf772df4"><code>608ba7c</code></a> 🗜️ build [skip ci]</li> <li><a href="https://github.com/markedjs/marked/commit/53c79ee9196bfd06ad15aad8904a7a4d61e0f400"><code>53c79ee</code></a> fix: leave whitespace only lines alone (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1889">#1889</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/42a18f1cdecbc0facc957bb095b03f748373a41b"><code>42a18f1</code></a> chore(deps-dev): Bump rollup from 2.36.2 to 2.38.0 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1910">#1910</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/be27b84286587badff95933f40e35a60079cb99b"><code>be27b84</code></a> chore(deps-dev): Bump uglify-js from 3.12.4 to 3.12.5 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1911">#1911</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/5f4a93152e8eebad2a5bc2098c80309b3c9b887c"><code>5f4a931</code></a> chore(deps-dev): Bump jasmine from 3.6.3 to 3.6.4 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1912">#1912</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/c457c5359cf301d79b70eb17bfd9909ef1afa2c2"><code>c457c53</code></a> chore(deps-dev): Bump semantic-release from 17.3.3 to 17.3.7 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1913">#1913</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/e1392c2563864804d41f9d65a10a89e5f9aa4d49"><code>e1392c2</code></a> chore(deps-dev): Bump rollup from 2.36.1 to 2.36.2 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1901">#1901</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/e9ce0ee0473b5a11a573c942760b0e6df4c81674"><code>e9ce0ee</code></a> chore(deps-dev): Bump eslint from 7.17.0 to 7.18.0 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1902">#1902</a>)</li> <li><a href="https://github.com/markedjs/marked/commit/e3e33ee7fcf29ff88d89b776f97be9d9b2e6eaae"><code>e3e33ee</code></a> chore(deps-dev): Bump semantic-release from 17.3.1 to 17.3.3 (<a href="https://github-redirect.dependabot.com/markedjs/marked/issues/1903">#1903</a>)</li> <li>Additional commits viewable in <a href="https://github.com/markedjs/marked/compare/v1.2.7...v1.2.8">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase
.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
pr created time in 3 hours
pull request commentnodejs/node
util: add internal createInvertedPromise()
Sure, I'll change the name. 😄
comment created time in 4 hours
PR opened nodejs/node
The pattern of resolving/rejecting a Promise from outside of its executor happens numerous times throughout the codebase (more than what is updated here in fact). This commit abstracts that logic into an internal utility function.
pr created time in 4 hours
issue commentnodejs/node
Array.prototype.find(),return -1?
Will this helps? let x = [{value:'Hello there.'}] let findIt = x.find(i=> i.value === undefined) === undefined ? -1 : 1; console.log(findIt)
oh, thanks, this problem has been dealt with
glad! You can close this. if the above snipper is worked. thanks
comment created time in 4 hours
pull request commentnodejs/node
readline: replace _questionCancel with a symbol
CI: https://ci.nodejs.org/job/node-test-pull-request/35769/
comment created time in 4 hours
issue commentnodejs/node
Array.prototype.find(),return -1?
Will this helps? let x = [{value:'Hello there.'}]
let findIt = x.find(i=> i.value === undefined) === undefined ? -1 : 1; console.log(findIt)
oh,thanks,this problem has been dealt with
comment created time in 4 hours
issue commentnodejs/node
Array.prototype.find(),return -1?
@zhengrz could you try to create an isolated test case? If this behavior is observed, most likely, something inside the project monkey-patched
Array.prototype
in an incompatible way (or that is notArray.prototype.find
for any other reasons). That behavior seems to be fitting forfindIndex
instead.Try doing the following:
- Checking how
Array.prototype.find
behaves at the start of that project, before any other code is loaded, might help confirm if that is the case.- Freezing
find
onArray.ptototype
viadefineProperty
(before all the other code is loaded) might help find the culprit.
thanks
comment created time in 4 hours
PR opened nodejs/node
This commit avoids exposing a new underscored property on readline Interface instances.
pr created time in 5 hours
issue commentnodejs/node
Created issue on https://github.com/nodejs/Release/issues/641
comment created time in 5 hours
issue commentnodejs/node
Array.prototype.find(),return -1?
Will this helps? let x = [{value:'Hello there.'}]
let findIt = x.find(i=> i.value === undefined) === undefined ? -1 : 1; console.log(findIt)
comment created time in 5 hours
pull request commentnodejs/node
process,doc: add missing deprecation code
CI: https://ci.nodejs.org/job/node-test-pull-request/35768/
comment created time in 5 hours
pull request commentnodejs/node
tools: remove commented code from stability.js
CI: https://ci.nodejs.org/job/node-test-pull-request/35767/
comment created time in 5 hours
issue commentnodejs/node
@nodejs/releasers It's tier2 build now. Maybe make it in the official release process ?
that link is 404 ?
It's a private group.
oooooh ok hook it up bro lol
comment created time in 5 hours
issue commentnodejs/node
@nodejs/releasers It's tier2 build now. Maybe make it in the official release process ?
that link is 404 ?
It's a private group.
comment created time in 5 hours
PR opened nodejs/node
pr created time in 5 hours
PR opened nodejs/node
Refs: https://github.com/nodejs/node/pull/36902
pr created time in 5 hours
issue commentnodejs/node
@nodejs/releasers It's tier2 build now. Maybe make it in the official release process ?
that link is 404 ?
comment created time in 5 hours
pull request commentnodejs/node
readline: check for null input in question()
CI: https://ci.nodejs.org/job/node-test-pull-request/35765/
comment created time in 6 hours
pull request commentnodejs/node
util: fix infinite recursion during inspection
CI: https://ci.nodejs.org/job/node-test-pull-request/35766/
comment created time in 6 hours
issue commentnodejs/node
Array.prototype.find(),return -1?
@zhengrz could you try to create an isolated test case?
If this behavior is observed, most likely, something inside the project monkey-patched Array.prototype
in an incompatible way (or that is not Array.prototype.find
for any other reasons).
Try doing the following:
- Checking how
Array.prototype.find
behaves at the start of that project, before any other code is loaded, might help confirm if that is the case. - Freezing
find
onArray.ptototype
viadefineProperty
might help find the culprit.
comment created time in 6 hours