github.com/apmckinlay/gsuneido/builtin/goc

@antoniovicente ready to be reviewed now

lambdai

comment created time in 6 minutes

push eventgolang/go

Jay Conrod

commit sha a2cef9b544708ecae983ed8836ee2425a28aab68

cmd/go: don't lookup the path for CC when invoking cgo Previously, if CC was a path without separators (like gcc or clang), we'd look it up in PATH in cmd/go using internal/execabs.LookPath, then pass the resolved path to cgo in CC. This caused a regression: if the directory in PATH containing CC has a space, cgo splits it and interprets it as multiple arguments. With this change, cmd/go no longer resolves CC before invoking cgo. cgo does the path lookup on each invocation. This reverts the security fix CL 284780, but that was redundant with the addition of internal/execabs (CL 955304), which still protects us. Fixes #43808 Updates #41400 Change-Id: I65d91a1e303856df8653881eb6e2e75a3bf95c49 Reviewed-on: https://go-review.googlesource.com/c/go/+/285873 Trust: Jay Conrod <jayconrod@google.com> Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>

cmd/go: handle space in path to C compiler

push time in 7 minutes

issue closedgolang/go

What version of Go are you using (`go version`)?

<pre> $ go version go version go1.15.7 windows/amd64 </pre>

What operating system and processor architecture are you using (`go env`)?

<details><summary><code>go env</code> Output</summary><br><pre> $ go env set GO111MODULE= set GOARCH=amd64 set GOBIN= set GOCACHE=C:\Users\andrew\AppData\Local\go-build set GOENV=C:\Users\andrew\AppData\Roaming\go\env set GOEXE=.exe set GOFLAGS= set GOHOSTARCH=amd64 set GOHOSTOS=windows set GOINSECURE= set GOMODCACHE=C:\Users\andrew\go\pkg\mod set GONOPROXY= set GONOSUMDB= set GOOS=windows set GOPATH=C:\Users\andrew\go set GOPRIVATE= set GOPROXY=https://proxy.golang.org,direct set GOROOT=c:\go set GOSUMDB=sum.golang.org set GOTMPDIR= set GOTOOLDIR=c:\go\pkg\tool\windows_amd64 set GCCGO=gccgo set AR=ar set CC=gcc set CXX=g++ set CGO_ENABLED=1 set GOMOD=V:\gsuneido\go.mod set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-g -O2 set PKG_CONFIG=pkg-config set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\andrew\AppData\Local\Temp\go-build158816006=/tmp/go-build -gno-record-gcc-switches GOROOT/bin/go version: go version go1.15.7 windows/amd64 GOROOT/bin/go tool compile -V: compile version go1.15.7 gdb --version: GNU gdb (GDB) 8.1 </pre></details>

What did you do?

<pre>

go build -v -ldflags "-s -w -X 'main.builtDate=Jan 20 2021 11:17:27' -X main.mode=gui -H windowsgui" </pre>

What did you expect to see?

Successful build

What did you see instead?

<pre>

github.com/apmckinlay/gsuneido/builtin/goc

cgo: exec c:\Program: exec: "c:\Program": file does not exist </pre>

It builds successfully on 1.15.6 (and 1.16beta1)

I cut my path down to:

<pre> PATH=C:\WINDOWS\System32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\system32;C:\Program Files\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin;C:\Go\bin;C:\Users\andrew\go\bin </pre>

In particular, mingw-w64 is in c:\program files I think that was the default, but I can't remember for sure.

Cmd finds g++ using this path

<pre>

g++ --version g++ (x86_64-posix-seh-rev0, Built by MinGW-W64 project) 8.1.0 </pre>

closed time in 7 minutes

apmckinlay

Pull request review commentenvoyproxy/envoy

OIDC users with admin role are not shown as "Admin"

+load(+    "//bazel:envoy_build_system.bzl",+    "envoy_cc_extension",+    "envoy_extension_package",+)++licenses(["notice"])  # Apache 2++envoy_extension_package()++envoy_cc_extension(+    name = "peer_buffer_lib",+    hdrs = ["peer_buffer.h"],+    security_posture = "unknown",+    status = "alpha",+    deps = [+        "//source/common/buffer:buffer_lib",+        "//source/common/buffer:watermark_buffer_lib",+        "//source/common/common:empty_string",+    ],+)++envoy_cc_extension(

add an empty config.h the status is wip. secruity_posture is "unknown".

What is the best secruity_posture indicating "don't use"?

lambdai

comment created time in 8 minutes

issue commentgoharbor/harbor

why not fix it and make it show up as 'yes'?

AllForNothing

comment created time in 9 minutes

Pull request review commentenvoyproxy/envoy

+#include "extensions/io_socket/user_space_io_socket/user_space_file_event_impl.h"++#include <cstdint>++#include "common/common/assert.h"++#include "extensions/io_socket/user_space_io_socket/peer_buffer.h"++namespace Envoy {+namespace Extensions {+namespace IoSocket {+namespace UserSpaceIoSocket {++UserSpaceFileEventImpl::UserSpaceFileEventImpl(Event::Dispatcher& dispatcher, Event::FileReadyCb cb,

renamed and moved all trivial method to header file

lambdai

comment created time in 12 minutes

Pull request review commentenvoyproxy/envoy

Fix codecov collection (Part 2/2)

+#include "extensions/io_socket/user_space_io_socket/user_space_file_event_impl.h"++#include <cstdint>++#include "common/common/assert.h"++#include "extensions/io_socket/user_space_io_socket/peer_buffer.h"++namespace Envoy {+namespace Extensions {+namespace IoSocket {+namespace UserSpaceIoSocket {++UserSpaceFileEventImpl::UserSpaceFileEventImpl(Event::Dispatcher& dispatcher, Event::FileReadyCb cb,+                                               uint32_t events, UserspaceIoHandle& io_source)+    : schedulable_(dispatcher.createSchedulableCallback([this, cb]() {+        auto ephemeral_events = event_listener_.getAndClearEphemeralEvents();+        ENVOY_LOG(trace, "User space event {} invokes callbacks on events = {}",+                  static_cast<void*>(this), ephemeral_events);+        cb(ephemeral_events);+      })),+      io_source_(io_source) {+  setEnabled(events);+}++void EventListenerImpl::clearEphemeralEvents() {+  // Clear ephemeral events to align with FileEventImpl::setEnable().+  ephemeral_events_ = 0;+}++void EventListenerImpl::onEventActivated(uint32_t activated_events) {+  ephemeral_events_ |= activated_events;+}++void EventListenerImpl::setEnabledEvents(uint32_t enabled_events) {+  enabled_events_ = enabled_events;+}++void UserSpaceFileEventImpl::activate(uint32_t events) {+  // Only supported event types are set.+  ASSERT((events & (Event::FileReadyType::Read | Event::FileReadyType::Write |+                    Event::FileReadyType::Closed)) == events);

Won't change:see activateIfEnabled()

lambdai

comment created time in 14 minutes

PR opened vitessio/vitess

Reviewers

fix common select script to work for both local and operator examples

Signed-off-by: deepthi deepthi@planetscale.com

Description

In #7245 we removed a file (select_commerce_data.sql) from the operator example. However, the README still points to the deleted file. This PR fixes the README to use the correct path to the file. In addition, the use command in that file only worked for the local example, not the operator example. That has also been fixed.

Related Issue(s)

#7245 A website PR will be created after 9.0 is released and we have archived the 9.0 docs.

Checklist

[ ] Should this PR be backported?
[x] Tests were added or are not required
[ ] Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

[ ] Query Serving
[ ] VReplication
[ ] Cluster Management
[ ] Build
[ ] VTAdmin

+3 -3

1 commit in planetscale/vitess/tree/ds-fix-use-commerce vitessio/vitess/tree/master

0 comment

2 changed files

pr created time in 15 minutes

pull request commentetcd-io/etcd

The PR (finally) works as expected. The first full coverage report for a long time is here: https://codecov.io/gh/etcd-io/etcd/tree/66255967e83c758f95613c89789a9aa426ce3c85

It manages to execute all tests (so is faster)
It has proper paths resolution, such that you can click any file to see the report
If filters our generated files (like pb.go & pb.gw.go)

ptabor

comment created time in 17 minutes

Pull request review commentenvoyproxy/envoy

scaled range timer: guard against queue deletion during timer fire

 void ScaledRangeTimerManagerImpl::onQueueTimerFired(Queue& queue) {    // Pop and trigger timers until the one at the front isn't supposed to have expired yet (given the   // current scale factor).+  queue.processing_timers_ = true;   while (!timers.empty() &&          computeTriggerTime(timers.front(), queue.duration_, scale_factor_) <= now) {     auto item = std::move(queue.range_timers_.front());     queue.range_timers_.pop_front();     item.timer_.trigger();   }+  queue.processing_timers_ = false;

So processing_timers_ needs to be per queue since otherwise the queue not empty invariant would not hold if a timer from queue A removes a timer from queue B. It would be good to also cover that case in tests.

Also, is there code somewhere that verifies the invariant that all active queues are non-empty?

chradcliffe

comment created time in 20 minutes

issue commentgolang/go

x/time/rate: Parallel reservations in Limiter.WaitN are served in parallel, violating rate limit

I don't see a problem here other than an error in your output: 1000000/elapsed? 10 goroutines x 10 iterations x 100 = 10000 10000 / 10 seconds for program execution = 1000 rps == the configured rate limiter

nbingham1

comment created time in 21 minutes

push eventgraphql/graphql-js

commit sha 01663f61121b91f37ff9920d5b817cfbd413b9ed

Add @stream directive to specified directives

commit sha a0cef35c9ee6b9be51f6e44a9d57be6361ebaa76

Implement support for @stream directive

commit sha 637fefb36226424127b4a59025024f74dd821015

add defer/stream support for subscriptions (#7)

commit sha 1c4940a2f6be95e9a7183435045c69ad5f62c9dd

Return underlying AsyncIterators when execute result is returned (#2843)

route config: Allow to configure direct response body size

push time in 22 minutes

Pull request review commentenvoyproxy/envoy

 TEST_F(RouteEntryMetadataMatchTest, ParsesMetadata) {   } } +class RouteConfigurationDirectResponseBodyTest : public testing::Test, public ConfigImplTestBase {};++TEST_F(RouteConfigurationDirectResponseBodyTest, DirectResponseBodySizeTooLarge) {

Added a case above. And the cases of different data sources combination for setting body content is covered in RouteMatcherTest.DirectResponse.

dio

comment created time in 22 minutes

push eventvitessio/vitess

commit sha e24c3aed4afe07dec65463cb94f1cc089a3d0371

Define GetSchema RPC, run generators, add server impl stub Signed-off-by: Andrew Mason <amason@slack-corp.com>

commit sha 77fbde75582783d86e40091f86d96448d0670723

Add implementation, tests, and another test tmclient Signed-off-by: Andrew Mason <amason@slack-corp.com>

commit sha 6e261beed2e781dd331f92dbb02f6cd3e770c53a

Rewrite legacy vtctl GetSchema test to use packaged fake tmclient Signed-off-by: Andrew Mason <amason@slack-corp.com>

commit sha da1437c3edcd77c4d7252b812bc27cc8ab06303c

Implement CLI command, refactor legacy command to use new RPC Signed-off-by: Andrew Mason <amason@slack-corp.com>

commit sha 3ee391be2c149bf33ba4357cd9ece36d511b1042

Any test that needs a VtctldServer needs to override the protocol to the fake Signed-off-by: Andrew Mason <amason@slack-corp.com>

Rohit Nayak

commit sha e34764d1df3b96ad1095bb7c1ed221130abc8bd6

Merge pull request #7346 from tinyspeck/am_vtctld_getschema [vtctld] Migrate GetSchema