profile
viewpoint
Joe Haddad Timer @vercel Strongsville, Ohio https://timer.blog Senior Software Engineer at Vercel. Maintainer of Next.js and Create React App.

facebook/create-react-app 84148

Set up a modern web app by running one command.

cssnano/cssnano 3614

A modular minifier, built on top of the PostCSS ecosystem.

fridays/next-routes 2246

Universal dynamic routes for Next.js

hashicorp/next-mdx-enhanced 312

A Next.js plugin that enables MDX pages, layouts, and front matter

iansu/create-react-app-meta 2

Create React App meeting notes

Timer/bayesian-learning 2

A parallel implementation of K2 Bayesian learning.

Timer/babel-plugin-dynamic-import-node 1

Babel plugin to transpile import() to a deferred require(), for node

Timer/chartjs 1

A simple and functional charting library.

created tagmartpie/next-transpile-modules

tag5.0.0

Next.js plugin to transpile code from node_modules

created time in 12 hours

release martpie/next-transpile-modules

5.0.0

released time in 12 hours

push eventmartpie/next-transpile-modules

Pierre de la Martinière

commit sha cd37a7e02292ef5d307443d6d676fe6d0d570d91

5.0.0

view details

push time in 12 hours

PR closed martpie/next-transpile-modules

feat: Improved HMR and Cache management on Webpack 5

Better cache management within webpack Faster HMR Simpler resolution compared to before

+139 -30

11 comments

4 changed files

ScriptedAlchemy

pr closed time in 12 hours

delete branch martpie/next-transpile-modules

delete branch : nextjs-10

delete time in 12 hours

push eventmartpie/next-transpile-modules

Pierre de la Martinière

commit sha 2be60fb75036bedac4c8be2acb4ea07d39395d1c

Update tests for Next.js 10.0.0

view details

Pierre de la Martinière

commit sha 4f6a3aee8ac4fcf91314508ef41f8a45534df190

Update README.md

view details

Pierre de la Martinière

commit sha 9b14b5b1ba754b0bef692a0977053e18280450ba

Remove CSS modules from node_modules override

view details

Pierre de la Martinière

commit sha 696822d138aceea47bbe0f15e9ef404fb41aa43f

Share files between tests and prepare things at pretest phases

view details

Pierre de la Martinière

commit sha 3228787b312ac18e305240c2b2f8cf4414786d77

Use beforeAll for files setup rather than cli

view details

Pierre de la Martinière

commit sha 128521bcf217b1ab784cfd290f0b97d536720f45

Use pre-setup Node.js script instead of beforeAll

view details

Pierre de la Martinière

commit sha 75d5d1e56030f88c129b02f8e3cb7c1031d01c7b

Update jest testRegex

view details

Pierre de la Martinière

commit sha aa87d991f0ecb8401ab0058bae0e3096a8fb30e8

Fix formatting

view details

Pierre de la Martinière

commit sha b7f8d7a53080ec9f7eb41a2448803f9709c4a9f9

Let's try another testRegex

view details

Pierre de la Martinière

commit sha d477ce07cc2f26a78335730437e9073c35e87196

Add .gitattributes

view details

Pierre de la Martinière

commit sha 8a777ed4b21dc9e63fb8b040ae9861417edb0634

Add pnpm integration tests

view details

Pierre de la Martinière

commit sha cfef8497fda15ea3584ae50ff0fafb9b141332ad

Add missing prefix when installing pnpm deps

view details

Pierre de la Martinière

commit sha ba764643e46c6ad60c2276e6d7163e359da67c18

Fix unit-tests setup

view details

Pierre de la Martinière

commit sha 5c1f013ab422f384e1cdcbd698a1a0c6ed656592

Re-update dependencies

view details

Pierre de la Martinière

commit sha 027758db64be5c5b74add2fc211aa225d8d7cb8e

Prepare tests to use native module resolution instead of path matching

view details

Pierre de la Martinière

commit sha ae1afea07e8a91df6a86f3d0499062ca88723efe

Drop regex implementation, use modules resolvers instead

view details

Pierre de la Martinière

commit sha 37296fcf40001ed2df3874a42a1b86822aef3d74

Fix externals (phew...)

view details

Pierre de la Martinière

commit sha 948e70894d6bb98ca208af0d7204f0c7126fd7e0

Remove outdated tests

view details

Pierre de la Martinière

commit sha b0b642817111eab082700f8dd1c3a91635fb2856

Simplify webpackDevMiddleware override

view details

Pierre de la Martinière

commit sha af7c63e16b73017982bd3546e2f37ad9a003598d

Re-add regexEqual tests

view details

push time in 12 hours

PR merged martpie/next-transpile-modules

Next.js 10 + v5
  • [x] Fixes #131 - Next.js 10
  • [ ] Fixes #115 - Improvements

If you want to try it, check #132, all feedback is very appreciated 🚀

+13036 -14258

24 comments

95 changed files

martpie

pr closed time in 12 hours

issue closedmartpie/next-transpile-modules

v5

This is an issue to keep track of all the things for the next major version on next-transpile-modules.

The popularity of this plugin is rising every month (> 180k weekly downloads at the time of this issue), and the use-cases and different setups used with this plugin are getting bigger and more complex.

Ok, let's go:

  • [ ] Support all major package managers
    • [x] npm (via file:)
    • [x] npm (via workspaces)
    • [x] yarn (via workspaces)
    • [x] yarn 2 (berry) #75
      • [x] make it work
      • [x] next-transpile-modules is not working when called from node_modules
    • [x] (?) pnpm
  • [ ] Add tests for hot-reloading
  • [x] Debug mode #120
  • [x] Improve transpilation overrides
    • [x] (?) Switch to resolver rather than path matchers
    • [x] (?) Match package names rather than package paths #90
  • [ ] ~Webpack 5-only support (to-be-discussed)~
  • [ ] (?) Serverless support #11

(?) -> not sure, to be discussed

Edit Nov 23rd: so you want to test it?

The branch is called nextjs-10 (yes it is misleading). It is unstable and can break anytime. No API changes, but the internal behavior is completely different (we don't rely on regexes anymore, but on real package names). Make sure you have a valid main field in your package.json (you can put an empty index.js at the root if you want.

closed time in 12 hours

martpie

pull request commentmartpie/next-transpile-modules

Next.js 10 + v5

Ok let's go, we'll release the cache optimization in a minor release later

martpie

comment created time in 12 hours

pull request commentmartpie/next-transpile-modules

Next.js 10 + v5

We disabled it by default. Now it's about adding the optimization by default or not

martpie

comment created time in 15 hours

pull request commentmartpie/next-transpile-modules

Next.js 10 + v5

Yep, technically the only thing missing is the cache optimization for W5, I still haven't tried.

I'd like to see if I can solve it in a performant, and more importantly, isolated way (another module somewhere?) to avoid code noise.

Another option is to leave this part to the user (the dev), at least until we come up with a nice solution. Or hide it behind a flag.

I still have to think about it.

Hello, I use next-transpile-modules with node_module packages so I would prefer an option to disable the cache (like the unstable_webpack5 one).

martpie

comment created time in 15 hours

pull request commentmartpie/next-transpile-modules

Next.js 10 + v5

Yep, technically the only thing missing is the cache optimization for W5, I still haven't tried.

I'd like to see if I can solve it in a performant, and more importantly, isolated way (another module somewhere?) to avoid code noise.

Another option is to leave this part to the user (the dev). Or hide it behind a flag.

I still have to think about it.

martpie

comment created time in a day

pull request commentmartpie/next-transpile-modules

Next.js 10 + v5

Looking good!

martpie

comment created time in a day

issue openediansu/create-react-app-meta

Meeting - 12/9/2020

Agenda

  • News/announcements
  • Review previous action items

Attendees

Notes

Previous Action Items

Action Items

Details

December 9, 2020 10:00am Pacific https://www.timeanddate.com/worldclock/fixedtime.html?msg=Create+React+App+maintainers+meeting&iso=20201209T18&p1=1440

Zoom: https://zoom.us/j/163553316

created time in a day

issue closediansu/create-react-app-meta

Meeting - 10/28/2020

Agenda

  • News/announcements
  • Review previous action items

Attendees

  • @iansu
  • @mrmckeb
  • @ianschmitz
  • @eddiemonge

Notes

  • 4.0.1
    • Quick fix for TypeScript config
    • Work around frozen TypeScript config object
    • Fix as many issues as we can in the next couple days, then release
  • v5
    • Prototype a new CLI (@iansu)
  • Tests
    • Try to fix tests on Azure (@ianschmitz)
    • Some test suites already work on GitHub Actions, let's move those over (@iansu)

Previous Action Items

  • Ask about notifications for GitHub Discussions (@iansu)
  • Build a new test suite that runs on GitHub Actions (@mrmckeb)
  • Create new CLI (@iansu)
  • Review swag production options
  • Follow up with Google about WebWorker PR (@iansu)
  • Talk to Facebook Open Source about T-shirts and swag (@iansu)
  • Remove Jack from accounts (@iansu)
  • Make sure the team has access to Azure DevOps (@iansu)
  • Set up Open Collective (@iansu)
  • Add maintainer info to README (@iansu)
  • Find out what other projects are using react-dev-utils/openBrowser (@iansu)
  • Fix and force-push master (@iansu)
  • Don't swallow stack traces on warnings (@gaearon)
  • Investigate how other similar projects handle testing (@ianschmitz)
  • Lock down force pushing to master (@gaearon)
  • Look into enabling canary releases (@ianschmitz)
  • Come up with a list of potential Open Collective donors (@iansu)
  • Talk to Dan about getting access to the eject survey (@iansu)
  • Document triaging process (@iansu)
  • Document PR process (@iansu)
  • Create maintainer onboarding document (@iansu)

Action Items

  • [ ] Ask about notifications for GitHub Discussions (@iansu)
  • [ ] Build a new test suite that runs on GitHub Actions (@mrmckeb)
  • [ ] Create new CLI (@iansu)
  • [ ] Review swag production options
  • [ ] Follow up with Google about WebWorker PR (@iansu)
  • [ ] Talk to Facebook Open Source about T-shirts and swag (@iansu)
  • [ ] Remove Jack from accounts (@iansu)
  • [ ] Make sure the team has access to Azure DevOps (@iansu)
  • [ ] Set up Open Collective (@iansu)
  • [ ] Add maintainer info to README (@iansu)
  • [ ] Find out what other projects are using react-dev-utils/openBrowser (@iansu)
  • [ ] Fix and force-push master (@iansu)
  • [ ] Don't swallow stack traces on warnings (@gaearon)
  • [ ] Investigate how other similar projects handle testing (@ianschmitz)
  • [ ] Lock down force pushing to master (@gaearon)
  • [ ] Look into enabling canary releases (@ianschmitz)
  • [ ] Come up with a list of potential Open Collective donors (@iansu)
  • [ ] Talk to Dan about getting access to the eject survey (@iansu)
  • [ ] Document triaging process (@iansu)
  • [ ] Document PR process (@iansu)
  • [ ] Create maintainer onboarding document (@iansu)

Details

October 28, 2020 10:00am Pacific https://www.timeanddate.com/worldclock/fixedtime.html?msg=Create+React+App+maintainers+meeting&iso=20201028T17&p1=1440

Zoom: https://zoom.us/j/163553316

closed time in a day

iansu

push eventmartpie/next-transpile-modules

Pierre de la Martinière

commit sha 594cc5484fd02adc119baef9e04ca630db39426b

Add credits section

view details

push time in a day

issue commentmartpie/next-transpile-modules

Pnp workspaces aren't transpiled (yarn berry)

Is anyone willing to try the branch again? I tested a yarn berry and managed to fix the resolution issue (without having to copy paste the library in your project).

You can also try @5.0.0-beta.15, it should be easier to install than the branch.

goszczynskip

comment created time in a day

push eventmartpie/next-transpile-modules

Pierre de la Martinière

commit sha a0092c35860d5b72d5b2554bf0721f00caf6ecda

5.0.0-beta.15

view details

push time in a day

push eventmartpie/next-transpile-modules

Pierre de la Martinière

commit sha 1eb66142c1aaca1eff409addf557f1ed1aac66ce

Fix resolve base directory for yarn berry

view details

push time in a day

push eventmartpie/next-transpile-modules

Pierre de la Martinière

commit sha 2798c9f7c4649c5257f227b5aae034672b0ea320

Update and clean dependencies

view details

Pierre de la Martinière

commit sha 0ad8f27f2c85768433225bec448ade486b22590e

Add 'source' to mainFields

view details

push time in 2 days

issue commentmartpie/next-transpile-modules

v5

Yeah I think we do something to a lesser extent when attempting to resolve Cache management

martpie

comment created time in 2 days

pull request commentTimer/blog

Bump highlight.js from 10.1.1 to 10.1.2

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/timer/blog/ku68mco46
✅ Preview: In Progress

dependabot[bot]

comment created time in 2 days

PR opened Timer/blog

Bump highlight.js from 10.1.1 to 10.1.2

Bumps highlight.js from 10.1.1 to 10.1.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/highlightjs/highlight.js/releases">highlight.js's releases</a>.</em></p> <blockquote> <h2>10.1.2</h2> <p>Fixes:</p> <ul> <li>fix(night) Prevent object prototype values from being returned by <code>getLanguage</code> (<a href="https://github-redirect.dependabot.com/highlightjs/highlight.js/issues/2636">#2636</a>) <a href="https://github.com/night">night</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/highlightjs/highlight.js/blob/10.1.2/CHANGES.md">highlight.js's changelog</a>.</em></p> <blockquote> <h2>Version 10.1.2</h2> <p>Fixes:</p> <ul> <li>fix(night) Prevent object prototype values from being returned by <code>getLanguage</code> (<a href="https://github-redirect.dependabot.com/highlightjs/highlight.js/issues/2636">#2636</a>) <a href="https://github.com/night">night</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/highlightjs/highlight.js/commit/edd73d2402b3d66706d141e9fadda004d237925d"><code>edd73d2</code></a> bump v10.1.2</li> <li><a href="https://github.com/highlightjs/highlight.js/commit/7241013ae011a585983e176ddc0489a7a52f6bb0"><code>7241013</code></a> (parser) use null prototype objects for languages/aliases (<a href="https://github-redirect.dependabot.com/highlightjs/highlight.js/issues/2636">#2636</a>)</li> <li>See full diff in <a href="https://github.com/highlightjs/highlight.js/compare/10.1.1...10.1.2">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~isagalaev">isagalaev</a>, a new releaser for highlight.js since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+5 -5

0 comment

2 changed files

pr created time in 2 days

create barnchTimer/blog

branch : dependabot/npm_and_yarn/highlight.js-10.1.2

created branch time in 2 days

pull request commentvercel/spr-landing

Update dependencies, rename ZEIT to Vercel.

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/spr-landing/hz750jgwy
✅ Preview: In Progress

leerob

comment created time in 2 days

PR opened vercel/spr-landing

Update dependencies, rename ZEIT to Vercel.

We'll also want to add an alias for spr.vercel.app 👍

+1641 -3119

0 comment

11 changed files

pr created time in 2 days

issue openedvercel/ncc

ncc and devDependencies or dependencies or bundledDependencies

I'm building a package with ncc.

I have 4 dependencies which are included in my ncc output. Where should these dependencies go in my package.json file?

Do they all go into devDependencies? Do they also go into bundledDependencies? I can't quite wrap my head around it and would be grateful for any input.

created time in 2 days

pull request commentmartpie/next-transpile-modules

Next.js 10 + v5

CSS modules also seem like they are impacted, import styles from './thing.scss' returns {}

martpie

comment created time in 3 days

pull request commentmartpie/next-transpile-modules

Next.js 10 + v5

My latest work combined with yours makes projects like geodesy fail to resolve at all in next

Give that one a try - it just will not resolve for me - devs had to go back to 4.2.1 where regex was still used

martpie

comment created time in 3 days

delete branch Timer/next.js

delete branch : update-analytics-domain

delete time in 3 days

more