profile
viewpoint
Mark Allen TSMMark @Vydia Greater NYC http://vydia.com Black Lives Matter. Dad, Co-founder & VP Engineering @Vydia, Powering the Business of Music. ❤️ React GraphQL JS Ruby.

APSL/react-native-keyboard-aware-scroll-view 4519

A ScrollView component that handles keyboard appearance and automatically scrolls to focused TextInput.

kudago/smart-app-banner 512

Lightweight smart app banner with no jquery requirement

dannyvassallo/sernjs 21

React, Node, Express, Passport, and Material-ui boilerplate with live-reloading capability server and clientside. (Welcoming contributions!)

dannyvassallo/vine_dl 5

Auth a user in to vine and download the available videos to your computer or server.

cloworm/guess-that-gif 4

Guess that Gif

cloworm/regex-playground 2

RegEx Playground with examples built in React

cloworm/todo 2

Todo App built with Next.js and Tailwind CSS. Animated with Framer Motion

dannyvassallo/git-bash-profile 1

Tweaks on the bash setup from: http://mediadoneright.com/content/ultimate-git-ps1-bash-prompt with instructions for OSX setup VS linux

TSMMark/fg2app 1

FanGate App v2.0

push eventTSMMark/TSMMark

Mark Allen

commit sha ada72a2760b120142861440a0fe11ecb13612ee1

Update README.md

view details

push time in 7 hours

startedFormidableLabs/react-fast-compare

started time in a day

push eventVydia/eslint-plugin-react-memo

TSMMark

commit sha 92ba1cf82f6e986a2b0fc5c6ef3a4cb7e58c01b3

incr will resume from any point

view details

push time in 3 days

create barnchVydia/eslint-plugin-react-memo

branch : memoized-var-name-incr-from-1

created branch time in 3 days

push eventVydia/eslint-plugin-react-memo

TSMMark

commit sha 1a03e1861b2cc964dda0a415e5b580bc5b09999d

fix tests

view details

push time in 3 days

issue commentwix/eslint-plugin-lodash

Rule proposal: forbid use of blacklisted lodash methods

@keverw feel free to try out using my branch https://github.com/wix/eslint-plugin-lodash/pull/335/files#diff-628fae3b7c19f17b44e6e61fe7bb21259a3e218e865baeb01809290acbe2559eR27-R33

You'd only have to change map to isObject and change the autofix code to replace with isPlainObject instead if you want it to autofix. If this seems like a rule that may be accepted we could work towards parameterizing the rule instead of hard coding.

serhalp

comment created time in 10 days

startedpypa/pipenv

started time in 12 days

pull request commentamilajack/eslint-plugin-flowtype-errors

New Rule: enforce-min-coverage-comments-sync

Confirmed next release works

TSMMark

comment created time in 17 days

pull request commentamilajack/eslint-plugin-flowtype-errors

New Rule: enforce-min-coverage-comments-sync

Just saw this. Will try to test next tag later tonight.

For the windows failure I can only guess something to do with EOL characters since the lines look identical to me

TSMMark

comment created time in 17 days

delete branch Vydia/eslint-plugin-flowtype-errors

delete branch : enforce-min-coverage-comments-sync-rule

delete time in 17 days

PullRequestReviewEvent

Pull request review commentamilajack/eslint-plugin-flowtype-errors

New Rule: enforce-min-coverage-comments-sync

 function createFilteredErrorRule(filter: (CollectOutputElement) => any): (contex   }; } +const MIN_COVERAGE_DIRECTIVE_COMMENT_PATTERN =+  /(\s*eslint\s*['"]flowtype-errors\/enforce-min-coverage['"]\s*:\s*\[\s*(?:2|['"]error['"])\s*,\s*)(\d+)(\]\s*)/

@amilajack I put a line break after =, but the pattern is still pretty long. AFAIK the only way to break this up further would be to use regexp constructor like this: https://stackoverflow.com/a/12317105/2696867

I personally prefer the regex literal, but lmk what you'd prefer

TSMMark

comment created time in 17 days

PullRequestReviewEvent

push eventVydia/eslint-plugin-flowtype-errors

TSMMark

commit sha f2e6ec42ee12585009c01b8286d827912f514edf

address pr review comments

view details

push time in 17 days

Pull request review commentamilajack/eslint-plugin-flowtype-errors

New Rule: enforce-min-coverage-comments-sync

     "eslint-plugin-vue": "^7.20.0",     "execa": "^5.1.1",     "flow-bin": "0.139.0",+    "gitpkg": "^1.0.0-beta.2",

Was using gitpkg to publish to a git ref in order to install in another codebase test the plugin there. Will clean it up !

TSMMark

comment created time in 17 days

PullRequestReviewEvent

PR opened amilajack/eslint-plugin-flowtype-errors

New Rule: enforce-min-coverage-comments-sync

Why?

When using eslint plugin flowtype rule enforce-min-coverage, a common pattern in practice seems to be override the global eslint config value in several specific files, when the coverage is lower than required in that one file, but you are okay with the lower % for whatever reason.

That looks like:

// @flow
/* eslint "flowtype-errors/enforce-min-coverage": [2, 30] */

// ... all the file's code below

However, after years of doing this in certain files, we've come to a place where some files used to have low coverage %, but at some point, we have improved type-safety of underlying modules and consequently increased the coverage % of many files downstream.

So now we're left with many files with comments like /* eslint "flowtype-errors/enforce-min-coverage": [2, 30] */, when actually the coverage % could be much higher than that.

New Rule Proposal

I have introduced a new rule called enforce-min-coverage-comments-sync which will update the per-file comments if the actual coverage % is greater than the enforce-min-coverage value by a configurable margin %.

  • If the file's actual coverage exceeds the local comment's % requirement, but is still below the global % requirement, the comment will be updated with a greater % value.
  • If the file's actual coverage exceeds the global % requirement, the comment will be removed entirely.

Let me know if you think this is a rule you would accept, and if so I can clean up this PR, rebase, whatever you want, lmk.

By the way, I ran this new rule on our medium-sized React codebase and it worked exactly as intended.

Thanks!

+526 -10

0 comment

12 changed files

pr created time in 17 days

push eventVydia/eslint-plugin-flowtype-errors

TSMMark

commit sha 2f5e8579b656159a60fc1047713208a9b4e8b3bd

remove leftover copypasta from enforce-min-coverage

view details

TSMMark

commit sha c821808f95ac3f337b9e07fb218654aedf39883c

0.4

view details

push time in 17 days

created tagVydia/eslint-plugin-flowtype-errors

tageslint-plugin-flowtype-errors-v4.5.0-pre0.4-gitpkg

Run Flow as an ESLint plugin

created time in 17 days

push eventVydia/eslint-plugin-flowtype-errors

TSMMark

commit sha 08666af23aac386a4cda587628015197467b7a6c

remove comment if coverage above global threshold

view details

TSMMark

commit sha 9751c6dc79f27d3b6f688327c4ce9ca9b8f98e75

add coverage-sync-* examples

view details

TSMMark

commit sha 5ab7f4390c6ee6b1105ce13366d452cd39f3ac86

add to codebases

view details

TSMMark

commit sha a835f7c00a38cbe94ce930c54719e5e1f85aa42f

Update format.spec.js.snap

view details

TSMMark

commit sha 24439356f113fcf03e6fbf5a149918b93ce91a78

handle expected fixes

view details

TSMMark

commit sha 44da253c1ebe0e20efac761518a4e84c34b2bc0b

no js ext on fixed examples so they won't be fixed themselves

view details

TSMMark

commit sha 2df7d8887aa52b5ed0dde2add4a803014657e869

percent is 33 apparently ok flow

view details

TSMMark

commit sha a8c99bde839202a4628e6f665e3889015b3cdaf8

version

view details

push time in 17 days

created tagVydia/eslint-plugin-flowtype-errors

tageslint-plugin-flowtype-errors-v4.5.0-pre0.3-gitpkg

Run Flow as an ESLint plugin

created time in 17 days

push eventVydia/eslint-plugin-flowtype-errors

TSMMark

commit sha 956abff49cadb06897f4059548e068e57f0dc0cb

floor

view details

push time in 18 days

created tagVydia/eslint-plugin-flowtype-errors

tageslint-plugin-flowtype-errors-v4.5.0-pre0.2-gitpkg

Run Flow as an ESLint plugin

created time in 18 days

push eventVydia/eslint-plugin-flowtype-errors

TSMMark

commit sha ff81b2e25638306a83c010d4a44f5ff418da4e73

4.5.0-pre0.1

view details

push time in 18 days

created tagVydia/eslint-plugin-flowtype-errors

tageslint-plugin-flowtype-errors-v4.5.0-pre0.1-gitpkg

Run Flow as an ESLint plugin

created time in 18 days

created tagVydia/eslint-plugin-flowtype-errors

tageslint-plugin-flowtype-errors-v4.4.0-gitpkg

Run Flow as an ESLint plugin

created time in 18 days

MemberEvent

startedlttb/flown

started time in 24 days

more