profile
viewpoint

Bahmni/bahmni-core 74

Core OpenMRS modules for Bahmni (including ERP & ELIS Atom Feed Clients)

Bahmni/bahmni-vagrant 9

Management of Vagrant box using Packer. Out-Of-The-Box bahmni on CentOS 6.7

Bahmni/bahmni-offline 5

Repo to hold bahmni offline code. This will support Chromium app and Android app as of now.

Bahmni/emr-functional-tests 4

emr functional tests

akhil-ghatiki/foreCastAlexSkillBackend 3

This is a custom backend logic for Alexa skill that forecasts the retail demand

Bahmni/bahmni-docker 3

Configuration required to build and run bahmni docker images

Bahmni/bahmni-java-utils 3

This repository has various functional utilities needed by bahmni.

Bahmni/bahmni-connect 2

Front end for the Bahmni Connect, written in AngularJS

Bahmni/bahmni-docker-old 2

DEPRECATED - This repository contains the relevant docker configuration for setting up Bahmni

Bahmni/bahmni-gauge 2

Bahmni Automation Test Suite using Gauge Framework

Pull request review commentBahmni/default-config

BAH-1125 - Swati/Praveena - Hide 'Join teleconsultation' button on non-teleconsultation Appointments

 angular.module('bahmni.common.displaycontrol.custom')             var jitsiMeetingId = $scope.upcomingAppointmentsUUIDs[appointmentIndex];             appService.setTeleConsultationVars(jitsiMeetingId, true);         };+        $scope.showJoinTeleconsultationOption = function (appointmentIndex) {

Please refrain from hard-coding texts. 'Scheduled' - please pull it from config.

praveenadayanand

comment created time in 4 hours

push eventopenmrs/openmrs-module-htmlformentry

openmrs-bot

commit sha 7a1e271b78c4e870a27870204ca082a26d9aa594

committing translations from transifex

view details

push time in 4 hours

pull request commentopenmrs/openmrs-module-uiframework

UIFR-217: Problem with ConfigurationResourceProvider running on Windows

I always forget about Windows...

mogoodrich

comment created time in 8 hours

create barnchopenmrs/openmrs-module-uiframework

branch : UIFR-217

created branch time in 8 hours

push eventopenmrs/openmrs-module-htmlformentry

Michael Seaton

commit sha cd91a682906822815c6b5c275f79ce7e9e2fa6be

Committing new French translations from transifex.

view details

push time in 8 hours

push eventopenmrs/openmrs-module-htmlformentry

Michael Seaton

commit sha 815195e19271235ff209e6754590995aea6cb266

Fix to properly translate select label attribute on drugOrder tag.

view details

push time in 15 hours

Pull request review commentopenmrs/openmrs-module-htmlformentryui

HTML-768: In HFE-UI, support form versions when loading via definitio…

 public static HtmlForm getHtmlFormFromUiResource(ResourceFactory resourceFactory         return getHtmlFormFromResourceXml(formService, htmlFormEntryService, xml);     } ++    // the new method above with "encounter" is preferred if an encounter is available, see: https://issues.openmrs.org/browse/HTML-768+    public static HtmlForm getHtmlFormFromUiResource(ResourceFactory resourceFactory, FormService formService, HtmlFormEntryService htmlFormEntryService, String providerAndPath) throws IOException {+        // using new Encounter() is a bit of a hack, used for a proper method signature hack; safe because the called method+        // perform a null check on encounter.getForm()+        return getHtmlFormFromUiResource(resourceFactory, formService, htmlFormEntryService, providerAndPath, new Encounter());

Oh, cool, I never realized you could do that... it appears to work, thanks!

mogoodrich

comment created time in 15 hours

push eventopenmrs/openmrs-module-htmlformentryui

mgoodrich

commit sha a42af27941ad1008bdf84052d1c13549d334d55f

follow-up commit

view details

push time in 15 hours

Pull request review commentopenmrs/openmrs-module-htmlformentryui

HTML-768: In HFE-UI, support form versions when loading via definitio…

 public void controller(@RequestParam(value="patientId", required=false) Patient      */     protected HtmlForm getHtmlFormFromResource(String resource, ResourceFactory rf, FormService fs, HtmlFormEntryService hfs) {         try {+            // TODO figure out how flowsheets might work with: https://issues.openmrs.org/browse/HTML-768

Seems fine for now.

mogoodrich

comment created time in 15 hours

Pull request review commentopenmrs/openmrs-module-htmlformentryui

HTML-768: In HFE-UI, support form versions when loading via definitio…

 public static HtmlForm getHtmlFormFromUiResource(ResourceFactory resourceFactory         return getHtmlFormFromResourceXml(formService, htmlFormEntryService, xml);     } ++    // the new method above with "encounter" is preferred if an encounter is available, see: https://issues.openmrs.org/browse/HTML-768+    public static HtmlForm getHtmlFormFromUiResource(ResourceFactory resourceFactory, FormService formService, HtmlFormEntryService htmlFormEntryService, String providerAndPath) throws IOException {+        // using new Encounter() is a bit of a hack, used for a proper method signature hack; safe because the called method+        // perform a null check on encounter.getForm()+        return getHtmlFormFromUiResource(resourceFactory, formService, htmlFormEntryService, providerAndPath, new Encounter());

Don't love the "new Encounter()". Could you achieve the same effect by doing "(Encounter)null" ?

mogoodrich

comment created time in 15 hours

pull request commentopenmrs/openmrs-contrib-android-client

AC-657 added About section

@rishabh-997 , @LuGO0 i have made the changes

MasterBlaster99

comment created time in 15 hours

Pull request review commentBahmni/bahmni-core

BAH-1127|Buvaneswari|openElis to OpenMRS sync

                 <version>${calculationModuleVersion}</version>                 <scope>test</scope>             </dependency>+

Agreed. Will remove this.

buvaneswari-arun

comment created time in 17 hours

Pull request review commentBahmni/bahmni-core

BAH-1127|Buvaneswari|openElis to OpenMRS sync

                 <version>${calculationModuleVersion}</version>                 <scope>test</scope>             </dependency>+

are these needed? jaxb are all XML schema and binding dependencies.

buvaneswari-arun

comment created time in 17 hours

Pull request review commentBahmni/bahmni-java-utils

BAH-1127|Buvaneswari|OpenElis not syncing with OpenMRS

 public HttpResponse get(HttpRequestDetails requestDetails) {     }      public HttpResponse get(HttpRequestDetails requestDetails, HttpHeaders httpHeaders) {-        defaultHttpClient = (connectionManager == null) ? new DefaultHttpClient() : new DefaultHttpClient(connectionManager);-        defaultHttpClient.getParams().setParameter(CoreConnectionPNames.SO_TIMEOUT, readTimeout);-        defaultHttpClient.getParams().setParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, connectTimeout);          HttpGet httpGet = new HttpGet(requestDetails.getUri());+        RequestConfig requestConfig = RequestConfig.custom()+                .setConnectTimeout(readTimeout)+                .setSocketTimeout(connectTimeout)+                .build();+        if(connectionManager == null) {+            connectionManager = new PoolingHttpClientConnectionManager();+        }+        closeableHttpClient = HttpClientBuilder.create()

you could have done with try with resources block, then you would not have to handle the closing part. But if caller is calling the closeConnection() and you wouldn't want to refactor that - then its ok

buvaneswari-arun

comment created time in 17 hours

Pull request review commentBahmni/bahmni-java-utils

BAH-1127|Buvaneswari|OpenElis not syncing with OpenMRS

             <scope>test</scope>         </dependency>     </dependencies>+    <build>

is this required? the httpcomponents is mentioned as provided dependency anyway

buvaneswari-arun

comment created time in 17 hours

push eventbahmni-msf/amman-config

Supriya Muppiri

commit sha b505df23075ffbaf921d96964d9b0eb6eacf5b73

Vinisha, Supriya | MOBN-1579 | Add video concept to Video Upload section

view details

push time in 18 hours

pull request commentopenmrs/openmrs-contrib-android-client

AC-657 added About section

I have made the changes @rishabh-997 , @LuGO0

MasterBlaster99

comment created time in 19 hours

push eventbahmni-msf/amman-config

Supriya Muppiri

commit sha 9fcf178a56c4e22590beebbba63b99a324574e02

Supriya, Vinisha, Tarun | MOBN-1575 | MOBN-1579 | Add set members to Form sections

view details

push time in 21 hours

push eventbahmni-msf/amman-config

Supriya Muppiri

commit sha f9f375505e7bdb83200359fb4c8c1ed8172f52d3

Vinisha, Supriya | MOBN-1575 |MOBN-1579 | Add migrations to liquibase.xml

view details

push time in a day

push eventopenmrs/openmrs-module-htmlformentry

openmrs-bot

commit sha eba3dc5c57b58f23abebddce11b28f0632c9a94c

committing translations from transifex

view details

push time in a day

pull request commentopenmrs/openmrs-module-htmlformentryui

HTML-768: In HFE-UI, support form versions when loading via definitio…

@mseaton note that I just put in TODO in the flowsheet stuff... I didn't give it much thought, but lmk if you think we should deal with this now...

mogoodrich

comment created time in a day

pull request commentopenmrs/openmrs-ocl-client

OCLOMRS-890:added clear error message for :release ID already exists

@k-joseph @dkayiwa do you have any thoughts on the cypress error for this!!

nk183

comment created time in 2 days

pull request commentopenmrs/openmrs-ocl-client

OCLOMRS-890:added clear error message for :release ID already exists

please help it working fine on my pc and don't know why it is failing checks

nk183

comment created time in 2 days

create barnchopenmrs/openmrs-module-htmlformentryui

branch : HTML-768

created branch time in 2 days

Pull request review commentopenmrs/openmrs-module-calculation

RA-1865: Patch bugs discovered by NCSU team

 public String purgeCalculationRegistration(@ModelAttribute(value = "calculationR 	
 	private void updateSessionMessage(WebRequest request, String code, Object... args) {
 		String msg = Context.getMessageSourceService().getMessage(code, args, Context.getLocale());
-		request.setAttribute(WebConstants.OPENMRS_MSG_ATTR, msg, WebRequest.SCOPE_SESSION);
+		request.setAttribute(WebConstants.OPENMRS_MSG_ATTR, Encode.forHtml(msg), WebRequest.SCOPE_SESSION);

@isears @dkayiwa I edited the message properties file to include a new message which does not depend on the name of the calculation. Please let me know if this works.

Thank you for helping me out with this issue!

anupamdevulapalli

comment created time in 2 days

Pull request review commentopenmrs/openmrs-module-coreapps

RA-1714:Primary Diagnosis not being showed in the Encounter details

+package org.openmrs.module.coreapps.diagnosisCompatibility;++import org.junit.Assert;+import org.junit.Test;+import org.openmrs.Encounter;+import org.openmrs.api.EncounterService;+import org.springframework.beans.factory.annotation.Autowired;+import org.springframework.beans.factory.annotation.Qualifier;+import org.springframework.stereotype.Component;+++@Component++public class DiagnosisServiceCompatibility2_2Test {+	+	@Autowired+	@Qualifier("encounterService")+	EncounterService encounterService;+	+	/**+	 * @see DiagnosisServiceCompatibility2_2#getDiagnoses(Encounter)+	 */+	+	@Test+	public void getDiagnoses_shouldGetDiagnosesOfTheProvidedEncounter() {+	Encounter encounter = encounterService.getEncounter(3);

@ibacher hi ian,so for this i have made changes in the core as seen here,https://github.com/openmrs/openmrs-core/pull/3682 at this line 26,i simply wanted to first check whether my submodule loads the openmrs api well,it looks like some thing is still missing since i get a null exception, https://pastebin.com/DxTuit8A a gentle request to help me look through my coreapps-web-2.2/pom.xml if i am missing out some thing cc @dkayiwa @mks-d

HerbertYiga

comment created time in 2 days

issue openedBahmni/bahmni-playbooks

Successfully installed bahmni, but failed to install dcm4chee.

Use docker container (centos 7.6) and bahmni install command to deploy bahmni(0.92) successfully, and can access services such as Bahmni-EMR and Bahmni-LAB through the web. But cannot access http://172.17.0.2/dcm4chee-web3, because dcm4chee has not been installed correctly. Querying Bahmni Wiki: Advanced Installation Options did not find out how to install dcm4chee through bahmni install. Any help would be appreciated.

bahmni start:
PLAY [pacs-integration-db:pacs-integration-db-slave] ***************************
skipping: no hosts matched
 [WARNING]: Could not match supplied host pattern, ignoring: pacs-integration
PLAY [pacs-integration] ********************************************************
skipping: no hosts matched
PLAY [atomfeed-console] ********************************************************
META: ran handlers
META: ran handlers
META: ran handlers
 [WARNING]: Could not match supplied host pattern, ignoring: dcm4chee-db
 [WARNING]: Could not match supplied host pattern, ignoring: dcm4chee-db-slave
PLAY [dcm4chee-db,dcm4chee-db-slave] *******************************************
skipping: no hosts matched
 [WARNING]: Could not match supplied host pattern, ignoring: dcm4chee
PLAY [dcm4chee] ****************************************************************
skipping: no hosts matched
 [WARNING]: Could not match supplied host pattern, ignoring: bahmni-event-log-
service
PLAY [bahmni-event-log-service] ************************************************
skipping: no hosts matched

created time in 2 days

more