profile
viewpoint
Steve Mattar SteveMattar Red Hat Tel Aviv, Israel https://www.linkedin.com/in/steve-mattar Full stack developer/DevOps engineer from Tel Aviv and currently working at Red Hat. Javascript, Python, Java, Angular, Node.js, Docker, Kubernetes, Golang.

SteveMattar/awesome-devops 0

A curated list of DevOps resources

SteveMattar/c 0

vscode and c/c++

SteveMattar/community-operators 0

The canonical source for Kubernetes Operators that are published on OperatorHub.io and part of the default catalog of the Operator Lifecycle Manager.

SteveMattar/event-loop 0

nodejs event-loop

SteveMattar/get.submariner.io 0

Get submariner/subctl script

SteveMattar/InstallCert 0

Java program to retrieve server certificate that can be added to local keystore

SteveMattar/katacoda-scenarios 0

Katacoda Scenarios

SteveMattar/lighthouse 0

Controller to facilitate DNS discovery between clusters

pull request commentsubmariner-io/releases

feat(bundle): auto create the PR against the upstream community-operators

Thanks again @mkolesnik sorry for taking me some time

SteveMattar

comment created time in 7 days

pull request commentsubmariner-io/submariner-operator

Determine the real "from version" for bundles

good catch @skitt 😉

skitt

comment created time in 7 days

push eventSteveMattar/releases

Steve Mattar

commit sha 9a362d1a0c717614f59f818bf98326782145e69f

feat(bundle): auto create a PR against the upstream community-operators Automate the release of the submariner-operator bundle on OperatorHub. Closes: #76 Signed-off-by: Steve Mattar <smattar@redhat.com>

view details

push time in 7 days

push eventSteveMattar/releases

Daniel Farrell

commit sha 78718c447ceef463914f89ab558fe45cd78e749e

Initiating release of 0.11.1 Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

view details

Daniel Farrell

commit sha 9fc392ec9e6c1e3a531f2fd2df12ad92676f4e58

Advancing 0.11.1 release to status: admiral Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

view details

Daniel Farrell

commit sha 8f6ddd20bbfacf589a4a7a406478dc0f2dd8f549

Advancing 0.11.1 release to status: projects Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

view details

Steve Mattar

commit sha 52c70cbcbce1589fb16ede423e87f5496d6a95c1

feat(bundle): auto create a PR against the upstream community-operators Automate the release of the submariner-operator bundle on OperatorHub. Closes: #76 Signed-off-by: Steve Mattar <smattar@redhat.com>

view details

push time in 7 days

push eventSteveMattar/releases

Steve Mattar

commit sha 93905992cfe72d671b1389e83ab459230cc3053d

feat(bundle): auto create a PR against the upstream community-operators Automate the release of the submariner-operator bundle on OperatorHub. Closes: #76 Signed-off-by: Steve Mattar <smattar@redhat.com>

view details

push time in 7 days

PullRequestReviewEvent

Pull request review commentsubmariner-io/releases

feat(bundle): auto create the PR against the upstream community-operators

 function advance_admiral() { function advance_projects() {     write_component "submariner-operator"     write_component "submariner-charts"+    if [[ -z "${semver['pre']}" ]]; then+        set_bundle+    fi

I left a TODO for your comment

SteveMattar

comment created time in 7 days

push eventSteveMattar/releases

Steve Mattar

commit sha e983fbeb03b2529a712b7e38cd617d9deec69efe

feat(bundle): auto create a PR against the upstream community-operators Automate the release of the submariner-operator bundle on OperatorHub. Closes: #76 Signed-off-by: Steve Mattar <smattar@redhat.com>

view details

push time in 7 days

Pull request review commentsubmariner-io/releases

feat(bundle): auto create the PR against the upstream community-operators

 function post_reviews_comment() {     dryrun gh pr review "${pr_url}" --comment --body "${comment}" } +function get_bundle_pr_body() {+   echo "Release Submariner v$1"+   curl -s "${BUNDLE_PR_TEMPLATE}" | sed -E "s/\[ \]/\[x\]/g; 0,/Is operator/d"+}++function release_bundle() {+    local bundle_version="${release['version']#v}"+    local bundle_from_version="${release['bundle.from_version']:-0.0.0}"+    local bundle_channel="${release['bundle.channel']:-$(echo alpha-"${bundle_version}" | cut -d'.' -f1,2)}"+    local pr_body+    pr_body=$(get_bundle_pr_body "${bundle_version}")++    (+        project=submariner-operator+        pushd projects/${project}+        dapper_in_dapper++        make packagemanifests \+            VERSION="${bundle_version}" \+            FROM_VERSION="${bundle_from_version}" \+            CHANNEL="${bundle_channel}"++        # Running dapper_in_dapper changes the Dockerfile, make sure to reset it.+        _git checkout HEAD Dockerfile.dapper+    )++    if [ ! -d "${BUNDLE_SOURCE_DIR}/${bundle_version}" ]; then+        echo "ERROR: The bundle version ${bundle_version} was not found in ${BUNDLE_SOURCE_DIR}/${bundle_version}"+        return 1+    fi++    (+        project=community-operators+        ORG="${BUNDLE_TARGET_ORG}"+        clone_and_create_branch "submariner-update" "main"+        cp -r "${BUNDLE_SOURCE_DIR}/${bundle_version}" "${BUNDLE_TARGET_DIR}"+        cp "${BUNDLE_SOURCE_DIR}/submariner.package.yaml" "${BUNDLE_TARGET_DIR}"+        pushd projects/${project}+        tree "${BUNDLE_TARGET_DIR}"

It was for debugging purposes I will remove that line

SteveMattar

comment created time in 7 days

PullRequestReviewEvent

create barnchSteveMattar/react-elastic

branch : master

created branch time in 11 days

created repositorySteveMattar/react-elastic

created time in 11 days

startedkubevirt/cluster-network-addons-operator

started time in 19 days

startedopen-cluster-management/deploy

started time in 19 days

startedsubmariner-io/submariner-charts

started time in 19 days

startedsubmariner-io/lighthouse

started time in 19 days

startedsubmariner-io/submariner-website

started time in 19 days

startedsubmariner-io/shipyard

started time in 19 days

startedsubmariner-io/submariner-operator

started time in 19 days

startedsubmariner-io/submariner-operator

started time in 19 days

startedsubmariner-io/submariner-operator

started time in 19 days

pull request commentsubmariner-io/submariner-operator

feat(bundle): support related-images

@nyechiel this is only relevant when deploying using the bundle. Nothing needs to be done by the user. The related images are pinned automatically in the CSV. This change is mostly relevant to the downstream environment.

SteveMattar

comment created time in 25 days

push eventSteveMattar/releases

Steve Mattar

commit sha 63e5965815e0dbe40aff0bebaaddd395a5ac69ee

feat(bundle): auto create a PR against the upstream community-operators Automate the release of the submariner-operator bundle on OperatorHub. Closes: #76 Signed-off-by: Steve Mattar <smattar@redhat.com>

view details

push time in a month

Pull request review commentsubmariner-io/releases

feat(bundle): auto create the PR against the upstream community-operators

 function post_reviews_comment() {     dryrun gh pr review "${pr_url}" --comment --body "${comment}" } +function get_pr_body() {+   wget "${PR_TEMPLATE}"+   sed -ir "s/\[ \]/\[x\]/g; 0,/Is operator/d" pull_request_template.md+   sed -r "1s/^/Release Submariner v$1\n/" pull_request_template.md+   rm -f pull_request_template.md+}++function release_bundle() {++    local bundle_version+    bundle_version="$(echo "${release["version"]}" | cut -d'-' -f1 | cut -c2- | cut -d'.' -f1,2,3)"+    local bundle_from_version="${release["bundle.from_version"]:-0.0.0}"+    local bundle_channel="${release["bundle.channel"]:-$(echo alpha-"${bundle_version}" | cut -d'.' -f1,2)}"+    local pr_body+    pr_body=$(get_pr_body "${bundle_version}")++    (+        project=submariner-operator+        pushd projects/${project}+        dapper_in_dapper

You mean the Dockerfile.dapper right?

SteveMattar

comment created time in a month

PullRequestReviewEvent

delete branch SteveMattar/submariner-operator

delete branch : feat/release-images

delete time in a month

push eventsubmariner-io/submariner-operator

Steve Mattar

commit sha b81b9adf02efbfcf69401962a1088d0fa41f285d

feat(bundle): support related-images Closes: #1427 Signed-off-by: Steve Mattar <smattar@redhat.com>

view details

push time in a month

PR merged submariner-io/submariner-operator

Reviewers
feat(bundle): support related-images ready-to-test

Note: the file config/manager/patches/related-images.deployment.config.yaml should have different content in the downstream environment.

Closes: #1427

Signed-off-by: Steve Mattar smattar@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+52 -0

1 comment

4 changed files

SteveMattar

pr closed time in a month

issue closedsubmariner-io/submariner-operator

Overriding images using Environment variables

<!-- Please only use this template for submitting enhancement requests -->

What would you like to be added: Today we support overriding images during build and runtime but not during the installation process. I propose adding an environment variable for each component in the deployment YAML which contains an image url, The operator will then use it to override the default image.

The priority will be in this order:

  1. image-override in Submariner CR
  2. The deployment environment variable
  3. Using the version & repo values in Submariner CR
  4. The default image

Why is this needed: When building the bundle as part of the CI. I would like to pin the image digest for all components belong to the same build. This way I can make sure the bundle does not use the latest images according to the regular floating tags but uses the images that I expect. In the end we would like to make sure what QA tests is what will be released.

closed time in a month

SteveMattar
more