profile
viewpoint
Yuri Skorokhodov SounD120 Russia, Yaroslavl

SounD120/C-Sharp-c-interview-question 0

List of top 500 C# csharp Interview Questions & Answers....Coding exercise questions are coming soon!!

SounD120/cordova-serve 0

Mirror of Apache cordova serve

SounD120/expo-cli 0

Tools for making Expo apps

SounD120/full-react-snippets 0

Code snippets for React/React Native and extra libs

SounD120/hello 0

Migration from angular to cordova app for soyjuanmedina

SounD120/ow 0

Function argument validation for humans

SounD120/rocketseat-vscode-react-native-snippets 0

Rocketseat React Native snippets for Visual Studio Code Editor

SounD120/virtual-environments 0

GitHub Actions virtual environments

SounD120/vscode 0

Visual Studio Code

push eventmicrosoft/vscode-cordova

JiglioNero

commit sha bf7c006765b11233f9164277deeaa0f49482357c

Update src/debugger/cordovaDebugSession.ts Co-authored-by: etatanova <77284023+etatanova@users.noreply.github.com>

view details

push time in 9 days

push eventmicrosoft/vscode-cordova

JiglioNero

commit sha 9d0d3150c47c6d3099bf46b34d3961f1b3a2821a

Update src/utils/android/androidEmulatorManager.ts Co-authored-by: etatanova <77284023+etatanova@users.noreply.github.com>

view details

push time in 9 days

push eventmicrosoft/vscode-cordova

JiglioNero

commit sha fbd136a5778c7c8040d2894b1bbd55dabffd7fc5

Update src/utils/android/androidEmulatorManager.ts Co-authored-by: etatanova <77284023+etatanova@users.noreply.github.com>

view details

push time in 9 days

push eventmicrosoft/vscode-cordova

JiglioNero

commit sha 77c2c4c30357cbf1f0c913b5a406a7a5421b4938

Update src/debugger/cordovaDebugSession.ts Co-authored-by: etatanova <77284023+etatanova@users.noreply.github.com>

view details

push time in 9 days

Pull request review commentmicrosoft/vscode-cordova

Use standart Cordova CLI workflow when could not find specified target

 To get the list of addresses run "ionic cordova run PLATFORM --livereload" (wher      private async resolveAndroidTarget(launchArgs: ICordovaLaunchRequestArgs): Promise<string[]> {         let workingDirectory = launchArgs.cwd;-        const targetArgs: string[] = [];+        let targetArgs: string[] = ["--verbose"];          const adbHelper = new AdbHelper(workingDirectory);         const androidEmulatorManager = new AndroidEmulatorManager(adbHelper);         const launchScenariousManager = new LaunchScenariosManager(workingDirectory);          const isDevice = launchArgs.target.toLowerCase() === TargetType.Device;         const isEmulator = launchArgs.target.toLowerCase() === TargetType.Emulator;-        targetArgs.push("--verbose");-        if (!isDevice) {-            const targetDevice = await androidEmulatorManager.startEmulator(launchArgs.target);-            if (targetDevice) {-                targetArgs.push("--emulator", `--target=${targetDevice.id}`);-                if (isEmulator && targetDevice.name) {-                    launchScenariousManager.updateLaunchScenario(launchArgs, {target: targetDevice.name});++        const useDefaultCLI = async () => {+            this.outputLogger("Continue using standard CLI workflow.");+            targetArgs = ["--verbose"];+            const debuggableDevices = await adbHelper.getOnlineDevices();+            // By default, if a target is not specified Cordova CLI uses the first online target from ‘adb devices’ list (launched emulators are placed after devices).+            // For more information see https://github.com/apache/cordova-android/blob/bb7d733cdefaa9ed36ec355a42f8224da610a26e/bin/templates/cordova/lib/run.js#L57-L68+            launchArgs.target = debuggableDevices.length ? debuggableDevices[0].id : TargetType.Emulator;+        };++        try {+            if ((await androidEmulatorManager.isEmulatorTarget(launchArgs.target))) {
            if (await androidEmulatorManager.isEmulatorTarget(launchArgs.target)) {
JiglioNero

comment created time in 9 days

Pull request review commentmicrosoft/vscode-cordova

Use standart Cordova CLI workflow when could not find specified target

 export class AndroidEmulatorManager extends VirtualDeviceManager {         if (target !== TargetType.Emulator) {             const onlineDevices = await this.adbHelper.getOnlineDevices();             for (let i = 0; i < onlineDevices.length; i++) {-                if (onlineDevices[i].id === target) {-                    return { id: onlineDevices[i].id };-                }-                if (await this.adbHelper.getAvdNameById(onlineDevices[i].id) === target) {-                    return { name: target, id: onlineDevices[i].id };+                if (onlineDevices[i].type === DeviceType.AndroidSdkEmulator) {+                    if (onlineDevices[i].id === target) {+                        return {name: await this.adbHelper.getAvdNameById(target), id: target };
                        return { name: await this.adbHelper.getAvdNameById(target), id: target };
JiglioNero

comment created time in 9 days

Pull request review commentmicrosoft/vscode-cordova

Use standart Cordova CLI workflow when could not find specified target

 export class AndroidEmulatorManager extends VirtualDeviceManager {         }         return emulatorsList;     }++    public async isEmulatorTarget(target: string): Promise<boolean> {+        if (target.toLowerCase().includes(TargetType.Emulator) || (await this.getVirtualDevicesNamesList()).includes(target)) {+            return true;+        }+        return false;
        return target.toLowerCase().includes(TargetType.Emulator) || (await this.getVirtualDevicesNamesList()).includes(target);
JiglioNero

comment created time in 9 days

Pull request review commentmicrosoft/vscode-cordova

Use standart Cordova CLI workflow when could not find specified target

 To get the list of addresses run "ionic cordova run PLATFORM --livereload" (wher      private async resolveAndroidTarget(launchArgs: ICordovaLaunchRequestArgs): Promise<string[]> {         let workingDirectory = launchArgs.cwd;-        const targetArgs: string[] = [];+        let targetArgs: string[] = ["--verbose"];          const adbHelper = new AdbHelper(workingDirectory);         const androidEmulatorManager = new AndroidEmulatorManager(adbHelper);         const launchScenariousManager = new LaunchScenariosManager(workingDirectory);          const isDevice = launchArgs.target.toLowerCase() === TargetType.Device;         const isEmulator = launchArgs.target.toLowerCase() === TargetType.Emulator;-        targetArgs.push("--verbose");-        if (!isDevice) {-            const targetDevice = await androidEmulatorManager.startEmulator(launchArgs.target);-            if (targetDevice) {-                targetArgs.push("--emulator", `--target=${targetDevice.id}`);-                if (isEmulator && targetDevice.name) {-                    launchScenariousManager.updateLaunchScenario(launchArgs, {target: targetDevice.name});++        const useDefaultCLI = async () => {+            this.outputLogger("Continue using standard CLI workflow.");+            targetArgs = ["--verbose"];+            const debuggableDevices = await adbHelper.getOnlineDevices();+            // By default, if a target is not specified Cordova CLI uses the first online target from ‘adb devices’ list (launched emulators are placed after devices).+            // For more information see https://github.com/apache/cordova-android/blob/bb7d733cdefaa9ed36ec355a42f8224da610a26e/bin/templates/cordova/lib/run.js#L57-L68
            // By default, if the target is not specified, Cordova CLI uses the first online target from ‘adb devices’ list (launched emulators are placed after devices).
            // For more information, see https://github.com/apache/cordova-android/blob/bb7d733cdefaa9ed36ec355a42f8224da610a26e/bin/templates/cordova/lib/run.js#L57-L68
JiglioNero

comment created time in 9 days

issue commentmicrosoft/vscode-cordova

'Unable to find adb'. Adb is in the path of my Mac OS Catalina

worked for me on ProductName: Mac OS X ProductVersion: 10.15.7 BuildVersion: 19H2 AND Android Studio 4.1.1 Build #AI-201.8743.12.41.6953283, built on November 5, 2020 Runtime version: 1.8.0_242-release-1644-b3-6915495 x86_64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o

MInesGomes

comment created time in 9 days

push eventmicrosoft/vscode-cordova

JiglioNero

commit sha cfb166f3a7a2e87f2bfebe63f10551733c4811b4

add comment

view details

push time in 9 days

delete branch microsoft/vscode-react-native

delete branch : fix-changelog

delete time in 9 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 786256efdcd74accf0d134a052c3339f10091b25

Fix changelog (#1487)

view details

push time in 9 days

create barnchmicrosoft/vscode-react-native

branch : fix-changelog

created branch time in 9 days

delete branch microsoft/vscode-react-native

delete branch : prepare-for-1.3.0

delete time in 9 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha a3bcb94dbaa8181be0dc2a9e42b1767209a75139

Prepare for 1.3.0 (#1484) * Update CHANGELOG and version to 1.3.0 * Update TPN Co-authored-by: etatanova <77284023+etatanova@users.noreply.github.com> Co-authored-by: etatanova <77284023+etatanova@users.noreply.github.com>

view details

push time in 9 days

issue commentmicrosoft/vscode-react-native

Failed to start the React Native packager (error code 106)

@RedMickey Today When I started the React native it works and Package started in the Visual Studio. I have no idea what make it working and what was an error earlier. Till Saturday it was not working at all (except from Terminal Command). Today it works from VS Code.

patriksharma

comment created time in 9 days

issue commentmicrosoft/vscode-react-native

Failed to start the React Native packager (error code 106)

@RedMickey

Here is the output for process.env.path command

process.env.PATH
"/usr/local/bin:\/usr/bin:/bin:/usr/sbin:/sbin:/Library/Apple/usr/bin:/usr/bin:/Users/mwp1/Library/Android/sdk/emulator:/Users/mwp1/Library/Android/sdk/tools:/Users/mwp1/Library/Android/sdk/platform-tools"
patriksharma

comment created time in 9 days

issue openedmicrosoft/vscode-react-native

An error occurred while attaching debugger to the application. Another debugger is already connected to packager. Please close it before trying to debug with VSCode. (error code 505) (error code 1410)

🐛 What is the bug? How can we reproduce it?

Vscode still thinks that debugger port is in use if it was at least on use once Vscode tried to start debugger. The error persists even after other debugger is killed (and yes I'm sure that it's killed). The only way to get Vscode debugger to work is to restart Vscode.

Please put here any steps, code or any information that can help us reproduce the error on our side so we can fix it:

  1. Have an attach configuration like this (other configurations might be encountering too, this is what I'm getting the error with):
  {
            "name": "Attach to packager",
            "cwd": "${workspaceFolder}",
            "type": "reactnative",
            "request": "attach",
            "sourceMaps": true
  }
  1. Open Vscode and React Native project. Start packager either via Vscode or externally, but do not attach to packager.
  2. Have another debugger listen on the debugger port, I had React Native Debugger listening on debugger port.
  3. Try to launch Vscode RN debugger. It will naturally fail with the error as external debugger is attached:
An error occurred while attaching debugger to the application. Another debugger is already connected to packager. Please close it before trying to debug with VSCode. (error code 505) (error code 1410)
  1. Terminate the external debugger.
  2. Try to attach to debugger.
  3. The debugger port is now free to attach but Vscode still displays the same error.

Expected behavior

Vscode should attach to debugger.

Debug output

<details> <summary>Debug Console</summary>


Attaching to the application
Starting debugger app worker.
Established a connection with the Proxy (Packager) to the React Native application
Disconnected from the Proxy (Packager) to the React Native application. Retrying reconnection soon...


</details>

<details> <summary>React Native output channel</summary>


[Info] Starting Packager

                                                          
               ######                ######               
             ###     ####        ####     ###             
            ##          ###    ###          ##            
            ##             ####             ##            
            ##             ####             ##            
            ##           ##    ##           ##            
            ##         ###      ###         ##            
             ##  ########################  ##             
          ######    ###            ###    ######          
      ###     ##    ##              ##    ##     ###      
   ###         ## ###      ####      ### ##         ###   
  ##           ####      ########      ####           ##  
 ##             ###     ##########     ###             ## 
  ##           ####      ########      ####           ##  
   ###         ## ###      ####      ### ##         ###   
      ###     ##    ##              ##    ##     ###      
          ######    ###            ###    ######          
             ##  ########################  ##             
            ##         ###      ###         ##            
            ##           ##    ##           ##            
            ##             ####             ##            
            ##             ####             ##            
            ##          ###    ###          ##            
             ###     ####        ####     ###             
               ######                ######               
                                                          
                 Welcome to React Native!
                Learn once, write anywhere


[Info] Packager started.

[Info] Packager is already running.

</details>

<details> <summary>Developer Tools console</summary>


rror: Another debugger is already connected to packager. Please close it before trying to debug with VSCode. (error code 505)
	at Function.getInternalError (/Users/Can/.vscode/extensions/msjsdiag.vscode-react-native-1.2.0/dist/rn-extension.js:1)
	at /Users/Can/.vscode/extensions/msjsdiag.vscode-react-native-1.2.0/dist/rn-extension.js:1
	at t.ExecutionsLimiter.execute (/Users/Can/.vscode/extensions/msjsdiag.vscode-react-native-1.2.0/dist/rn-extension.js:1)
	at A.<anonymous> (/Users/Can/.vscode/extensions/msjsdiag.vscode-react-native-1.2.0/dist/rn-extension.js:1)
	at A.emit (events.js:223)
	at A.emitClose (/Users/Can/.vscode/extensions/msjsdiag.vscode-react-native-1.2.0/dist/rn-extension.js:1)
	at Socket.U (/Users/Can/.vscode/extensions/msjsdiag.vscode-react-native-1.2.0/dist/rn-extension.js:1)
	at Socket.emit (events.js:223)
	at TCP.<anonymous> (net.js:664)
$onExtensionRuntimeError @ mainThreadExtensionService.ts:57
_doInvokeHandler @ rpcProtocol.ts:396
_invokeHandler @ rpcProtocol.ts:330
_receiveRequest @ rpcProtocol.ts:269
_receiveOneMessage @ rpcProtocol.ts:208
(anonymous) @ rpcProtocol.ts:90
fire @ event.ts:525
fire @ ipc.net.ts:449
_receiveMessage @ ipc.net.ts:785
(anonymous) @ ipc.net.ts:642
fire @ event.ts:525
acceptChunk @ ipc.net.ts:191
(anonymous) @ ipc.net.ts:191
t @ ipc.net.ts:925
emit @ events.js:223
addChunk @ _stream_readable.js:309
readableAddChunk @ _stream_readable.js:290
Readable.push @ _stream_readable.js:224
onStreamRead @ internal/stream_base_commons.js:181

</details>

Environment

Please tell us about your system and your project:

  • npx react-native doctor or npx expo doctor if your project is using Expo:
Common
 ✓ Node.js
 ✓ yarn
 ✓ Watchman - Used for watching changes in the filesystem when in development mode

Android
 ✓ JDK
 ✓ Android Studio - Required for building and installing your app on Android
 ✖ Android SDK - Required for building and installing your app on Android
   - Versions found: N/A
   - Version supported: 28.0.3
 ✓ ANDROID_HOME

iOS
 ✓ Xcode - Required for building and installing your app on iOS
 ✓ CocoaPods - Required for installing iOS dependencies
 ✓ ios-deploy - Required for installing your app on a physical device with the CLI

Errors:   1
Warnings: 0
  • envinfo:
  System:
    OS: macOS 11.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 30.08 GB / 64.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.9.0 - /usr/local/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 6.14.7 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
    Gradle: 5.6.1 - /usr/local/bin/gradle
    Homebrew: 2.7.1 - /usr/local/bin/brew
    Maven: 3.6.2 - /usr/local/bin/mvn
    pip2: 19.1.1 - /usr/local/bin/pip2
    pip3: 20.3.1 - /usr/local/bin/pip3
    RubyGems: 3.0.3 - /usr/bin/gem
  Utilities:
    CMake: 3.19.2 - /usr/local/bin/cmake
    Make: 3.81 - /usr/bin/make
    GCC: 14.3. - /usr/bin/gcc
    Git: 2.24.3 - /usr/bin/git
    Clang: 1200.0.32.28 - /usr/bin/clang
    FFmpeg: 4.1 - /usr/local/bin/ffmpeg
  Servers:
    Apache: 2.4.46 - /usr/sbin/apachectl
  Virtualization:
    Parallels: 16.1.1 - /usr/local/bin/prlctl
  SDKs:
    iOS SDK:
      Platforms: iOS 14.3, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
    Android SDK:
      Android NDK: 17.2.4988734
  IDEs:
    Android Studio: 4.1 AI-201.8743.12.41.6858069
    Nano: 2.0.6 - /usr/bin/nano
    Sublime Text: Build 3211
    VSCode: 1.52.1 - /usr/local/bin/code
    Vim: 8.2 - /usr/bin/vim
    Xcode: 12.3/12C33 - /usr/bin/xcodebuild
  Languages:
    Bash: 3.2.57 - /bin/bash
    Go: 1.11.4 - /usr/local/bin/go
    Java: 10.0.2 - /usr/bin/javac
    Perl: 5.28.2 - /usr/bin/perl
    PHP: 7.3.24 - /usr/bin/php
    Python: 3.9.1 - /usr/local/opt/python/libexec/bin/python
    Python3: 3.9.1 - /usr/local/bin/python3
    Ruby: 2.6.3 - /usr/bin/ruby
  Databases:
    SQLite: 3.28.0 - /Users/Can/Library/Android/sdk/platform-tools/sqlite3
  Browsers:
    Chrome: 87.0.4280.141
    Firefox: 74.0
    Safari: 14.0.2
  • React Native Tools extension version: 1.2.0

created time in 11 days

push eventmicrosoft/vscode-cordova

JiglioNero

commit sha 8504769de4af4e5c340f16979ae311284081a3ea

move logic to helper

view details

push time in 12 days

Pull request review commentmicrosoft/vscode-cordova

Use standart Cordova CLI workflow when could not find specified target

 To get the list of addresses run "ionic cordova run PLATFORM --livereload" (wher      private async resolveAndroidTarget(launchArgs: ICordovaLaunchRequestArgs): Promise<string[]> {         let workingDirectory = launchArgs.cwd;-        const targetArgs: string[] = [];+        let targetArgs: string[] = ["--verbose"];          const adbHelper = new AdbHelper(workingDirectory);         const androidEmulatorManager = new AndroidEmulatorManager(adbHelper);         const launchScenariousManager = new LaunchScenariosManager(workingDirectory);          const isDevice = launchArgs.target.toLowerCase() === TargetType.Device;         const isEmulator = launchArgs.target.toLowerCase() === TargetType.Emulator;-        targetArgs.push("--verbose");-        if (!isDevice) {-            const targetDevice = await androidEmulatorManager.startEmulator(launchArgs.target);-            if (targetDevice) {-                targetArgs.push("--emulator", `--target=${targetDevice.id}`);-                if (isEmulator && targetDevice.name) {-                    launchScenariousManager.updateLaunchScenario(launchArgs, {target: targetDevice.name});++        const useDefaultCLI = async () => {+            this.outputLogger("Continue using standard CLI workflow.");+            targetArgs = ["--verbose"];+            const debuggableDevices = await adbHelper.getOnlineDevices();+            launchArgs.target = debuggableDevices.length ? debuggableDevices[0].id : TargetType.Emulator;+        };++        try {+            if ((await androidEmulatorManager.isEmulatorTarget(launchArgs.target))) {+                const targetDevice = await androidEmulatorManager.startEmulator(launchArgs.target);+                if (targetDevice) {+                    targetArgs.push("--emulator", `--target=${targetDevice.id}`);+                    if (isEmulator) {+                        launchScenariousManager.updateLaunchScenario(launchArgs, {target: targetDevice.name});+                    }+                    launchArgs.target = targetDevice.id;+                } else {+                   this.outputLogger(`Could not find debugable target '${launchArgs.target}'.`, true);+                   useDefaultCLI();+                }+            } else {+                targetArgs.push("--device");+                if (!isDevice) {+                    if ((await adbHelper.getOnlineDevices()).find((device) => device.id === launchArgs.target)) {

I think it's better to create a special function for this check.

JiglioNero

comment created time in 12 days

push eventmicrosoft/vscode-cordova

JiglioNero

commit sha 5a4782bf1da30bf51524b7aba69b57bb16f61a8d

improve device type definition

view details

push time in 12 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 1ae839b983e59b242368956e6149588ceb92732f

Update CHANGELOG.md Co-authored-by: etatanova <77284023+etatanova@users.noreply.github.com>

view details

push time in 12 days

Pull request review commentmicrosoft/vscode-react-native

Prepare for 1.3.0

+## 1.3.0+* Enhanced creation of debugging configurations. Now debugging configurations are generated interactively. You just need to click on `React Native` button in the IntelliSense prompt in `launch.json` file and then select required parameters in selection panels [#1468](https://github.com/microsoft/vscode-react-native/pull/1468)+* Added a notification with a link to the CHANGELOG after the extension update [#1476](https://github.com/microsoft/vscode-react-native/pull/1476)+* Fixed the bug with incorrect recursive deletion of paths when activating the extension [#1481](https://github.com/microsoft/vscode-react-native/pull/1481)+* Improved extension security [#1472](https://github.com/microsoft/vscode-react-native/pull/1472)+* Enhanced contributing guide and documentation about debugging React Native for Windows and macOS applications [#1477](https://github.com/microsoft/vscode-react-native/pull/1477), [#1469](https://github.com/microsoft/vscode-react-native/pull/1469)+* Internal changes:+    * Fixed ESLint issues in the code and added Prettier support [#1463](https://github.com/microsoft/vscode-react-native/pull/1463), [#1475](https://github.com/microsoft/vscode-react-native/pull/1475)

This indent is required for correct display of internal changes. Let's leave it unchanged.

RedMickey

comment created time in 12 days

Pull request review commentmicrosoft/vscode-react-native

Prepare for 1.3.0

+## 1.3.0+* Enhanced creation of debugging configurations. Now debugging configurations are generated interactively. You just need to click on `React Native` button in the IntelliSense prompt in `launch.json` file and then select required parameters in selection panels [#1468](https://github.com/microsoft/vscode-react-native/pull/1468)+* Added a notification with a link to the CHANGELOG after the extension update [#1476](https://github.com/microsoft/vscode-react-native/pull/1476)+* Fixed the bug with incorrect recursive deletion of paths when activating the extension [#1481](https://github.com/microsoft/vscode-react-native/pull/1481)+* Improved extension security [#1472](https://github.com/microsoft/vscode-react-native/pull/1472)+* Enhanced contributing guide and documentation about debugging React Native for Windows and macOS applications [#1477](https://github.com/microsoft/vscode-react-native/pull/1477), [#1469](https://github.com/microsoft/vscode-react-native/pull/1469)+* Internal changes:+    * Fixed ESLint issues in the code and added Prettier support [#1463](https://github.com/microsoft/vscode-react-native/pull/1463), [#1475](https://github.com/microsoft/vscode-react-native/pull/1475)+ ## 1.2.0 * Added `Run React Native LogCat Monitor` and `Stop React Native LogCat Monitor` command palette commands. These commands allow to control LogCat outputs monitoring and create monitors for Android devices on demand. See [more information here](https://github.com/microsoft/vscode-react-native#configure-an-android-logcat-monitor) [#1461](https://github.com/microsoft/vscode-react-native/pull/1461)
* Added `Run React Native LogCat Monitor` and `Stop React Native LogCat Monitor` palette commands. These commands allow to control LogCat outputs monitoring and create monitors for Android devices on demand. See [more information here](https://github.com/microsoft/vscode-react-native#configure-an-android-logcat-monitor) [#1461](https://github.com/microsoft/vscode-react-native/pull/1461)
RedMickey

comment created time in 12 days

Pull request review commentmicrosoft/vscode-react-native

Prepare for 1.3.0

+## 1.3.0+* Enhanced creation of debugging configurations. Now debugging configurations are generated interactively. You just need to click on `React Native` button in the IntelliSense prompt in `launch.json` file and then select required parameters in selection panels [#1468](https://github.com/microsoft/vscode-react-native/pull/1468)+* Added a notification with a link to the CHANGELOG after the extension update [#1476](https://github.com/microsoft/vscode-react-native/pull/1476)+* Fixed the bug with incorrect recursive deletion of paths when activating the extension [#1481](https://github.com/microsoft/vscode-react-native/pull/1481)+* Improved extension security [#1472](https://github.com/microsoft/vscode-react-native/pull/1472)+* Enhanced contributing guide and documentation about debugging React Native for Windows and macOS applications [#1477](https://github.com/microsoft/vscode-react-native/pull/1477), [#1469](https://github.com/microsoft/vscode-react-native/pull/1469)+* Internal changes:+    * Fixed ESLint issues in the code and added Prettier support [#1463](https://github.com/microsoft/vscode-react-native/pull/1463), [#1475](https://github.com/microsoft/vscode-react-native/pull/1475)
* Fixed ESLint issues in the code and added Prettier support [#1463](https://github.com/microsoft/vscode-react-native/pull/1463), [#1475](https://github.com/microsoft/vscode-react-native/pull/1475)
RedMickey

comment created time in 12 days

push eventmicrosoft/vscode-cordova

JiglioNero

commit sha 7346367dccb7df65d1bbac8408e0d6d1fdf4ab5b

Update src/debugger/cordovaDebugSession.ts Co-authored-by: etatanova <77284023+etatanova@users.noreply.github.com>

view details

push time in 12 days

Pull request review commentmicrosoft/vscode-cordova

Use standart Cordova CLI workflow when could not find specified target

 To get the list of addresses run "ionic cordova run PLATFORM --livereload" (wher      private async resolveAndroidTarget(launchArgs: ICordovaLaunchRequestArgs): Promise<string[]> {         let workingDirectory = launchArgs.cwd;-        const targetArgs: string[] = [];+        let targetArgs: string[] = [];          const adbHelper = new AdbHelper(workingDirectory);         const androidEmulatorManager = new AndroidEmulatorManager(adbHelper);         const launchScenariousManager = new LaunchScenariosManager(workingDirectory);          const isDevice = launchArgs.target.toLowerCase() === TargetType.Device;         const isEmulator = launchArgs.target.toLowerCase() === TargetType.Emulator;++        const useDefaultCLI = async () => {+            this.outputLogger("Continue using standard CLI workflow.");+            targetArgs = ["--verbose"];+            const debuggableDevices = await adbHelper.getOnlineDevices();+            if (debuggableDevices.length) {+                launchArgs.target = debuggableDevices[0].id;+            } else {+                launchArgs.target = TargetType.Emulator;+            }

May we use the ternary operator here?

            launchArgs.target = debuggableDevices.length ? debuggableDevices[0].id : TargetType.Emulator; 
JiglioNero

comment created time in 12 days

more