profile
viewpoint
Sjors Provoost Sjors Utrecht, The Netherlands

BitMEXResearch/forkmonitor 28

Fork Monitor

blockchain/libwally-swift 14

Swift wrapper for LibWally, a collection of useful primitives for cryptocurrency wallets

Sjors/dao-challenge 7

https://dao-challenge.herokuapp.com/

Sjors/crush_curve 5

Yet another Corona dashboard

Sjors/armbian-bitcoin-core 4

Generates an Armbian image for minicomputers with Bitcoin Core including GUI

Sjors/docker-bitcoin-core 3

There's no such thing as too many bitcoin docker solutions.

Sjors/bitcoin 2

Bitcoin Core integration/staging tree

Sjors/bitcoin-passbook 2

Monitor your bitcoin address balance in Passbook on your iPhone

Sjors/ducks-on-rails 2

Visualisation of duck migration data.

pull request commentbitcoin-core/gui

Enlarge Network Traffic Graph

I only noticed the misspellings because the linter caught them...

RandyMcMillan

comment created time in 7 hours

pull request commentbitcoin-core/gui

Enlarge Network Traffic Graph

@luke-jr

I realized that I can trigger my own rebuilds after I posted. Really useful.

Also: I noticed codespell ignores the /forms folder and test/lint/lint-qt.sh is quite limited. There seems to be room for improvement in qt linting. Worthwhile work?

RandyMcMillan

comment created time in 7 hours

Pull request review commentbitcoin-core/gui

Enlarge Network Traffic Graph

              <verstretch>0</verstretch>             </sizepolicy>            </property>+           <property name="accessibleName">+            <string>Traffic Graph</string>+           </property>           </widget>          </item>          <item>           <layout class="QHBoxLayout" name="horizontalLayout_2">+           <item>+            <widget class="QGroupBox" name="groupBox_2">+             <property name="toolTip">+              <string extracomment="Totals"/>+             </property>+             <property name="accessibleName">+              <string>Totals</string>+             </property>+             <property name="title">+              <string/>+             </property>+             <property name="flat">+              <bool>true</bool>+             </property>+             <layout class="QVBoxLayout" name="verticalLayout_9">+              <item>+               <layout class="QHBoxLayout" name="horizontalLayout_6">+                <item>+                 <widget class="Line" name="line_3">+                  <property name="sizePolicy">+                   <sizepolicy hsizetype="Fixed" vsizetype="Fixed">+                    <horstretch>0</horstretch>+                    <verstretch>0</verstretch>+                   </sizepolicy>+                  </property>+                  <property name="minimumSize">+                   <size>+                    <width>10</width>+                    <height>0</height>+                   </size>+                  </property>+                  <property name="palette">+                   <palette>+                    <active>+                     <colorrole role="Light">+                      <brush brushstyle="SolidPattern">+                       <color alpha="255">+                        <red>0</red>+                        <green>255</green>+                        <blue>0</blue>+                       </color>+                      </brush>+                     </colorrole>+                    </active>+                    <inactive>+                     <colorrole role="Light">+                      <brush brushstyle="SolidPattern">+                       <color alpha="255">+                        <red>0</red>+                        <green>255</green>+                        <blue>0</blue>+                       </color>+                      </brush>+                     </colorrole>+                    </inactive>+                    <disabled>+                     <colorrole role="Light">+                      <brush brushstyle="SolidPattern">+                       <color alpha="255">+                        <red>0</red>+                        <green>255</green>+                        <blue>0</blue>+                       </color>+                      </brush>+                     </colorrole>+                    </disabled>+                   </palette>+                  </property>+                  <property name="orientation">+                   <enum>Qt::Horizontal</enum>+                  </property>+                 </widget>+                </item>+                <item>+                 <widget class="QLabel" name="label_24">+                  <property name="accessibleName">+                   <string>Recieved</string>

Thank you - I value your input.

RandyMcMillan

comment created time in 8 hours

Pull request review commentbitcoin-core/gui

qt: amend .gitignore

 background.tiff*  # Qt Creator Makefile.am.user+build-bitcoin-qt*

Folders with this prefix are created by Qt creator.

RandyMcMillan

comment created time in 19 hours

push eventbitcoin-core/gui

Hennadii Stepanov

commit sha 667b6a29df9a328cbb57bf27de63bbdf8d36e2ae

ci: Adjust Cirrus CI task names (follow up) "no depends" implies "only system libs".

view details

MarcoFalke

commit sha f35e4d906fee907f28ac5d8f32d4948e6b7b14c3

Merge #20572: ci: Adjust Cirrus CI task names (follow up) 667b6a29df9a328cbb57bf27de63bbdf8d36e2ae ci: Adjust Cirrus CI task names (follow up) (Hennadii Stepanov) Pull request description: "no depends" implies "only system libs". #20545 follow up . ACKs for top commit: practicalswift: ACK 667b6a29df9a328cbb57bf27de63bbdf8d36e2ae Tree-SHA512: b3bf5dc931b7aeed30932e8d6c5f5b0040e4be5a5676ed23b41675ebad2f8a016b1abb27584b68970ee00bc5b2af7122ca9566f373db5f3a2e38fcf7eee6522a

view details

push time in 19 hours

pull request commentbitcoin-core/gui

Add icon policy documentation

This may be helpful in getting this PR to pass.

https://github.com/bitcoin-core/gui/pull/139#issuecomment-739078392

Bosch-0

comment created time in a day

pull request commentbitcoin-core/gui

doc: Improve gui/src/qt README.md

The parent commits never passed CI

The current parent commits

https://github.com/bitcoin-core/gui/commit/ca759bc743c9b3b240289c467349cefc5f4444af https://github.com/bitcoin-core/gui/commit/62c93c34c1d9b83cd168b6b1e30d10e01db53e38 https://github.com/bitcoin-core/gui/commit/b40d4d494e1e87fecdba05463430749971c1b023

I suggest rebasing it to

https://github.com/bitcoin-core/gui/commit/a0489f3472f3799dc1ece32a59556fd239c4c14b

As you can see - it passed CIRRUS

https://cirrus-ci.com/build/4908623950249984

and travis-ci

https://travis-ci.org/github/bitcoin-core/gui/builds/747420647

jarolrod

comment created time in a day

pull request commentbitcoin-core/gui

about-view: clean up - Bitcoin branding

Updated default presentations:

Screen Shot 2020-12-04 at 3 19 07 PM

Screen Shot 2020-12-04 at 3 18 56 PM

RandyMcMillan

comment created time in a day

Pull request review commentbitcoin-core/gui

about-view: clean up - Bitcoin branding

    <rect>     <x>0</x>     <y>0</y>-    <width>780</width>-    <height>400</height>+    <width>602</width>

The view's dimensions are now dynamic and resize based on help/about context.

RandyMcMillan

comment created time in a day

Pull request review commentbitcoin-core/gui

about-view: clean up - Bitcoin branding

         <file alias="hd_disabled">res/icons/hd_disabled.png</file>         <file alias="network_disabled">res/icons/network_disabled.png</file>         <file alias="proxy">res/icons/proxy.png</file>+        <file alias="bitcoin_core">res/icons/bitcoin_core.png</file>

Reuse of bitcoin.png is a better approach. Thanks for the feed back!

RandyMcMillan

comment created time in a day

Pull request review commentbitcoin-core/gui

about-view: clean up - Bitcoin branding

 void SetupServerArgs(NodeContext& node)     argsman.AddHiddenArgs(hidden_args); } +std::string VersionInfo()

REF: https://github.com/bitcoin-core/gui/pull/140/commits/e0ff8e263dc96199385e31e481e64ad3a242fcd9#r536344384

REF: https://github.com/bitcoin-core/gui/pull/140/commits/e0ff8e263dc96199385e31e481e64ad3a242fcd9#r536346038

RandyMcMillan

comment created time in a day

Pull request review commentbitcoin-core/gui

about-view: clean up - Bitcoin branding

 static std::string FormatVersion(int nVersion)     return strprintf("%d.%d.%d", nVersion / 10000, (nVersion / 100) % 100, nVersion % 100); } +std::string FormatVersion()

Returns a terse string for reusability. REF: https://github.com/bitcoin-core/gui/pull/140/commits/e0ff8e263dc96199385e31e481e64ad3a242fcd9#r536344384

RandyMcMillan

comment created time in a day

Pull request review commentbitcoin-core/gui

about-view: clean up - Bitcoin branding

 static bool AppInit(int argc, char* argv[])      // Process help and version before taking care about datadir     if (HelpRequested(args) || args.IsArgSet("-version")) {-        std::string strUsage = PACKAGE_NAME " version " + FormatFullVersion() + "\n";+        std::string strUsage = PACKAGE_NAME " version " + FormatFullVersion() + "\n";//from init.cpp          if (args.IsArgSet("-version")) {-            strUsage += FormatParagraph(LicenseInfo()) + "\n";+            strUsage += FormatParagraph(LicenseInfo()) + "\n" + CopyrightInfo() + "\n";//from init.cpp

bitcoind.cpp uses the same strings that help and about use. LicenseInfo() and CopyrightInfo() are now refactored for reusability.

RandyMcMillan

comment created time in a day

Pull request review commentbitcoin-core/gui

about-view: clean up - Bitcoin branding

 HelpMessageDialog::HelpMessageDialog(QWidget *parent, bool about) :     ui(new Ui::HelpMessageDialog) {     ui->setupUi(this);-+    this->resize(500,0);//force view height to stretch+    ui->aboutMessage->resize(0,0);//force label to stretch     QString version = QString{PACKAGE_NAME} + " " + tr("version") + " " + QString::fromStdString(FormatFullVersion()); -    if (about)-    {-        setWindowTitle(tr("About %1").arg(PACKAGE_NAME));-         std::string licenseInfo = LicenseInfo();-        /// HTML-format the license message from the core+        std::string copyrightInfo = CopyrightInfo();+        // HTML-format aboutMessage elements+        QString versionInfoHTML = QString::fromStdString(FormatVersion());+        QString copyrightInfoHTML = QString::fromStdString(CopyrightInfo());+        QString aboutMessageInfoHTML = QString::fromStdString(AboutMessageInfo());         QString licenseInfoHTML = QString::fromStdString(LicenseInfo());         // Make URLs clickable         QRegExp uri("<(.*)>", Qt::CaseSensitive, QRegExp::RegExp2);         uri.setMinimal(true); // use non-greedy matching+        versionInfoHTML.replace(uri, "<a href=\"\\1\">\\1</a>");+        //copyrightInfoHTML.replace(uri, "<a href=\"\\1\">\\1</a>");+        aboutMessageInfoHTML.replace(uri, "<a href=\"\\1\">\\1</a>");         licenseInfoHTML.replace(uri, "<a href=\"\\1\">\\1</a>");         // Replace newlines with HTML breaks+        copyrightInfoHTML.replace("\n", "<br>");+        aboutMessageInfoHTML.replace("\n", "<br>");         licenseInfoHTML.replace("\n", "<br>"); +        ui->copyrightInfo->setTextFormat(Qt::RichText);         ui->aboutMessage->setTextFormat(Qt::RichText);-        ui->scrollArea->setVerticalScrollBarPolicy(Qt::ScrollBarAsNeeded);-        text = version + "\n" + QString::fromStdString(FormatParagraph(licenseInfo));-        ui->aboutMessage->setText(version + "<br><br>" + licenseInfoHTML);+        ui->licenseInfo->setTextFormat(Qt::RichText);+        ui->versionInfo->setTextFormat(Qt::RichText);         ui->aboutMessage->setWordWrap(true);+        ui->scrollArea->setVerticalScrollBarPolicy(Qt::ScrollBarAsNeeded);+        ui->copyrightInfo->setText(copyrightInfoHTML); //about bottom left corner+        ui->aboutMessage->setText(aboutMessageInfoHTML); //aboutMessage bodyy+        ui->licenseInfo->setText(licenseInfoHTML);+        ui->versionInfo->setText(versionInfoHTML);+++    if (about)+    {+        setWindowTitle(tr("About %1").arg(PACKAGE_NAME));

Over riding PACKAGE_NAME is outside the scope of this PR.

This PR is implementing changes based on broader community discussions and sentiment.

REF: https://github.com/bitcoin-core/gui/issues/89#issuecomment-705384143

REF: https://github.com/bitcoin-core/gui/pull/140#issuecomment-737773556

RandyMcMillan

comment created time in a day

Pull request review commentbitcoin-core/gui

about-view: clean up - Bitcoin branding

 HelpMessageDialog::HelpMessageDialog(QWidget *parent, bool about) :     ui(new Ui::HelpMessageDialog) {     ui->setupUi(this);-+    this->resize(500,0);//force view height to stretch+    ui->aboutMessage->resize(0,0);//force label to stretch

https://github.com/bitcoin-core/gui/pull/140/commits/e0ff8e263dc96199385e31e481e64ad3a242fcd9#r536333863

RandyMcMillan

comment created time in a day

Pull request review commentbitcoin-core/gui

about-view: clean up - Bitcoin branding

 HelpMessageDialog::HelpMessageDialog(QWidget *parent, bool about) :     ui(new Ui::HelpMessageDialog) {     ui->setupUi(this);-+    this->resize(500,0);//force view height to stretch

The Ui::HelpMessageDialog is shared with the about view. These changes force the view to stretch to an appropriate height - this eliminates excessive height dimensions - the user resizes based upon personal preference.

RandyMcMillan

comment created time in a day

Pull request review commentbitcoin-core/gui

about-view: clean up - Bitcoin branding

 void BitcoinGUI::showDebugWindowActivateConsole() void BitcoinGUI::showHelpMessageClicked() {     helpMessageDialog->show();+    helpMessageDialog->raise();//bring to top if obscured

If the helpMessageDialog has already been presented - this change brings it to the front if the user re-clicks on the help menu item - otherwise it remains obscured by any other windows.

RandyMcMillan

comment created time in a day

pull request commentbitcoin-core/gui

UI external signer support (e.g. hardware wallet)

checking whether to build with external signer support... configure: error: "External signer support requested but requires Boost.Pocess"

Boost.Process?

Sjors

comment created time in a day

pull request commentbitcoin-core/gui

Add icon policy documentation

I like the idea of putting it in the /res folder. Maybe even just name it README.md if it lands in the /res folder? This may be a good place to add logo/branding specification notes in the future.

Bosch-0

comment created time in a day

push eventbitcoin-core/gui

Andrew Chow

commit sha 773c42b265fb2212b5cb8785b7226a206d063543

tests: Test that a fully signed tx given to signrawtx is unchanged Tests that a fully signed transaction given to signrawtransactionwithwallet is both unchanged and marked as complete. This tests for a regression in 0.20 where the transaction would not be marked as complete.

view details

MarcoFalke

commit sha 751ffaabad82f7904fd1d9742a0b323a0ab7bfee

Merge #20562: tests: Test that a fully signed tx given to signrawtx is unchanged 773c42b265fb2212b5cb8785b7226a206d063543 tests: Test that a fully signed tx given to signrawtx is unchanged (Andrew Chow) Pull request description: Tests that a fully signed transaction given to `signrawtransactionwithwallet` is both unchanged and marked as complete. This tests for a regression in 0.20 where the transaction would not be marked as complete. ACKs for top commit: MarcoFalke: ACK 773c42b265 🕶 Tree-SHA512: b32afd5f2667c817ee59c37af78cb37352e7c22d0271833d446fd61f11b354974694128a3b408f214db459caef3fd67ecdbf1664280ac2de602215f05aa4a6de

view details

push time in a day

push eventbitcoin-core/gui

MarcoFalke

commit sha fac7ab1d5b58fb9cfd80d5cf74ac4d2e5cb8eff2

refactor: Use C++17 std::array where possible

view details

MarcoFalke

commit sha c1604483d34f745fe6dc77a5f1be4fcfad7408a7

Merge #20566: refactor: Use C++17 std::array where possible fac7ab1d5b58fb9cfd80d5cf74ac4d2e5cb8eff2 refactor: Use C++17 std::array where possible (MarcoFalke) Pull request description: Using the C++11 std::array with explicit template parameters is problematic because overshooting the size will fill the memory with default constructed types. For example, ```cpp #include <array> #include <iostream> int main() { std::array<int, 3> a{1, 2}; for (const auto& i : a) { std::cout << i << std::endl; // prints "1 2 0" } } ``` ACKs for top commit: jonasschnelli: Code Review ACK fac7ab1d5b58fb9cfd80d5cf74ac4d2e5cb8eff2 practicalswift: cr ACK fac7ab1d5b58fb9cfd80d5cf74ac4d2e5cb8eff2 vasild: ACK fac7ab1d promag: Code review ACK fac7ab1d5b58fb9cfd80d5cf74ac4d2e5cb8eff2. Tree-SHA512: ef7e872340226e0d6160e6fd66c6ca78b2ef9c245fa0ab27fe4777aac9fba8d5aaa154da3d27b65dec39a6a63d07f1063c3a8ffb667a98ab137756a1a0af2656

view details

push time in a day

push eventbitcoin-core/gui

Block Mechanic

commit sha e373959d6fe90cc4507024a6b31a706bfc5bd0c8

Android : Ensure pic build for bdb

view details

fanquake

commit sha 9601c0d7aab771d3bfbab1cf7b988ee4ccf5132c

Merge #20565: Android : Ensure pic build for bdb e373959d6fe90cc4507024a6b31a706bfc5bd0c8 Android : Ensure pic build for bdb (Block Mechanic) Pull request description: This pr ensures android builds for the BDB dependency have the pic flag enabled. Android builds were failing to link with reloc errors. ACKs for top commit: laanwj: Code review ACK e373959d6fe90cc4507024a6b31a706bfc5bd0c8 jonasschnelli: utACK e373959d6fe90cc4507024a6b31a706bfc5bd0c8 Tree-SHA512: 68319ed7cc0bd295eaa87dd53ba051daeb1456bc3ab9b48ca0c4b831a9c8da1073480478efde73689f0e403e37409a8459229264656f05ba5fef6c257a74f977

view details

push time in a day

pull request commentbitcoin-core/gui

Add ability to integrate the client with desktop environment on Linux

@jarolrod

Tested ACK on Arch Linux and KDE Plasma. Works smoothly. Also tested to make sure this option doesn't show up on macOS.

Thank you for testing.

One question: the option does not show up when testing on FreeBSD, how do we add support for the BSD's?

I'm not familiar with BSD world, except of macOS :)

hebasto

comment created time in 2 days

push eventbitcoin-core/gui

practicalswift

commit sha fa861569dcfff9e72686dc5f30b1faa645b4d54e

util: Allow Assert(...) to be used in all contexts Fixes the compile error when used inside operator[]: ./chain.h:404:23: error: C++11 only allows consecutive left square brackets when introducing an attribute return (*this)[Assert(pindex)->nHeight] == pindex; ^

view details

MarcoFalke

commit sha fac5efe730ab5b8694920547203deefc5252d294

util: Add Assume() identity function

view details

MarcoFalke

commit sha faa05854f832405231c9198787a4eafe2cd4c5f0

util: Remove probably misleading TODO The TODO has been added by me, but I don't remember how to solve it. The current code works fine, so just remove the TODO.

view details

MarcoFalke

commit sha dca80ffb45fcc8e6eedb6dc481d500dedab4248b

Merge #20255: util: Add Assume() identity function faa05854f832405231c9198787a4eafe2cd4c5f0 util: Remove probably misleading TODO (MarcoFalke) fac5efe730ab5b8694920547203deefc5252d294 util: Add Assume() identity function (MarcoFalke) fa861569dcfff9e72686dc5f30b1faa645b4d54e util: Allow Assert(...) to be used in all contexts (practicalswift) Pull request description: This is needed for #20138. Please refer to the added documentation for motivation. ACKs for top commit: practicalswift: cr ACK faa05854f832405231c9198787a4eafe2cd4c5f0 jnewbery: utACK faa05854f832405231c9198787a4eafe2cd4c5f0 hebasto: ACK faa05854f832405231c9198787a4eafe2cd4c5f0, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 72165fbd898b92ab9a79b070993fa1faa86c2e3545b6645e72c652bda295d5107bc298d0482bf3aaf0926fc0c3e6418a445c0e073b08568c44231f547f76a688

view details

push time in 2 days

Pull request review commentbitcoin-core/gui

Add icon policy documentation

+# Icon policy+This document provides guidelines for contributing icons to Bitcoin Core.++++## Preparing Icons+Both an icon source file, in Scalable Vector Graphics (SVG) format, and an optimised production file, in Portable Network Graphics (PNG) format, are required for +each icon.++SVGs are used as source files due to being able to scale to any size whilst retaining image quality, but are not used in production due to limited support by +applications. If different sized production (PNG) icons are required they can be generated from the associated scaled SVG source file in a vector based tool like +Inkspace, Adobe illustrator, Figma, Sketch or Adobe XD.++PNGs are used in production due to their wide support in applications, support of transparent backgrounds and better image quality than competing file types +such as JPEG.+++### Icon Grid+Bitcoin Core uses an 8-point grid system for its icons which utilises size increments of 8px to visually orientate elements within a grid. Majority of screen sizes are divisible by 8 which makes fitting elements easier using an 8-point grid system. This makes things more efficient for designers and maintains consistency across applications. +++### Icon Style+Icon style should follow a few basic principles to maintain consistency and clarity:++- Icons should be minimal with little to no fine details. This is to make sure icons look good at any scale.  +- Icons size should be 32x32px. Different sized icons sizes may be necessary in some circumstances. If 32x32px is too small for the required icon placement, then the icon should be scaled up or down whilst sticking to the 8-point grid system.+- Shapes should be consistent and avoid organic elements that do not scale well.+- Colors should be consistent with other icons used in Bitcoin Core. +- Icons should should follow an 8-point grid system (see above). +++### Optimizing Production Files (PNG): +Production (PNG) files are to be optmized before being added to Bitcoin Core. Optimizing PNG files removes various color profiles, ancillary (alla) and text chunks resulting in a reduction in size of the image file losslessly (without a lowered image quality). Any `zopflipng` / `pngcrush` based PNG optimizers can be used, below are some examples:++- Open source tool [ImageOptim](https://imageoptim.com/api).+- Open source tool [Trimage](https://trimage.org/).+- (Advanced) Run them through Bitcoin Cores [optimize-png.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimise-pngs.py) script.++++## Contributing+Icons should only be added to the Bitcoin Core repo via a pull request (PR) in two situations:++- An icon used in production is being replaced with a new icon.+- A feature is being added to the Bitcoin Core GUI that requires the addition of a new icon.++If a new icon is designed for an upcoming or active PR, the designer of the icon should [open an issue](https://github.com/bitcoin-core/gui/issues/new/choose) to get feedback on the design and to make sure it is consistent with Bitcoin Core's iconography.++If a new feature is being added to the Bitcoin Core GUI that requires a new icon the developer should [open an issue](https://github.com/bitcoin-core/gui/issues/new/choose) requesting an icon to be designed. ++Icons (both SVG and PNG) should not be added to the Bitcoin Core repo if they are not yet used in production.++When opening a PR that adds an icon source (SVG) files should be added to `src/qt/res/src` at 32x32px and optimized production (PNG) files should be added to `src/qt/res/icons` at 32x32px. 

Than the SVG should be used to create a larger production (PNG) file. I'll specify something about this just being the default size - different sizes will have to be tested by those contributing icons to see what size works best.

Bosch-0

comment created time in 2 days

push eventbitcoin-core/gui

Adam Jonas

commit sha 86e6add5ca7d425faa314103df6617044a910ab3

doc: rename CODEOWNERS to REVIEWERS This reverts #18949 since CODEOWNERS require write permission. Instead the REVIEWERS file uses DrahtBot to tag reviewers in PR comments.

view details

Wladimir J. van der Laan

commit sha ca759bc743c9b3b240289c467349cefc5f4444af

Merge #20200: doc: rename CODEOWNERS to REVIEWERS 86e6add5ca7d425faa314103df6617044a910ab3 doc: rename CODEOWNERS to REVIEWERS (Adam Jonas) Pull request description: This PR renames the CODEOWNERS file to REVIEWERS and works with DrahtBot to leave a comment requesting a review. Testing of the functionality was done on https://github.com/adamjonas/bitcoin-codeowners-sandbox/pulls. ~EDIT: [after further testing of a fake organization](https://github.com/jonasorg/bitcoin-codeowners-sandbox-org/pulls), it appears that in order to be automatically tagged, the reviewer requires write level permissions. This is undocumented and will obviously close the circle of who can be tagged and so this PR reverts the addition of the file in #18949.~ ~This removes a line not being parsed in the CODEOWNERS file introduced in #18949. While the pattern [checked out](https://github.com/bitcoin/bitcoin/pull/18949#issuecomment-648859076) using `git ls-files`, it is preventing the CODEOWNERS file from automatically tagging reviewers. For future modifications to this file, note that [any line failing to parse causes the entire file to stop identifying codeowners](http://www.benjaminoakes.com/git/2018/08/10/Testing-changes-to-GitHub-CODEOWNERS/#:~:text=warning).~ ~I experimented in a [sandbox repo](https://github.com/adamjonas/bitcoin-codeowners-sandbox/pulls) to discover the offending line and this change appears to fix the problem.~ ACKs for top commit: laanwj: Doesn't look like github is going to fix this any time soon and besides REVIEWERS is a better name so ACK 86e6add5ca7d425faa314103df6617044a910ab3 Tree-SHA512: b3425eca4be62f829f0edcfa08232df310680835c2f60e9fa36956a6b59a2b0cd0ab580c572c87affccd843fbd849f4f99e4b3d9d7b6070ab117953f04e17f5a

view details

push time in 2 days

Pull request review commentbitcoin-core/gui

Add icon policy documentation

+# Icon policy+This document provides guidelines for contributing icons to Bitcoin Core.++++## Preparing Icons+Both an icon source file, in Scalable Vector Graphics (SVG) format, and an optimised production file, in Portable Network Graphics (PNG) format, are required for +each icon.++SVGs are used as source files due to being able to scale to any size whilst retaining image quality, but are not used in production due to limited support by +applications. If different sized production (PNG) icons are required they can be generated from the associated scaled SVG source file in a vector based tool like +Inkspace, Adobe illustrator, Figma, Sketch or Adobe XD.++PNGs are used in production due to their wide support in applications, support of transparent backgrounds and better image quality than competing file types +such as JPEG.+++### Icon Grid+Bitcoin Core uses an 8-point grid system for its icons which utilises size increments of 8px to visually orientate elements within a grid. Majority of screen sizes are divisible by 8 which makes fitting elements easier using an 8-point grid system. This makes things more efficient for designers and maintains consistency across applications. +++### Icon Style+Icon style should follow a few basic principles to maintain consistency and clarity:++- Icons should be minimal with little to no fine details. This is to make sure icons look good at any scale.  +- Icons size should be 32x32px. Different sized icons sizes may be necessary in some circumstances. If 32x32px is too small for the required icon placement, then the icon should be scaled up or down whilst sticking to the 8-point grid system.+- Shapes should be consistent and avoid organic elements that do not scale well.+- Colors should be consistent with other icons used in Bitcoin Core. +- Icons should should follow an 8-point grid system (see above). 

Good point, could probably remove this

Bosch-0

comment created time in 2 days

Pull request review commentbitcoin-core/gui

Add icon policy documentation

+# Icon policy+This document provides guidelines for contributing icons to Bitcoin Core.++++## Preparing Icons+Both an icon source file, in Scalable Vector Graphics (SVG) format, and an optimised production file, in Portable Network Graphics (PNG) format, are required for 

My mistake, I write in British English - will make this change to be more consistent with other documentation.

Bosch-0

comment created time in 2 days

push eventbitcoin-core/gui

Hennadii Stepanov

commit sha d3ef947524a07f8d7fbad5b95781ab6cacb1cb49

build: Check that Homebrew's berkeley-db4 package is actually installed

view details

Jonas Schnelli

commit sha 257cf05f9b841ba30202f23a94bcdb1743feded2

Merge #20563: build: Check that Homebrew's berkeley-db4 package is actually installed d3ef947524a07f8d7fbad5b95781ab6cacb1cb49 build: Check that Homebrew's berkeley-db4 package is actually installed (Hennadii Stepanov) Pull request description: On master (a0489f3472f3799dc1ece32a59556fd239c4c14b) the `configure` script is not able to determine that Homebrew's `berkeley-db4` package is uninstalled. This causes a compile error on macOS. With this PR, and with the [uninstalled](https://stackoverflow.com/questions/20802320/detect-if-homebrew-package-is-installed) `berkeley-db4` package: ``` % ./configure -q configure: error: libdb_cxx headers missing, Bitcoin Core requires this library for BDB wallet support (--without-bdb to disable BDB wallet support) ``` Related #20478. ACKs for top commit: promag: Tested ACK d3ef947524a07f8d7fbad5b95781ab6cacb1cb49. willcl-ark: tACK d3ef947524a07f8d7fbad5b95781ab6cacb1cb49 jonasschnelli: utACK d3ef947524a07f8d7fbad5b95781ab6cacb1cb49 Tree-SHA512: 8dc532e08249ec63bd357594aa458d314b6e8537fc63f5b1d509c84d0d71d5b1f70172caa1a7efe2fc8af31c829e7982a0695cf3fbe5cbc477019550269915e1

view details

push time in 2 days

pull request commentbitcoin-core/gui

Add icon policy documentation

Concept ACK. Great work. My only question would be, it this should belong to the root docs/ directory or if we should place it in src/qt/res/.

Bosch-0

comment created time in 2 days

more