profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/SimenB/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Simen Bekkhus SimenB @folio-as Oslo, Norway

facebook/jest 36867

Delightful JavaScript Testing.

siimon/prom-client 1991

Prometheus client for node.js

af/envalid 763

Environment variable validation for Node.js

istanbuljs/istanbuljs 736

monorepo containing the various nuts and bolts that facilitate istanbul.js test instrumentation

istanbuljs/babel-plugin-istanbul 529

A babel plugin that adds istanbul instrumentation to ES6 code

SimenB/add-asset-html-webpack-plugin 322

Add a JavaScript or CSS asset to the HTML generated by html-webpack-plugin

rickhanlonii/jest-silent-reporter 97

A silent reporter for Jest

istanbuljs/v8-to-istanbul 65

convert from v8 coverage format to istanbul's format

danielhusar/gulp-stylint 29

Gulp plugin for stylus stylint linter

jest-community/jest-runner-tsd 9

Jest runner to test typescript typings

PullRequestReviewEvent
PullRequestReviewEvent

issue commentfacebook/jest

[Feature]: Allow usage of tsm instead of ts-node?

PR very much welcome!

karlhorky

comment created time in 3 hours

Pull request review commentnodejs/docker-node

feat: Add back BATS for testing images

+[submodule "test/bats"]

A lockfile would assert the same thing, and probably be just as easy (and more familiar to contributers). That said, I don't strongly about this

MasonM

comment created time in 3 hours

PullRequestReviewEvent

pull request commentjest-community/jest-runner-tsd

fix: use `tsd` instead of forked `mlh-tsd`

I'm not ignoring this btw, I just haven't found the time to sit down and actually think about what I think makes the most sense ๐Ÿ˜…

mrazauskas

comment created time in 19 hours

PR closed jest-community/jest-runner-tsd

feat: pretty errors

Before: Screenshot 2021-10-21 at 17 10 29

After: Screenshot 2021-10-21 at 17 06 57

Larger code frames looked unnecessary. For instance, most of the assertions in the Jest test suite are one-liners. Also tsc reporter is printing only one line of code. Seemed to be reasonable. Can be improved later if there is a need.

+81 -29

1 comment

9 changed files

mrazauskas

pr closed time in 19 hours

pull request commentjest-community/jest-runner-tsd

feat: pretty errors

#29

mrazauskas

comment created time in 19 hours

pull request commentjest-community/jest-runner-tsd

feat: pretty errors

@mrazauskas could you send a PR adding some screenshots to the readme?

mrazauskas

comment created time in 19 hours

push eventjest-community/jest-runner-tsd

mrazauskas

commit sha 44786ef2aa34a53606b5bb0de453039299573df6

feat: pretty errors (#29)

view details

push time in 19 hours

PR merged jest-community/jest-runner-tsd

feat: pretty errors

Same as #28. Only message is shaped differently.

Before: Screenshot 2021-10-21 at 17 10 29

After: Screenshot 2021-10-22 at 09 14 05

Before (verbose sample): Screenshot 2021-10-22 at 09 21 01

After (verbose sample): Screenshot 2021-10-22 at 09 19 15

+79 -29

1 comment

9 changed files

mrazauskas

pr closed time in 19 hours

pull request commentjest-community/jest-runner-tsd

feat: pretty errors v2

Only message is shaped differently. This looks more like Jest's own reports, so let's roll with this one rather than #28. Thank you again!

I've gotten publish access, so can probably make a release and update in Jest

mrazauskas

comment created time in 19 hours

PullRequestReviewEvent

Pull request review commentnodejs/docker-node

feat: Add back BATS for testing images

+[submodule "test/bats"]

should we install via npm (https://www.npmjs.com/package/bats) rather than cloning?

MasonM

comment created time in 19 hours

PullRequestReviewEvent

pull request commentnodejs/docker-node

fix: docker-entrypoint.sh file handling, closes #1456

Thanks @MasonM!

MasonM

comment created time in 19 hours

push eventnodejs/docker-node

Mason Malone

commit sha 3101ce6b5b3a0308b58d464eef141e0043c3bf5b

fix: docker-entrypoint.sh file handling, closes #1456 The docker-entrypoint.sh script added in https://github.com/nodejs/docker-node/issues/1039 is intended to run the supplied command with "node" if it contains a "-" or doesn't correspond to a system command. In Alpine, this doesn't work if the supplied command corresponds to a regular, non-executable JS file. The root issue is a bug in ash/dash: its implementation of "command -v" incorrectly outputs the supplied command_name even for non-executable files. This is a violation of the POSIX standard and has been reported to the Debian team in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874264, though there's been no activity in several years. As a workaround, this adds an additional check to docker-entrypoint.sh for regular files that aren't marked as executable.

view details

Mason Malone

commit sha f89451f17b5f19a2908dedede39434f4f1b1baf0

Add regression test

view details

Mason Malone

commit sha dc060bd8cc937c41d08de442f686a1d98e4d62a6

Merge branch 'main' into fix-permission-denied

view details

Mason Malone

commit sha be42a31be48999703631ffc818d860d9c814cd98

Update entrypoints for Node 17

view details

Simen Bekkhus

commit sha cbbf60da587a7ca135b573f4c05810d88f04ace7

Merge pull request #1579 from MasonM/fix-permission-denied

view details

push time in 19 hours

issue closednodejs/docker-node

/usr/local/bin/docker-entrypoint.sh can not splice command and parameters correctly

<!-- Thank you for reporting an issue with the Node.js image.

Please fill in as much of the template below as you're able. -->

Environment

  • Platform: Macos & CentOS
  • Docker Version: 19.03
  • Node.js Version:
  • Image Tag: node:14-slim

Expected Behavior

docker run -it --rm \
    --name "test-slim" \
    --workdir /app \
    -v $(pwd)/:/app \
    node:14-slim \
    dist/index.js

docker run can run correctly.

-->

Current Behavior

The docker command has saome errors as below:

/usr/local/bin/docker-entrypoint.sh: 11: exec: dist/index.js: Permission denied

I debug found that [ -z "$(command -v "${1}")" ] return wrong bool value causing executable command could not patch node prefix. I executed this script in my local env without docker and it worked. My sh version is 3.2, maybe is sh version the root casue in image?

This is docker-entrypoint.sh, https://github.com/nodejs/docker-node/blob/main/docker-entrypoint.sh#L4

#!/bin/sh
set -e

if [ "${1#-}" != "${1}" ] || [ -z "$(command -v "${1}")" ]; then
  set -- node "$@"
fi

exec "$@"

Possible Solution

<!-- Suggest a fix/reason for the bug in case you have an idea. -->

Steps to Reproduce

<!-- Tell us about the steps you took to encounter this bug with the image. -->

Additional Information

<!-- Tell us anything else you think we should know. -->

closed time in 19 hours

stanxing

PR merged nodejs/docker-node

Reviewers
fix: docker-entrypoint.sh file handling, closes #1456

Description

The docker-entrypoint.sh script added in https://github.com/nodejs/docker-node/pull/1043 is intended to run the supplied command with node if it contains a - or doesn't correspond to a system command. In Alpine, this doesn't work if the supplied command corresponds to a regular, non-executable JS file.

The root issue is a bug in ash/dash: its implementation of command -v <command_name> incorrectly outputs the supplied command_name even for non-executable files. This is a violation of the POSIX standard and has been reported to the Debian team, though there's been no activity in several years.

As a workaround, this adds an additional check to docker-entrypoint.sh for regular files that aren't marked as executable.

Motivation and Context

See https://github.com/nodejs/docker-node/issues/1456

Testing Details

$ cd 14/alpine3.14
$ mkdir dist && echo 'console.log("success")' > dist/index.js                                                                                                              
$ docker run --rm -v "$PWD:/app" -w /app node:alpine3.14 dist/index.js                                                                                                
/usr/local/bin/docker-entrypoint.sh: exec: line 8: dist/index.js: Permission denied

$ docker build -t testimage . > /dev/null
$ docker run --rm -v "$PWD:/app" -w /app testimage dist/index.js                                                                                                           
success                                                           

Example Output(if appropriate)

N/A

Types of changes

<!-- What types of changes does your code introduce? Put an x in all the boxes that apply. -->

  • [ ] Documentation
  • [ ] Version change (Update, remove or add more Node.js versions)
  • [ ] Variant change (Update, remove or add more variants, or versions of variants)
  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Others (non of above)

Checklist

<!-- Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [X] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [X] I have read the CONTRIBUTING.md document.
  • [X] All new and existing tests passed. (I don't see any tests in this repository)
+167 -40

7 comments

41 changed files

MasonM

pr closed time in 19 hours

PullRequestReviewEvent

push eventnodejs/docker-node

Jeve-Stobs

commit sha eeed4a818e7cd954dbd4fff34de1afb8555b834f

Update node.js v17 from 17.0.0 to 17.0.1

view details

Simen Bekkhus

commit sha f63b83d4c471c55b152d1242090f29131595385b

Merge pull request #1587 from Jeve-Stobs/version-update

view details

push time in 2 days

PR merged nodejs/docker-node

Update node.js v17 from 17.0.0 to 17.0.1

<!-- Provide a general summary of your changes in the Title above. -->

Description

Update node.js v17 from 17.0.0 to 17.0.1 #1587

<!-- Describe your changes in detail. --> Reference:

  • https://nodejs.org/en/blog/release/v17.0.1/
  • https://github.com/nodejs/node/releases/tag/v17.0.1
  • https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V17.md#2021-10-20-version-1701-current-targos##

Motivation and Context

New version released that fixed #40526

Types of changes

<!-- What types of changes does your code introduce? Put an x in all the boxes that apply. -->

  • [ ] Documentation
  • [x] Version change (Update, remove or add more Node.js versions)
  • [ ] Variant change (Update, remove or add more variants, or versions of variants)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Others (non of above)

Checklist

<!-- Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING.md document.
  • [x] All new and existing tests passed.
+12 -12

0 comment

9 changed files

Jeve-Stobs

pr closed time in 2 days

PullRequestReviewEvent

delete branch SimenB/jest

delete branch : ci-node-17

delete time in 2 days

push eventfacebook/jest

Simen Bekkhus

commit sha f41e128c169a1296595fe1bc480ddede320a8730

chore(ci): test on node 17 (#11983)

view details

push time in 2 days

PR merged facebook/jest

chore(ci): test on node 17 cla signed

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->

<!-- Please remember to update CHANGELOG.md at the root of the project if you have not done so. -->

Summary

It's out

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? -->

Test plan

Green CI

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->

+2 -2

0 comment

2 changed files

SimenB

pr closed time in 2 days

push eventjest-community/jest-watch-typeahead

renovate[bot]

commit sha 97df7ae7d07f369dadb6d5ebdb960d74590ee483

chore(deps): update dependency eslint to v8 (#90)

view details

push time in 2 days

delete branch jest-community/jest-watch-typeahead

delete branch : renovate/eslint-8.x

delete time in 2 days

PR merged jest-community/jest-watch-typeahead

chore(deps): update dependency eslint to v8

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) ^7.8.1 -> ^8.0.0 age adoption passing confidence

Release Notes

<details> <summary>eslint/eslint</summary>

v8.0.1

Compare Source

v8.0.0

Compare Source

</details>


Configuration

๐Ÿ“… Schedule: At any time (no schedule defined).

๐Ÿšฆ Automerge: Disabled by config. Please merge this manually once you are satisfied.

โ™ป Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

๐Ÿ”• Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

+61 -111

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

PR opened facebook/jest

chore(ci): test on node 17

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->

<!-- Please remember to update CHANGELOG.md at the root of the project if you have not done so. -->

Summary

It's out

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? -->

Test plan

Green CI

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->

+2 -2

0 comment

2 changed files

pr created time in 2 days