profile
viewpoint

microsoft/vscode-react-native 2124

VSCode extension for React Native - supports debugging and editor integration

microsoft/vscode-cordova 254

A Visual Studio Code extension providing intellisense, debug, and build support for Cordova and Ionic projects.

microsoft/cordova-simulate 195

Simulates your Apache Cordova application in the browser.

RedMickey/balancing-service 0

Practical work

RedMickey/demo-ionic 0

Ionic demo app

RedMickey/devtools-protocol 0

Chrome DevTools Protocol

RedMickey/expo-cli 0

Tools for creating, running, and deploying Universal Expo and React Native apps

RedMickey/MedicalJournal 0

graduation work

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 5514e2871f80044eedbe4f8290b3e9bdbf098c97

Add scenarios to run apps without debugging (#1319) * Add scenarios to launch Android and iOS apps without debugging * Add scenario to launch Android Hermes apps without debugging * Update README

view details

RedMickey

commit sha 67ffa5b40d95e65f48c89d928a014356b94014f2

Fix logger and appWorker stop (#1325)

view details

RedMickey

commit sha 4e4705fcd5a515ac8e2ef7e064fbd4be38e03b19

[Preview] Fix expo smoke tests (#1334) * Fix Expo smoke tests (#1332) * Update expo apps template * Add App.tsx entry point * Fix file names * Change Expo version for pure expo scenarios * Fix versions * Improve Expo Pure tests Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> * update command for install java8 on mac

view details

Yuri Skorokhodov

commit sha 8152571adb22d7628c545490a38bc85153249841

Fix errors in case of spaces in adb path from local.properties (#1328) * Add tests

view details

RedMickey

commit sha 50b5bd9c81ec7c815969f632707b05a4fad8e937

Merge remote-tracking branch 'origin/preview' into implement-experiment-service

view details

push time in a day

delete branch microsoft/vscode-react-native

delete branch : fix-expo-smoke-tests

delete time in a day

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 4e4705fcd5a515ac8e2ef7e064fbd4be38e03b19

[Preview] Fix expo smoke tests (#1334) * Fix Expo smoke tests (#1332) * Update expo apps template * Add App.tsx entry point * Fix file names * Change Expo version for pure expo scenarios * Fix versions * Improve Expo Pure tests Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> * update command for install java8 on mac

view details

push time in a day

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 0abbb0d3756e0001a4d6d36503395b49a81b4496

Update test/smoke/package/src/debugAndroid.test.ts

view details

push time in 2 days

Pull request review commentmicrosoft/vscode-react-native

[Preview] Fix expo smoke tests

 export function setup(testParameters?: TestRunArguments) {             }         }); -        async function expoTest(testName: string, workspacePath: string, debugConfigName: string, triesToLaunchApp: number) {-            app = await runVSCode(workspacePath);-            console.log(`${testName}: ${workspacePath} directory is opened in VS Code`);-            await app.workbench.quickaccess.openFile("App.js");-            await app.workbench.editors.scrollTop();-            console.log(`${testName}: App.js file is opened`);-            await app.workbench.debug.setBreakpointOnLine(ExpoSetBreakpointOnLine);-            console.log(`${testName}: Breakpoint is set on line ${ExpoSetBreakpointOnLine}`);-            console.log(`${testName}: Chosen debug configuration: ${debugConfigName}`);+        async function runExpoDebugScenario(logFilePath: string, testName: string, workspacePath: string, debugConfigName: string, triesToLaunchApp: number) {             console.log(`${testName}: Starting debugging`);             // Scan logs only if launch retries provided (Expo Tunnel scenarios)             if (triesToLaunchApp <= 1) {                 await app.workbench.quickaccess.runDebugScenario(debugConfigName);             } else {-                if (process.env.REACT_NATIVE_TOOLS_LOGS_DIR) {-                    for (let retry = 1; retry <= triesToLaunchApp; retry++) {-                        let expoLaunchStatus: ExpoLaunch;-                        await app.workbench.quickaccess.runDebugScenario(debugConfigName);-                        expoLaunchStatus = await findExpoSuccessAndFailurePatterns(path.join(process.env.REACT_NATIVE_TOOLS_LOGS_DIR, SmokeTestsConstants.ReactNativeLogFileName), SmokeTestsConstants.ExpoSuccessPattern, SmokeTestsConstants.ExpoFailurePattern);-                        if (expoLaunchStatus.successful) {-                            break;-                        } else {-                            if (retry === triesToLaunchApp) {-                                assert.fail(`App start has failed after ${retry} retries`);-                            }-                            console.log(`Attempt to start #${retry} failed, retrying...`);+                for (let retry = 1; retry <= triesToLaunchApp; retry++) {+                    let expoLaunchStatus: ExpoLaunch;+                    await app.workbench.quickaccess.runDebugScenario(debugConfigName);+                    expoLaunchStatus = await findExpoSuccessAndFailurePatterns(logFilePath, SmokeTestsConstants.ExpoSuccessPattern, SmokeTestsConstants.ExpoFailurePattern);+                    if (expoLaunchStatus.successful) {+                        break;+                    } else {+                        if (retry === triesToLaunchApp) {+                            assert.fail(`App start has failed after ${retry} retries`);                         }+                        console.log(`Attempt to start #${retry} failed, retrying...`);                     }-                } else {-                    assert.fail("REACT_NATIVE_TOOLS_LOGS_DIR is not defined");                 }             }+        }++        async function expoTest(appFileName: string, testName: string, workspacePath: string, debugConfigName: string, triesToLaunchApp: number, isPureExpo: boolean = false) {+            let logFilePath = "";+            app = await runVSCode(workspacePath);+            console.log(`${testName}: ${workspacePath} directory is opened in VS Code`);+            await app.workbench.quickaccess.openFile(appFileName);+            await app.workbench.editors.scrollTop();+            console.log(`${testName}: ${appFileName} file is opened`);+            await app.workbench.debug.setBreakpointOnLine(ExpoSetBreakpointOnLine);+            console.log(`${testName}: Breakpoint is set on line ${ExpoSetBreakpointOnLine}`);+            console.log(`${testName}: Chosen debug configuration: ${debugConfigName}`);+            if (process.env.REACT_NATIVE_TOOLS_LOGS_DIR) {+                logFilePath = path.join(process.env.REACT_NATIVE_TOOLS_LOGS_DIR, SmokeTestsConstants.ReactNativeLogFileName);+            } else {+                assert.fail("REACT_NATIVE_TOOLS_LOGS_DIR is not defined");+            }+            await runExpoDebugScenario(logFilePath, testName, workspacePath, debugConfigName, triesToLaunchApp);+            // We stop and start Pure Expo debug scenario again, since we faced Metro cache processing problem on+            // Expo SDK 38. The debug scenario works fine only on the second and further launches of the packager.+            // As soon as this problem is fixed, this condition won't be needed.+            if (isPureExpo) {+                await waitForRunningPackager(logFilePath);
                await waitForRunningPackager(logFilePath);
                await sleep(2 * 1000);
RedMickey

comment created time in 2 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 42a1256a79b4429c7ae2474bf5ef636bf93075e2

Use stable ms-vscode.js-debug

view details

push time in 2 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 12ec2239a42a5001ce9d5321cad7bf590848b487

Set popCoveragePercent for RNTPreviewPrompt on 0.1

view details

push time in 2 days

delete branch microsoft/vscode-react-native

delete branch : prepare-for-0.16.1

delete time in 2 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 166908e57b5023d45edd66783ac169b7f678f84f

Prepare for 0.16.1 (#1333) * Update changelog * Update TPN Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com>

view details

push time in 2 days

issue commentfacebook/flipper

Question: show dev menu button doesn't work for iOS

@mweststrate, I opened the corresponding issue in RN CLI repository.

RedMickey

comment created time in 2 days

issue openedreact-native-community/cli

"Open developer menu" command doesn't work from the terminal for iOS and RNW

Environment

  • MacOS: System: OS: macOS 10.15.5 CPU: (6) x64 Intel(R) Core(TM) i5-8500B CPU @ 3.00GHz Memory: 1.11 GB / 32.00 GB Shell: 5.7.1 - /bin/zsh Binaries: Node: 10.19.0 - ~/.nvm/versions/node/v10.19.0/bin/node Yarn: 1.22.0 - /usr/local/bin/yarn npm: 6.13.4 - ~/.nvm/versions/node/v10.19.0/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman Managers: CocoaPods: 1.8.3 - /usr/local/bin/pod SDKs: iOS SDK: Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2 Android SDK: API Levels: 25, 27, 28, 29 Build Tools: 23.0.1, 25.0.1, 25.0.2, 27.0.3, 28.0.3, 29.0.0, 29.0.1 System Images: android-28 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom Android NDK: Not Found IDEs: Android Studio: 3.6 AI-192.7142.36.36.6241897 Xcode: 11.5/11E608c - /usr/bin/xcodebuild Languages: Java: 1.8.0_222 - /usr/bin/javac Python: 2.7.16 - /usr/bin/python npmPackages: @react-native-community/cli: Not Found react: 16.11.0 => 16.11.0 react-native: 0.62.2 => 0.62.2 npmGlobalPackages: react-native: Not Found

  • Windows System: OS: Windows 10 10.0.18362 CPU: (8) x64 Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz Memory: 7.62 GB / 15.94 GB Binaries: Node: 12.14.1 - C:\Program Files\nodejs\node.EXE Yarn: 1.17.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 6.13.4 - C:\Program Files\nodejs\npm.CMD Watchman: Not Found SDKs: Android SDK: API Levels: 27, 28, 29 Build Tools: 27.0.3, 28.0.2, 28.0.3, 29.0.2, 29.0.3 System Images: android-28 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom Android NDK: Not Found IDEs: Android Studio: Version 3.6.0.0 AI-192.7142.36.36.6241897 Languages: Java: 1.8.0_212-release - C:\Program Files\Android\Android Studio\jre\bin\javac.EXE Python: 3.7.6 - C:\Python37\python.EXE npmPackages: @react-native-community/cli: Not Found react: 16.11.0 => 16.11.0 react-native: ^0.62.0-0 => 0.62.2 npmGlobalPackages: react-native: Not Found

Description

Please see the original issue.

I created a plain React Native v0.62.2 project. I tried to open dev menu on an iOS simulator from the terminal by pressing "d", but it didn't open. At the same time the Reload command works fine.

image

I also faced the same problem on a React Native Windows application. It seems that "Open developer menu" command works incorrectly from the terminal.

created time in 2 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha a6befcb42c8604595c183a3e0a7c86d54cf894af

Update CHANGELOG.md

view details

push time in 2 days

Pull request review commentmicrosoft/vscode-react-native

Prepare for 0.16.1

+## 0.16.1
+* Improved extension security [#1310](https://github.com/microsoft/vscode-react-native/pull/1310), [#1329](https://github.com/microsoft/vscode-react-native/pull/1329)
+* Fixed the incorrect handling of spaces in `adb` path from `local.properties`
* Fixed the incorrect handling of spaces in `adb` path from `local.properties` [#1326](https://github.com/microsoft/vscode-react-native/pull/1326)
RedMickey

comment created time in 2 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha eeb48616f7467ff7cb6a3f087bf2212b70c2b879

Update CHANGELOG.md Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com>

view details

push time in 2 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 78c8e625042db3e2383026676eeff4f92e8c65ba

Update TPN

view details

push time in 2 days

issue commentfacebook/flipper

Question: show dev menu button doesn't work for iOS

@mweststrate, I tried to open dev menu from the terminal by pressing "d" and faced the same proplem - dev menu isn't opened. It seems that there could be some issues with React Native CLI or Metro packager in this case. Maybe we should open an issue about this problem in the react-native-community/cli repository?

RedMickey

comment created time in 3 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha a971c8f722265edefe2b5c7526563bf9a109a3aa

Fix Expo smoke tests (#1332) * Update expo apps template * Add App.tsx entry point * Fix file names * Change Expo version for pure expo scenarios * Fix versions * Improve Expo Pure tests Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com>

view details

RedMickey

commit sha 0fafe17e88ec590f3dec8772db09b282f91bfb14

Fix vulnerabilities (#1329)

view details

RedMickey

commit sha 406e06aeda2d0dd456c9d7a18375bfa094a45b6d

Merge branch 'master' into prepare-for-0.16.1

view details

push time in 3 days

delete branch microsoft/vscode-react-native

delete branch : fix-template-in-expo-smoke-tests

delete time in 3 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 0fafe17e88ec590f3dec8772db09b282f91bfb14

Fix vulnerabilities (#1329)

view details

push time in 3 days

delete branch microsoft/vscode-react-native

delete branch : fix-vulnerabilities

delete time in 3 days

PR merged microsoft/vscode-react-native

Fix vulnerabilities security

Fixed https://github.com/acornjs/acorn/issues/929

+28 -176

0 comment

2 changed files

RedMickey

pr closed time in 3 days

create barnchmicrosoft/vscode-react-native

branch : fix-expo-smoke-tests

created branch time in 3 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha a971c8f722265edefe2b5c7526563bf9a109a3aa

Fix Expo smoke tests (#1332) * Update expo apps template * Add App.tsx entry point * Fix file names * Change Expo version for pure expo scenarios * Fix versions * Improve Expo Pure tests Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com>

view details

RedMickey

commit sha 6538abd8d828e2b1aabeaf4e09c2a8e145daa3d7

Merge branch 'master' into fix-vulnerabilities

view details

push time in 3 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha a971c8f722265edefe2b5c7526563bf9a109a3aa

Fix Expo smoke tests (#1332) * Update expo apps template * Add App.tsx entry point * Fix file names * Change Expo version for pure expo scenarios * Fix versions * Improve Expo Pure tests Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com>

view details

push time in 3 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha ba6a22d73e168bed2a4d51460b728bb276f88774

Add comments

view details

push time in 3 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 6ec09862496313a09527c51bd46c944ded30eea5

Minor fix

view details

push time in 3 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha f024d1209372bf1f24c413d2787a552cefa7ac5b

Minor fix

view details

push time in 3 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 4bbc17609aae4b7f3faadf9b3555abbd34256b97

Improve Expo Pure tests

view details

push time in 3 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha e071fe988c02d1d2ee75ad3e5b76215e3ad0693c

Minor fix

view details

push time in 4 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 4caff3f99c949991e320d4e25a065ea8294a81ed

Improve retries

view details

push time in 4 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 83d88a17ba5f02682a9809d2443eefc8d215afce

Increase retry attempts in Android expo

view details

push time in 4 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha a2950d621352b2ab41d095b17b1340f4d73321a7

Apply suggestions from code review Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com>

view details

push time in 4 days

create barnchmicrosoft/vscode-react-native

branch : prepare-for-0.16.1

created branch time in 4 days

Pull request review commentmicrosoft/vscode-react-native

Start packager before attach to it

 export class DirectDebugSession extends DebugSessionBase {                     logger.log(`Connecting to ${attachArgs.port} port`);                     return this.appLauncher.getRnCdpProxy().stopServer()                         .then(() => this.appLauncher.getRnCdpProxy().initializeServer(new DirectCDPMessageHandler(), this.cdpProxyLogLevel))+                        .then(async () => {

I think it would be better to use such structure:

.then(() => this.appLauncher.getPackager().start())
JiglioNero

comment created time in 4 days

issue openedfacebook/flipper

Question: show dev menu button doesn't work for iOS

Hello, I tried to use the Show dev menu button on debugging an iOS app and it seems that it doesn't work correctly. On the Flipper toolbar there are 2 buttons to show dev menu and reload the application. They work correctly in case of debugging Android applications. But when I try to debug an iOS app only the Reload button works. Nothing happens when I click on the Show dev menu button. It could be that I did something wrong and should have done some additional configurations:

  • Ran an iOS app using npx react-native run-ios
  • Clicked on the Show dev menu button

As I understand there could be some problems with handling of the devMenu command on the Metro packager side, because the command is sent successfully via events socket. Could you please tell if that is an expected behavior and why this command doesn't work on iOS the same way as on Android?

created time in 4 days

delete branch microsoft/vscode-react-native

delete branch : fix-async-request-handling

delete time in 9 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 67ffa5b40d95e65f48c89d928a014356b94014f2

Fix logger and appWorker stop (#1325)

view details

push time in 9 days

push eventmicrosoft/vscode-react-native

Yuri Skorokhodov

commit sha 10e2def9ea1eb4a50af0e98a0e1eef02a489af42

Fix errors in case of spaces in adb path from local.properties (#1326) * Add tests

view details

RedMickey

commit sha 3603772462dde58fdc839d6ac066ff9d4ff7922d

Merge branch 'master' into fix-vulnerabilities

view details

push time in 9 days

PR opened microsoft/vscode-react-native

Fix vulnerabilities

Fixed https://github.com/acornjs/acorn/issues/929

+28 -176

0 comment

2 changed files

pr created time in 9 days

create barnchmicrosoft/vscode-react-native

branch : fix-vulnerabilities

created branch time in 9 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha af3ae5f47603fbe19826daa827963f62ff8e3078

Undo removal

view details

push time in 9 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha c112c01e8080861617223b8034d98f5d8bfba289

Remove unused experiment

view details

push time in 9 days

issue commentmicrosoft/vscode-react-native

[Bug] Loading Environment variables in app config is broken

@superandrew, a new version of the @expo/xdl package with the fix https://github.com/expo/expo-cli/pull/2220 has been released. But it contains the bugs https://github.com/expo/expo-cli/issues/2270, https://github.com/expo/expo-cli/issues/2257, so for now it can work incorrectly. I don't recommend to reinstall the extension to update the @expo/xdl package until these bugs have fixed. I'm closing this issue, please, feel free to open new ones if needed.

superandrew

comment created time in 9 days

issue closedmicrosoft/vscode-react-native

[Bug] Loading Environment variables in app config is broken

It seems that the debugger is unable to load environment variables in app config

Please put here any steps, code or any information that can help us reproduce the error on our side so we can fix it:

  1. Step 1 put an app configuration in (e.g. ./tenant_configs/tenant1.app.json)

  2. Step 2 using https://github.com/tusbar/babel-plugin-dotenv-import import an environment variable from an .env file

  3. Step 3 try to read values from those variables

import { ConfigContext, ExpoConfig } from "@expo/config/build";
import { mergeDeep } from "./utils/objectUtils";
import { TENANCY_NAME } from "@env";

export default ({ config }: ConfigContext): ExpoConfig => {

  let customConfig = require(`./tenant_configs/${TENANCY_NAME}.app.json`);

  return customConfig;

};
  1. Step 4 Launch the debugger

Expected behavior

The application should launch normally, as it does while running expo r

Debug output

Could not debug <details> <summary>Debug Console</summary>


OS: darwin x64
Adapter node: v12.8.1 x64
vscode-chrome-debug-core: 6.8.8
Could not debug. Failed to read config at: /Users/superandrew/code/<appname>/app.config.ts

</details>

<details> <summary>React Native output channel</summary>


ConfigError: Failed to read config at: /Users/superandrew/code/<appname>/app.config.ts


</details>

<details> <summary>Developer Tools console</summary>


console.ts:137 [Extension Host] (node:26677) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
t.log @ console.ts:137
$logExtensionHostMessage @ mainThreadConsole.ts:39
_doInvokeHandler @ rpcProtocol.ts:402
_invokeHandler @ rpcProtocol.ts:387
_receiveRequest @ rpcProtocol.ts:303
_receiveOneMessage @ rpcProtocol.ts:230
(anonymous) @ rpcProtocol.ts:105
fire @ event.ts:587
fire @ ipc.net.ts:453
_receiveMessage @ ipc.net.ts:733
(anonymous) @ ipc.net.ts:592
fire @ event.ts:587
acceptChunk @ ipc.net.ts:239
(anonymous) @ ipc.net.ts:200
t @ ipc.net.ts:28
emit @ events.js:203
addChunk @ _stream_readable.js:295
readableAddChunk @ _stream_readable.js:276
Readable.push @ _stream_readable.js:210
onStreamRead @ internal/stream_base_commons.js:166

</details>

Environment

Please tell us about your system and your project:

  • npx react-native doctor or npx expo doctor if your project is using Expo:
Didn't find any issues with your project!
  • envinfo:
 System:
    OS: macOS 10.15.4
    CPU: (16) x64 Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz
    Memory: 9.05 GB / 32.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.8.1 - ~/.nvm/versions/node/v12.8.1/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.10.2 - ~/.nvm/versions/node/v12.8.1/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.8.4 - /usr/local/bin/pod
    Gradle: 6.3 - /usr/local/bin/gradle
    Homebrew: 2.2.14 - /usr/local/bin/brew
    pip3: 20.0.2 - /usr/local/bin/pip3
    RubyGems: 3.0.3 - /usr/bin/gem
  Utilities:
    Make: 3.81 - /usr/bin/make
    GCC: 4.2.1 - /usr/bin/gcc
    Git: 2.24.3 - /usr/bin/git
    Clang: 1103.0.32.62 - /usr/bin/clang
  Servers:
    Apache: 2.4.41 - /usr/sbin/apachectl
  Virtualization:
    Docker: 19.03.8 - /usr/local/bin/docker
  SDKs:
    iOS SDK:
      Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
  IDEs:
    Android Studio: 3.6 AI-192.7142.36.36.6308749
    Nano: 2.0.6 - /usr/bin/nano
    Vim: 8.1 - /usr/bin/vim
    Xcode: 11.5/11E608c - /usr/bin/xcodebuild
  Languages:
    Bash: 3.2.57 - /bin/bash
    Java: 1.8.0_251 - /usr/bin/javac
    Perl: 5.18.4 - /usr/bin/perl
    PHP: 7.3.11 - /usr/bin/php
    Python: 2.7.16 - /usr/bin/python
    Python3: 3.7.7 - /usr/local/bin/python3
    Ruby: 2.6.3 - /usr/bin/ruby
  Databases:
    PostgreSQL: 12.3 - /Applications/Postgres.app/Contents/Versions/latest/bin/postgres
    SQLite: 3.28.0 - /usr/bin/sqlite3
  Browsers:
    Chrome: 83.0.4103.61
    Safari: 13.1
  • React Native Tools extension version: latest
  • Expo SDK version (if applicable): 37

closed time in 9 days

superandrew

issue closedmicrosoft/vscode-react-native

Run the application without debugging

Right now we only launch the application in debug mode. A couple developers have proposed having a way to run it in no debug mode as well.

closed time in 9 days

molant

issue commentmicrosoft/vscode-react-native

Run the application without debugging

We added three scenarios in React Native Tools Preview which allow to run applications without debugging:

  • Run Android (Preview)
  • Run iOS (Preview)
  • Run Android Hermes (Preview) - Experimental

To try them out, please, install React Native Tools Preview version.

molant

comment created time in 9 days

create barnchmicrosoft/vscode-react-native

branch : fix-async-request-handling

created branch time in 9 days

issue commentmicrosoft/vscode-react-native

[Bug] If there is a space in the ADB path, it will not work properly

@yuki2006, I tried to modify my .zshrc file the following way:

PATH="$PATH:/Volumes/Macintosh HD/Users/user/Documents/temp_sdk/folder with space/sdk/platform-tools"
export ANDROID_HOME=/Users/akvelon/Library/Android/sdk
export ANDROID_SDK_ROOT=$ANDROID_HOME
export PATH=$PATH:$ANDROID_HOME/emulator
export PATH=$PATH:$ANDROID_HOME/tools
export PATH=$PATH:$ANDROID_HOME/tools/bin

And the adb devices command worked correctly in the extension.

Could you please also try to add backslash(\) before the space in your configuration string to wrap the space?

set .zshrc
PATH="${PATH}":"/Volumes/Macintosh\ HD/Users/foo/Library/Android/sdk/platform-tools"
yuki2006

comment created time in 10 days

delete branch microsoft/vscode-react-native

delete branch : add-launch-apps-scenarios

delete time in 10 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 5514e2871f80044eedbe4f8290b3e9bdbf098c97

Add scenarios to run apps without debugging (#1319) * Add scenarios to launch Android and iOS apps without debugging * Add scenario to launch Android Hermes apps without debugging * Update README

view details

push time in 10 days

PR merged microsoft/vscode-react-native

Add scenarios to run apps without debugging preview
  • Added the enableDebug parameter to debug configurations. It is used to enable debug mode. If set to "false", an application will be launched without debugging.

  • Added 3 scenarios to launch Android, Android Hermes and iOS apps without debugging: image

  • Added the mobilePlatform.disableJSDebuggingMode telemetry event in case of launch apps without debugging image

https://github.com/microsoft/vscode-react-native/issues/1276

+239 -124

0 comment

11 changed files

RedMickey

pr closed time in 10 days

delete branch microsoft/vscode-react-native

delete branch : experiment-service-launch

delete time in 10 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha f4f2d271a4edf6e8f241d06226c8833f979dada6

Implement launch of experiment service (#1322)

view details

push time in 10 days

PR merged microsoft/vscode-react-native

Implement launch of the experiment service

https://github.com/microsoft/vscode-react-native/issues/1306

+11 -1

0 comment

2 changed files

RedMickey

pr closed time in 10 days

push eventRedMickey/ThingsManager

dependabot[bot]

commit sha 76c92a589376b07eccc5c70edd2acfb291d6b359

Bump websocket-extensions in /react-frontend/things-manager-frontend Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com>

view details

RedMickey

commit sha 4ef3205598b5463bb8df973edcb5107d33793a50

Merge pull request #1 from RedMickey/dependabot/npm_and_yarn/react-frontend/things-manager-frontend/websocket-extensions-0.1.4 Bump websocket-extensions from 0.1.3 to 0.1.4 in /react-frontend/things-manager-frontend

view details

push time in 11 days

PR merged RedMickey/ThingsManager

Bump websocket-extensions from 0.1.3 to 0.1.4 in /react-frontend/things-manager-frontend dependencies

Bumps websocket-extensions from 0.1.3 to 0.1.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md">websocket-extensions's changelog</a>.</em></p> <blockquote> <h3>0.1.4 / 2020-06-02</h3> <ul> <li>Remove a ReDoS vulnerability in the header parser (CVE-2020-7662, reported by Robert McLaughlin)</li> <li>Change license from MIT to Apache 2.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/faye/websocket-extensions-node/commit/8efd0cd6e35faf9bb9cb08759be1e27082177d43"><code>8efd0cd</code></a> Bump version to 0.1.4</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/3dad4ad44a8c5f74d4f8f4efd3f9d6e0b5df3051"><code>3dad4ad</code></a> Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/4a76c75efb1c5d6a2f60550e9501757458d19533"><code>4a76c75</code></a> Add Node versions 13 and 14 on Travis</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/44a677a9c0631daed0b0f4a4b68c095b624183b8"><code>44a677a</code></a> Formatting change: {...} should have spaces inside the braces</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/f6c50aba0c20ff45b0f87cea33babec1217ec3f5"><code>f6c50ab</code></a> Let npm reformat package.json</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/2d211f3705d52d9efb4f01daf5a253adf828592e"><code>2d211f3</code></a> Change markdown formatting of docs.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/0b620834cc1e1f2eace1d55ab17f71d90d88271d"><code>0b62083</code></a> Update Travis target versions.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/729a4653073fa8dd020561113513bfa2e2119415"><code>729a465</code></a> Switch license to Apache 2.0.</li> <li>See full diff in <a href="https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 11 days

push eventRedMickey/ThingsManager

RedMickey

commit sha cd7637e8877d10e2731b43741441a6a2fb53c1da

ThingsManagerRestAPI project created

view details

RedMickey

commit sha 59865cb8198d404edc2d6a3c6c8a47970f058c7e

Begining to create models

view details

RedMickey

commit sha 51685a2ac0d9af0b1f56ba388ff5d9945ead1d5d

Create repositories and services

view details

RedMickey

commit sha 02dd889b2b09687f4ff41182b658eebc5789cd71

Initialize frontend project

view details

RedMickey

commit sha cfa9fcd2625992314d585e1c16af148abb304173

Implement authentication

view details

RedMickey

commit sha 7faff72f57089f224a88ed4e854254646fdd3098

Implement authentication 0.7

view details

RedMickey

commit sha e3081b6ef63af0224ccfcd9f2409e9795002ef68

Add functional of items getting

view details

RedMickey

commit sha 253065f7511199c708d14be33fe3794ccff24eac

Add things displaying

view details

RedMickey

commit sha 2cdabe3aa81b4d1e6966df9bc8ca29543c73522d

Add unit test for ItemService

view details

RedMickey

commit sha 557c46354943616610c9f37c14687ceff579f0af

Add unit tests for models methods

view details

RedMickey

commit sha 0242d43af1f87f0a0135811bd34dc57c963966c5

Added markups for building, room and space pages

view details

RedMickey

commit sha b50c1067df9ab65f93d426649e59fae3c8d943e1

Implemented buildings

view details

RedMickey

commit sha f514d100ae0790b6df600be9976365c8c6a278f3

Added buildings and rooms functional

view details

RedMickey

commit sha 792fe7578b0f11452a7c7f884f09d6d98d444018

Add space functional

view details

RedMickey

commit sha 8dcffbc232852d58c4e34832e8a6c8eb4f890714

Implemented room and 1/2 space

view details

RedMickey

commit sha ca8ce2f0a9c2b532cb8fdc62c6191aeae8207649

Fix adding of Room entities, fix updating, add deletion

view details

RedMickey

commit sha 62fbc7d90d6209261940dd9e1191f67b68cf4e95

Fix adding of Spaces entities, fix updating, add deletion

view details

RedMickey

commit sha 5e9cd44eddd83db74657b25ada765a3d51d5f741

Add category support

view details

RedMickey

commit sha d0a2bbf32ea3aa5bcef3b33c06192019b3cd1616

Implement things adding

view details

RedMickey

commit sha d09a63d842559ab2e4432967bc24267b02c20fe1

Implement updating of things

view details

push time in 11 days

push eventRedMickey/ThingsManager

RedMickey

commit sha 9579305d05505fc7a81f14da66ca3a6e5489fe78

Implement image handling

view details

push time in 11 days

PR opened microsoft/vscode-react-native

Add experiment service to preview

https://github.com/microsoft/vscode-react-native/issues/1306

+493 -86

0 comment

8 changed files

pr created time in 11 days

create barnchmicrosoft/vscode-react-native

branch : implement-experiment-service

created branch time in 11 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 61e152fddd4e26bf9b57ae14cf057133f17196cf

Improve error handling

view details

push time in 11 days

push eventRedMickey/ThingsManager

RedMickey

commit sha dc55ba003386254a9bd19c863f6d12f6afe2c239

Implement image adding

view details

push time in 12 days

create barnchmicrosoft/vscode-react-native

branch : experiment-service-launch

created branch time in 12 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 5f0a94f67e03996b9c41affac7527c9f94a8997b

Fix comments

view details

push time in 12 days

delete branch microsoft/vscode-react-native

delete branch : add-prompt-functionality

delete time in 12 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 305d77de618087d06fb463c37d49ed8b069bbf35

Add prompt functionality to promote RNT-preview extension (#1309) * Implement Experiment Service * Implement sending of errors to telemetry * Adapt experiment service to bundling

view details

push time in 12 days

PR merged microsoft/vscode-react-native

Reviewers
Add prompt functionality to promote RNT-preview extension
  • Now the extension shows such a prompt before attaching to an application. image

  • When we click on Open extension button VS Code opens the page with information about the extension (Preview). image

For now, there isn't migration guide on the screenshot. We'll add it to the preview branch via another PR soon.

  • Added runExperiments telemetry event, which contains experiment names and their statuses or error codes:
    • Experiment status can be: enabled, disabled image
    • The error field can contain an error code or an encrypted message image

https://github.com/microsoft/vscode-react-native/issues/1306

+451 -20

4 comments

9 changed files

RedMickey

pr closed time in 12 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha efc432ef1a70a5d27b349f6b8cc63964551ccb91

Minor fix

view details

push time in 13 days

PR opened microsoft/vscode-react-native

Add scenarios to run apps without debugging

https://github.com/microsoft/vscode-react-native/issues/1276

+131 -27

0 comment

9 changed files

pr created time in 15 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 2ebb089358af94721a3c4eca292a18820c79b5a5

Update README

view details

push time in 15 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 8a02a98f112974950c83d589d63ab8f52262621d

Add scenario to launch Android Hermes apps without debugging

view details

push time in 15 days

create barnchmicrosoft/vscode-react-native

branch : add-launch-apps-scenarios

created branch time in 15 days

issue commentmicrosoft/vscode-react-native

Use the same ws version as in debuggee app

@benabbon, I am closing this issue due to inactivity. Feel free to reopen if needed.

ruslan-bikkinin

comment created time in 16 days

issue closedmicrosoft/vscode-react-native

Use the same ws version as in debuggee app

Related issue: #1047

Currently, debugger uses particular version of ws (https://github.com/microsoft/vscode-react-native/blob/master/src/debugger/appWorker.ts#L6), but, as RN team has start bumping ws version that is used in RN for proxy debugger server, this version may be inconsistent with the one is used in the extension. To avoid any future problems extension should use ws version that is installed in the debuggee app.

closed time in 16 days

ruslan-bikkinin

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 1df2366af7cd43cd025b60dbf41f0b7417c585d8

Fix tests

view details

push time in 16 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha 123997eb8bba1d5c153872b81439ec23b1b30d0b

Adapt experiment service to bundling

view details

push time in 16 days

delete branch microsoft/vscode-react-native

delete branch : add-debug-config-migration-help

delete time in 17 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha ff70c05a6c821e99785e3f91dca1daf27094e4fd

Add debug config migration guide for RNT preview (#1311) * Add migration guide

view details

push time in 17 days

PR merged microsoft/vscode-react-native

Reviewers
Add debug config migration guide for RNT preview preview

The preview guide will look like: image

+36 -0

0 comment

2 changed files

RedMickey

pr closed time in 17 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha bd79be0d0ea1e6b9d154a792bd8c08f68c61a135

Implement sending of errors to telemetry

view details

push time in 18 days

Pull request review commentmicrosoft/vscode-react-native

Add prompt functionality to promote RNT-preview extension

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT license. See LICENSE file in the project root for details.++import * as Configstore from "configstore";+import * as https from "https";+import * as glob from "glob";+import * as vscode from "vscode";+import * as path from "path";+import { getFileNameWithoutExtension } from "../../common/utils";+import { IExperiment } from "./IExperiment";+import { PromiseUtil } from "../../common/node/promise";+import { TelemetryHelper } from "../../common/telemetryHelper";++export enum ExperimentStatuses {+    ENABLED = "enabled",+    DISABLED = "disabled",+    FAILED = "failed",+}++export interface ExperimentConfig {+    experimentName: string;+    popCoveragePercent: number;+    enabled: boolean;+}++export interface ExperimentParameters extends ExperimentConfig {+    [key: string]: any;+    extensionId?: string;+}++export interface ExperimentResult {+    resultStatus: ExperimentStatuses;+    updatedExperimentParameters: ExperimentParameters;+}++export class ExperimentService implements vscode.Disposable {+    private static instance: ExperimentService;++    private readonly endpointURL: string;+    private readonly configName: string;+    private config: Configstore;+    private downloadedExperimentsConfig: Array<ExperimentConfig> | null;+    private experimentsInstances: Map<string, IExperiment>;+    private downloadConfigRequest: Promise<ExperimentConfig[]>;+    private promiseUtil: PromiseUtil;+    private cancellationTokenSource: vscode.CancellationTokenSource;++    public static create () {+        if (!ExperimentService.instance) {+            ExperimentService.instance = new ExperimentService();+        }++        return ExperimentService.instance;+    }++    public async runExperiments(): Promise<void> {+        if (!this.downloadedExperimentsConfig) {+            this.downloadedExperimentsConfig = await this.downloadConfigRequest;+        }++        let experimentResults: Array<ExperimentResult> = await Promise.all(this.downloadedExperimentsConfig+            .map(async (expConfig) => await this.executeExperiment(expConfig))+        );++        this.sendExperimentTelemetry(experimentResults);+    }++    public dispose() {+        this.cancellationTokenSource.cancel();+        this.cancellationTokenSource.dispose();+    }++    private constructor() {+        this.endpointURL = "https://microsoft.github.io/vscode-react-native/experiments/experimentsConfig.json";+        this.configName = "reactNativeToolsConfig";++        this.promiseUtil = new PromiseUtil();+        this.config = new Configstore(this.configName);+        this.cancellationTokenSource = new vscode.CancellationTokenSource();+        this.downloadedExperimentsConfig = null;++        this.experimentsInstances = this.initializeExperimentsInstances();+        this.downloadConfigRequest = this.retryDownloadExperimentsConfig();+    }++    private getAvailableExperiments(): Array<string> {+        const cwd = path.join(__dirname, "experiments");+        return glob.sync("*.js", { cwd })+        .map(fullExpName => path.join(cwd, fullExpName));+    }++    private async executeExperiment(expConfig: ExperimentConfig): Promise<ExperimentResult> {+        let curExperimentParameters = this.config.get(expConfig.experimentName);+        let expInstance = this.experimentsInstances.get(expConfig.experimentName);++        let expResult: ExperimentResult;+        if (expInstance && expConfig.enabled) {+            try {+                expResult = await expInstance.run(expConfig, curExperimentParameters);+                this.config.set(expConfig.experimentName, expResult.updatedExperimentParameters);+            } catch (err) {+                expResult = {+                    resultStatus: ExperimentStatuses.FAILED,+                    updatedExperimentParameters: expConfig,+                };+            }+        } else {+            expResult = {+                resultStatus: ExperimentStatuses.DISABLED,+                updatedExperimentParameters: expConfig,+            };+        }++        return expResult;+    }++    private async retryDownloadExperimentsConfig(retryCount = 60): Promise<ExperimentConfig[]> {+        try {+            return await this.downloadExperimentsConfig();+        } catch (err) {+            if (retryCount < 1 || this.cancellationTokenSource.token.isCancellationRequested) {+                throw err;+            }++            await this.promiseUtil.delay(2000);+            return await this.retryDownloadExperimentsConfig(--retryCount);+        }+    }++    private initializeExperimentsInstances(): Map<string, IExperiment> {+        let expInstances = new Map<string, IExperiment>();+        const availableExperiments = this.getAvailableExperiments();++        availableExperiments.forEach(expPath => {+            let expClass = require(expPath);

We implemented a custom require function in the bundled extension. I asked Yuri about this place and he said that we could replace require with the customRequire function to be able to get modules dynamically. I think we will adapt this part of the code during adding of the experiment service to the Preview version.

RedMickey

comment created time in 18 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha b8ff6bdda3f456f5f4a0b6efe169a13b3f58727e

Remove redundant images

view details

push time in 18 days

push eventmicrosoft/vscode-react-native

RedMickey

commit sha d399f2957a8e988e7b6af8145756639797426934

Fixed comments

view details

push time in 18 days

issue openedexpo/expo-cli

[Bug] Incorrect check of the packager port in the "setOptionsAsync" function

Hello, I am a maintainer of React Native Tools VS Code extension. The extension is used for debugging React Native (including Expo) applications.

Description

We use the setOptionsAsync function from the @expo/xdl package. After the latest release of the @expo/xdl package (@expo/xdl@57.9.14) we faced the problem with configuring of the packager port. Now this function throws the error:

XDLError: packagerPort must be an integer

But we provide an integer packager port parameter.

image

It seems that the condition for verification of the packager port is incorrect.

Expected Behavior

I suppose that the condition for verification of the packager port could look something like this:

  if (options.packagerPort != null && !Number.isInteger(options.packagerPort)) {
    throw new XDLError('INVALID_OPTIONS', 'packagerPort must be an integer');
  }

This condition will be true if packagerPort isn't null and packagerPort isn't integer. So in such case the error should be thrown.

Observed Behavior

This is the current condition, which was added in this commit chore: upgrade and partially remove deprecated joi package.

  if (options.packagerPort != null && Number.isInteger(options.packagerPort)) {
    throw new XDLError('INVALID_OPTIONS', 'packagerPort must be an integer');
  }

This condition will be true if packagerPort isn't null and packagerPort is integer. So the error "packagerPort must be an integer" will be thrown if packagerPort is integer instead of when it isn't integer.

created time in 19 days

issue commentmicrosoft/vscode-react-native

autocompleted/suggestion no more show after autto updated vscode

Hi @zxccvvv and thanks for reaching us. I upgraded VS Code to 1.46.0 and didn't face problems with IntelliSense work and autocomplete. The extension doesn't provide features for code autocomplete. VS Code uses TypeScript language service to extract type declarations from *.d.ts files, and then based on this data implements autocomplete (you can find more info about IntelliSense and React here). I checked that autocomplete works without this extension (VS Code 1.46).

image

Do you have autocomplete problems only in React Native projects? Could you please check if autocomplete works in other javascript and/or typescript projects?

Could you please also send us the following logs in case of incorrect work of autocomplete?

  • Output of the Developer Tools console (Help -> Toggle Developer Tools -> Select Console tab):
PASTE OUTPUT HERE
zxccvvv

comment created time in 19 days

issue commentmicrosoft/vscode-react-native

[Bug] Expo SDK 38 not supported?

Hi @GollyJer and thanks for reaching us. The extension uses @expo/xdl package to get an Expo SDK version. We investigated this issue and found out that the function of getting Expo SDK version works incorrectly in @expo/xdl package. Expo has added Expo SDK v38 to SDK versions, but it hasn't been released yet. For now the function returns the latest version of SDK, so we get SDK 38 instead of 37. We opened the issue about this bug in expo/expo-cli repository. But until Expo fixes this bug, please, replace"sdkVersion": "38.0.0" with "sdkVersion": "37.0.0" manually in app.json file if you face this problem again.

GollyJer

comment created time in 19 days

issue openedexpo/expo-cli

[Bug] Incorrect mapping of a React Native version to an Expo SDK version

Hello, I am a maintainer of React Native Tools VS Code extension. The extension is used for debugging React Native (including Expo) applications.

[Bug] Incorrect mapping of a React Native version to an Expo SDK version

We use facebookReactNativeVersionToExpoVersionAsync function to get appropriate Expo SDK version and add it to app.json file. This function worked fine until Expo added new SDK v38 to Expo SDK versions. We investigated how this function works and found out that after chore: clean up lodash usage (#2170) commit its behavior has been changed a bit. It seems that now the original facebookReactNativeVersion parameter passed to the function is overlaped in this loop by internal facebookReactNativeVersion variable. Therefore in each iteration we compare the facebookReactNativeVersion parameter with itself.

image image

Expected Behavior

For example we pass facebookReactNativeVersion equals to 0.61.4 to this function . We expect to get Expo SDK 37 version.

Observed Behavior

But facebookReactNativeVersionToExpoVersionAsync function returnes Expo SDK 38 version.

image

It seems that all iterations are performed in the loop and we get the version of the newest SDK (38). I suppose that we haven't faced this problem earlier since Expo SDK 37 was the latest version.

Environment

System: OS: Windows 10 10.0.18362 CPU: (8) x64 Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz Memory: 15.94 GB Binaries: Node: 12.14.1 Yarn: 1.17.3 npm: 6.13.4 SDKs: Expo-CLI: 3.21.5 Expo: 37.0.9 Android SDK: API Levels: 27, 28, 29 Build Tools: 27.0.3, 28.0.2, 28.0.3, 29.0.2, 29.0.3 System Images: android-28 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom IDEs: Android Studio: Version 3.6.0.0 AI-192.7142.36.36.6241897

created time in 19 days

push eventRedMickey/ThingsManager

RedMickey

commit sha caf6d473052014c8c5cc2a814e1ab9916aca27df

Implement image controller

view details

RedMickey

commit sha 6719fa788d58f3d902ee77e1f24593541b856ce0

Remove redundant images

view details

RedMickey

commit sha 49dc5bf693ddab40a258622571eeb52db9b76cb9

Update .gitignore

view details

push time in 20 days

push eventmicrosoft/vscode-react-native

JiglioNero

commit sha 90d151176518d426875fba71cc79be9cba58072d

Eslint migration (#1315) * Initial eslint configuration * lint changes * fix camel case * update pachage-lock and delete tslint.json * disable prefer-rest-params * add eslint task to smoke gulp, add rules for semicolons and do some autofixes * fix in smoke tests * remove tslint from smoke package.json * fix rule for delimeters * small fix * remove redunant ignore patterns Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com>

view details

RedMickey

commit sha bb76fcf199609b8813738109409a0da4303171fc

Merge master branch

view details

push time in 23 days

Pull request review commentmicrosoft/vscode-react-native

Add prompt functionality to promote RNT-preview extension

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT license. See LICENSE file in the project root for details.++import * as Configstore from "configstore";+import * as https from "https";+import { PreviewVersionPromotion } from "./experiments/previewVersionPromotion";+import { IExperiment } from "./experiments/IExperiment";+import { TelemetryHelper } from "../../common/telemetryHelper";++export enum ExperimentStatuses {+    FAILURE = "failure",+    SUCCESS = "success",+    SKIPPED = "skipped",+}++export interface ExperimentConfig {+    experimentName: string;+    popCoveragePercent: number;+    enabled: boolean;+}++export interface ExperimentParameters extends ExperimentConfig {+    [key: string]: any;+    extensionId?: string;+}++export interface ExperimentResult {+    resultStatus: ExperimentStatuses;+    updatedExperimentParameters: ExperimentParameters;+}++export class ExperimentService {+    private readonly endpointURL: string;+    private readonly configName: string;+    private readonly availableExperiments: any;+    private config: Configstore;+    private downloadedExperimentsConfig: Array<ExperimentConfig> | null;+    private downloadConfigRequest: Promise<ExperimentConfig[]> | null;++    constructor() {+        this.endpointURL = "https://microsoft.github.io/vscode-react-native/experiments/experimentsConfig.json";+        this.configName = "reactNativeToolsConfig";+        this.availableExperiments = {+            RNT_PREVIEW_PROMPT: "RNTPreviewPrompt",+        };++        this.config = new Configstore(this.configName);+        this.downloadedExperimentsConfig = null;+        this.downloadConfigRequest = null;+    }++    public async initialize(): Promise<void> {+        this.downloadConfigRequest = this.downloadExperimentsConfig();+    }++    public async runExperiments(): Promise<void> {+        if (!this.downloadedExperimentsConfig) {+            if (!this.downloadConfigRequest) {+                throw new Error("Experiment Service is not initialized");+            }+            try {+                this.downloadedExperimentsConfig = await this.downloadConfigRequest;+            } catch (err) {+                this.downloadConfigRequest = this.downloadExperimentsConfig();+                throw new Error("Failed to download experiments config");

I added retry download function for downloading of experiments config, so there shouldn't be an infinity-loop.

RedMickey

comment created time in 23 days

more