profile
viewpoint
PowerShell Team PowerShell Redmond https://microsoft.com/powershell https://microsoft.com/powershell

pull request commentPowerShell/PowerShell-RFC

draft to enable pwsh to be used as login shell

@joeyaiello, @JamesWTruher and I discussed this today.

I was a bit dissatisfied with the idea of executing the profile file with sh and sucking up the output.

My first instinct was that maybe starting pwsh as a subprocess of sh so that it inherits the variables, but didn't like the implementation detail of the sh process wrapping pwsh.

@JamesWTruher suggested that this is exactly what exec is for (note that exec decrements SHLVL in bash).

@joeyaiello then suggested that a simple and effective solution is a wrapper script (perhaps /bin/pwsh-login):

#/bin/sh -l
exec pwsh

Discussing this we were curious about how other sh-incompatible shells are used as login shells, and:

  • The prevailing suggestion for fish is to do the same as above
  • csh/tcsh have their own .login concept and don't even try to run .profile
SteveL-MSFT

comment created time in 22 minutes

issue commentPowerShell/PowerShell

Remoting infrastructure doesn't allow capturing / redirection of any streams other than success and error

What you are seeing on console is actually a host stream. Warning/verbose/debug/information records processed remotely and resulting writes to host transferred and replicated locally.

mklement0

comment created time in an hour

issue commentPowerShell/PowerShell

Remoting infrastructure doesn't allow capturing / redirection of any streams other than success and error

Thanks, @PetSerAl, I've updated the OP accordingly. So this means that while you can capture the information stream with a redirection and with-InformationVariable, and the warning stream with -WarningVariable only, the streams (effectively) still also print to the console, which cannot be suppressed.

mklement0

comment created time in an hour

push eventPowerShell/PowerShell

Ilya

commit sha afa76dec2374df8dadc1629bd7050c5db11c0694

Remove Workflow from PSSessionType (#9618) Remove PSSessionType and IsWorkflowConfigurationType()

view details

push time in 2 hours

PR merged PowerShell/PowerShell

Reviewers
Remove Workflow from PSSessionType CL-CodeCleanup

<!-- Anything that looks like this is a comment and can't be seen after the Pull Request is created. -->

PR Summary

Remove deprecated Workflow code.

PR Context

Related #9570

We could remove PSSessionType (or only Workflow value from it) at all but it is used publicly as parameter in Register-PSSessionConfiguration and would be a breaking change. Is it ok?

PR Checklist

+11 -165

0 comment

6 changed files

iSazonov

pr closed time in 2 hours

startedPowerShell/PowerShell

started time in 3 hours

startedPowerShell/PowerShell

started time in 3 hours

startedPowerShell/xActiveDirectory

started time in 3 hours

startedPowerShell/PowerShell

started time in 3 hours

issue commentPowerShell/PowerShell

How you re-throw changes our ability to catch the exception:

I recall some discussion about PS ignore exceptions thrown by a .NET property accessor but I don't recall anything about exceptions thrown by .NET methods being treated differently. But the following behavior is just weird. The Substring(1) call causes an exception to be generated in .NET. An exception "should" alter the flow of control through my code and IMO the Write-Host shouldn't execute but it does. I have to wrap that call in try/catch to get the behavior I want. I can also set $ErrorActionPreference to Stop to get the desired behavior but both of these seem like they should be unnecessary.

C:\Users\Keith
05-20 20:03:02 3> function WTF {
>>     [CmdletBinding()]param()
>>     "".substring(1)
>>     Write-Host "Shouldn't get here!"
>> }
C:\Users\Keith
05-20 20:08:47 4> WTF
Exception calling "Substring" with "1" argument(s): "startIndex cannot be larger than length of string.
Parameter name: startIndex"
At line:3 char:5
+     "".substring(1)
+     ~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
+ FullyQualifiedErrorId : ArgumentOutOfRangeException

Shouldn't get here!  <<<< Huh?
C:\Users\Keith
05-20 20:08:51 5> function WTF {
>>     [CmdletBinding()]param()
>>     try { "".substring(1) } catch { throw }
>>     Write-Host "Shouldn't get here!"
>> }
C:\Users\Keith
05-20 20:09:17 6> WTF
Exception calling "Substring" with "1" argument(s): "startIndex cannot be larger than length of string.
Parameter name: startIndex"
At line:3 char:11
+     try { "".substring(1) } catch { throw } # This works but doesn't seem like I should have to do this
+           ~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [], ParentContainsErrorRecordException
+ FullyQualifiedErrorId : ArgumentOutOfRangeException

C:\Users\Keith
05-20 20:09:19 7>
Jaykul

comment created time in 3 hours

startedPowerShell/PowerShell

started time in 3 hours

pull request commentPowerShell/PowerShell-RFC

draft to enable pwsh to be used as login shell

@iSazonov:

My sense is that logon shells are a legacy construct, stemming from a time when the shell was the only UI. System-wide configuration shouldn't rely on a particular shell's startup behavior, and things are moving away from that. A shell's initialization files should be limited to configuring that shell's behavior.

Therefore:

  • We should try to be as compatible as is reasonably possible in order to accommodate the remnants of that legacy behavior, most notably on macOS.

  • However, we do not want to get into the business of concocting a PowerShell-specific login shell feature, let alone via .json files.

SteveL-MSFT

comment created time in 3 hours

pull request commentPowerShell/PowerShell-RFC

draft to enable pwsh to be used as login shell

@SteveL-MSFT: SHELL reflects the user's default shell, not the one currently running, so it can safely be inherited.

@joeyaiello: SHLVL would indeed be inappropriate to inherit; _, by contrast is a shell variable (current-process-only), not an environment variable, which is generally an important distinction to make.

With the reinvoke-via-sh approach I've proposed, you wouldn't need to worry about shell variables, because they would invariably be scoped to the sh process.

SteveL-MSFT

comment created time in 4 hours

PR opened PowerShell/PowerShellGet

Issue 340 - Prefer Trusted Repositories

This addresses a portion of issue #340.

  • Get-PSRepository now returns trusted repos, then untrusted repos. They are also sorted alphabetically.
  • Install-Module now does a Find-Module based on the parameters and if there are multiple repositories found, the first result is picked and set as the Source parameter for Install-Package.

Tests were added for both changes. I'm concerned that Find-Module will have a performance impact, but I'm not sure how else to do that check unless it's done at the PackageManagement\Install-Package function instead.

+88 -18

0 comment

4 changed files

pr created time in 4 hours

issue openedPowerShell/PowerShell

provider path in namespace variable notation inconsistency

Steps to reproduce

Try a provider path in namespace variable notation to access a file:

${filesystem::drive:pathtofile} # nothing happens
${filesystem::drive:pathtofile} = 'hello' # 'hello' is written to file
${filesystem::drive:pathtofile} # nothing happens
${drive:pathtofile} # gets file contents 'hello'

Substitute a valid accessible path to a temporary file for testing. Note that using a drive requires Windows drives.

I'd expect both syntaxes to read the file, since the provider notation is able to write the file.

Environment data

Name                           Value
----                           -----
PSVersion                      6.2.0
PSEdition                      Core
GitCommitId                    6.2.0
OS                             Microsoft Windows 10.0.17763
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

<!-- provide the output of $PSVersionTable -->


created time in 5 hours

issue commentPowerShell/Win32-OpenSSH

Public key authentication not allowed by mm_answer_keyallowed

Thanks the reply.

No, I did not put my authorized key in PROGRAMDATA/ssh/administrators_authorized_keys. You can see that,

Failed to open file:C:/ProgramData/ssh/administrators_authorized_keys error:2

I.e., the file is not found. I put in my user's profile instead.

suntong

comment created time in 5 hours

pull request commentPowerShell/PowerShell-RFC

RFC for expanded implicit line continuance feature

Tbh, with this we're kinda starting to get in the "generalized splatting" RFC territory, where supposedly this would be possible with this syntax instead (among other things outlined in that RFC):

Get-ChildItem @@{
    Path = "C:\"
    Filter = "*.ps*1"
    File = $true
    Recurse = $true
KirkMunro

comment created time in 5 hours

Pull request review commentPowerShell/PowerShell-RFC

RFC for expanded implicit line continuance feature

 If the risk is deemed to be too high because of the risk with named unary operat     Pros: The @ symbol is familiar since it is used for splatting. Also, PSReadline could recognize when you're opting in to use this at the command prompt, only running the command if you hit enter twice (although this wouldn't be used nearly as often at the prompt -- it's really for scripts).     Cons: Users lose the benefit of not having to use any characters for line continuance. +    Here's another alternative sigil to do the same thing that is a bit more literal:++    ```PowerShell+    New-ADUser ...

Personally I'm rather fond of using ~ as the continuation token here:

Get-ChildItem ~
    C:\
    -Filter *.ps*1
    -File
    -Recurse
KirkMunro

comment created time in 5 hours

PR opened PowerShell/PowerShell

Reviewers
Allow updatable help defaultsourcepath setting from user settings

<!-- Anything that looks like this is a comment and can't be seen after the Pull Request is created. -->

PR Summary

Allow updatable help defaultsourcepath setting from user settings

fixes #9632

PR Context

<!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->

PR Checklist

+1 -1

0 comment

1 changed file

pr created time in 5 hours

pull request commentPowerShell/xWebAdministration

FTP

Hi @t3mi , nice work on this! Can we separate the changes into two PRs? One for the new FTP resource and another for the changes to xWebsite and xWebApplication? They are both big changes in their own right and would be good to have a separate issue opened for the changes to xWebsite and xWebApplication and describe what we're addressing there. It's a large PR and will be easier to review if we can keep the changes scoped a bit more.

t3mi

comment created time in 6 hours

pull request commentPowerShell/PowerShell

Build(deps): Bump NJsonSchema from 9.14.1 to 10.0.0

10.0 renamed the JsonSchema4 type to just JsonSchema. We can fix the cmdlet, but anyone scripted against this type will be broken.

dependabot[bot]

comment created time in 6 hours

delete branch PowerShell/vscode-powershell

delete branch : dependabot/npm_and_yarn/@types/node-12.0.2

delete time in 6 hours

push eventPowerShell/vscode-powershell

dependabot[bot]

commit sha 802d3a933933f1be67fb1216886931694dbebd95

[Ignore] Bump @types/node from 12.0.1 to 12.0.2 (#1970) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.0.1 to 12.0.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

push time in 6 hours

PR merged PowerShell/vscode-powershell

Bump @types/node from 12.0.1 to 12.0.2 dependencies

Bumps @types/node from 12.0.1 to 12.0.2. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

+4 -4

1 comment

2 changed files

dependabot[bot]

pr closed time in 6 hours

delete branch PowerShell/vscode-powershell

delete branch : dependabot/npm_and_yarn/legacy/1.x/@types/node-12.0.2

delete time in 6 hours

push eventPowerShell/vscode-powershell

dependabot[bot]

commit sha 1695ce13a46da80b6e2fadf3e90ad1d3c23feabf

[Ignore] Bump @types/node from 12.0.1 to 12.0.2 (#1971) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.0.1 to 12.0.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

push time in 6 hours

PR merged PowerShell/vscode-powershell

Bump @types/node from 12.0.1 to 12.0.2 dependencies

Bumps @types/node from 12.0.1 to 12.0.2. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

+4 -4

1 comment

2 changed files

dependabot[bot]

pr closed time in 6 hours

issue commentPowerShell/PowerShellGet

Proposal: Allow multiple repositories to contain the same package

Sounds good. I'm hoping to have something over this week. I think I have the Install-Module and Get-Module files modified, just need to come up with the tests to validate.

edyoung

comment created time in 6 hours

issue openedPowerShell/PowerShell

Update-Help DefaultSourcePath should be allowed from user setting

Summary of the new feature/enhancement

Update-Help DefaultSourcePath should be allowed from user setting

Proposed technical implementation details (optional)

This line here: https://github.com/PowerShell/PowerShell/blob/778920bbc443182ee6bf0646ad43e7e43cc6a72f/test/xUnit/csharp/test_PSConfiguration.cs#L509

should be changed to var updatableHelpSetting = Utils.GetPolicySetting<UpdatableHelp>(Utils.SystemWideOnlyConfig);

created time in 6 hours

issue commentPowerShell/PowerShellGet

Proposal: Allow multiple repositories to contain the same package

That would be great! Nobody is looking at this to my knowledge. I feel a bit weird about using alphabetical order for sorting but can't think of a big problem that would result, and the priority thing makes it more complicated, so I am fine leaving it out - we could potentially add it later if we discover a good reason.

edyoung

comment created time in 6 hours

issue commentPowerShell/Win32-OpenSSH

ProxyJump

missing this one too, proxycommand workaround seems to misbehave with paramiko...

ProxyCommand requires netcat/nmap-ncat installed on the JumpHost.

cw789

comment created time in 7 hours

issue commentPowerShell/PSDscResources

WindowsFeature Absent should account for 'removed' as well

I had to do the following to overcome the issue:

#Disabled Features (STIG Requirements) $DisabledFeatures = @( 'Simple-TCPIP' 'Telnet-Client' 'PNRP' 'Web-Ftp-Server' 'Web-Ftp-Service' 'Web-Ftp-Ext' 'TFTP-Client' 'Fax' 'RSAT-Fax' ) Script Remove_Disabled_Features { #Using script resource because some features are not available at all, and windowsfeature resource reports error in configuring #'$.InstallState -match '^Install' covers Install and InstallPending GetScript = { #Do Nothing } SetScript = { $Installed_Features = Get-WindowsFeature | Where-Object {$.Name -in $Using:DisabledFeatures -and $.InstallState -match '^Install'} ForEach ($Feature in $Installed_Features) {Uninstall-WindowsFeature -Name $Feature} } TestScript = { $Installed_Features = Get-WindowsFeature | Where-Object {$.Name -in $Using:DisabledFeatures -and $_.InstallState -match '^Install'} if ($Installed_Features) {return $false} else {return $true} } }

ewhitesides

comment created time in 7 hours

issue commentPowerShell/Win32-OpenSSH

New-PSSession error "subsystem request failed on channel 0"

@Adikota Check out https://docs.microsoft.com/en-us/powershell/scripting/learn/remoting/ssh-remoting-in-powershell-core?view=powershell-6

sunzcosmo

comment created time in 7 hours

push eventPowerShell/openssh-portable

Bryan Berns

commit sha 959cbe326544e33f8a21d0ddcd5e6af70667c069

Allow Console Output In UTF-8 (#378) - Address issue where console output does not display UTF-8 string properly. - Resolves https://github.com/PowerShell/Win32-OpenSSH/issues/1225

view details

push time in 7 hours

PR merged PowerShell/openssh-portable

Allow Console Output In UTF-8
  • Address issue where console output does not display UTF-8 string properly.
  • Resolves https://github.com/PowerShell/Win32-OpenSSH/issues/1225
+2 -0

0 comment

1 changed file

NoMoreFood

pr closed time in 7 hours

issue closedPowerShell/Win32-OpenSSH

SFTP, SSH unicode display issues.

version - OpenSSHv7.7.2.0.

  1. SSH NO-PTY Unicode issue PS C:\Users\bagajjal\Desktop\OpenSSH_RS5_inbox> .\ssh.exe -T nonadmin@localhost "dir c:\users\nonadmin\client_test_dir_язык" Volume in drive C has no label. Volume Serial Number is F82C-1E41

Directory of c:\users\nonadmin\client_test_dir_????

08/03/2018 05:46 PM <DIR> . 08/03/2018 05:46 PM <DIR> .. 0 File(s) 0 bytes 2 Dir(s) 26,905,329,664 bytes free PS C:\Users\bagajjal\Desktop\OpenSSH_RS5_inbox>

  1. SFTP Unicode issue sftp> ls c:\test /c:/test/client_test_dir_╤Å╨╖╤ï╨║ (But it should be c:\test\client_test_dir_язык) sftp> cd c:\test\client_test_dir_язык sftp> pwd Remote working directory: /c:/test/client_test_dir_╤Å╨╖╤ï╨║

sftp> lcd c:\test\client_test_dir_язык sftp> lpwd Local working directory: c:\test\client_test_dir_╤Å╨╖╤ï╨║ sftp>

closed time in 7 hours

bagajjal

issue commentPowerShell/PSDscResources

WindowsFeature Absent should account for 'removed' as well

output from a similar setting I had set on 'PNRP' feature:

Message System.InvalidOperationException: The requested feature PNRP could not be found on the target machine. HResult -2146233087 StackTrack at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input) at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke) at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync) at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings) at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings) at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings) at Microsoft.PowerShell.DesiredStateConfiguration.Internal.ResourceProviderAdapter.ExecuteCommand(PowerShell powerShell, ResourceModuleInfo resInfo, String operationCmd, List1 acceptedProperties, CimInstance nonResourcePropeties, CimInstance resourceConfiguration, LCMDebugMode debugMode, PSInvocationSettings pSInvocationSettings, UInt32& resultStatusHandle, Collection1& result, ErrorRecord& errorRecord, PSModuleInfo localRunSpaceModuleInfo)

ewhitesides

comment created time in 7 hours

issue openedPowerShell/PSDscResources

WindowsFeature Absent should account for 'removed' as well

When I declare a simple resource such as this:

WindowsFeature RemoveTFTP {
    Name = 'TFTP-Client'
    Ensure = 'Absent'
}

I get returned that the resource is not in desired state (from get-dscconfigurationstatus) when applying this to 2016 servers without a GUI, because apparently by default this feature is removed, not available, etc.

To me, if the feature is removed, that also qualifies as absent, so it should return that it is in the desired state.

created time in 7 hours

issue commentPowerShell/Win32-OpenSSH

Public key authentication not allowed by mm_answer_keyallowed

Looks like you are an admin on the target. Did you put your authorized key in PROGRAMDATA/ssh/administrators_authorized_keys ? and not in the user's profile ?

suntong

comment created time in 8 hours

pull request commentPowerShell/openssh-portable

Add Zlib Library For Compression Support

@lars18th not yet. we have some work on our side to put in place an official build pipeline for the new repo.

NoMoreFood

comment created time in 8 hours

PR closed PowerShell/PowerShell

Reviewers
updating getting-code-coverage.md with errors I encountered CL-Docs Review - Abandoned

PR Summary

I was following this document and found out some additional steps to get it working. This PR adds additional steps, which might save some time in the future if someone is to encounter the same.

PR Checklist

+17 -0

6 comments

1 changed file

SytzeAndr

pr closed time in 8 hours

pull request commentPowerShell/PowerShell

updating getting-code-coverage.md with errors I encountered

This PR has been automatically closed because it is stale. If you wish to continue working on the PR, please first update the PR, then reopen it. Thanks again for your contribution. Community members are welcome to grab these works.

SytzeAndr

comment created time in 8 hours

issue commentPowerShell/Win32-OpenSSH

How change dos command promt?

Already, but problem is exist

goodandrewsoft

comment created time in 8 hours

issue commentPowerShell/Win32-OpenSSH

How change dos command promt?

do set PROMPT=$P$G from within the remote session

goodandrewsoft

comment created time in 8 hours

issue commentPowerShell/Win32-OpenSSH

Java client sftp fails

Please get SFTP server side traces using steps at https://github.com/PowerShell/Win32-OpenSSH/wiki/Troubleshooting-Steps https://github.com/PowerShell/Win32-OpenSSH/wiki/Logging-Facilities

shorbachuk

comment created time in 8 hours

Pull request review commentPowerShell/PowerShell-RFC

RFC for expanded implicit line continuance feature

 If the risk is deemed to be too high because of the risk with named unary operat     Pros: The @ symbol is familiar since it is used for splatting. Also, PSReadline could recognize when you're opting in to use this at the command prompt, only running the command if you hit enter twice (although this wouldn't be used nearly as often at the prompt -- it's really for scripts).     Cons: Users lose the benefit of not having to use any characters for line continuance. +    Here's another alternative sigil to do the same thing that is a bit more literal:++    ```PowerShell+    New-ADUser ...

My current favorite is this alternative -- not the ellipsis specifically, but some sigil to tell the parser to parse the rest of the command in multi-line mode, meaning it would parse parameters/arguments until it encountered a command terminator (e.g. semi-colon, closing brace/bracket, etc.) or a blank line. It's minimal, transitioning to/from that syntax is as simple as adding/deleting the sigil and some newlines, and commands could be wrapped however the scripter wants, it would work in the interactive shell, and it would be completely non-breaking as long as the sigil was chosen carefully.

KirkMunro

comment created time in 8 hours

issue commentPowerShell/Win32-OpenSSH

Key generated is not considered by ssh when connecting to server

Follow trouble shooting steps at https://github.com/PowerShell/Win32-OpenSSH/wiki/Troubleshooting-Steps

If you are an admin, see if this helps: https://github.com/PowerShell/Win32-OpenSSH/wiki/sshd_config#authorizedkeysfile

eliassal

comment created time in 8 hours

pull request commentPowerShell/vscode-powershell

Bump @types/node from 12.0.1 to 12.0.2

CLA assistant check <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><br/>:x: dependabot[bot] sign now<br/><sub>You have signed the CLA already but the status is still pending? Let us recheck it.</sub>

dependabot[bot]

comment created time in 8 hours

pull request commentPowerShell/vscode-powershell

Bump @types/node from 12.0.1 to 12.0.2

CLA assistant check <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><br/>:x: dependabot[bot] sign now<br/><sub>You have signed the CLA already but the status is still pending? Let us recheck it.</sub>

dependabot[bot]

comment created time in 8 hours

issue openedPowerShell/PowerShell

Dependabot couldn't reach https://powershell.myget.org/F/powershell-core/api/v3/index.json as it timed out

Dependabot couldn't reach https://powershell.myget.org/F/powershell-core/api/v3/index.json as it timed out.

Is https://powershell.myget.org/F/powershell-core/api/v3/index.json accessible over the internet? If it is then this may be a transitory issue and can be ignored - Dependabot will close it on its next successful update run.

You can mention @dependabot in the comments below to contact the Dependabot team.

created time in 8 hours

PR opened PowerShell/vscode-powershell

Bump @types/node from 12.0.1 to 12.0.2

Bumps @types/node from 12.0.1 to 12.0.2. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

+4 -4

0 comment

2 changed files

pr created time in 8 hours

PR opened PowerShell/vscode-powershell

Bump @types/node from 12.0.1 to 12.0.2

Bumps @types/node from 12.0.1 to 12.0.2. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

+4 -4

0 comment

2 changed files

pr created time in 8 hours

Pull request review commentPowerShell/PowerShell-RFC

RFC for expanded implicit line continuance feature

 If the risk is deemed to be too high because of the risk with named unary operat     Pros: The @ symbol is familiar since it is used for splatting. Also, PSReadline could recognize when you're opting in to use this at the command prompt, only running the command if you hit enter twice (although this wouldn't be used nearly as often at the prompt -- it's really for scripts).     Cons: Users lose the benefit of not having to use any characters for line continuance. +    Here's another alternative sigil to do the same thing that is a bit more literal:++    ```PowerShell+    New-ADUser ...

Good point. Thanks.

KirkMunro

comment created time in 8 hours

pull request commentPowerShell/PowerShell

Build(deps): Bump markdownlint from 0.11.0 to 0.14.2 in /test/common/markdown

CLA assistant check <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><br/>:x: dependabot[bot] sign now<br/><sub>You have signed the CLA already but the status is still pending? Let us recheck it.</sub>

dependabot[bot]

comment created time in 8 hours

delete branch PowerShell/PowerShell

delete branch : dependabot/npm_and_yarn/test/common/markdown/release/v6.2.1/markdownlint-0.14.1

delete time in 8 hours

PR closed PowerShell/PowerShell

Build(deps): Bump markdownlint from 0.11.0 to 0.14.1 in /test/common/markdown CL-BuildPackaging

Bumps markdownlint from 0.11.0 to 0.14.1. <details> <summary>Commits</summary>

  • 0b9b74c Update to version 0.14.1.
  • 608f875 Update MD033/no-inline-html to better handle inline code spans (fixes #182).
  • f003926 Update MD033/no-inline-html to ignore email autolinks (fixes #183).
  • ad8e400 Update to version 0.14.0.
  • 3960a4a Minor updates for MD047 and to remove a reference to io.js.
  • 994903b Update dependencies: eslint to 5.16.0, js-yaml to 3.13.1, typescript to 3.4.5...
  • bb6f9ba Fix .travis.yml after_script to use nyc for coverage reporting.
  • 1b8b156 Replace assign/clone helpers with object spread syntax.
  • 684416a Improve MD034/no-bare-urls range reporting (fixes #181).
  • dba6d49 Remove support for end-of-life Node.js version 6.
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

+13 -13

2 comments

2 changed files

dependabot[bot]

pr closed time in 8 hours

PR opened PowerShell/PowerShell

Build(deps): Bump markdownlint from 0.11.0 to 0.14.2 in /test/common/markdown

Bumps markdownlint from 0.11.0 to 0.14.2. <details> <summary>Commits</summary>

  • 95d23b9 Update to version 0.14.2.
  • 517fc61 Set options.handleRuleFailures=true in demo page for easier diagnostics.
  • 0f72bf0 Add options.handleRuleFailures for custom rule exceptions.
  • 0e5c446 Add link to V8 project to Examples section of README.md.
  • 61c92e5 Handle un-closed HTML comments in a way that does not trigger MD047/single-tr...
  • 0b9b74c Update to version 0.14.1.
  • 608f875 Update MD033/no-inline-html to better handle inline code spans (fixes #182).
  • f003926 Update MD033/no-inline-html to ignore email autolinks (fixes #183).
  • ad8e400 Update to version 0.14.0.
  • 3960a4a Minor updates for MD047 and to remove a reference to io.js.
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

+13 -13

0 comment

2 changed files

pr created time in 8 hours

pull request commentPowerShell/PowerShell

Build(deps): Bump markdownlint from 0.12.0 to 0.14.2 in /test/common/markdown

CLA assistant check <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><br/>:x: dependabot[bot] sign now<br/><sub>You have signed the CLA already but the status is still pending? Let us recheck it.</sub>

dependabot[bot]

comment created time in 8 hours

delete branch PowerShell/PowerShell

delete branch : dependabot/npm_and_yarn/test/common/markdown/markdownlint-0.14.1

delete time in 8 hours

PR closed PowerShell/PowerShell

Reviewers
Build(deps): Bump markdownlint from 0.12.0 to 0.14.1 in /test/common/markdown CL-BuildPackaging

Bumps markdownlint from 0.12.0 to 0.14.1. <details> <summary>Commits</summary>

  • 0b9b74c Update to version 0.14.1.
  • 608f875 Update MD033/no-inline-html to better handle inline code spans (fixes #182).
  • f003926 Update MD033/no-inline-html to ignore email autolinks (fixes #183).
  • ad8e400 Update to version 0.14.0.
  • 3960a4a Minor updates for MD047 and to remove a reference to io.js.
  • 994903b Update dependencies: eslint to 5.16.0, js-yaml to 3.13.1, typescript to 3.4.5...
  • bb6f9ba Fix .travis.yml after_script to use nyc for coverage reporting.
  • 1b8b156 Replace assign/clone helpers with object spread syntax.
  • 684416a Improve MD034/no-bare-urls range reporting (fixes #181).
  • dba6d49 Remove support for end-of-life Node.js version 6.
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

+5 -5

2 comments

2 changed files

dependabot[bot]

pr closed time in 8 hours

PR opened PowerShell/PowerShell

Build(deps): Bump markdownlint from 0.12.0 to 0.14.2 in /test/common/markdown

Bumps markdownlint from 0.12.0 to 0.14.2. <details> <summary>Commits</summary>

  • 95d23b9 Update to version 0.14.2.
  • 517fc61 Set options.handleRuleFailures=true in demo page for easier diagnostics.
  • 0f72bf0 Add options.handleRuleFailures for custom rule exceptions.
  • 0e5c446 Add link to V8 project to Examples section of README.md.
  • 61c92e5 Handle un-closed HTML comments in a way that does not trigger MD047/single-tr...
  • 0b9b74c Update to version 0.14.1.
  • 608f875 Update MD033/no-inline-html to better handle inline code spans (fixes #182).
  • f003926 Update MD033/no-inline-html to ignore email autolinks (fixes #183).
  • ad8e400 Update to version 0.14.0.
  • 3960a4a Minor updates for MD047 and to remove a reference to io.js.
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

+5 -5

0 comment

2 changed files

pr created time in 8 hours

issue commentPowerShell/PowerShell

Connect-MsolService : Could not load file or assembly 'System.IdentityModel, Version=4.0.0.0

Not sure the MSOL cmdlets were ever slated to be supported in PS Core? Part of the Connect-MsolService cmdlet involves popping a GUI window for the login; this is not particularly practical or possible at the moment in PS Core -- you'll note that in Core, even credential prompts are in the shell rather than being the WinPS-style credential popups. The MSOL module hasn't accounted for this...

This has probably already been reported, but searching on the UserVoice channels for this module/service is probably a good idea just in case. I'm not sure the MSOL module is still being maintained / updated.

nvtag

comment created time in 8 hours

issue commentPowerShell/Win32-OpenSSH

Enter-PSSession : The SSH client session has ended with error message: The SSH transport process has abruptly terminated causing this remote session to break.

Assuming you setup your server using steps at https://docs.microsoft.com/en-us/powershell/scripting/learn/remoting/ssh-remoting-in-powershell-core?view=powershell-6 ?

eliassal

comment created time in 8 hours

Pull request review commentPowerShell/PowerShell-RFC

RFC for expanded implicit line continuance feature

 If the risk is deemed to be too high because of the risk with named unary operat     Pros: The @ symbol is familiar since it is used for splatting. Also, PSReadline could recognize when you're opting in to use this at the command prompt, only running the command if you hit enter twice (although this wouldn't be used nearly as often at the prompt -- it's really for scripts).     Cons: Users lose the benefit of not having to use any characters for line continuance. +    Here's another alternative sigil to do the same thing that is a bit more literal:++    ```PowerShell+    New-ADUser ...

I'm not a fan of ... over @. I think the readability of ... is poor. My vision is bad and the ellipsis blends in with the line below it. Also it could be confused with (The Unicode ellipsis character). But I do like the idea of using something here and won't bike shed on it. I just want to call out the readability issue.

KirkMunro

comment created time in 14 hours

pull request commentPowerShell/PowerShell-RFC

RFC for expanded implicit line continuance feature

Thanks for responding @swngdnz.

In re: discounting my perspective - just like @GABeech - in my opinion, you have hand-waved my objections away and dismissed them as unimportant. No point in my taking any further effort.

Last part first: I am trying to take all perspectives into account, not be dismissive or wave away something as unimportant, with one exception: I think arguments about this not being necessary from scripters who have been using PowerShell for a long time may be missing the point. That doesn't make those perspectives unimportant, but I am trying to keep focus on users less experienced with PowerShell or new to PowerShell while absolutely considering backwards compatibility with the thousands of scripts and many tools that are that are out there.

For the comments about splatting, my counterpoint about using -{...} enclosures instead of -@{..} enclosures was simply that inside of the former, I can mix named parameters, positional parameters, and arguments in any order I want, wrapping wherever I like. In the latter, I'm given a hashtable structure which gives me named parameters and their values only.

e.g. This is more flexible for all inputs into a command.

someCommand -{
    42
    -c foo
    --please
}

# or

Get-ChildItem -{
    C:\
    -Filter *.ps*1
    -File
    -Recurse
}

# or even if we went with a sigil that told PowerShell to parse the command parameters/arguments in multi-line mode until it encountered a statement terminator or blank line

New-ADUser ...
    -Name 'Jack Robinson'
    -GivenName 'Jack'
    -Surname 'Robinson'
    -SamAccountName 'J.Robinson'
    -UserPrincipalName 'J.Robinson@enterprise.com'
    -Path 'OU=Users,DC=enterprise,DC=com'
    -AccountPassword (Read-Host -AsSecureString 'Input Password')
    -Enabled $true

This enclosure would presumably enforce hashtable syntax, which means no positional parameters, no arguments for external commands that don't have parameters at all (unless of course you also had -@(...)).

Get-ChildItem -@{
    LiteralPath = 'C:\' # I can't use a positional parameter here
    Filter = '*.ps*1'
    File = $true
    Recurse = $true
}

In my mind, the former is more flexible and allows for transition to/from that syntax with no changes whatsoever to the parameters/arguments used with the command.

KirkMunro

comment created time in 8 hours

issue commentPowerShell/PowerShell

Remove-PSDrive does not work correctly for Networked Drives created using -persist and -scope Global

Any updates on this issue? It's affecting my build pipelines. I have to use a New-PSDrive to add and net use to remove Network Drives. This inconsistency in my pipeline doesn't look great.

VortexUK

comment created time in 8 hours

issue commentPowerShell/vscode-powershell

PowerShell Integrated Console: "Value cannot be null" for missing mandatory parameter when debugging

Just installed a fresh copy of VSCode Insiders:

Version: 1.35.0-insider (user setup) Commit: a5536b8f5a16a10d859f3dec1e59701671bf069e Date: 2019-05-20T05:17:36.269Z Electron: 3.1.8 Chrome: 66.0.3359.181 Node.js: 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.17763

Then installed PowerShell preview 2.0.2

Placed the following into my settings.json:

{
    "terminal.integrated.shell.windows": "c:\\program files\\PowerShell\\6\\pwsh.exe",
    "powershell.powerShellExePath": "C:\\Program Files\\PowerShell\\6\\pwsh.exe"
}

Output was as it was before:

PS> .\TestParamNull.ps1
Value cannot be null.
Parameter name: type
At C:\Users\myuser\Documents\Development\PowerShell\TestParamNull.ps1:14 char:1
+ Get-Details
+ ~~~~~~~~~~~
+ CategoryInfo          : OperationStopped: (:) [], ArgumentNullException
+ FullyQualifiedErrorId : System.ArgumentNullException

Added this to my settings.json:

    "powershell.developer.featureFlags": [ "PSReadLine" ]

And now I get:

PS> .\TestParamNull.ps1

cmdlet Get-Details at command pipeline position 1
Supply values for the following parameters:
ClassVar:

So that does seem pretty conclusive! :)

gmckeown

comment created time in 9 hours

issue commentPowerShell/PowerShellGet

Proposal: PowerShellGet on 'Package Management Light'

@edyoung Let me clarify, my concern is with the breaking change of removing the PowerShellGet provider and PackageManagement module, not where the internal logic is located. I completely understand and agree with you that the current implementation having the logic in the PowerShellGet provider causes more problems than it solves.

I also agree with @alerickson that the best approach would be to implement the NuGet API directly in PowerShellGet module removing the dependency on PackageManagement allowing them to be developed independently.

To continue supporting the use case of managing modules and scripts from PackageManagement, the PowerShellGet provider would need to be updated. The work effort would be minimal as the only logic in the provider would be calling the PowerShellGet methods/functions and the required logic for the provider to function. This allows users to continue to have dedicated PowerShell cmdlets (*-Module, *-Script) as well as supporting PackageManagement cmdlets.

I believe this would solve the two main concerns you have with PackageManagement: nested runspace and extra complexity of having logic split between the provider and module. This is the approach I've gone with for my company's provider with great success. It's also the recommended approach for creating DSC resources. By having all the logic in the PowerShell module, the DSC resource will only have the required logic to support DSC.

@joeyaiello has PowerShell ever removed an in-box module outside the technical limitations of the 5.1 to 6.0 release? If so does that constitute a breaking change as the cmdlets are no longer present by default?

edyoung

comment created time in 9 hours

startedPowerShell/ActiveDirectoryCSDsc

started time in 9 hours

pull request commentPowerShell/PowerShell-RFC

RFC for expanded implicit line continuance feature

You are the one that bought up "PS 7 to rule them all", not me. In fact, PS 7 will NOT rule them all. That's the only (counter-)point I was making to your statement.

There is nothing wrong with enlightened self-interest. You are almost certainly bringing this RFC up because, at least at some level, it meets your needs. Nothing wrong with that, whether I agree with your RFC or not.

I've also been involved with PowerShell for 12+ years, since we were using Monad in Exchange 2007 TAP. But I am a scripter, not a developer. I'm a good scripter, but "just" a scripter. Pulling out a C# compiler is something I do as a very last resort.

You wrote:

which is restrictive, because you can also splat arrays as arguments into a command, and a hashtable wouldn't allow for that

what exactly do you mean?

@{
  a=1
  b='str'
  c=1,2,3,4,5
}
$a=1,2,3,4,5
@{
  a=1
  b='str'
  c=$a
}

Both of these work exactly as I expect and splat as I expect.

In re: discounting my perspective - just like @GABeech - in my opinion, you have hand-waved my objections away and dismissed them as unimportant. No point in my taking any further effort.

KirkMunro

comment created time in 9 hours

issue commentPowerShell/vscode-powershell

Preview extension: command 'PowerShell.GenerateBugReport' not found

This was an early bug if you opened an untitled workspace. This should be fixed in the current latest beta.

@fullenw1 are you still seeing this issue?

fullenw1

comment created time in 9 hours

issue commentPowerShell/PowerShell

Unable to load System.Data.SqlClient, Version 4.2.0.2

This assembly is shipped with PSCore6 and that version should be used. Older .NET Framework based ones are not compatible.

axelheer

comment created time in 9 hours

push eventPowerShell/PowerShell

Steve Lee (POWERSHELL)

commit sha 13f33472898bedef53080077fa03eab0aa335504

[package] address Dongbo and Aditya's feedback

view details

push time in 9 hours

Pull request review commentPowerShell/PowerShell

Port to .NET Core 3.0

-<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">+<Project ToolsVersion="15.0">   <Import Project="..\..\PowerShell.Common.props" />+   <PropertyGroup>     <Description>PowerShell on Windows top-level project</Description>     <AssemblyName>pwsh</AssemblyName>     <OutputType>Exe</OutputType>     <TieredCompilation>true</TieredCompilation>+    <TieredCompilationQuickJit>true</TieredCompilationQuickJit>+    <UseWindowsForms>false</UseWindowsForms>+    <UseWPF>false</UseWPF>

I suppose it would be cleaner without them. Will remove.

SteveL-MSFT

comment created time in 9 hours

pull request commentPowerShell/NetworkingDsc

DnsClientGlobalSetting: Fix SuffixSearchList Empty String Handling

Codecov Report

Merging #399 into dev will decrease coverage by <1%. The diff coverage is 60%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #399   +/-   ##
===================================
- Coverage    96%    95%   -1%     
===================================
  Files        27     27           
  Lines      2157   2176   +19     
===================================
+ Hits       2071   2080    +9     
- Misses       86     96   +10
X-Guardian

comment created time in 9 hours

pull request commentPowerShell/PowerShell-RFC

draft to enable pwsh to be used as login shell

SHELL needs to not be inherited. Proposal is to rename to -LoadEtcProfile

SteveL-MSFT

comment created time in 9 hours

pull request commentPowerShell/PowerShell-RFC

RFC for expanded implicit line continuance feature

@KirkMunro Honestly, at this point I've made my points. You seem content to hand-wave them away with "It's an insignificant risk" I don't agree, and have given some examples as to why (as well as alternative suggestions).

Quite honestly throughout this thread you have been pretty dismissive of concerns brought up (by myself and others) and I have no desire to continue trying to get my point across where it is obvious you don't want to take those concerns into consideration.

KirkMunro

comment created time in 10 hours

issue commentPowerShell/vscode-powershell

PowerShell Integrated Console: "Value cannot be null" for missing mandatory parameter when debugging

It's likely that this is fixed in the preview extension using PSReadLine

@TylerLeonhardt just confirmed that this does indeed work with PSReadLine

gmckeown

comment created time in 10 hours

issue commentPowerShell/vscode-powershell

PowerShell Integrated Console: "Value cannot be null" for missing mandatory parameter when debugging

It's likely that this is fixed in the preview extension using PSReadLine

gmckeown

comment created time in 10 hours

issue commentPowerShell/vscode-powershell

PowerShell Integrated Console: "Value cannot be null" for missing mandatory parameter when debugging

Looks like this occurs when a class is used as a mandatory parameter like this

gmckeown

comment created time in 10 hours

issue openedPowerShell/SharePointDsc

SPConfigWizard: Should not try to run wizard if other servers do not have the binaries installed yet

Details of the scenario you tried and the problem that is occurring

When other servers in the farm do not have the binaries installed yet, SPConfigWizard should not try to run the config wizard. This because the wizard first stops the IIS W3 processes and then fails because it cannot upgrade servers. Unfortunately it does not restart IIS and therefore causing downtime.

Verbose logs showing the problem

Suggested solution to the issue

Implement a check to see if the config wizard can be ran. The following code is able to do that, but has to be tested on 2013 and 2016 before implementing:

$farm = Get-SPFarm
$productVersions = [Microsoft.SharePoint.Administration.SPProductVersions]::GetProductVersions($farm)
$server = Get-SPServer $env:COMPUTERNAME
$serverProductInfo = $productVersions.GetServerProductInfo($server.Id);
if ($null -ne $serverProductInfo)
{
	$products = $serverProductInfo.Products;
	$statusType = $serverProductInfo.InstallStatus;
	if ($statusType -ne 0)
	{
		$statusType = $serverProductInfo.GetUpgradeStatus($farm, $server);
	}
}
else
{
	$statusType = [Microsoft.SharePoint.Administration.SPServerProductInfo+StatusType]::NoActionRequired;
}
Write-Host "StatusType: $statusType"

if ($statusType -ne "NoActionRequired")
{
    Write-Host "Upgrade not possible"
}

The DSC configuration that is used to reproduce the issue (as detailed as possible)

N/A

The operating system the target node is running

Windows 2016

Version of SharePoint that is used (e.g. SharePoint 2016)

SP2019

Version and build of PowerShell the target node is running

v5.1

Version of the DSC module that was used ('dev' if using current dev branch)

Dev

created time in 10 hours

issue commentPowerShell/vscode-powershell

PSReadLine is only available in the Preview Extension

@Jaykul please understand that GitHub issues represent open work items for us. More open issues means less focus (and therefore less ability to deliver features), and our workflow is that issues solved in master (i.e. preview) are closed. But because of the *nix console issue, we PSReadLine is not ready for stable release -- we were hoping it would be, but sometimes you hit hard problems in software. We're doing our best to work on it.

SydneyhSmith

comment created time in 10 hours

issue commentPowerShell/SharePointDsc

SPUserProfileSyncConnection: Test fails when specifying the Server parameter

Fixed in my next bugfix PR

ykuijs

comment created time in 10 hours

issue commentPowerShell/vscode-powershell

PSReadLine is only available in the Preview Extension

The issue that's been blocking this: https://github.com/PowerShell/vscode-powershell/issues/1936

It's turned out to require significant work to overcome, but we're doing our best to engineer around it.

SydneyhSmith

comment created time in 10 hours

issue openedPowerShell/SharePointDsc

SPUserProfileSyncConnection: Test fails when specifying the Server parameter

Details of the scenario you tried and the problem that is occurring

When specifying the Server parameter in SPUserProfileSyncConnection, the Test method always fails because the Get method always returns Server=null.

Verbose logs showing the problem

Suggested solution to the issue

Do not check the Server parameter in SP2016

The DSC configuration that is used to reproduce the issue (as detailed as possible)

N/A

The operating system the target node is running

Windows 2016

Version of SharePoint that is used (e.g. SharePoint 2016)

SP2016/2019

Version and build of PowerShell the target node is running

v5.1

Version of the DSC module that was used ('dev' if using current dev branch)

Dev

created time in 10 hours

pull request commentPowerShell/PowerShell-RFC

RFC for expanded implicit line continuance feature

@GABeech Regarding PR8938, I should add one more important detail: other programming languages that do not have line terminators and that do have continuance characters recognize and support (where possible) multiple multi-line chaining styles without using line continuance characters(e.g. ruby. This doesn't break PowerShell. It offers an additional pipeline chaining style that suits the needs of the scripter. It doesn't have to have full consensus across the community to be worth adding to the language when the risk is insignificant. Arguments for/against such styles are similar to arguments about indentation or bracing styles. Let the community do what they want when it makes sense to do so (and despite there being some opposition, it made sense to support this syntax in scripts which increases readability for many). I don't really know what else to say about that PR on this thread, other than I'm sorry you don't like it.

This RFC is related because it's about parameter-chaining, ideally without continuance characters (because they shouldn't need to be used unnecessarily), but possibly with a sigil or enclosure for continuance if it's absolutely necessary to have one. You keep hitting on readability and fundamentals. I keep going back to Intellisense plus tab expansion without having to use line continuance (or one of the alternatives presented in the RFC). Feels like we're talking around each other there, which is unfortunate.

I didn't decide I didn't like a certain style and then try to modify the way a language operates to fit my preferred style. To me, "I don't like the current options on line continuation" is not a significant enough reason to make a change like this.

And in saying so you're implying that I did? How about we stop with the finger pointing. Having worked very closely with the PowerShell community for over 12 years, I'm most certainly not creating PRs/RFCs just because it suits my own needs.

KirkMunro

comment created time in 10 hours

pull request commentPowerShell/PowerShell-RFC

draft to enable pwsh to be used as login shell

Haven't read the thread yet, but I thought it was worth noting here that we should ignore SHLVL (the shell level) and _ (the last run command, I believe?) Both will be inaccurate when we dump them out and copy them into PS.

SteveL-MSFT

comment created time in 10 hours

pull request commentPowerShell/PowerShell

Build(deps): Bump NJsonSchema from 9.14.1 to 10.0.0

@TravisEz13, this is the reminder you requested 1 hour ago

dependabot[bot]

comment created time in 10 hours

issue commentPowerShell/PowerShell

NullReferenceException in Get-Command

@rkeithhill Thanks for reporting the issue.

rkeithhill

comment created time in 10 hours

PR opened PowerShell/NetworkingDsc

DnsClientGlobalSetting: Fix SuffixSearchList Empty String Handling

Pull Request (PR) description

This PR fixes the incorrect test handling of an empty string for the SuffixSearchList parameter by modifying the DnsClientGlobalSetting Test-TargetResource code to be type specific, similar to the test code in the Firewall resource.

This Pull Request (PR) fixes the following issues

  • Fixes #398

Task list

<!-- To aid community reviewers in reviewing and merging your PR, please take the time to run through the below checklist and make sure your PR has everything updated as required.

Change to [x] for each task in the task list that applies to your PR.
For those task that don't apply to you PR, leave those as is.

-->

  • [ ] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
  • [ ] Resource documentation added/updated in README.md in resource folder.
  • [ ] Resource parameter descriptions added/updated in schema.mof and comment-based help.
  • [ ] Comment-based help added/updated.
  • [ ] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
  • [ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • [ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.
+141 -10

0 comment

3 changed files

pr created time in 10 hours

more