profile
viewpoint
Peter Dave Hello PeterDaveHello @nodejs @maintainers @transmission-remote-gui Taiwan https://www.peterdavehello.org/ Free & Open Source enthusiast. Interested in SysAdmin & Git ⚒⚙. A 👨🏼 who ♥️ Debian GNU/Linux 🐧 lives in 🇹🇼

g0v/moedict-webkit 356

萌典網站

breezestars/cord-tools 3

Tools and scripts about build CORD

PeterDaveHello/add-apt-ppa 3

🏎 Speedup ppa apt repo adding process 🕶

cdnjs/statuspage 1

The customisations made to our status page at status.cdnjs.com

cdnjs/swag-store 1

Help fund what we do at cdnjs and rock some awesome, custom designed swag with our tees, sweatshirts and comfy hoodies.

chitwanix/Kelvin 1

A scientific conversion Utility

chitwanix/loadshedding 1

Nepal Loadshedding Utility

extend1994/cdnjs 1

Free and Open Source Public Web CDN for web developer!

chitwanix/chitwanix.com 0

Official Site of Chitwanix.com

pull request commentnodejs/docker-node

Update node.js v13.x from 13.6.0 to 13.7.0

@LaurentGoderre thanks! no offense, I wonder for trivial and simple version update, maybe it'll be more effective if reviewer can also directly merge it after review approval to speed up the process? Thanks again.

PeterDaveHello

comment created time in a day

push eventnodejs/docker-node

Peter Dave Hello

commit sha 975ad7f092d362ade47f4cff6e2897de17be4cc5

Update node.js v13.x from 13.6.0 to 13.7.0 - https://nodejs.org/en/blog/release/v13.7.0/ - https://github.com/nodejs/node/releases/tag/v13.7.0 - https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md#13.7.0

view details

Peter Dave Hello

commit sha b927622b91df092f6a9c8491acb1be50eb73f4cc

Merge pull request #1205 from PeterDaveHello/update-node.js Update node.js v13.x from 13.6.0 to 13.7.0

view details

push time in a day

delete branch PeterDaveHello/docker-node

delete branch : update-node.js

delete time in a day

PR merged nodejs/docker-node

Update node.js v13.x from 13.6.0 to 13.7.0
  • https://nodejs.org/en/blog/release/v13.7.0/
  • https://github.com/nodejs/node/releases/tag/v13.7.0
  • https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md#13.7.0
+8 -8

0 comment

6 changed files

PeterDaveHello

pr closed time in a day

Pull request review commentnodejs/docker-node

feat: GitHub Actions docker files CI

 #!/usr/bin/env bats  @test "Test for node and version" {-  run docker run --rm -it node:"$full_tag" node -e "process.stdout.write(process.versions.node)"+  run docker run node:"$full_tag" node -e "process.stdout.write(process.versions.node)"

It's okay to keep it but the changes here should be separated into another PR.

nschonni

comment created time in 2 days

PR opened nodejs/docker-node

Update node.js v13.x from 13.6.0 to 13.7.0
  • https://nodejs.org/en/blog/release/v13.7.0/
  • https://github.com/nodejs/node/releases/tag/v13.7.0
  • https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md#13.7.0
+8 -8

0 comment

6 changed files

pr created time in 2 days

create barnchPeterDaveHello/docker-node

branch : update-node.js

created branch time in 2 days

Pull request review commentnodejs/docker-node

feat: GitHub Actions docker files CI

 #!/usr/bin/env bats  @test "Test for node and version" {-  run docker run --rm -it node:"$full_tag" node -e "process.stdout.write(process.versions.node)"+  run docker run node:"$full_tag" node -e "process.stdout.write(process.versions.node)"

No matter they are necessary or not, they're not related with switching to GitHub Actions, are they?

nschonni

comment created time in 2 days

Pull request review commentnodejs/docker-node

feat: GitHub Actions docker files CI

+name: 10 on alpine3.11++on:+  pull_request:+    paths:+      - 10/alpine3.11/Dockerfile++jobs:+  build:+    runs-on: ubuntu-latest+    steps:+      - uses: actions/checkout@v1+      - run: sudo apt-get install bats

Maybe need to add -y here for apt?

nschonni

comment created time in 4 days

Pull request review commentnodejs/docker-node

feat: GitHub Actions docker files CI

 #!/usr/bin/env bats  @test "Test for node and version" {-  run docker run --rm -it node:"$full_tag" node -e "process.stdout.write(process.versions.node)"+  run docker run node:"$full_tag" node -e "process.stdout.write(process.versions.node)"

I'm not sure how is this related with switching to GitHub Actions?

nschonni

comment created time in 4 days

issue commentnodejs/docker-node

@nodejs/docker I think we should invite @nschonni to join our team as an active contributor.

Need to ping some @nodejs admins to do so

nschonni

comment created time in 8 days

startedbswebdk/FFQueue

started time in 8 days

issue commenttransmission-remote-gui/transgui

GeoIP Data download 404!

@cavalli1021w please open an issue with environment details, thanks.

flyqieqq

comment created time in 9 days

startedXIU2/TrackersListCollection

started time in 11 days

issue commenttransmission-remote-gui/transgui

Upgrade GeoIP Lite to GeoLite2

@mS0gxokXEsg5ysJ7J79kzWiqO1fHgFA6ZR8eEls The workaround is working right now, not sure why if you need it? Actually, you can manually do that without a feature added.

PeterDaveHello

comment created time in 12 days

Pull request review commentnodejs/docker-node

Added instructions for submitting a version update PR (#1190)

 New **NPM** releases are not tracked. We simply use the NPM version bundled in t  **Yarn** is updated to the latest version only when there is a new Node.js SemVer PATCH release (unless Yarn has received a security update), and it's updated only in the branch with the new release, preferably in the same PR. The `update.sh` script does this automatically when invoked with a specific branch, e.g. `./update.sh 6.10`. +### Submitting a PR for a version update++If you'd like to help us by submitting a PR for a version update, please do the following:++1. [Fork this project.](https://help.github.com/en/github/getting-started-with-github/fork-a-repo)+2. [Clone the forked repository.](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/cloning-a-repository)+3. Create a branch for the update PR. For example, `git checkout master; git checkout -b version-update`.+4. Run `./update.sh`. You can see additional options by using accessing the built-in help documentation with `./update.sh -h`. This script will automatically update the appropriate files with the latest versions and checksums.+5. Commit the modified files to the `version-update` branch and push the branch to your fork.+6. [Create a PR to merge the branch from your fork into this project's master branch.](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork).

I suggest to use 1. only, so we don't need to maintain the numbers.

clayzermk1

comment created time in 12 days

startedICQFan4ever/MTProxyARMPatch

started time in 12 days

created tagPeterDaveHello/dockerized-shfmt

tag3.0.1

🐳 Dockerized "shfmt" 🐚 an amazing shell script formatter

created time in 13 days

push eventPeterDaveHello/dockerized-shfmt

Peter Dave Hello

commit sha 67fb23a089aa599ea777076d88c3de6f1fb6982f

Bump shfmt to v3.0.1

view details

push time in 13 days

push eventnodejs/docker-node

Laurent Goderre

commit sha 60915d2eb94e19a0d8500eb6f31c7ab1a4807fd7

Auto PR: Only keep the first line of the commit message Fixes issue highlited in #1183

view details

Peter Dave Hello

commit sha 2e7cc02b1be66901b453cbe92ecbaca226497bb9

Merge pull request #1184 from LaurentGoderre/fix-pr Auto PR: Only keep the first line of the commit message

view details

push time in 13 days

PR merged nodejs/docker-node

Auto PR: Only keep the first line of the commit message

Fixes issue highlited in #1183

+1 -1

2 comments

1 changed file

LaurentGoderre

pr closed time in 13 days

pull request commentnodejs/docker-node

Auto PR: Only keep the first line of the commit message

Sure!

LaurentGoderre

comment created time in 13 days

push eventnodejs/docker-node

Laurent Goderre

commit sha 3dbeefaa1b231aeddb7af7ef24bb83dd229d3e39

Revert "Fix update.sh invocation with unknown variant"

view details

Peter Dave Hello

commit sha 8162dba564224f057a81f3055debd9e6e1c661f3

Merge pull request #1192 from nodejs/revert-1161-improve-updatesh Revert "Fix update.sh invocation with unknown variant"

view details

push time in 13 days

delete branch nodejs/docker-node

delete branch : revert-1161-improve-updatesh

delete time in 13 days

PR merged nodejs/docker-node

Revert "Fix update.sh invocation with unknown variant"

Reverts nodejs/docker-node#1161

+1 -1

0 comment

1 changed file

LaurentGoderre

pr closed time in 13 days

issue commentnodejs/docker-node

Documentation request: how to update files for a new node version

BTW, update.sh is once mentioned here in https://github.com/nodejs/docker-node/blob/master/CONTRIBUTING.md, but it's not a proper documentation for it.

clayzermk1

comment created time in 13 days

issue closednodejs/docker-node

mv operation in node:10 is extremly slow

When comparing mv-ing directories, the official node:10 container is extremly slow. I could reproduce this with a variety of Docker versions.

Consider this Dockerfile as comparison for the alpine container:

FROM node:10-alpine
RUN mkdir /src
WORKDIR /src
RUN yarn init -y
# just an arbitary project with many dependencies to generate a large node_modules folder
RUN yarn add azure
# speed is as expected
RUN sh -c "time cp -r node_modules node_modules_cp && time mv node_modules node_modules_mv && exit 1"

# copy
#real    0m 14.18s
#user    0m 0.30s
#sys     0m 2.36s

# mv
#real    0m 8.06s
#user    0m 0.59s
#sys     0m 3.20s

As you can see, renaming (mv) is actually faster than cp. This was to be expected. Now let's compare this with node:10:

# same for node:10-slim
FROM node:10
RUN mkdir /src
WORKDIR /src
RUN yarn init -y
# just an arbitary project with many dependencies to generate a large node_modules folter
RUN yarn add azure
# why is copying so much faster than renaming?
RUN bash -c "time cp -r node_modules node_modules_cp && time mv node_modules node_modules_mv && exit 1"

# cp
#real    0m22.949s
#user    0m0.400s
#sys     0m3.070s

# mv
#real    10m35.163s
#user    0m0.490s
#sys     0m12.680s

As you can see, the copy process is a little bit slower. But renaming node_modules takes over 10 minutes!

I could reproduce the same behaviour with the official debian:stretch / debian:stretch-slim images when using the same folder.

closed time in 13 days

thewilli

issue commentnodejs/docker-node

mv operation in node:10 is extremly slow

Looks like it's not an docker-node issue, thanks for the report!

thewilli

comment created time in 13 days

issue commentnodejs/docker-node

CVE-2019-5094

I assume this one can be closed?

IdanAdar

comment created time in 13 days

issue commentnodejs/docker-node

Documentation request: how to update files for a new node version

Hi @clayzermk1,

Thanks for being interested in contribution to this project!

You're right that there is no documentation for the update process yet, actually we usually use the update.sh to do the job, it's usage can currently been revealed by the -h parameter, just as below:

~/FOSS/docker-node $ ./update.sh -h

  Update the node docker images.

  Usage:
    ./update.sh [-s] [MAJOR_VERSION(S)] [VARIANT(S)]

  Examples:
    - update.sh                   # Update all images
    - update.sh -s                # Update all images, skip updating Alpine and Yarn
    - update.sh 8,10              # Update version 8 and 10 and variants (default, slim, alpine etc.)
    - update.sh -s 8              # Update version 8 and variants, skip updating Alpine and Yarn
    - update.sh 8 slim,stretch    # Update only slim and stretch variants for version 8
    - update.sh -s 8 slim,stretch # Update only slim and stretch variants for version 8, skip updating Alpine and Yarn
    - update.sh . alpine          # Update the alpine variant for all versions
    - update.sh -t                # Update .travis.yml only

  OPTIONS:
    -s Security update; skip updating the yarn and alpine versions.
    -t Travis CI config update only
    -h Show this message

Would you like to try it and help us add some description in README.md? It'll be very helpful that somebody would like to help test the tools and add the missing document! Thank you!

clayzermk1

comment created time in 13 days

issue commentnodejs/docker-node

curl no longer shipped with node:slim

Hi @scooper91,

Thanks for the feedback, yes, I think we should at least have a place to describe breaking changes, but I'm not sure if we have enough resource to have a full changelog, would you like to open an issue for everyone who's interested in to discuss about the details? (I know that I can open it, but as a maintainer, I'd always like to encourage users to engage, contribute back, to make the project better and better!)

And yes, for simple changes, it's not required to have additional approvals, only breaking changes or potential breaking changes must have it.

scooper91

comment created time in 13 days

issue commentnodejs/docker-node

curl no longer shipped with node:slim

Hey @scooper91 @lukebatchelor @jjcm, sorry for the breaking changes here, I agree with @Starefossen that the breaking changes should be delivered with major version, no matter it's intended or not, it's not a good idea to ship breaking changes without users' expectation.

As what's done it's done, maybe it's not a must to revert #1128, IMO it's more important to prevent similar situation happened again (but I'm open to have a vote or discussion about revert it or not, if someone strongly suggest to).

So, instead of revert #1128, I'll suggest that known breaking changes need more approvals before being merged in the future, in this case, the PR received only one approval from the @nodejs/docker team members, which is a little bit not enough, we could ping the team for more discussion and approval next time, for breaking changes, I suggest we have approvals from half of the team members, I know I didn't show up in time in this PR, and because we all volunteered our spare time to maintain the repository, sometimes the process won't be very agile, we'll try our best to make it agile.

Anyone who's interested in helping us and the project, feel free to join the discussion of issues and pull requests, send and help review patches, I'd like to invite those contributors who're active in the project to join @nodejs/docker! (We currently have only 6 members, and only half of the members are very active)

scooper91

comment created time in 13 days

Pull request review commentnodejs/docker-node

Auto PR: Only keep the first line of the commit message

 function pr_payload() {   local body   local maintainers -  escaped_message="$(echo "${COMMIT_MESSAGE}" | sed -E -e "s/\"/\\\\\"/g")"+  escaped_message="$(echo "${COMMIT_MESSAGE}" | head -n1 | sed -E -e "s/\"/\\\\\"/g")"

I think it should be as previous review comment?

-    escaped_message="$(echo "${COMMIT_MESSAGE}" | head -n1 | sed -E -e "s/\"/\\\\\"/g")"
+    escaped_message="$(echo "${COMMIT_MESSAGE}" | head -n 1 | sed -E -e "s/\"/\\\\\"/g")"
LaurentGoderre

comment created time in 14 days

push eventnodejs/docker-node

Nick Schonning

commit sha be6e86a7f669c5378aff7b80b89430db2133e3fd

chore: Switch ECLint build to GitHub Actions

view details

Nick Schonning

commit sha 24fcebb1955cfe93e202c66eeecf6986f4f90132

chore: Switch DocTOC build to GitHub Actions Only executes when the TOC files have changed. Now also checks BestPractices.md

view details

Nick Schonning

commit sha cfc1388bb787200fc0e07326fb67103f29f29123

chore: Switch shfmt and shellcheck builds to GitHub Actions

view details

Nick Schonning

commit sha 34382c85bd6d4335d524748701c3ba1161ccea4a

chore: Switch markdown-link-check build to GitHub Actions

view details

Peter Dave Hello

commit sha ba024f05bc22fb68d3245af06980753dfbff20fc

Merge pull request #1179 from nschonni/github-actions GitHub actions

view details

push time in 15 days

PR merged nodejs/docker-node

GitHub actions

Pulls a few of the minor ones over to GitHub actions to reduce the Travis load. This also has a little better built in job filtering, so if affected files in the "path" values doesn't match, it doesn't even launch a job. I did some testing on the path executions on my fork, but I can add some dummy commits to show it if you want.

+80 -94

15 comments

6 changed files

nschonni

pr closed time in 15 days

pull request commentnodejs/docker-node

GitHub actions

Let's do it!

nschonni

comment created time in 15 days

push eventnodejs/docker-node

Tommi Vainikainen

commit sha 6c3fa2f322cbff89885a849a7dfe69972ce97a30

Fix update.sh invocation with unknown variant If update.sh was invoked with non-existing variant, it updated all variants. Change in_variants_to_update to return true always if second variant argument was not given, but not when given variant argument does not match to available variants.

view details

Peter Dave Hello

commit sha e088f69dce49ae9c09e2ea7a6a750a077a9b1c7b

Merge pull request #1161 from LaurentGoderre/improve-updatesh Fix update.sh invocation with unknown variant Co-authored-by: Tommi Vainikainen <thv@iki.fi>

view details

push time in 15 days

PR merged nodejs/docker-node

Fix update.sh invocation with unknown variant

If update.sh was invoked with non-existing variant, it updated all variants. Change in_variants_to_update to return true always if second variant argument was not given, but not when given variant argument does not match to available variants.

+1 -1

10 comments

1 changed file

LaurentGoderre

pr closed time in 15 days

pull request commentnodejs/docker-node

Fix update.sh invocation with unknown variant

Oh, I misunderstood, sorry!

LaurentGoderre

comment created time in 15 days

Pull request review commentnodejs/docker-node

Auto PR: Only keep the first line of the commit message

 function pr_payload() {   local body   local maintainers -  escaped_message="$(echo "${COMMIT_MESSAGE}" | sed -E -e "s/\"/\\\\\"/g")"+  escaped_message="$(echo "${COMMIT_MESSAGE}" | sed -E -e "s/\"/\\\\\"/g" | head -n1)"

and maybe can put head before sed?

LaurentGoderre

comment created time in 15 days

Pull request review commentnodejs/docker-node

Auto PR: Only keep the first line of the commit message

 function pr_payload() {   local body   local maintainers -  escaped_message="$(echo "${COMMIT_MESSAGE}" | sed -E -e "s/\"/\\\\\"/g")"+  escaped_message="$(echo "${COMMIT_MESSAGE}" | sed -E -e "s/\"/\\\\\"/g" | head -n1)"

Let's keep the styling like the one in generate-stackbrew-pr.sh?

-    escaped_message="$(echo "${COMMIT_MESSAGE}" | sed -E -e "s/\"/\\\\\"/g" | head -n1)"
+    escaped_message="$(echo "${COMMIT_MESSAGE}" | sed -E -e "s/\"/\\\\\"/g" | head -n 1)"
LaurentGoderre

comment created time in 15 days

issue commentkeycdn/cache-enabler

Brotli or zopfli support

@picasticks yes, zopfli is for some special cases ;)

PeterDaveHello

comment created time in 15 days

delete branch PeterDaveHello/travis-cookbooks

delete branch : update-shellcheck-v0.7.0

delete time in 16 days

pull request commenttravis-ci/travis-cookbooks

Update ShellCheck from v0.6.0 to v0.7.0

Sure, thanks.

PeterDaveHello

comment created time in 16 days

push eventPeterDaveHello/travis-cookbooks

Aaron Chong

commit sha 920b3968d298a801e58b097e067fa519a9d38b38

Fix RuboCop offenses: Style/MultilineWhenThen

view details

Aaron Chong

commit sha 731ff0c8e4853b634b84ba1fd5155e34d567beac

Fix RuboCop offenses: Lint/SendWithMixinArgument

view details

Jordan Harband

commit sha 13b3c4fd28cf07e39a7939c54259246da3d523ea

Merge pull request #1069 from acjh/patch-2 Fix RuboCop offenses for RuboCop 0.75.1

view details

Peter Dave Hello

commit sha 5603ae6af84b5a3d8756b6556e682727cd3c7e0c

Update ShellCheck from v0.6.0 to v0.7.0

view details

push time in 16 days

pull request commentnodejs/docker-node

Fix update.sh invocation with unknown variant

This doesn't seem to work

Before this change:

./update.sh 8 alpine3.9,none

Updating version 8...
8/alpine3.9/Dockerfile is already up to date!
Done!

./update.sh 8 none

Updating version 8...
8/jessie/Dockerfile is already up to date!
8/jessie-slim/Dockerfile is already up to date!
8/stretch/Dockerfile is already up to date!
8/stretch-slim/Dockerfile is already up to date!
8/buster/Dockerfile is already up to date!
8/buster-slim/Dockerfile is already up to date!
8/onbuild/Dockerfile is already up to date!
8/alpine3.10/Dockerfile is already up to date!
8/alpine3.9/Dockerfile is already up to date!
Done!

After this change:

./update.sh 8 alpine3.9,none

Updating version 8...
8/alpine3.9/Dockerfile is already up to date!
Done!

./update.sh 8 none

./update.sh: line 96: update_variants[@]: unbound variable

I thought update_variants[@]: unbound variable is after the change?

LaurentGoderre

comment created time in 17 days

Pull request review commentnodejs/docker-node

GitHub actions

+name: Test Whitespace and line endings++on: [pull_request]++jobs:+  eclint:+    name: Editor Config check+    runs-on: ubuntu-latest+    steps:+    - uses: actions/checkout@v2+    - uses: snow-actions/eclint@v1.0.1

No, it wasn't pinned before, but we have the ability to pin it any time, by using the action, we lost the control of it.

nschonni

comment created time in 17 days

delete branch PeterDaveHello/transmission-rss

delete branch : patch-1

delete time in 18 days

Pull request review commentnodejs/docker-node

GitHub actions

+name: Check Shell scripts++on:+  pull_request:+    paths:+      - "**/*.sh"++jobs:+  shfmt:+    runs-on: ubuntu-latest+    steps:+      - uses: actions/checkout@v1+      - run: docker run -v "$(pwd)":/sh -w /sh peterdavehello/shfmt:3.0.0 shfmt -sr -i 2 -l -w -ci .

Though it looks pretty safe in this case, I'm not sure the migration should also contains version bump(from v2.6.3 to v3.0.0), thought we can make the changes more clean and clear, separate the migration and the dependency update?

nschonni

comment created time in 18 days

Pull request review commentnodejs/docker-node

GitHub actions

+name: Test Whitespace and line endings++on: [pull_request]++jobs:+  eclint:+    name: Editor Config check+    runs-on: ubuntu-latest+    steps:+    - uses: actions/checkout@v2+    - uses: snow-actions/eclint@v1.0.1

Sorry if I didn't make it clear in the last comment, this also looks the case we can't directly control the eclint version in case we need? (like upstream changes default behavier or something like that breaks the build)

nschonni

comment created time in 18 days

pull request commenttravis-ci/travis-cookbooks

Update ShellCheck from v0.6.0 to v0.7.0

hmmm, I'm not sure if those errors are related to the changes here :thinking:

PeterDaveHello

comment created time in 18 days

pull request commentnning/transmission-rss

Enable syntax highlight in README code blocks

Sure, it's done.

PeterDaveHello

comment created time in 18 days

push eventPeterDaveHello/transmission-rss

Peter Dave Hello

commit sha 97e145b58e105169c2360da420be5603db511786

Enable syntax highlight in README code blocks This will help improve readability of README.md ;)

view details

push time in 18 days

startedlupus78/feedtransmission

started time in 19 days

PR opened nning/transmission-rss

Enable syntax highlight in README code blocks

This will help improve readability of README.md ;)

+104 -82

0 comment

1 changed file

pr created time in 19 days

push eventPeterDaveHello/transmission-rss

Peter Dave Hello

commit sha b3f1cc3fb71bc10ec5073f1d8d18fd21bd9f1575

Enable syntax highlight in README code blocks This will help improve readability of README.md ;)

view details

push time in 19 days

fork PeterDaveHello/transmission-rss

Adds torrents from RSS feeds to Transmission web frontend

fork in 19 days

PR opened travis-ci/travis-cookbooks

Update ShellCheck from v0.6.0 to v0.7.0

Ref: https://github.com/koalaman/shellcheck/releases/tag/v0.7.0

+3 -3

0 comment

1 changed file

pr created time in 20 days

create barnchPeterDaveHello/travis-cookbooks

branch : update-shellcheck-v0.7.0

created branch time in 20 days

push eventPeterDaveHello/travis-cookbooks

Arya Irani

commit sha b7ca27ffd52b8383fb4cb5457ff6df855186f05e

bump travis_sbt_extras version for sbt 1.x support Travis CI uses paulp/sbt-extras as its sbt launcher. sbt-extras versions before May 9, 2016 don't support sbt 1.x (they don't know the right URL to download updates from), and the version on Travis is from Aug 19, 2015. This PR updates the sbt-extras version to the latest.

view details

getong

commit sha c787fd74b1ecd52605a4c2e93804441c64a55d66

update rebar3 to 3.6.1

view details

getong

commit sha 168aca05d06c7fc4caa5384c777509f189409ba2

rebar3 3.6.2

view details

Peter Dave Hello

commit sha 5856b8a611d1d63670d19effe71bbd3449c641e4

Update shfmt to v2.6.3

view details

Peter Dave Hello

commit sha 80e4fd984498455a68c64eda7d8dc0479802dc73

Update Maven from v3.5.4 to v3.6.0

view details

Peter Dave Hello

commit sha 7a4112855b6c19779d3be73555c82250e700167d

Drop deprecated `sudo` config in .travis.yml

view details

Joep van Delft

commit sha 68ea00476e0c62fcd9693f4b4b5831443a87596c

Merge pull request #1033 from PeterDaveHello/update-shfmt-to-v2.6.3 Update shfmt to v2.6.3

view details

Joep van Delft

commit sha a34d7aa99ee67d4535529340cc6285d4a079632d

Merge branch 'master' into Update-CI-setting

view details

Joep van Delft

commit sha c3642aac8c246659a3efdc884f3ec67b13cab6c2

Merge pull request #1038 from PeterDaveHello/Update-CI-setting Drop deprecated `sudo` config in .travis.yml

view details

Joep van Delft

commit sha cb0fc0bfed495ae588d79b1e5b8b54031423e610

Merge branch 'master' into update-maven-v3.6.0

view details

Joep van Delft

commit sha 946ffa881692ce27db07b63f7db8e22862e79713

Merge pull request #1035 from PeterDaveHello/update-maven-v3.6.0 Update Maven from v3.5.4 to v3.6.0

view details

Joep van Delft

commit sha 2a2a92745c18562a16de030b7f9262f20a2d4670

php aliases

view details

Peter Dave Hello

commit sha 896c1e86ccbe3642173501fd377646c7428f6796

Update Gradle from v4.10.2 to v5.1.1

view details

Peter Dave Hello

commit sha a5e0d3caaf213fadc6ff45eed28c1d677357659a

Update Neo4j from v3.4.7 to v3.5.2

view details

Joep van Delft

commit sha 9595f0a5316a2bc9b15f1e8a07e58cd07b97167c

Merge pull request #1036 from PeterDaveHello/update-neo4j Update Neo4j from v3.4.7 to v3.5.2

view details

Joep van Delft

commit sha 047050f7a6ce29265c757ba05c2afd0591f13e05

Merge branch 'master' into update-gradle-to-v5.1.1

view details

Akhilesh Bhople

commit sha 67ac072caa55ed691ec4c9e099c11609c9305784

Update installation of openjdk-r repo

view details

Akhilesh Bhople

commit sha 3134de6c39604baf23b231572dba7575cf7b51fa

update openjdk-r.rb recipe

view details

Joep van Delft

commit sha 5a634d9e3cba098f817686c3fc0cfe207e88bb54

Merge pull request #1040 from akhileshbhople/master fix openjdk-r installation

view details

Joep van Delft

commit sha 70dbfcf93693f350721adc22617c0aaf3b88b302

Set git wire protocol to version 2

view details

push time in 20 days

push eventPeterDaveHello/Ubuntu-Debian-Templatize

Peter Dave Hello

commit sha 05ad7051144480bbe12dfd9c7ffb739bc6a5ee46

[Travis CI] Remove deprecated `sudo:` setting

view details

Peter Dave Hello

commit sha 720b58c17669ace64ae001c453943fcd8b19c1d6

[Travis CI] Upgrade CI environment to Ubuntu 18.04

view details

Peter Dave Hello

commit sha 40a94578a06365453c4ad7e26055f5c50c4c757d

[Travis CI] Switch CI environment to minimal image

view details

Peter Dave Hello

commit sha c6779921eba1c4c083f771c53d0c1e398875f480

[Travis CI] Remove manuall shellcheck installation

view details

push time in 20 days

push eventPeterDaveHello/Ubuntu-Debian-Templatize

Peter Dave Hello

commit sha 48cc3097febf87a3b15926a2a9920d5b9349dd01

Add missing systemd journal log clean up

view details

push time in 20 days

Pull request review commentnodejs/docker-node

GitHub actions

+name: Check Shell scripts++on:+  pull_request:+    paths:+      - "**/*.sh"++jobs:+  sh-checker:+    runs-on: ubuntu-latest+    steps:+      - uses: actions/checkout@v1+      - name: Run the sh-checker+        uses: luizm/action-sh-checker@v0.1.0

I vote for more precise control, to make sure the build won't be blocked by upstream changes, thanks.

nschonni

comment created time in 20 days

Pull request review commentnodejs/docker-node

GitHub actions

+name: Check Shell scripts++on:+  pull_request:+    paths:+      - "**/*.sh"++jobs:+  sh-checker:+    runs-on: ubuntu-latest+    steps:+      - uses: actions/checkout@v1+      - name: Run the sh-checker+        uses: luizm/action-sh-checker@v0.1.0

Is it possible to control the version of shfmt as it was in Travis CI?

nschonni

comment created time in 21 days

pull request commentnodejs/docker-node

GitHub actions

Looks good from a quick check :+1:

I wonder if all the commits can use the same commit message style as the first commit: chore: Use GitHub Action for ECLint as it clearly mention enable GitHub Action for the task?

(Add Shell Script checking Action clearly mentions Add but it actually also remove the Travis CI job, maybe switch to would be more precisely?)

nschonni

comment created time in 21 days

push eventnodejs/docker-node

Nick Schonning

commit sha c06bc079b0676060ace0538e6e10aa38fdc77917

chore: Remove Node 8

view details

Nick Schonning

commit sha 6b3ebcd02674c98dff18d4e55bfad3ab4eab9777

chore: Remove Node 8 ChakraCore

view details

Nick Schonning

commit sha b7a069e8334efb0522171c0b191b5515fe50cac1

chore: Remove OnBuild variant

view details

Peter Dave Hello

commit sha 44c21775afa12a4db1dfb3073249ba5ccb333e13

Merge pull request #1177 from nschonni/node-8-eol chore: Remove EOL Node 8 images

view details

push time in 21 days

PR merged nodejs/docker-node

chore: Remove EOL Node 8 images

Closes #1171

+11 -983

0 comment

28 changed files

nschonni

pr closed time in 21 days

issue closednodejs/docker-node

Remove 8 in early January for EOL

Just opening an issue since it is the end of the "onbuild" variant, so there is a few things to clean up when 8 hits EOL https://github.com/nodejs/docker-node/search?q=onbuild&unscoped_q=onbuild

  • [ ] Remove "8" folder
  • [ ] Remove array_8 from generate-stackbrew-library.sh
  • [ ] Remove onbuild Dockerfile-onbuild.template
  • [ ] Remove onbuild section from README
  • [ ] Remove onbuild from architectures
  • [ ] Remove onbuild from update.sh
  • [ ] Remove onbuild from test-build.sh

I think the Chakracore 8 should probalby be removed, but maybe that is a different EOL/cycle

closed time in 21 days

nschonni

pull request commentnodejs/docker-node

Fix update.sh invocation with unknown variant

I mean update_variants[@]: unbound variable

LaurentGoderre

comment created time in 21 days

pull request commentnodejs/docker-node

docs: update contributing to mentions security yarn releases

Let's get this done :+1:

SimenB

comment created time in 21 days

push eventnodejs/docker-node

Simen Bekkhus

commit sha 6f32733d774510ee96ffacbdb84d2967419d2b32

docs: update contributing to mentions security yarn releases

view details

Peter Dave Hello

commit sha 3951ce41d920b7554ddd250f62fffe4f2aa4feed

Merge pull request #1173 from nodejs/SimenB-patch-1 docs: update contributing to mentions security yarn releases

view details

push time in 21 days

delete branch nodejs/docker-node

delete branch : SimenB-patch-1

delete time in 21 days

PR merged nodejs/docker-node

docs: update contributing to mentions security yarn releases

@PeterDaveHello brought up a great point in https://github.com/nodejs/docker-node/pull/1170#discussion_r359206734 - our current policy states that we only update yarn when there's new releases of node. I somewhat regret just moving on instead of backing out those changes and discussing. However, I think we should update it on security updates, so here's a PR with a policy update

+1 -1

5 comments

1 changed file

SimenB

pr closed time in 21 days

startedseriyps/mtproto_proxy

started time in 22 days

startedvladikoff/netflix-1080p-firefox

started time in 22 days

startedTelegramMessenger/MTProxy

started time in 23 days

MemberEvent

created repositoryKKBOX/mirex2018-english-lyrics-alignment

created time in 24 days

delete branch PeterDaveHelloKitchen/percona-xtradb-cluster

delete branch : Debian-init-script-fails-socket-not-specified

delete time in a month

created tagPeterDaveHello/docker-yamllint

tag1.20.0

🐳 Dockerized yamllint with proper versioning, a linter for YAML files.

created time in a month

pull request commentpercona/percona-xtradb-cluster

Fix Debian init script fails when socket not specified

BTW, if you guys will like to receive more contributions, I'd be happy to help improve the shell scripts here.

PeterDaveHello

comment created time in a month

pull request commentpercona/percona-xtradb-cluster

Fix Debian init script fails when socket not specified

Sure, it's done, thanks!

PeterDaveHello

comment created time in a month

issue openedPeterDaveHello/ipinfo.tw

Significant Changes to Accessing and Using GeoLite2 Databases

https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/

created time in a month

push eventPeterDaveHello/Awesome-website-under-construction

Peter Dave Hello

commit sha 3fa0755f49e977c67f5a3404f5f7bdc5ed51b782

init

view details

push time in a month

push eventPeterDaveHello/Awesome-website-under-construction

Peter Dave Hello

commit sha c39b8dc832c9aa18fc079e5e4cda45b72874716a

init

view details

push time in a month

push eventPeterDaveHello/Awesome-website-under-construction

Peter Hsu

commit sha 6d16f5532fe374d5aa219bc1c19f4dd92464fd1f

init

view details

push time in a month

create barnchPeterDaveHello/Awesome-website-under-construction

branch : master

created branch time in a month

created repositoryPeterDaveHello/Awesome-website-under-construction

Collection of Website Coming Soon / Under Construction page / templates

created time in a month

PR opened MicrosoftLearning/AZ-203-DevelopingSolutionsforMicrosoftAzure

Remove duplicated "+ Add field" action in AZ-203_06_lab_ak.md

Location

  • Course: 06
  • Exercise: 01
  • Task: 04
  • Step[s]: 6~9

Proposed Changes

  • Remove additional "+ Add field"

Those "+ Add field" seem wrong to me but please also confirm that before merging.

+0 -8

0 comment

1 changed file

pr created time in a month

push eventPeterDaveHello/ipinfo.tw

Peter Dave Hello

commit sha a51f36c93fcde65e138f57c6aab127e02e23e7f2

Decrease Docker healthcheck start period to 5 sec

view details

push time in a month

startedmacvk/dnsleaktest

started time in a month

pull request commentnodejs/docker-node

Add missing Alpine 3.9 image for node.js v13

@nodejs/docker I think we should invite @nschonni to join our team as an active contributor.

PeterDaveHello

comment created time in a month

push eventPeterDaveHello/tor-socks-proxy

Peter Dave Hello

commit sha b896de5b6ce996500204108678a568fe54f217a5

Add Docker restart parameter in README example

view details

Peter Dave Hello

commit sha cf437c0152dc8b731b16c41224aefe36b66ebcf6

Update healthcheck target URL to Facebook's Tor onion service

view details

push time in a month

delete branch PeterDaveHello/qrious

delete branch : patch-1

delete time in a month

delete branch PeterDaveHello/deluge

delete branch : optimize-png-imgs

delete time in a month

pull request commentrequest/request

Use Doctoc to maintain README "Table of contents"!

@reconbot would you like to take a look? Thanks :)

PeterDaveHello

comment created time in a month

PR opened nodejs/docker-node

Add missing Alpine 3.9 image for node.js v13

Not sure why I missed it, but I think we sould add it back.

cc #1135

+117 -7

0 comment

4 changed files

pr created time in a month

more