profile
viewpoint

BetterThanTomorrow/calva 715

Clojure & ClojureScript Interactive Programming for VS Code

PEZ/clerk 59

In-page navigation (scrolling) for ClojureScript SPAs.

BetterThanTomorrow/calva-fmt 33

VS Code extension for formatting Clojure & ClojureScript code

BetterThanTomorrow/calva-paredit 13

Paredit extension for Visual Studio Code

PEZ/awesome-krell-project 4

A ClojureScript React Native (cljsrn) Example Project using Krell

PEZ/Bots 4

My Robocode Bots

PEZ/Bootstrap-Skin 3

Bootstrap Skin for MediaWiki. Bootstrap is an excellent toolkit by Twitter. This is a MediaWiki skin based off of that template.

olled/NodeJS-Server 2

A try-out of the NodeJS arch for a log server

PEZ/ALToastView 2

Android-like toast messages for iOS

PEZ/appirater 1

A utility that reminds your iPhone app's users to review the app.

issue commentBetterThanTomorrow/calva

Add an auto scroll lock feature to the REPL output window

Thanks for insisting, @stefan-toubia.

I think it can be approached in steps. The first concern is that the user needs some way to freeze the scrolling as new output arrives. Let's take care of that first.

When we have that in place... I can agree that iTerm solves this quite nicely. I have never been annoyed but that behaviour. So if that can be implemented without quirks, I think I'd be for it. As I wrote in slack, I have deemed it to be hard to implement, but maybe it isn't.

stefan-toubia

comment created time in 5 days

issue commentBetterThanTomorrow/calva

Idea: Integrate kibit

I think this would be a really nice feature. The advantage of keeping it in Calva is that the user doesn't need to install more stuff, but there is definitely a case for doing it standalone. I haven't thought the implementation through at all, but there might be that Calva has some utilities that make it easier to implement and then that would be a reason for that path.

You can definitely start out in a separate extension. It is super easy to move it into Calva later.

If you go the separate extension way, we can then choose to bundle it with Calva or at least let the Calva user's know about the extension somehow.

svdo

comment created time in 5 days

issue commentBetterThanTomorrow/calva

Paredit hotkeys not working on macOS VSCode

@fgerard I’m afk. But see if you can find the info at calva.io

dijonkitchen

comment created time in 5 days

issue commentBetterThanTomorrow/calva

Add an auto scroll lock feature to the REPL output window

Thanks for the feature request.

I can see the need for scroll locking, but I really don’t like the way the vs code output channel does it. It is horrible and I constantly has to fight it. The button is the only thing about it that I like, actually.

I suggest this is addressed with a toggled setting, like in a terminal of old where ctrl+s would lock scrolling and ctrl+q would unlock. We will notice if a visual clue is needed. No automagic stuff, please.

stefan-toubia

comment created time in 5 days

pull request commentBetterThanTomorrow/calva

Allow toggling keyboard shortcuts

This is awesome. I realise it can feel like you are torn In all different directions @wcerfgba , but I think Calva benefits from us all engaging and providing perspectives. I vote for merging now.

Many thanks for the help @wcerfgba , I hope you find more things you want to improve.

wcerfgba

comment created time in 8 days

delete branch BetterThanTomorrow/calva-docs

delete branch : gh-pages

delete time in 9 days

release BetterThanTomorrow/calva

v2.0.125

released time in 10 days

pull request commentBetterThanTomorrow/calva

Show the REPL/output with cursor at the bottom (#792)

I don't think we can remove the scrolling in that append method. When the window is not visible it should still be scrolled when made visible. So my guess is that this will not work when the output window is in the same tab group as the file where the evaluation happens. I'd be happy to be wrong about it, though. No fan of state. 😄

glebovmaksim

comment created time in 10 days

issue commentBetterThanTomorrow/calva

Show the REPL/output with cursor at the bottom

I'd be fine with that the window always scrolls to bottom when opened via the command. Not sure what you mean by removing state, but if it works like you describe, I like it.

glebovmaksim

comment created time in 10 days

issue commentBetterThanTomorrow/calva

Test runner output only partially commented

I'm lazy, so haven't checked before suggesting: Make an issue for the extra parens things. They have bit me many times, but lately I have finally learnt to ignore them, which is totally the wrong solution.

stefan-toubia

comment created time in 10 days

pull request commentBetterThanTomorrow/calva

Allow toggling Paredit function independently of mode

I also think it's best to keep it at just the paredit shortcuts, so the user can keep them off if desired and still do things like jack-in and evaluate forms.

Interesting. I am happy to leave it as it is, since this is fine for my workflow (and means I don't have to change the PR too much 😛 ) so long as you are both happy with it from a philosophical and UX perspective. 😃

Yeah interesting. 😄 If I understand the use case correctly this is to very temporarily move shadowing shortcuts away, while the user does a few things and then they would be switched back again. The thing is, we don't know which shortcuts are in the way. Maybe some extension uses ctrl+enter or alt+enter for something? Then moving just the paredit shortcuts away wouldn't do the trick. All or none, is my take on it.

Is it best to have a toggle button for this in the status bar? I wonder the frequency at which users would actually need to toggle it. If infrequent, then it makes sense to just have it as a checkbox in settings. If you find yourself wanting to toggle it often, then the status bar button makes sense.

Personally I want to toggle it often and easily, so I would use the keybinding I assigned to the command, rather than clicking a statusbar button, but I think it is nice to provide a visual indication of the modality -- cf vi with no indication of insert/command mode and vim where it indicates --INSERT-- in the statusbar. 😃

I think this is not a very common need. Giving it a place of its own in the status bar is a bit too much. A keyboard shortcut is perfect. It was just that the paredit mode icon reflected the disablement that got me to want to use it to toggle back. I think it just leaving that icon displaying the keymap info is OK. Grey it out, but keep it toggling between keymaps.

wcerfgba

comment created time in 10 days

issue commentBetterThanTomorrow/calva

Test runner output only partially commented

While I think that this last thing should go in an issue of its own, I can't resist commenting on it. 😄 Yes, it is possible. But it would need to be done via the highlight module, I can talk you through it some on slack or something, if you want to take it on.

stefan-toubia

comment created time in 11 days

issue commentBetterThanTomorrow/calva

Test runner can't find tests under cursor when using a custom test macro

Thanks, we'll need to revisit this, it seems.

stefan-toubia

comment created time in 11 days

pull request commentBetterThanTomorrow/calva

Allow toggling Paredit function independently of mode

Hello. Thanks for this PR! I had to ponder this a bit to decide whether I thought it is a good idea or not. My default reaction to new settings is that they are bad. 😄 (Only half joking here, as @bpringe can tell you). Anyhow, I've decided that this might actually be a good thing to support: To quickly stove away some troublesome shortcuts and then switch them back back in again. I'll let @bpringe chime in as well.

Here are some thoughts:

I wonder about whether this really is a paredit thing, or rather a Calva in general thing. The problem is that some of Calva's shortcuts are overriding shortcuts that someone might be used to using for something else, right? That it is Calva Paredit that register most of those is due to the fact that Paredit registers the bulk of Calva's shortcuts, and that some of the Paredit shortcuts are of the ”simple” type, with high risk for conflict. So maybe we should name the option ”calva keyboard shortcuts enabled” (or some such) and let the command toggle them all?

Also the current name makes it sound a bit like you are enabling/disabling paredit, which you are not, just the shortcuts. (I have both glanced at the code changes and tried it, so I know that Paredit is still enabled when this option is disabling the shortcuts 😄).

When toggling the shortcuts off, the paredit button in the status bar shows this nicely. But I can't toggle it back on using that button, which seems a bit odd to me. But I also see how this button isn't used to disable the shortcuts, so it makes sense too. 😄 Your thoughts on this, @wcerfgba and @bpringe ?

As for the code changes, I think they look clean and also improves the code a bit, Kaizen style.

wcerfgba

comment created time in 11 days

issue commentBetterThanTomorrow/calva

Not able to escape read-line in the output window

We should make dismissal of the input picker send cttl+z, probably.

pedro-w

comment created time in 11 days

issue commentrksm/clj-suitable

shadow-cljs support broken in 2.10.+

A note to Calva users. I just realized that this also kills cljs completions, if the Calva: Enable JSCompletion setting is on. While this issue is not resolved, disable this setting for the project.

thheller

comment created time in 12 days

issue commentBetterThanTomorrow/calva

Format commands fails with this specific scenario

It's the namespaced keyword. https://github.com/weavejester/cljfmt/issues/106

Might be about to be solved upstream, or maybe even solved, if we piece together the PRs and such.

bpringe

comment created time in 14 days

issue commentBetterThanTomorrow/calva

Don't require the `alias` key in deps.edn to jack-in

We don't save any state about the project files. But we do save state about the user choices made in those jack-in/connect prompts. I haven't checked the code yet, but that is a clue anyway. My guess is that we have an assumption about the aliases key being present, that is somehow dodged by the prompt/quick-pick state.

beders

comment created time in 23 days

pull request commentBetterThanTomorrow/calva-docs

Added figwheel-main-webpack-deps docs

Hello. Sorry for late response. I had dropped this ball a bit. This is super great!

gmp26

comment created time in 25 days

push eventBetterThanTomorrow/calva-docs

gmp26

commit sha 8f17199df776a7a788c6cbb01853ef47d23b2a78

added figwheel-main-webpack

view details

gmp26

commit sha 017d903ec58196392ab319790b7ec35a59a49a49

fix typos and formatted deps

view details

Mike Pearson

commit sha 5745b0fb2b1e20265ce19a35c208be1b500503bd

Merge pull request #1 from gmp26/feature/figwheel-main-webpack Feature/figwheel main webpack

view details

Peter Strömberg

commit sha 9d84d774d22250839bb7874890de85f6e6f010bc

Merge pull request #11 from gmp26/master Added figwheel-main-webpack-deps docs

view details

push time in 25 days

issue commentBetterThanTomorrow/calva

Calva REPL evaluates to last read atomic expr only -- expr ingored

Hello. Which commands are you using?

thelazydogsback

comment created time in a month

release BetterThanTomorrow/calva

v2.0.124

released time in a month

push eventPEZ/pez.github.io

Peter Strömberg

commit sha b2b113e5f86da44fe74f28f3d86e8e0cca1fc1b2

Link to netlify

view details

push time in a month

push eventPEZ/pez.github.io

Peter Strömberg

commit sha da16146cd79ce6d3b17d302ff1d06ef200289061

typo

view details

push time in a month

push eventPEZ/pez.github.io

Peter Strömberg

commit sha 67c59342a348254f5abc561a6be8e4246579e6b4

Title tautology

view details

push time in a month

push eventPEZ/pez.github.io

Peter Strömberg

commit sha 905920fd2bcca172ad915e655704c6daf26bb7d4

Add note about unsafe

view details

push time in a month

push eventPEZ/pez.github.io

Peter Strömberg

commit sha c95d2d248bf7762d9c4adf07a9162fdf9fa0a2d6

Add post about pandoc vercel hugo

view details

push time in a month

release BetterThanTomorrow/calva

v2.0.123

released time in a month

issue commentBetterThanTomorrow/calva

Can't jack-in when no project file is open

Thanks for the workaround, @brdloush ! Very interesting. Which OS are you on?

diegovdc

comment created time in a month

pull request commentBetterThanTomorrow/calva

Fix/enhance test runner

This is so needed. Thanks!

bpringe

comment created time in a month

issue commentBetterThanTomorrow/calva

Parsing project.clj eval error

Yes, sorry for late response. This is pragmatic. It will work and will not break anything.

We should parse these files using the token cursor, but for now, this change is super.

brandonstubbs

comment created time in a month

issue commentBetterThanTomorrow/calva

Fix issues with test runner

The intention is to run any tests defined in the metadata of the symbol. So with something like this:

(defn abs
  "The absolute value of a number."
   {:test (fn []
            (is (= (Math/abs 5) 5))
            (is (= (Math/abs -2) 2))
            (is (= (Math/abs 0) 0)))}
  [x]
  {:pre [(number? x)]}
  (if (pos? x)
    x
    (- x)))

Running the current test with the cursor inside this function should run those tests.

Indeed, if we could find the corresponding test defined in a deftest, and if we can support with-tests as well, that would be great. I think for the deftest case we would need two settings:

  1. How to find the namespace where the corresponding deftest could be
  2. How to find the deftest symbol

Probably both involve some regex. Maybe if CIDER does the right thing here, we could have a look at how it is done there.

bpringe

comment created time in a month

issue commentBetterThanTomorrow/calva

Fix issues with test runner

Yes, this would be great to improve in the ways you point at.

About looking for tests when it is just a def. Remember that we should be querying for tests when it is a defn.

bpringe

comment created time in a month

issue commentBetterThanTomorrow/calva

Code loses syntax colors when switching from one window to the other

Just so I understand this correctly:

all the letters are white

I can't see this in screenshots. However, what I do see is that the ignored form (prepended by #_) is not dimmed in the second one. Let me take this opportunity to clarify/explain some of what is going on in Calva when it concerns syntax highlighting.

There are two syntax highlighters in Calva:

  1. A tmLanguage based grammar, provided by Calva, but managed/executed by VS Code. (Let's call this HL1)
  2. A Calva provided and managed highlighter written in TypeScript. (HL2, but aka Calva Highlighter).

HL2 also replaces the VS Code built in active bracket matching, which used to be confusing for structural editing (I'm saying ”used to”, because this might have been fixed in VS Code, I am not sure).

In Calva most of the ”basic” highlighting, functions, keywords, symbols, line comments, etcetera, is performed by HL1. tmLanguage isn't very structural in the LISP sense, so rainbow brackets, rainbow guides, (comment ..), #_, and reader tags are hard to express in that language. At least I don't know how to do it. So those parts are handled by HL2/Calva Highlighter.

VS Code has some rocket science, super efficient, ways of optimising the highlighting it does using the tmLanguage grammar. It is really efficient, and can highlight huge files really fast. Even so, HL1 throws in the towel with lines larger than 20K characters (this is configurable in settings, iirc).

HL2 is a nice piece of engineering, but it starts to take noticeable time when working on large forms. This usually isn't a problem when opening a file, if it takes 150ms for HL2 to paint the rainbows, it's not a very big deal.

But HL2 also has that active bracket highlighting, which need a lot of context, and for performance reasons we gather that context in the same pass as we do the other HL2 work. If it takes 150ms to repaint the rainbows when scrolling by moving the cursor down (maybe by pressing the down key), that makes things be sluggish. Unbearably so if the file is 100K lines. Therefore we make an optimisation by trying to limit the highlighting to what is visible in the viewport. This is the optimisation that @bpringe mentions.

However, it is not what is causing the glitch you experience here. I've just used a lot of words to establish this, I realise, but I think this information should be available anyway, so ... 😀

I think that the reason you think this has not been the case before, @fabricioc8 , is that before version 2.0.109 of Calva, HL2 was only working on the active editor. So if you scrolled file1.cljc without making it active, that dimmed form would have stayed dimmed because HL2 wouldn't touch it again. But text being scrolled into view, that HL2 had not done any work on, would not get rainbows or dimming and such.

Calva 2.0.109 introduced a new output/repl window, that is designed to be left in view side by side with the code you work on. This meant that I needed to change Calva so that HL2 would work on a non-active editor as well. I guess what is happening in your repro there is that HL2 manages to clear its highlighting, but not apply a correct one.

So. Now I have convinced myself that this is a bug and not by design. 😄 (If it had been reported prior to 2.0.109 it would have been a feature request.).

What you can do to give us some more info here, @fabricioc8 , is to try and see if this happens with all your files, or if it is only for some. That would help us guess where the bug originates.

Thanks for reporting!

fabricioc8

comment created time in a month

pull request commentBetterThanTomorrow/calva

Fix/interrupted evaluation output

Awesome.

bpringe

comment created time in a month

release BetterThanTomorrow/calva

v2.0.122

released time in a month

push eventBetterThanTomorrow/calva-docs

Peter Strömberg

commit sha e642646b50050cb639d79941cac026ed34a8123d

Update sponsor page some more

view details

push time in a month

push eventBetterThanTomorrow/calva-docs

Peter Strömberg

commit sha 0d85a84cf2a3c9b388ed78a4f29d59f867f9b14d

Deployed b8a79dc with MkDocs version: 1.1

view details

push time in a month

issue commentBetterThanTomorrow/calva

Stack traces not being shown in the REPL output

Thanks for reporting! Yes, tried this and see that it worked in .119 and stopped working in .120. So checked the contents of .120 and now suspect this PR a lot: https://github.com/BetterThanTomorrow/calva/pull/739

Ir sure fixed its issue, but seems to do it in a very crude way. 🤦

I have a busy work day in front of me, so won't be able to tackle this until tomorrow I think. If someone else can, be my guest!

StarScape

comment created time in a month

pull request commentBetterThanTomorrow/calva

Adds validation for the existence of an activeTextEditor

Super awesome and clean. Like a surgeon. 😄

Thanks!

diegovdc

comment created time in a month

push eventBetterThanTomorrow/calva

Diego

commit sha cdddf275999f3c435d77c11c0fa914c1ee62bf97

Adds validation for the existence of an activeTextEditor

view details

Diego

commit sha 7db169666683315c71a596f79b5ab1eaf534e40a

Updates Changelog

view details

Peter Strömberg

commit sha 23f09e53e1033c599dbe61cfec5e7f97cf0a43cc

Merge pull request #757 from diegovdc/fix/calva-dir-path-in-ubuntu Adds validation for the existence of an activeTextEditor

view details

push time in a month

PR merged BetterThanTomorrow/calva

Adds validation for the existence of an activeTextEditor

<!-- ❤️ Thanks for filing a Pull Request on Calva! You are contributing to a better Clojure coding experience. ❤️ --> <!-- We use checklists in order to not forget about important lessons we and others have learnt along the way. -->

What has Changed?

<!-- Introduce the change(s) briefly here. Consider explaining why a particular change was implemented the way it was. If you have considered alternative ways to introduce the change, please elaborate a bit on that as well. -->

  • Adds validation for the existence of an activeTextEditor

<!-- Tell us what Github issue(s) your PR is fixing. Consider creating the issue if need be. --> Fixes #734

My Calva PR Checklist

<!-- Remove the checkboxes that do not apply, as Github reports how many are not ticked. If you want to add checkboxes, please do. -->

I have:

  • [x] Read How to Contribute.
  • [x] Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • [x] Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • [x] Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • [x] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [x] Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • [x] Tested the particular change
    • [ ] Figured if the change might have some side effects and tested those as well.
    • [ ] Smoke tested the extension as such.
  • [x] Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • [x] If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • [ ] If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • [x] Created the issue I am fixing/addressing, if it was not present.

The Calva Team PR Checklist:

<!-- Please read the list, since you'll get a better idea about what to expect by doing so. 😄 -->

Before merging we (at least one of us) have:

  • [ ] Made sure the PR is directed at the dev branch (unless reasons).
  • [ ] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • [ ] Read the source changes.
  • [ ] Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • [ ] Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • [ ] Tested the particular change
    • [ ] Figured if the change might have some side effects and tested those as well.
    • [ ] Smoke tested the extension as such.
  • [ ] If need be, had a chat within the team about particular changes.

Ping @pez, @kstehn, @cfehse, @bpringe

<!-- This is a nice book to read about the power of checklists: https://www.samuelthomasdavies.com/book-summaries/health-fitness/the-checklist-manifesto/ -->

+4 -2

0 comment

2 changed files

diegovdc

pr closed time in a month

push eventBetterThanTomorrow/calva

Brandon Ringe

commit sha c85ff6a6a9584dac83d94184fa9a3fdc5925da01

Bring on version: v2.0.122! [skip ci]

view details

Peter Strömberg

commit sha 93260bff2fde4703e86e56415705294edd78fab6

Add funding profile @bpringe

view details

Peter Strömberg

commit sha 2bf19101e118d6fd15d6ebbb235cf86606f24299

Merge branch 'dev'

view details

push time in a month

push eventBetterThanTomorrow/calva

Peter Strömberg

commit sha 93260bff2fde4703e86e56415705294edd78fab6

Add funding profile @bpringe

view details

push time in a month

release BetterThanTomorrow/calva

v2.0.121

released time in a month

push eventBetterThanTomorrow/calva

Maksim

commit sha 825ae88b9c519bebaae7d616731e92c1c509710e

Fix #700

view details

Peter Strömberg

commit sha 56a7bd703fc397eea00bb8ec1db5cd392f8c6ac8

Merge pull request #749 from glebovmaksim/fix-700-formatting Fix top level formatting (#700)

view details

Brandon Ringe

commit sha 334fc0eb845d8f57e95907387ccd65b185cdcbaa

Make rangeForCurentForm account for anonymous function open token better

view details

Brandon Ringe

commit sha 19b31c3508b7bc934c7f6c5c1d9ce4e00d90b81c

Fix #600

view details

Brandon Ringe

commit sha 1d36af83ce21238e804947826905a8068985204e

Merge remote-tracking branch 'origin/dev' into fix/expand_selection_anonymous_function

view details

Brandon Ringe

commit sha f758c14f8102d3e91e4f00ee41418c5b126d6f35

Fix equals and not equals to use tri-form

view details

Peter Strömberg

commit sha 1b6e323ffdafa38f14bdbd7850548d7bdb2f9660

Merge pull request #752 from BetterThanTomorrow/fix/expand_selection_anonymous_function Fix/expand selection anonymous function

view details

Peter Strömberg

commit sha 7d6132bf4f9a7369c4750122c22068d9a5cc6663

Merge branch 'dev' into fix/go_to_definition

view details

push time in a month

delete branch BetterThanTomorrow/calva

delete branch : fix/expand_selection_anonymous_function

delete time in a month

pull request commentBetterThanTomorrow/calva

Fix/expand selection anonymous function

Super!

bpringe

comment created time in a month

push eventBetterThanTomorrow/calva

Brandon Ringe

commit sha 334fc0eb845d8f57e95907387ccd65b185cdcbaa

Make rangeForCurentForm account for anonymous function open token better

view details

Brandon Ringe

commit sha 19b31c3508b7bc934c7f6c5c1d9ce4e00d90b81c

Fix #600

view details

Brandon Ringe

commit sha 1d36af83ce21238e804947826905a8068985204e

Merge remote-tracking branch 'origin/dev' into fix/expand_selection_anonymous_function

view details

Brandon Ringe

commit sha f758c14f8102d3e91e4f00ee41418c5b126d6f35

Fix equals and not equals to use tri-form

view details

Peter Strömberg

commit sha 1b6e323ffdafa38f14bdbd7850548d7bdb2f9660

Merge pull request #752 from BetterThanTomorrow/fix/expand_selection_anonymous_function Fix/expand selection anonymous function

view details

push time in a month

PR merged BetterThanTomorrow/calva

Fix/expand selection anonymous function

<!-- ❤️ Thanks for filing a Pull Request on Calva! You are contributing to a better Clojure coding experience. ❤️ --> <!-- We use checklists in order to not forget about important lessons we and others have learnt along the way. -->

What has Changed?

<!-- Introduce the change(s) briefly here. Consider explaining why a particular change was implemented the way it was. If you have considered alternative ways to introduce the change, please elaborate a bit on that as well. -->

  • Make rangeForCurrentForm account for anonymous function open tokens

<!-- Tell us what Github issue(s) your PR is fixing. Consider creating the issue if need be. --> Fixes #600

My Calva PR Checklist

<!-- Remove the checkboxes that do not apply, as Github reports how many are not ticked. If you want to add checkboxes, please do. -->

I have:

  • [x] Read How to Contribute.
  • [x] Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • [x] Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • [x] Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • [x] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [x] Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • [x] Tested the particular change
    • [x] Figured if the change might have some side effects and tested those as well.
    • [x] Smoke tested the extension as such.
  • [x] Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • [x] If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • [x] If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • [x] Created the issue I am fixing/addressing, if it was not present.

The Calva Team PR Checklist:

<!-- Please read the list, since you'll get a better idea about what to expect by doing so. 😄 -->

Before merging we (at least one of us) have:

  • [ ] Made sure the PR is directed at the dev branch (unless reasons).
  • [ ] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • [ ] Read the source changes.
  • [ ] Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • [ ] Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • [ ] Tested the particular change
    • [ ] Figured if the change might have some side effects and tested those as well.
    • [ ] Smoke tested the extension as such.
  • [ ] If need be, had a chat within the team about particular changes.

Ping @pez, @kstehn, @cfehse, @bpringe

<!-- This is a nice book to read about the power of checklists: https://www.samuelthomasdavies.com/book-summaries/health-fitness/the-checklist-manifesto/ -->

+19 -4

0 comment

3 changed files

bpringe

pr closed time in a month

Pull request review commentBetterThanTomorrow/calva

Fix/expand selection anonymous function

 export class LispTokenCursor extends TokenCursor {         beforeCursor.forwardWhitespace(true);         const readerCursor = beforeCursor.clone();         readerCursor.backwardThroughAnyReader();-        if (beforeCursor.offsetStart == offset || readerCursor.offsetStart != beforeCursor.offsetStart) {+        if ((offset >= beforeCursor.offsetStart && offset <= beforeCursor.offsetEnd) || readerCursor.offsetStart != beforeCursor.offsetStart) {

💯

bpringe

comment created time in a month

PullRequestReviewEvent

pull request commentBetterThanTomorrow/calva

Fix top level formatting (#700)

Awesome!

glebovmaksim

comment created time in a month

push eventBetterThanTomorrow/calva

Maksim

commit sha 825ae88b9c519bebaae7d616731e92c1c509710e

Fix #700

view details

Peter Strömberg

commit sha 56a7bd703fc397eea00bb8ec1db5cd392f8c6ac8

Merge pull request #749 from glebovmaksim/fix-700-formatting Fix top level formatting (#700)

view details

push time in a month

PR merged BetterThanTomorrow/calva

Fix top level formatting (#700)

<!-- ❤️ Thanks for filing a Pull Request on Calva! You are contributing to a better Clojure coding experience. ❤️ --> <!-- We use checklists in order to not forget about important lessons we and others have learnt along the way. -->

What has Changed?

<!-- Introduce the change(s) briefly here. Consider explaining why a particular change was implemented the way it was. If you have considered alternative ways to introduce the change, please elaborate a bit on that as well. -->

  • Disallow top level formatting in the output file (because it breaks the prompt).
  • Do not perform top level formatting after paredit command, only when tab is pressed on an empty line. Fixes this: Peek 2020-08-17 13-42

<!-- Tell us what Github issue(s) your PR is fixing. Consider creating the issue if need be. --> Fixes #700

My Calva PR Checklist

<!-- Remove the checkboxes that do not apply, as Github reports how many are not ticked. If you want to add checkboxes, please do. -->

I have:

  • [x] Read How to Contribute.
  • [x] Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • [x] Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • [x] Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • [x] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [x] Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • [x] Tested the particular change
    • [x] Figured if the change might have some side effects and tested those as well.
    • [x] Smoke tested the extension as such.
  • [x] Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • [x] If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • [x] If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • [x] Created the issue I am fixing/addressing, if it was not present.

The Calva Team PR Checklist:

<!-- Please read the list, since you'll get a better idea about what to expect by doing so. 😄 -->

Before merging we (at least one of us) have:

  • [ ] Made sure the PR is directed at the dev branch (unless reasons).
  • [ ] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • [ ] Read the source changes.
  • [ ] Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • [ ] Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • [ ] Tested the particular change
    • [ ] Figured if the change might have some side effects and tested those as well.
    • [ ] Smoke tested the extension as such.
  • [ ] If need be, had a chat within the team about particular changes.

Ping @pez, @kstehn, @cfehse, @bpringe

<!-- This is a nice book to read about the power of checklists: https://www.samuelthomasdavies.com/book-summaries/health-fitness/the-checklist-manifesto/ -->

+16 -11

2 comments

2 changed files

glebovmaksim

pr closed time in a month

pull request commentBetterThanTomorrow/calva

Fix top level formatting (#700)

Hello. Super duper awesome that you take on this horrible issue. Thanks!

Can you merge dev onto this, so that it can be tested integrated with the latest changes. I merged when testing it and know that it is pretty clean, I only had to:

  1. Fix the import of the output window, which in a recent refactoring was moved to ../../results-output/results-doc (relative to the format.ts module.)
  2. Fix the CHANGELOG which when I merged ended up with this change in the wrong place.

Thanks for refactoring the if/else structure of the formatPostion method. However, the test if (!onType && !outputWindow.isResultsDoc(doc)) is hard to unpack for me (I'm after an intense workday so my brain hardly works, but anyway). I'm trying to figure out if it can interfere with on-type formatting in regular Calva editors... Can itbee expressed in some other way? I would suggest something if it wasn't that I can't think right now.

If it is hard to express easier, we can merge this anyway. The on-type formatting from regular files should only end up here in the odd chance that someone has opted out of the new indent engine, and we will soon remove that possibility. And then I don't need to understand if it affects those editors, haha.

I get this in the debug console:

rejected promise not handled within 1 second: TypeError: Cannot read property 'includes' of undefined
extensionHostProcess.js:1007
stack trace: TypeError: Cannot read property 'includes' of undefined
    at formatPositionInfo (/Users/pez/Projects/calva/src/calva-fmt/src/format.ts:53:26)
    at Object.formatPosition (/Users/pez/Projects/calva/src/calva-fmt/src/format.ts:76:25)
    at /Users/pez/Projects/calva/src/doc-mirror/index.ts:40:38
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:85:5)

I don't think it has been there before, but I could be wrong. Anyway, can you see if you understand why it happens? Or, rather, confirm if it is from this change or not, and if it is, fix it.

Again, thanks! So happy that you're engaging in making Calva better!

glebovmaksim

comment created time in a month

push eventBetterThanTomorrow/calva-docs

Peter Strömberg

commit sha c3026660dbfed3b0c6e3266e327953205ce2a984

Deployed 238f788 with MkDocs version: 1.1

view details

push time in a month

push eventBetterThanTomorrow/calva-docs

Peter Strömberg

commit sha 238f78802b1b2eef8fae0f87bf9668b6eda6f95e

Clearer about myLeinProfiles

view details

push time in a month

push eventBetterThanTomorrow/calva-docs

Peter Strömberg

commit sha dccddbe69314d877b1a3af1cc5376d7443e23339

Output goes to output window

view details

Peter Strömberg

commit sha 26445a286c1d55e4b41a6d62be168d7bb77d7b2c

Restructure main menu some

view details

Peter Strömberg

commit sha 17109b6e7f55ed62267609efbe5be5db66db8476

Less muddled about selection commands

view details

push time in a month

release BetterThanTomorrow/calva

v2.0.120

released time in a month

issue commentBetterThanTomorrow/calva

Post 2.0.109 Repl: entering text and evaluating

That sounds super weird. Can you type normally in regular .clj files, but not in the REPL window? (Which is just a regular file, so that would be super mysterious.)

It does certainly not sound like you are doing something wrong. But maybe some extension you have is doing something wrong. What can you tell us about your setup? Windows/Mac/Linux, what version of VS Code? What more extensions could be in play?

thelazydogsback

comment created time in 2 months

pull request commentBetterThanTomorrow/calva

fix #740 - Stop overriding vs code's default esc keybinding

Thanks!!!

crispinb

comment created time in 2 months

push eventBetterThanTomorrow/calva

Crispin Bennett

commit sha 8c930bd0514bce574b2b9cda2c13948e04648d50

Stop overriding vs code's default esc keybinding - as per [Calva's ESC keybinding overrides VS Code's (useful) default](https://github.com/BetterThanTomorrow/calva/issues/740)

view details

Peter Strömberg

commit sha a4fabeb5e8024fcb5f27047cbe48e6675c133d7d

Merge pull request #741 from crispinb/dev fix #740 - Stop overriding vs code's default esc keybinding

view details

push time in 2 months

PR merged BetterThanTomorrow/calva

fix #740 - Stop overriding vs code's default esc keybinding

<!-- ❤️ Thanks for filing a Pull Request on Calva! You are contributing to a better Clojure coding experience. ❤️ --> <!-- We use checklists in order to not forget about important lessons we and others have learnt along the way. -->

What has Changed?

<!-- Introduce the change(s) briefly here. Consider explaining why a particular change was implemented the way it was. If you have considered alternative ways to introduce the change, please elaborate a bit on that as well. -->

  • just a quick change to keybinds in package.json. I don't think there's another way to do it

<!-- Tell us what Github issue(s) your PR is fixing. Consider creating the issue if need be. --> Fixes #740 https://github.com/BetterThanTomorrow/calva/issues/740

My Calva PR Checklist

<!-- Remove the checkboxes that do not apply, as Github reports how many are not ticked. If you want to add checkboxes, please do. -->

I have:

  • [x] Read How to Contribute.
  • [x] Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • [x] Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • [x] Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • [x] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
    • I think esc operates similarly everywhere from memory, but don't currently have a non-linux box to check on
  • [ ] Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • [ ] Tested the particular change
    • [ ] Figured if the change might have some side effects and tested those as well.
    • [ ] Smoke tested the extension as such.
  • [x] Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • [x] If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • [ ] If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • [ ] Created the issue I am fixing/addressing, if it was not present.

The Calva Team PR Checklist:

<!-- Please read the list, since you'll get a better idea about what to expect by doing so. 😄 -->

Before merging we (at least one of us) have:

  • [ ] Made sure the PR is directed at the dev branch (unless reasons).
  • [ ] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • [ ] Read the source changes.
  • [ ] Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • [ ] Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • [ ] Tested the particular change
    • [ ] Figured if the change might have some side effects and tested those as well.
    • [ ] Smoke tested the extension as such.
  • [ ] If need be, had a chat within the team about particular changes.

Ping @pez, @kstehn, @cfehse, @bpringe

<!-- This is a nice book to read about the power of checklists: https://www.samuelthomasdavies.com/book-summaries/health-fitness/the-checklist-manifesto/ -->

+4 -3

0 comment

3 changed files

crispinb

pr closed time in 2 months

issue commentBetterThanTomorrow/calva

Calva's ESC keybinding overrides VS Code's (useful) default

This should be changed in Calva (PR welcome).

Meanwhile you can fix it for your own setup by changing the when clause for Calva's ESC key binding to:

editorTextFocus && !editorHasMultipleSelections && !editorHasSelection && !editorReadOnly && !hasOtherSuggestions && !parameterHintsVisible && !selectionAnchorSet && !suggestWidgetVisible && editorLangId == 'clojure'
crispinb

comment created time in 2 months

delete branch BetterThanTomorrow/calva

delete branch : fix/738-interrupt

delete time in 2 months

push eventBetterThanTomorrow/calva

Peter Strömberg

commit sha 154fe409e339e7ab7c8e703e2e1c0f1db4671d06

Stop trying to print stacktrace when there is none Also: - Do not print stdout as being stderr (venatius/ultra must handle its own bugs) - Print out-of-band stdout to output window (not Calva says) Fixes #738

view details

Peter Strömberg

commit sha 0c6e33060af2f46e2f0f71779ef12b4728f1f83d

Merge branch 'dev' into fix/738-interrupt

view details

Peter Strömberg

commit sha 42f7ee77e9bffb52b547e916a85b62c63ca28f4f

Merge pull request #739 from BetterThanTomorrow/fix/738-interrupt Stop trying to print stacktrace when there is none

view details

push time in 2 months

PR merged BetterThanTomorrow/calva

Stop trying to print stacktrace when there is none

Also:

  • Do not print stdout as being stderr (venatius/ultra must handle its own bugs)
  • Print out-of-band stdout to output window (not Calva says)

Fixes #738

My Calva PR Checklist

I have:

  • [x] Read How to Contribute.
  • [x] Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • [x] Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • [x] Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • [x] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • [x] Tested the particular change
    • [x] Figured if the change might have some side effects and tested those as well.
    • [x] Smoke tested the extension as such.
  • [x] Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • [x] Created the issue I am fixing/addressing, if it was not present.

The Calva Team PR Checklist:

<!-- Please read the list, since you'll get a better idea about what to expect by doing so. 😄 -->

Before merging we (at least one of us) have:

  • [ ] Made sure the PR is directed at the dev branch (unless reasons).
  • [ ] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • [ ] Read the source changes.
  • [ ] Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • [ ] Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • [ ] Tested the particular change
    • [ ] Figured if the change might have some side effects and tested those as well.
    • [ ] Smoke tested the extension as such.
  • [ ] If need be, had a chat within the team about particular changes.

Ping @pez, @kstehn, @cfehse, @bpringe

<!-- This is a nice book to read about the power of checklists: https://www.samuelthomasdavies.com/book-summaries/health-fitness/the-checklist-manifesto/ -->

+12 -16

0 comment

3 changed files

PEZ

pr closed time in 2 months

push eventBetterThanTomorrow/calva

Peter Strömberg

commit sha ac03bcd58f0afa0a3ba52d17b6627157759a1448

Move ns and session utils to new module

view details

Peter Strömberg

commit sha 64b917d24ce830d094d2299f623b146a6feef82a

Merge branch 'dev' into wip/terminal-jack-in

view details

push time in 2 months

push eventBetterThanTomorrow/calva

Peter Strömberg

commit sha ac03bcd58f0afa0a3ba52d17b6627157759a1448

Move ns and session utils to new module

view details

Peter Strömberg

commit sha 0c6e33060af2f46e2f0f71779ef12b4728f1f83d

Merge branch 'dev' into fix/738-interrupt

view details

push time in 2 months

push eventBetterThanTomorrow/calva

Peter Strömberg

commit sha ac03bcd58f0afa0a3ba52d17b6627157759a1448

Move ns and session utils to new module

view details

push time in 2 months

issue commentBetterThanTomorrow/calva

Backspace is not working properly in the output window

Ah, yes, that makes sense! I was looking at the wrong place...

So, many paredit commands finish with formatting and probably we (implicitly or explicitly) tell the formatter to trim trailing whitespace.

Iirc there is a special case for when formatting is performed on the top level. Or, rather, for selecting what is to be formatted. A check there for if it is the output file could maybe stop this madness. Also trimming trailing whitespace is generally a bad idea in this window.

PR is super welcome. Please don't hesitate to ask us for help.

glebovmaksim

comment created time in 2 months

push eventBetterThanTomorrow/calva-docs

Peter Strömberg

commit sha 0a051a21d5fd0e3d7fd3f980702b18a2fe611526

Deployed 6386857 with MkDocs version: 1.1

view details

push time in 2 months

push eventBetterThanTomorrow/calva-docs

Peter Strömberg

commit sha 6386857af31b55792a99226cf9123006412ca04e

Update w/ old repl window replaced by new one

view details

push time in 2 months

push eventBetterThanTomorrow/calva

Brandon

commit sha bdd4028b5f47ef89cdf0fbca40fabfbcd680ecd4

Merge remote-tracking branch 'origin/dev'

view details

Peter

commit sha dbf793b5409e66bc70fa978cc912b4f8cd02a40a

Merge branch 'master' of github.com:BetterThanTomorrow/calva

view details

Peter

commit sha 7e18675fe32562e94edfb1f8b561b6baee0b6fae

Merge branch 'dev'

view details

Peter

commit sha 148856ef73c95f27cf873bcc8c1fb37fb37e3e9e

Merge branch 'dev'

view details

Peter

commit sha 133ad6c62f2d360d6bb54c66dfec1d3e58187615

Merge branch 'dev'

view details

Brandon Ringe

commit sha 69c26b0c661f953d47d8e9705568d89837ce3baf

Merge remote-tracking branch 'origin/dev'

view details

Peter

commit sha 9e22c12d2b863aa9ec93ac46b7d57b5bac75e10f

Merge branch 'dev'

view details

Peter

commit sha 64d7b0020293fa245f1915887f7b0e99b99f5048

Merge branch 'master' of github.com:BetterThanTomorrow/calva

view details

Peter

commit sha 2bc2d3e5bd10cab63c65fcd69afed7c01899132d

Merge branch 'dev'

view details

Peter Strömberg

commit sha 25be193491b4b5d70c18b608825cc0480cd52e8a

Merge branch 'dev'

view details

Brandon Ringe

commit sha 36533ff76ec50dda76de65bec01075e2863aa09a

Merge remote-tracking branch 'origin/dev'

view details

Peter Strömberg

commit sha 5a98e90732beb6bfb7b31be892f2e35d995e54bd

Merge branch 'dev'

view details

Peter Strömberg

commit sha 25c5749b9a8a6c4397ed36b85d6f43f466ecc65a

Add Calva Gold Fans sponsor, Liftoff! 🚀 [skip ci]

view details

Peter Strömberg

commit sha 8b164ee78504b5f7646b308e0e77d3f39d27a21e

Add mention about calva.io also displaying gold sponsors [skip ci]

view details

Peter Strömberg

commit sha f5672a866e4ec8a4ee2133201dd2839723ecdfb9

Merge branch 'dev'

view details

Peter Strömberg

commit sha 8cb97400db009549630dda67364046fb2eea4a82

Merge branch 'dev'

view details

Brandon Ringe

commit sha 9eb756193a4afde4b50d589b4573acbc9ed4f363

Merge branch 'dev'

view details

Peter Strömberg

commit sha b578206d924cce6b755eb778b6337602555c58d1

Expose crash with lexing hashes Addressing #667 The tests are disabled in order for the suite to run at all.

view details

Peter Strömberg

commit sha 9b5c86bf8cb8e1c4c1dd3c787d5f52f7163355ca

Stop tokenizing reader tags as part of forms - This to avoid regexps that produce a catastrophic backreference in node's regexp engine. - Works because we already let the cursor navigate past reader tags Fixes #667

view details

Peter Strömberg

commit sha c59e2ea3a690eb7f35abdf3e904240c3c3da3b19

Update changelog for v2.0.104 [skip ci]

view details

push time in 2 months

PR opened BetterThanTomorrow/calva

Stop trying to print stacktrace when there is none

Also:

  • Do not print stdout as being stderr (venatius/ultra must handle its own bugs)
  • Print out-of-band stdout to output window (not Calva says)

Fixes #738

My Calva PR Checklist

I have:

  • [x] Read How to Contribute.
  • [x] Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • [x] Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • [x] Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • [x] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • [x] Tested the particular change
    • [x] Figured if the change might have some side effects and tested those as well.
    • [x] Smoke tested the extension as such.
  • [x] Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • [x] Created the issue I am fixing/addressing, if it was not present.

The Calva Team PR Checklist:

<!-- Please read the list, since you'll get a better idea about what to expect by doing so. 😄 -->

Before merging we (at least one of us) have:

  • [ ] Made sure the PR is directed at the dev branch (unless reasons).
  • [ ] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • [ ] Read the source changes.
  • [ ] Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • [ ] Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • [ ] Tested the particular change
    • [ ] Figured if the change might have some side effects and tested those as well.
    • [ ] Smoke tested the extension as such.
  • [ ] If need be, had a chat within the team about particular changes.

Ping @pez, @kstehn, @cfehse, @bpringe

<!-- This is a nice book to read about the power of checklists: https://www.samuelthomasdavies.com/book-summaries/health-fitness/the-checklist-manifesto/ -->

+12 -16

0 comment

3 changed files

pr created time in 2 months

create barnchBetterThanTomorrow/calva

branch : fix/738-interrupt

created branch time in 2 months

push eventBetterThanTomorrow/calva

Peter Strömberg

commit sha 78858fc71c330e4b55f65c2d91b2002699b597e1

Delete lingering webview file

view details

push time in 2 months

issue openedBetterThanTomorrow/calva

Interrupting evaluations produces extra output and no prompt

When interrupting a running evaluation there is no prompt printed in the output window. This indicates that something goes wrong before the prompt is printed.

Also, when interruption something like this:

  (loop [i 100]
    (println i)
    (Thread/sleep 75)
    (if (zero? i)
      i
      (recur (dec i))))

The output is printed once again, only as single line comments.

created time in 2 months

issue commentBetterThanTomorrow/calva

Hover over result not working for inline evaluation

I didn't like the implementation and hurried to remove it once we had the output window displaying and making it easy to copy the results.

It was also my impression that this was not a very used feature. Which seems to have been a faulty assumption. You are not the first one to ask for it, if I put out that way.

We are considering if there is a more proper way to implement it, and even if we can live with the previous implementation.

Let's see if this issue attracts the fans of the feature. That would certainly help in helping us prioritize and decide which way to go. Thanks for posting it!

Yunfeng-Song

comment created time in 2 months

issue commentBetterThanTomorrow/calva

Reintegrate old REPL/add easy "previous line" functionality

It is because it is to much of a burden to maintain it. There is some discussion about it here: https://clojureverse.org/t/calva-summer-of-bugs-2020/6303

madisoncfallin

comment created time in 2 months

issue commentBetterThanTomorrow/calva

Reintegrate old REPL/add easy "previous line" functionality

You are super welcome to provide a PR with this, @gustavobertolino .

madisoncfallin

comment created time in 2 months

push eventBetterThanTomorrow/calva

Peter Strömberg

commit sha f4c174e832524ae8f4e0835725ba361b18481420

Bring on v2.0.120

view details

push time in 2 months

push eventBetterThanTomorrow/calva

Peter Strömberg

commit sha 7309ef580a303acb3b1d06ea562c4e09d96593bb

Prepare for v2.0.119

view details

Peter Strömberg

commit sha b156ea5996551bb9c5f3d855b6771eaf38fa7e92

Only pre-eval in-ns if ns is not already set Fixes #724 (again)

view details

Peter Strömberg

commit sha 90bbdab6aa35a42adf5a53d4d4a615f4acfbe2ac

Merge pull request #735 from BetterThanTomorrow/fix/724-dynamic-eval-vars Fix dynamic eval vars in output/repl window

view details

Peter Strömberg

commit sha db449d690e8032c4bfedc22c4fc54c344c5a95e9

Update changelog for v2.0.119 [skip ci]

view details

push time in 2 months

issue closedBetterThanTomorrow/calva

Accessing recent results (*1, *2, *3) does not work

E.g. this can't be reproduced in new REPL window.

closed time in 2 months

glebovmaksim

release BetterThanTomorrow/calva

v2.0.119

released time in 2 months

created tagBetterThanTomorrow/calva

tagv2.0.119

Clojure & ClojureScript Interactive Programming for VS Code

created time in 2 months

push eventBetterThanTomorrow/calva

Peter Strömberg

commit sha db449d690e8032c4bfedc22c4fc54c344c5a95e9

Update changelog for v2.0.119 [skip ci]

view details

push time in 2 months

delete branch BetterThanTomorrow/calva

delete branch : fix/724-dynamic-eval-vars

delete time in 2 months

push eventBetterThanTomorrow/calva

Peter Strömberg

commit sha b156ea5996551bb9c5f3d855b6771eaf38fa7e92

Only pre-eval in-ns if ns is not already set Fixes #724 (again)

view details

Peter Strömberg

commit sha 90bbdab6aa35a42adf5a53d4d4a615f4acfbe2ac

Merge pull request #735 from BetterThanTomorrow/fix/724-dynamic-eval-vars Fix dynamic eval vars in output/repl window

view details

push time in 2 months

PR merged BetterThanTomorrow/calva

Fix dynamic eval vars in output/repl window

What has Changed?

  • Check if the the current ns of the repl is different from what the form to be evaluated should be using before evaluating (in-ns ...).
  • Add pre-eval (conditional) to the commands for setting the output window ns and copying over forms to the repl window.

Fixes #724

My Calva PR Checklist

I have:

  • [x] Read How to Contribute.
  • [x] Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • [x] Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • [x] Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • [x] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • [x] Tested the particular change
    • [x] Figured if the change might have some side effects and tested those as well.
    • [x] Smoke tested the extension as such.
  • [x] Referenced the issue I am fixing/addressing in a commit message for the pull request.

The Calva Team PR Checklist:

<!-- Please read the list, since you'll get a better idea about what to expect by doing so. 😄 -->

Before merging we (at least one of us) have:

  • [ ] Made sure the PR is directed at the dev branch (unless reasons).
  • [ ] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • [ ] Read the source changes.
  • [ ] Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • [ ] Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • [ ] Tested the particular change
    • [ ] Figured if the change might have some side effects and tested those as well.
    • [ ] Smoke tested the extension as such.
  • [ ] If need be, had a chat within the team about particular changes.

Ping @pez, @kstehn, @cfehse, @bpringe

<!-- This is a nice book to read about the power of checklists: https://www.samuelthomasdavies.com/book-summaries/health-fitness/the-checklist-manifesto/ -->

+35 -26

0 comment

3 changed files

PEZ

pr closed time in 2 months

PR opened BetterThanTomorrow/calva

Fix dynamic eval vars in output/repl window

What has Changed?

  • Check if the the current ns of the repl is different from what the form to be evaluated should be using before evaluating (in-ns ...).
  • Add pre-eval (conditional) to the commands for setting the output window ns and copying over forms to the repl window.

Fixes #724

My Calva PR Checklist

I have:

  • [x] Read How to Contribute.
  • [x] Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • [x] Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • [x] Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • [x] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • [x] Tested the particular change
    • [x] Figured if the change might have some side effects and tested those as well.
    • [x] Smoke tested the extension as such.
  • [x] Referenced the issue I am fixing/addressing in a commit message for the pull request.

The Calva Team PR Checklist:

<!-- Please read the list, since you'll get a better idea about what to expect by doing so. 😄 -->

Before merging we (at least one of us) have:

  • [ ] Made sure the PR is directed at the dev branch (unless reasons).
  • [ ] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • [ ] Read the source changes.
  • [ ] Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • [ ] Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • [ ] Tested the particular change
    • [ ] Figured if the change might have some side effects and tested those as well.
    • [ ] Smoke tested the extension as such.
  • [ ] If need be, had a chat within the team about particular changes.

Ping @pez, @kstehn, @cfehse, @bpringe

<!-- This is a nice book to read about the power of checklists: https://www.samuelthomasdavies.com/book-summaries/health-fitness/the-checklist-manifesto/ -->

+35 -26

0 comment

3 changed files

pr created time in 2 months

create barnchBetterThanTomorrow/calva

branch : fix/724-dynamic-eval-vars

created branch time in 2 months

IssuesEvent

issue commentBetterThanTomorrow/calva

Accessing recent results (*1, *2, *3) does not work

So, this now works for cljs, but not for clj. Reopening. And I think I know how to fix it reliably.

glebovmaksim

comment created time in 2 months

issue commentBetterThanTomorrow/calva

Include material from clojuredocs.org in function documentation

I think we can do that. How is this dialog brought up in Cursive?

crispinb

comment created time in 2 months

issue commentBetterThanTomorrow/calva

Cannot start Figwheel Main repl

I agree it is unfortunate that people who had relief on this now get burnt when it suddenly stops working. But it should never have been like it was. It caused problems for people upgrading/using a particular version of Figwheel Main when Calva did its hard override.

alzadude

comment created time in 2 months

IssuesEvent

issue commentBetterThanTomorrow/calva

Can't jack-in to a fresh clj-new project

Actually you shouldn't have to open a file in the project. I'm reopening, so that we keep this on our radar, and so that people find your workaround. Thanks for reporting!

diegovdc

comment created time in 2 months

more